Module: kamailio
Branch: master
Commit: 2dbaa727a38e29da0f887fa5d0d8d20392839f9b
URL: https://github.com/kamailio/kamailio/commit/2dbaa727a38e29da0f887fa5d0d8d20…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-07-05T07:04:46Z
tm: remove obselete comment, add clarification for reply_wait mode 2
---
Modified: src/modules/tm/rpc_uac.c
---
Diff: https://github.com/kamailio/kamailio/commit/2dbaa727a38e29da0f887fa5d0d8d20…
Patch: https://github.com/kamailio/kamailio/commit/2dbaa727a38e29da0f887fa5d0d8d20…
---
diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c
index ce22b6121c1..d461d123a13 100644
--- a/src/modules/tm/rpc_uac.c
+++ b/src/modules/tm/rpc_uac.c
@@ -626,12 +626,12 @@ static void rpc_uac_block_callback(
* only if reply_wait is set to 1. Otherwise the rpc reply will be sent
* immediately and it will be success if the parameters were ok and t_uac did
* not report any error.
- * Note: reply waiting (reply_wait==1) is not yet supported.
* @param rpc - rpc handle
* @param c - rpc current context
* @param reply_wait - if 1 do not generate a rpc reply until final response
* for the transaction arrives, if 0 immediately send
- * an rpc reply (see above).
+ * an rpc reply (see above). If 2 blocking wait until
+ * final response for the transaction arrives.
*/
static void rpc_t_uac(rpc_t *rpc, void *c, int reply_wait)
{
### Description
The dbmode behavior was modified (see the commit reference bellow) and does not clearly align with the documentation anymore, I still need the feature when we can persist htable records that were inserted at runtime.
In fact I do not understand that value of writing back only records that where loaded from the DB, this seems equivalent to dbmode 0 (if the db is not altered) ?
Maybe you can help me understand why we the change is needed @miconda ?
```
dbmode - if set to 1, the content of hash table is written to database table when the SIP server is stopped (i.e., ensure persistency over restarts). Default value is 0 (no write back to db table).
```
```
commit b1fa63b1547fc5af6cc1e97db42ea76db1bf927b
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Wed Apr 13 13:11:30 2022 +0200
htable: track when records were successfully loaded from database
- write back only in such case
diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c
index 00023e7153..f212600e21 100644
--- a/src/modules/htable/ht_api.c
+++ b/src/modules/htable/ht_api.c
@@ -1099,7 +1099,7 @@ int ht_db_sync_tables(void)
ht = _ht_root;
while(ht)
{
- if(ht->dbtable.len>0 && ht->dbmode!=0 && ht->ncols==0)
+ if(ht->dbtable.len>0 && ht->dbmode!=0 && ht->dbload!=0 && ht->ncols==0)
{
LM_DBG("sync db table [%.*s] from ht [%.*s]\n",
ht->dbtable.len, ht->dbtable.s,
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3422
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3422(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The documentation shows a wrong example for the modparam "method_filter".
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3505
-- Commit Summary --
* xlog: fix docs example for modparam methods_filter
-- File Changes --
M src/modules/xlog/doc/xlog_admin.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3505.patchhttps://github.com/kamailio/kamailio/pull/3505.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3505
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3505(a)github.com>
(adding sr-dev)
Hello,
I only had a quick look to the code, but at least the sl module stats seems to look fine:
int sl_filter_ACK(struct sip_msg *msg, unsigned int flags, void *bar)
[...]
if(memcmp(tag_str->s, sl_tag.s, sl_tag.len) == 0) {
LM_DBG("SL local ACK found -> dropping it!\n");
update_sl_filtered_acks();
void update_sl_filtered_acks(void)
{
(*sl_stats)[process_no].filtered_acks++;
}
unsigned long sl_stats_rcv_acks(void)
{
sl_stats_update();
return _sl_stats_total.filtered_acks;
}
Are you not seeing the increase in the received_ACKs statistics?
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>
From: Kaufman <bkaufman(a)bcmone.com>
Sent: Mittwoch, 28. Juni 2023 01:52
To: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org>
Subject: [SR-Users] SL absorbed ACK is counted as dropped by core.drop_requests
Just checking to see if this is the designed behavior. The SL module will attempt to match ACKs for stateless replies and handle them (absorb them?).
The question I have is that it looks as though this ACK gets counted as dropped by the core.drop_requests from the KEX module. Tested using this config:
#!KAMAILIO
loadmodule "pv"
loadmodule "sl"
loadmodule "xlog"
loadmodule "kex"
loadmodule "corex"
loadmodule "ctl"
modparam("sl", "bind_tm", 0)
route {
xinfo("[$ci] $rm Request. Src:[$si:$sp] RURI:[$ru] To:[$tu] From:[$fu]\n");
sl_send_reply("404", "Not Found");
}
event_route[sl:filtered-ack] {
xnotice("sl:filtered-ack ACK [$ci] to local reply absorbed\n");
}
Then validate by kamcmd stats.fetch core:drop_requests
Is this the designed and "correct" behavior?
Kaufman
### Description
Kamailio receives call and changes originating number to anonymous using uac_replace_from() with auto restore and password. Info is stored in vsf parameter of Record-Route
Original From Uri is sip:123456789@1.1.1.1:5060
New From Uri is "sip:[anonymous@anonymous.invalid](mailto:anonymous@anonymous.invalid)"
When originating IP sends an ACK after the 200 OK, it sends a different IP on the From header
From Uri received on the ACK sent to Kamailio : sip:123456789@2.2.2.2:5070
From Uri sent by kamailio after restore : sip:[anonymous@bnlnzmlu4s.hnv2a](mailto:anonymous@bnlnzmlu4s.hnv2a)'_lid
The Uri sent by Kamailio is variable and it's not always the same.
#### Reproduction
I've annexed to this issue two call XMS (Outgoing and Incoming) that creates this scenario.
Kamailio is configured to change the From URI to sip:[anonymous@anonymous.invalid](mailto:anonymous@anonymous.invalid) with uac_replace_from() with auto restore and password
In order to rule out problems in the rest of my code i've used the base kamailio.cfg with minimum changes as possible and added this code right before PSTN being called :
```
$var(New_From_uri) = "sip:anonymous@anonymous.invalid" ;
uac_replace_from("","$var(New_From_uri)");
```
I have the following configurations for uac :
```
loadmodule "uac.so"
modparam("uac","restore_mode","auto")
modparam("uac","restore_from_avp","$avp(vsf)")
modparam("uac","restore_to_avp","$avp(vst)")
modparam("uac","restore_passwd","password123")
modparam("rr", "append_fromtag", 1)
```
### Additional Information
```
version: kamailio 5.7.1 (x86_64/linux) 4238e4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 4238e4
compiled on 12:39:30 Jun 29 2023 with gcc 4.8.5
```
* **Operating System**:
CentOS7
Please let me know if i can be of any help on testing.
Cheers
[Originating_XML.txt](https://github.com/kamailio/kamailio/files/11914634/Or…
[Terminating_XML.txt](https://github.com/kamailio/kamailio/files/11914635/Te…
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3500
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3500(a)github.com>
### Description
Kamailio receives call and changes originating number to anonymous using uac_replace_from() with auto restore and password. Info is stored in vsf parameter of Record-Route
Original From Uri is sip:123456789@1.1.1.1:5060
New From Uri is "sip:anonymous@anonymous.invalid"
When originating IP sends an ACK after the 200 OK, it sends a different IP on the From header
From Uri received on the ACK sent to Kamailio : sip:123456789@2.2.2.2:5070
From Uri sent by kamailio after restore : sip:anonymous@bnlnzmlu4s.hnv2a'_lid
The Uri sent by Kamailio is variable and it's not always the same.
#### Reproduction
I've annexed to this issue two call XMS (Outgoing and Incoming) that creates this scenario.
Kamailio is configured to change the From URI to sip:anonymous@anonymous.invalid with uac_replace_from() with auto restore and password
### Additional Information
version: kamailio 5.2.1 (x86_64/linux) 947769
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 16MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 947769
compiled on 11:41:21 Apr 5 2022 with gcc 4.8.5
* **Operating System**:
CentOS 7
```
[Originating_XML.txt](https://github.com/kamailio/kamailio/files/11898066/Or…
[Terminating_XML.txt](https://github.com/kamailio/kamailio/files/11898067/Te…
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3498
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3498(a)github.com>
Hello,
Kamailio SIP Server v5.7.1 stable release is out.
This is a maintenance release of the latest stable branch, 5.7, that
includes fixes since the release of v5.7.0. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.7.x. Deployments running previous v5.7.x
versions are strongly recommended to be upgraded to v5.7.1.
For more details about version 5.7.1 (including links and guidelines to
download the tarball or from GIT repository), visit:
* https://www.kamailio.org/w/2023/06/kamailio-v5-7-1-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - www.kamailioworld.com