- sr-dev - kamailio.org

git:master:5335f6d5: cfgutils: typos
by Daniel-Constantin Mierla 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 5335f6d5a80f804257a2303f05a2b2c5edf02322 URL: https://github.com/kamailio/kamailio/commit/5335f6d5a80f804257a2303f05a2b2c… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 cfgutils: typos --- Modified: src/modules/cfgutils/cfgutils.c Modified: src/modules/cfgutils/doc/cfgutils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5335f6d5a80f804257a2303f05a2b2c… Patch: https://github.com/kamailio/kamailio/commit/5335f6d5a80f804257a2303f05a2b2c… --- diff --git a/src/modules/cfgutils/cfgutils.c b/src/modules/cfgutils/cfgutils.c index bf4b0680bbc..740d26f4b46 100644 --- a/src/modules/cfgutils/cfgutils.c +++ b/src/modules/cfgutils/cfgutils.c @@ -333,7 +333,7 @@ void cfgutils_rpc_get_gflags(rpc_t* rpc, void* ctx) flags = *gflags; if (rpc->rpl_printf(ctx, "0x%X (%u)", flags, flags) < 0) { - rpc->fault(ctx, 500, "Faiure building the response"); + rpc->fault(ctx, 500, "Failure building the response"); return; } } @@ -365,7 +365,7 @@ void cfgutils_rpc_get_prob(rpc_t* rpc, void* ctx) { if (rpc->rpl_printf(ctx, "actual probability: %u percent", (*probability)) < 0) { - rpc->fault(ctx, 500, "Faiure building the response"); + rpc->fault(ctx, 500, "Failure building the response"); return; } } @@ -374,7 +374,7 @@ void cfgutils_rpc_get_hash(rpc_t* rpc, void* ctx) { if (rpc->rpl_printf(ctx, "%.*s", MD5_LEN, config_hash) < 0) { - rpc->fault(ctx, 500, "Faiure building the response"); + rpc->fault(ctx, 500, "Failure building the response"); return; } } @@ -451,12 +451,12 @@ void cfgutils_rpc_check_hash(rpc_t* rpc, void* ctx) if (strncmp(config_hash, tmp, MD5_LEN) == 0) { if (rpc->rpl_printf(ctx, "Identical hash") < 0) { - rpc->fault(ctx, 500, "Faiure building the response"); + rpc->fault(ctx, 500, "Failure building the response"); return; } } else { if (rpc->rpl_printf(ctx, "Different hash") < 0) { - rpc->fault(ctx, 500, "Faiure building the response"); + rpc->fault(ctx, 500, "Failure building the response"); return; } } @@ -976,17 +976,17 @@ static int w_core_hash(struct sip_msg *msg, char *p1, char *p2, char *p3) if (fixup_get_svalue(msg, (gparam_p) p1, &s1) != 0) { - LM_ERR("invalid s1 paramerer\n"); + LM_ERR("invalid s1 parameter\n"); return -1; } if (fixup_get_svalue(msg, (gparam_p) p2, &s2) != 0) { - LM_ERR("invalid s2 paramerer\n"); + LM_ERR("invalid s2 parameter\n"); return -1; } if (fixup_get_ivalue(msg, (gparam_p) p3, &size) != 0) { - LM_ERR("invalid size paramerer\n"); + LM_ERR("invalid size parameter\n"); return -1; } diff --git a/src/modules/cfgutils/doc/cfgutils_admin.xml b/src/modules/cfgutils/doc/cfgutils_admin.xml index 23afd740535..41ebc0435f2 100644 --- a/src/modules/cfgutils/doc/cfgutils_admin.xml +++ b/src/modules/cfgutils/doc/cfgutils_admin.xml @@ -80,7 +80,7 @@ <section> <title>Dependencies</title> <para> - The module depends on the following modules (in the other words the + The module depends on the following modules (in other words the listed modules must be loaded before this module): <itemizedlist> <listitem>

1 0

git:master:326ad479: ims_registrar_pcscf: typo
by Daniel-Constantin Mierla 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 326ad479fb9e09f4f3a177606f2b5dcc09fbbd62 URL: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 ims_registrar_pcscf: typo --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… Patch: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 88c0c008a8e..db9b7e73877 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -254,7 +254,7 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma } /** - * Save contact based on REGISTER request. this will be a pending save, until we receive response + * Save contact based on REGISTER request. This will be a pending save, until we receive response * from SCSCF. If no response after pending_timeout seconds, the contacts is removed. Can only be used from REQUEST ROUTE */ int save_pending(struct sip_msg* _m, udomain_t* _d) {

1 0

git:master:27e97f17: janssonrpcc: typo
by Daniel-Constantin Mierla 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 27e97f1717e542765125f32f0bde98f6bf47e26b URL: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 janssonrpcc: typo --- Modified: src/modules/janssonrpcc/doc/janssonrpcc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… Patch: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… --- diff --git a/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml b/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml index 0d7e78c7085..10a3a732482 100644 --- a/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml +++ b/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml @@ -143,7 +143,7 @@ modparam("janssonrpcc", "result_pv", "$var(result)") modparam("janssonrpcc", "server", "conn=tests;srv=_test1._tcp.example.net"); modparam("janssonrpcc", "server", "conn=tests;srv=_test2._tcp.example.net"); modparam("janssonrpcc", "server", "conn=local;addr=localhost;port=8080;priority=10;weight=10"); -modparam("janssonrpcc", "server", "conn=user_db;addr=rpc.prod.exmaple.net;port=5060;priority=10;weight=10"); +modparam("janssonrpcc", "server", "conn=user_db;addr=rpc.prod.example.net;port=5060;priority=10;weight=10"); ... </programlisting> </example>

1 0

git:master:b1f783df: call_control: typos
by Daniel-Constantin Mierla 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: b1f783df4ceb2a1d4a525c3802707105b6f1a0c6 URL: https://github.com/kamailio/kamailio/commit/b1f783df4ceb2a1d4a525c380270710… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 call_control: typos --- Modified: src/modules/call_control/call_control.c Modified: src/modules/call_control/doc/call_control.8 Modified: src/modules/call_control/doc/call_control_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b1f783df4ceb2a1d4a525c380270710… Patch: https://github.com/kamailio/kamailio/commit/b1f783df4ceb2a1d4a525c380270710… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index f9d152f85f2..1da3cf38f82 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -102,7 +102,7 @@ typedef struct AVP_List { typedef struct CallControlSocket { char *name; // name int sock; // socket - int timeout; // how many miliseconds to wait for an answer + int timeout; // how many milliseconds to wait for an answer time_t last_failure; // time of the last failure char data[BUFFER_SIZE]; // buffer for the answer data } CallControlSocket; @@ -124,7 +124,7 @@ int parse_param_stop(unsigned int type, void *val); static CallControlSocket callcontrol_socket = { "/run/callcontrol/socket", // name -1, // sock - 500, // timeout in 500 miliseconds if there is no answer + 500, // timeout in 500 milliseconds if there is no answer 0, // time of the last failure "" // data }; diff --git a/src/modules/call_control/doc/call_control.8 b/src/modules/call_control/doc/call_control.8 index ea3d50d25b4..d94d647dcd3 100644 --- a/src/modules/call_control/doc/call_control.8 +++ b/src/modules/call_control/doc/call_control.8 @@ -115,11 +115,11 @@ see .BR kamailio.cfg(5) .PP Full documentation on Kamailio is available at -.I http://www.kamailio.org/. +.I https://www.kamailio.org/. .PP Mailing lists: .nf -users(a)lists.kamailio.org - Kamailio user community +sr-users(a)lists.kamailio.org - Kamailio user community .nf -devel(a)lists.kamailio.org - Kamailio development, new features and unstable version +sr-dev(a)lists.kamailio.org - Kamailio development, new features and unstable version diff --git a/src/modules/call_control/doc/call_control_admin.xml b/src/modules/call_control/doc/call_control_admin.xml index a7a57a8d735..0dd52f026ad 100644 --- a/src/modules/call_control/doc/call_control_admin.xml +++ b/src/modules/call_control/doc/call_control_admin.xml @@ -76,7 +76,7 @@ <para> Callcontrol is invoked by calling the call_control() function for the initial INVITE of every call we want to apply a limit to. This will end - up as a request to the callcontrol application, which will interogate + up as a request to the callcontrol application, which will interrogate the rating engine for a time limit for the given caller and destination. The rating engine will determine if the destination has any associated cost and if the caller has any credit limit and if so will return the

1 0

[kamailio/kamailio] Typos (PR #3415)
by Дилян Палаузов 25 Apr '23

25 Apr '23

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3415 -- Commit Summary -- * call_control: typos * cfgutils: typos * ims_registrar_pcscf: typo * janssonrpcc: typo * jsonrpcs: typos * jwt: typo algoritm → algorithm * kazoo: typos * keepalive: typos * kemix: update Kamailio URLs to HTTP → HTTPS * kex: typos -- File Changes -- M src/modules/call_control/call_control.c (4) M src/modules/call_control/doc/call_control.8 (6) M src/modules/call_control/doc/call_control_admin.xml (2) M src/modules/cfgutils/cfgutils.c (16) M src/modules/cfgutils/doc/cfgutils_admin.xml (2) M src/modules/ims_registrar_pcscf/save.c (2) M src/modules/janssonrpcc/doc/janssonrpcc_admin.xml (2) M src/modules/jsonrpcs/doc/jsonrpcs_admin.xml (2) M src/modules/jsonrpcs/jsonrpcs_mod.c (6) M src/modules/jwt/doc/jwt_admin.xml (6) M src/modules/kazoo/doc/kazoo_admin.xml (2) M src/modules/kazoo/kazoo.c (2) M src/modules/kazoo/kz_amqp.c (4) M src/modules/keepalive/doc/keepalive_admin.xml (12) M src/modules/keepalive/keepalive.h (2) M src/modules/keepalive/keepalive_rpc.c (30) M src/modules/kemix/doc/kemix_admin.xml (4) M src/modules/kemix/kemix_mod.c (4) M src/modules/kex/core_stats.c (4) M src/modules/kex/doc/kex_admin.xml (8) M src/modules/kex/kex_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3415.patch https://github.com/kamailio/kamailio/pull/3415.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3415 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3415(a)github.com>

2 1

git:master:b2b4eda3: statistics: convert to memory logging helper
by Henning Westerholt 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: b2b4eda387ec21ebac2db7258cabda2b9c9ed81b URL: https://github.com/kamailio/kamailio/commit/b2b4eda387ec21ebac2db7258cabda2… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-25T11:52:31Z statistics: convert to memory logging helper --- Modified: src/modules/statistics/statistics.c Modified: src/modules/statistics/stats_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/b2b4eda387ec21ebac2db7258cabda2… Patch: https://github.com/kamailio/kamailio/commit/b2b4eda387ec21ebac2db7258cabda2… --- diff --git a/src/modules/statistics/statistics.c b/src/modules/statistics/statistics.c index 3ffa58865b2..a8a1de484ad 100644 --- a/src/modules/statistics/statistics.c +++ b/src/modules/statistics/statistics.c @@ -125,7 +125,7 @@ static int fixup_stat(void** param, int param_no) /* var name - string or pv */ sopv = (struct stat_or_pv *)pkg_malloc(sizeof(struct stat_or_pv)); if (sopv==NULL) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; return E_OUT_OF_MEM; } memset( sopv, 0 , sizeof(struct stat_or_pv) ); @@ -151,7 +151,7 @@ static int fixup_stat(void** param, int param_no) } else if (param_no==2) { lopv = (struct long_or_pv *) pkg_malloc(sizeof(struct long_or_pv)); if (lopv == NULL) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; return E_OUT_OF_MEM; } memset(lopv, 0, sizeof(struct long_or_pv)); diff --git a/src/modules/statistics/stats_funcs.c b/src/modules/statistics/stats_funcs.c index c75beafae4b..bc3e5cbd56f 100644 --- a/src/modules/statistics/stats_funcs.c +++ b/src/modules/statistics/stats_funcs.c @@ -76,7 +76,7 @@ int reg_statistic( char* name) se = (stat_elem*)pkg_malloc( sizeof(stat_elem) ); if (se==0) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; goto error; }

1 0

git:master:78e658cd: kex: convert to memory logging helper, add missing mem error logging
by Henning Westerholt 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 78e658cd70d23f3665f08f436d8b9a9fa99769f9 URL: https://github.com/kamailio/kamailio/commit/78e658cd70d23f3665f08f436d8b9a9… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-25T11:29:37Z kex: convert to memory logging helper, add missing mem error logging --- Modified: src/modules/kex/km_core.c Modified: src/modules/kex/pkg_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/78e658cd70d23f3665f08f436d8b9a9… Patch: https://github.com/kamailio/kamailio/commit/78e658cd70d23f3665f08f436d8b9a9… --- diff --git a/src/modules/kex/km_core.c b/src/modules/kex/km_core.c index f0d97f1af97..583377379b5 100644 --- a/src/modules/kex/km_core.c +++ b/src/modules/kex/km_core.c @@ -76,7 +76,7 @@ int pv_printf_fixup(void** param, int param_no) spec = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); if(spec==NULL) { - LM_ERR("out of pkg\n"); + PKG_MEM_ERROR; return -1; } memset(spec, 0, sizeof(pv_spec_t)); diff --git a/src/modules/kex/pkg_stats.c b/src/modules/kex/pkg_stats.c index 15ce1dcf2c0..35565cbcd9e 100644 --- a/src/modules/kex/pkg_stats.c +++ b/src/modules/kex/pkg_stats.c @@ -78,7 +78,10 @@ int pkg_proc_stats_init(void) _pkg_proc_stats_list = (pkg_proc_stats_t*)shm_malloc( _pkg_proc_stats_no*sizeof(pkg_proc_stats_t)); if(_pkg_proc_stats_list==NULL) + { + SHM_MEM_ERROR; return -1; + } memset(_pkg_proc_stats_list, 0, _pkg_proc_stats_no*sizeof(pkg_proc_stats_t)); return 0;

1 0

git:master:836dd900: sipcapture: convert to memory logging helper, add missing mem logging and cleanup on errors
by Henning Westerholt 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 836dd90007d82a8d6a3bea1969a21ca349203e05 URL: https://github.com/kamailio/kamailio/commit/836dd90007d82a8d6a3bea1969a21ca… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-25T11:46:12Z sipcapture: convert to memory logging helper, add missing mem logging and cleanup on errors --- Modified: src/modules/sipcapture/hep.c Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/836dd90007d82a8d6a3bea1969a21ca… Patch: https://github.com/kamailio/kamailio/commit/836dd90007d82a8d6a3bea1969a21ca…

1 0

git:master:2264b5ca: call_control: convert to memory logging helper, add cleanup for errors
by Henning Westerholt 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 2264b5ca85256db2c3701575a24865f45b657c6c URL: https://github.com/kamailio/kamailio/commit/2264b5ca85256db2c3701575a24865f… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-25T11:49:47Z call_control: convert to memory logging helper, add cleanup for errors --- Modified: src/modules/call_control/call_control.c --- Diff: https://github.com/kamailio/kamailio/commit/2264b5ca85256db2c3701575a24865f… Patch: https://github.com/kamailio/kamailio/commit/2264b5ca85256db2c3701575a24865f… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index 14455ec967f..f9d152f85f2 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -260,6 +260,10 @@ cc_parse_param(void *val, AVP_List** avps) { } p0 = (char*) pkg_malloc (content.len + 1); + if(!(p0)) { + PKG_MEM_ERROR; + return -1; + } CHECK_ALLOC(p0); memset(p0, 0, content.len + 1); p = p0; @@ -270,10 +274,22 @@ cc_parse_param(void *val, AVP_List** avps) { for (;*p != '\0';) { mp = (AVP_List*) pkg_malloc (sizeof(AVP_List)); + if(!(mp)) { + PKG_MEM_ERROR; + pkg_free(p0); + return -1; + } CHECK_ALLOC(mp); memset(mp, 0, sizeof(AVP_List)); mp->next = *avps; mp->pv = (pv_spec_p) pkg_malloc (sizeof(pv_spec_t)); + if(!(mp->next)) + { + PKG_MEM_ERROR; + pkg_free(p0); + pkg_free(mp); + return -1; + } CHECK_ALLOC(mp->pv); memset(mp->pv, 0, sizeof(pv_spec_t));

1 0

git:master:2c976699: sworker: convert to memory logging helper
by Henning Westerholt 25 Apr '23

25 Apr '23

Module: kamailio Branch: master Commit: 2c976699e0e066659a2b1d2c1888300823c4b773 URL: https://github.com/kamailio/kamailio/commit/2c976699e0e066659a2b1d2c1888300… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-25T11:26:06Z sworker: convert to memory logging helper --- Modified: src/modules/sworker/sworker_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2c976699e0e066659a2b1d2c1888300… Patch: https://github.com/kamailio/kamailio/commit/2c976699e0e066659a2b1d2c1888300… --- diff --git a/src/modules/sworker/sworker_mod.c b/src/modules/sworker/sworker_mod.c index 6a151caa44b..377fb3cc608 100644 --- a/src/modules/sworker/sworker_mod.c +++ b/src/modules/sworker/sworker_mod.c @@ -192,7 +192,7 @@ int sworker_send_task(sip_msg_t *msg, str *gname) } at = (async_task_t *)shm_malloc(dsize); if(at == NULL) { - LM_ERR("no more shm memory\n"); + SHM_MEM_ERROR; return -1; } memset(at, 0, dsize);

1 0

git:master:04bcef64: rtimer: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 04bcef64e0bf0cff3558ce3cb895439ab2cdd5c7 URL: https://github.com/kamailio/kamailio/commit/04bcef64e0bf0cff3558ce3cb895439… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:43:37Z rtimer: convert to memory logging helper --- Modified: src/modules/rtimer/rtimer_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/04bcef64e0bf0cff3558ce3cb895439… Patch: https://github.com/kamailio/kamailio/commit/04bcef64e0bf0cff3558ce3cb895439… --- diff --git a/src/modules/rtimer/rtimer_mod.c b/src/modules/rtimer/rtimer_mod.c index 2b9fa12d431..cde900845cf 100644 --- a/src/modules/rtimer/rtimer_mod.c +++ b/src/modules/rtimer/rtimer_mod.c @@ -301,7 +301,7 @@ int stm_t_param(modparam_t type, void *val) nt = (stm_timer_t*)pkg_malloc(sizeof(stm_timer_t)); if(nt==0) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; free_params(params_list); return -1; } @@ -387,7 +387,7 @@ int stm_e_param(modparam_t type, void *val) rt = (stm_route_t*)pkg_malloc(sizeof(stm_route_t)); if(rt==0) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; free_params(params_list); return -1; }

1 0

git:master:b531f6df: drouting: convert to memory logging helper, add missing logging, free mem in errors
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: b531f6df91a5dd75fc6fae47e44041a1f1ebe6ca URL: https://github.com/kamailio/kamailio/commit/b531f6df91a5dd75fc6fae47e44041a… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:52:42Z drouting: convert to memory logging helper, add missing logging, free mem in errors --- Modified: src/modules/drouting/dr_load.c Modified: src/modules/drouting/dr_time.c Modified: src/modules/drouting/drouting.c Modified: src/modules/drouting/routing.c --- Diff: https://github.com/kamailio/kamailio/commit/b531f6df91a5dd75fc6fae47e44041a… Patch: https://github.com/kamailio/kamailio/commit/b531f6df91a5dd75fc6fae47e44041a…

1 0

git:master:a3fe9388: path: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: a3fe9388540ee3ba0331b642e1c26170ca572e60 URL: https://github.com/kamailio/kamailio/commit/a3fe9388540ee3ba0331b642e1c2617… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:30:54Z path: convert to memory logging helper --- Modified: src/modules/path/path.c --- Diff: https://github.com/kamailio/kamailio/commit/a3fe9388540ee3ba0331b642e1c2617… Patch: https://github.com/kamailio/kamailio/commit/a3fe9388540ee3ba0331b642e1c2617… --- diff --git a/src/modules/path/path.c b/src/modules/path/path.c index c90aa939004..f1d8a624646 100644 --- a/src/modules/path/path.c +++ b/src/modules/path/path.c @@ -68,8 +68,10 @@ static char *path_strzdup(char *src, int len) if(len<0) { len = strlen(src); } - if (!(res = (char *) pkg_malloc(len + 1))) + if (!(res = (char *) pkg_malloc(len + 1))) { + PKG_MEM_ERROR; return NULL; + } strncpy(res, src, len); res[len] = 0; @@ -112,7 +114,7 @@ static int prepend_path(sip_msg_t* _m, str *user, path_param_t param, cp = suffix = pkg_malloc(suffix_len); if (!suffix) { - LM_ERR("no pkg memory left for suffix\n"); + PKG_MEM_ERROR_FMT("for suffix\n"); goto out1; } @@ -165,7 +167,7 @@ static int prepend_path(sip_msg_t* _m, str *user, path_param_t param, prefix_len = PATH_PREFIX_LEN + (user ? user->len : 0) + 2; prefix = pkg_malloc(prefix_len); if (!prefix) { - LM_ERR("no pkg memory left for prefix\n"); + PKG_MEM_ERROR_FMT("for prefix\n"); goto out2; } if (user && user->len)

1 0

git:master:56a843bb: dmq_usrloc: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 56a843bb18b5f06d4ef88ed525d446a1ff298b3f URL: https://github.com/kamailio/kamailio/commit/56a843bb18b5f06d4ef88ed525d446a… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:32:29Z dmq_usrloc: convert to memory logging helper --- Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/56a843bb18b5f06d4ef88ed525d446a… Patch: https://github.com/kamailio/kamailio/commit/56a843bb18b5f06d4ef88ed525d446a… --- diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 62477198a27..657db6cb7cb 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -203,7 +203,7 @@ void usrloc_get_all_ucontact(dmq_node_t* node) len = rval * 2; buf = dmq_usrloc_malloc(len); if (buf == NULL) { - LM_ERR("out of pkg memory\n"); + PKG_MEM_ERROR; goto done; } rval = dmq_ul.get_all_ucontacts(buf, len, 0, 0, 1, 0); @@ -453,7 +453,7 @@ static int init_usrloc_dmq_recv() { LM_DBG("Initializing usrloc_dmq_recv for pid (%d)\n", my_pid()); usrloc_dmq_recv = (int*)pkg_malloc(sizeof(int)); if (!usrloc_dmq_recv) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; return -1; } *usrloc_dmq_recv = 0;

1 0

git:master:fc52a1e7: prefix_route: convert to memory logging helper, add missing logging
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: fc52a1e73812daaef425727fcf5f59ed6b75b2f9 URL: https://github.com/kamailio/kamailio/commit/fc52a1e73812daaef425727fcf5f59e… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:35:41Z prefix_route: convert to memory logging helper, add missing logging --- Modified: src/modules/prefix_route/tree.c --- Diff: https://github.com/kamailio/kamailio/commit/fc52a1e73812daaef425727fcf5f59e… Patch: https://github.com/kamailio/kamailio/commit/fc52a1e73812daaef425727fcf5f59e… --- diff --git a/src/modules/prefix_route/tree.c b/src/modules/prefix_route/tree.c index a90144d63af..c5e55826539 100644 --- a/src/modules/prefix_route/tree.c +++ b/src/modules/prefix_route/tree.c @@ -72,7 +72,7 @@ struct tree_item *tree_item_alloc(void) root = (struct tree_item *)shm_malloc(sizeof(*root)); if (NULL == root) { - LM_CRIT("shared memory alloc failed\n"); + SHM_MEM_CRITICAL; return NULL; } @@ -241,8 +241,10 @@ static struct tree *tree_alloc(void) struct tree *tree; tree = (struct tree *)shm_malloc(sizeof(*tree)); - if (NULL == tree) + if (NULL == tree) { + SHM_MEM_CRITICAL; return NULL; + } tree->root = NULL; atomic_set(&tree->refcnt, 0); @@ -325,6 +327,7 @@ int tree_init(void) /* Pointer to global tree must be in shared memory */ shared_tree = (struct tree **)shm_malloc(sizeof(*shared_tree)); if (NULL == shared_tree) { + SHM_MEM_ERROR; lock_destroy(shared_tree_lock); lock_dealloc(shared_tree_lock); shared_tree_lock=0;

1 0

git:master:965606b2: rr: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 965606b2fbdad7b868637fb2f35f15507279caf6 URL: https://github.com/kamailio/kamailio/commit/965606b2fbdad7b868637fb2f35f155… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:26:44Z rr: convert to memory logging helper --- Modified: src/modules/rr/loose.c Modified: src/modules/rr/record.c Modified: src/modules/rr/rr_cb.c --- Diff: https://github.com/kamailio/kamailio/commit/965606b2fbdad7b868637fb2f35f155… Patch: https://github.com/kamailio/kamailio/commit/965606b2fbdad7b868637fb2f35f155… --- diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index 8df81d56528..71a38532131 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -316,7 +316,7 @@ static inline int save_ruri(struct sip_msg* _m) + ROUTE_SUFFIX_LEN; s = (char*)pkg_malloc(len); if (!s) { - LM_ERR("No memory pkg left\n"); + PKG_MEM_ERROR; return -3; } diff --git a/src/modules/rr/record.c b/src/modules/rr/record.c index b6178cade36..01bbd3e4032 100644 --- a/src/modules/rr/record.c +++ b/src/modules/rr/record.c @@ -172,7 +172,7 @@ static inline struct lump *insert_rr_param_lump(struct lump *before, /* duplicate data in pkg mem */ s1 = (char*)pkg_malloc(l); if (s1==0) { - LM_ERR("no more pkg mem (%d)\n",l); + PKG_MEM_ERROR_FMT("missing (%d)\n",l); return 0; } memcpy( s1, s, l); @@ -233,7 +233,7 @@ static inline int build_rr(struct lump* _l, struct lump* _l2, str* user, r2 = pkg_malloc(RR_R2_LEN); if (!prefix || !suffix || !term || !r2) { - LM_ERR("No more pkg memory\n"); + PKG_MEM_ERROR; if (suffix) pkg_free(suffix); if (prefix) pkg_free(prefix); if (term) pkg_free(term); @@ -356,7 +356,7 @@ static int copy_flow_token(str *token, struct sip_msg *_m) token->s = pkg_malloc(puri.user.len * sizeof(char)); if (token->s == NULL) { - LM_ERR("allocating memory\n"); + PKG_MEM_ERROR; return -1; } memcpy(token->s, puri.user.s, puri.user.len); @@ -593,7 +593,7 @@ int record_route_preset(struct sip_msg* _m, str* _data) suffix.s = pkg_malloc(suffix.len); term.s = pkg_malloc(term.len); if (!hdr.s || !suffix.s || !term.s) { - LM_ERR("no pkg memory left\n"); + PKG_MEM_ERROR; if(hdr.s) pkg_free(hdr.s); if(suffix.s) pkg_free(suffix.s); if(term.s) pkg_free(term.s); @@ -719,7 +719,7 @@ static inline int build_advertised_rr(struct lump* _l, struct lump* _l2, str *_d r2 = pkg_malloc(RR_R2_LEN); term = pkg_malloc(RR_TERM_LEN); if (!hdr || !trans || !suffix || !term || !r2) { - LM_ERR("no pkg memory left\n"); + PKG_MEM_ERROR; if (hdr) pkg_free(hdr); if (trans) pkg_free(trans); if (suffix) pkg_free(suffix); diff --git a/src/modules/rr/rr_cb.c b/src/modules/rr/rr_cb.c index 6b66e8c5859..c55f0117295 100644 --- a/src/modules/rr/rr_cb.c +++ b/src/modules/rr/rr_cb.c @@ -59,7 +59,7 @@ int register_rrcb( rr_cb_t f, void *param ) /* build a new callback structure */ if (!(cbp=pkg_malloc( sizeof( struct rr_callback)))) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; return -1; }

1 0

git:master:4f44adcf: outbound: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 4f44adcfbfaf84262f09f03afd8912205ce6c13b URL: https://github.com/kamailio/kamailio/commit/4f44adcfbfaf84262f09f03afd89122… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:27:45Z outbound: convert to memory logging helper --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4f44adcfbfaf84262f09f03afd89122… Patch: https://github.com/kamailio/kamailio/commit/4f44adcfbfaf84262f09f03afd89122… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index df9538aace8..bed8c03fbb4 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -101,7 +101,7 @@ static int mod_init(void) if ((ob_key.s = shm_malloc(OB_KEY_LEN)) == NULL) { - LM_ERR("Failed to allocate memory for flow-token key\n"); + SHM_MEM_ERROR_FMT("for flow-token key\n"); return -1; } ob_key.len = OB_KEY_LEN; @@ -210,7 +210,7 @@ int encode_flow_token(str *flow_token, struct receive_info *rcv) flow_token->s = pkg_malloc(base64_enc_len(pos)); if (flow_token->s == NULL) { - LM_ERR("allocating package memory\n"); + PKG_MEM_ERROR; return -1; } flow_token->len = base64_enc(unenc_flow_token, pos,

1 0

git:master:f7588fb8: siputils: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: f7588fb8fb804aa7585db5cb97433b69763ceb62 URL: https://github.com/kamailio/kamailio/commit/f7588fb8fb804aa7585db5cb97433b6… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:17:56Z siputils: convert to memory logging helper --- Modified: src/modules/siputils/chargingvector.c Modified: src/modules/siputils/checks.c Modified: src/modules/siputils/contact_ops.c Modified: src/modules/siputils/options.c Modified: src/modules/siputils/rpid.c Modified: src/modules/siputils/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/f7588fb8fb804aa7585db5cb97433b6… Patch: https://github.com/kamailio/kamailio/commit/f7588fb8fb804aa7585db5cb97433b6…

1 0

git:master:6f68f55c: qos: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 6f68f55c1c654e3cb120c10eb6999d538d943ca2 URL: https://github.com/kamailio/kamailio/commit/6f68f55c1c654e3cb120c10eb6999d5… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:20:16Z qos: convert to memory logging helper --- Modified: src/modules/qos/qos_cb.c Modified: src/modules/qos/qos_ctx_helpers.c --- Diff: https://github.com/kamailio/kamailio/commit/6f68f55c1c654e3cb120c10eb6999d5… Patch: https://github.com/kamailio/kamailio/commit/6f68f55c1c654e3cb120c10eb6999d5… --- diff --git a/src/modules/qos/qos_cb.c b/src/modules/qos/qos_cb.c index e2b0c0f9aee..6c81411d6f0 100644 --- a/src/modules/qos/qos_cb.c +++ b/src/modules/qos/qos_cb.c @@ -34,7 +34,7 @@ int init_qos_callbacks(void) { create_cbs = (struct qos_head_cbl*)shm_malloc(sizeof(struct qos_head_cbl)); if (create_cbs==0) { - LM_ERR("no more shm mem\n"); + SHM_MEM_ERROR; return -1; } create_cbs->first = 0; @@ -88,7 +88,7 @@ int register_qoscb(qos_ctx_t *qos, int types, qos_cb f, void *param ) } cb = (struct qos_callback*)shm_malloc(sizeof(struct qos_callback)); if (cb==0) { - LM_ERR("no more shm mem\n"); + SHM_MEM_ERROR; return -1; } diff --git a/src/modules/qos/qos_ctx_helpers.c b/src/modules/qos/qos_ctx_helpers.c index f36193cf6ce..25143dfdb4d 100644 --- a/src/modules/qos/qos_ctx_helpers.c +++ b/src/modules/qos/qos_ctx_helpers.c @@ -52,7 +52,7 @@ qos_ctx_t *build_new_qos_ctx(void) { if (ctx!=NULL) { memset(ctx, 0, sizeof(qos_ctx_t)); } else { - LM_ERR("No enough shared memory\n"); + SHM_MEM_ERROR; return NULL; } if (!lock_init(&ctx->lock)) { @@ -342,7 +342,7 @@ int add_pending_sdp_session(qos_ctx_t *qos_ctx, unsigned int dir, str *cseq_numb qos_sdp = (qos_sdp_t *)shm_malloc(len); LM_DBG("alloc qos_sdp: %p\n", qos_sdp); if (qos_sdp==NULL) { - LM_ERR("oom %d\n", len); + SHM_MEM_ERROR_FMT("missing %d\n", len); return -1; } else { memset(qos_sdp, 0, len);

1 0

git:master:19df3ad8: uid_auth_db: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 19df3ad8f3e10b6c9fa91e69f288fdbd51be7091 URL: https://github.com/kamailio/kamailio/commit/19df3ad8f3e10b6c9fa91e69f288fdb… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:24:24Z uid_auth_db: convert to memory logging helper --- Modified: src/modules/uid_auth_db/aaa_avps.h Modified: src/modules/uid_auth_db/uid_auth_db_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/19df3ad8f3e10b6c9fa91e69f288fdb… Patch: https://github.com/kamailio/kamailio/commit/19df3ad8f3e10b6c9fa91e69f288fdb… --- diff --git a/src/modules/uid_auth_db/aaa_avps.h b/src/modules/uid_auth_db/aaa_avps.h index 62f1062bf3d..25b6cbeda3b 100644 --- a/src/modules/uid_auth_db/aaa_avps.h +++ b/src/modules/uid_auth_db/aaa_avps.h @@ -76,7 +76,7 @@ static int aaa_avps_init(str *avp_list, str **parsed_avps, int *avps_n) cp = pkg_malloc(avp_list->len + 1); if (cp == NULL) { - LM_ERR("can't allocate memory\n"); + PKG_MEM_ERROR; errcode = -1; goto bad; } diff --git a/src/modules/uid_auth_db/uid_auth_db_mod.c b/src/modules/uid_auth_db/uid_auth_db_mod.c index 781ff37220f..2fd206bb970 100644 --- a/src/modules/uid_auth_db/uid_auth_db_mod.c +++ b/src/modules/uid_auth_db/uid_auth_db_mod.c @@ -172,7 +172,7 @@ static int generate_queries(authdb_table_info_t *info) len = sizeof(*result_cols) * (credentials_n + 3); result_cols = pkg_malloc(len); if (!result_cols) { - ERR("can't allocate pkg mem\n"); + PKG_MEM_ERROR; return -1; } memset(result_cols, 0, len); @@ -321,7 +321,7 @@ static authdb_table_info_t *register_table(str *table) info = (authdb_table_info_t*)pkg_malloc(sizeof(authdb_table_info_t) + table->len + 1); if (!info) { - LM_ERR("can't allocate pkg mem\n"); + PKG_MEM_ERROR; return NULL; }

1 0

git:master:7747f91f: stun: convert to memory logging helper
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 7747f91f6c482a99cfab4813e3b2ad5e6e970d07 URL: https://github.com/kamailio/kamailio/commit/7747f91f6c482a99cfab4813e3b2ad5… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:06:41Z stun: convert to memory logging helper --- Modified: src/modules/stun/kam_stun.c --- Diff: https://github.com/kamailio/kamailio/commit/7747f91f6c482a99cfab4813e3b2ad5… Patch: https://github.com/kamailio/kamailio/commit/7747f91f6c482a99cfab4813e3b2ad5… --- diff --git a/src/modules/stun/kam_stun.c b/src/modules/stun/kam_stun.c index 04f52fa2bfd..0ddbb00ed1c 100644 --- a/src/modules/stun/kam_stun.c +++ b/src/modules/stun/kam_stun.c @@ -408,7 +408,7 @@ static int stun_create_response( */ res->msg.buf.s = (char *) pkg_malloc(sizeof(char)*STUN_MSG_LEN); if (res->msg.buf.s == NULL) { - LOG(L_ERR, "ERROR: STUN: out of memory\n"); + PKG_MEM_ERROR; return FATAL_ERROR; } @@ -822,7 +822,7 @@ static struct stun_unknown_att* stun_alloc_unknown_attr(USHORT_T type) attr = (struct stun_unknown_att *) pkg_malloc(sizeof(struct stun_unknown_att)); if (attr == NULL) { - LOG(L_ERR, "ERROR: STUN: out of memory\n"); + PKG_MEM_ERROR; return NULL; }

1 0

git:master:d5ab93a1: statsc: convert to memory logging helper, free memory in case of error
by Henning Westerholt 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: d5ab93a1e642aec9c842c9ffe9cb712c0f41e4c0 URL: https://github.com/kamailio/kamailio/commit/d5ab93a1e642aec9c842c9ffe9cb712… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-04-24T19:08:29Z statsc: convert to memory logging helper, free memory in case of error --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d5ab93a1e642aec9c842c9ffe9cb712… Patch: https://github.com/kamailio/kamailio/commit/d5ab93a1e642aec9c842c9ffe9cb712… --- diff --git a/src/modules/statsc/statsc_mod.c b/src/modules/statsc/statsc_mod.c index 3b636b81fc5..92447339151 100644 --- a/src/modules/statsc/statsc_mod.c +++ b/src/modules/statsc/statsc_mod.c @@ -202,7 +202,7 @@ int statsc_nmap_add(str *sname, str *rname) + STRLEN_ROUNDUP(sname->len) + STRLEN_ROUNDUP(rname->len); sm = shm_malloc(sz); if(sm==NULL) { - LM_ERR("no more shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(sm, 0, sz); @@ -241,7 +241,7 @@ int statsc_init(void) _statsc_info = shm_malloc(sizeof(statsc_info_t)); if(_statsc_info==NULL) { - LM_ERR("no more shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(_statsc_info, 0, sizeof(statsc_info_t)); @@ -250,7 +250,8 @@ int statsc_init(void) sz = sizeof(statsc_nmap_t) + statsc_items * sizeof(int64_t); sm = shm_malloc(sz); if(sm==NULL) { - LM_ERR("no more shared memory\n"); + SHM_MEM_ERROR; + shm_free(_statsc_info); return -1; } memset(sm, 0, sz);

1 0

[kamailio/kamailio] Application crash due to intensive "dispather.add" using (Issue #3424)
by Nikolay Shakin 24 Apr '23

24 Apr '23

### Description I want to add addresses to dispatcher.list dynamically ``` modparam("dispatcher", "db_url", DBURL) modparam("dispatcher", "table_name", "dispatcher") modparam("dispatcher", "ds_ping_interval", 10) modparam("dispatcher", "ds_probing_mode", 1) modparam("dispatcher", "ds_inactive_threshold", 1) modparam("dispatcher", "ds_probing_threshold", 1) modparam("dispatcher", "reload_delta", 0) modparam("dispatcher", "ds_timer_mode", 1) ... if(!ds_is_from_list("1","0","$var(contact)")) { jsonrpc_exec( '{ "jsonrpc": "2.0", "method": "dispatcher.add", "params": [1, "$var(contact)"], "id": 1 }' ); } ``` this scheme works with low load(one or two UAs) but it doesn't work with dozens of requests, kamailio crashes ### Troubleshooting ``` Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: CRITICAL: {1 12016 REGISTER db88353a-66cf-4ca6-91e2-6f306e43cee9} <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f2f964578b8), called from dispatcher: dispatch.c: reindex_dests(790), first free dispatcher: dispatch.c: ds_avl_destroy(4013) - ignoring Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: INFO: {1 12016 REGISTER db88353a-66cf-4ca6-91e2-6f306e43cee9} dispatcher [dispatch.c:682]: dp_init_relative_weights(): extra rweight 100 for last active destination in group 1 Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6827]: INFO: {1 16898 REGISTER eebaeca9-c642-465f-bc09-67d1448ba6b7} dispatcher [dispatch.c:682]: dp_init_relative_weights(): extra rweight 100 for last active destination in group 1 Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: ERROR: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: WARNING: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: ERROR: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: WARNING: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: ERROR: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6825]: WARNING: {1 27217 REGISTER 885dc562-c8f3-477a-bc4b-ba3718cdf8db} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: ERROR: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: WARNING: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: ERROR: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: WARNING: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: ERROR: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6829]: WARNING: {1 40473 REGISTER bd8d332f-d896-4dab-b4ab-3904f8a29dda} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: ERROR: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: WARNING: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: ERROR: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: WARNING: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: ERROR: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:407]: pack_dest(): bad uri [] Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6832]: WARNING: {1 55015 REGISTER bfc85ce0-6aee-40c3-9b73-d0f64e835dc1} dispatcher [dispatch.c:2624]: ds_add_dest_cb(): failed to add destination in group 1 - Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6808]: ALERT: <core> [main.c:774]: handle_sigs(): child process 6825 exited by a signal 11 Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6808]: ALERT: <core> [main.c:777]: handle_sigs(): core was not generated Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6808]: INFO: <core> [main.c:799]: handle_sigs(): terminating due to SIGCHLD Apr 22 22:18:09 kamailio /usr/sbin/kamailio[6827]: INFO: <core> [main.c:854]: sig_usr(): signal 15 received Apr 22 22:18:10 kamailio /usr/sbin/kamailio[6808]: INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized Apr 22 22:18:10 kamailio systemd[1]: kamailio.service: Main process exited, code=exited, status=1/FAILURE Apr 22 22:18:10 kamailio systemd[1]: kamailio.service: Failed with result 'exit-code'. Apr 22 22:18:10 kamailio systemd[1]: kamailio.service: Consumed 1.304s CPU time. ``` #### Reproduction use code from Description section on request route #### Debugging Data ``` (gdb) bt full #0 0x000055945e0ccd20 in ?? () No symbol table info available. #1 0x000055945e0cd6ee in qm_malloc () No symbol table info available. #2 0x000055945e0da9c9 in qm_shm_malloc () No symbol table info available. #3 0x00007f325a05e921 in pack_dest () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #4 0x00007f325a060ad4 in add_dest2list () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #5 0x00007f325a087cf9 in ds_filter_dest_cb () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #6 0x00007f325a05affb in ds_iter_set () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #7 0x00007f325a088706 in ds_remove_dst () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #8 0x00007f325a0af7a8 in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/dispatcher.so No symbol table info available. #9 0x00007f325e7e82f5 in jsonrpc_exec_ex () from /usr/lib/x86_64-linux-gnu/kamailio/modules/jsonrpcs.so No symbol table info available. #10 0x00007f325e7e875e in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/jsonrpcs.so No symbol table info available. #11 0x000055945ddce3f3 in do_action () No symbol table info available. #12 0x000055945dddd391 in run_actions () No symbol table info available. #13 0x000055945ddce2d3 in do_action () No symbol table info available. #14 0x000055945dddd391 in run_actions () No symbol table info available. #15 0x000055945ddce2d3 in do_action () No symbol table info available. #16 0x000055945dddd391 in run_actions () No symbol table info available. #17 0x000055945ddca244 in do_action () No symbol table info available. --Type <RET> for more, q to quit, c to continue without paging-- #18 0x000055945dddd391 in run_actions () No symbol table info available. #19 0x000055945ddce2d3 in do_action () No symbol table info available. #20 0x000055945dddd391 in run_actions () No symbol table info available. #21 0x000055945ddddc0b in run_top_route () No symbol table info available. #22 0x000055945df3b1b2 in receive_msg () No symbol table info available. #23 0x000055945e09ea5d in udp_rcv_loop () No symbol table info available. #24 0x000055945ddb709b in main_loop () No symbol table info available. #25 0x000055945ddc420c in main () No symbol table info available. ``` ```(gdb) info locals No symbol table info available.``` ```(gdb) list 1 ../sysdeps/unix/sysv/linux/dl-vdso-setup.c: No such file or directory.``` #### SIP Traffic [kamailio.txt](https://github.com/kamailio/kamailio/files/11302151/kamailio.… ### Possible Solutions no idea ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` root@kamailio:[/etc]: kamailio -v version: kamailio 5.6.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: ``` root@kamailio:[/etc]: uname -a Linux kamailio 5.10.0-21-amd64 #1 SMP Debian 5.10.162-1 (2023-01-21) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3424 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3424(a)github.com>

3 6

[kamailio/kamailio] .github/workflows: added GitHub action script to build Alpine docker (PR #3425)
by sergey-safarov 24 Apr '23

24 Apr '23

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Created GitHub action script to allow build Alpine docker image and push to GitHub packages as `kamailio/kamailio-ci` docker image You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3425 -- Commit Summary -- * .github/workflows: added GitHub action script to build Alpine based docker image -- File Changes -- A .github/workflows/alpine.yml (179) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3425.patch https://github.com/kamailio/kamailio/pull/3425.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3425 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3425(a)github.com>

2 1

git:master:83789e7e: .github/workflows: added GitHub action script to build Alpine based docker image
by Victor Seva 24 Apr '23

24 Apr '23

Module: kamailio Branch: master Commit: 83789e7efe6e1a3479e7742812eaff2ffd7ebdd3 URL: https://github.com/kamailio/kamailio/commit/83789e7efe6e1a3479e7742812eaff2… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-04-24T16:44:52+02:00 .github/workflows: added GitHub action script to build Alpine based docker image --- Added: .github/workflows/alpine.yml --- Diff: https://github.com/kamailio/kamailio/commit/83789e7efe6e1a3479e7742812eaff2… Patch: https://github.com/kamailio/kamailio/commit/83789e7efe6e1a3479e7742812eaff2…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev