I run Kamailio with
```
log_stderror=yes
/* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */
debug=-1
```
and inspect the output. Some messages from the websocket module are logged repeatedly at ERROR-level, but they are in no way errors. This changes moves such periodially logged no-error messages to debug-level INFO.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3349
-- Commit Summary --
* websocket: move some logging from ERROR to INFO
-- File Changes --
M src/modules/websocket/doc/websocket_admin.xml (2)
M src/modules/websocket/utf8_decode.h (2)
M src/modules/websocket/ws_frame.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3349.patchhttps://github.com/kamailio/kamailio/pull/3349.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3349
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3349(a)github.com>
Module: kamailio
Branch: master
Commit: d7ef61788fcf84ff86b000f972aff99a300c5237
URL: https://github.com/kamailio/kamailio/commit/d7ef61788fcf84ff86b000f972aff99…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-03T18:46:40+01:00
websocket: typos
---
Modified: src/modules/websocket/doc/websocket_admin.xml
Modified: src/modules/websocket/utf8_decode.h
---
Diff: https://github.com/kamailio/kamailio/commit/d7ef61788fcf84ff86b000f972aff99…
Patch: https://github.com/kamailio/kamailio/commit/d7ef61788fcf84ff86b000f972aff99…
---
diff --git a/src/modules/websocket/doc/websocket_admin.xml b/src/modules/websocket/doc/websocket_admin.xml
index 5d33184a85..8ce006c0f8 100644
--- a/src/modules/websocket/doc/websocket_admin.xml
+++ b/src/modules/websocket/doc/websocket_admin.xml
@@ -488,7 +488,7 @@ end
</para>
<para><emphasis>Default value is 1.</emphasis></para>
<example>
- <title>Set <varname>timer_interval</varname>parameter</title>
+ <title>Set <varname>timer_interval</varname> parameter</title>
<programlisting format="linespecific">
...
modparam("websocket", "timer_interval", 5)
diff --git a/src/modules/websocket/utf8_decode.h b/src/modules/websocket/utf8_decode.h
index 33c0ccf55f..76b378e742 100644
--- a/src/modules/websocket/utf8_decode.h
+++ b/src/modules/websocket/utf8_decode.h
@@ -47,7 +47,7 @@ static const uint8_t utf8d[] = {
10,3,3,3,3,3,3,3,3,3,3,3,3,4,3,3, 11,6,6,6,5,8,8,8,8,8,8,8,8,8,8,8,
// The second part is a transition table that maps a combination
- // of a state of the automaton and a character class to a state.
+ // of a state of the automation and a character class to a state.
0, 12,24,36,60,96,84,12,12,12,48,72, 12,12,12,12,12,12,12,12,12,12,12,12,
12, 0,12,12,12,12,12, 0,12, 0,12,12, 12,24,12,12,12,12,12,24,12,24,12,12,
12,12,12,12,12,12,12,24,12,12,12,12, 12,24,12,12,12,12,12,12,12,24,12,12,
In src/core/ccopts.sh:98 there is “acroos”. This could be macros or across.
Likewise in 2× src/Makefile.defs
In src/core/dst_blocklist.c:625 `taget` could be `target` or `tagged`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3354
-- Commit Summary --
* core: typos
-- File Changes --
M src/core/action.c (4)
M src/core/atomic/atomic_alpha.h (2)
M src/core/atomic/atomic_ppc.h (2)
M src/core/atomic/atomic_sparc64.h (4)
M src/core/atomic/atomic_unknown.h (4)
M src/core/atomic_ops.h (2)
M src/core/atomic_ops_init.h (2)
M src/core/basex.c (2)
M src/core/basex.h (4)
M src/core/bit_count.h (2)
M src/core/bit_scan.h (2)
M src/core/ccopts.sh (4)
M src/core/cfg.y (6)
M src/core/cfg/cfg.c (4)
M src/core/cfg/cfg_ctx.c (12)
M src/core/cfg/cfg_ctx.h (2)
M src/core/cfg/cfg_struct.c (4)
M src/core/cfg/cfg_struct.h (2)
M src/core/counters.c (6)
M src/core/daemonize.c (4)
M src/core/dns_cache.c (26)
M src/core/dns_cache.h (2)
M src/core/dprint.c (2)
M src/core/dprint.h (2)
M src/core/dst_blocklist.c (10)
M src/core/endianness.h (6)
M src/core/error.c (2)
M src/core/fix_lumps.h (2)
M src/core/forward.c (2)
M src/core/hashes.h (2)
M src/core/io_wait.h (14)
M src/core/ip_addr.c (2)
M src/core/kemi.c (4)
M src/core/local_timer.c (2)
M src/core/lock_ops.h (4)
M src/core/mem/dl_malloc.c (6)
M src/core/mem/ll_malloc.c (2)
M src/core/mem/sf_malloc.c (2)
M src/core/mod_fix.c (4)
M src/core/msg_translator.h (2)
M src/core/onsend.c (4)
M src/core/parser/digest/digest_parser.c (4)
M src/core/parser/digest/digest_parser.h (2)
M src/core/parser/hf.c (2)
M src/core/parser/hf.h (2)
M src/core/parser/msg_parser.c (2)
M src/core/parser/msg_parser.h (4)
M src/core/parser/parse_body.c (18)
M src/core/parser/parse_content.c (10)
M src/core/parser/parse_content.h (4)
M src/core/parser/parse_diversion.c (2)
M src/core/parser/parse_expires.c (2)
M src/core/parser/parse_param.c (2)
M src/core/parser/parse_uri.c (2)
M src/core/parser/parse_uri.h (2)
M src/core/parser/parse_via.c (6)
M src/core/parser/sdp/sdp.c (6)
M src/core/parser/sdp/sdp_helpr_funcs.c (2)
M src/core/pass_fd.c (2)
M src/core/rand/fortuna/fortuna.c (2)
M src/core/raw_sock.c (4)
M src/core/resolve.c (10)
M src/core/rpc.h (2)
M src/core/rvalue.c (12)
M src/core/rvalue.h (2)
M src/core/select.c (2)
M src/core/select.h (4)
M src/core/select_core.c (16)
M src/core/ser_time.h (2)
M src/core/signals.c (2)
M src/core/sip_msg_clone.c (2)
M src/core/socket_info.c (2)
M src/core/sr_module.c (10)
M src/core/strutils.c (2)
M src/core/switch.c (8)
M src/core/tcp_conn.h (2)
M src/core/tcp_init.h (2)
M src/core/tcp_main.c (14)
M src/core/tcp_options.c (2)
M src/core/tcp_read.c (8)
M src/core/timer.c (8)
M src/core/timer.h (2)
M src/core/timer_funcs.h (2)
M src/core/timer_proc.c (10)
M src/core/timer_proc.h (4)
M src/core/timer_ticks.h (2)
M src/core/usr_avp.c (2)
M src/core/ut.c (2)
M src/core/ut.h (4)
M src/core/utils/srjson.c (2)
M src/core/utils/tmrec.c (2)
M src/core/ver.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3354.patchhttps://github.com/kamailio/kamailio/pull/3354.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3354
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3354(a)github.com>
Module: kamailio
Branch: master
Commit: 609b689e6071c272e8230901e95db183334391d1
URL: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-02-03T09:46:31+01:00
modules: readme files regenerated - rr ... [skip ci]
---
Modified: src/modules/rr/README
---
Diff: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
Patch: https://github.com/kamailio/kamailio/commit/609b689e6071c272e8230901e95db18…
---
diff --git a/src/modules/rr/README b/src/modules/rr/README
index c31f0c8ee8..efaf0df8e3 100644
--- a/src/modules/rr/README
+++ b/src/modules/rr/README
@@ -152,13 +152,13 @@ Chapter 1. Admin Guide
1. Overview
- The module contains record routing logic
+ The module contains record routing logic.
2. Dialog support
Kamailio is basically only a transaction stateful proxy, without any
dialog support build in. There are many features/services which
- actually requires a dialog awareness, like storing the information in
+ actually require a dialog awareness, like storing the information in
the dialog creation stage, information which will be used during the
whole dialog existence.
@@ -327,7 +327,7 @@ modparam("rr", "enable_socket_mismatch_warning", 0)
4.6. custom_user_avp (avp string)
- When enable_username is enabled, a call to record_route will add the
+ When add_username is enabled, a call to record_route will add the
username of the RequestURI to the Record-Route URI. This parameter
allows you to setup an AVP with which you can customise the username to
be added in the Record-Route URI.
@@ -614,7 +614,7 @@ add_rr_param(";nat=yes");
The function checks if the URI parameters of the local Route header
(corresponding to the local server) matches the given regular
- expression. It must be call after loose_route() (see Section 5.1,
+ expression. It must be called after loose_route() (see Section 5.1,
���loose_route()���).
Meaning of the parameters is as follows:
@@ -780,7 +780,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks for the request ���msg��� if the URI parameters of the
local Route header (corresponding to the local server) matches the
- given regular expression ���re���. It must be call after the loose_route
+ given regular expression ���re���. It must be called after the loose_route
was done.
The function returns 0 on success. Otherwise, -1 is returned.
@@ -796,7 +796,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks the flow direction of the request ���msg���. As for
checking it's used the ���ftag��� Route header parameter, the
append_fromtag (see ??? module parameter must be enables. Also this
- must be call only after the loose_route is done.
+ must be called only after the loose_route is done.
The function returns 0 if the ���dir��� is the same with the request's flow
direction. Otherwise, -1 is returned.
@@ -808,9 +808,9 @@ record_route_advertised_address("1.2.3.4:5090");
1.6. get_route_param(msg, name, val)
- The function search in to the ���msg���'s Route header parameters the
+ The function searches in the ���msg���'s Route header parameters the
parameter called ���name��� and returns its value into ���val���. It must be
- call only after the loose_route is done.
+ called only after the loose_route is done.
The function returns 0 if parameter was found (even if it has no
value). Otherwise, -1 is returned.
@@ -824,7 +824,7 @@ record_route_advertised_address("1.2.3.4:5090");
1.7. register_rrcb(callback, param)
- The function register a new callback (along with its parameter). The
+ The function registers a new callback (along with its parameter). The
callback will be called when a loose route will be performed for the
local address.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3344
-- Commit Summary --
* test/ : typos
* snmpstats: typos
-- File Changes --
M src/modules/snmpstats/doc/snmpstats_admin.xml (8)
M src/modules/snmpstats/hashTable.c (2)
M src/modules/snmpstats/hashTable.h (2)
M src/modules/snmpstats/interprocess_buffer.c (6)
M src/modules/snmpstats/mibs/KAMAILIO-MIB (10)
M src/modules/snmpstats/mibs/KAMAILIO-REG-MIB (6)
M src/modules/snmpstats/mibs/KAMAILIO-SIP-COMMON-MIB (4)
M src/modules/snmpstats/mibs/KAMAILIO-SIP-SERVER-MIB (6)
M src/modules/snmpstats/mibs/KAMAILIO-TC (4)
M src/modules/snmpstats/snmpObjects.c (2)
M src/modules/snmpstats/snmpSIPContactTable.c (2)
M src/modules/snmpstats/snmpSIPContactTable.h (2)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.c (4)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.h (2)
M src/modules/snmpstats/snmpSIPStatusCodesTable.c (4)
M src/modules/snmpstats/sub_agent.c (2)
M test/misc/cfg/mobile61.cfg (2)
M test/misc/cfg/nc.cfg (8)
M test/misc/cfg/struas.cfg (2)
M test/misc/cfg/test1.cfg (2)
M test/misc/cfg/use_jab.cfg (2)
M test/misc/code/atomic_test.c (2)
M test/misc/code/atomic_test2.c (2)
M test/misc/code/basex.c (2)
M test/misc/code/shoot.c (2)
M test/misc/code/shoot2.c (2)
M test/misc/code/udp.c (6)
M test/misc/extra/gcc_version.sh (2)
M test/unit/5.cfg (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3344.patchhttps://github.com/kamailio/kamailio/pull/3344.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3344
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3344(a)github.com>
The documentation of rr.custom_user_avp speaks about option `enable_username`, but there is no such option.
I assume the documentation means `add_username`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3352
-- Commit Summary --
* rr: doc — replace enable_username with add_username
-- File Changes --
M src/modules/rr/doc/rr_admin.xml (6)
M src/modules/rr/doc/rr_devel.xml (10)
M src/modules/rr/loose.c (10)
M src/modules/rr/loose.h (6)
M src/modules/rr/rr_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3352.patchhttps://github.com/kamailio/kamailio/pull/3352.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3352
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3352(a)github.com>
Module: kamailio
Branch: master
Commit: 022fa0cfc75d150fde219b8ae4f9a99b3fa2f132
URL: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-03T09:38:26+01:00
rr: doc - fixed typos and use the proper param name add_username instead of enable_username
---
Modified: src/modules/rr/doc/rr_admin.xml
Modified: src/modules/rr/doc/rr_devel.xml
---
Diff: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
Patch: https://github.com/kamailio/kamailio/commit/022fa0cfc75d150fde219b8ae4f9a99…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 691e3d07df..2456450e4f 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -12,7 +12,7 @@
<section>
<title>Overview</title>
- <para>The module contains record routing logic</para>
+ <para>The module contains record routing logic.</para>
</section>
<section id="RR-dialog-id">
@@ -20,7 +20,7 @@
<para>&kamailio; is basically <emphasis>only</emphasis> a transaction
stateful proxy, without any dialog support build in. There are many
- features/services which actually requires a dialog awareness, like storing
+ features/services which actually require a dialog awareness, like storing
the information in the dialog creation stage, information which will be
used during the whole dialog existence.</para>
@@ -246,7 +246,7 @@ modparam("rr", "enable_socket_mismatch_warning", 0)
<section id="rr.p.custom_user_avp">
<title><varname>custom_user_avp</varname> (avp string)</title>
- <para>When enable_username is enabled, a call to record_route will add
+ <para>When add_username is enabled, a call to record_route will add
the username of the RequestURI to the Record-Route URI. This parameter
allows you to setup an AVP with which you can customise the username to
be added in the Record-Route URI.</para>
@@ -664,7 +664,7 @@ add_rr_param(";nat=yes");
<para>The function checks if the URI parameters of the local Route
header (corresponding to the local server) matches the given regular
- expression. It must be call after loose_route() (see <xref
+ expression. It must be called after loose_route() (see <xref
linkend="rr.f.loose_route"/>).</para>
<para>Meaning of the parameters is as follows:</para>
diff --git a/src/modules/rr/doc/rr_devel.xml b/src/modules/rr/doc/rr_devel.xml
index 516eb5a3aa..aa6f9c4b69 100644
--- a/src/modules/rr/doc/rr_devel.xml
+++ b/src/modules/rr/doc/rr_devel.xml
@@ -128,7 +128,7 @@ record_route_advertised_address("1.2.3.4:5090");
The function checks for the request <quote>msg</quote> if the URI
parameters of the local Route header (corresponding to the local
server) matches the given regular expression <quote>re</quote>.
- It must be call after the loose_route was done.
+ It must be called after the loose_route was done.
</para>
<para>
The function returns 0 on success. Otherwise, -1 is returned.
@@ -157,7 +157,7 @@ record_route_advertised_address("1.2.3.4:5090");
<quote>msg</quote>. As for checking it's used the <quote>ftag</quote>
Route header parameter, the append_fromtag (see
<xref linkend="append-fromtag-id"/> module parameter
- must be enables. Also this must be call only after the loose_route is
+ must be enables. Also this must be called only after the loose_route is
done.
</para>
<para>
@@ -185,9 +185,9 @@ record_route_advertised_address("1.2.3.4:5090");
<function moreinfo="none">get_route_param(msg, name, val)</function>
</title>
<para>
- The function search in to the <quote>msg</quote>'s Route header
+ The function searches in the <quote>msg</quote>'s Route header
parameters the parameter called <quote>name</quote> and returns its
- value into <quote>val</quote>. It must be call only after the
+ value into <quote>val</quote>. It must be called only after the
loose_route is done.
</para>
<para>
@@ -220,7 +220,7 @@ record_route_advertised_address("1.2.3.4:5090");
<function moreinfo="none">register_rrcb(callback, param)</function>
</title>
<para>
- The function register a new callback (along with its parameter). The
+ The function registers a new callback (along with its parameter). The
callback will be called when a loose route will be performed for the
local address.
</para>
I use Kamailio with `log_stderror=yes`. When Kamailio receives confirmation from the Websocket reverse proxy, it logs on stderr
```
23(24) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 22)
23(24) ERROR: <core> [core/parser/msg_parser.c:749]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 101 Switching Protocols
Sia: SIP/2.0/TCP 111.11.111.11:47418
Sec-WebSocket-Protocol: sip
Upgrade: websocket
Connection: upgrade
Sec-WebSocket-Accept: Ak3/c/aw3iyHnFkDDHabw1iXcqY=
Content-Length: 0
>
23(24) ERROR: <core> [core/msg_translator.c:3256]: build_sip_msg_from_buf(): parsing failed
```
Without the included `\n` here the subsequent messages are logged on the same line as `parsing failed`.
For the record, I use this NGINX configuration:
```
location /sip {
proxy_http_version 1.1;
proxy_set_header "Accept-Encoding" ""; # delete header before sending it to Kamailio
proxy_set_header "Pragma" "";
proxy_set_header "Cache-control" "";
proxy_set_header "User-Agent" "";
proxy_set_header Host $host;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;
proxy_pass http://123.12.123.12:5060;
proxy_read_timeout 86400;
}
```
and it leads to that unparsable message above.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3348
-- Commit Summary --
* core: msg_translator.c put new line after «parsing failed» error message
-- File Changes --
M src/core/msg_translator.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3348.patchhttps://github.com/kamailio/kamailio/pull/3348.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3348
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3348(a)github.com>
Module: kamailio
Branch: master
Commit: 51fa3da96c1eacd4d679598a3305180c9e818cfb
URL: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-03T09:28:58+01:00
core: typos in comments and EoL after log when parse msg fails
- GH #3348
---
Modified: src/core/msg_translator.c
---
Diff: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
Patch: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
---
diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c
index bc1b9736df..3ab6fae472 100644
--- a/src/core/msg_translator.c
+++ b/src/core/msg_translator.c
@@ -53,7 +53,7 @@
* lookup is performed on the host part and the reply is sent to the
* resulting ip. If a port is present or the host part is an ip address
* the dns lookup will be a "normal" one (A or AAAA).
- * - if rport is present, it's value will be used as the destination port
+ * - if rport is present, its value will be used as the destination port
* (and this will also disable srv lookups)
* - if no port is present the destination port will be taken from the srv
* lookup. If the srv lookup fails or is not performed (e.g. ip address
@@ -1459,7 +1459,7 @@ void process_lumps( struct sip_msg* msg,
/* skip len bytes from orig msg */
s_offset+=t->len;
} else if (t->op==LUMP_DEL && flag == FLAG_MSG_LUMPS_ONLY) {
- /* copy lump value and indent as necessarely */
+ /* copy lump value and indent as necessarily */
memcpy(new_buf+offset, orig + t->u.offset, t->len);
offset+=t->len;
if (new_buf[offset-1] != '\n') {
@@ -1592,7 +1592,7 @@ static inline int adjust_clen(struct sip_msg* msg, int body_delta, int proto)
/* The body has been changed, try to find
* existing Content-Length
*/
- /* no need for Content-Length if it's and UDP packet and
+ /* no need for Content-Length if it's an UDP packet and
* it hasn't Content-Length already */
if (msg->content_length==0){
/* content-length doesn't exist, append it */
@@ -1938,7 +1938,7 @@ int check_boundaries(struct sip_msg *msg, struct dest_info *send_info)
/** builds a request in memory from another sip request.
*
* Side-effects: - it adds lumps to the msg which are _not_ cleaned.
- * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENLENGTH_T
+ * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENTLENGTH_T
* and HDR_ROUTE_T (when a Route: header is added as a result of a non-null
* msg->path_vec).
* - it might change send_info->proto and send_info->send_socket
@@ -2109,7 +2109,7 @@ char * build_req_buf_from_sip_req(struct sip_msg* msg,
}
received_buf = NULL;
}
- /* if rport needs to be updated, delete it if present and add it's value */
+ /* if rport needs to be updated, delete it if present and add its value */
if (rport_buf){
if (msg->via1->rport){ /* rport already present */
via_insert_param=del_lump(msg,
@@ -3075,7 +3075,7 @@ char* create_via_hf(unsigned int *len,
/* builds a char* buffer from message headers without body
* first line is excluded in case of skip_first_line=1
- * error is set -1 if the memory allocation failes
+ * error is set -1 if the memory allocation fails
*/
char * build_only_headers( struct sip_msg* msg, int skip_first_line,
unsigned int *returned_len,
@@ -3127,7 +3127,7 @@ char * build_only_headers( struct sip_msg* msg, int skip_first_line,
}
/* builds a char* buffer from message body
- * error is set -1 if the memory allocation failes
+ * error is set -1 if the memory allocation fails
*/
char * build_body( struct sip_msg* msg,
unsigned int *returned_len,
@@ -3253,7 +3253,7 @@ int build_sip_msg_from_buf(struct sip_msg *msg, char *buf, int len,
msg->buf = buf;
msg->len = len;
if (parse_msg(buf, len, msg)!=0) {
- LM_ERR("parsing failed");
+ LM_ERR("parsing failed\n");
return -1;
}
msg->set_global_address=default_global_address;
My reading of the original text:
> USE_NAPTR - if defined the naptr lookup support will be compiled in.
> NAPTR support still has to be enabled from Kamailio's config file (it's
> off by default).
was that USE_NAPTR was by default off (undefined). This change clarifies that by default USE_NAPTR is defined, but naptr support is by default disabled from the cofiguration file.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3353
-- Commit Summary --
* doc/tutorials/dns: USE_NAPTR is on by default
-- File Changes --
M doc/tutorials/dns.txt (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3353.patchhttps://github.com/kamailio/kamailio/pull/3353.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3353
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3353(a)github.com>
Module: kamailio
Branch: master
Commit: 8821d9a91ab3823d5b1d78d84332ab9965a7c6b2
URL: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-02-01T18:06:44+01:00
doc/tutorials/dns: USE_NAPTR is on by default
---
Modified: doc/tutorials/dns.txt
---
Diff: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
Patch: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
---
diff --git a/doc/tutorials/dns.txt b/doc/tutorials/dns.txt
index 442f0900f6..0cfebff3f7 100644
--- a/doc/tutorials/dns.txt
+++ b/doc/tutorials/dns.txt
@@ -143,7 +143,7 @@ DNS Resolver Options
If set to yes - the additional part is checked against the search list.
The maximum time a DNS request can take (before failing) is:
- (dns_retr_time*dns_retr_no) * (search_list_domains) If dns_try_ipv6 is yes,
+ (dns_retr_time*dns_retr_no) * (search_list_domains). If dns_try_ipv6 is yes,
multiply it again by 2.
The option combination that produces the "fastest" DNS resolver config
@@ -167,8 +167,9 @@ DNS Resolver Compile Options
----------------------------
USE_NAPTR - if defined the naptr lookup support will be compiled in.
- NAPTR support still has to be enabled from Kamailio's config file (it's
- off by default).
+ NAPTR support still has to be enabled from Kamailio's config file.
+ USE_NAPTR is defined by default. NAPTR support is disabled from the
+ config file by default.
DNS Cache and Failover Config Variables
@@ -182,7 +183,7 @@ DNS Cache and Failover Config Variables
server.
Default: on.
- use_dns_failover = on |off - if on and sending a request fails (due to not
+ use_dns_failover = on | off - if on and sending a request fails (due to not
being allowed from an onsend_route, send failure, blocklisted destination
or, when using tm, invite timeout), and the destination resolves to
multiple ip addresses and/or multiple SRV records, the send will be
@@ -260,7 +261,7 @@ DNS Cache and Failover Config Variables
Default: no
dns_cache_init = on | off - if off, the DNS cache is not initialized
- at startup and cannot be enabled runtime, that saves some memory.
+ at startup and cannot be enabled at runtime, that saves some memory.
Default: on
DNS Cache Compile Options
@@ -301,7 +302,7 @@ DNS Cache Compile Options
If this option is not defined (experimental), everything in the AR
section will be added to the cache.
- Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it
+ Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it
from DEFS list. To add a compile options add it to the make command line,
e.g.: make proper; make all extra_defs=-DUSE_DNS_FAILOVER
or for a permanent solution, edit Makefile.defs and add it to DEFS
On receiving:
```
BYE sip:127.3.4.84;line=sr-bkhov30ei16khxiahn60i3jelfjzcwdavb.a8bhyuzda8bbavz8ymwb4lsi0iqmoigitdx9vbqgv5fjhdb.j8wcg5x8evkyv5fyqdbnguztav1yamwha8bwqfz8ymwl28o** SIP/2.0
Route: <sip:7Vu+g0t42xO1vwWQTI5OE8SQTI5O1do=@111.11.111.11;transport=ws;r2=on;lr;nat=yes>
Route: <sip:127.3.4.84;line=sr-BkHOVzLFLnGq8S7T8q0D8Xcgo6YwnboD9b0bwo9imwMaclMU7WtTm1ygmpyamW.AmQNRmbdk8bGTB3YABgCEBq7ULlaQVg.eDFUAVkaeVkJ0LW6JcX8*>
Via: SIP/2.0/WSS 964rp9hud53v.invalid;branch=z9hG4bK47814
Max-Forwards: 70
To: <sip:99372@aegee.org>;tag=kejtvxx541
From: "Online" <sip:online@example.org>;tag=b7movp1df3
Call-ID: lo20t4jpu47jpvo9mkn1
CSeq: 5788 BYE
Supported: outbound
User-Agent: SIP.js/0.7.8
Content-Length: 0
```
Kamailio 5.6.3 logs:
```
20(21) ERROR: <core> [core/kemi.c:1573]: sr_kemi_core_to_proto_helper(): failed to parse nh uri [Of^U<B2>hr$-v`<A2>qa-a&jr^Y<FA>ce@1<B1>21168.0114<F1><B2>385D<FB>^Z<B2>a&sU'rD]
```
The logged unparsable part of nh uri is not part of the input.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3351
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3351(a)github.com>