It is unlikely that this patch solves any eventual issues that you had.
You changed the comparison of a pointer with NULL to 0 and, in C, NULL
and 0 are the same in context of pointers:
- https://c-faq.com/null/nullor0.html
So practically there is not change in behaviour.
Cheers,
Daniel
On 21.12.22 15:41, Olle E. Johansson wrote:
> I suggest that this patch be backported :-)
>
> Cheers,
> /O
>
>> Begin forwarded message:
>>
>> *From: *Olle E. Johansson <oej(a)edvina.net>
>> *Subject: **[sr-dev] git:master:5c90e6e2: DMQ:
>> dmq_notification_address_list is initialized to NULL*
>> *Date: *21 December 2022 at 15:27:49 CET
>> *To: *sr-dev(a)lists.kamailio.org
>> *Reply-To: *"Kamailio (SER) - Development Mailing List"
>> <sr-dev(a)lists.kamailio.org>
>>
>> Module: kamailio
>> Branch: master
>> Commit: 5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb
>> URL:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>>
>> Author: Olle E. Johansson <oej(a)edvina.net>
>> Committer: Olle E. Johansson <oej(a)edvina.net>
>> Date: 2022-12-21T15:27:28+01:00
>>
>> DMQ: dmq_notification_address_list is initialized to NULL
>>
>> This code led to random and unpredictable behaviour when loading a
>> configuration with
>> multiple notification nodes.
>>
>> ---
>>
>> Modified: src/modules/dmq/dmq.c
>>
>> ---
>>
>> Diff:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>> Patch:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>>
>> ---
>>
>> diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c
>> index 843b7e3e4d2..f4a66c3d847 100644
>> --- a/src/modules/dmq/dmq.c
>> +++ b/src/modules/dmq/dmq.c
>> @@ -379,7 +379,7 @@ static int
>> dmq_add_notification_address(modparam_t type, void * val)
>> }
>>
>> /* initial allocation */
>> -if (dmq_notification_address_list == 0) {
>> +if (dmq_notification_address_list == NULL) {
>> dmq_notification_address_list = pkg_malloc(sizeof(str_list_t));
>> if (dmq_notification_address_list == NULL) {
>> PKG_MEM_ERROR;
>>
>> _______________________________________________
>> Kamailio (SER) - Development Mailing List
>> To unsubscribe send an email to sr-dev-leave(a)lists.kamailio.org
>
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Module: kamailio
Branch: master
Commit: 5fedf169d256e7e24fe2ce2b593af9a865ac9578
URL: https://github.com/kamailio/kamailio/commit/5fedf169d256e7e24fe2ce2b593af9a…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-12-20T10:46:41+01:00
modules: readme files regenerated - app_ruby ... [skip ci]
---
Modified: src/modules/app_ruby/README
---
Diff: https://github.com/kamailio/kamailio/commit/5fedf169d256e7e24fe2ce2b593af9a…
Patch: https://github.com/kamailio/kamailio/commit/5fedf169d256e7e24fe2ce2b593af9a…
---
diff --git a/src/modules/app_ruby/README b/src/modules/app_ruby/README
index 7d68583ccd..2554a990f8 100644
--- a/src/modules/app_ruby/README
+++ b/src/modules/app_ruby/README
@@ -135,15 +135,15 @@ modparam("app_ruby", "load", "/usr/local/etc/kamailio/ruby/myscript.rb")
internal functions from the app_ruby module, otherwise the ones from
core are used.
- Note: when set to 1, there were crashing reports that are under
- investigation, this option being provided as intermediary solution to
- preserve the behaviour from older versions.
+ Note: upt to version 5.7, when set to 1, there were crashing reports
+ that are under investigation, this option being provided as
+ intermediary solution to preserve the behaviour from older versions.
- Default value is ���0���.
+ Default value is ���1���.
Example 1.2. Set xval_mode parameter
...
-modparam("app_ruby", "xval_mode", 1)
+modparam("app_ruby", "xval_mode", 0)
...
3.3. modproc (str)
Module: kamailio
Branch: master
Commit: 4b5cdf184a77e60d75f1ddf1cd666c6f36a76d48
URL: https://github.com/kamailio/kamailio/commit/4b5cdf184a77e60d75f1ddf1cd666c6…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-12-19T21:36:11+01:00
app_ruby: docs updated for xval_mode param
---
Modified: src/modules/app_ruby/doc/app_ruby_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/4b5cdf184a77e60d75f1ddf1cd666c6…
Patch: https://github.com/kamailio/kamailio/commit/4b5cdf184a77e60d75f1ddf1cd666c6…
---
diff --git a/src/modules/app_ruby/doc/app_ruby_admin.xml b/src/modules/app_ruby/doc/app_ruby_admin.xml
index ff957c6646..ae81a2a961 100644
--- a/src/modules/app_ruby/doc/app_ruby_admin.xml
+++ b/src/modules/app_ruby/doc/app_ruby_admin.xml
@@ -98,20 +98,20 @@ modparam("app_ruby", "load", "/usr/local/etc/kamailio/ruby/myscript.rb")
core are used.
</para>
<para>
- Note: when set to 1, there were crashing reports that are under
- investigation, this option being provided as intermediary
- solution to preserve the behaviour from older versions.
+ Note: upt to version 5.7, when set to 1, there were crashing
+ reports that are under investigation, this option being provided
+ as intermediary solution to preserve the behaviour from older versions.
</para>
<para>
<emphasis>
- Default value is <quote>0</quote>.
+ Default value is <quote>1</quote>.
</emphasis>
</para>
<example>
<title>Set <varname>xval_mode</varname> parameter</title>
<programlisting format="linespecific">
...
-modparam("app_ruby", "xval_mode", 1)
+modparam("app_ruby", "xval_mode", 0)
...
</programlisting>
</example>
Module: kamailio
Branch: master
Commit: bcb37da492fad5c6811784370cfd25cb5efdcf64
URL: https://github.com/kamailio/kamailio/commit/bcb37da492fad5c6811784370cfd25c…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2022-12-19T12:05:04+08:00
tlsa: add clarification comment about LIBSSL_STATIC_SRCPATH
* if LIBSSL_STATIC_SRCPATH is set to the installation folder
of libssl.a and libcrypto.a,
then headers will be in $LIBSSL_STATIC_SRCPATH/../include
* this covers the case where tlsa is built on a system with a local
installation of OpenSSL without the source code available
---
Modified: src/modules/tlsa/Makefile
---
Diff: https://github.com/kamailio/kamailio/commit/bcb37da492fad5c6811784370cfd25c…
Patch: https://github.com/kamailio/kamailio/commit/bcb37da492fad5c6811784370cfd25c…
---
diff --git a/src/modules/tlsa/Makefile b/src/modules/tlsa/Makefile
index 528c983b15..28b5c2692d 100644
--- a/src/modules/tlsa/Makefile
+++ b/src/modules/tlsa/Makefile
@@ -10,7 +10,9 @@ NAME=tlsa.so
# set to yes when wanting to link with static libraries compiled from source
LIBSSL_STATIC_SRCLIB ?= no
-# set to the path of the folder with static libraries compiled from source
+# set to the path of the folder with static libraries compiled from source;
+# can also be the folder where static OpenSSL libraries are installed
+# in which case headers are expected to be in $LIBSSL_STATIC_SRCPATH/../include
LIBSSL_STATIC_SRCPATH ?= /usr/local/src/openssl
# or set to the path where the static libraries are installed, for example:
# LIBSSL_STATIC_SRCPATH ?= /usr/lib/x86_64-linux-gnu/
Module: kamailio
Branch: 5.5
Commit: 3d45b091a6983694fbd440ab2f33f1b7abe8f6a1
URL: https://github.com/kamailio/kamailio/commit/3d45b091a6983694fbd440ab2f33f1b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-12-18T11:17:05+01:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/registrar/README
---
Diff: https://github.com/kamailio/kamailio/commit/3d45b091a6983694fbd440ab2f33f1b…
Patch: https://github.com/kamailio/kamailio/commit/3d45b091a6983694fbd440ab2f33f1b…
---
diff --git a/src/modules/registrar/README b/src/modules/registrar/README
index 83830b5885..d146d62bba 100644
--- a/src/modules/registrar/README
+++ b/src/modules/registrar/README
@@ -1105,7 +1105,7 @@ lookup_branches("location");
4.5. registered(domain [, uri [, match_option [, match_action]]])
The function returns true if the AOR in the URI is registered, false
- otherwise. The function does not modify the message being process, it
+ otherwise. The function does not modify the message being processed, it
neither rewrites the Request-URI if a contact is found nor append
branches. If uri parameter is not provided, then it considered to be
the Request-URI for SIP requests and To-URI for SIP replies.
Module: kamailio
Branch: 5.5
Commit: bd0fb7164bda717363fc72a726330ad58d0cc860
URL: https://github.com/kamailio/kamailio/commit/bd0fb7164bda717363fc72a726330ad…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2022-12-18T10:04:50Z
registrar: typo
(cherry picked from commit c738a65c2fd0a40c3cdc236a3d3b48b0d18add21)
(cherry picked from commit a3f5abb0852d8c7d4006724639605cc26e74806b)
---
Modified: src/modules/registrar/doc/registrar_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/bd0fb7164bda717363fc72a726330ad…
Patch: https://github.com/kamailio/kamailio/commit/bd0fb7164bda717363fc72a726330ad…
---
diff --git a/src/modules/registrar/doc/registrar_admin.xml b/src/modules/registrar/doc/registrar_admin.xml
index fad2e968cb..7e00382a33 100644
--- a/src/modules/registrar/doc/registrar_admin.xml
+++ b/src/modules/registrar/doc/registrar_admin.xml
@@ -1416,7 +1416,7 @@ lookup_branches("location");
<para>
The function returns true if the AOR in the URI is
registered, false otherwise. The function does not modify the
- message being process, it neither rewrites the Request-URI if a
+ message being processed, it neither rewrites the Request-URI if a
contact is found nor append branches. If uri parameter is not
provided, then it considered to be the Request-URI for SIP requests
and To-URI for SIP replies.
According to https://www.kamailio.org/docs/modules/5.6.x/modules/corex.html#corex.f.file… the functions cores.file_read() and cores.file_write() do not return a value (return void). The examples after functions are `if (file_write("z', "z")) {...}`. Since the functions appear in `if ()` they return se value.
* document the return values of both functions
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3314
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3314(a)github.com>