- sr-dev - kamailio.org

[kamailio/kamailio] [Websocket] websocket:closed sometimes is not fired (Issue #3950)
by Gustavo Almeida 23 Jun '25

23 Jun '25

### Description After carrying out some load tests using the `Websocket` module, I noticed that sometimes the `websocket:closed` event is not triggered. This problem seems to be particularly noticeable when the load is high and simultaneous. Example: 1000 records simultaneously. In the tests carried out, I realized that the number of times the event is not triggered is small, in the order of [1-10]/1000. I check that when I do a `ws.dump` I don't have any active connections, and I confirm that they are all effectively cleaned (`netstat -ano | grep 8061`). However, the event is not triggered for some connections. I can see this in the logs, and also when i display the content of an hash table, i'm dropping key inside `websocket:closed` event. ### Troubleshooting The troubleshooting was simplistic, i.e. I ran the same test n times, and validated that the event was triggered for all connections, the number of `ws` connections listed by `Kamailio`, and the open connections. #### Reproduction To reproduce, we can use any mechanism that emulates the use of the `Websocket` module. For example, I used the `sipexer` tool to create a `wss` connection with `Kamailio`, forcing simultaneous registrations. Example command: `sipexer -cb -mt register -ex 60 -au <user> -ap <pass> -fuser example -fd mydomain -wso https://10.0.0.12:10000 -ruri sip:kamailio -su wss://kamailio:8061` Kamailio TLS listener: `listen=tls:10.0.0.12:8061 advertise PUBLIC_IP` Websocket module: ``` loadmodule "websocket.so" tcp_accept_no_cl=yes ``` ``` event_route[websocket:closed] { xlog("L_NOTICE", "WebSocket connection closed $proto:$si:$sp\n"); <I also delete where a htable key> } ``` #### Debugging Data ``` [root@ ~]$ prcmd ws.dump { connections: { } info: { wscounter: 0 truncated: no } } [root@ ~]$ netstat -ano | grep 8061 tcp 0 0 10.0.0.12:8061 0.0.0.0:* LISTEN off (0.00/0/0) [root ~]$ prcmd htable.dump wsauth | grep "name" | wc -l 3 [root ~]$ cat /var/log/kamailio.log | grep "WebSocket connection closed" | wc -l 997 [root ~]$ cat /var/log/proxy-registrar/proxy-registrar.log | grep "ERR" | grep "WAR" | wc -l 0 ``` #### Log Messages Nothing relevant. #### SIP Traffic Nothing relevant here, the SIP Flow is OK. ### Additional Information ``` version: kamailio 5.6.4 (x86_64/linux) a004cf-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf -dirty compiled on 23:17:27 Jun 7 2024 with gcc 4.8.5 ``` * **Operating System**: ``` CentOS Linux release 7.9.2009 (Core) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3950 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3950(a)github.com>

6 5

git:master:e77ba1cd: websocket: set the field for event route execution on timer removing
by Daniel-Constantin Mierla 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: e77ba1cdf80b384bc55cc457d280b5fc0aef80db URL: https://github.com/kamailio/kamailio/commit/e77ba1cdf80b384bc55cc457d280b5f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-23T13:36:50+02:00 websocket: set the field for event route execution on timer removing - GH #3950 --- Modified: src/modules/websocket/ws_conn.c --- Diff: https://github.com/kamailio/kamailio/commit/e77ba1cdf80b384bc55cc457d280b5f… Patch: https://github.com/kamailio/kamailio/commit/e77ba1cdf80b384bc55cc457d280b5f… --- diff --git a/src/modules/websocket/ws_conn.c b/src/modules/websocket/ws_conn.c index 2de1adf5e3f..945c38af924 100644 --- a/src/modules/websocket/ws_conn.c +++ b/src/modules/websocket/ws_conn.c @@ -709,6 +709,7 @@ void ws_timer(unsigned int ticks, void *param) LM_DBG("ws structure without active tcp connection\n"); wsc->state = WS_S_REMOVING; wsc->rmticks = get_ticks(); + wsc->run_event = 1; } else { tcpconn_put(con); }

1 0

git:master:868240b7: websocket: updated a couple of debug messages with id and hash id
by Daniel-Constantin Mierla 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: 868240b75b9bc6a2263a31a46038d11064269000 URL: https://github.com/kamailio/kamailio/commit/868240b75b9bc6a2263a31a46038d11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-23T13:36:50+02:00 websocket: updated a couple of debug messages with id and hash id --- Modified: src/modules/websocket/ws_conn.c --- Diff: https://github.com/kamailio/kamailio/commit/868240b75b9bc6a2263a31a46038d11… Patch: https://github.com/kamailio/kamailio/commit/868240b75b9bc6a2263a31a46038d11… --- diff --git a/src/modules/websocket/ws_conn.c b/src/modules/websocket/ws_conn.c index 9fa3125343c..2de1adf5e3f 100644 --- a/src/modules/websocket/ws_conn.c +++ b/src/modules/websocket/ws_conn.c @@ -329,7 +329,8 @@ static void wsconn_dtor(ws_connection_t *wsc) if(!wsc) return; - LM_DBG("wsconn_dtor for [%p] refcnt [%d]\n", wsc, atomic_get(&wsc->refcnt)); + LM_DBG("wsconn id: %d / %u [%p] refcnt [%d]\n", wsc->id, wsc->id_hash, wsc, + atomic_get(&wsc->refcnt)); if(wsc->run_event) wsconn_run_route(wsc); @@ -338,12 +339,13 @@ static void wsconn_dtor(ws_connection_t *wsc) shm_free(wsc); - LM_DBG("wsconn_dtor for [%p] destroyed\n", wsc); + LM_DBG("wsconn id: %d / %u [%p] destroyed\n", wsc->id, wsc->id_hash, wsc); } int wsconn_rm(ws_connection_t *wsc, ws_conn_eventroute_t run_event_route) { - LM_DBG("wsconn_rm for [%p] refcnt [%d]\n", wsc, atomic_get(&wsc->refcnt)); + LM_DBG("remove wscon id: %d / %u [%p] refcnt [%d]\n", wsc->id, wsc->id_hash, + wsc, atomic_get(&wsc->refcnt)); if(run_event_route == WSCONN_EVENTROUTE_YES) wsc->run_event = 1;

1 0

git:master:0f34b62a: core: tcp - increase the TCP_ID_HASH_SIZE
by Daniel-Constantin Mierla 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: 0f34b62ad21e57a21ed2b478cbdb784787b2adab URL: https://github.com/kamailio/kamailio/commit/0f34b62ad21e57a21ed2b478cbdb784… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-23T13:36:50+02:00 core: tcp - increase the TCP_ID_HASH_SIZE - now 2048 instead of 1024 --- Modified: src/core/tcp_conn.h --- Diff: https://github.com/kamailio/kamailio/commit/0f34b62ad21e57a21ed2b478cbdb784… Patch: https://github.com/kamailio/kamailio/commit/0f34b62ad21e57a21ed2b478cbdb784… --- diff --git a/src/core/tcp_conn.h b/src/core/tcp_conn.h index bd394c5a57c..ea1f6b6329a 100644 --- a/src/core/tcp_conn.h +++ b/src/core/tcp_conn.h @@ -376,7 +376,7 @@ typedef struct tcp_connection #define TCPCONN_UNLOCK lock_release(tcpconn_lock); #define TCP_ALIAS_HASH_SIZE 4096 -#define TCP_ID_HASH_SIZE 1024 +#define TCP_ID_HASH_SIZE 2048 /* hash (dst_ip, dst_port, local_ip, local_port) */ static inline unsigned tcp_addr_hash(struct ip_addr *ip, unsigned short port,

1 0

git:master:6faf0470: tls: use SSL_CTX_set_ciphersuites() when using openSSL 1.1.1
by Henning Westerholt 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: 6faf0470d0fab1594249e43d91000f324c5e25a7 URL: https://github.com/kamailio/kamailio/commit/6faf0470d0fab1594249e43d91000f3… Author: Nicolas Chapleau <nicchap(a)outlook.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-23T10:42:09Z tls: use SSL_CTX_set_ciphersuites() when using openSSL 1.1.1 --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/6faf0470d0fab1594249e43d91000f3… Patch: https://github.com/kamailio/kamailio/commit/6faf0470d0fab1594249e43d91000f3… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index 6527b16a9fa..c7f35df63ee 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -737,11 +737,27 @@ static int set_cipher_list(tls_domain_t *d) return 0; procs_no = get_max_procs(); for(i = 0; i < procs_no; i++) { +#if OPENSSL_VERSION_NUMBER < 0x030000000L if(SSL_CTX_set_cipher_list(d->ctx[i], cipher_list) == 0) { ERR("%s: Failure to set SSL context cipher list \"%s\"\n", tls_domain_str(d), cipher_list); return -1; } +#else + if(d->method == TLS_USE_TLSv1_3 || d->method == TLS_USE_TLSv1_3_PLUS) { + if(SSL_CTX_set_ciphersuites(d->ctx[i], cipher_list) == 0) { + ERR("%s: Failure to set SSL context cipher suites \"%s\"\n", + tls_domain_str(d), cipher_list); + return -1; + } else { + if(SSL_CTX_set_cipher_list(d->ctx[i], cipher_list) == 0) { + ERR("%s: Failure to set SSL context cipher list \"%s\"\n", + tls_domain_str(d), cipher_list); + return -1; + } + } + } +#endif #if !defined(OPENSSL_NO_ECDH) && OPENSSL_VERSION_NUMBER < 0x10100000L setup_ecdh(d->ctx[i]); #endif

1 0

git:master:d049b58b: modules: readme files regenerated - registrar ... [skip ci]
by Kamailio Dev 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: d049b58b4e528e7ec8420465abfa7558b17a499c URL: https://github.com/kamailio/kamailio/commit/d049b58b4e528e7ec8420465abfa755… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-23T12:31:09+02:00 modules: readme files regenerated - registrar ... [skip ci] --- Modified: src/modules/registrar/README --- Diff: https://github.com/kamailio/kamailio/commit/d049b58b4e528e7ec8420465abfa755… Patch: https://github.com/kamailio/kamailio/commit/d049b58b4e528e7ec8420465abfa755… --- diff --git a/src/modules/registrar/README b/src/modules/registrar/README index fea39e0a62e..aeb0b5414fe 100644 --- a/src/modules/registrar/README +++ b/src/modules/registrar/README @@ -1134,6 +1134,7 @@ lookup_branches("location"); * uri - the URI to be searched in location table. * rxname - name of the XAVP to store record attributes. These are: + aor - the address of record. + + count - the number of contacts. * cxname - name of the XAVP to store content attributes, name mapping is done from the perspective of using them to send out SIP requests. These are: @@ -1148,9 +1149,9 @@ lookup_branches("location"); ... lookup_xavp("location", "$fu", "rul", "cul"); xinfo("aor: $xavp(rul=>aor)\n"); -xinfo("number of contacts: $xavp(rul>count)\n"); -xinfo("first contact record - uri: $xavp(cul>uri)\n"); -xinfo("first contact record - socket: $xavp(cul>socket)\n"); +xinfo("number of contacts: $xavp(rul=>count)\n"); +xinfo("first contact record - uri: $xavp(cul=>uri)\n"); +xinfo("first contact record - socket: $xavp(cul=>socket)\n"); ... 4.6. registered(domain [, uri [, match_option [, match_action]]])

1 0

git:master:25067526: registrar: docs: Add count attribute docs
by Xenofon Karamanos 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: 25067526ab659a336067e54a84b7a7b71e597dd3 URL: https://github.com/kamailio/kamailio/commit/25067526ab659a336067e54a84b7a7b… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-06-23T10:20:39Z registrar: docs: Add count attribute docs - Fix spelling mistake for accesing xavp --- Modified: src/modules/registrar/doc/registrar_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/25067526ab659a336067e54a84b7a7b… Patch: https://github.com/kamailio/kamailio/commit/25067526ab659a336067e54a84b7a7b… --- diff --git a/src/modules/registrar/doc/registrar_admin.xml b/src/modules/registrar/doc/registrar_admin.xml index 848e5ae40e1..fc1e5a0fc03 100644 --- a/src/modules/registrar/doc/registrar_admin.xml +++ b/src/modules/registrar/doc/registrar_admin.xml @@ -1496,6 +1496,11 @@ lookup_branches("location"); <emphasis>aor</emphasis> - the address of record. </para> </listitem> + <listitem> + <para> + <emphasis>count</emphasis> - the number of contacts. + </para> + </listitem> </itemizedlist> </listitem> <listitem> @@ -1533,9 +1538,9 @@ lookup_branches("location"); ... lookup_xavp("location", "$fu", "rul", "cul"); xinfo("aor: $xavp(rul=>aor)\n"); -xinfo("number of contacts: $xavp(rul>count)\n"); -xinfo("first contact record - uri: $xavp(cul>uri)\n"); -xinfo("first contact record - socket: $xavp(cul>socket)\n"); +xinfo("number of contacts: $xavp(rul=>count)\n"); +xinfo("first contact record - uri: $xavp(cul=>uri)\n"); +xinfo("first contact record - socket: $xavp(cul=>socket)\n"); ... </programlisting> </example> @@ -2086,4 +2091,3 @@ if(reg_fetch_contacts("location", "$fu", "caller")) </section> </chapter> -

1 0

[kamailio/kamailio] dialplan: improve performance by reusing PCRE structure (PR #4289)
by Lucian Balaceanu 23 Jun '25

23 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  By reusing the pcre_md structure needed by pcre2_match function we see improvements of 10x in the time of dp_translate() function call (via benchmark module). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4289 -- Commit Summary -- * dialplan: improve performance by reusing PCRE structure -- File Changes -- M src/modules/dialplan/dp_repl.c (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4289.patch https://github.com/kamailio/kamailio/pull/4289.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4289 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4289(a)github.com>

3 6

git:master:6d1f59df: dialplan: improve performance by reusing PCRE structure
by Victor Seva 23 Jun '25

23 Jun '25

Module: kamailio Branch: master Commit: 6d1f59df690ace49752be7b6abe6ab5f50aa5e72 URL: https://github.com/kamailio/kamailio/commit/6d1f59df690ace49752be7b6abe6ab5… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-06-23T10:31:38+02:00 dialplan: improve performance by reusing PCRE structure --- Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/6d1f59df690ace49752be7b6abe6ab5… Patch: https://github.com/kamailio/kamailio/commit/6d1f59df690ace49752be7b6abe6ab5… --- diff --git a/src/modules/dialplan/dp_repl.c b/src/modules/dialplan/dp_repl.c index d78db14eb68..82f7e32584d 100644 --- a/src/modules/dialplan/dp_repl.c +++ b/src/modules/dialplan/dp_repl.c @@ -409,7 +409,7 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, int repl_nb, offset, match_nb, rc, cap_cnt; struct replace_with token; struct subst_expr *repl_comp; - pcre2_match_data *pcre_md = NULL; + static pcre2_match_data *pcre_md = NULL; str match; pv_value_t sv; str *uri; @@ -427,6 +427,14 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, return 0; } + if(pcre_md == NULL) { + pcre_md = pcre2_match_data_create(MAX_REPLACE_WITH, NULL); + if(pcre_md == NULL) { + LM_ERR("failed to allocate pcre2_match_data\n"); + return -1; + } + } + if(subst_comp) { /*just in case something went wrong at load time*/ rc = pcre2_pattern_info(subst_comp, PCRE2_INFO_CAPTURECOUNT, &cap_cnt); @@ -446,7 +454,6 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, } /*search for the pattern from the compiled subst_exp*/ - pcre_md = pcre2_match_data_create_from_pattern(subst_comp, NULL); if(pcre2_match(subst_comp, (PCRE2_SPTR)instr->s, (PCRE2_SIZE)instr->len, 0, 0, pcre_md, NULL) <= 0) { @@ -454,8 +461,6 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, "the match_exp %.*s but not the subst_exp %.*s!\n", instr->len, instr->s, rule->match_exp.len, rule->match_exp.s, rule->subst_exp.len, rule->subst_exp.s); - if(pcre_md) - pcre2_match_data_free(pcre_md); return -1; } ovector = pcre2_get_ovector_pointer(pcre_md); @@ -472,8 +477,6 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, memcpy(result->s, repl_comp->replacement.s, repl_comp->replacement.len); result->len = repl_comp->replacement.len; result->s[result->len] = '\0'; - if(pcre_md) - pcre2_match_data_free(pcre_md); return 0; } @@ -582,15 +585,11 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule, } result->s[result->len] = '\0'; - if(pcre_md) - pcre2_match_data_free(pcre_md); return 0; error: result->s = 0; result->len = 0; - if(pcre_md) - pcre2_match_data_free(pcre_md); return -1; } @@ -599,7 +598,7 @@ static char dp_attrs_buf[DP_MAX_ATTRS_LEN + 1]; int dp_translate_helper( sip_msg_t *msg, str *input, str *output, dpl_id_p idp, str *attrs) { - pcre2_match_data *pcre_md = NULL; + static pcre2_match_data *pcre_md = NULL; dpl_node_p rulep; dpl_index_p indexp; int user_len, rez; @@ -622,6 +621,14 @@ int dp_translate_helper( return -1; } + if(pcre_md == NULL) { + pcre_md = pcre2_match_data_create(MAX_REPLACE_WITH, NULL); + if(pcre_md == NULL) { + LM_ERR("failed to allocate pcre2_match_data\n"); + return -1; + } + } + search_rule: for(rulep = indexp->first_rule; rulep != NULL; rulep = rulep->next) { switch(rulep->matchop) { @@ -640,8 +647,6 @@ int dp_translate_helper( rez = -1; do { if(rez < 0) { - pcre_md = pcre2_match_data_create_from_pattern( - re_list->re, NULL); rez = pcre2_match(re_list->re, (PCRE2_SPTR)input->s, (PCRE2_SIZE)input->len, 0, 0, pcre_md, NULL); @@ -651,18 +656,13 @@ int dp_translate_helper( LM_DBG("match check skipped: [%.*s] %d\n", re_list->expr.len, re_list->expr.s, rez); rt = re_list->next; - if(pcre_md) - pcre2_match_data_free(pcre_md); pcre2_code_free(re_list->re); pkg_free(re_list); re_list = rt; } while(re_list); } else { - pcre_md = pcre2_match_data_create_from_pattern( - rulep->match_comp, NULL); rez = pcre2_match(rulep->match_comp, (PCRE2_SPTR)input->s, (PCRE2_SIZE)input->len, 0, 0, pcre_md, 0); - pcre2_match_data_free(pcre_md); } break;

1 0

[kamailio/kamailio] Handling Duplicate Values in secfilter Module's kamcmd Commands (Issue #4091)
by AsedMorteza 23 Jun '25

23 Jun '25

**Description** The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values? Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes: `kamcmd secfilter.del_bl user 1005` I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place. **Proposed Solutions** 1. **Prevent Duplicates in Existing `add` Commands:** * I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance. 2. **Introduce New `add_unique` Commands:** * I can maintain the current `add` commands for backward compatibility. * I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries. **Recommendation** I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach. **Further Considerations** * Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered. * Document the behavior of duplicate values in the `secfilter` module's documentation. **I would appreciate your feedback and guidance on the best course of action.** -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4091 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4091(a)github.com>

6 12

git:6.0:1c2ed9b6: github: added multiarch support for rpm generation [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 1c2ed9b6c1a4c82bb9fe8a98271bae3db3acee5b URL: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:53:06+03:00 github: added multiarch support for rpm generation [skip ci] (cherry picked from commit 76b6e3b9733d0382348da1a80c3cdeecec44415e) --- Modified: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3… Patch: https://github.com/kamailio/kamailio/commit/1c2ed9b6c1a4c82bb9fe8a98271bae3…

1 0

git:6.0:1f305801: github: generate rpm packages
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 1f3058011f8f45f8d7ad2eb68294a9b9c6e82bcd URL: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:28:27+03:00 github: generate rpm packages (cherry picked from commit afa2d017e3b5a1f5a776935767e485c1158be461) --- Added: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… Patch: https://github.com/kamailio/kamailio/commit/1f3058011f8f45f8d7ad2eb68294a9b… --- diff --git a/.github/workflows/rpm.yml b/.github/workflows/rpm.yml new file mode 100644 index 00000000000..0d890b63a8c --- /dev/null +++ b/.github/workflows/rpm.yml @@ -0,0 +1,89 @@ +--- +name: build_rpm +'on': + schedule: + - cron: '41 6 * * 0' + push: + tags: + - '[0-9]+.[0-9]+.[0-9]+' +jobs: + # is required nightly build? + # More info at https://stackoverflow.com/questions/63014786/how-to-schedule-a-github-actio… + # looking commit_id of the last successful daily build + check: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: octokit/request-action(a)v2.x + id: check_last_run + with: + route: GET /repos/{owner}/{repo}/actions/workflows/rpm.yml/runs?per_page=1&status=success + owner: ${{ github.repository_owner }} + repo: kamailio + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Show last execution info + run: | + echo "Last daily build: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }}" + + outputs: + last_sha: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }} + + native: + needs: [check] + if: needs.check.outputs.last_sha != github.sha + strategy: + matrix: + os: + - centos-10 + - rhel-10 + - centos-9 + - rhel-9 + - centos-8 + - rhel-8 + runner: + - ubuntu-latest + - ubuntu-24.04-arm + runs-on: ${{ matrix.runner }} + permissions: + contents: write + steps: + - name: checkout sources + uses: actions/checkout@v4 + + - name: print commit info and init hosttype var + id: init + run: | + echo ${{ github.sha }} + echo "hosttype=${HOSTTYPE}" >> $GITHUB_OUTPUT + + - name: build rpm files + uses: addnab/docker-run-action@v3 + with: + image: safarov/kamailio-builder:${{ matrix.os }} + options: -v ${{ github.workspace }}:/usr/src/kamailio + run: | + cd /usr/src/kamailio + make cfg + make -C pkg/kamailio src.rpm + rpmbuild -ra /usr/src/kamailio/kamailio*.src.rpm + cp -R /deps ~/rpmbuild/RPMS + mv ~/rpmbuild/SRPMS/* ~/rpmbuild/RPMS + mv ~/rpmbuild/RPMS . + tar czf kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz RPMS + + - name: Push artifacts + uses: actions/upload-artifact@v4 + if: "! startsWith(github.ref, 'refs/tags/')" + with: + name: kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm + path: | + RPMS/* + + - name: Release + uses: softprops/action-gh-release@v2 + if: "startsWith(github.ref, 'refs/tags/')" + with: + files: | + kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz

1 0

git:6.0:3bb3b4ef: pkg/kamailio: use radcli on RHEL based dist [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 3bb3b4ef8f38e944bbae94ccc51c25b3330d2faa URL: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:31:02+03:00 pkg/kamailio: use radcli on RHEL based dist [skip ci] (cherry picked from commit c2fc809059e0c70aa4324f5727666989ee8aff05) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… Patch: https://github.com/kamailio/kamailio/commit/3bb3b4ef8f38e944bbae94ccc51c25b… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index c6e2f5929ab..68b7c46b90f 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -746,8 +746,8 @@ Summary: RADIUS modules for Kamailio Group: %{PKGGROUP} Requires: kamailio = %ver %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} -Requires: freeradius-client -BuildRequires: freeradius-client-devel +Requires: radcli +BuildRequires: radcli-devel %else Requires: radiusclient-ng BuildRequires: radiusclient-ng-devel @@ -1072,7 +1072,7 @@ rm -f misc/examples/pkg/sipcapture.cfg %build %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 -export FREERADIUS=1 +export RADCLI=1 %endif make cfg prefix=/usr \ basedir=%{buildroot} \ @@ -1084,7 +1084,7 @@ make make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ jabber ndb_cassandra osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \ @@ -1192,7 +1192,7 @@ make install make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ iptrtpproxy jabber osp" \ %if 0%{?fedora} || 0%{?suse_version} || 0%{?rhel} >= 8 - FREERADIUS=1 \ + RADCLI=1 \ %endif %if 0%{?rhel} >= 8 PYTHON3=python3.12 \

1 0

git:6.0:b80dd574: pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: b80dd57418fa1dad8a333f11f64f5a9df3e65332 URL: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:30:46+03:00 pkg/kamailio: removed RHEL 6 and 7 if macros from RPM spec file (cherry picked from commit 701d07df14d0d66125ff0ff3adec3ce424929472) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9… Patch: https://github.com/kamailio/kamailio/commit/b80dd57418fa1dad8a333f11f64f5a9…

1 0

git:6.0:6d0c691c: pkg/kamailio: sipcapture remove
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: 6.0 Commit: 6d0c691c379a8798822c5672d3fd515eb01f5394 URL: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T19:30:15+03:00 pkg/kamailio: sipcapture remove (cherry picked from commit a7c4d4003dced50b3f6cbc7c9c6235e6bf894334) --- Modified: pkg/kamailio/obs/kamailio.spec Removed: pkg/kamailio/obs/sipcapture.service Removed: pkg/kamailio/obs/sipcapture.sysconfig Removed: pkg/kamailio/obs/sipcapture.tmpfiles --- Diff: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515… Patch: https://github.com/kamailio/kamailio/commit/6d0c691c379a8798822c5672d3fd515…

1 0

git:master:76b6e3b9: github: added multiarch support for rpm generation [skip ci]
by Sergey Safarov 22 Jun '25

22 Jun '25

Module: kamailio Branch: master Commit: 76b6e3b9733d0382348da1a80c3cdeecec44415e URL: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-22T20:50:02+03:00 github: added multiarch support for rpm generation [skip ci] --- Modified: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee… Patch: https://github.com/kamailio/kamailio/commit/76b6e3b9733d0382348da1a80c3cdee…

1 0

[kamailio/kamailio] extra bytes should be ignored when Content-Length header present (Issue #4290)
by sergey-safarov 22 Jun '25

22 Jun '25

sergey-safarov created an issue (kamailio/kamailio#4290) ### Description According to [RFC3261](https://www.ietf.org/rfc/rfc3261.html#section-18.3) Section 18.3 ``` In the case of message-oriented transports (such as UDP), if the message has a Content-Length header field, the message body is assumed to contain that many bytes. If there are additional bytes in the transport packet beyond the end of the body, they MUST be discarded. ``` In the current Kamailio implementation, extra bytes are analyzed, and this triggers a failed sanity check. ### Troubleshooting #### Reproduction To reproduce required prepare config file ``` listen=udp:127.0.0.1:5060 loadmodule "xlog.so" loadmodule "sl.so" loadmodule "sanity.so" modparam("sanity", "autodrop", 0) modparam("sanity", "noreply", 1) route{ if(sanity_check()) { sl_send_reply("200", "OK"); exit; } xerr("sanity checks failed\n"); sanity_reply(); drop; } ``` And start using a command like ``` kamailio -DD -E -f kamailio.cfg ``` Then need to send options using a command like ``` cat options-extra.txt | nc -u 127.0.0.1 5060 ``` Where `options-extra.txt` is a file from the attached archive [options.tar.gz](https://github.com/user-attachments/files/20838024/options.… If you remove extra bytes after the OPTIONS message, then Kamailio does not generate an error. This can be tested using the command ``` cat options-normal.txt | nc -u 127.0.0.1 5060 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4290 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4290(a)github.com>

3 6

git:6.0:4e221917: pkg/kamailio/alpine: add missing dependency for jwt module [skip ci]
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 4e221917fc18463e8a7a1a5f6db13e8da6785ed0 URL: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T21:17:31+03:00 pkg/kamailio/alpine: add missing dependency for jwt module [skip ci] related #4132 (cherry picked from commit 95d0c1fc38da00dc6bbda19dba1ac4b20535abf5) --- Modified: pkg/kamailio/alpine/APKBUILD --- Diff: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… Patch: https://github.com/kamailio/kamailio/commit/4e221917fc18463e8a7a1a5f6db13e8… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index fe941ec28e5..2215305313f 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -32,7 +32,7 @@ makedepends="bison db-dev flex freeradius-client-dev expat-dev net-snmp-dev libuuid libev-dev jansson-dev json-c-dev libevent-dev linux-headers libmemcached-dev rabbitmq-c-dev hiredis-dev ruby-dev libmaxminddb-dev libunistring-dev mongo-c-driver-dev - libwebsockets-dev mosquitto-dev librdkafka-dev nghttp2-dev" + libwebsockets-dev mosquitto-dev librdkafka-dev nghttp2-dev libjwt-dev" install="$pkgname.pre-install $pkgname.pre-upgrade"

1 0

git:6.0:6edde708: pkg/kamailio: for dispatcher work required working DNS resolution daemon
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 6edde7080fd5f7fb6a547f6de5c5b7c104cb493a URL: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T21:17:12+03:00 pkg/kamailio: for dispatcher work required working DNS resolution daemon (cherry picked from commit aa7b2460ff0d8085ddc8ae9232a9fea0fe0db5f8) --- Modified: pkg/kamailio/obs/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… Patch: https://github.com/kamailio/kamailio/commit/6edde7080fd5f7fb6a547f6de5c5b7c… --- diff --git a/pkg/kamailio/obs/kamailio.service b/pkg/kamailio/obs/kamailio.service index 0c4fbc49caf..0a527056f91 100644 --- a/pkg/kamailio/obs/kamailio.service +++ b/pkg/kamailio/obs/kamailio.service @@ -1,8 +1,8 @@ [Unit] Description=Kamailio - the Open Source SIP Server Documentation=man:kamailio(8) -Wants=network-online.target -After=network-online.target +Wants=network-online.target nss-lookup.target +After=network-online.target nss-lookup.target [Service] Type=simple

1 0

git:6.0:d4159f45: pkg/kamailio: updated alpine build rules
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: d4159f45972bad6151649d190f4e6c35c3259e5f URL: https://github.com/kamailio/kamailio/commit/d4159f45972bad6151649d190f4e6c3… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T17:21:54+03:00 pkg/kamailio: updated alpine build rules (cherry picked from commit 9ddd70a45168c618a3ef2356689890daee8c8415) --- Modified: pkg/kamailio/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/d4159f45972bad6151649d190f4e6c3… Patch: https://github.com/kamailio/kamailio/commit/d4159f45972bad6151649d190f4e6c3… --- diff --git a/pkg/kamailio/Makefile b/pkg/kamailio/Makefile index ce2e3ae7327..6f1a18ec3c6 100644 --- a/pkg/kamailio/Makefile +++ b/pkg/kamailio/Makefile @@ -32,8 +32,8 @@ apk: sed -e "s/^_gitcommit=.*/_gitcommit=${GIT_TAG}/" \ -e "s/^pkgver=.*/pkgver=${APK_VERSION}/" \ -i alpine/APKBUILD - cd alpine && abuild snapshot - @echo \"abuild\" cannot be started from Makefile please start manually \"cd alpine \&\& abuild -r\" + abuild -C alpine snapshot + @echo \"abuild\" cannot be started from Makefile please start manually \"abuild -C alpine -r\" # build source rpm package .PHONY: src.rpm

1 0

git:6.0:26bd6104: github: refactored alpine docker image generation
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 26bd61047c446eb509691765ad3fa60292a0b25d URL: https://github.com/kamailio/kamailio/commit/26bd61047c446eb509691765ad3fa60… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T17:00:04+03:00 github: refactored alpine docker image generation - GH #4241 (cherry picked from commit de4e36779ec0d01e4ba749318677e29472de5b55) Signed-off-by: Sergey Safarov <s.safarov(a)anycast-lb.net> --- Modified: .github/workflows/alpine.yml --- Diff: https://github.com/kamailio/kamailio/commit/26bd61047c446eb509691765ad3fa60… Patch: https://github.com/kamailio/kamailio/commit/26bd61047c446eb509691765ad3fa60…

1 0

git:6.0:7022d949: pkg/docker: submodule update
by Sergey Safarov 21 Jun '25

21 Jun '25

Module: kamailio Branch: 6.0 Commit: 7022d9493d4db047d5fa2d67e589c05f43aec5e9 URL: https://github.com/kamailio/kamailio/commit/7022d9493d4db047d5fa2d67e589c05… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-06-21T16:59:26+03:00 pkg/docker: submodule update --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/7022d9493d4db047d5fa2d67e589c05… Patch: https://github.com/kamailio/kamailio/commit/7022d9493d4db047d5fa2d67e589c05… --- diff --git a/pkg/docker b/pkg/docker index cf48a82c5f9..75be900d83b 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit cf48a82c5f9df67813d14e6619cc9a41ec9a683b +Subproject commit 75be900d83bb70b3ec77443fdbb309b9ef1a6d80

1 0

[kamailio/kamailio] prefix_route - prefix longer than 12 characters ignored (Issue #4218)
by Barry Flanagan 21 Jun '25

21 Jun '25

flantel created an issue (kamailio/kamailio#4218) ### Description If I add a prefix of greater than 12 characters in to prefix_route it does not return the correct route but instead acts as if no record was found. ### Troubleshooting #### Reproduction Create a prefix_route prefix of more than 12 characters and the route will not be chosen. #### Debugging Data There is none. #### Log Messages prefix_route does not seem to produce DEBUG level messages. ### Additional Information ``` kamailio 5.8.6 (x86_64/linux) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4218 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4218(a)github.com>

3 4

[kamailio/kamailio] topoh: fix bug in hiding record routes in reply messages (PR #4170)
by Farzaneh Soltanzadeh 21 Jun '25

21 Jun '25

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4170 -- Commit Summary -- * hide all record routes except last one in reply messages -- File Changes -- M src/modules/topoh/th_msg.c (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4170.patch https://github.com/kamailio/kamailio/pull/4170.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4170 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4170(a)github.com>

3 13

Re: [kamailio/kamailio] aaaa (2698244)
by Henning Westerholt 20 Jun '25

20 Jun '25

The commits were reverted (details at https://kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kamailio.org/mes… ) - but I was reluctant to do a force-push on a public repository, so there were still visible. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/26982449b7dabe0413258a7602d8810… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/26982449b7dabe0413258a7602d88107c8f7e7d9/160481195(a)github.com>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev