<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Add new parameter for dmq module "remove_inactive" that controls removing nodes behavior. Default value is 1, so the behavior will not changed by default.
This is useful especially with notification peers that are defined as dns record together with enabled multi_notify option.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4146
-- Commit Summary --
* dmq: added remove_inactive parameter
-- File Changes --
M src/modules/dmq/dmq.c (2)
M src/modules/dmq/dmq.h (1)
M src/modules/dmq/doc/dmq_admin.xml (20)
M src/modules/dmq/notification_peer.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4146.patchhttps://github.com/kamailio/kamailio/pull/4146.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4146
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4146(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Few fixes to topos_htable module. To be backported in 6.0 branch.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4133
-- Commit Summary --
* topos_htable: fix xtag and add more snprintf checks
-- File Changes --
M src/modules/topos_htable/topos_htable_storage.c (25)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4133.patchhttps://github.com/kamailio/kamailio/pull/4133.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4133
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4133(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Dispatcher timer regularly pings the nodes. Should skip resolving and pinging the no-dns-A flag ones since those node do not have an A record by definition.
Otherwise that no-dns-A flag(state) is overwritten by the pinging process. This leads to node removal from group, after RPC commands e.g. "kamcmd dispatcher.add/remove".
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4150
-- Commit Summary --
* dispatcher: skip ping for DS_NODNSARES_DST
-- File Changes --
M src/modules/dispatcher/dispatch.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4150.patchhttps://github.com/kamailio/kamailio/pull/4150.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4150
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4150(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
OPTIONS ping is always sent to Path uri, if contact has it set. Add option to ignore this and still send OPTIONS to contact.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4152
-- Commit Summary --
* nathelper: Add modparam to not send ping to Path
-- File Changes --
M src/modules/nathelper/doc/nathelper_admin.xml (20)
M src/modules/nathelper/nathelper.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4152.patchhttps://github.com/kamailio/kamailio/pull/4152.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4152
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4152(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
BYE transactions keept increasing and were never freed.
#### Reproduction
1. Compile kamailio 5.8.5 and run it under no traffic, with default config
2. Connect 1 WSS client
3. Send INVITE with "Session-Expires" header from WSS client -> kamailio -> PBX (e.g. asterisk)
4. Wait for WSS client to refresh session in re-INVITE with another "Session-Expires"
5. Force kill WSS client and wait
6. PBX (asterisk) will send BYE to end session
7. kamailio replies "477 Unfortunately error on sending to next hop occurred (477/SL)"
8. kamcmd tm.list | grep BYE -> will see that transaction there is never freed
#### Debugging Data + Log Messages
```
DEBUG: tm [h_table.c:415]: build_cell(): created new cell 0x7f673e2552d0
INFO: <script>: [pdn60n9cob1j3j0doi36] MANAGE_BRANCH: New branch [0] to ....., BYE
WARNING: tm [../../core/forward.h:217]: msg_send_buffer(): TCP/TLS connection for WebSocket could not be found
DEBUG: tm [t_fwd.c:1566]: t_send_branch(): send to 169.132.91.64:1702 (5) failed
WARNING: tm [t_fwd.c:1586]: t_send_branch(): sending request on branch 0 failed
DEBUG: tm [t_funcs.c:358]: t_relay_to(): t_forward_nonack returned error -1 (-477)
DEBUG: tm [t_funcs.c:376]: t_relay_to(): -477 error reply generation delayed
DEBUG: sl [sl_funcs.c:564]: sl_run_callbacks(): execute callback for event type 1
ERROR: sl [sl_funcs.c:428]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL)
DEBUG: dialog [dlg_hash.c:780]: dlg_lookup_mode(): ref dlg 0x7f673e5dbae0 with 1 -> 2
DEBUG: dialog [dlg_hash.c:784]: dlg_lookup_mode(): dialog id=6986 found on entry 2734
DEBUG: dialog [dlg_hash.c:1088]: dlg_unref_helper(): unref op on 0x7f673e5dbae0 with 1 from dlg_hash.c:1106
DEBUG: dialog [dlg_hash.c:1092]: dlg_unref_helper(): unref dlg 0x7f673e5dbae0 with 1 -> 1
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```

```
### Possible Solutions
Tracked this down to this "#ifdef" that is defined inside the C file itself: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_funcs.c#L…
Solution 1: remove all the code related to TM_DELAYED_REPLY since it is anyway local to t_funcs.c file
Solution 2: t_release_transaction(t); /* kill it silently */ in case of TM_DELAYED_REPLY too
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
all up to latest one
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
not relevant
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4140
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4140(a)github.com>
### Description
I am trying to configure some "default" settings in Kamailio that would be independent of the configuration file. The command-line options `--loadmodule` and `--modparam` seemed to be exactly what I was looking for.
However, I noticed that these options are processed **before** the configuration file is loaded. As a result, the `--modparam` option cannot be used separately, because the module for the specified parameter has not yet been loaded:
```
# kamailio -E -DD --modparam=corex:alias_subdomains:s:kamailio.org
0(653) ERROR: <core> [core/modparam.c:199]: set_mod_param_regex(): No module matching <corex> found
0(653) ERROR: <core> [main.c:2584]: main(): failed to set modparam: corex:alias_subdomains:s:kamailio.org
```
To address this, the module needs to be loaded first using the `--loadmodule` option. However, this causes an error if the same module is also loaded in the configuration file:
```
# kamailio -E -DD --loadmodule=corex --modparam=corex:alias_subdomains:s:kamailio.org
0(654) WARNING: <core> [core/sr_module.c:611]: ksr_load_module(): attempting to load the same module twice (/usr/lib/x86_64-linux-gnu/kamailio/modules/corex.so)
0(654) CRITICAL: <core> [core/cfg.y:4014]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 283, column 12-21: failed to load module
```
### Possible Solutions
Would it be possible to move the processing of these command-line options **after** the configuration file is loaded? And could the `--loadmodule` option ignore loading a module if it has already been loaded via the configuration file?
Another potential solution could be introducing new options, such as `--loadmodule-after` and `--modparam-after`, to specify parameters that should only be applied once the configuration file has been loaded.
What do you think about these suggestions?
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.4 (x86_64/linux)
```
* **Operating System**:
```
Linux 010a217cd09a 6.12.10-orbstack-00297-gf8f6e015b993 #42 SMP Sun Jan 19 03:00:07 UTC 2025 x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4126
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4126(a)github.com>
Hello, I discovered that kamcmd command doesn't allow the same argument for a rpc command if I call a one-liner command or from the kamcmd console. it's related to ul.add command
If I call this command from bash:
kamcmd ul.add location 222(a)domain.com sip:222@tbd.domain.com:5088;transport=udp 0 -1.0 . 0 2240 5023 . udp:8.12.6.7:5060
the command will fail with 2 errors:
error: 500 - Not enough parameters or wrong format
-bash: 0: command not found
I discovered if I remove ;transport=udp I get rid of the errors and I get new one:
Unknown option `-1'.
And if I set my Q value from -1.0 to 0.0 the command works
BUT
If I go into the kamcmd console and I ask the exact original command, it works and I can see in usrloc database that it accepted my Q value to -1.0 and the transport=udp string
I tried to use s: to force some argument as string but it doesn't works , may be I don't use correctly
I tried unsuccessfully:
kamcmd ul.add location 298(a)domain.com s:sip:298@tbd.domain.com:5088;transport=udp 0 s:-1.0 . 0 2240 5023 . udp:8.12.6.7:5060
-->
I use kamailio version
kamailio 5.7.1 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 10.2.1
kamcmd has been built from the same source code with the rest of the program
Built on debian 11
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4137
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4137(a)github.com>
Hello,
there is a planned mainenance work on the infrastructure for the server
hosting kamailio.org services (among them: the main website, wiki,
mailing lists) on next week, Tuesday, February 18, 2025, to start about
10:00am Berlin time (CET). Expect some intervals of unavailability, we
hope they will be short and most of them not noticeable for the majority
accessing these services during the day.
Once the work is finished, an announcement will be sent out.
The apt repository, github project and the matrix chat channels should
not be affected, they can be accessed as usual and can be used a backup
communication channels if anyone observes something that has to be
addressed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio Advanced Training, March 24-28, 2025 -- asipto.com
Kamailio World Conference, May 12-13, 2025, Berlin -- kamailioworld.com