- sr-dev - kamailio.org

git:master:11acfd85: pv: extended $nh(k) to work for replies using 2nd via
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 11acfd857d1b9c5e7e4c10efd8f1eb239c77e8a8 URL: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:02:08+02:00 pv: extended $nh(k) to work for replies using 2nd via --- Modified: src/modules/pv/pv_branch.c --- Diff: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… Patch: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… --- diff --git a/src/modules/pv/pv_branch.c b/src/modules/pv/pv_branch.c index d3e34c681a..594a88f1f5 100644 --- a/src/modules/pv/pv_branch.c +++ b/src/modules/pv/pv_branch.c @@ -669,6 +669,81 @@ int pv_parse_rcv_name(pv_spec_p sp, str *in) return -1; } +/** + * + */ +int pv_get_nh_reply(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res) +{ + static char rpluribuf[MAX_URI_SIZE]; + str suri = STR_NULL; + str host = STR_NULL; + str sproto = STR_NULL; + unsigned int port = 0; + + if(parse_headers( msg, HDR_VIA2_F, 0)==-1) { + LM_DBG("no 2nd via parsed\n"); + return pv_get_null(msg, param, res); + } + if((msg->via2==0) || (msg->via2->error!=PARSE_OK)) { + return pv_get_null(msg, param, res); + } + if(msg->via2->rport && msg->via2->rport->value.s) { + LM_DBG("using 'rport'\n"); + if(str2int(&msg->via2->rport->value, &port)<0) { + LM_ERR("invalid rport value\n"); + return pv_get_null(msg, param, res); + } + } + if(msg->via2->received) { + LM_DBG("using 'received'\n"); + host = msg->via2->received->value; + } else { + LM_DBG("using via host\n"); + host = msg->via2->host; + } + if(port==0) { + port = (msg->via2->port)?msg->via2->port:SIP_PORT; + } + + switch(param->pvn.u.isname.name.n) { + case 0: /* uri */ + if(get_valid_proto_string(msg->via2->proto, 1, 0, &sproto)<0) { + sproto.s = "udp"; + sproto.len = 3; + } + suri.len = snprintf(rpluribuf, MAX_URI_SIZE, "sip:%.*s:%u;transport=%.*s", + host.len, host.s, port, sproto.len, sproto.s); + if(suri.len<=0 || suri.len>=MAX_URI_SIZE) { + LM_DBG("building the dst uri failed (%d)\n", suri.len); + return pv_get_null(msg, param, res); + } + suri.s = rpluribuf; + return pv_get_strval(msg, param, res, &suri); + case 1: /* user - not in Via */ + return pv_get_null(msg, param, res); + case 2: /* domain/host */ + return pv_get_strval(msg, param, res, &host); + case 3: /* port */ + return pv_get_uintval(msg, param, res, port); + case 4: /* proto */ + if(get_valid_proto_string(msg->via2->proto, 0, 0, &sproto)<0) { + /* default to udp */ + sproto.s = "udp"; + sproto.len = 3; + return pv_get_strintval(msg, param, res, &sproto, PROTO_UDP); + } + return pv_get_strintval(msg, param, res, &sproto, + (int)msg->via2->proto); + } + + LM_ERR("unknown specifier\n"); + return pv_get_null(msg, param, res); +} + +/** + * + */ int pv_get_nh(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { @@ -678,8 +753,10 @@ int pv_get_nh(struct sip_msg *msg, pv_param_t *param, if(msg==NULL || res==NULL) return -1; - if(msg->first_line.type == SIP_REPLY) /* REPLY doesnt have r/d-uri */ - return pv_get_null(msg, param, res); + if(msg->first_line.type == SIP_REPLY) { + /* REPLY doesnt have r/d-uri - use second Via */ + return pv_get_nh_reply(msg, param, res); + } if (msg->dst_uri.s != NULL && msg->dst_uri.len>0) {

1 0

[kamailio/kamailio] app_perl: Ignore __DIE__ signals that come from eval blocks (#2745)
by rodolfojcj 09 Jun '21

09 Jun '21

### Description If possible, I would like that the `kamailio/src/modules/app_perl/lib/perl/Kamailio.pm` file does not generate error messages to the system log files, which are not actual errors and are caused by `eval` blocks of third-party Perl modules that my code depends on. To illustrate the current setup, let's consider the following: - In file `/etc/kamailio/kamailio_52.cfg` ```perl modparam( "app_perl", "filename", "/opt/myprogram/perllib/MyKamailio.pm" ) ``` - In file `/opt/myprogram/perllib/MyKamailio.pm`: ```perl use Crypt::JWT qw( decode_jwt encode_jwt ); ``` - It happens that `Crypt::JWT` depends on `CryptX`, which in turn needs a `JSON::XS` implementation, which could be either `Cpanel::JSON::XS` or `JSON::XS`or `JSON::PP`, in that order of preference. That need is resolved at runtime, as we can see in the following code fragment taken from the file at https://github.com/DCIT/perl-CryptX/blob/master/lib/CryptX.pm: ```perl BEGIN { if (eval { require Cpanel::JSON::XS }) { Cpanel::JSON::XS->import(qw(encode_json decode_json)); $has_json = 1; } elsif (eval { require JSON::XS }) { JSON::XS->import(qw(encode_json decode_json)); $has_json = 2; } elsif (eval { require JSON::PP }) { JSON::PP->import(qw(encode_json decode_json)); $has_json = 3; } else { $has_json = 0; } } ``` - In my system, `Cpanel::JSON::XS` is not installed because it is not needed. I could install it, but unfortunately that module intermittently causes a segmentation fault, as described in the issue report at https://github.com/rurban/Cpanel-JSON-XS/issues/179. ### Expected behavior I would expect two things: - The operating system log files, like `/var/log/syslog`, adds only entries like the following ones after restarting Kamailio: May 25 14:30:06 myserver systemd[1]: kamailio.service: Succeeded. May 25 14:30:06 myserver systemd[1]: Stopped Kamailio server. May 25 14:30:06 myserver systemd[1]: Starting Kamailio server... May 25 14:30:06 myserver systemd[1]: Started Kamailio server. - The output of commands like `systemctl status kamailio.service` only shows informational messages of success. ### Actual observed behavior - The operating system log files, like `/var/log/syslog`, also adds error messages like the following one after restarting Kamailio: May 25 14:30:06 myserver /sbin/kamailio[1827476]: ERROR: app_perl [kamailioxs.xs:1041]: XS_Kamailio__Message_log(): perl error: Can't locate Cpanel/JSON/XS.pm in @INC (you may need to install the Cpanel::JSON::XS module) (@INC contains: /opt/myprogram/perllib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl) at /usr/local/lib/x86_64-linux-gnu/perl/5.30.0/CryptX.pm line 14. - The output of commands like `systemctl status kamailio.service` adds that same error message at its end. ### What could be changed in Kamailio? The `kamailio/src/modules/app_perl/lib/perl/Kamailio.pm` file could ignore, or bypass, the `__DIE__` signals coming from `eval` blocks, like this changed code fragment shows: ```perl $SIG{'__DIE__'} = sub { die @_ if( $^S or not defined $^S ); Kamailio::Message::log(undef, L_ERR, "perl error: $_[0]\n"); }; ``` That changed is based on the following references: - The [Override die with END or CORE::GLOBAL::die](https://www.effectiveperlprogramming.com/2011/05/overrid… article, which says: > There’s a Perl special variable that can help. The documentation for die recommends that you start your `__DIE__` handler by checking `$^S` before you continue. Inside the handler, the special handler is turned off so `die` inside `$SIG{__DIE__}` is the real `die`. The value of `$^S` will be true if it came from within an `eval`, so this just re-throws the exception without handling it. - The [Perl documentation for the `$^S` variable](https://perldoc.perl.org/perlvar#%24%5ES), which says: > Current state of the interpreter. $^S State --------- ------------------------------------- undef Parsing module, eval, or main program true (1) Executing an eval false (0) Otherwise > The first state may happen in `$SIG{__DIE__}` and `$SIG{__WARN__}` handlers. - The [Perl documentation for the `die` function](https://perldoc.perl.org/functions/die), which says: > You can arrange for a callback to be run just before the `die` does its deed, by setting the `$SIG{__DIE__}` hook. The associated handler is called with the exception as an argument, and can change the exception, if it sees fit, by calling `die` again. See `"%SIG"` in perlvar for details on setting `%SIG` entries, and `eval` for some examples. Although this feature was to be run only right before your program was to exit, this is not currently so: the `$SIG{__DIE__}` hook is currently called even inside `eval`ed blocks/strings! If one wants the hook to do nothing in such situations, put ```perl die @_ if $^S; ``` > as the first line of the handler (see "`$^S`" in perlvar). Because this promotes strange action at a distance, this counterintuitive behavior may be fixed in a future release. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ```bash root@myserver:~# kamailio -V version: kamailio 5.4.3 (x86_64/linux) e19ae3 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: e19ae3 compiled on 17:51:35 Feb 14 2021 with gcc 9.3.0 ``` * **Operating System**: ```bash root@myserver:~# uname -a Linux myserver 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` ```bash root@myserver:~# cat /etc/os-release NAME="Ubuntu" VERSION="20.04.1 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.1 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal ``` * **Perl version**: ```bash root@myserver:~# perl -V Summary of my perl5 (revision 5 version 30 subversion 0) configuration: Platform: osname=linux osvers=4.19.0 archname=x86_64-linux-gnu-thread-multi uname='linux localhost 4.19.0 #1 smp debian 4.19.0 x86_64 gnulinux ' config_args='-Dmksymlinks -Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=-DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/perl-Wfb2Cd/perl-5.30.0=. -fstack-protector-strong -Wformat -Werror=format-security -Dldflags= -Wl,-Bsymbolic-functions -Wl,-z,relro -Dlddlflags=-shared -Wl,-Bsymbolic-functions -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.30 -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.30 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux-gnu/perl5/5.30 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.30.0 -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.30.0 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -Ui_xlocale -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib -Dlibperl=libperl.so.5.30.0' hint=recommended useposix=true d_sigaction=define useithreads=define usemultiplicity=define use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='x86_64-linux-gnu-gcc' ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' optimize='-O2 -g' cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='' gccversion='9.3.0' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='x86_64-linux-gnu-gcc' ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=libc-2.31.so so=so useshrplib=true libperl=libperl.so.5.30 gnulibc_version='2.31' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -L/usr/local/lib -fstack-protector-strong' Characteristics of this binary (from libperl): Compile-time options: HAS_TIMES MULTIPLICITY PERLIO_LAYERS PERL_COPY_ON_WRITE PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP PERL_OP_PARENT PERL_PRESERVE_IVUV USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO USE_PERL_ATOF USE_REENTRANT_API USE_THREAD_SAFE_LOCALE Locally applied patches: DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS default for modules installed from CPAN. DEBPKG:debian/db_file_ver - https://bugs.debian.org/340047 Remove overly restrictive DB_File version check. DEBPKG:debian/doc_info - Replace generic man(1) instructions with Debian-specific information. DEBPKG:debian/enc2xs_inc - https://bugs.debian.org/290336 Tweak enc2xs to follow symlinks and ignore missing @INC directories. DEBPKG:debian/errno_ver - https://bugs.debian.org/343351 Remove Errno version check due to upgrade problems with long-running processes. DEBPKG:debian/libperl_embed_doc - https://bugs.debian.org/186778 Note that libperl-dev package is required for embedded linking DEBPKG:fixes/respect_umask - Respect umask during installation DEBPKG:debian/writable_site_dirs - Set umask approproately for site install directories DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of libperl.a under /usr/lib DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or perllocal.pod for perl or vendor DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to the binary targets. DEBPKG:debian/instmodsh_doc - Debian policy doesn't install .packlist files for core or vendor. DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH as per Debian policy. DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to /etc/perl/Net as /usr may not be writable. DEBPKG:debian/perlivp - https://bugs.debian.org/510895 Make perlivp skip include directories in /usr/local DEBPKG:debian/squelch-locale-warnings - https://bugs.debian.org/508764 Squelch locale warnings in Debian package maintainer scripts DEBPKG:debian/patchlevel - https://bugs.debian.org/567489 List packaged patches for 5.30.0-9ubuntu0.2 in patchlevel.h DEBPKG:fixes/document_makemaker_ccflags - https://bugs.debian.org/628522 [rt.cpan.org #68613] Document that CCFLAGS should include $Config{ccflags} DEBPKG:debian/find_html2text - https://bugs.debian.org/640479 Configure CPAN::Distribution with correct name of html2text DEBPKG:debian/perl5db-x-terminal-emulator.patch - https://bugs.debian.org/668490 Invoke x-terminal-emulator rather than xterm in perl5db.pl DEBPKG:debian/cpan-missing-site-dirs - https://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with nonexisting site dirs if a parent is writable DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] https://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' option not respected DEBPKG:debian/makemaker-pasthru - https://bugs.debian.org/758471 Pass LD settings through to subdirectories DEBPKG:debian/makemaker-manext - https://bugs.debian.org/247370 Make EU::MakeMaker honour MANnEXT settings in generated manpage headers DEBPKG:debian/kfreebsd-softupdates - https://bugs.debian.org/796798 Work around Debian Bug#796798 DEBPKG:fixes/autodie-scope - https://bugs.debian.org/798096 Fix a scoping issue with "no autodie" and the "system" sub DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in Memoize DEBPKG:debian/hurd-softupdates - https://bugs.debian.org/822735 Fix t/op/stat.t failures on hurd DEBPKG:fixes/math_complex_doc_great_circle - https://bugs.debian.org/697567 [rt.cpan.org #114104] Math::Trig: clarify definition of great_circle_midpoint DEBPKG:fixes/math_complex_doc_see_also - https://bugs.debian.org/697568 [rt.cpan.org #114105] Math::Trig: add missing SEE ALSO DEBPKG:fixes/math_complex_doc_angle_units - https://bugs.debian.org/731505 [rt.cpan.org #114106] Math::Trig: document angle units DEBPKG:fixes/cpan_web_link - https://bugs.debian.org/367291 CPAN: Add link to main CPAN web site DEBPKG:debian/hppa_op_optimize_workaround - https://bugs.debian.org/838613 Temporarily lower the optimization of op.c on hppa due to gcc-6 problems DEBPKG:debian/installman-utf8 - https://bugs.debian.org/840211 Generate man pages with UTF-8 characters DEBPKG:fixes/getopt-long-4 - https://bugs.debian.org/864544 [rt.cpan.org #122068] Fix issue #122068. DEBPKG:debian/hppa_opmini_optimize_workaround - https://bugs.debian.org/869122 Lower the optimization level of opmini.c on hppa DEBPKG:debian/sh4_op_optimize_workaround - https://bugs.debian.org/869373 Also lower the optimization level of op.c and opmini.c on sh4 DEBPKG:debian/perldoc-pager - https://bugs.debian.org/870340 [rt.cpan.org #120229] Fix perldoc terminal escapes when sensible-pager is less DEBPKG:debian/prune_libs - https://bugs.debian.org/128355 Prune the list of libraries wanted to what we actually need. DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian DEBPKG:debian/configure-regen - https://bugs.debian.org/762638 Regenerate Configure et al. after probe unit changes DEBPKG:debian/deprecate-with-apt - https://bugs.debian.org/747628 Point users to Debian packages of deprecated core modules DEBPKG:debian/disable-stack-check - https://bugs.debian.org/902779 [perl #133327] Disable debugperl stack extension checks for binary compatibility with perl DEBPKG:fixes/eumm-usrmerge - https://bugs.debian.org/913637 Avoid mangling /bin non-perl shebangs on merged-/usr systems DEBPKG:debian/perlbug-editor - https://bugs.debian.org/922609 Use "editor" as the default perlbug editor, as per Debian policy DEBPKG:fixes/gid-parsing - [79e302e] https://bugs.debian.org/941985 [perl #134169] (perl #134169) mg.c reset endptr after use DEBPKG:fixes/CVE-2020-10543.patch - [PATCH v530 1/4] regcomp.c: Prevent integer overflow from nested regex quantifiers. DEBPKG:fixes/CVE-2020-10878-1.patch - [PATCH v530 2/4] study_chunk: extract rck_elide_nothing DEBPKG:fixes/CVE-2020-10878-2.patch - [PATCH v530 3/4] regcomp: use long jumps if there is any possibility of overflow DEBPKG:fixes/CVE-2020-12723.patch - [PATCH v530 4/4] study_chunk: avoid mutating regexp program within GOSUB Built under linux Compiled at Oct 19 2020 10:56:54 @INC: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base ``` Please evaluate the situation and let me know your feedback and what I could help with. Thanks in advance for your time and attention. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2745

3 3

git:master:8275046a: siptrace: aadded siptrace pseudo var
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 8275046a250a80018f42f8dbadaa245094c6f5ff URL: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T09:21:16+02:00 siptrace: aadded siptrace pseudo var --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… Patch: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 012644bfa0..b411886f54 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -195,6 +195,10 @@ static str trace_local_ip = {NULL, 0}; static db1_con_t *db_con = NULL; /*!< database connection */ static db_func_t db_funcs; /*!< Database functions */ +int pv_parse_siptrace_name(pv_spec_t *sp, str *in); +int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res); + /*! \brief * Exported functions */ @@ -276,6 +280,14 @@ stat_export_t siptrace_stats[] = { /* clang-format on */ #endif +static pv_export_t mod_pvs[] = { + + { {"siptrace", (sizeof("siptrace")-1)}, PVT_OTHER, pv_get_siptrace, 0, + pv_parse_siptrace_name, 0, 0, 0 }, + + { {0, 0}, 0, 0, 0, 0, 0, 0, 0 } +}; + /*! \brief module exports */ /* clang-format off */ struct module_exports exports = { @@ -283,9 +295,9 @@ struct module_exports exports = { DEFAULT_DLFLAGS, /*!< dlopen flags */ cmds, /*!< exported functions */ params, /*!< exported parameters */ - 0, /*!< exported rpc functions */ - 0, /*!< exported pseudo-variables */ - 0, /*!< response function */ + 0, /*!< exported rpc functions */ + mod_pvs, /*!< exported pseudo-variables */ + 0, /*!< response function */ mod_init, /*!< module initialization function */ child_init, /*!< child initialization function */ destroy /*!< destroy function */ @@ -2039,6 +2051,8 @@ static void trace_free_info(void* trace_info) shm_free(trace_info); } +static siptrace_data_t* siptrace_event_data = NULL; + static int siptrace_exec_evcb_msg(siptrace_data_t *sto) { int backup_rt; @@ -2068,6 +2082,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); + siptrace_event_data = sto; if(_siptrace_evrt_msg_idx>=0) { run_top_route(event_rt.rlist[_siptrace_evrt_msg_idx], &msg, &ctx); } else { @@ -2080,6 +2095,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) sr_kemi_act_ctx_set(bctx); } } + siptrace_event_data = NULL; free_sip_msg(&msg); set_route_type(backup_rt); @@ -2482,6 +2498,56 @@ static sr_kemi_t sr_kemi_siptrace_exports[] = { { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; + +/** + * + */ +int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res) +{ + if (siptrace_event_data==NULL) { + return pv_get_null(msg, param, res); + } + + switch(param->pvn.u.isname.name.n) { + case 1: /* dst_uri*/ + return pv_get_strval(msg, param, res, &siptrace_event_data->toip); + default: + /* 0 - src_uri */ + return pv_get_strval(msg, param, res, &siptrace_event_data->fromip); + } +} + +/** + * + */ +int pv_parse_siptrace_name(pv_spec_t *sp, str *in) +{ + if(sp==NULL || in==NULL || in->len<=0) + return -1; + + switch(in->len) + { + case 7: + if(strncmp(in->s, "src_uri", 7)==0) + sp->pvp.pvn.u.isname.name.n = 0; + else if(strncmp(in->s, "dst_uri", 7)==0) + sp->pvp.pvn.u.isname.name.n = 1; + else goto error; + break; + default: + goto error; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = 0; + + return 0; + +error: + LM_ERR("unknown PV snd name %.*s\n", in->len, in->s); + return -1; +} + /* clang-format on */ /**

1 0

git:master:10bc5b24: pv: new variable $hflc(hname)
by Daniel-Constantin Mierla 08 Jun '21

08 Jun '21

Module: kamailio Branch: master Commit: 10bc5b244db34e57beb9e5b4ec546396fb12a76b URL: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-08T13:25:54+02:00 pv: new variable $hflc(hname) - return the number of bodies for known headers that can also be as a comma separated list - supported now is Via header --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Patch: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 2738a8b7a2..3a904e3161 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -110,6 +110,8 @@ static pv_export_t mod_pvs[] = { 0, 0, 0}, {{"hfl", (sizeof("hfl")-1)}, PVT_HDR, pv_get_hfl, 0, pv_parse_hfl_name, pv_parse_index, 0, 0}, + {{"hflc", (sizeof("hflc")-1)}, PVT_HDRC, pv_get_hflc, 0, pv_parse_hfl_name, + 0, 0, 0}, {{"var", (sizeof("var")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, pv_set_scriptvar, pv_parse_scriptvar_name, 0, 0, 0}, {{"vz", (sizeof("vz")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 1b39ef3fb8..a4bfe21985 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2421,6 +2421,70 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); } +/** + * + */ +int pv_get_hflc(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + pv_value_t tv = {0}; + via_body_t *vb = NULL; + hdr_field_t *hf = NULL; + int n = 0; + + if(msg==NULL || res==NULL || param==NULL) + return -1; + + /* get the name */ + if(param->pvn.type == PV_NAME_PVAR) { + if(pv_get_spec_name(msg, param, &tv)!=0 || (!(tv.flags&PV_VAL_STR))) { + LM_ERR("invalid name\n"); + return pv_get_sintval(msg, param, res, 0); + } + } else { + if(param->pvn.u.isname.type == AVP_NAME_STR) { + tv.flags = PV_VAL_STR; + tv.rs = param->pvn.u.isname.name.s; + } else { + tv.flags = 0; + tv.ri = param->pvn.u.isname.name.n; + } + } + + if (parse_headers(msg, HDR_EOH_F, 0)<0) { + LM_DBG("failed to parse sip headers\n"); + return pv_get_sintval(msg, param, res, 0); + } + + if((tv.flags == 0) && (tv.ri==HDR_VIA_T)) { + if(msg->h_via1==NULL) { + LM_WARN("no Via header\n"); + return pv_get_sintval(msg, param, res, 0); + } + /* count Via header bodies */ + for(hf=msg->h_via1; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_VIA_T) { + for(vb=(via_body_t*)hf->parsed; vb!=NULL; vb=vb->next) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); + } + + for (hf=msg->headers; hf; hf=hf->next) { + if(tv.flags == 0) { + if (tv.ri==hf->type) { + n++; + } + } else { + if (cmp_hdrname_str(&hf->name, &tv.rs)==0) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); +} + /** * */ diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 179df8fd0b..d001104647 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -255,6 +255,8 @@ int pv_get_hdrc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); +int pv_get_hflc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_scriptvar(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

[kamailio/kamailio] tm: prevent t_suspend memory leak (#2763)
by Julien Chavanton 07 Jun '21

07 Jun '21

When suspending while already in t_continue when processing a reply / suspending twice in a reply. Thanks to @giavac https://github.com/kamailio/kamailio/pull/2721 we can now suspend more then once in a reply route. This is working well, however a memory leak was detected. This modification is proposing a solution that will prevent calling `sip_msg_cloner` over an already twice over the same pointer, creating the memory leak.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) I assume this is a non "breaking change" since it can only trigger in a very the specific case that was not supported anyway. Conditions when this alternate behavior can trigger: 1- must be in t_suspend 2- must be in a reply `if (msg->first_line.type == SIP_REPLY) {` 3- must have an already cloned `if (t->uac[branch].reply) {` An alternate solution would be to free everything in the cloned message and recreate it. #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) load test done that included connections, failures and timeouts while suspending multiple times. ``` 6(31) INFO: tm [t_suspend.c:126]: t_suspend(): [>>>SUSPEND<<<] cloning message ! 53(78) INFO: tm [t_suspend.c:136]: t_suspend(): [>>>SUSPEND<<<] message already cloned, re-using ! ``` ``` Total 100000 INVITE calls sent in 1710825 ms at rate of 58/sec Total 100000 connection responses received in 1714999 ms at rate of 58/sec: >> Detailed connection responses received: - 200 connection responses: 24924 (OK) - 404 connection responses: 25145 (Not Found) - 408 connection responses: 24912 (Request Timeout) - 500 connection responses: 25019 (Internal Server Error) >> Detailed disconnection responses received: - 200 disconnection responses: 24924 (OK) ------ TOTAL responses: 24924 (rate=14/sec) ``` #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2763 -- Commit Summary -- * tm: prevent t_suspend memory leak -- File Changes -- M src/modules/tm/t_suspend.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2763.patch https://github.com/kamailio/kamailio/pull/2763.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2763

2 4

git:master:09218156: tm: prevent t_suspend memory leak (#2763)
by GitHub 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 09218156f3831ec9642d9ebf20d8668229ab16d6 URL: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-06-07T08:13:36-07:00 tm: prevent t_suspend memory leak (#2763) When suspending while already in t_continue when processing a reply / suspending twice in a reply. Co-authored-by: Julien Chavanton <jchavanton(a)subspace.com> --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… Patch: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… --- diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index 04f906f53c..826307d20a 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -118,18 +118,23 @@ int t_suspend(struct sip_msg *msg, LM_ERR("failed find UAC branch\n"); return -1; } - LM_DBG("found a a match with branch id [%d] - " - "cloning reply message to t->uac[branch].reply\n", branch); - sip_msg_len = 0; - t->uac[branch].reply = sip_msg_cloner( msg, &sip_msg_len ); + if (!t->uac[branch].reply) { + sip_msg_len = 0; + LM_DBG("found a match with branch id [%d] - " + "cloning reply message to t->uac[branch].reply\n", branch); + t->uac[branch].reply = sip_msg_cloner( msg, &sip_msg_len ); - if (! t->uac[branch].reply ) { - LM_ERR("can't alloc' clone memory\n"); - return -1; + if (! t->uac[branch].reply ) { + LM_ERR("can't alloc' clone memory\n"); + return -1; + } + t->uac[branch].end_reply = ((char*)t->uac[branch].reply) + sip_msg_len; + } else { + LM_DBG("found a match with branch id [%d] - " + "message already cloned to t->uac[branch].reply\n", branch); + // This can happen when suspending more than once in a reply. } - t->uac[branch].end_reply = ((char*)t->uac[branch].reply) + sip_msg_len; - LM_DBG("saving transaction data\n"); t->uac[branch].reply->flags = msg->flags; t->flags |= T_ASYNC_SUSPENDED;

1 0

git:master:7747872f: mtree: docs - section id for mt_match() function
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 7747872f066ead3488cbfc854873506bda4f7390 URL: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:23:50+02:00 mtree: docs - section id for mt_match() function --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… Patch: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… --- diff --git a/src/modules/mtree/doc/mtree_admin.xml b/src/modules/mtree/doc/mtree_admin.xml index 09eb86092c..2416d8fb8d 100644 --- a/src/modules/mtree/doc/mtree_admin.xml +++ b/src/modules/mtree/doc/mtree_admin.xml @@ -454,7 +454,7 @@ modparam("mtree", "mt_allow_duplicates", 1) <section> <title>Functions</title> <section> - <title> + <title id="mtree.f.mt_match"> <function moreinfo="none">mt_match(mtree, pv, mode)</function> </title> <para>

1 0

[kamailio/kamailio] Sl (#2767)
by sergey-safarov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description HTTP request do not trigger `SREV_NET_DATA_RECV` (please check [`receive_msg`](https://github.com/kamailio/kamailio/blob/0e806316b84be8388dad670e964e54011000b4a4/src/core/receive.c#L321)) This PR adds the same behavior for HTTP responces. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2767 -- Commit Summary -- * core: published sip_check_fline function in .h file * sl: disabled SREV_NET_DATA_SENT for HTTP respones -- File Changes -- M src/core/receive.h (1) M src/modules/sl/sl_funcs.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2767.patch https://github.com/kamailio/kamailio/pull/2767.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2767

2 1

git:master:4168d7c5: sl: disabled SREV_NET_DATA_SENT for HTTP respones
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 4168d7c55955a01c3a30c67d5e8a510be52120ff URL: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 sl: disabled SREV_NET_DATA_SENT for HTTP respones more details at GH #2767 --- Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… Patch: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… --- diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 86ad65c5e8..e80259d61d 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -210,7 +210,11 @@ int sl_reply_helper(struct sip_msg *msg, int code, char *reason, str *tag) dst.comp=msg->via1->comp_no; #endif dst.send_flags=msg->rpl_send_flags; - ret = msg_send(&dst, buf.s, buf.len); + if(sip_check_fline(buf.s, buf.len) == 0) + ret = msg_send_buffer(&dst, buf.s, buf.len, 0); + else + ret = msg_send_buffer(&dst, buf.s, buf.len, 1); + mhomed=backup_mhomed; keng = sr_kemi_eng_get();

1 0

git:master:c336eed3: core: published sip_check_fline function in .h file
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: c336eed393f2fedae16dbcf004e143fdd38c46e2 URL: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 core: published sip_check_fline function in .h file --- Modified: src/core/receive.h --- Diff: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Patch: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… --- diff --git a/src/core/receive.h b/src/core/receive.h index d4ce7895a8..433bf6a72e 100644 --- a/src/core/receive.h +++ b/src/core/receive.h @@ -32,6 +32,7 @@ #include "ip_addr.h" int receive_msg(char* buf, unsigned int len, struct receive_info *ri); +int sip_check_fline(char *buf, unsigned int len); unsigned int inc_msg_no(void); void ksr_msg_env_reset(void);

1 0

[kamailio/kamailio] Smsops 7bit support special chars (#2756)
by alexyosifov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2756 -- Commit Summary -- * Add README.md * Merge branch 'master' of github.com:alexyosifov/kamailio * Merge remote-tracking branch 'remote_yosifov/master' * Merge branch 'master' of github.com:alexyosifov/kamailio * smsops: support for 7bit special chars -- File Changes -- M src/modules/smsops/smsops_impl.c (256) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2756.patch https://github.com/kamailio/kamailio/pull/2756.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2756

3 4

git:master:f82c4775: smsops: support for 7bit special chars
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: f82c4775efca0580401f4b1a48dcb4d2cf26814f URL: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:13:17+02:00 smsops: support for 7bit special chars - Added support for 7bit special chars for MO/MT SMSs. --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d… Patch: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d…

1 0

[kamailio/kamailio] app_perl change to ignore "die" signals from eval blocks (#2754)
by rodolfojcj 07 Jun '21

07 Jun '21

Proposed fix for issue #2745. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2754 -- Commit Summary -- * app_perl change to ignore "die" signals from eval blocks -- File Changes -- M src/modules/app_perl/lib/perl/Kamailio.pm (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2754.patch https://github.com/kamailio/kamailio/pull/2754.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2754

2 2

git:master:50557b84: app_perl change to ignore "die" signals from eval blocks
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 50557b8433e137a9095b4d48df8ac9b8c3fd8807 URL: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… Author: rodolfojcj <458749+rodolfojcj(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:11:27+02:00 app_perl change to ignore "die" signals from eval blocks --- Modified: src/modules/app_perl/lib/perl/Kamailio.pm --- Diff: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… Patch: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… --- diff --git a/src/modules/app_perl/lib/perl/Kamailio.pm b/src/modules/app_perl/lib/perl/Kamailio.pm index eda5ede8b7..aa587424e1 100644 --- a/src/modules/app_perl/lib/perl/Kamailio.pm +++ b/src/modules/app_perl/lib/perl/Kamailio.pm @@ -40,6 +40,7 @@ bootstrap Kamailio; BEGIN { $SIG{'__DIE__'} = sub { + die @_ if( $^S or not defined $^S ); Kamailio::Message::log(undef, L_ERR, "perl error: $_[0]\n"); }; $SIG{'__WARN__'} = sub {

1 0

git:master:0e806316: mtree: docs - added section ids for parameters
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: 0e806316b84be8388dad670e964e54011000b4a4 URL: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T17:59:58+02:00 mtree: docs - added section ids for parameters --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540… Patch: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540…

1 0

[kamailio/kamailio] evapi: Evapi MAX clients set to 8 can it be made configurable parameter? (#2762)
by Balajee 04 Jun '21

04 Jun '21

### Description Evapi max client is set to 8 in [evapi module](https://github.com/kamailio/kamailio/blob/master/src/modules/evapi/… Can this be increased or can be made as configuration parameter?  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2762

2 2

[kamailio/kamailio] pv: fixed error "pv_get_method(): no CSEQ header" (#2761)
by sergey-safarov 04 Jun '21

04 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description pv: fixed error "pv_get_method(): no CSEQ header" when sent HTTP request like ``` HTTP/1.1 200 OK Sia: SIP/2.0/TCP 8.8.8.8:39813 Content-Type: application/json Server: kamailio Content-Length: 49 {"data":{"status-code":200,"reason-phrase":"OK"}} ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2761 -- Commit Summary -- * pv: fixed error "pv_get_method(): no CSEQ header" -- File Changes -- M src/modules/pv/pv_core.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2761.patch https://github.com/kamailio/kamailio/pull/2761.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2761

2 7

git:master:de8c85ce: pv: pv_get_method fixed error "pv_get_method(): no CSEQ header"
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: de8c85ceae93779cdf7d6aea2eabb7567d69d7ce URL: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T16:22:49+02:00 pv: pv_get_method fixed error "pv_get_method(): no CSEQ header" GH #2761: Error obeserver when sent HTTP reply like HTTP/1.1 200 OK Sia: SIP/2.0/TCP 8.8.8.8:39813 Content-Type: application/json Server: kamailio Content-Length: 49 {"data":{"status-code":200,"reason-phrase":"OK"}} --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… Patch: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 5b011ea248..1b39ef3fb8 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -147,6 +147,9 @@ int pv_get_method(struct sip_msg *msg, pv_param_t *param, (int)msg->first_line.u.request.method_value); } + if (IS_HTTP_REPLY(msg)) + return pv_get_null(msg, param, res); + if(msg->cseq==NULL && ((parse_headers(msg, HDR_CSEQ_F, 0)==-1) || (msg->cseq==NULL))) {

1 0

git:master:c264fbc6: pv: test for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: c264fbc66a4690b073c72ffa8fc095227ce0ae8b URL: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T15:29:50+02:00 pv: test for HDR_ERROR_T after header name parsing --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… Patch: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 8f398cdf43..5b011ea248 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3501,8 +3501,8 @@ int pv_parse_hdr_name(pv_spec_p sp, str *in) s.s = p; s.len = in->len+1; - if (parse_hname2_short(s.s, s.s + s.len, &hdr)==0) - { + parse_hname2_short(s.s, s.s + s.len, &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", s.len, s.s); goto error; }

1 0

git:master:b775bbdf: dmq: warning about protocol made info
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: b775bbdff501de0ca1f1a0bc1ab39a3b790c166f URL: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T09:08:06+02:00 dmq: warning about protocol made info --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… Patch: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 1db7cdd1f4..817fc3f3bb 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -161,7 +161,7 @@ static int make_socket_str_from_uri(struct sip_uri *uri, str *socket) } if(get_valid_proto_string(uri->proto, 0, 0, &sproto)<0) { - LM_WARN("unknown transport protocol - fall back to udp\n"); + LM_INFO("unknown transport protocol - fall back to udp\n"); sproto.s = "udp"; sproto.len = 3; }

1 0

git:master:490ae559: dialog: safety checks for bind addr fields
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: 490ae559d2b77b13b3f3831e7ff1aa58980e4086 URL: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T15:28:31+02:00 dialog: safety checks for bind addr fields - they can be null on non-local sockets - GH #2757 --- Modified: src/modules/dialog/dlg_db_handler.c --- Diff: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… Patch: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… --- diff --git a/src/modules/dialog/dlg_db_handler.c b/src/modules/dialog/dlg_db_handler.c index 1bfcb2cad7..b6a49da2a4 100644 --- a/src/modules/dialog/dlg_db_handler.c +++ b/src/modules/dialog/dlg_db_handler.c @@ -802,6 +802,7 @@ int update_dialog_dbinfo_unsafe(struct dlg_cell * cell) int i; struct dlg_var *var; srjson_doc_t jdoc; + str sempty = str_init(""); db_val_t values[DIALOG_TABLE_COL_NO]; @@ -870,14 +871,25 @@ int update_dialog_dbinfo_unsafe(struct dlg_cell * cell) SET_STR_VALUE(values+6, cell->tag[DLG_CALLEE_LEG]); SET_PROPER_NULL_FLAG(cell->tag[DLG_CALLEE_LEG], values, 6); - LM_DBG("caller sock_info is %.*s, callee sock_info is %.*s\n", - cell->bind_addr[DLG_CALLER_LEG]->sock_str.len, - cell->bind_addr[DLG_CALLER_LEG]->sock_str.s, - cell->bind_addr[DLG_CALLEE_LEG]->sock_str.len, - cell->bind_addr[DLG_CALLEE_LEG]->sock_str.s); - SET_STR_VALUE(values+7, cell->bind_addr[DLG_CALLER_LEG]->sock_str); - SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); + if(cell->bind_addr[DLG_CALLER_LEG]) { + LM_DBG("caller sock_info is %.*s\n", + cell->bind_addr[DLG_CALLER_LEG]->sock_str.len, + cell->bind_addr[DLG_CALLER_LEG]->sock_str.s); + SET_STR_VALUE(values+7, cell->bind_addr[DLG_CALLER_LEG]->sock_str); + } else { + LM_DBG("no caller sock_info\n"); + SET_STR_VALUE(values+7, sempty); + } + if(cell->bind_addr[DLG_CALLEE_LEG]) { + LM_DBG("callee sock_info is %.*s\n", + cell->bind_addr[DLG_CALLEE_LEG]->sock_str.len, + cell->bind_addr[DLG_CALLEE_LEG]->sock_str.s); + SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); + } else { + LM_DBG("no callee sock_info\n"); + SET_STR_VALUE(values+8, sempty); + } SET_STR_VALUE(values+12, cell->cseq[DLG_CALLER_LEG]); SET_STR_VALUE(values+13, cell->cseq[DLG_CALLEE_LEG]);

1 0

git:master:e8fa2b3e: pv: support Contact header in $hfl(...)
by Daniel-Constantin Mierla 03 Jun '21

03 Jun '21

Module: kamailio Branch: master Commit: e8fa2b3e8e5a789ac6d6d35f75ec61d09f487d6c URL: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T11:11:50+02:00 pv: support Contact header in $hfl(...) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… Patch: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 073d0dccb8..8f398cdf43 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2191,6 +2191,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) pv_value_t tv = {0}; via_body_t *vb = NULL; rr_t *rrb = NULL; + contact_t *cb = NULL; hdr_field_t *hf = NULL; int n = 0; str sval = STR_NULL; @@ -2358,6 +2359,62 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_null(msg, param, res); } + if((tv.flags == 0) && (tv.ri==HDR_CONTACT_T)) { + if(msg->contact==NULL) { + LM_DBG("no Contact header\n"); + return pv_get_null(msg, param, res); + } + if(parse_contact_headers(msg) < 0) { + LM_DBG("failed to parse Contact headers\n"); + return pv_get_null(msg, param, res); + } + if(idx<0) { + n = 1; + /* count Contact header bodies */ + for(hf=msg->contact; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_CONTACT_T) { + for(cb=(((contact_body_t*)hf->parsed)->contacts); + cb!=NULL; cb=cb->next) { + n++; + } + } + } + + idx = -idx; + if(idx>n) { + LM_DBG("index out of range\n"); + return pv_get_null(msg, param, res); + } + idx = n - idx; + } + if(idx==0) { + cb = ((contact_body_t*)msg->contact->parsed)->contacts; + sval.s = cb->name.s; + sval.len = cb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n=0; + for(hf=msg->contact; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_CONTACT_T) { + for(cb=(((contact_body_t*)hf->parsed)->contacts); + cb!=NULL; cb=cb->next) { + if(n==idx) { + sval.s = cb->name.s; + sval.len = cb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n++; + } + } + } + LM_DBG("unexpected contact index out of range\n"); + return pv_get_null(msg, param, res); + } + return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); }

1 0

git:master:25834469: core: select - test for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 03 Jun '21

03 Jun '21

Module: kamailio Branch: master Commit: 2583446968d81a9351caab1cfdd2cc86434850f3 URL: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T10:55:22+02:00 core: select - test for HDR_ERROR_T after header name parsing --- Modified: src/core/select_core.c --- Diff: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… Patch: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… --- diff --git a/src/core/select_core.c b/src/core/select_core.c index 029f880a48..02d393a6ba 100644 --- a/src/core/select_core.c +++ b/src/core/select_core.c @@ -595,7 +595,7 @@ int select_msg_header(str* res, select_t* s, struct sip_msg* msg) { /* get all headers */ char *c; - res->s = SIP_MSG_START(msg) + msg->first_line.len; + res->s = SIP_MSG_START(msg) + msg->first_line.len; c = get_body(msg); res->len = c - res->s; return 0; @@ -607,7 +607,7 @@ int select_anyheader(str* res, select_t* s, struct sip_msg* msg) int hi; char c; struct hdr_field hdr; - + if(msg==NULL) { if (res!=NULL) return -1; @@ -622,13 +622,15 @@ int select_anyheader(str* res, select_t* s, struct sip_msg* msg) /* if header name is parseable, parse it and set SEL_PARAM_DIV */ c=s->params[2].v.s.s[s->params[2].v.s.len]; s->params[2].v.s.s[s->params[2].v.s.len]=':'; - if (parse_hname2_short(s->params[2].v.s.s,s->params[2].v.s.s+(s->params[2].v.s.len<3?4:s->params[2].v.s.len+1), - &hdr)==0) { + parse_hname2_short(s->params[2].v.s.s,s->params[2].v.s.s + +(s->params[2].v.s.len<3?4:s->params[2].v.s.len+1), + &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("fixup_call:parse error\n"); return -1; } s->params[2].v.s.s[s->params[2].v.s.len]=c; - + if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) { /* pkg_free(s->params[1].v.s.s); */ /* don't free it (the mem can leak only once at startup)

1 0

[kamailio/kamailio] Update resolve.c handle type 41 (#2759)
by Andrew Webster 03 Jun '21

03 Jun '21

Possible solution to https://github.com/kamailio/kamailio/issues/2758   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2759 -- Commit Summary -- * Update resolve.c handle type 41 -- File Changes -- M src/core/resolve.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2759.patch https://github.com/kamailio/kamailio/pull/2759.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2759

2 2

git:master:cb2705f2: textops: check for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: cb2705f21e56f884e733febc2362055da3ef2693 URL: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T21:21:59+02:00 textops: check for HDR_ERROR_T after header name parsing --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… Patch: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 40ea02c273..e93bc82bf2 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -1816,7 +1816,8 @@ static int ki_remove_hf_idx(sip_msg_t* msg, str* hname, int idx) return -1; } - if(parse_hname2_str(hname, &hfm)==NULL) { + parse_hname2_str(hname, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("failed to parse header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2098,12 +2099,13 @@ static int ki_hname_gparam(str *hname, gparam_t *gp) gp->v.str = *hname; - if (parse_hname2_short(hbuf, hbuf + gp->v.str.len + 1, &hdr)==0) { + parse_hname2_short(hbuf, hbuf + gp->v.str.len + 1, &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name: %.*s\n", hname->len, hname->s); return -1; } - if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) { + if (hdr.type!=HDR_OTHER_T) { LM_DBG("using hdr type (%d) instead of <%.*s>\n", hdr.type, gp->v.str.len, gp->v.str.s); gp->v.str.s = NULL; @@ -3713,17 +3715,19 @@ static int hname_fixup(void** param, int param_no) gp->v.str.s[gp->v.str.len] = ':'; gp->v.str.len++; - if (parse_hname2_short(gp->v.str.s, gp->v.str.s + gp->v.str.len, &hdr)==0) + parse_hname2_short(gp->v.str.s, gp->v.str.s + gp->v.str.len, &hdr); + + gp->v.str.len--; + gp->v.str.s[gp->v.str.len] = c; + + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name\n"); pkg_free(gp); return E_UNSPEC; } - gp->v.str.len--; - gp->v.str.s[gp->v.str.len] = c; - - if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) + if (hdr.type!=HDR_OTHER_T) { LM_DBG("using hdr type (%d) instead of <%.*s>\n", hdr.type, gp->v.str.len, gp->v.str.s);

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev