- sr-dev - kamailio.org

git:master:e111de99: core: dset - helper function to encode/decode uri alias values
by Daniel-Constantin Mierla 30 Mar '21

30 Mar '21

Module: kamailio Branch: master Commit: e111de999e22ed5d968ac50844e92f3f21dc0c2e URL: https://github.com/kamailio/kamailio/commit/e111de999e22ed5d968ac50844e92f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-30T11:06:02+02:00 core: dset - helper function to encode/decode uri alias values --- Modified: src/core/dset.c Modified: src/core/dset.h --- Diff: https://github.com/kamailio/kamailio/commit/e111de999e22ed5d968ac50844e92f3… Patch: https://github.com/kamailio/kamailio/commit/e111de999e22ed5d968ac50844e92f3… --- diff --git a/src/core/dset.c b/src/core/dset.c index 16e1cdc12e..1252135043 100644 --- a/src/core/dset.c +++ b/src/core/dset.c @@ -1113,6 +1113,125 @@ int uri_trim_rcv_alias(str *uri, str *nuri) return 1; } +/** + * encode sip uri to uri alias parameter format + * - param: iuri - input sip uri + * - param: ualias - output uri alias value in format: address~port~proto + * * ualias->s must point to a buffer of size ualias->len, at least iuri->len + * * ualias->len is adjusted to the output value length + * - return 0 on success, negative on error + */ +int ksr_uri_alias_encode(str *iuri, str *ualias) +{ + sip_uri_t puri; + char *p; + + if (parse_uri (iuri->s, iuri->len, &puri) < 0) { + LM_ERR("failed to parse uri [%.*s]\n", iuri->len, iuri->s); + return -1; + } + + /*host~port~proto*/ + if(puri.host.len + 16 >= ualias->len) { + LM_ERR("not enough space to build uri alias - buf size: %d\n", + ualias->len); + return -1; + } + p = ualias->s; + memcpy(p, puri.host.s, puri.host.len); + p += puri.host.len; + *p++ = '~'; + if(puri.port.len>0) { + memcpy(p, puri.port.s, puri.port.len); + p += puri.port.len; + } else { + if(puri.proto==PROTO_TLS || puri.proto==PROTO_WSS) { + memcpy(p, "5061", 4); + } else { + memcpy(p, "5060", 4); + } + p += 4; + } + *p++ = '~'; + *p++ = puri.proto + '0'; + ualias->len = p - ualias->s; + ualias->s[ualias->len] = '\0'; + + LM_DBG("encoded <%.*s> => [%.*s]\n", + iuri->len, iuri->s, ualias->len, ualias->s); + + return 0; +} + +/** + * decode uri alias parameter to a sip uri + * - param: ualias - uri alias value in format: address~port~proto + * - param: ouri - output uri - ouri->s must point to a buffer of size ouri->len + * * ouri->len is adjusted to the output value length + * - return 0 on success, negative on error + */ +int ksr_uri_alias_decode(str *ualias, str *ouri) +{ + int n; + char *p; + int nproto; + str sproto; + + /* 24 => sip:...;transport=sctp */ + if(ualias->len + 24 >= ouri->len) { + LM_ERR("received uri alias is too long: %d\n", ualias->len); + return -1; + } + + /* received=ip~port~proto */ + memcpy(ouri->s, "sip:", 4); + memcpy(ouri->s + 4, ualias->s, ualias->len); + ouri->s[4 + ualias->len] = '\0'; + p = ouri->s + 4; + n = 0; + while(*p!='\0') { + if(*p=='~') { + n++; + if(n==1) { + /* port */ + *p = ':'; + } else if(n==2) { + /* proto */ + *p = ';'; + p++; + if(*p=='\0') { + LM_ERR("invalid received format\n"); + goto error; + } + nproto = *p - '0'; + if (nproto != PROTO_UDP) { + proto_type_to_str(nproto, &sproto); + if (sproto.len == 0) { + LM_ERR("unknown proto in received param\n"); + goto error; + } + memcpy(p, "transport=", 10); + p += 10; + memcpy(p, sproto.s, sproto.len); + p += sproto.len; + *p = '\0'; + ouri->len = (int)(p - ouri->s); + ouri->s[ouri->len] = '\0'; + break; + } + } else { + LM_ERR("invalid number of separators (%d)\n", n); + goto error; + } + } + p++; + } + return 0; + +error: + return -1; +} + /* address of record (aor) management */ /* address of record considered case sensitive diff --git a/src/core/dset.h b/src/core/dset.h index 981f1a5d6a..cf19fdfe1b 100644 --- a/src/core/dset.h +++ b/src/core/dset.h @@ -285,6 +285,8 @@ int setbflagsval(unsigned int branch, flag_t val); int uri_add_rcv_alias(sip_msg_t *msg, str *uri, str *nuri); int uri_restore_rcv_alias(str *uri, str *nuri, str *suri); int uri_trim_rcv_alias(str *uri, str *nuri); +int ksr_uri_alias_encode(str *iuri, str *ualias); +int ksr_uri_alias_decode(str *ualias, str *ouri); int init_dst_set(void);

1 0

git:5.3:00b6341b: carrierroute: replace faulty warning mechanism
by Lucian Balaceanu 30 Mar '21

30 Mar '21

Module: kamailio Branch: 5.3 Commit: 00b6341b361bdcd07b6fa901a652850e3dcd67be URL: https://github.com/kamailio/kamailio/commit/00b6341b361bdcd07b6fa901a652850… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2021-03-30T12:07:54+03:00 carrierroute: replace faulty warning mechanism - warning log for the same carrier/domain having routes with only 0 probability is now triggered through counting probabilities per carrier and domain - kudos also go to Huseyin Dikme - GH #2653 (cherry picked from commit 087c00a276623adad6b87242bc58f7c0b4d8ff33) --- Modified: src/modules/carrierroute/cr_data.c Modified: src/modules/carrierroute/cr_db.c Modified: src/modules/carrierroute/cr_db.h Modified: src/modules/carrierroute/cr_domain.h --- Diff: https://github.com/kamailio/kamailio/commit/00b6341b361bdcd07b6fa901a652850… Patch: https://github.com/kamailio/kamailio/commit/00b6341b361bdcd07b6fa901a652850…

1 0

git:5.4:f08e5814: carrierroute: replace faulty warning mechanism
by Lucian Balaceanu 30 Mar '21

30 Mar '21

Module: kamailio Branch: 5.4 Commit: f08e58145e93e57f2654ffcb901d49f9e898bcab URL: https://github.com/kamailio/kamailio/commit/f08e58145e93e57f2654ffcb901d49f… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2021-03-30T12:06:26+03:00 carrierroute: replace faulty warning mechanism - warning log for the same carrier/domain having routes with only 0 probability is now triggered through counting probabilities per carrier and domain - kudos also go to Huseyin Dikme - GH #2653 (cherry picked from commit 087c00a276623adad6b87242bc58f7c0b4d8ff33) --- Modified: src/modules/carrierroute/cr_data.c Modified: src/modules/carrierroute/cr_db.c Modified: src/modules/carrierroute/cr_db.h Modified: src/modules/carrierroute/cr_domain.h --- Diff: https://github.com/kamailio/kamailio/commit/f08e58145e93e57f2654ffcb901d49f… Patch: https://github.com/kamailio/kamailio/commit/f08e58145e93e57f2654ffcb901d49f…

1 0

git:5.3:518da782: core: use third array element when generating totag suffix
by Henning Westerholt 30 Mar '21

30 Mar '21

Module: kamailio Branch: 5.3 Commit: 518da782dc580aabd7fcddc7bea06b65ac7db232 URL: https://github.com/kamailio/kamailio/commit/518da782dc580aabd7fcddc7bea06b6… Author: Charles Chance <charles.chance(a)sipcentric.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-30T08:06:01Z core: use third array element when generating totag suffix (cherry picked from commit 895208ebb0f999365ded50a9ecfc0fb2ed2b1e01) --- Modified: src/core/tags.h --- Diff: https://github.com/kamailio/kamailio/commit/518da782dc580aabd7fcddc7bea06b6… Patch: https://github.com/kamailio/kamailio/commit/518da782dc580aabd7fcddc7bea06b6… --- diff --git a/src/core/tags.h b/src/core/tags.h index fff879cfab..b134dd3b01 100644 --- a/src/core/tags.h +++ b/src/core/tags.h @@ -51,17 +51,18 @@ static inline void calc_crc_suffix( struct sip_msg *msg, char *tag_suffix) suffix_source[0]=msg->via1->host; suffix_source[1]=msg->via1->port_str; if (msg->via1->branch) { - suffix_source[2]=msg->via1->branch->value; + suffix_source[ss_nr++]=msg->via1->branch->value; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0; } crcitt_string_array( tag_suffix, suffix_source, ss_nr ); + ss_nr=2; suffix_source[0]=msg->via1->port_str; suffix_source[1]=msg->via1->host; if (msg->callid) { - suffix_source[2]=msg->callid->body; + suffix_source[ss_nr++]=msg->callid->body; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0;

1 0

git:5.4:740ecd3d: core: use third array element when generating totag suffix
by Henning Westerholt 30 Mar '21

30 Mar '21

Module: kamailio Branch: 5.4 Commit: 740ecd3d54da2905142c3171292a00c3576a650f URL: https://github.com/kamailio/kamailio/commit/740ecd3d54da2905142c3171292a00c… Author: Charles Chance <charles.chance(a)sipcentric.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-30T08:05:40Z core: use third array element when generating totag suffix (cherry picked from commit 895208ebb0f999365ded50a9ecfc0fb2ed2b1e01) --- Modified: src/core/tags.h --- Diff: https://github.com/kamailio/kamailio/commit/740ecd3d54da2905142c3171292a00c… Patch: https://github.com/kamailio/kamailio/commit/740ecd3d54da2905142c3171292a00c… --- diff --git a/src/core/tags.h b/src/core/tags.h index fff879cfab..b134dd3b01 100644 --- a/src/core/tags.h +++ b/src/core/tags.h @@ -51,17 +51,18 @@ static inline void calc_crc_suffix( struct sip_msg *msg, char *tag_suffix) suffix_source[0]=msg->via1->host; suffix_source[1]=msg->via1->port_str; if (msg->via1->branch) { - suffix_source[2]=msg->via1->branch->value; + suffix_source[ss_nr++]=msg->via1->branch->value; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0; } crcitt_string_array( tag_suffix, suffix_source, ss_nr ); + ss_nr=2; suffix_source[0]=msg->via1->port_str; suffix_source[1]=msg->via1->host; if (msg->callid) { - suffix_source[2]=msg->callid->body; + suffix_source[ss_nr++]=msg->callid->body; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0;

1 0

[kamailio/kamailio] core: use third array element when generating totag suffix (#2696)
by Charles Chance 30 Mar '21

30 Mar '21

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Since totag suffix generation was updated in 5.3 to increase randomness, the third element of the array in both parts - via1 branch and call-id - have never been included. The result is that for any given host/port the generated totag is always the same, causing issues with some UAs - specifically relating to presence subscriptions in the cases identified. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2696 -- Commit Summary -- * core: use third array element when generating totag suffix -- File Changes -- M src/core/tags.h (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2696.patch https://github.com/kamailio/kamailio/pull/2696.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2696

3 3

git:master:895208eb: core: use third array element when generating totag suffix
by Henning Westerholt 30 Mar '21

30 Mar '21

Module: kamailio Branch: master Commit: 895208ebb0f999365ded50a9ecfc0fb2ed2b1e01 URL: https://github.com/kamailio/kamailio/commit/895208ebb0f999365ded50a9ecfc0fb… Author: Charles Chance <charles.chance(a)sipcentric.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-30T09:32:38+02:00 core: use third array element when generating totag suffix --- Modified: src/core/tags.h --- Diff: https://github.com/kamailio/kamailio/commit/895208ebb0f999365ded50a9ecfc0fb… Patch: https://github.com/kamailio/kamailio/commit/895208ebb0f999365ded50a9ecfc0fb… --- diff --git a/src/core/tags.h b/src/core/tags.h index fff879cfab..b134dd3b01 100644 --- a/src/core/tags.h +++ b/src/core/tags.h @@ -51,17 +51,18 @@ static inline void calc_crc_suffix( struct sip_msg *msg, char *tag_suffix) suffix_source[0]=msg->via1->host; suffix_source[1]=msg->via1->port_str; if (msg->via1->branch) { - suffix_source[2]=msg->via1->branch->value; + suffix_source[ss_nr++]=msg->via1->branch->value; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0; } crcitt_string_array( tag_suffix, suffix_source, ss_nr ); + ss_nr=2; suffix_source[0]=msg->via1->port_str; suffix_source[1]=msg->via1->host; if (msg->callid) { - suffix_source[2]=msg->callid->body; + suffix_source[ss_nr++]=msg->callid->body; } else { suffix_source[2].s = NULL; suffix_source[2].len = 0;

1 0

git:master:e36ea1fd: modules: readme files regenerated - textops ... [skip ci]
by Kamailio Dev 30 Mar '21

30 Mar '21

Module: kamailio Branch: master Commit: e36ea1fd0ad6e7d2814e8f07eff89a89ecd14469 URL: https://github.com/kamailio/kamailio/commit/e36ea1fd0ad6e7d2814e8f07eff89a8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-30T09:31:24+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/e36ea1fd0ad6e7d2814e8f07eff89a8… Patch: https://github.com/kamailio/kamailio/commit/e36ea1fd0ad6e7d2814e8f07eff89a8…

1 0

git:master:df1f22fc: textops: docs for str_find() and str_ifind()
by Daniel-Constantin Mierla 30 Mar '21

30 Mar '21

Module: kamailio Branch: master Commit: df1f22fc2948071d7f77533cec337c45080d3a85 URL: https://github.com/kamailio/kamailio/commit/df1f22fc2948071d7f77533cec337c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-30T09:25:36+02:00 textops: docs for str_find() and str_ifind() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/df1f22fc2948071d7f77533cec337c4… Patch: https://github.com/kamailio/kamailio/commit/df1f22fc2948071d7f77533cec337c4… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index c41859f731..6f3ab09f9a 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1760,6 +1760,52 @@ if (ends_with("$rU", "8800")) </example> </section> + <section id="textops.f.str_find"> + <title> + <function moreinfo="none">str_find(str1, str2)</function> + </title> + <para> + The function returns <emphasis>true</emphasis> (greater than 0) if + the str2 string is found in str1, case sensitive comparison. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>str_find</function> usage</title> + <programlisting format="linespecific"> +... +if (str_find("$rU", "8800")) { + # do interesting stuff here +} +... +</programlisting> + </example> + </section> + + <section id="textops.f.str_ifind"> + <title> + <function moreinfo="none">str_ifind(str1, str2)</function> + </title> + <para> + The function returns <emphasis>true</emphasis> (greater than 0) if + the str2 string is found in str1, case insensitive comparison. + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>str_ifind</function> usage</title> + <programlisting format="linespecific"> +... +if (str_ifind("$rU", "Alice")) { + # do interesting stuff here +} +... +</programlisting> + </example> + </section> + <section id="textops.f.set_body_multipart"> <title> <function moreinfo="none">set_body_multipart([txt,content_type][,boundary])</function>

1 0

git:master:38922466: textops: added functions to find a string inside another one
by Daniel-Constantin Mierla 30 Mar '21

30 Mar '21

Module: kamailio Branch: master Commit: 389224660bc748b7e9f69fadcbbed0faf8a44b5a URL: https://github.com/kamailio/kamailio/commit/389224660bc748b7e9f69fadcbbed0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-30T08:50:54+02:00 textops: added functions to find a string inside another one --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/389224660bc748b7e9f69fadcbbed0f… Patch: https://github.com/kamailio/kamailio/commit/389224660bc748b7e9f69fadcbbed0f… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 1b045dc89c..3d90e97a90 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -137,6 +137,8 @@ static int cmp_str_f(struct sip_msg *msg, char *str1, char *str2 ); static int cmp_istr_f(struct sip_msg *msg, char *str1, char *str2 ); static int starts_with_f(struct sip_msg *msg, char *str1, char *str2 ); static int ends_with_f(struct sip_msg *msg, char *str1, char *str2 ); +static int str_find_f(sip_msg_t *msg, char *str1, char *str2 ); +static int str_ifind_f(sip_msg_t *msg, char *str1, char *str2 ); static int remove_hf_re_f(struct sip_msg* msg, char* key, char* foo); static int remove_hf_exp_f(sip_msg_t* msg, char* ematch, char* eskip); static int is_present_hf_re_f(struct sip_msg* msg, char* key, char* foo); @@ -324,6 +326,12 @@ static cmd_export_t cmds[]={ {"ends_with", (cmd_function)ends_with_f, 2, fixup_spve_spve, 0, ANY_ROUTE}, + {"str_find", (cmd_function)str_find_f, 2, + fixup_spve_spve, 0, + ANY_ROUTE}, + {"str_ifind", (cmd_function)str_ifind_f, 2, + fixup_spve_spve, 0, + ANY_ROUTE}, {"is_audio_on_hold", (cmd_function)is_audio_on_hold_f, 0, 0, 0, ANY_ROUTE}, @@ -4271,6 +4279,78 @@ static int ki_ends_with(sip_msg_t *msg, str *vstr, str *vsuffix ) return -2; } +static int ki_str_find(sip_msg_t *msg, str *txt, str *needle) +{ + char *p; + + if(txt==NULL || needle==NULL) { + return -1; + } + + if(needle->len > txt->len) { + return -1; + } + p = str_search(txt, needle); + if(p==NULL) { + return -1; + } + + return (int)(1 + p - txt->s); +} + +static int str_find_f(struct sip_msg *msg, char *str1, char *str2 ) +{ + str s1; + str s2; + + if(fixup_get_svalue(msg, (gparam_p)str1, &s1)!=0) { + LM_ERR("cannot get first parameter\n"); + return -8; + } + if(fixup_get_svalue(msg, (gparam_p)str2, &s2)!=0) { + LM_ERR("cannot get second parameter\n"); + return -8; + } + + return ki_str_find(msg, &s1, &s2); +} + +static int ki_str_ifind(sip_msg_t *msg, str *txt, str *needle) +{ + char *p; + + if(txt==NULL || needle==NULL) { + return -1; + } + + if(needle->len > txt->len) { + return -1; + } + p = str_casesearch(txt, needle); + if(p==NULL) { + return -1; + } + + return (int)(1 + p - txt->s); +} + +static int str_ifind_f(sip_msg_t *msg, char *str1, char *str2 ) +{ + str s1; + str s2; + + if(fixup_get_svalue(msg, (gparam_p)str1, &s1)!=0) { + LM_ERR("cannot get first parameter\n"); + return -8; + } + if(fixup_get_svalue(msg, (gparam_p)str2, &s2)!=0) { + LM_ERR("cannot get second parameter\n"); + return -8; + } + + return ki_str_ifind(msg, &s1, &s2); +} + static int ki_is_audio_on_hold(sip_msg_t *msg) { int sdp_session_num = 0, sdp_stream_num; @@ -5019,6 +5099,16 @@ static sr_kemi_t sr_kemi_textops_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("textops"), str_init("str_find"), + SR_KEMIP_INT, ki_str_find, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("textops"), str_init("str_ifind"), + SR_KEMIP_INT, ki_str_ifind, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("textops"), str_init("is_audio_on_hold"), SR_KEMIP_INT, ki_is_audio_on_hold, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

[kamailio/kamailio] Kamailio 5.4.2 - CentOS 7 - qm_free(): BUG: freeing already freed pointer, called from core: core/usr_avp.c: destroy_avp_list_unsafe (#2620)
by Ryan Gehrig 29 Mar '21

29 Mar '21

Hi, Same issue with @farnk05 on https://github.com/kamailio/kamailio/issues/2224 Wanted to open a fresh issue to not reopen an old one. This is on kamailio 5.4.2, which appears to have these fixes from https://github.com/kamailio/kamailio/issues/2224#issuecomment-602730307 in them when I checked the src files. ``` $ sudo rpm -qi kamailio |grep Date Install Date: Fri 20 Nov 2020 12:03:26 AM PST Build Date : Tue 27 Oct 2020 05:37:31 AM PDT ``` ``` $ sudo rpm -qa | grep kamailio kamailio-mysql-5.4.2-0.el7.x86_64 kamailio-tls-5.4.2-0.el7.x86_64 kamailio-5.4.2-0.el7.x86_64 kamailio-websocket-5.4.2-0.el7.x86_64 kamailio-tcpops-5.4.2-0.el7.x86_64 kamailio-statsd-5.4.2-0.el7.x86_64 ``` Package Source: https://rpm.kamailio.org/centos/7/5.4/5.4.2/x86_64/ OS: RHEL 7.6.1810 Mem mgr: default/qm SHM is 4096, PKG is 1024 (system has 16gb ram, 4 core Intel Skylake CPU on a KVM. There are a few variations we see with the qm_free errors, here are the most common we see when kamailio segfaults, and we have to let systemd restart it, or Monit as we now have to have Monit check for CRITICAL messages since kamailio segfaults so often. ``` /usr/sbin/kamailio[32734]: CRITICAL: <core> [core/mem/q_malloc.c:521]: qm_free(): BUG: freeing already freed pointer (0x7f0da5012fc0), called from core: core/usr_avp.c: destroy_avp_list_unsafe(626), first free core: core/usr_avp.c: destroy_avp_list_unsafe(626) - ignoring /usr/sbin/kamailio[32734]: CRITICAL: <core> [core/mem/q_malloc.c:521]: qm_free(): BUG: freeing already freed pointer (0x7f0da5012fc0), called from core: core/usr_avp.c: destroy_avp_list_unsafe(626), first free core: core/usr_avp.c: destroy_avp_list_unsafe(626) - ignoring ... ``` ``` /usr/sbin/kamailio[32733]: CRITICAL: dialog [dlg_profile.c:574]: set_dlg_profile(): BUG - dialog not found in a non REQUEST route (1) /usr/sbin/kamailio[32733]: CRITICAL: dialog [dlg_profile.c:574]: set_dlg_profile(): BUG - dialog not found in a non REQUEST route (1) /usr/sbin/kamailio[6160]: CRITICAL: <core> [core/mem/q_malloc.c:521]: qm_free(): BUG: freeing already freed pointer (0x7ff00842e320), called from tm: h_table.c: free_cell_helper(189), first free core: core/usr_avp.c: destroy_avp_list_unsafe(626) - ignoring ``` GDB as requested in the other Issue (note gdb was run on another VM, not the main system, hopefully that is not an issue: ``` $ gdb /usr/sbin/kamailio /core-kamailio-11-995-992-11912-1612143069 GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-114.el7 Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /usr/sbin/kamailio...Reading symbols from /usr/lib/debug/usr/sbin/kamailio.debug...done. done. [New LWP 11912] warning: .dynamic section for "/lib64/libc.so.6" is not at the expected address (wrong library or version mismatch?) [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by '/usr/sbin/kamailio -DD -P /var/run/kamailio/kamailio.pid -f /etc/kamailio/kamai'. Program terminated with signal 11, Segmentation fault. #0 0x00000000006024be in destroy_avp_list_unsafe (list=0x7fdc559d4fd8) at core/usr_avp.c:625 625 avp = avp->next; Missing separate debuginfos, use: debuginfo-install glibc-2.17-260.el7_6.6.x86_64 keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-37.el7_6.x86_64 libcom_err-1.42.9-13.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 libmaxminddb-1.2.0-1.el7.x86_64 libselinux-2.5-14.1.el7.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 libunistring-0.9.3-9.el7.x86_64 mariadb-libs-5.5.60-1.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64 (gdb) frame 0 #0 0x00000000006024be in destroy_avp_list_unsafe (list=0x7fdc559d4fd8) at core/usr_avp.c:625 625 avp = avp->next; (gdb) list 620 avp_t *avp, *foo; 621 622 avp = *list; 623 while( avp ) { 624 foo = avp; 625 avp = avp->next; 626 shm_free_unsafe( foo ); 627 } 628 *list = 0; 629 } (gdb) p *p_entry No symbol "p_entry" in current context. (gdb) p *l No symbol "l" in current context. (gdb) No symbol "l" in current context. (gdb) p *lh No symbol "lh" in current context. (gdb) p *lh No symbol "lh" in current context. (gdb) frame 1 #1 0x00007fdd56fb8f92 in free_cell_helper (dead_cell=0x7fdc559d4dd8, silent=0, fname=0x7fdd570d1363 "timer.c", fline=643) at h_table.c:255 255 destroy_avp_list_unsafe(&dead_cell->uri_avps_from); (gdb) #1 0x00007fdd56fb8f92 in free_cell_helper (dead_cell=0x7fdc559d4dd8, silent=0, fname=0x7fdd570d1363 "timer.c", fline=643) at h_table.c:255 255 destroy_avp_list_unsafe(&dead_cell->uri_avps_from); (gdb) list 250 if(dead_cell->user_avps_from) 251 destroy_avp_list_unsafe(&dead_cell->user_avps_from); 252 if(dead_cell->user_avps_to) 253 destroy_avp_list_unsafe(&dead_cell->user_avps_to); 254 if(dead_cell->uri_avps_from) 255 destroy_avp_list_unsafe(&dead_cell->uri_avps_from); 256 if(dead_cell->uri_avps_to) 257 destroy_avp_list_unsafe(&dead_cell->uri_avps_to); 258 if(dead_cell->xavps_list) 259 xavp_destroy_list_unsafe(&dead_cell->xavps_list); (gdb) p *dlg No symbol "dlg" in current context. (gdb) p *msg No symbol "msg" in current context. (gdb) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2620

2 5

git:master:686bad20: modules: readme files regenerated - dmq ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 686bad209b3f445d8ab81643bd82648a12d72f1d URL: https://github.com/kamailio/kamailio/commit/686bad209b3f445d8ab81643bd82648… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T16:31:11+02:00 modules: readme files regenerated - dmq ... [skip ci] --- Modified: src/modules/dmq/README --- Diff: https://github.com/kamailio/kamailio/commit/686bad209b3f445d8ab81643bd82648… Patch: https://github.com/kamailio/kamailio/commit/686bad209b3f445d8ab81643bd82648… --- diff --git a/src/modules/dmq/README b/src/modules/dmq/README index 085fe3c9df..7daadc857d 100644 --- a/src/modules/dmq/README +++ b/src/modules/dmq/README @@ -222,7 +222,10 @@ modparam("dmq", "server_address", "sip:10.0.0.20:5061;transport=tls") 3.2. notification_address(str) The address of another DMQ node from which the local node should - retrieve initial information about all other nodes. + retrieve initial information about all other nodes. This parameter can + be specified multiple times in the configuration, to configure multiple + notification servers. If you configure multiple notification servers, + the multi_notify parameter needs to be disabled. Default value is “NULL”. @@ -247,7 +250,8 @@ modparam("dmq", "notification_channel", "peers") 3.4. multi_notify(int) Enables the ability to resolve multiple IPv4/IPv6 addresses for a - single notification address. + single notification address. Please note that this mode is not + supported if you specify multiple notification address parameter. A value of zero resolves to the first IP address found. A non-zero value resolves to all IP addresses associated with the host. This

1 0

git:master:678f9c6a: dmq: add support to specify a notification address multiple times in the cfg
by Henning Westerholt 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 678f9c6ad8a8118741a921fcc01f9b23b5702c6e URL: https://github.com/kamailio/kamailio/commit/678f9c6ad8a8118741a921fcc01f9b2… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T14:25:18Z dmq: add support to specify a notification address multiple times in the cfg - add support to specify a notification address multiple times in the cfg, e.g.: - modparam("dmq", "notification_address", "sip:10.0.0.1:5060") - modparam("dmq", "notification_address", "sip:10.0.0.2:5060") etc.. - this can be used to easily configure multiple notification server - it is an alternative to the multi_notify mode and do not work together with it --- Modified: src/modules/dmq/dmq.c Modified: src/modules/dmq/dmq.h Modified: src/modules/dmq/dmq_funcs.c Modified: src/modules/dmq/doc/dmq_admin.xml Modified: src/modules/dmq/notification_peer.c Modified: src/modules/dmq/notification_peer.h --- Diff: https://github.com/kamailio/kamailio/commit/678f9c6ad8a8118741a921fcc01f9b2… Patch: https://github.com/kamailio/kamailio/commit/678f9c6ad8a8118741a921fcc01f9b2…

1 0

git:master:981701d4: modules: readme files regenerated - path ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 981701d4ffa8bce2be3768f43cbde0f5344390fc URL: https://github.com/kamailio/kamailio/commit/981701d4ffa8bce2be3768f43cbde0f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T15:31:11+02:00 modules: readme files regenerated - path ... [skip ci] --- Modified: src/modules/path/README --- Diff: https://github.com/kamailio/kamailio/commit/981701d4ffa8bce2be3768f43cbde0f… Patch: https://github.com/kamailio/kamailio/commit/981701d4ffa8bce2be3768f43cbde0f…

1 0

git:master:6b607182: path: option to set received param name
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 6b607182678a5913b1e07c0e32725cb89b399501 URL: https://github.com/kamailio/kamailio/commit/6b607182678a5913b1e07c0e32725cb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T15:25:21+02:00 path: option to set received param name --- Modified: src/modules/path/path.c Modified: src/modules/path/path_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/6b607182678a5913b1e07c0e32725cb… Patch: https://github.com/kamailio/kamailio/commit/6b607182678a5913b1e07c0e32725cb…

1 0

git:master:54036506: path: docs for received_name parameter
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 54036506a005d30e0ea2685ac99d004b416bf0f3 URL: https://github.com/kamailio/kamailio/commit/54036506a005d30e0ea2685ac99d004… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T15:28:10+02:00 path: docs for received_name parameter --- Modified: src/modules/path/doc/path_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/54036506a005d30e0ea2685ac99d004… Patch: https://github.com/kamailio/kamailio/commit/54036506a005d30e0ea2685ac99d004… --- diff --git a/src/modules/path/doc/path_admin.xml b/src/modules/path/doc/path_admin.xml index 14c600f2a6..8c4dc8d9fd 100644 --- a/src/modules/path/doc/path_admin.xml +++ b/src/modules/path/doc/path_admin.xml @@ -168,6 +168,26 @@ modparam("path", "use_received", 1) ... modparam("path", "received_format", 1) ... +</programlisting> + </example> + </section> + <section id="path.p.received_name"> + <title><varname>received_name</varname> (str)</title> + <para> + Set the name of the header parameter to add the + <quote>received</quote> value. + </para> + <para> + <emphasis> + Default value is "received". + </emphasis> + </para> + <example> + <title>Set <varname>received_name</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("path", "received_name", "rcv") +... </programlisting> </example> </section>

1 0

git:master:0f0a56ad: path: removed svn id header
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 0f0a56ad5c97a611fab64fc9b9eba304643dcec8 URL: https://github.com/kamailio/kamailio/commit/0f0a56ad5c97a611fab64fc9b9eba30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T15:04:38+02:00 path: removed svn id header --- Modified: src/modules/path/path_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0f0a56ad5c97a611fab64fc9b9eba30… Patch: https://github.com/kamailio/kamailio/commit/0f0a56ad5c97a611fab64fc9b9eba30… --- diff --git a/src/modules/path/path_mod.c b/src/modules/path/path_mod.c index cc27d1a457..c7a2b637ac 100644 --- a/src/modules/path/path_mod.c +++ b/src/modules/path/path_mod.c @@ -1,6 +1,4 @@ /* - * $Id$ - * * Path handling for intermediate proxies * * Copyright (C) 2006 Inode GmbH (Andreas Granig <andreas.granig(a)inode.info>) @@ -17,8 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * */

1 0

git:5.3:57529832: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.3 Commit: 575298326cc2de40123262497dcc9baece74715a URL: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T15:01:37+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/htable/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba… Patch: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba…

1 0

git: new commits in branch 5.3
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

- URL: https://github.com/kamailio/kamailio/commit/9758c88a12cf08edf2f18ae71e13952… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:50:35+02:00 core: kemi - KSR.is_method_in() uses E/e to match PRACK (cherry picked from commit b04111b583b454b12ea0c6a265a14858c195b213) (cherry picked from commit ff5283b156f6aa934bd5f621537427d9f2b31b1d) - URL: https://github.com/kamailio/kamailio/commit/b3623ff5cf1eed58b0af9f0ed85b615… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:51:01+02:00 core: info message made dbg when adding a subst expression (cherry picked from commit 80b3d5d036da493316a93594c770df1ef8218e5e) (cherry picked from commit 0b98ddb1ea04603851ce581a69111581a1d30a67) - URL: https://github.com/kamailio/kamailio/commit/0d2edc1871aa8bf163e50612ded2668… Author: Dennis <dennis_y(a)mail.ru> Date: 2021-03-29T10:51:20+02:00 rtpengine: fixing wrong parsing the pair of IPv6 addr:port (#2592) - fixing wrong parsing the pair of IPv6 addr:port in rtpengine module, when loading node information from database. (cherry picked from commit 13d786e33d6f04a718af40ba345cf0827f752c2f) (cherry picked from commit f64d41efc8bf08daa8f4a36cb81d4620bea2b367) - URL: https://github.com/kamailio/kamailio/commit/14fd3f6432e1385be78022c21f0f666… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-03-29T10:51:48+02:00 core: work around interface enum buffer overrun When a system has too many interfaces and too many addresses, 8 kilobytes isn't enough to fit all of the netlink responses. As the result, kamailio gets stuck in a loop where it tries to do a 0-length recv. Increase the buffer to 32K. It's a miniscule amount for modern times anyway. Also, add diagnostics to make further troubleshooting easier. Proper fix would be to switch to libnl here, which would make a good weekend project. (cherry picked from commit d2fd204b0ae35512a04702e480bb0d16878e98be) (cherry picked from commit 252b0dd2d778c15ac6e96c7c415296619df3dc3e) - URL: https://github.com/kamailio/kamailio/commit/82476273898615f278ee209c65ad2be… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-03-29T10:52:00+02:00 core: fix unused argument in socket_info.c:get_flags get_flags has an argument - family - which is supposed to be used in netlink message, otherwise why would we need it? (cherry picked from commit 42f7702430c312b2c9caea8f617af4e3719ef12f) (cherry picked from commit 23000a3ab3d88419d4f0ac797aae201a22f0e1fb) - URL: https://github.com/kamailio/kamailio/commit/0761382626bb4c8882c7fa5226e6380… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:52:39+02:00 kamctl: option for rpc command to replace tokens in parameters - supported now: replace '=CRLF=' with '\r\n' - fix 'kamctl ping' command by replacing '=CRLF=' with '\r\n' in multi-headers parameter (cherry picked from commit 1c66f6a1a5d04c33f1912609a36729b06b6eebd7) (cherry picked from commit 9b5eade1faa8deeb3fcc8f9cb010f803c17ee309) - URL: https://github.com/kamailio/kamailio/commit/577f8b9b8bb3920be739f940d0a1c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:52:52+02:00 kamctl: use tm.t_uac_wait for ping command (cherry picked from commit 20d075a17189961baf63ac000e4417d7f04d8a08) (cherry picked from commit 6769d44cfab686824a6b077bc8cbb4a347fd3356) - URL: https://github.com/kamailio/kamailio/commit/aee753d522088c09620e73872d5b18a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:53:30+02:00 kamctl: use param evaluation mode for cisco restart command (cherry picked from commit 359050f9be40002aec1d3894dc43a2a8762ce8cc) (cherry picked from commit b8a7d2bfd1118d556c9e46dcab97fbcb45fa6187) - URL: https://github.com/kamailio/kamailio/commit/ac05b82e8036b14423652b3bee2b347… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:55:23+02:00 kamctl: added srv debug subcommand - control server debug level via rpc (cherry picked from commit 6b5aa70f09e294338a65a0bf2fcae8b92fdc6fae) (cherry picked from commit 3027f8b9daed5ca4f36d0779cd6f79e596bf42e1) - URL: https://github.com/kamailio/kamailio/commit/5d34b8e4cc025c8b1bceee9fa066b9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:55:58+02:00 app_python3: handle deprecated PyEval_InitThreads() - https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads - GH #2626 (cherry picked from commit ca37f9247ecb6754fbdbd210fc59158bf0f32def) (cherry picked from commit f9f33d37f80003836cf87338a4dd96b1b4614c22) - URL: https://github.com/kamailio/kamailio/commit/5030d4f7e066222e88813cf89ed387e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:57:08+02:00 tls: fixed small typo in log message (cherry picked from commit 3c1a454a1ac4fe8e668f709d3e278bbce59c51d3) (cherry picked from commit a36805a26aa84e865ba18260d94587be44688883) - URL: https://github.com/kamailio/kamailio/commit/7898de48fe58b3a17e846ba7b8e4af6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:57:44+02:00 core: cfg.lex - do not destroy action if pre-fixup fails - params might be in inconsistent state, shutdown is triggered which cleans the pkg anyhow - GH #2630 (cherry picked from commit dddd530ed9fa7b6ca8b31ff299105a53c39c1a5e) (cherry picked from commit 38dd7fd703f043c51756df936abc56103c891545) - URL: https://github.com/kamailio/kamailio/commit/b2b0979ab435c82ea2dc9ba6e2552e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:58:32+02:00 htable: docs - not about use of event_route[htable:mod-init] (cherry picked from commit e0dcb1617bedf13cc3fc76cf7f3b5cd516806bc8) (cherry picked from commit e0461d1c4026dd2953e4352bea0586419980180b) - URL: https://github.com/kamailio/kamailio/commit/17af137c8ce2112387b6e356bbc4797… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:59:04+02:00 pv: proper transfomation name in the log message (cherry picked from commit b4d1def5d8a5ffaddbd87708d8dc99f0f5f8853c) (cherry picked from commit e8595172d317b03a335bfd7c29fdf09d2e6da8b5) - URL: https://github.com/kamailio/kamailio/commit/f78d112e7c7e03e0c9121b9f34471c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:59:52+02:00 rr: catch uri without host part when matching local addresses - can happen for tel or urn uri (cherry picked from commit 81cd9c5d6934392cafd4b73541a19dbfa4b553f9) (cherry picked from commit 908acb8f0995d10b1ed9334fc7b81166b14ab8cc) - URL: https://github.com/kamailio/kamailio/commit/55689451b6902f6bcd61e3eaf5221d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:03+02:00 core: early detect of empty host for check_self() (cherry picked from commit 6863cb8b0253c641146633bd063575a53bc6a466) (cherry picked from commit 5b6a77222eca4e927480ed7b18e7f233e3fdf822) - URL: https://github.com/kamailio/kamailio/commit/856c5632011480b1281bb5f6ce8ebd6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:13+02:00 jsonrpcs: use json null value for c null char* or str* (cherry picked from commit c48e409b741821fa470788b3bca0ead32e4d6efc) (cherry picked from commit 3632d39b557d2b926ccfce4fd83b4c16568e6ee1) - URL: https://github.com/kamailio/kamailio/commit/77a8514ee2c459579b706078237d134… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:28+02:00 ipops: use local ip struct for internal resolving - static structure from core can be overwritten on subsequential use - GH #2645 (cherry picked from commit 2ce244825bf7bc38f145699209ef7125ae5480d0) (cherry picked from commit 47b45b60a037808a675f7d52dd5b2ee80bfe0868) - URL: https://github.com/kamailio/kamailio/commit/7c9f6aeb7f7bbaad68a14252f084b33… Author: Piotr Gregor <piotr(a)signalwire.com> Date: 2021-03-29T11:00:45+02:00 kamdbctl: typo in log message - core tables successfully installed (cherry picked from commit 571fe52f4ad0cf5ceef98fb2d77c2711f3692c28) (cherry picked from commit 68ec1e125e5069160696c8a634cac43e14d35ddd) - URL: https://github.com/kamailio/kamailio/commit/fe17b6f7117105a644b5888db0ffe30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:11:35+02:00 ims_qos: typos in comments (cherry picked from commit f9c336aa9a78169cf9c7f3fd9bfcfd22218078fb) (cherry picked from commit c9a46eb88365add327b5d6f11f121c26a6230e58) - URL: https://github.com/kamailio/kamailio/commit/bad7d0aeb170b7a93787c3f60806d55… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:38:58+02:00 ims_charging: renamed str_list_t to str_htlist_t - fix conflict added by e1dc6dd6d9b206168f6da2929560ca6a64e1b41e (cherry picked from commit 1f751775525fdcdb5a75b45fbf451e2bef3696ec) (cherry picked from commit 0df03a96e9ed07ff1683690f95598bf44b87701a) - URL: https://github.com/kamailio/kamailio/commit/0301ed59003aceb645a8f7c781596c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:35+02:00 ipops: proper handling of return code for ip to buf conversion - reported in GH #2695 (cherry picked from commit 1d7d78c31eeab717c7013a00650d3cb07895bac8) (cherry picked from commit 8bd9404ff172671338a91a16aa04cbf8e22db501) - URL: https://github.com/kamailio/kamailio/commit/068f5d10a97e5aa79a14ac74e9b6d60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:47+02:00 topos: handle 100 response completely - it may be needed by other modules to be processed with all via stack (cherry picked from commit 80e812caf83a131c5f830b7d23de754136fd54f7) (cherry picked from commit 8ac768c9da3102db87a420b5a5bea8a960183698) - URL: https://github.com/kamailio/kamailio/commit/fbf0e1eeb84f1bc3a66cc3f0f68d10f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:59+02:00 topos: one more update to enable processing ofr 100 (cherry picked from commit 620194165e0c6c27dfe9dbe382dc2e7b58be13b5) (cherry picked from commit a7442d19734a40c6b2f9df2d427216bf5631d3a9) - URL: https://github.com/kamailio/kamailio/commit/3458fe7b341f312079948f86a1f01e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T12:18:08+02:00 xmlrpc: use <nil/> for null string values - XML-RPC extension listed at https://en.wikipedia.org/wiki/XML-RPC#Data_types (cherry picked from commit 17b9a6add82781f71b4d84da7c804e0e72c8b026) (cherry picked from commit e8c38b14f2cecaaf41468e52bc23e5b15aa5cf81) - URL: https://github.com/kamailio/kamailio/commit/3d4eb57841a07deb09e01afc214db9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T12:18:18+02:00 ctl: handle null char* and str* values everywhere - not all cases were covered (cherry picked from commit fa0d2f05ad5124f6166a0384265a827187c6c83f) (cherry picked from commit 25c26de179f3e5081afb2f1ff063bc535a7cc06b) - URL: https://github.com/kamailio/kamailio/commit/34076bfe3a018a48addbfc5e4b017ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:54:12+02:00 xmlrpc: fixed error assigning to str variable added by previous commit (cherry picked from commit 4c6715b5e4a0938ece2937a787c6d2ed6e81a3d8) (cherry picked from commit 2c154f3cfaba97d9a97ca924ce17e01ac3519c74) - URL: https://github.com/kamailio/kamailio/commit/18024d670a28602080e1ff32fa26658… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:54:31+02:00 textops: docs - note about search() doing posix regex matching (cherry picked from commit 0cbee55284c4f4d5fef09a3185de31d04776e569) (cherry picked from commit 5a1c7faa6b72feaa71da383e5b19e6442a50b27d) - URL: https://github.com/kamailio/kamailio/commit/0f10d2dee358ddf3dd4db9d1da6bff2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:01+02:00 usrloc: adjusted rpc reply text when the location domain table is not found (cherry picked from commit d3a36ed6757eeda42dc32608a63b857ee9a67bb9) (cherry picked from commit a0a5b201041616d1df7f497eb4db7eb49b080f96) - URL: https://github.com/kamailio/kamailio/commit/2710b7825ce4b74c7448575693c711c… Author: easyrider14 <stephane.houssin(a)hotmail.fr> Date: 2021-03-29T13:55:25+02:00 cplc: permanent contact not skipped by lookup anymore - a permanently registered contact has an "expires" value of 0 in usrloc when processing lookup, cplc module checks that contacts are not expired by checking that the "expires" value of the contact is not lower than current time as a consequence, permanently registered contact are alsways skipped and never targeted (cherry picked from commit 525ee139abcb45f71bda42b417b5f8e75c12a622) (cherry picked from commit 631232a502de1e6ec60a72b4828ddfcaff57e805) - URL: https://github.com/kamailio/kamailio/commit/d37e5da02d1de9b1c39a890a4c4536d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:38+02:00 tm: log message if starting cancel retransmission fails (cherry picked from commit afe84defa4ab391064c266e15f557415c5249f7c) (cherry picked from commit 5ae6e5222a65030d8e2fd313ca1da8c4dad12830) - URL: https://github.com/kamailio/kamailio/commit/d6a9148faff05125d06a3c7e6650ed7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:53+02:00 registrar: documented lookup_to_dset() cfg function [skip ci] - function available for long time, but somehow was not documented - GH #2623 (cherry picked from commit 56cdf70ea008b5401bdd7d1824f15788f85fc6fa) (cherry picked from commit c6a07c6891fd14aa0d46d5b0d064bc45d41b1a88) - URL: https://github.com/kamailio/kamailio/commit/d011770220830454219518da7f586ff… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2021-03-29T13:56:16+02:00 rtpengine: remove square brackets from IPv6 address for getaddrinfo function - After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:nnnn, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN. (cherry picked from commit 491d1261e04e09f13990d5062c21faca7eb32b37) (cherry picked from commit 3141310b5cd6283d1f7b1ebed3d7471fb0d03138) - URL: https://github.com/kamailio/kamailio/commit/1219a949663dd1e18499ec135e06fe0… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T13:56:26+02:00 nathelper: small spelling fixes (cherry picked from commit 46dee155ee10a2f11ecfd41b103f92752042c5ec) (cherry picked from commit 695439f128ccae4306730735eac7a9e8dd286eb9) - URL: https://github.com/kamailio/kamailio/commit/081407592b57b3704b4183ae6c2466e… Author: Miteshkumar Thakkar <mitesht(a)users.noreply.github.com> Date: 2021-03-29T13:56:37+02:00 app_lua: Fixed error 'too many parameters' - Calling function KSR.secsipid.secsipid_add_identity() has six parameters, is giving error 'too many parameters' (cherry picked from commit 5460949614c92c7dbfb7f63274540500f2a69d5b) (cherry picked from commit d0f028b4f48fc6e55612ed43bc9160d2bf67fb10) - URL: https://github.com/kamailio/kamailio/commit/66a35ce02a1b68672dbd965e632877b… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2021-03-29T13:56:59+02:00 rtpengine: fix typo in docs (cherry picked from commit 5cc888f0e9e305734621c0db1f63a47f2f0c381a) (cherry picked from commit ad6559f48735a9b369caad851bf87392a12dee9a) - URL: https://github.com/kamailio/kamailio/commit/ad4f9c76fc607bbd195eb612f1a4707… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:57:43+02:00 acc_diameter: init variables for safer cleanup (cherry picked from commit 5c48d437935e971482c9bbf41f067d120911e2c8) (cherry picked from commit 652c3fb55f94efee0c9d5b16f3f492ad8e771984) - URL: https://github.com/kamailio/kamailio/commit/e3deee64670b9d4280a5fe53d449240… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:58:10+02:00 pv: use unsigned for safer non-ascii bit shifting for hexa - related to GH #2690 (cherry picked from commit c331e6dddb238abe5fc832ce3d3934fbe56ad2f7) (cherry picked from commit 7faaf17a532de7c2f4f781f3a33bfd8306458ca0)

1 0

git:master:08ccff91: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 08ccff9107f4c1ff1f0e863967be688b6c821bb4 URL: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T12:01:13+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… Patch: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 27c2337426..24d02d1c5d 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -421,7 +421,9 @@ Chapter 1. Admin Guide module parameter definition for syntax description. The balancing inside a set is done automatically by the module based on - the weight of each RTPEngine from the set. + the weight of each RTPEngine from the set. The default weight is 1, if + another RTPEngine should be used twice as often as the first one, one + would specify the weight 2 for this server, for example. The selection of the set is done from script prior using rtpengine_delete(), rtpengine_offer() or rtpengine_answer() functions -

1 0

git:master:ab68c7a6: rtpengine: improvement in docs related to sock weights
by Henning Westerholt 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: ab68c7a6190bb89775cb92428bc2c5ac4798f560 URL: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T09:51:59Z rtpengine: improvement in docs related to sock weights --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… Patch: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index d7f102ece5..ef7d5a4fd7 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -46,7 +46,9 @@ </para> <para> The balancing inside a set is done automatically by the module based on - the weight of each RTPEngine from the set. + the weight of each RTPEngine from the set. The default weight is 1, if + another RTPEngine should be used twice as often as the first one, one + would specify the weight 2 for this server, for example. </para> <para> The selection of the set is done from script prior using

1 0

git:5.4:fa2e5178: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.4 Commit: fa2e51786dcb3daaa389055c6dc2b17c2a2d7c7b URL: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T10:46:39+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/pv/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/textops/README Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17… Patch: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17…

1 0

git:5.4:b864dcf0: kemix: exported function get_rcvadvip() and get_rcvadvport()
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.4 Commit: b864dcf0eaf984c83b4e7b5c4d1c70f7a3b32ac5 URL: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:45:03+02:00 kemix: exported function get_rcvadvip() and get_rcvadvport() - return advertised address and port of the receiving socket - forward porting from 5.3 (cherry picked from commit 070a9c042a1caf19162d3d97b26f8d7548747cbb) (cherry picked from commit a76f06eb010765216450bd78bcc1040aa9902280) --- Modified: src/modules/kemix/kemix_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… Patch: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… --- diff --git a/src/modules/kemix/kemix_mod.c b/src/modules/kemix/kemix_mod.c index 4bd6f839d1..66cdcf1bc1 100644 --- a/src/modules/kemix/kemix_mod.c +++ b/src/modules/kemix/kemix_mod.c @@ -520,6 +520,38 @@ static sr_kemi_xval_t* ki_kx_get_rcvport(sip_msg_t *msg) return &_sr_kemi_kx_xval; } +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rcvadvip(sip_msg_t *msg) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + if(msg->rcv.bind_address!=NULL + && msg->rcv.bind_address->useinfo.address_str.len > 0) { + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + _sr_kemi_kx_xval.v.s = msg->rcv.bind_address->useinfo.address_str; + return &_sr_kemi_kx_xval; + } + + return ki_kx_get_rcvip(msg); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rcvadvport(sip_msg_t *msg) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + if(msg->rcv.bind_address!=NULL + && msg->rcv.bind_address->useinfo.port_no_str.len > 0) { + _sr_kemi_kx_xval.vtype = SR_KEMIP_INT; + _sr_kemi_kx_xval.v.n = (int)msg->rcv.bind_address->useinfo.port_no; + return &_sr_kemi_kx_xval; + } + + return ki_kx_get_rcvport(msg); +} + /** * */ @@ -1085,6 +1117,16 @@ static sr_kemi_t sr_kemi_kx_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("kx"), str_init("get_rcvadvip"), + SR_KEMIP_XVAL, ki_kx_get_rcvadvip, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_rcvadvport"), + SR_KEMIP_XVAL, ki_kx_get_rcvadvport, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("kx"), str_init("get_proto"), SR_KEMIP_XVAL, ki_kx_get_proto, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git: new commits in branch 5.4
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

- URL: https://github.com/kamailio/kamailio/commit/8ac768c9da3102db87a420b5a5bea8a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:04+02:00 topos: handle 100 response completely - it may be needed by other modules to be processed with all via stack (cherry picked from commit 80e812caf83a131c5f830b7d23de754136fd54f7) - URL: https://github.com/kamailio/kamailio/commit/a7442d19734a40c6b2f9df2d427216b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:17+02:00 topos: one more update to enable processing ofr 100 (cherry picked from commit 620194165e0c6c27dfe9dbe382dc2e7b58be13b5) - URL: https://github.com/kamailio/kamailio/commit/e8c38b14f2cecaaf41468e52bc23e5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:45+02:00 xmlrpc: use <nil/> for null string values - XML-RPC extension listed at https://en.wikipedia.org/wiki/XML-RPC#Data_types (cherry picked from commit 17b9a6add82781f71b4d84da7c804e0e72c8b026) - URL: https://github.com/kamailio/kamailio/commit/25c26de179f3e5081afb2f1ff063bc5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:56+02:00 ctl: handle null char* and str* values everywhere - not all cases were covered (cherry picked from commit fa0d2f05ad5124f6166a0384265a827187c6c83f) - URL: https://github.com/kamailio/kamailio/commit/2c154f3cfaba97d9a97ca924ce17e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:16:10+02:00 xmlrpc: fixed error assigning to str variable added by previous commit (cherry picked from commit 4c6715b5e4a0938ece2937a787c6d2ed6e81a3d8) - URL: https://github.com/kamailio/kamailio/commit/beb59d4bf335c927d1224e02a67e81d… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:25+02:00 ims_diameter_server: check response is not null before json conversion (cherry picked from commit 6968f1df9e9d3d66810df910d290f3d9368255fe) - URL: https://github.com/kamailio/kamailio/commit/9fb04eb982ef4903801970981faff9b… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:42+02:00 ims_diameter_server: fix initialization of s_message (cherry picked from commit faf1edabf732af5a24ad0399098ad11e27b3a1ab) - URL: https://github.com/kamailio/kamailio/commit/0d4e6c8b7450823dfb8caa6baaa6ce0… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:58+02:00 ims_diameter_server: drop cdp session to avoid deadlock (cherry picked from commit 84c342277f2a73196cb377476f2b80e6b4085e7b) - URL: https://github.com/kamailio/kamailio/commit/532eedac63d0bd2b0c4c6b4f9557ac2… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:18:17+02:00 ims_diameter_server: fix check for addAVPsfromJSON return code (cherry picked from commit 88d38bd306f595585af6e972ac529b40d7a93b58) - URL: https://github.com/kamailio/kamailio/commit/5a1c7faa6b72feaa71da383e5b19e64… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:18:40+02:00 textops: docs - note about search() doing posix regex matching (cherry picked from commit 0cbee55284c4f4d5fef09a3185de31d04776e569) - URL: https://github.com/kamailio/kamailio/commit/50e9db0cd53381cec5e522777556adb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:02+02:00 pv: handle missing fields (otcid, instance) for $banch() and $sbranch() (cherry picked from commit 0c4becd70428ef15be76fb0aa53932e5803c6bd0) - URL: https://github.com/kamailio/kamailio/commit/a0a5b201041616d1df7f497eb4db7eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:17+02:00 usrloc: adjusted rpc reply text when the location domain table is not found (cherry picked from commit d3a36ed6757eeda42dc32608a63b857ee9a67bb9) - URL: https://github.com/kamailio/kamailio/commit/8248442af0d32ee4045590dbb8b083b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:36+02:00 rtp_media_server: Makefile - removed unnecessary DEFS+=-DKAMAILIO_MOD_INTERFACE (cherry picked from commit 7532f864cb9698aff95b9023bc9ff6959a41fd3f) - URL: https://github.com/kamailio/kamailio/commit/631232a502de1e6ec60a72b4828ddfc… Author: easyrider14 <stephane.houssin(a)hotmail.fr> Date: 2021-03-29T10:22:14+02:00 cplc: permanent contact not skipped by lookup anymore - a permanently registered contact has an "expires" value of 0 in usrloc when processing lookup, cplc module checks that contacts are not expired by checking that the "expires" value of the contact is not lower than current time as a consequence, permanently registered contact are alsways skipped and never targeted (cherry picked from commit 525ee139abcb45f71bda42b417b5f8e75c12a622) - URL: https://github.com/kamailio/kamailio/commit/5ae6e5222a65030d8e2fd313ca1da8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:14+02:00 tm: log message if starting cancel retransmission fails (cherry picked from commit afe84defa4ab391064c266e15f557415c5249f7c) - URL: https://github.com/kamailio/kamailio/commit/9fb67b2d70dadefe667c0bfbff7e324… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:38+02:00 uac: docs - listed uac_auth_mode() function (cherry picked from commit be4e1843c54e70206688c1f2d1f5483165baef8f) - URL: https://github.com/kamailio/kamailio/commit/da5df462c81ba7e4ef700fbd19bc57c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:48+02:00 uac: exposed uac_auth_mode() also as uac_mode([mode]) to match docs (cherry picked from commit bb1fe2fc12cb0499c5242c220dd8065e83fe6e61) - URL: https://github.com/kamailio/kamailio/commit/c6a07c6891fd14aa0d46d5b0d064bc4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:24:02+02:00 registrar: documented lookup_to_dset() cfg function [skip ci] - function available for long time, but somehow was not documented - GH #2623 (cherry picked from commit 56cdf70ea008b5401bdd7d1824f15788f85fc6fa) - URL: https://github.com/kamailio/kamailio/commit/293e161fb8828310954ea37f522c2e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:24:19+02:00 presence: do not init db in dmq worker for in-memory only mode - GH #2642 (cherry picked from commit 2b475553ef77f63cb444c34ad6c2df0ea237c88b) - URL: https://github.com/kamailio/kamailio/commit/5d47465d6791f6213994ae77089d156… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Date: 2021-03-29T10:26:07+02:00 smsops: fix parsing of validity period - Validity period is present only for SUBMIT msg type and it is an optional parameter. For now supports only Relative VP format. (cherry picked from commit c4b1d0ab700ea03869114d08daa78ab6a6a56b96) - URL: https://github.com/kamailio/kamailio/commit/3141310b5cd6283d1f7b1ebed3d7471… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2021-03-29T10:31:05+02:00 rtpengine: remove square brackets from IPv6 address for getaddrinfo function - After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:nnnn, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN. (cherry picked from commit 491d1261e04e09f13990d5062c21faca7eb32b37) - URL: https://github.com/kamailio/kamailio/commit/695439f128ccae4306730735eac7a9e… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T10:31:38+02:00 nathelper: small spelling fixes (cherry picked from commit 46dee155ee10a2f11ecfd41b103f92752042c5ec) - URL: https://github.com/kamailio/kamailio/commit/d0f028b4f48fc6e55612ed43bc9160d… Author: Miteshkumar Thakkar <mitesht(a)users.noreply.github.com> Date: 2021-03-29T10:32:02+02:00 app_lua: Fixed error 'too many parameters' - Calling function KSR.secsipid.secsipid_add_identity() has six parameters, is giving error 'too many parameters' (cherry picked from commit 5460949614c92c7dbfb7f63274540500f2a69d5b) - URL: https://github.com/kamailio/kamailio/commit/d23aef79e6ecd6149b9a6db7a09dd46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:17+02:00 core: comments updated for msg_send_buffer() (cherry picked from commit 9c2c4bafa0f0cd980b5867e7d4c0995255730f87) - URL: https://github.com/kamailio/kamailio/commit/e2c7d171bbd65e2689a3c498330c546… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:34+02:00 core: events - rename SREV_NET_DATA_SEND to SREV_NET_DATA_SENT - reflects better the purpose, being executed after the message is sent (cherry picked from commit 93df5a5241f57ffb71dad0b0df04a256b7b0b7b4) - URL: https://github.com/kamailio/kamailio/commit/d8871bfa1d0a3b2f1c01fb51e518e1e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:47+02:00 siptrace: renamed SREV_NET_DATA_SEND to SREV_NET_DATA_SENT (cherry picked from commit e1570a115f99c896d3703b756fe95cc28e0cb7d5) - URL: https://github.com/kamailio/kamailio/commit/0c0d833aeeaf6a4fed91300189e2c4f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:33:05+02:00 pv: docs - note about use of $shv() in kemi scripts for shvset param [skip ci] (cherry picked from commit bcc6370cdc00f25ce3d0f29e168c20ca880dcda2) - URL: https://github.com/kamailio/kamailio/commit/9a8002541773108a3a9dcb8a2f31a91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:33:19+02:00 pv: docs - relocated shvset note outside of param definition details [skip ci] (cherry picked from commit c959a3c5f5efa1158bd53a31476f33d080793928) - URL: https://github.com/kamailio/kamailio/commit/ad6559f48735a9b369caad851bf8739… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2021-03-29T10:33:40+02:00 rtpengine: fix typo in docs (cherry picked from commit 5cc888f0e9e305734621c0db1f63a47f2f0c381a) - URL: https://github.com/kamailio/kamailio/commit/75caa3c348706838722898c01e324b9… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: 2021-03-29T10:34:12+02:00 siptrace: properly terminate logs with '\n' (cherry picked from commit 5ac49634c18955ffedd0ad909d2199e5881905c6) - URL: https://github.com/kamailio/kamailio/commit/652c3fb55f94efee0c9d5b16f3f492a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:00+02:00 acc_diameter: init variables for safer cleanup (cherry picked from commit 5c48d437935e971482c9bbf41f067d120911e2c8) - URL: https://github.com/kamailio/kamailio/commit/d7cec6d68fc2198ae69d3c5d30dd0fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:40+02:00 core: use unsigned for safer non-ascii bit shifting for hexa (cherry picked from commit 9efe1e0c32ae43d67240d6a97306e3cff61c3c55) - URL: https://github.com/kamailio/kamailio/commit/7faaf17a532de7c2f4f781f3a33bfd8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:50+02:00 pv: use unsigned for safer non-ascii bit shifting for hexa - related to GH #2690 (cherry picked from commit c331e6dddb238abe5fc832ce3d3934fbe56ad2f7)

1 0

[kamailio/kamailio] Fix ip parsing in ipops (#2695)
by Nathan 29 Mar '21

29 Mar '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2645 #### Description For #2645, a patch was pushed in 47b45b60a037808a675f7d52dd5b2ee80bfe0868, but this code does not correctly check the return value of `str2ip6buf` and `str2ipbuf`. As described in the comments on both methods, they return zero *for success*. This MR should be backported to 5.4 as well. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2695 -- Commit Summary -- * Fix ip parsing in ipops -- File Changes -- M src/modules/ipops/ipops_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2695.patch https://github.com/kamailio/kamailio/pull/2695.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2695

2 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev