### Description
I don't know if this is a bug, or if I missing some config requirements. I mentioned the issue on the sr-user but did not get any comment.
In case serial (or combined serial/parallel) branching is wished, the q value from the registered contact is considered to define the order in which a call is serial branched.
If a CPE registers without q value, the value can be defined by:
modparam("registrar", "default_q", 500)
If a CPE registers with a q value, the client provided value is not being overridden by the default_q setting.
In order to force the order there is a need to override the q value provided by a CPE.
According to the Manual this is possible:
modparam("registrar", "xavp_cfg", "reg")
https://www.kamailio.org/docs/modules/devel/modules/registrar.html#registra…
q - q value of contact (integer 0-1000). It overrides q value given in contact header and default_q parameter. Used in save().
#### Reproduction
Actual config:
```
modparam("registrar", "method_filtering", 1)
modparam("registrar", "max_contacts", 10)
modparam("registrar", "max_expires", 3600)
modparam("registrar", "gruu_enabled", 0)
modparam("registrar", "retry_after", 30)
modparam("registrar", "xavp_cfg", "reg")
modparam("registrar", "default_q", 600)
modparam("registrar", "use_path", 1)
modparam("registrar", "path_mode", 1)
modparam("registrar", "path_check_local", 0)
```
```
route[REGISTRAR] {
# Create an AOR based on the auth_username for the location service.
$var(saveuri) = "sip:" + $aU + "@" + $rd;
$xavp(reg=>q) = 450;
$var(result) = save("location","0x00","$var(saveuri)");
if ($var(result) == -2) {
xlog("L_ERR", "$cfg(route): Too many contacts for $var(saveuri)\n");
sl_reply_error();
}
if ($var(result) == -1) {
xlog("L_ERR", "$cfg(route): Error saving location $var(saveuri)\n");
sl_reply_error();
}
if ($var(result) == 1) {
xlog("L_INFO", "$cfg(route): Contact $var(saveuri) inserted\n");
}
if ($var(result) == 2) {
if ($avp(debug) > 0) {
xlog("L_INFO", "$cfg(route): Contact $var(saveuri) updated\n");
}
}
if ($var(result) == 3) {
xlog("L_INFO", "$cfg(route): Contact $var(saveuri) deleted\n");
}
if ($var(result) == 4) {
xlog("L_INFO", "$cfg(route): Contact $var(saveuri) returned\n");
}
}
```
#### Debugging Data
```
# kamctl ul show | json_pp | grep "Q"
"Q" : 0.6,
"Q" : 0.6,
"Q" : 0.6,
"Q" : 0.5,
"Q" : 0.6,
"Q" : 0.6,
"Q" : 0.6,
```
CPE providing a q value (0.5 in this case for CPE 4) are not overriden.
CPE providing no q value are inserted with default_q value.
Expectation: $xavp(reg=>q) = 450 should cause all CPE to register with Q: 0.45
#### Log Messages
No errors logged while saving contact.
#### SIP Traffic
I could show the Register messages of CPE with q= attribute and without, but I don't think this contributes to solving the issue.
### Possible Solutions
I attempted some other notations like:
$xavp(reg>q)
or
$xavp(reg[0]=>q)
none worked.
I also noted some time ago that setting: $xavp(reg=>max_contacts) also does not work
### Additional Information
```
# kamailio -v
version: kamailio 5.7.6 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 11.4.0
```
```
Distributor ID: Ubuntu
Description: Ubuntu 22.04.4 LTS
Release: 22.04
Codename: jammy
```
Any help / hints appreciated!
-Benoît-
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4068
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4068(a)github.com>
Hello,
I propose to aim freezing the development for 6.0.x series at the end of
the 16th of December 2024 (Monday).
New features that one wants to get in this release series have to be
pushed to git repository or pull requests made for them. Afterwards
usually follows a 4-6 weeks of testing till the first release 6.0.0.
Unfreezing will happen earlier, after the first weeks of testing when
the 6.0 branch will be created.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
- allows custom tags to be added to prometheus metrics
- Addresses GH issue #4021
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #4021
#### Description
<!-- Describe your changes in detail -->
This change adds a new parameter `xhttp_prom_tags`. It allows the user to append tags to the prometheus metrics. This makes those metrics a lot more useful when having multiple kamailio instances running on a single host.
This is done by 2 shared memory helper variables which contain the parameter in different formats. This way it is easy to print them out with minimal changes.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4072
-- Commit Summary --
* xhttp_prom: new xhttp_prom_tags parameter
* Fixed formating
-- File Changes --
M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (25)
M src/modules/xhttp_prom/prom.c (30)
M src/modules/xhttp_prom/xhttp_prom.c (50)
M src/modules/xhttp_prom/xhttp_prom.h (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4072.patchhttps://github.com/kamailio/kamailio/pull/4072.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4072
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4072(a)github.com>
### Description
When I rewrite from native to Lua syntax, I find that `pv_www_authenticate` has no corresponding implementation, can we add it?
### Expected behavior
#### Actual observed behavior
#### Debugging Data
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a improvement.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
Kamailio 5.8.2
Lua 5.1.4
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4067
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4067(a)github.com>
- allows custom tags to be added to prometheus metrics
- Addresses GH issue #4021
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #4021
#### Description
<!-- Describe your changes in detail -->
This change adds a new parameter `xhttp_prom_tags`. It allows the user to append tags to the prometheus metrics. This makes those metrics a lot more useful when having multiple kamailio instances running on a single host.
This is done by 2 shared memory helper variables which contain the parameter in different formats. This way it is easy to print them out with minimal changes.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4070
-- Commit Summary --
* xhttp_prom: new xhttp_prom_tags parameter
-- File Changes --
M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (25)
M src/modules/xhttp_prom/prom.c (25)
M src/modules/xhttp_prom/xhttp_prom.c (45)
M src/modules/xhttp_prom/xhttp_prom.h (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4070.patchhttps://github.com/kamailio/kamailio/pull/4070.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4070
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4070(a)github.com>
Discuss and track updates to default kamailio.cfg for v6.0.x series.
If you want to add something new to or remove from kamailio.cfg, post a comment in this thread.
Commits to kamailio.cfg can also reference this tracker item.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4034
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4034(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
#### Description
kamailio module for handling as-feature-event presence messages
This module provide support for 'Device FeatureKey Synchronization', as described in
http://community.polycom.com/polycom/attachments/polycom/VoIP/2233/1/Device…
This 'protocol' was developed at Broadsoft, and is used in Linksys/Cisco and Polycom phones and probably some other too.
It allows to set up features like dnd (No Not Disturb) and call forwarding using phone interface and have that status
updated on aplication server/ proxy or otherway, set those features on aplication server using some gui, and have this data
provisioned on phone.
For Shared Line Appreance application this let You share status on all phones.
[original source](https://github.com/majastanislawska/sip-router-presence_dfks-module…
[sipwise](https://github.com/sipwise/kamailio/blob/master/debian/patches/sip…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4065
-- Commit Summary --
* presence_dfks: [WIP]
* pua: support as-feature-event
* Makefile.groups: add presence_dfks to mod_list_presence
* cmake: add presence_dfks to MOD_LIST_PRESENCE
-- File Changes --
M cmake/groups.cmake (1)
M src/Makefile.groups (2)
A src/modules/presence_dfks/CMakeLists.txt (6)
A src/modules/presence_dfks/Makefile (27)
A src/modules/presence_dfks/README.md (32)
A src/modules/presence_dfks/add_events.c (316)
A src/modules/presence_dfks/add_events.h (7)
A src/modules/presence_dfks/presence_dfks.c (131)
A src/modules/presence_dfks/presence_dfks.h (18)
M src/modules/pua/add_events.c (13)
M src/modules/pua/add_events.h (2)
M src/modules/pua/hash.h (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4065.patchhttps://github.com/kamailio/kamailio/pull/4065.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4065
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4065(a)github.com>
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue https://lists.kamailio.org/mailman3/hyperkitty/list/sr-users@lists.kamailio…
#### Description
``current_msg_id_repl is only`` changed if ``$diameter_reponse`` is changed by via ``pv_set_response()``. The event_route is executed with a ``fake_msg`` so it will not match if is setted outside anyways.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4069
-- Commit Summary --
* ims_diameter_server: fix retrieval ``$diameter_response`` value
-- File Changes --
M src/modules/ims_diameter_server/avp_helper.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4069.patchhttps://github.com/kamailio/kamailio/pull/4069.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4069
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4069(a)github.com>