- sr-dev - kamailio.org

[kamailio/kamailio] tm: Emit event only when CANCEL request is locally generated (PR #4286)
by Xenofon Karamanos 18 Jun '25

18 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3831 and #4249 #### Description  This PR intoduces a flag for the tm cancel logic. The flag denotes that the cancel request is locally generated and an event of `local_request` should be emmited. Updated also the modules and functions that used tm bindings to adopt for this change. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4286 -- Commit Summary -- * tm: Generate local_request for CANCEL only if locally initiated * dialog: Update to use new tm FLAG for CANCEL * rtp_media_server: Update to use new tm FLAG for CANCEL * tmx: Update to use new tm FLAG for CANCEL -- File Changes -- M src/modules/dialog/dlg_req_within.c (2) M src/modules/rtp_media_server/rtp_media_server.c (2) M src/modules/tm/t_cancel.c (69) M src/modules/tm/t_cancel.h (2) M src/modules/tmx/tmx_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4286.patch https://github.com/kamailio/kamailio/pull/4286.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4286 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4286(a)github.com>

3 3

[kamailio/kamailio] dlgs: Fix spelling mistake (PR #4288)
by Xenofon Karamanos 18 Jun '25

18 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix a spelling mistake You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4288 -- Commit Summary -- * dlgs: Fix spelling mistake -- File Changes -- M src/modules/dlgs/dlgs_records.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4288.patch https://github.com/kamailio/kamailio/pull/4288.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4288 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4288(a)github.com>

3 5

git:5.8:ae4342ad: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 5.8 Commit: ae4342ad20a0e98681f83f1874294869d930e99d URL: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:44:43Z dlgs: Fix spelling mistake (cherry picked from commit 994d4dfa9cd284f63092543400a5ed82b746a758) --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… Patch: https://github.com/kamailio/kamailio/commit/ae4342ad20a0e98681f83f187429486… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:6.0:c0e60449: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: c0e60449ae0d35fd9e753d0da92c98c03e2a4494 URL: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:41:37Z dlgs: Fix spelling mistake (cherry picked from commit 994d4dfa9cd284f63092543400a5ed82b746a758) --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… Patch: https://github.com/kamailio/kamailio/commit/c0e60449ae0d35fd9e753d0da92c98c… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:6.0:0637ca7e: tmx: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 0637ca7e0b7795c33ab9f230c0eee65d6ea80e8d URL: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:40:39Z tmx: Update to use new tm FLAG for CANCEL (cherry picked from commit caad49279e6db7e85e3f2b84276f9defb0aa4eef) --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… Patch: https://github.com/kamailio/kamailio/commit/0637ca7e0b7795c33ab9f230c0eee65… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index aae6547834d..4e1e7c78289 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -333,7 +333,7 @@ static int t_cancel_branches_helper(sip_msg_t *msg, int n) LM_DBG("canceling %d/%d\n", n, (int)cancel_data.cancel_bitmap); if(cancel_data.cancel_bitmap == 0) return -1; - _tmx_tmb.cancel_uacs(t, &cancel_data, 0); + _tmx_tmb.cancel_uacs(t, &cancel_data, F_CANCEL_LOCAL); return 1; } @@ -408,7 +408,7 @@ static int ki_t_cancel_callid_reason( cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); + _tmx_tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); //_tmx_tmb.unref_cell(trans); _tmx_tmb.t_sett(bkt, bkb);

1 0

git:6.0:c3160efc: rtp_media_server: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: c3160efc9b4af01d8e2997fdc6cb168838f76ba9 URL: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:41Z rtp_media_server: Update to use new tm FLAG for CANCEL (cherry picked from commit fc5f804ad92593f74110a9392d63384e04fed218) --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… Patch: https://github.com/kamailio/kamailio/commit/c3160efc9b4af01d8e2997fdc6cb168… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 720c4afd900..21abb7fb836 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -1024,7 +1024,7 @@ static int rms_sip_cancel(struct sip_msg *msg, str *callid_s, str *cseq_s) cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - tmb.cancel_uacs(trans, &cancel_data, 0); + tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); tmb.t_sett(bkt, bkb); if(!tmb.t_reply(msg, 202, "cancelling")) {

1 0

git:6.0:5d82b77a: dialog: Update to use new tm FLAG for CANCEL
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 5d82b77ad9852d8d584edef97ec11e16879a1fd6 URL: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:33Z dialog: Update to use new tm FLAG for CANCEL (cherry picked from commit 9740f5ea7ee0b9827cf3e113bc1c458f72b8cbf7) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… Patch: https://github.com/kamailio/kamailio/commit/5d82b77ad9852d8d584edef97ec11e1… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 773ae788e3b..57c2df5475e 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -407,7 +407,7 @@ static inline int send_bye( LM_DBG("\"%d %.*s\" sent to caller\n", bye_early_code, bye_early_reason.len, bye_early_reason.s); } else { - d_tmb.cancel_all_uacs(cell->t, 0); + d_tmb.cancel_all_uacs(cell->t, F_CANCEL_LOCAL); LM_DBG("CANCEL sent to callee(s)\n"); } return 0;

1 0

git:6.0:835a3b60: tm: Generate local_request for CANCEL only if locally initiated
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: 6.0 Commit: 835a3b60607db381b3941b308f00c0469fcaf021 URL: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2025-06-18T08:39:21Z tm: Generate local_request for CANCEL only if locally initiated - Introduce new flag F_CANCEL_LOCAL (cherry picked from commit 49ffcebdf6cbf8ce2e4e2e55d9197b906f74ff95) --- Modified: src/modules/tm/t_cancel.c Modified: src/modules/tm/t_cancel.h --- Diff: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… Patch: https://github.com/kamailio/kamailio/commit/835a3b60607db381b3941b308f00c04… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index d4f1be0eaca..e3114c70d0e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -338,44 +338,47 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, LM_DBG("sending cancel...\n"); - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, evname.s); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); + if(flags & F_CANCEL_LOCAL) { + /* Call event */ + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } } - } - // /* Check if msg is null */ - if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { - LM_ERR("fail to parse msg\n"); - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - LM_DBG("tm:local-request found [%d]\n", rt); - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { + /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_DBG("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } } } + set_route_type(backup_rt); + free_sip_msg(&msg); } - set_route_type(backup_rt); - free_sip_msg(&msg); if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) @@ -429,7 +432,7 @@ void rpc_cancel(rpc_t *rpc, void *c) prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); /* tell tm to cancel the call */ DBG("Now calling cancel_uacs\n"); - i = cancel_uacs(trans, &cancel_data, 0); /* don't fake 487s, + i = cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); /* don't fake 487s, just wait for timeout */ /* t_lookup_callid REF`d the transaction for us, we must UNREF here! */ diff --git a/src/modules/tm/t_cancel.h b/src/modules/tm/t_cancel.h index b80a6dba77b..d5042edd97d 100644 --- a/src/modules/tm/t_cancel.h +++ b/src/modules/tm/t_cancel.h @@ -65,6 +65,8 @@ and F_CANCE_B_KILL take precedence */ #define F_CANCEL_UNREF 16 /* unref the trans after canceling */ +#define F_CANCEL_LOCAL 32 /* cancel is locally generated */ + void prepare_to_cancel(struct cell *t, branch_bm_t *cancel_bm, branch_bm_t s); int cancel_uacs(struct cell *t, struct cancel_info *cancel_data, int flags);

1 0

[kamailio/kamailio] cmake format options and naming styles (Issue #4075)
by Daniel-Constantin Mierla 18 Jun '25

18 Jun '25

Discussion to define cmake format options and coding/naming styles. It is better to define most of them now to have coherency in the future. Started from the discussion on #4066. Comment with what you would like to have, describing when useful why your proposal is a good/better option. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4075 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4075(a)github.com>

5 12

git:master:994d4dfa: dlgs: Fix spelling mistake
by Xenofon Karamanos 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 994d4dfa9cd284f63092543400a5ed82b746a758 URL: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-06-18T11:11:26+03:00 dlgs: Fix spelling mistake --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… Patch: https://github.com/kamailio/kamailio/commit/994d4dfa9cd284f63092543400a5ed8… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index f6cad29856e..38ecb3d5ee3 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -692,7 +692,7 @@ void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) stats->c_confirmed += val; return; case DLGS_STATE_TERMINATED: - stats->c_terminted += val; + stats->c_terminated += val; return; case DLGS_STATE_NOTANSWERED: stats->c_notanswered += val; @@ -1046,7 +1046,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; - sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_terminated += _dlgs_htb->slots[i].astats.c_terminated; sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; } sti = &sta; @@ -1058,7 +1058,7 @@ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) } if(rpc->struct_add(ti, "uuuuuu", "init", sti->c_init, "progress", sti->c_progress, "answered", sti->c_answered, "confirmed", - sti->c_confirmed, "terminted", sti->c_terminted, + sti->c_confirmed, "terminated", sti->c_terminated, "notanswered", sti->c_notanswered) < 0) { rpc->fault(ctx, 500, "Internal error creating values"); diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index e6a02824a62..0dfeba797c9 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -43,7 +43,7 @@ typedef struct _dlgs_stats { unsigned int c_progress; unsigned int c_answered; unsigned int c_confirmed; - unsigned int c_terminted; + unsigned int c_terminated; unsigned int c_notanswered; } dlgs_stats_t;

1 0

git:master:caad4927: tmx: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: caad49279e6db7e85e3f2b84276f9defb0aa4eef URL: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 tmx: Update to use new tm FLAG for CANCEL --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… Patch: https://github.com/kamailio/kamailio/commit/caad49279e6db7e85e3f2b84276f9de… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index aae6547834d..4e1e7c78289 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -333,7 +333,7 @@ static int t_cancel_branches_helper(sip_msg_t *msg, int n) LM_DBG("canceling %d/%d\n", n, (int)cancel_data.cancel_bitmap); if(cancel_data.cancel_bitmap == 0) return -1; - _tmx_tmb.cancel_uacs(t, &cancel_data, 0); + _tmx_tmb.cancel_uacs(t, &cancel_data, F_CANCEL_LOCAL); return 1; } @@ -408,7 +408,7 @@ static int ki_t_cancel_callid_reason( cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; _tmx_tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - _tmx_tmb.cancel_uacs(trans, &cancel_data, 0); + _tmx_tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); //_tmx_tmb.unref_cell(trans); _tmx_tmb.t_sett(bkt, bkb);

1 0

git:master:fc5f804a: rtp_media_server: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: fc5f804ad92593f74110a9392d63384e04fed218 URL: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 rtp_media_server: Update to use new tm FLAG for CANCEL --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… Patch: https://github.com/kamailio/kamailio/commit/fc5f804ad92593f74110a9392d63384… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 720c4afd900..21abb7fb836 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -1024,7 +1024,7 @@ static int rms_sip_cancel(struct sip_msg *msg, str *callid_s, str *cseq_s) cancel_data.reason.cause = rcode; cancel_data.cancel_bitmap = 0; tmb.prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); - tmb.cancel_uacs(trans, &cancel_data, 0); + tmb.cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); tmb.t_sett(bkt, bkb); if(!tmb.t_reply(msg, 202, "cancelling")) {

1 0

git:master:9740f5ea: dialog: Update to use new tm FLAG for CANCEL
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 9740f5ea7ee0b9827cf3e113bc1c458f72b8cbf7 URL: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 dialog: Update to use new tm FLAG for CANCEL --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… Patch: https://github.com/kamailio/kamailio/commit/9740f5ea7ee0b9827cf3e113bc1c458… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 48494bef428..1e7c71c17f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -407,7 +407,7 @@ static inline int send_bye( LM_DBG("\"%d %.*s\" sent to caller\n", bye_early_code, bye_early_reason.len, bye_early_reason.s); } else { - d_tmb.cancel_all_uacs(cell->t, 0); + d_tmb.cancel_all_uacs(cell->t, F_CANCEL_LOCAL); LM_DBG("CANCEL sent to callee(s)\n"); } return 0;

1 0

git:master:49ffcebd: tm: Generate local_request for CANCEL only if locally initiated
by Henning Westerholt 18 Jun '25

18 Jun '25

Module: kamailio Branch: master Commit: 49ffcebdf6cbf8ce2e4e2e55d9197b906f74ff95 URL: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-18T09:07:59+02:00 tm: Generate local_request for CANCEL only if locally initiated - Introduce new flag F_CANCEL_LOCAL --- Modified: src/modules/tm/t_cancel.c Modified: src/modules/tm/t_cancel.h --- Diff: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… Patch: https://github.com/kamailio/kamailio/commit/49ffcebdf6cbf8ce2e4e2e55d9197b9… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index d4f1be0eaca..e3114c70d0e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -338,44 +338,47 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, LM_DBG("sending cancel...\n"); - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, evname.s); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); + if(flags & F_CANCEL_LOCAL) { + /* Call event */ + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } } - } - // /* Check if msg is null */ - if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { - LM_ERR("fail to parse msg\n"); - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - LM_DBG("tm:local-request found [%d]\n", rt); - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { + /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_DBG("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } } } + set_route_type(backup_rt); + free_sip_msg(&msg); } - set_route_type(backup_rt); - free_sip_msg(&msg); if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) @@ -429,7 +432,7 @@ void rpc_cancel(rpc_t *rpc, void *c) prepare_to_cancel(trans, &cancel_data.cancel_bitmap, 0); /* tell tm to cancel the call */ DBG("Now calling cancel_uacs\n"); - i = cancel_uacs(trans, &cancel_data, 0); /* don't fake 487s, + i = cancel_uacs(trans, &cancel_data, F_CANCEL_LOCAL); /* don't fake 487s, just wait for timeout */ /* t_lookup_callid REF`d the transaction for us, we must UNREF here! */ diff --git a/src/modules/tm/t_cancel.h b/src/modules/tm/t_cancel.h index b80a6dba77b..d5042edd97d 100644 --- a/src/modules/tm/t_cancel.h +++ b/src/modules/tm/t_cancel.h @@ -65,6 +65,8 @@ and F_CANCE_B_KILL take precedence */ #define F_CANCEL_UNREF 16 /* unref the trans after canceling */ +#define F_CANCEL_LOCAL 32 /* cancel is locally generated */ + void prepare_to_cancel(struct cell *t, branch_bm_t *cancel_bm, branch_bm_t s); int cancel_uacs(struct cell *t, struct cancel_info *cancel_data, int flags);

1 0

git:master:7dc92ed5: modules: readme files regenerated - rr ... [skip ci]
by Kamailio Dev 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 7dc92ed5a45e004cc1dc6898a9027d265e220721 URL: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-17T22:16:09+02:00 modules: readme files regenerated - rr ... [skip ci] --- Modified: src/modules/rr/README --- Diff: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… Patch: https://github.com/kamailio/kamailio/commit/7dc92ed5a45e004cc1dc6898a9027d2… --- diff --git a/src/modules/rr/README b/src/modules/rr/README index 0fc41c9767a..1919d7a6e84 100644 --- a/src/modules/rr/README +++ b/src/modules/rr/README @@ -466,13 +466,16 @@ if(!loose_route_preloaded()) { 5.3. loose_route_mode(vmode) - The function is similar to `loose_route()`, but it does only loose - routing processing if vmode==1, skipping the testing of r-uri==myself - for performing strict routing. If vmode==0, it behaves like - loose_route(). + The function is similar to `loose_route()`, but it accepts route mode + bitmask as vmode parameter. - It is a convenient function to use with application servers that set - the Contact URI to SIP server address. + If bit one is set, then do only loose routing processing, skipping the + testing of r-uri==myself for performing strict routing. If not, behave + like loose_route(). If bit two is set, then skip flow tokens + processing. + + First bit is convenient to use with application servers that set the + Contact URI to SIP server address. This function can be used from REQUEST_ROUTE.

1 0

[kamailio/kamailio] rr: add force_lr_no_outbound_flag param (PR #4280)
by Michael Furmur 17 Jun '25

17 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description `loose_route()` in `rr` checks request src ip/port against ip/port in flow tokens to detect direction and decide whether to apply flow tokens routing: ``` static inline int process_outbound(struct sip_msg *_m, str flow_token) { ... } else if(!ip_addr_cmp(&rcv->src_ip, &_m->rcv.src_ip) || rcv->src_port != _m->rcv.src_port) { LM_DBG("\"incoming\" request found. Using flow-token for " "routing\n"); ... ``` there are cases when remote UA changes ip/port for in-dialog messages and this approach does not work. incoming message has route set with flow tokens and src ip/port different from ones in the flow tokens. as a result, `loose_route()` routes message back to the client using flow tokens instead of using the normal part of the Route headers as expected. new `force_lr_no_outbound_flag` allows to control flow tokens usage in the `loose_route()` when we know direction based on the some high level config logic (for example: by the result of `ds_is_from_list()` call) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4280 -- Commit Summary -- * rr: add force_lr_no_outbound_flag param -- File Changes -- M src/modules/rr/doc/rr_admin.xml (17) M src/modules/rr/loose.c (6) M src/modules/rr/rr_mod.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4280.patch https://github.com/kamailio/kamailio/pull/4280.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4280 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4280(a)github.com>

2 5

git:master:eef8d69b: rr: loose_route_mode: add vmode bit 2 to skip outbound
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: eef8d69bc88bac394d7134ab9f591cdea3b4914b URL: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T22:02:15+02:00 rr: loose_route_mode: add vmode bit 2 to skip outbound --- Modified: src/modules/rr/doc/rr_admin.xml Modified: src/modules/rr/loose.c Modified: src/modules/rr/rr_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… Patch: https://github.com/kamailio/kamailio/commit/eef8d69bc88bac394d7134ab9f591cd… --- diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml index 4801b845dfb..4a2921fce32 100644 --- a/src/modules/rr/doc/rr_admin.xml +++ b/src/modules/rr/doc/rr_admin.xml @@ -446,11 +446,16 @@ if(!loose_route_preloaded()) { <section id="rr.f.loose_route_mode"> <title><function moreinfo="none">loose_route_mode(vmode)</function></title> - <para>The function is similar to `loose_route()`, but it does only - loose routing processing if vmode==1, skipping the testing of r-uri==myself - for performing strict routing. If vmode==0, it behaves like loose_route(). + <para>The function is similar to `loose_route()`, + but it accepts route mode bitmask as <emphasis>vmode</emphasis> parameter. </para> - <para>It is a convenient function to use with application servers that + <para> + If bit one is set, then do only loose routing processing, skipping the testing of r-uri==myself + for performing strict routing. If not, behave like loose_route(). + If bit two is set, then skip flow tokens processing. + </para> + <para> + First bit is convenient to use with application servers that set the Contact URI to SIP server address. </para> <para>This function can be used from REQUEST_ROUTE.</para> diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index 23378147903..443f90b17f4 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -854,7 +854,7 @@ static inline void rr_do_force_send_socket( * \param preloaded do we have a preloaded route set * \return -1 on failure, 1 on success */ -static inline int after_loose(struct sip_msg *_m, int preloaded) +static inline int after_loose(struct sip_msg *_m, int _mode, int preloaded) { struct hdr_field *hdr; struct sip_uri puri; @@ -890,9 +890,11 @@ static inline int after_loose(struct sip_msg *_m, int preloaded) routed_msg_id.msgid = _m->id; routed_msg_id.pid = _m->pid; - if((use_ob = process_outbound(_m, puri.user)) < 0) { - LM_INFO("failed to process outbound flow-token\n"); - return RR_FLOW_TOKEN_BROKEN; + if(!(_mode & RR_LR_MODE_SKIP_OUTBOUND)) { + if((use_ob = process_outbound(_m, puri.user)) < 0) { + LM_INFO("failed to process outbound flow-token\n"); + return RR_FLOW_TOKEN_BROKEN; + } } if(rr_force_send_socket && !use_ob) { @@ -1050,12 +1052,12 @@ int loose_route_mode(sip_msg_t *_m, int _mode) if(ret < 0) { return -1; } else if(ret == 1) { - return after_loose(_m, 1); + return after_loose(_m, _mode, 1); } else { - if((_mode == 0) && (is_myself(&_m->parsed_uri))) { + if((!(_mode & RR_LR_MODE_LOOSE_ONLY)) && (is_myself(&_m->parsed_uri))) { return after_strict(_m); } else { - return after_loose(_m, 0); + return after_loose(_m, _mode, 0); } } } diff --git a/src/modules/rr/rr_mod.h b/src/modules/rr/rr_mod.h index 829e912e499..a411625824c 100644 --- a/src/modules/rr/rr_mod.h +++ b/src/modules/rr/rr_mod.h @@ -36,6 +36,11 @@ extern str i_user; #endif +/*! bit to force loose mode in loose_route_mode() */ +#define RR_LR_MODE_LOOSE_ONLY 1 +/*! bit to skip outbound processing in after_loose() */ +#define RR_LR_MODE_SKIP_OUTBOUND 2 + /*! should request's from-tag is appended to record-route */ extern int append_fromtag; /*! insert two record-route header instead of one */

1 0

git:master:72699b5d: core: added $defv(name) variable
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 72699b5d85bc1ca8b487749798ed8e93622d1686 URL: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T19:42:24+02:00 core: added $defv(name) variable - return the unquoted value of the define 'name' - unquotes in both cases of single and double quotes - if no quotes enclose the defined value, then the value is returned as it is --- Modified: src/core/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… Patch: https://github.com/kamailio/kamailio/commit/72699b5d85bc1ca8b487749798ed8e9… --- diff --git a/src/core/pv_core.c b/src/core/pv_core.c index 87bf4cc91d3..f577c4ba3a9 100644 --- a/src/core/pv_core.c +++ b/src/core/pv_core.c @@ -28,6 +28,7 @@ #include "pv_core.h" #include "pvar.h" +#include "pvapi.h" #include "ppcfg.h" #include "str.h" #include "mem/pkg.h" @@ -168,6 +169,49 @@ static int pv_get_defn(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } +static int pv_parse_defv_name(pv_spec_p sp, str *in) +{ + if(in == NULL || in->s == NULL || sp == NULL) { + LM_ERR("INVALID DEF NAME\n"); + return -1; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = AVP_NAME_STR; + sp->pvp.pvn.u.isname.name.s = *in; + return 0; +} + +static int pv_get_defv(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + str *val = NULL; + str ret = STR_NULL; + + val = pp_define_get( + param->pvn.u.isname.name.s.len, param->pvn.u.isname.name.s.s); + + if(!val) { + return pv_get_null(msg, param, res); + } + + if(val->len < 2) { + return pv_get_strval(msg, param, res, val); + } + if((val->s[0] == '"' && val->s[val->len - 1] == '"') + || (val->s[0] == '\'' && val->s[val->len - 1] == '\'')) { + ret.s = pv_get_buffer(); + ret.len = pv_get_buffer_size(); + if(ret.len < val->len) { + return pv_get_null(msg, param, res); + } + memcpy(ret.s, val->s + 1, val->len - 2); + ret.len = val->len - 2; + ret.s[ret.len] = '\0'; + return pv_get_strval(msg, param, res, &ret); + } else { + return pv_get_strval(msg, param, res, val); + } +} + /* clang-format off */ /** * @@ -185,6 +229,8 @@ static pv_export_t core_pvs[] = { 0, 0}, {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, 0, 0, 0}, + {STR_STATIC_INIT("defv"), PVT_OTHER, pv_get_defv, 0, pv_parse_defv_name, + 0, 0, 0}, {{0, 0}, 0, 0, 0, 0, 0, 0, 0} };

1 0

git:master:076d9549: core: reformat structure with core pv exports
by Daniel-Constantin Mierla 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: 076d9549a28295392c9a8ca0ce079f2a59ed4f1e URL: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-17T19:23:13+02:00 core: reformat structure with core pv exports --- Modified: src/core/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… Patch: https://github.com/kamailio/kamailio/commit/076d9549a28295392c9a8ca0ce079f2… --- diff --git a/src/core/pv_core.c b/src/core/pv_core.c index c889f7572b7..87bf4cc91d3 100644 --- a/src/core/pv_core.c +++ b/src/core/pv_core.c @@ -168,24 +168,27 @@ static int pv_get_defn(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } +/* clang-format off */ /** * */ static pv_export_t core_pvs[] = { - /* return code, various synonims */ - {STR_STATIC_INIT("?"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("rc"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("retcode"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, - {STR_STATIC_INIT("env"), PVT_OTHER, pv_get_env, 0, pv_parse_env_name, 0, - 0, 0}, - {STR_STATIC_INIT("envn"), PVT_OTHER, pv_get_envn, 0, pv_parse_envn_name, - 0, 0, 0}, - {STR_STATIC_INIT("def"), PVT_OTHER, pv_get_def, 0, pv_parse_def_name, 0, - 0, 0}, - {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, - 0, 0, 0}, - - {{0, 0}, 0, 0, 0, 0, 0, 0, 0}}; + /* return code, various synonims */ + {STR_STATIC_INIT("?"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("rc"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("retcode"), PVT_OTHER, pv_get_retcode, 0, 0, 0, 0, 0}, + {STR_STATIC_INIT("env"), PVT_OTHER, pv_get_env, 0, pv_parse_env_name, 0, + 0, 0}, + {STR_STATIC_INIT("envn"), PVT_OTHER, pv_get_envn, 0, pv_parse_envn_name, + 0, 0, 0}, + {STR_STATIC_INIT("def"), PVT_OTHER, pv_get_def, 0, pv_parse_def_name, 0, + 0, 0}, + {STR_STATIC_INIT("defn"), PVT_OTHER, pv_get_defn, 0, pv_parse_defn_name, + 0, 0, 0}, + + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; +/* clang-format on */ /** * register built-in core pvars.

1 0

[kamailio/kamailio] Segfault when using kamailio 5.8.4 as a presence proxy (Issue #4102)
by Joe Mordica 17 Jun '25

17 Jun '25

### Description We are now using kamailio on the edge as a presence proxy to scale presence. We have 3 internal kamailio instances handling the actual subscriptions and publishing. This works well, however, once per 24-36hours we experience a crash on the border proxy instance. We did not experience this when using the border proxy as a presence server (there was no proxying SUBSCRIBE). ### Troubleshooting #### Reproduction I believe this is happening when a customers network randomly experiences issues where it doesn't receive our replies to subscribes (and continues to send a subscribe). Logs are below. #### Debugging Data  Here's the output while replacing any sensitive info in the payload. ``` GNU gdb (Debian 13.1-3) 13.1 Copyright (C) 2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <https://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/.build-id/ce/c19d0ed1a928e4e25a84ae20d77e9c904a4892.debug... warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing [New LWP 26] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `kamailio -DD -E -m 8000 -M 512 -f /etc/kamailio/kamailio.cfg -P /var/run/kamail'. Program terminated with signal SIGSEGV, Segmentation fault. #0 via_builder (len=len@entry=0x7ffed7e3ecb8, msg=msg@entry=0x7ff9529548b0, send_info=send_info@entry=0x7ff764d20bb0, branch=branch@entry=0x7ffed7e3ecc0, extra_params=0x0, hp=hp@entry=0x7ffed7e3ebb0) at core/msg_translator.c:2910 2910 core/msg_translator.c: No such file or directory. (gdb) bt full #0 via_builder (len=len@entry=0x7ffed7e3ecb8, msg=msg@entry=0x7ff9529548b0, send_info=send_info@entry=0x7ff764d20bb0, branch=branch@entry=0x7ffed7e3ecc0, extra_params=0x0, hp=hp@entry=0x7ffed7e3ebb0) at core/msg_translator.c:2910 via_len = <optimized out> extra_len = <optimized out> line_buf = <optimized out> max_len = <optimized out> via_prefix_len = <optimized out> address_str = <optimized out> port_str = 0x0 send_sock = 0x0 comp_len = <optimized out> comp_name_len = <optimized out> port = <optimized out> proto = <optimized out> ip = {af = 536870912, len = 0, u = {addrl = {534820896, 1586192}, addr32 = {534820896, 0, 1586192, 0}, addr16 = {47136, 8160, 0, 0, 13328, 24, 0, 0}, addr = " \270\340\037\000\000\000\000\0204\030\000\000\000\000"}} from = 0x0 local_addr = {s = {sa_family = 16, sa_data = "#\000\000\000\000\000\020\000\000\000\000\000\000"}, sin = {sin_family = 16, sin_port = 35, sin_addr = {s_addr = 0}, sin_zero = "\020\000\000\000\000\000\000"}, sin6 = {sin6_family = 16, sin6_port = 35, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = "\020\000\000\000\000\000\000\000\003\000\000\000\000\000\000", __u6_addr16 = {16, 0, 0, 0, 3, 0, 0, 0}, __u6_addr32 = {16, 0, 3, 0}}}, sin6_scope_id = 3000082688}, sas = {ss_family = 16, __ss_padding = "#\000\000\000\000\000\020\000\000\000\000\000\000\000\003\000\000\000\000\000\000\000\000\241\321\262cg\357`@\000\000\000\000\000\000\000X\f-\177!V\000\000\020\016\217R\371\177\000\000\001\000\000\000!V\000\000*\000\000\000\000\000\000\000\001\000\000\000\376\177\000\000\004\360;\177!V\000\000\250,A\177!V\000\000\000\355\343\327\376\177\000\000\000\241\321\262cg\357`h\256\006R\371\177\000", __ss_align = 94701866020241}} con = 0x0 rxavp = 0x0 xname = {s = 0x0, len = -2141140176} __func__ = "via_builder" #1 0x000056217f155030 in create_via_hf (len=len@entry=0x7ffed7e3ecb8, msg=msg@entry=0x7ff9529548b0, send_info=send_info@entry=0x7ff764d20bb0, branch=branch@entry=0x7ffed7e3ecc0) at core/msg_translator.c:3232 via = <optimized out> extra_params = {s = 0x0, len = 0} hp = {host = 0x56217f4fb380 <default_global_address>, port = 0x56217f4fb370 <default_global_port>} sbuf = "\331\023\000\000\001", '\000' <repeats 18 times> --Type <RET> for more, q to quit, c to continue without paging--info locals slen = <optimized out> xparams = <optimized out> id_buf = <optimized out> id_len = 0 __func__ = "create_via_hf" __llevel = <optimized out> __kld = <optimized out> #2 0x000056217f1592f7 in build_req_buf_from_sip_req (msg=msg@entry=0x7ff9529548b0, returned_len=returned_len@entry=0x7ffed7e3eeac, send_info=send_info@entry=0x7ff764d20bb0, mode=mode@entry=128) at core/msg_translator.c:2096 len = 581 new_len = <optimized out> received_len = 0 rport_len = 0 uri_len = 0 via_len = 0 body_delta = 0 line_buf = 0x0 received_buf = 0x0 rport_buf = 0x0 new_buf = 0x0 buf = 0x56217f5866c0 <buf> "SUBSCRIBE sip:74@sip.domain.co SIP/2.0\r\nVia: SIP/2.0/UDP 12.171.207.82:25744;branch=z9hG4bK1805670803;rport\r\nFrom: \"Heather Myers\" <sip:1086448@sip.domain.co>;tag=1805518213\r\nTo: <sip:74@sip.domain.co>\r\nCa"... path_buf = {s = 0x0, len = 0} offset = 0 s_offset = 0 size = <optimized out> via_anchor = 0x7ff952951300 via_lump = <optimized out> via_rm = <optimized out> via_insert_param = 0x0 path_anchor = <optimized out> path_lump = <optimized out> branch = {s = 0x7ff952954ed8 "z9hG4bKc7ed.5819b4295fe83f981a2fc19b7f739d7e.0", len = 46} flags = 262273 --Type <RET> for more, q to quit, c to continue without paging--list udp_mtu = <optimized out> di = {send_sock = 0x0, to = {s = {sa_family = 18608, sa_data = "\225R\371\177\000\000\002\000\023\331\n4\001\r"}, sin = {sin_family = 18608, sin_port = 21141, sin_addr = { s_addr = 32761}, sin_zero = "\002\000\023\331\n4\001\r"}, sin6 = {sin6_family = 18608, sin6_port = 21141, sin6_flowinfo = 32761, sin6_addr = {__in6_u = { __u6_addr8 = "\002\000\023\331\n4\001\r\000\000\000\000\000\000\000", __u6_addr16 = {2, 55571, 13322, 3329, 0, 0, 0, 0}, __u6_addr32 = {3641901058, 218182666, 0, 0}}}, sin6_scope_id = 0}, sas = {ss_family = 18608, __ss_padding = "\225R\371\177\000\000\002\000\023\331\n4\001\r", '\000' <repeats 103 times>, __ss_align = 0}}, id = 0, send_flags = {f = 0, blst_imask = 0}, proto = 0 '\000', proto_pad0 = 0 '\000', proto_pad1 = 0} ret = <optimized out> __func__ = "build_req_buf_from_sip_req" error00 = <optimized out> #3 0x00007ff951fbe90d in prepare_new_uac (t=t@entry=0x7ff764d20880, i_req=i_req@entry=0x7ff9529548b0, branch=branch@entry=0, uri=<optimized out>, uri@entry=0x7ff9529548e8, path=<optimized out>, path@entry=0x7ff952954f60, next_hop=<optimized out>, fsocket=0x7ff9528f0e10, snd_flags=..., fproto=<optimized out>, flags=<optimized out>, instance=<optimized out>, ruid=<optimized out>, location_ua=<optimized out>) at ./src/modules/tm/t_fwd.c:482 shbuf = 0x0 add_rm_backup = <optimized out> body_lumps_backup = <optimized out> parsed_uri_bak = {user = { s = 0x56217f5866ce <buf+14> "74(a)sip.domain.co SIP/2.0\r\nVia: SIP/2.0/UDP 12.171.207.82:25744;branch=z9hG4bK1805670803;rport\r\nFrom: \"Heather Myers\" <sip:1086448@sip.domain.co>;tag=1805518213\r\nTo: <sip:74@sip.domain.co>\r\nCall-ID: 0_18056"..., len = 2}, passwd = {s = 0x0, len = 0}, host = { s = 0x56217f5866d1 <buf+17> "sip.domain.co SIP/2.0\r\nVia: SIP/2.0/UDP 12.171.207.82:25744;branch=z9hG4bK1805670803;rport\r\nFrom: \"Heather Myers\" <sip:1086448@sip.domain.co>;tag=1805518213\r\nTo: <sip:74@sip.domain.co>\r\nCall-ID: 0_18056078"..., len = 11}, port = {s = 0x0, len = 0}, params = {s = 0x0, len = 0}, sip_params = {s = 0x0, len = 0}, headers = { s = 0x0, len = 0}, port_no = 0, proto = 0, type = SIP_URI_T, flags = 0, transport = {s = 0x0, len = 0}, ttl = {s = 0x0, len = 0}, user_param = {s = 0x0, len = 0}, maddr = { s = 0x0, len = 0}, method = {s = 0x0, len = 0}, lr = {s = 0x0, len = 0}, r2 = {s = 0x0, len = 0}, gr = {s = 0x0, len = 0}, transport_val = {s = 0x0, len = 0}, ttl_val = { s = 0x0, len = 0}, user_param_val = {s = 0x0, len = 0}, maddr_val = {s = 0x0, len = 0}, method_val = {s = 0x0, len = 0}, lr_val = {s = 0x0, len = 0}, r2_val = {s = 0x0, len = 0}, gr_val = {s = 0x0, len = 0}} ret = -1 len = 32761 parsed_uri_ok_bak = <optimized out> free_new_uri = 1 msg_uri_bak = {s = 0x0, len = 0} dst_uri_bak = {s = 0x7ff9529525f0 "sip:10.52.1.13:5081", len = 19} dst_uri_backed_up = 1 path_bak = {s = 0x0, len = 0} free_path = 1 instance_bak = {s = 0x0, len = 0} ``` #### Log Messages  ``` ERROR 2025-01-10T06:00:31.847348563Z [resource.labels.containerName: kamailio] 8(28) CRITICAL: {1 1 SUBSCRIBE 0_1907143137(a)192.168.100.28} tm [timer.h:188]: _set_fr_retr(): already added: 0x7ff763e62250 , tl=0x7ff763e62270!!! ERROR 2025-01-10T06:00:31.847388483Z [resource.labels.containerName: kamailio] 8(28) CRITICAL: {1 1 SUBSCRIBE 0_1907143137(a)192.168.100.28} tm [t_fwd.c:1613]: t_send_branch(): BUG: retransmission already started for: 0x7ff763e62250 ERROR 2025-01-10T06:00:31.847394809Z [resource.labels.containerName: kamailio] 8(28) ERROR: {1 1 SUBSCRIBE 0_1907143137(a)192.168.100.28} sl [sl_funcs.c:428]: sl_reply_error(): stateless error reply used: No error (0/SL) ERROR 2025-01-10T06:00:31.847400738Z [resource.labels.containerName: kamailio] 8(28) BUG: {1 1 SUBSCRIBE 0_1907143137(a)192.168.100.28} tm [t_lookup.c:2052]: t_unref(): REQ_ERR DELAYED should have been caught much earlier for 0x7ff763e61f70: 24 (hex 18) ERROR 2025-01-10T06:00:47.346744773Z [resource.labels.containerName: kamailio] 45(65) ERROR: <core> [core/tcp_main.c:4818]: tcpconn_main_timeout(): connect 64.63.142.90:12190 failed (timeout) ERROR 2025-01-10T06:00:58.274915089Z [resource.labels.containerName: kamailio] 45(65) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 20 ERROR 2025-01-10T06:01:02.715789076Z [resource.labels.containerName: kamailio] 0(1) ALERT: <core> [main.c:805]: handle_sigs(): child process 26 exited by a signal 11 ERROR 2025-01-10T06:01:02.715827333Z [resource.labels.containerName: kamailio] 0(1) ALERT: <core> [main.c:809]: handle_sigs(): core was generated ERROR 2025-01-10T06:01:02.718815287Z [resource.labels.containerName: kamailio] 45(65) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 25 ERROR 2025-01-10T06:01:02.720985493Z [resource.labels.containerName: kamailio] 45(65) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 23 ERROR 2025-01-10T06:01:02.725450552Z [resource.labels.containerName: kamailio] 45(65) CRITICAL: <core> [core/pass_fd.c:281]: receive_fd(): EOF on 30 ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions I can atleast say that when this segfault happens that these logs are always present right before the crash. However, I also see instances of these logs without a crash immediately following. On the proxy we are doing this is withindlg route to send subscribes to the presence route: ``` if KSR.is_SUBSCRIBE() and KSR.is_myself_ruri() then -- in-dialog subscribe requests ksr_route_presence(); KSR.x.exit(); end ``` Any then this is our ksr_route_presence(): ``` function ksr_route_presence() if not KSR.is_SUBSCRIBE() then return 1; end local fuser = KSR.kx.get_fuser(); if fuser=='' then KSR.xlog.xinfo('Subscription attempt without username from IP ' .. KSR.kx.get_srcip() .. ' - Rejecting\n'); KSR.sl.sl_send_reply(404, 'Not Found'); KSR.x.exit(); end KSR.pv.sets('$avp(s:tenant)', string.match(fuser, '-(.*)')); local setId = '6' .. KSR.kx.get_def('DEFAULT_DISPATCH_SET'); local modeId = '7'; if KSR.dispatcher.ds_select_dst(setId, modeId)<0 then KSR.sl.send_reply(404, 'No destination'); KSR.x.exit(); end KSR.corex.set_send_socket(KSR.kx.get_def('PRIVATE_LISTEN_IP') .. ':' .. KSR.kx.get_def('INTERNAL_PORT')); KSR.tm.t_on_failure('ksr_route_rtf_dispatch'); ksr_route_relay(); end ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**:  ``` PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" ``` ``` Linux gke-us-south1-external-sip-800ca69e-qyb3 5.15.0-1048-gke #53-Ubuntu SMP Tue Nov 28 00:39:01 UTC 2023 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4102 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4102(a)github.com>

5 34

[kamailio/kamailio] [outbound] use_outbound_register logs empty Contact for unREGISTER with `Contact: *` (Issue #4242)
by George Diamantopoulos 17 Jun '25

17 Jun '25

gedia created an issue (kamailio/kamailio#4242)  ### Description This is definitely not high priority, just a nuisance when auditing logs for actionable events. The following is logged (see Log Messages section below) on edge proxies when the outbound module is loaded and the REGISTER contains: ``` Contact: * Expires: 0 ``` AFAIK this is legit when a UAC asks that all their contacts be removed from the location database. ### Troubleshooting #### Reproduction Force a UAC to send an unREGISTER towards an outbound-capable kamailio edge proxy. #### Log Messages ``` outbound [outbound_mod.c:325]: use_outbound_register(): empty Contact: ``` #### SIP Traffic  See description ### Possible Solutions  I'm not sure what the best approach would be here, but I'm thinking one of the following: * Either handle this case gracefully (contact is * in REGISTER with Expires=0), without logging anything, unless there's some misbehaviour here by the UAC I'm not aware of regarding outbound and unREGISTER behaviour * Or, log this in a more verbose level (e.g. debug), when contact parsing fails due to it being set to '*' ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**:  ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye Linux lbpub0-tis0-cn1 5.10.0-21-amd64 #1 SMP Debian 5.10.162-1 (2023-01-21) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4242 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4242(a)github.com>

3 4

[kamailio/kamailio] outbound: Use outbound if Register contains Contacts:* and Expires:0 (PR #4279)
by Xenofon Karamanos 17 Jun '25

17 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4242 #### Description  This PR fixes the invalid case of empy Contact. Contact:* and expires:0 is valid and should be handled accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4279 -- Commit Summary -- * outbound: Use outbound if Register contains Contacts:* and Expires:0 -- File Changes -- M src/modules/outbound/outbound_mod.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4279.patch https://github.com/kamailio/kamailio/pull/4279.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4279 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4279(a)github.com>

3 2

git:master:b4516591: outbound: Use outbound if Register contains Contacts:* and Expires:0
by Henning Westerholt 17 Jun '25

17 Jun '25

Module: kamailio Branch: master Commit: b45165919ea2ab0f361a6e0a94c71e10739cd573 URL: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-17T09:09:49+02:00 outbound: Use outbound if Register contains Contacts:* and Expires:0 --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… Patch: https://github.com/kamailio/kamailio/commit/b45165919ea2ab0f361a6e0a94c71e1… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index a5f17e4ef99..1524b9b4417 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -38,6 +38,7 @@ #include "../../core/sr_module.h" #include "../../core/counters.h" #include "../../core/parser/contact/parse_contact.h" +#include "../../core/parser/parse_expires.h" #include "../../core/parser/parse_rr.h" #include "../../core/parser/parse_uri.h" #include "../../core/parser/parse_supported.h" @@ -324,6 +325,14 @@ static int use_outbound_register(struct sip_msg *msg) LM_ERR("parsing Contact: header body\n"); return 0; } + + if(((contact_body_t *)msg->contact->parsed)->star + && ((exp_body_t *)msg->expires->parsed)->val == 0) { + LM_DBG("found REGISTER with * in Contact: header body and Expires " + ": 0 - outbound used\n"); + return 1; + } + contact = ((contact_body_t *)msg->contact->parsed)->contacts; if(!contact) { LM_ERR("empty Contact:\n");

1 0

[kamailio/kamailio] dispatcher: ds_is_from_list() with mode flag 16 provides only exact matches (Issue #4236)
by Gianluca Merlo 16 Jun '25

16 Jun '25

giangi created an issue (kamailio/kamailio#4236) ### Description The mode flag value 16 (int) in `ds_is_from_list()` is supposed to provide a "best matching" candidate, however it does not seem to recognize anything other than exact matches. ### Troubleshooting #### Reproduction With the following `dispatcher.list` ``` # setid(int) destination(sip uri) flags(int,opt) priority(int,opt) attributes(str,opt) 1 sip:127.1.2.3:5060 1 sip:127.1.2.3:5060;transport=tcp ``` The following invocations result in a match ``` ds_is_from_list("-1", "16", "sip:127.1.2.3:5060"); ds_is_from_list("-1", "16", "sip:127.1.2.3:5060;transport=tcp"); ``` while others, e.g. some with some mismatching ports, but a valid address, fail to match ``` ds_is_from_list("-1", "16", "sip:127.1.2.3:12345"); ds_is_from_list("-1", "16", "sip:127.1.2.3:12345;transport=tcp"); ``` ### Possible Solutions The code of `ds_is_addr_from_set()` from `src/modules/dispatcher/dispatch.c` has some suspicious `continue` while evaluating the "strictness score" of nodes and deciding upon the best match. If I am not mistaken they may cause the code that updates the `ds_strictest_node` to never get executed, thus not providing any match at all. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: Debian 12 "bookworm" -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4236 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4236(a)github.com>

2 3

[kamailio/kamailio] execution in event_route takes too much time (Issue #4285)
by Sergii 16 Jun '25

16 Jun '25

Serg1289 created an issue (kamailio/kamailio#4285) In case of event below, script execution takes too much time (40 sec): _event_route[dispatcher:dst-down] { exec_msg("/bin/bash -c '/usr/local/etc/kamailio/ipassign.sh &'"); }_ In case I run this script from shell it takes ~2 sec. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4285 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4285(a)github.com>

2 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev