- sr-dev - kamailio.org

git:master:3202dc9d: rtpengine: Add check for skipping pings on manually disabled nodes.
by Xenofon Karamanos 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: 3202dc9d8e26620fe642e474e5cf8632ab6bc3a7 URL: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2025-06-10T12:28:01+03:00 rtpengine: Add check for skipping pings on manually disabled nodes. - Add debug log when trying to ping a node. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… Patch: https://github.com/kamailio/kamailio/commit/3202dc9d8e26620fe642e474e5cf863… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 828eca4e7a2..f813bd45579 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1955,6 +1955,7 @@ static int rtpp_test_ping(struct rtpp_node *node) char *cp; int ret; + LM_DBG("Sending ping to node %.*s\n", node->rn_url.len, node->rn_url.s); if(bencode_buffer_init(&bencbuf)) { return -1; } @@ -4078,7 +4079,7 @@ static void rtpengine_ping_check_timer(unsigned int ticks, void *param) for(crt_rtpp = rtpp_list->rn_first; crt_rtpp != NULL; crt_rtpp = crt_rtpp->rn_next) { - if(!crt_rtpp->rn_displayed) { + if(!crt_rtpp->rn_displayed || crt_rtpp->rn_disabled) { continue; }

1 0

[kamailio/kamailio] presence: preserve etag uniqueness when marking presentity for removal (PR #4275)
by Alessio Garzi 10 Jun '25

10 Jun '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #### Description When the `presence` module attempts to clean up records in the `presentity` table, it replaces the `etag` with a static, hardcoded string: ``` "*#-OFFLINE-#*" ``` However, the `presentity` table enforces a uniqueness constraint on the following combination of fields: ``` MariaDB [kamailio]> show create table presentity; | presentity | CREATE TABLE `presentity` ( ... UNIQUE KEY `presentity_idx` (`username`,`domain`,`event`,`etag`), ``` This approach breaks the uniqueness of etag, which is intended to differentiate records , especially in cases such as parallel calls, or when using kamailio as a forking proxy. Instead of overwriting the etag with the static offline marker, this patch appends the marker to the existing etag value. This ensures the offline flag is retained while preserving the uniqueness of the etag. The deletion query was also updated accordingly: it now identifies offline records using a LIKE '%*#-OFFLINE-#*' clause. Based on testing, the duplicate key errors no longer occur, and the cleanup logic now behaves as expected. This patch improves the reliability of presentity cleanup without requiring schema or index changes. Please consider merging into master. Thanks! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4275 -- Commit Summary -- * presence: preserve etag uniqueness when marking presentity for removal -- File Changes -- M src/modules/presence/presentity.c (90) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4275.patch https://github.com/kamailio/kamailio/pull/4275.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4275 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4275(a)github.com>

3 10

git:master:cdcb570e: core: sdp - check if space is found for extracting session version
by Daniel-Constantin Mierla 10 Jun '25

10 Jun '25

Module: kamailio Branch: master Commit: cdcb570e46101703f4963863c705345c7a3420ac URL: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-10T08:21:44+02:00 core: sdp - check if space is found for extracting session version --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… Patch: https://github.com/kamailio/kamailio/commit/cdcb570e46101703f4963863c705345… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 0d18d787242..60613ff8264 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -734,7 +734,7 @@ int extract_sess_version(str *oline, str *sess_version) i++; } while((cp < oline->s + oline->len) && i < 3); - if(cp >= oline->s + oline->len) { + if(cp == NULL || cp0 == NULL || cp >= oline->s + oline->len) { LM_ERR("broken o= line - version field not found\n"); return -1; }

1 0

git:master:418a1017: core: destroy the x/avp lists on msg env data pop
by Daniel-Constantin Mierla 09 Jun '25

09 Jun '25

Module: kamailio Branch: master Commit: 418a1017a58e87a9fe9085f75183bcbfba3f9022 URL: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-09T08:45:31+02:00 core: destroy the x/avp lists on msg env data pop --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… Patch: https://github.com/kamailio/kamailio/commit/418a1017a58e87a9fe9085f75183bcb… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 31eb2808835..3be80b4d075 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -79,6 +79,27 @@ sr_cfgenv_t *sr_cfgenv_get(void) static ksr_msg_env_data_t _ksr_msg_env_stack[KSR_MSG_ENV_STACK_SIZE]; static int _ksr_msg_env_stack_idx = 0; +/** + * + */ +int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv) +{ + if(denv == NULL) { + return -1; + } + destroy_avp_list(&denv->avps_uri_from); + destroy_avp_list(&denv->avps_uri_to); + destroy_avp_list(&denv->avps_user_from); + destroy_avp_list(&denv->avps_user_to); + destroy_avp_list(&denv->avps_domain_from); + destroy_avp_list(&denv->avps_domain_to); + xavp_destroy_list(&denv->xavps); + xavp_destroy_list(&denv->xavus); + xavp_destroy_list(&denv->xavis); + + return 0; +} + /** * */ @@ -127,8 +148,8 @@ int ksr_msg_env_pop(ksr_msg_env_links_t *menv) return -1; } - /* current msg x/avp lists are expected to be cleaned up - * - just replace and pop */ + ksr_msg_env_data_destroy(&_ksr_msg_env_stack[_ksr_msg_env_stack_idx - 1]); + set_route_type(menv->route_type); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); diff --git a/src/core/srapi.h b/src/core/srapi.h index d4c64c1976a..0a1593fe93a 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -71,5 +71,6 @@ typedef struct ksr_msg_env_links int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); +int ksr_msg_env_data_destroy(ksr_msg_env_data_t *denv); #endif

1 0

git:master:10c6f973: sipdump: use the msg env data stack
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: 10c6f973b0f2334c6b2790d61efa1fc3ac282a01 URL: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 sipdump: use the msg env data stack --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… Patch: https://github.com/kamailio/kamailio/commit/10c6f973b0f2334c6b2790d61efa1fc… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index e199d1cefc9..6dd3af751af 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -293,7 +293,7 @@ int sipdump_event_route(sipdump_data_t *sdi) sr_kemi_eng_t *keng = NULL; str evname = str_init("sipdump:msg"); sip_msg_t *fmsg = NULL; - ksr_msg_env_t menv = {0}; + ksr_msg_env_links_t menv = {0}; ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE);

1 0

git:master:f3a6f2ed: siptrace: use the msg env data stack
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: f3a6f2ed539a4a0f287ba0bfee89bd44d2f1a781 URL: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 siptrace: use the msg env data stack --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… Patch: https://github.com/kamailio/kamailio/commit/f3a6f2ed539a4a0f287ba0bfee89bd4… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 3c27e20fe87..79d1756a979 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2227,7 +2227,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) sr_kemi_eng_t *keng = NULL; str evname = str_init("siptrace:msg"); sip_msg_t msg; - ksr_msg_env_t menv = {0}; + ksr_msg_env_links_t menv = {0}; if(_siptrace_evrt_msg_idx < 0 && _siptrace_evcb_msg.len <= 0) { return 0;

1 0

git:master:c10c1d7f: core: keep a stack of msg env data
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: c10c1d7f0214105c01a300b4a69c58219e4c970a URL: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 core: keep a stack of msg env data - GH #4258 --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… Patch: https://github.com/kamailio/kamailio/commit/c10c1d7f0214105c01a300b4a69c582… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index a16acf97d21..31eb2808835 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -75,29 +75,60 @@ sr_cfgenv_t *sr_cfgenv_get(void) /** * */ -void ksr_msg_env_push(ksr_msg_env_t *menv) +#define KSR_MSG_ENV_STACK_SIZE 8 +static ksr_msg_env_data_t _ksr_msg_env_stack[KSR_MSG_ENV_STACK_SIZE]; +static int _ksr_msg_env_stack_idx = 0; + +/** + * + */ +int ksr_msg_env_push(ksr_msg_env_links_t *oenv) { - menv->route_type = get_route_type(); - - menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); - menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); - menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); - menv->avps_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, NULL); - menv->avps_domain_from = - set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, NULL); - menv->avps_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, NULL); - menv->xavps = xavp_set_list(NULL); - menv->xavus = xavu_set_list(NULL); - menv->xavis = xavi_set_list(NULL); - - return; + ksr_msg_env_data_t *senv = NULL; + + if(_ksr_msg_env_stack_idx >= KSR_MSG_ENV_STACK_SIZE) { + LM_ERR("msg env stack size exceeded\n"); + return -1; + } + senv = &_ksr_msg_env_stack[_ksr_msg_env_stack_idx]; + memset(&_ksr_msg_env_stack[_ksr_msg_env_stack_idx], 0, + sizeof(ksr_msg_env_data_t)); + + oenv->route_type = get_route_type(); + + oenv->avps_uri_from = + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &senv->avps_uri_from); + oenv->avps_uri_to = + set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &senv->avps_uri_to); + oenv->avps_user_from = set_avp_list( + AVP_TRACK_FROM | AVP_CLASS_USER, &senv->avps_user_from); + oenv->avps_user_to = + set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, &senv->avps_user_to); + oenv->avps_domain_from = set_avp_list( + AVP_TRACK_FROM | AVP_CLASS_DOMAIN, &senv->avps_domain_from); + oenv->avps_domain_to = set_avp_list( + AVP_TRACK_TO | AVP_CLASS_DOMAIN, &senv->avps_domain_to); + oenv->xavps = xavp_set_list(&senv->xavps); + oenv->xavus = xavu_set_list(&senv->xavus); + oenv->xavis = xavi_set_list(&senv->xavis); + + _ksr_msg_env_stack_idx++; + + return 0; } /** * */ -void ksr_msg_env_pop(ksr_msg_env_t *menv) +int ksr_msg_env_pop(ksr_msg_env_links_t *menv) { + if(_ksr_msg_env_stack_idx <= 0) { + LM_ERR("invalid msg env stack index\n"); + return -1; + } + + /* current msg x/avp lists are expected to be cleaned up + * - just replace and pop */ set_route_type(menv->route_type); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); @@ -110,5 +141,7 @@ void ksr_msg_env_pop(ksr_msg_env_t *menv) xavu_set_list(menv->xavus); xavi_set_list(menv->xavis); - return; + _ksr_msg_env_stack_idx--; + + return 0; } diff --git a/src/core/srapi.h b/src/core/srapi.h index b573493a62b..d4c64c1976a 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -41,7 +41,21 @@ typedef struct sr_cfgenv void sr_cfgenv_init(void); sr_cfgenv_t *sr_cfgenv_get(void); -typedef struct ksr_msg_env +typedef struct ksr_msg_env_data +{ + int route_type; + avp_list_t avps_user_from; + avp_list_t avps_user_to; + avp_list_t avps_domain_from; + avp_list_t avps_domain_to; + avp_list_t avps_uri_from; + avp_list_t avps_uri_to; + sr_xavp_t *xavps; + sr_xavp_t *xavus; + sr_xavp_t *xavis; +} ksr_msg_env_data_t; + +typedef struct ksr_msg_env_links { int route_type; avp_list_t *avps_user_from; @@ -53,9 +67,9 @@ typedef struct ksr_msg_env sr_xavp_t **xavps; sr_xavp_t **xavus; sr_xavp_t **xavis; -} ksr_msg_env_t; +} ksr_msg_env_links_t; -void ksr_msg_env_push(ksr_msg_env_t *menv); -void ksr_msg_env_pop(ksr_msg_env_t *menv); +int ksr_msg_env_links_push(ksr_msg_env_links_t *menv); +int ksr_msg_env_links_pop(ksr_msg_env_links_t *menv); #endif

1 0

git:master:3379d66b: uac: added ftag and ttag fields for $uac_req(...)
by Daniel-Constantin Mierla 08 Jun '25

08 Jun '25

Module: kamailio Branch: master Commit: 3379d66b082ed866235d354c96171b964fd2d708 URL: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-08T12:10:30+02:00 uac: added ftag and ttag fields for $uac_req(...) --- Modified: src/modules/uac/uac_send.c --- Diff: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… Patch: https://github.com/kamailio/kamailio/commit/3379d66b082ed866235d354c96171b9… --- diff --git a/src/modules/uac/uac_send.c b/src/modules/uac/uac_send.c index ea3595ca755..2513a6989d0 100644 --- a/src/modules/uac/uac_send.c +++ b/src/modules/uac/uac_send.c @@ -63,8 +63,12 @@ typedef struct _uac_send_info str s_ruri; char b_turi[MAX_URI_SIZE]; str s_turi; + char b_ttag[128]; + str s_ttag; char b_furi[MAX_URI_SIZE]; str s_furi; + char b_ftag[128]; + str s_ftag; char b_callid[128]; str s_callid; char b_hdrs[MAX_UACH_SIZE]; @@ -99,7 +103,9 @@ void uac_send_info_copy(uac_send_info_t *src, uac_send_info_t *dst) dst->s_method.s = dst->b_method; dst->s_ruri.s = dst->b_ruri; dst->s_turi.s = dst->b_turi; + dst->s_ttag.s = dst->b_ttag; dst->s_furi.s = dst->b_furi; + dst->s_ftag.s = dst->b_ftag; dst->s_hdrs.s = dst->b_hdrs; dst->s_body.s = dst->b_body; dst->s_ouri.s = dst->b_ouri; @@ -193,6 +199,15 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, _uac_req.fr_timeout); case 20: return pv_get_uintval(msg, param, res, _uac_req.fr_inv_timeout); + case 21: + if(_uac_req.s_ftag.len <= 0) + return pv_get_null(msg, param, res); + return pv_get_strval(msg, param, res, &_uac_req.s_ftag); + case 22: + if(_uac_req.s_ttag.len <= 0) + return pv_get_null(msg, param, res); + return pv_get_strval(msg, param, res, &_uac_req.s_ttag); + default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -217,7 +232,9 @@ int pv_set_uac_req( _uac_req.flags = 0; _uac_req.s_ruri.len = 0; _uac_req.s_furi.len = 0; + _uac_req.s_ftag.len = 0; _uac_req.s_turi.len = 0; + _uac_req.s_ttag.len = 0; _uac_req.s_ouri.len = 0; _uac_req.s_hdrs.len = 0; _uac_req.s_body.len = 0; @@ -228,6 +245,8 @@ int pv_set_uac_req( _uac_req.evtype = 0; _uac_req.evcode = 0; _uac_req.cseqno = 0; + _uac_req.fr_timeout = 0; + _uac_req.fr_inv_timeout = 0; _uac_req.s_evparam.len = 0; } break; @@ -512,6 +531,40 @@ int pv_set_uac_req( } _uac_req.fr_inv_timeout = tval->ri; break; + case 21: + if(tval == NULL) { + _uac_req.s_ftag.len = 0; + return 0; + } + if(!(tval->flags & PV_VAL_STR)) { + LM_ERR("Invalid value type\n"); + return -1; + } + if(tval->rs.len >= 128) { + LM_ERR("Value size too big\n"); + return -1; + } + memcpy(_uac_req.s_ftag.s, tval->rs.s, tval->rs.len); + _uac_req.s_ftag.s[tval->rs.len] = '\0'; + _uac_req.s_ftag.len = tval->rs.len; + break; + case 22: + if(tval == NULL) { + _uac_req.s_ttag.len = 0; + return 0; + } + if(!(tval->flags & PV_VAL_STR)) { + LM_ERR("Invalid value type\n"); + return -1; + } + if(tval->rs.len >= 128) { + LM_ERR("Value size too big\n"); + return -1; + } + memcpy(_uac_req.s_ttag.s, tval->rs.s, tval->rs.len); + _uac_req.s_ttag.s[tval->rs.len] = '\0'; + _uac_req.s_ttag.len = tval->rs.len; + break; } return 0; } @@ -533,8 +586,12 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 1; else if(strncmp(in->s, "turi", 4) == 0) sp->pvp.pvn.u.isname.name.n = 2; + else if(strncmp(in->s, "ttag", 4) == 0) + sp->pvp.pvn.u.isname.name.n = 22; else if(strncmp(in->s, "furi", 4) == 0) sp->pvp.pvn.u.isname.name.n = 3; + else if(strncmp(in->s, "ftag", 4) == 0) + sp->pvp.pvn.u.isname.name.n = 21; else if(strncmp(in->s, "hdrs", 4) == 0) sp->pvp.pvn.u.isname.name.n = 4; else if(strncmp(in->s, "body", 4) == 0) @@ -612,7 +669,9 @@ void uac_req_init(void) memset(&_uac_req, 0, sizeof(struct _uac_send_info)); _uac_req.s_ruri.s = _uac_req.b_ruri; _uac_req.s_furi.s = _uac_req.b_furi; + _uac_req.s_ftag.s = _uac_req.b_ftag; _uac_req.s_turi.s = _uac_req.b_turi; + _uac_req.s_ttag.s = _uac_req.b_ttag; _uac_req.s_ouri.s = _uac_req.b_ouri; _uac_req.s_hdrs.s = _uac_req.b_hdrs; _uac_req.s_body.s = _uac_req.b_body;

1 0

[kamailio/kamailio] core: tcp_send_timeout applied for outbound connections (PR #4234)
by sergey-safarov 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4187 #### Description core: tcp_send_timeout applied for outbound connections You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4234 -- Commit Summary -- * core: tcp_send_timeout applied for outbound connections -- File Changes -- M src/core/tcp_main.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4234.patch https://github.com/kamailio/kamailio/pull/4234.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4234 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4234(a)github.com>

3 8

git:master:91053984: core: tcp_send_timeout applied for outbound connections
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9105398413b4f9fab410482d9ebf5d82b6c3fb0a URL: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T16:08:44+02:00 core: tcp_send_timeout applied for outbound connections --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… Patch: https://github.com/kamailio/kamailio/commit/9105398413b4f9fab410482d9ebf5d8… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 604102dcef6..369bfb1f159 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -352,6 +352,17 @@ static int init_sock_opt(int s, int af) } } #endif +#ifdef HAVE_TCP_USER_TIMEOUT + if((optval = TICKS_TO_S(cfg_get(tcp, tcp_cfg, send_timeout)))) { + optval *= 1000; + if(setsockopt(s, IPPROTO_TCP, TCP_USER_TIMEOUT, &optval, sizeof(optval)) + < 0) { + LM_WARN("failed to set TCP_USER_TIMEOUT: %s\n", strerror(errno)); + } else { + LM_DBG("Set TCP_USER_TIMEOUT=%d ms\n", optval); + } + } +#endif #ifdef HAVE_TCP_QUICKACK if(cfg_get(tcp, tcp_cfg, delayed_ack)) { optval = 0; /* reset quick ack => delayed ack */

1 0

git:master:128ccdc6: modules: readme files regenerated - file_out ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 128ccdc6330232fd810bd0a35b325e44d5bdf98d URL: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T15:46:10+02:00 modules: readme files regenerated - file_out ... [skip ci] --- Modified: src/modules/file_out/README --- Diff: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… Patch: https://github.com/kamailio/kamailio/commit/128ccdc6330232fd810bd0a35b325e4… --- diff --git a/src/modules/file_out/README b/src/modules/file_out/README index 89ca58147c1..0fcbf640251 100644 --- a/src/modules/file_out/README +++ b/src/modules/file_out/README @@ -23,6 +23,7 @@ Xenofon Karamanos 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 4. Functions @@ -35,7 +36,8 @@ Xenofon Karamanos 1.1. Set base_folder parameter 1.2. Set file parameter 1.3. Set worker_usleep parameter - 1.4. file_out usage + 1.4. Set timer_interval parameter + 1.5. file_out usage Chapter 1. Admin Guide @@ -52,6 +54,7 @@ Chapter 1. Admin Guide 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 4. Functions @@ -98,6 +101,7 @@ Chapter 1. Admin Guide 3.1. base_folder (string) 3.2. file (string) 3.3. worker_usleep (int) + 3.4. timer_interval (int) 3.1. base_folder (string) @@ -146,6 +150,18 @@ modparam("file_out", "file", "name=accounting;extension=.txt") modparam("file_out", "worker_usleep", "1000") ... +3.4. timer_interval (int) + + The time in seconds which timer will trigger for rotating the files. + Make sure that this value is lower than the interval of the files. + + Default value is “10” (10 s). + + Example 1.4. Set timer_interval parameter +... +modparam("file_out", "timer_interval", "60") +... + 4. Functions 4.1. file_out(filename, string) @@ -157,7 +173,7 @@ modparam("file_out", "worker_usleep", "1000") string to be written to the file. Filename is the name of the file defined in the configuration file as name=filename. - Example 1.4. file_out usage + Example 1.5. file_out usage ... modparam("file_out", "file", "name=accounting;interval=200") modparam("file_out", "file", "name=missed_calls;extension=.json;interval=300")

1 0

[kamailio/kamailio] file_out: Add rotation timer (PR #4263)
by Xenofon Karamanos 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR introduces a new modparam `timer_interval` to denote the frequency where files are checked for rotation. Also some improvements regarding memory managments and defaults options. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4263 -- Commit Summary -- * file_out: Consistent check * file_out: Memory allocation and copy when used. * file_out: Add debug function * file_out: Add file properties init function * file_out: Rotate files based on timer * file_out: Add require_rotation for better file handling * file_out: Fix missing evaluated PVs * file_out/docs: Add timer_interval doc -- File Changes -- M src/modules/file_out/doc/file_out_admin.xml (23) M src/modules/file_out/file_out.c (193) M src/modules/file_out/types.c (79) M src/modules/file_out/types.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4263.patch https://github.com/kamailio/kamailio/pull/4263.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4263 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4263(a)github.com>

3 3

git:master:92484d73: file_out: docs: Add timer_interval doc
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 92484d73b136a95a46e118af6b46b566f5df1875 URL: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: docs: Add timer_interval doc --- Modified: src/modules/file_out/doc/file_out_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… Patch: https://github.com/kamailio/kamailio/commit/92484d73b136a95a46e118af6b46b56… --- diff --git a/src/modules/file_out/doc/file_out_admin.xml b/src/modules/file_out/doc/file_out_admin.xml index ce02069ae83..83b84b6abc6 100644 --- a/src/modules/file_out/doc/file_out_admin.xml +++ b/src/modules/file_out/doc/file_out_admin.xml @@ -190,6 +190,29 @@ modparam("file_out", "worker_usleep", "1000") </example> </section> + <section> + <title> + <varname>timer_interval</varname> (int)</title> + <para> + The time in seconds which timer will trigger for rotating the files. + <emphasis> + Make sure that this value is lower than the interval of the files. + </emphasis> + </para> + <para> + <emphasis> + Default value is <quote>10</quote> (10 s). + </emphasis> + </para> + <example> + <title>Set <varname>timer_interval</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("file_out", "timer_interval", "60") +... + </programlisting> + </example> + </section> </section> <section>

1 0

git:master:9b5ad5d1: file_out: Fix missing evaluated PVs
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 9b5ad5d1d814bc9ba4c41dc02bac4362268ec37f URL: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Fix missing evaluated PVs --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… Patch: https://github.com/kamailio/kamailio/commit/9b5ad5d1d814bc9ba4c41dc02bac436… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index ce43c1f3a32..6ec2a950119 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -548,6 +548,7 @@ static int fo_init_file(const int index) LM_ERR("Couldn't open file %s\n", strerror(errno)); return -1; } + return 1; } @@ -643,12 +644,8 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) return -1; } - fo_prefix_str.s = fo_prefix_buf; - fo_prefix_str.len = buf_size; - if(pv_printf(msg, fo_files[file_index].fo_prefix_pvs, fo_prefix_str.s, - &fo_prefix_str.len) - == 0 - && fo_prefix_str.len > 0) { + if(pv_printf_s(msg, fo_files[file_index].fo_prefix_pvs, &fo_prefix_str) + == 0) { fo_prefix_val.s = fo_prefix_str.s; fo_prefix_val.len = fo_prefix_str.len; }

1 0

git:master:59a23249: file_out: Add require_rotation for better file handling
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 59a23249c9ddf64119d6129123b3c610de66d6f3 URL: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add require_rotation for better file handling --- Modified: src/modules/file_out/file_out.c Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61… Patch: https://github.com/kamailio/kamailio/commit/59a23249c9ddf64119d6129123b3c61…

1 0

git:master:a841fd25: file_out: Rotate files based on timer
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: a841fd2539ed8c13184face4fdf6215a917162cc URL: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Rotate files based on timer --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215… Patch: https://github.com/kamailio/kamailio/commit/a841fd2539ed8c13184face4fdf6215…

1 0

git:master:ca72b648: file_out: Add file properties init function
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: ca72b6487fbed30be4ca83f7864c2ac1a29c647e URL: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add file properties init function --- Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… Patch: https://github.com/kamailio/kamailio/commit/ca72b6487fbed30be4ca83f7864c2ac… --- diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 1b5ffc4c6cb..9c2056ef59e 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -121,6 +121,41 @@ void fo_free_queue(fo_queue_t *q) shm_free(q); } +int fo_file_properties_init(fo_file_properties_t *fp) +{ + if(fp == NULL) { + return -1; + } + + /* Malloc member for each element required */ + fp->fo_base_filename.s = (char *)shm_malloc(FO_MAX_PATH_LEN * sizeof(char)); + if(fp->fo_base_filename.s == NULL) { + LM_ERR("Failed to allocate memory for base filename\n"); + return -1; + } + fp->fo_extension.s = (char *)shm_malloc(10 * sizeof(char)); + if(fp->fo_extension.s == NULL) { + LM_ERR("Failed to allocate memory for extension\n"); + return -1; + } + + fp->fo_prefix.s = (char *)shm_malloc(4096 * sizeof(char)); + if(fp->fo_prefix.s == NULL) { + LM_ERR("Failed to allocate memory for prefix\n"); + return -1; + } + fp->fo_stored_timestamp = time(NULL); + fp->fo_interval_seconds = 0; + + fp->fo_prefix_pvs = (pv_elem_t *)shm_malloc(sizeof(pv_elem_t)); + if(fp->fo_prefix_pvs == NULL) { + LM_ERR("Failed to allocate memory for prefix pvs\n"); + return -1; + } + + return 1; +} + int fo_file_properties_destroy(fo_file_properties_t *fp) { if(fp == NULL) { diff --git a/src/modules/file_out/types.h b/src/modules/file_out/types.h index 940c6f7476b..27d3884ffc9 100644 --- a/src/modules/file_out/types.h +++ b/src/modules/file_out/types.h @@ -27,6 +27,7 @@ #include "../../core/pvar.h" #define FO_MAX_FILES 10 /* Maximum number of files */ +#define FO_MAX_PATH_LEN 2048 typedef struct log_message { @@ -65,6 +66,7 @@ typedef struct fo_file_properties FILE *fo_file_output; } fo_file_properties_t; +int fo_file_properties_init(fo_file_properties_t *fp); int fo_file_properties_destroy(fo_file_properties_t *fp); int fo_file_properties_print(const fo_file_properties_t file_prop);

1 0

git:master:60086f11: file_out: Add debug function
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 60086f1108ac199d4db4453c2c14865e2e16022c URL: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Add debug function --- Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… Patch: https://github.com/kamailio/kamailio/commit/60086f1108ac199d4db4453c2c14865… --- diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 5b9a62112f4..1b5ffc4c6cb 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -140,3 +140,13 @@ int fo_file_properties_destroy(fo_file_properties_t *fp) } return 1; } + +int fo_file_properties_print(const fo_file_properties_t file_prop) +{ + LM_DBG("Base filename: %s\n", file_prop.fo_base_filename.s); + LM_DBG("Prefix: %s\n", file_prop.fo_prefix.s); + LM_DBG("Extension: %s\n", file_prop.fo_extension.s); + LM_DBG("Interval: %d\n", file_prop.fo_interval_seconds); + LM_DBG("Stored timestamp: %ld\n", file_prop.fo_stored_timestamp); + return 1; +} diff --git a/src/modules/file_out/types.h b/src/modules/file_out/types.h index 6140e4ff111..940c6f7476b 100644 --- a/src/modules/file_out/types.h +++ b/src/modules/file_out/types.h @@ -66,5 +66,6 @@ typedef struct fo_file_properties } fo_file_properties_t; int fo_file_properties_destroy(fo_file_properties_t *fp); +int fo_file_properties_print(const fo_file_properties_t file_prop); #endif

1 0

git:master:c4521d05: file_out: Memory allocation and copy when used.
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: c4521d05cb90773e6a50747a4dc1f069617d7843 URL: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Memory allocation and copy when used. --- Modified: src/modules/file_out/file_out.c Modified: src/modules/file_out/types.c --- Diff: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… Patch: https://github.com/kamailio/kamailio/commit/c4521d05cb90773e6a50747a4dc1f06… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 7a275d59022..ecd8298a874 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -589,9 +589,31 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) fo_prefix_val.len = fo_prefix_str.len; } + /* Allocate memory */ + logMessage.prefix = (str *)shm_malloc(sizeof(str)); + if(logMessage.prefix == NULL) { + SHM_MEM_ERROR; + return -1; + } + + logMessage.message = (str *)shm_malloc(sizeof(str)); + if(logMessage.message == NULL) { + SHM_MEM_ERROR; + return -1; + } + + /* Copy the value */ + if(shm_str_dup(logMessage.prefix, &fo_prefix_val) < 0) { + LM_ERR("Failed to copy prefix\n"); + return -1; + } + + if(shm_str_dup(logMessage.message, &value) < 0) { + LM_ERR("Failed to copy message\n"); + return -1; + } + /* Add the logging string to the global gueue */ - logMessage.prefix = &fo_prefix_val; - logMessage.message = &value; logMessage.dest_file = file_index; fo_enqueue(fo_queue, logMessage); diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index 0ae9bc7b063..5b9a62112f4 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -37,36 +37,6 @@ static fo_node_t *fo_new_node(fo_log_message_t data) int fo_enqueue(fo_queue_t *q, fo_log_message_t data) { - /* - Copy the contents of data.message - */ - str *message_copy = 0; - str *prefix_copy = 0; - /* - * Allocate memory for the message and prefix - */ - message_copy = (str *)shm_malloc(sizeof(str)); - if(message_copy == 0) { - SHM_MEM_ERROR; - return -1; - } - if(shm_str_dup(message_copy, data.message) < 0) { - LM_ERR("Failed to duplicate message\n"); - return -1; - } - data.message = message_copy; - - prefix_copy = (str *)shm_malloc(sizeof(str)); - if(prefix_copy == 0) { - SHM_MEM_ERROR; - return -1; - } - if(shm_str_dup(prefix_copy, data.prefix) < 0) { - LM_ERR("Failed to duplicate prefix\n"); - return -1; - } - data.prefix = prefix_copy; - fo_node_t *temp = fo_new_node(data); lock_get(&(q->lock));

1 0

git:master:b8373b9a: file_out: Consistent check
by Henning Westerholt 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: b8373b9aeeb9d4d4b0b56f6f4de3a358bd224daf URL: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-06-06T15:43:16+02:00 file_out: Consistent check --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… Patch: https://github.com/kamailio/kamailio/commit/b8373b9aeeb9d4d4b0b56f6f4de3a35… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 149059e0e68..7a275d59022 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -206,7 +206,7 @@ static void destroy(void) } } - if(fo_prefix_buf) { + if(fo_prefix_buf != NULL) { pkg_free(fo_prefix_buf); }

1 0

[kamailio/kamailio] permanently disabled rtpengine nodes in a set are not permanently disabled anymore after commits: (e183a3e25c, 3823479733) (Issue #4247)
by Nuno M Reis ＠talkdesk 06 Jun '25

06 Jun '25

nmreistd created an issue (kamailio/kamailio#4247)  ### Description rtpengine module is now trying to ping previous permanently disabled nodes after commits: ``` * e183a3e25c rtpengine: Re-enable down servers (but not disabled ones) * 3823479733 rtpengine: Add timer to ping rtpengine ``` ### Troubleshooting #### Reproduction Just create a set of nodes and also set at least one to be permanently disabled. After that do RPC `rtpengine.reload` or equivelent and after a `rtpengine.show all` and `disabled: 1(permanent)` will never show as before the aforementioned additions. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` Tested between `kamailio 5.8.2` and `6.0.1` ``` * **Operating System**:  ``` debian bookworm ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4247 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4247(a)github.com>

3 4

[kamailio/kamailio] branch_failure_route does not handle reply while wt_timer period (Issue #4266)
by IgorG 06 Jun '25

06 Jun '25

IgorrG created an issue (kamailio/kamailio#4266) ### Description While implementing mid-register inspired by pull request (https://github.com/kamailio/kamailio/pull/3360) we found the case when it goes impossible to handle responses for registrar servers. In case some of registrars busy and respond with 401 after 200ok received - it is not possible using any routes and configuration options to handle responses received in branch transactions. According to documentation I think that setting wt_timer should allow to absorb and handle responses on failure-route while transaction kept in memory. In fact wt_timer does not affect handling responses in any way. ![Image](https://github.com/user-attachments/assets/14feb472-91ea-4028-8780-1fee1d4ee0e8) ### Troubleshooting To reproduce this case we have configured sipp to response instant with 200ok on registration request. #### Reproduction To reproduce issue SIPP could be setup as one of the dispatcher nodes with instant 200ok reply to register. Kamailio should use following configuration snippet: https://github.com/ovoshlook/kamailio-mid-registrar-config-snippets/blob/ma… #### Log Messages REGISTER|401tm [t_lookup.c:912]: t_reply_matching(): t_reply_matching: hash 12337 label 0 branch 1 REGISTER|401tm [t_lookup.c:986]: t_reply_matching(): reply (0x7f1fc67f83a8) matched an active transaction (T=0x7f1fc0f0f740)! REGISTER|401tm [t_lookup.c:1122]: t_check_msg(): msg (0x7f1fc67f83a8) id=13/1915035 global id=13/1915035 T end=0x7f1fc0f0f740 REGISTER|401tm [t_reply.c:2363]: reply_received(): transaction found - T:0x7f1fc0f0f740 branch:1 REGISTER|401tm [t_reply.c:2376]: reply_received(): original status uas=200, uac[1]=0 local=0 is_invite=0) REGISTER|401tm [t_reply.c:1363]: t_should_relay_response(): ->>>>>>>>> T_code=200, new_code=401 REGISTER|401tm [t_reply.c:1374]: t_should_relay_response(): final reply already sent REGISTER|401tm [t_reply.c:1625]: t_should_relay_response(): finished with rps discarded - uas status: 200 ### Possible Solutions  ### Additional Information * **Kamailio Version** ``` version: kamailio 5.6.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 16:35:08 Jun 5 2023 with gcc 10.2.1 ``` * **Operating System**: ``` No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye Linux pbxKamaTest 5.10.0-23-amd64 #1 SMP Debian 5.10.179-1 (2023-05-12) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4266 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4266(a)github.com>

2 1

[kamailio/kamailio] Missing two way audio when using Yealink. Kamilio + rtpengine + freeswitch/fusionpbx (Issue #4270)
by jaspreet-eltropy 06 Jun '25

06 Jun '25

jaspreet-eltropy created an issue (kamailio/kamailio#4270) **I’m running into an issue when using Yealink SIP phones in a setup involving Kamailio + RTPengine + FreeSWITCH/Fusionpbx.** **Setup Overview:** SIP Proxy: Kamailio (handling NAT traversal, registration, and routing) Media Relay: RTPengine (with replace-origin, replace-session-connection, media-address, and other options) Media Server: FreeSWITCH (handles RTP/audio and call logic) Phone: Yealink T54w Series (but likely affects other models too) Transport: UDP (with force_rport() and NAT detection routes in place) Environment: Mixed NAT/public IPs with STUN/TURN enabled on WebRTC clients(SIP.js) (where applicable) Problem Description: When a call is placed from/to a Yealink phone, the call signaling works fine (INVITE, 200 OK, ACK are all seen correctly), but there is no audio or sometimes one-way audio. This only happens with Yealink; other SIP clients (Zoiper, Linphone, SIP.js etc.) work fine with the same setup. From packet captures and Kamailio logs, I can see the following: RTPengine receives the call and processes it. The rtpengine_manage() is called with these flags: May 30 05:38:13 ip-10-7-37-179 /usr/local/sbin/kamailio[62354]: INFO: <script>: BRIDGING: TRYING TO BRIDGE udp sip:5555@192.168.1.10:12561;transport=TCP May 30 05:38:13 ip-10-7-37-179 /usr/local/sbin/kamailio[62354]: INFO: <script>: NATMANAGE branch_id:0 ruri: sip:5555@192.168.1.10:12561;transport=TCP, method:INVITE, status:<null>, extra_id: z9hG4bKcSBpr6vNyyepe0, rtpengine_manage: replace-origin replace-session-connection media-address=52.24.225.81 trust-address via-branch=extra The Yealink phone sends SDP with correct IPs, but it doesn’t receive RTP (confirmed via tcpdump). Interestingly, if I bypass RTPengine + kamilio (media goes directly to/from FreeSWITCH), audio works. What I’ve Tried: Enabling/disabling trust-address and via-branch options. Using set_contact_alias() for REGISTER/NATed clients. Ensured that Contact header aliasing is applied. Verified that Yealink NAT settings are configured correctly. Using force_rport() and fix_nated_register() in Kamailio. Ensured RTP ports are open and media_address in RTPengine is set correctly. My Questions: Is there a known compatibility issue with Yealink phones and RTPengine in relayed mode? Does Yealink require specific NAT handling rules that differ from softphones? Are there any recommended rtpengine_manage() flags or Kamailio routing practices specifically for Yealink endpoints? Any suggestions to debug further — SIP traces seem clean, but RTP is not received by the Yealink. Sample Logs (Kamailio): NATMANAGE branch_id:0 ruri: <null>, method:INVITE, status:100, extra_id: z9hG4bK4b1.ffbb20e21cff840bb08800b46398f55b.00, rtpengine_manage: replace-origin replace-session-connection media-address=52.24.225.81 trust-address via-branch=extra Yealink SIP Config: NAT Traversal: Enabled (STUN) Keep-Alive: 30s UDP port: 5060 SIP registration: works Audio: not working when RTPengine is in the path Any help or suggestions would be greatly appreciated. Let me know if logs or traces are needed. ``` -[ RECORD 1 ]-+---------------------------------------------------------------------- id | 3259 ruid | uloc-683943f5-f3a0-1 username | 5555 domain | contact | sip:5555@192.168.1.10:12561;transport=TCP received | sip:182.77.49.201:12561;transport=tcp path | expires | 2025-05-30 05:44:04 q | -1 callid | [2_689921921@192.168.1.10](mailto:2_689921921@192.168.1.10) cseq | 6 last_modified | 2025-05-30 05:42:04 flags | 0 cflags | 64 user_agent | Yealink SIP-T54W 96.86.0.75 socket | tcp:10.7.37.179:5060 methods | 16383 instance | reg_id | 0 server_id | 0 connection_id | 4 keepalive | 1 partition | 28 ``` Thanks in advance -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4270 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4270(a)github.com>

3 5

git:master:a1449f0d: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: a1449f0d160fa0911fb6cad588e4c41a9dc5d147 URL: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-06T15:16:09+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README Modified: src/modules/pua_reginfo/README --- Diff: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41… Patch: https://github.com/kamailio/kamailio/commit/a1449f0d160fa0911fb6cad588e4c41…

1 0

[kamailio/kamailio] wip: pua_reginfo: add helper to disable publishing for current message (PR #4253)
by Matteo 06 Jun '25

06 Jun '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4252 #### Description This PR adds a new helper `reginfo_disable_publish` to `pua_reginfo` module which disabled the publishing for the current message, which is useful to control when to actually send it or not (eg in DMQ replication scenarios). The helper is "negative" (it *disables* not enables) on purpose in order to mantain backward compatibility to current behaviour. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4253 -- Commit Summary -- * pua_reginfo: add helper to disable publishing for current message -- File Changes -- M src/modules/pua_reginfo/pua_reginfo.c (4) M src/modules/pua_reginfo/pua_reginfo.h (4) M src/modules/pua_reginfo/usrloc_cb.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4253.patch https://github.com/kamailio/kamailio/pull/4253.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4253 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4253(a)github.com>

3 8

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev