- sr-dev - kamailio.org

git:master:af9f95da: cplc: convert to memory error logging helper, add one missing free in error case
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: af9f95da42bd07ea9bf3de0ea5cbd264f384bc02 URL: https://github.com/kamailio/kamailio/commit/af9f95da42bd07ea9bf3de0ea5cbd26… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T12:13:47Z cplc: convert to memory error logging helper, add one missing free in error case --- Modified: src/modules/cplc/cpl_db.c Modified: src/modules/cplc/cpl_loader.c Modified: src/modules/cplc/cpl_log.c Modified: src/modules/cplc/cpl_nonsig.c Modified: src/modules/cplc/cpl_proxy.h Modified: src/modules/cplc/cpl_run.c Modified: src/modules/cplc/cpl_time.c Modified: src/modules/cplc/cplc.c Modified: src/modules/cplc/loc_set.h Modified: src/modules/cplc/sub_list.c --- Diff: https://github.com/kamailio/kamailio/commit/af9f95da42bd07ea9bf3de0ea5cbd26… Patch: https://github.com/kamailio/kamailio/commit/af9f95da42bd07ea9bf3de0ea5cbd26…

1 0

git:master:9e001534: avpops: convert to memory error logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: 9e001534589a3428cd5f8908e84fe327ffc20fb6 URL: https://github.com/kamailio/kamailio/commit/9e001534589a3428cd5f8908e84fe32… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T11:17:22Z avpops: convert to memory error logging helper --- Modified: src/modules/avpops/avpops.c Modified: src/modules/avpops/avpops_db.c Modified: src/modules/avpops/avpops_parse.c --- Diff: https://github.com/kamailio/kamailio/commit/9e001534589a3428cd5f8908e84fe32… Patch: https://github.com/kamailio/kamailio/commit/9e001534589a3428cd5f8908e84fe32…

1 0

Re: [kamailio/kamailio] auth_db: fix goto for memory allocation error, convert to memory logging helper (01e82b3)
by Bastian Triller 22 Mar '23

22 Mar '23

Is it intended to jump to `error` instead of `parse_error` now? @pantelisk98 @henningw -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/01e82b38c41d344c1e94b2e0f574981… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/01e82b38c41d344c1e94b2e0f574981ef0ce4318/105530322(a)github.com>

2 1

git:master:d45eb770: auth_xkeys: convert to memory logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: d45eb770b0a8e17533f12e16dfc1d23dc5e7d951 URL: https://github.com/kamailio/kamailio/commit/d45eb770b0a8e17533f12e16dfc1d23… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T10:14:39Z auth_xkeys: convert to memory logging helper --- Modified: src/modules/auth_xkeys/auth_xkeys.c --- Diff: https://github.com/kamailio/kamailio/commit/d45eb770b0a8e17533f12e16dfc1d23… Patch: https://github.com/kamailio/kamailio/commit/d45eb770b0a8e17533f12e16dfc1d23… --- diff --git a/src/modules/auth_xkeys/auth_xkeys.c b/src/modules/auth_xkeys/auth_xkeys.c index 6963d4e3132..3f02f0d9bce 100644 --- a/src/modules/auth_xkeys/auth_xkeys.c +++ b/src/modules/auth_xkeys/auth_xkeys.c @@ -61,7 +61,7 @@ int auth_xkeys_list_init(void) return 0; _auth_xkeys_list = shm_malloc(sizeof(auth_xkey_t*)); if(_auth_xkeys_list==NULL) { - LM_ERR("no more shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(_auth_xkeys_list, 0, sizeof(auth_xkey_t*)); @@ -88,7 +88,7 @@ int authx_xkey_insert(auth_xkey_t *nkey) + nkey->kvalue.len + 3; ukey = (auth_xkey_t*)shm_malloc(ksize); if(ukey==NULL) { - LM_ERR("no more shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(ukey, 0, ksize); @@ -269,7 +269,7 @@ int auth_xkeys_add(sip_msg_t* msg, str *hdr, str *key, } p = (char*)pkg_malloc(xdata.len+1); if(p==NULL) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; return -2; } memcpy(p, xdata.s, xdata.len);

1 0

git:master:fcf733ce: db_flatstore: convert to memory logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: fcf733ce205221a40f68414662f841b918dea48f URL: https://github.com/kamailio/kamailio/commit/fcf733ce205221a40f68414662f841b… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T10:19:30Z db_flatstore: convert to memory logging helper --- Modified: src/modules/db_flatstore/db_flatstore.c Modified: src/modules/db_flatstore/flat_cmd.c Modified: src/modules/db_flatstore/flat_con.c Modified: src/modules/db_flatstore/km_flat_con.c Modified: src/modules/db_flatstore/km_flat_id.c Modified: src/modules/db_flatstore/km_flatstore.c Modified: src/modules/db_flatstore/km_flatstore_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fcf733ce205221a40f68414662f841b… Patch: https://github.com/kamailio/kamailio/commit/fcf733ce205221a40f68414662f841b…

1 0

git:master:0702a7e0: app_sqlang: convert to memory logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: 0702a7e0d9df2867cbc86188c06d95363d484d5a URL: https://github.com/kamailio/kamailio/commit/0702a7e0d9df2867cbc86188c06d953… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T09:55:14Z app_sqlang: convert to memory logging helper --- Modified: src/modules/app_sqlang/app_sqlang_api.c --- Diff: https://github.com/kamailio/kamailio/commit/0702a7e0d9df2867cbc86188c06d953… Patch: https://github.com/kamailio/kamailio/commit/0702a7e0d9df2867cbc86188c06d953… --- diff --git a/src/modules/app_sqlang/app_sqlang_api.c b/src/modules/app_sqlang/app_sqlang_api.c index a1d195bace2..fd2a81f759b 100644 --- a/src/modules/app_sqlang/app_sqlang_api.c +++ b/src/modules/app_sqlang/app_sqlang_api.c @@ -362,7 +362,7 @@ static SQInteger sqlang_sr_modf (HSQUIRRELVM J) if(sqlangv[i]!=NULL) { argv[i] = (char*)pkg_malloc(strlen(sqlangv[i])+1); if(argv[i]==NULL) { - LM_ERR("no more pkg\n"); + PKG_MEM_ERROR; goto error; } strcpy(argv[i], sqlangv[i]); @@ -583,7 +583,7 @@ int sqlang_sr_init_mod(void) if(_sr_sqlang_reload_version == NULL) { _sr_sqlang_reload_version = (int*)shm_malloc(sizeof(int)); if(_sr_sqlang_reload_version == NULL) { - LM_ERR("failed to allocated reload version\n"); + SHM_MEM_ERROR; return -1; } *_sr_sqlang_reload_version = 0; @@ -1085,7 +1085,7 @@ SQInteger sqlang_open_KSR(HSQUIRRELVM J) _sr_J_KSRMethods = malloc(SR_SQLANG_KSR_METHODS_SIZE * sizeof(SQRegFunction)); if(_sr_J_KSRMethods==NULL) { - LM_ERR("no more pkg memory\n"); + SYS_MEM_ERROR ; return 0; } memset(_sr_J_KSRMethods, 0, SR_SQLANG_KSR_METHODS_SIZE * sizeof(SQRegFunction));

1 0

git:master:01e82b38: auth_db: fix goto for memory allocation error, convert to memory logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: 01e82b38c41d344c1e94b2e0f574981ef0ce4318 URL: https://github.com/kamailio/kamailio/commit/01e82b38c41d344c1e94b2e0f574981… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T10:07:02Z auth_db: fix goto for memory allocation error, convert to memory logging helper --- Modified: src/modules/auth_db/auth_db_mod.c Modified: src/modules/auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/01e82b38c41d344c1e94b2e0f574981… Patch: https://github.com/kamailio/kamailio/commit/01e82b38c41d344c1e94b2e0f574981… --- diff --git a/src/modules/auth_db/auth_db_mod.c b/src/modules/auth_db/auth_db_mod.c index ce8baae8381..5d54bdf4bd4 100644 --- a/src/modules/auth_db/auth_db_mod.c +++ b/src/modules/auth_db/auth_db_mod.c @@ -359,7 +359,7 @@ int parse_aaa_pvs(char *definition, pv_elem_t **pv_def, int *cnt) while ( (end=strchr(p,';'))!=0 || (end=p+strlen(p))!=p ) { /* new pv_elem_t */ if ( (pve=(pv_elem_t*)pkg_malloc(sizeof(pv_elem_t)))==0 ) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; goto error; } memset( pve, 0, sizeof(pv_elem_t)); @@ -394,8 +394,8 @@ int parse_aaa_pvs(char *definition, pv_elem_t **pv_def, int *cnt) /* create an avp definition for the spec parser */ pv.s = (char*)pkg_malloc(pve->text.len + 7); if (pv.s == NULL) { - LM_ERR("no more pkg mem\n"); - goto parse_error; + PKG_MEM_ERROR; + goto error; } pv.len = snprintf(pv.s, pve->text.len + 7, "$avp(%.*s)", pve->text.len, pve->text.s); diff --git a/src/modules/auth_db/authorize.c b/src/modules/auth_db/authorize.c index 4f8d9674549..dfaf8f92bbf 100644 --- a/src/modules/auth_db/authorize.c +++ b/src/modules/auth_db/authorize.c @@ -59,7 +59,7 @@ int fetch_credentials(sip_msg_t *msg, str *user, str* domain, str *table, int fl } col = pkg_malloc(sizeof(*col) * (nc+1)); if (col == NULL) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; return -1; } @@ -140,7 +140,7 @@ static inline int get_ha1(struct username* _username, str* _domain, col = pkg_malloc(sizeof(*col) * (credentials_n + 1)); if (col == NULL) { - LM_ERR("no more pkg memory\n"); + PKG_MEM_ERROR; return -1; }

1 0

git:master:66e9b02f: app_lua_sr: convert to memory logging helper
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: 66e9b02f7fc99084341d6519ac94cd580b334ac7 URL: https://github.com/kamailio/kamailio/commit/66e9b02f7fc99084341d6519ac94cd5… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T09:52:17Z app_lua_sr: convert to memory logging helper --- Modified: src/modules/app_lua_sr/app_lua_sr_api.c --- Diff: https://github.com/kamailio/kamailio/commit/66e9b02f7fc99084341d6519ac94cd5… Patch: https://github.com/kamailio/kamailio/commit/66e9b02f7fc99084341d6519ac94cd5… --- diff --git a/src/modules/app_lua_sr/app_lua_sr_api.c b/src/modules/app_lua_sr/app_lua_sr_api.c index dc1e14f17fc..7e9fc023656 100644 --- a/src/modules/app_lua_sr/app_lua_sr_api.c +++ b/src/modules/app_lua_sr/app_lua_sr_api.c @@ -276,7 +276,7 @@ static int lua_sr_modf (lua_State *L) argv[i] = (char*)pkg_malloc(strlen(luav[i])+1); if(argv[i]==NULL) { - LM_ERR("no more pkg\n"); + PKG_MEM_ERROR; goto error; } strcpy(argv[i], luav[i]);

1 0

git:master:8bf54822: app_jsdt: fix log message for system memory allocation
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: 8bf54822b9f610eceae1b5c6006ab6cc5ed96d00 URL: https://github.com/kamailio/kamailio/commit/8bf54822b9f610eceae1b5c6006ab6c… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T09:49:48Z app_jsdt: fix log message for system memory allocation --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/8bf54822b9f610eceae1b5c6006ab6c… Patch: https://github.com/kamailio/kamailio/commit/8bf54822b9f610eceae1b5c6006ab6c… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index 5df1b2db716..548b27690fb 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -868,7 +868,7 @@ duk_ret_t dukopen_KSR(duk_context *J) _sr_J_KSRMethods = malloc(SR_JSDT_KSR_METHODS_SIZE * sizeof(duk_function_list_entry)); if(_sr_J_KSRMethods==NULL) { - LM_ERR("no more pkg memory\n"); + SYS_MEM_ERROR; return 0; } memset(_sr_J_KSRMethods, 0, SR_JSDT_KSR_METHODS_SIZE * sizeof(duk_function_list_entry));

1 0

git:master:eef779ca: app_java: add missing free in error case
by Henning Westerholt 22 Mar '23

22 Mar '23

Module: kamailio Branch: master Commit: eef779ca7b5b203d216f76fbec56025d595f6e6d URL: https://github.com/kamailio/kamailio/commit/eef779ca7b5b203d216f76fbec56025… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-22T09:48:05Z app_java: add missing free in error case --- Modified: src/modules/app_java/java_native_methods.c --- Diff: https://github.com/kamailio/kamailio/commit/eef779ca7b5b203d216f76fbec56025… Patch: https://github.com/kamailio/kamailio/commit/eef779ca7b5b203d216f76fbec56025… --- diff --git a/src/modules/app_java/java_native_methods.c b/src/modules/app_java/java_native_methods.c index bb2ebe6be70..a73fdc313de 100644 --- a/src/modules/app_java/java_native_methods.c +++ b/src/modules/app_java/java_native_methods.c @@ -1002,6 +1002,7 @@ JNIEXPORT jint JNICALL Java_org_siprouter_CoreMethods_force_1send_1socket( si = (struct socket_id *)pkg_malloc(sizeof(struct socket_id)); if(!si) { PKG_MEM_ERROR; + pkg_free(nl); return -1; }

1 0

[kamailio/kamailio] With TOPOH module enabled, transferred call hangup from callee side does not hang up the call (Issue #3398)
by akabihno 21 Mar '23

21 Mar '23

### Description We have faced an issue which appears when TOPOH module is enabled, call is made from WebRTC client, then transferred by callee. #### Scenario WebRTC client behind load balancer makes call to softphone, call from softphone is transferred to external number using Asterisk. #### Expected result When call is hanged up on external number side, call should be hanged up on WebRTC client side. #### Actual result When call is hanged up on external number side, call is not hanged up on WebRTC client side. ### Troubleshooting #### Legend 10.5.0.145 - load balancer 10.128.150.67 - WebRTC client 10.181.0.1 - kamailio 10.5.2.192 - asterisk #### Log Messages On transfer: https://pastebin.com/H3FQ4Kpj On hangup from external number side: https://pastebin.com/wgfRzGbd On hangup from WebRTC client side: https://pastebin.com/sE0yhBae #### SIP Traffic Faulty case with TOPOH module enabled: [topoh_on.csv](https://github.com/kamailio/kamailio/files/11028205/topoh_on.… Normal behavior with TOPOH module disabled: [topoh_off.csv](https://github.com/kamailio/kamailio/files/11028206/topoh_of… #### Config files kamailio.cfg: [kamailio.txt](https://github.com/kamailio/kamailio/files/11028283/kamailio.… kamailio-local.cfg enabled toggles: #!define WITH_MYSQL #!define WITH_AUTH #!define WITH_USRLOCDB #!define WITH_DISPATCHER #!define WITH_HOMER #!define WITH_PSTN #!define WITH_TOPOH #!define WITH_CUSTOM_HEADERS #!define WITH_PROM #!define WITH_DMQ #!define WITH_NAT #!define WITH_XXXX_HEADERS #!define WITH_TLS #!define WITH_WEBSOCKET #!define WITH_VOIP_AUTH #!define WITH_ADVERTISE #!define WITH_JSONRPC #!define WITH_TCP #!define WITH_DIALOG #!define WITH_DIFF_PROVIDER_SRC_IP #!define WITH_UAC #!define WITH_DEV ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 09:11:15 Nov 15 2022 with gcc 9.3.0 ``` * **Operating System**: ``` dockerized kamailio running on Ubuntu 16.04.3 LTS Docker version 18.03.1-ce, build 9ee9f40 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3398 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3398(a)github.com>

2 2

[kamailio/kamailio] Missing from: tag creates ERROR: log (Issue #3399)
by CarlWickbom 21 Mar '23

21 Mar '23

Hi Kamailio, We have noticed that a request not belonging to a dialog (e.g. a SIP MESSAGE) missing the tag= parameter in the from: header will trigger an ERROR: message like. ```` Mar 21 14:40:23 ip-10-85-164-143 /usr/sbin/kamailio[172]: ERROR: dialog [dlg_handlers.c:726]: pre_match_parse(): failed to get From header ```` ```` Mar 21 14:42:31 ip-10-85-165-13 /usr/sbin/kamailio[183]: ERROR: tmx [tmx_pretran.c:227]: tmx_check_pretran(): failed to get From header ```` According to our interpretation of 3261 section 12.1.1 ```` "A UAS MUST be prepared to receive a request without a tag in the From field, in which case the tag is considered to have a value of null." ```` this should not be the case. Also the BNF states no from: tag: is mandatory ``` From = ( "From" / "f" ) HCOLON from-spec from-spec = ( name-addr / addr-spec ) *( SEMI from-param ) from-param = tag-param / generic-param tag-param = "tag" EQUAL token ``` We believe this to be implemented in at least two places where one example is in the `dlg_handler` where `pre_match_parse` check ``` if (parse_from_header(req) < 0 || get_from(req)->tag_value.len == 0) { LM_ERR("failed to get From header\n"); return -1; } ``` As our interpretation of the standard is that the from: tag is not mandatory, hence we can't require our customer to change their behaviour, we consider this as a bug. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3399 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3399(a)github.com>

2 3

git:master:b9d397c8: async: convert to memory error logging helper
by Henning Westerholt 21 Mar '23

21 Mar '23

Module: kamailio Branch: master Commit: b9d397c84cb3e0911e9823386b6eb4944b02c9ed URL: https://github.com/kamailio/kamailio/commit/b9d397c84cb3e0911e9823386b6eb49… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-21T16:22:24Z async: convert to memory error logging helper --- Modified: src/modules/async/async_mod.c Modified: src/modules/async/async_sleep.c --- Diff: https://github.com/kamailio/kamailio/commit/b9d397c84cb3e0911e9823386b6eb49… Patch: https://github.com/kamailio/kamailio/commit/b9d397c84cb3e0911e9823386b6eb49… --- diff --git a/src/modules/async/async_mod.c b/src/modules/async/async_mod.c index 3b18eda9570..3075bf61d00 100644 --- a/src/modules/async/async_mod.c +++ b/src/modules/async/async_mod.c @@ -289,7 +289,7 @@ static int fixup_async_sleep(void **param, int param_no) return 0; ap = (async_param_t *)pkg_malloc(sizeof(async_param_t)); if(ap == NULL) { - LM_ERR("no more pkg memory available\n"); + PKG_MEM_ERROR; return -1; } memset(ap, 0, sizeof(async_param_t)); diff --git a/src/modules/async/async_sleep.c b/src/modules/async/async_sleep.c index d6dd41d3f17..c19f05bbe67 100644 --- a/src/modules/async/async_sleep.c +++ b/src/modules/async/async_sleep.c @@ -109,7 +109,7 @@ int async_init_timer_list(void) _async_list_head = (struct async_list_head *)shm_malloc( sizeof(struct async_list_head)); if(_async_list_head == NULL) { - LM_ERR("no more shm\n"); + SHM_MEM_ERROR; return -1; } memset(_async_list_head, 0, sizeof(struct async_list_head)); @@ -135,7 +135,7 @@ int async_init_ms_timer_list(void) _async_ms_list = (struct async_ms_list *)shm_malloc( sizeof(struct async_ms_list)); if(_async_ms_list == NULL) { - LM_ERR("no more shm\n"); + SHM_MEM_ERROR; return -1; } memset(_async_ms_list, 0, sizeof(struct async_ms_list)); @@ -247,7 +247,7 @@ int async_sleep(sip_msg_t *msg, int seconds, cfg_action_t *act, str *cbname) slot = ticks % ASYNC_RING_SIZE; ai = (async_item_t *)shm_malloc(sizeof(async_item_t)); if(ai == NULL) { - LM_ERR("no more shm memory\n"); + SHM_MEM_ERROR; return -1; } memset(ai, 0, sizeof(async_item_t)); @@ -454,7 +454,7 @@ int async_ms_sleep(sip_msg_t *msg, int milliseconds, cfg_action_t *act, str *cbn at = (async_task_t *)shm_malloc(dsize); if(at == NULL) { - LM_ERR("no more shm memory\n"); + SHM_MEM_ERROR; return -1; } memset(at, 0, dsize); @@ -517,7 +517,7 @@ int async_send_task(sip_msg_t *msg, cfg_action_t *act, str *cbname, str *gname) dsize = sizeof(async_task_t) + sizeof(async_task_param_t); at = (async_task_t *)shm_malloc(dsize); if(at == NULL) { - LM_ERR("no more shm memory\n"); + SHM_MEM_ERROR; return -1; } memset(at, 0, dsize); @@ -614,7 +614,7 @@ int async_send_data(sip_msg_t *msg, cfg_action_t *act, str *cbname, str *gname, dsize = sizeof(async_task_t) + sizeof(async_data_param_t) + sdata->len + 1; at = (async_task_t *)shm_malloc(dsize); if(at == NULL) { - LM_ERR("no more shm memory\n"); + SHM_MEM_ERROR; return -1; } memset(at, 0, dsize);

1 0

git:master:9cc9a177: p_usrloc: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture
by Victor Seva 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 9cc9a177daf6d5ce11fbdef714bd576716dc5a2f URL: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-20T16:56:03+01:00 p_usrloc: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture --- Modified: src/modules/p_usrloc/ul_check.c --- Diff: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… Patch: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… --- diff --git a/src/modules/p_usrloc/ul_check.c b/src/modules/p_usrloc/ul_check.c index dfc062f266..0ed32dc99f 100644 --- a/src/modules/p_usrloc/ul_check.c +++ b/src/modules/p_usrloc/ul_check.c @@ -19,6 +19,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <inttypes.h> #include <stdint.h> #include "../../core/mem/shm_mem.h" @@ -136,7 +137,7 @@ int must_retry(time_t *timer, time_t interval){ if(!timer){ return -1; } - LM_DBG("must_retry: time is at %llu, retry at %llu.\n", (uint64_t)time(NULL), + LM_DBG("must_retry: time is at %" PRIu64 ", retry at %" PRIu64 ".\n", (uint64_t)time(NULL), (uint64_t)(*timer)); if(*timer <= time(NULL)){ *timer = time(NULL) + interval;

1 0

git:master:1b3224c5: rtpengine: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture
by Victor Seva 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 1b3224c514105d69c3099c11edc5ef20ca02c567 URL: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-20T16:53:15+01:00 rtpengine: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… Patch: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 58c96efc0d..51bd9e380a 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -19,6 +19,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <inttypes.h> #include <sys/types.h> #include <sys/socket.h> #include <sys/time.h> @@ -1337,7 +1338,7 @@ static void rtpengine_rpc_reload(rpc_t* rpc, void* ctx) _rtpe_list_version->vernum += 1; _rtpe_list_version->vertime = time(NULL); - LM_DBG("current rtpengines list version: %d (%llu)\n", + LM_DBG("current rtpengines list version: %d (%" PRIu64 ")\n", _rtpe_list_version->vernum, (uint64_t)_rtpe_list_version->vertime); rpc->rpl_printf(ctx, "Ok. Reload successful."); @@ -1857,7 +1858,7 @@ static int build_rtpp_socks(int lmode, int rtest) { if(_rtpe_list_vernum_local == _rtpe_list_version->vernum) { /* same version for the list of rtpengines */ - LM_DBG("same rtpengines list version: %d (%llu)\n", + LM_DBG("same rtpengines list version: %d (%" PRIu64 ")\n", _rtpe_list_version->vernum, (uint64_t)_rtpe_list_version->vertime); return 0;

1 0

git:master:452af935: modules: readme files regenerated - evapi ... [skip ci]
by Kamailio Dev 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 452af935fbcc60572541941612091cbc0535a310 URL: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-20T16:31:24+01:00 modules: readme files regenerated - evapi ... [skip ci] --- Modified: src/modules/evapi/README Modified: src/modules/jsonrpcs/README Modified: src/modules/pipelimit/README --- Diff: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb… Patch: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb…

1 0

git: new commits in branch master
by Daniel-Constantin Mierla 20 Mar '23

20 Mar '23

- URL: https://github.com/kamailio/kamailio/commit/926ba9473775878d8f38b175764a50d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 rtpengine: cast to uint64_t when using time_t value - URL: https://github.com/kamailio/kamailio/commit/e29ce594466385a7c35634fda4b4664… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 p_usrloc: cast to uint64_t when using time_t value - URL: https://github.com/kamailio/kamailio/commit/161ec6d14b702cb92406171152d127b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 jsonrpcs: protocol extended to allow storing response in a file - implemented for udp sockets - URL: https://github.com/kamailio/kamailio/commit/4fec664327410db4e5ff7036a459e99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 jsonrpcs: implemented result storing for rpc over fifo - URL: https://github.com/kamailio/kamailio/commit/1b5caab3479bb32c2986906e6e07ea9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 kamctl: option to set store path for rpc commands - URL: https://github.com/kamailio/kamailio/commit/e27823f746eb8fca834474945e45bfe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 pipelimit: added rpc command pl.rm_pipe - URL: https://github.com/kamailio/kamailio/commit/6c0b62c464bcbc67e485c1e2193b7a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 pipelimit: docs for rpc command pl.rm_pipe - URL: https://github.com/kamailio/kamailio/commit/e0713531bf6ea2aa9b249503dc346ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 pipelimit: new rpc command pl.reset_pipe - reset associated values - URL: https://github.com/kamailio/kamailio/commit/569db2eeaef17f3034f692e808f3401… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 pipelimit: docs for rpc command pl.reset_pipe - URL: https://github.com/kamailio/kamailio/commit/4c998de5f54ee941f7516e589e29405… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: wait when idle made a modparam - URL: https://github.com/kamailio/kamailio/commit/3b99e09dc10ff38024b2821b26f2efe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs for wait_idle modparam - URL: https://github.com/kamailio/kamailio/commit/3bff060dcb74a081782abdbdade830b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: use internal workers to handle client messages - URL: https://github.com/kamailio/kamailio/commit/b34e24770a6435577097b173cafab30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: initial support for tcp transport - one rpc command per connection, which is closed after the response is sent - URL: https://github.com/kamailio/kamailio/commit/1400e8cb6aebdd93a5b0c6979a444a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: more debug messages when handling tcp commands - URL: https://github.com/kamailio/kamailio/commit/7000f437ac8f3fb40c7a55c8c7a3c2c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: docs for tcp_socket parameter - URL: https://github.com/kamailio/kamailio/commit/58bd64200e4d2f237f192acf6f88074… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: support for adaptive wait on idle to spare cpu when not busy - URL: https://github.com/kamailio/kamailio/commit/6e4ba9bd7421bf483cdbc7e5484f21d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: wait increase limit made modparam - URL: https://github.com/kamailio/kamailio/commit/b044c33c72318c12de78c0d8b7f8ac5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs for wait_increase parameter - URL: https://github.com/kamailio/kamailio/commit/1dc0eac9a3a3abd6e128aa5f1d17d5f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: if workers is 0, execute callback by evapi receiver - URL: https://github.com/kamailio/kamailio/commit/d4be0b2ec72159c5769fc6d7d0cee57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs - updates to workers parameter - URL: https://github.com/kamailio/kamailio/commit/ab1831efc20816e18a89e6322d16c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 core: skip warning for atomic ops with locking for some dev os-es - do not print the compile warning for non-native memory barier/atomic ops on some devel platforms, for now macos with apple silicon cpu

1 0

git:master:135f7b5e: modules: readme files regenerated - ims_registrar_pcscf ... [skip ci]
by Kamailio Dev 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 135f7b5e2114617b0bc408175ec146d248d01d3a URL: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-20T11:01:25+01:00 modules: readme files regenerated - ims_registrar_pcscf ... [skip ci] --- Modified: src/modules/ims_registrar_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… Patch: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… --- diff --git a/src/modules/ims_registrar_pcscf/README b/src/modules/ims_registrar_pcscf/README index 3bfb0e6003..02327a005c 100644 --- a/src/modules/ims_registrar_pcscf/README +++ b/src/modules/ims_registrar_pcscf/README @@ -312,6 +312,33 @@ pcscf_save("location"); * domain - Logical domain within the registrar. If a database is used then this must be name of the table which stores the contacts. + The return code may have the following values: + * ( 1) OK + * (-1) Parsing of contact data failed + * (-2) Deregistration in progress + + For db_mode = DB_ONLY (3) setting for ims_usrloc_pcscf module modparam + following logic is implemented: + * To avoid race time conditions between a REREGISTER and the expiry + handler state machine in the scscf an approach is chosen to refuse + a REREGISTER in time window of 20 seconds after pcontact expiry on + the pcscf (thus allowing expiry handling to finish). REREGISTER is + refused in this scenario with return code -2. + * In case a REREGISTER arrives at pcscf and the respective pcontact + is expired longer than time window of 20 seconds registration also + is refused with return code -2 and additionaly PUBLISH is sent to + scscf with expiry = 0. + * The rc -2 shall be handled in register.cfg script as follows: + pcscf_save_pending("location"); + switch ($retcode) { + case -1: + ....... + case -2: + send_reply("500", "Deregister in progress - Please try again"); + exit; + break; + } + 4.3. pcscf_follows_service_routes(domain) Returns true, if the request is following the "learned" service-routes

1 0

git:master:38d72c3f: ims_registrar_pcscf: changes for ul db_mode DB_ONLY
by Henning Westerholt 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 38d72c3f8248b32b3ba0ff24abd1f2f7407f9d8f URL: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f… Author: Annemarie Mandl <mandl(a)rpmbld.novalocal> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-20T10:57:21+01:00 ims_registrar_pcscf: changes for ul db_mode DB_ONLY Enable registration of pcscf contact callback during download from db location table and inserting pcontact (normally this callback is registered during handling of REGISTER). Refuse REGISTER when pcontact is expired since [0 to 20] seconds. Within this time window a NOTIFY is expected from scscf and in order to avoid race time conditions between scscf and pcscf REGISTER will be refused. Refuse REGISTER when pcontact is expired longer than 20 seconds - send PUBLISH (contact expired) to scscf to trigger NOTIFY. In both REGISTER refused scenarios routing script should reply 500 - Deregistration in progress. undo changes in ul_callback.c & ul_callback.h corrections after comments from Henning --- Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c Modified: src/modules/ims_registrar_pcscf/notify.c Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f… Patch: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f…

1 0

[kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)
by petermarianF 20 Mar '23

20 Mar '23

Enable registration of pcscf contact callback during download from db location table and inserting pcontact (normally this callback is registered during handling of REGISTER). Refuse REGISTER when pcontact is expired since [0 to 20] seconds. Within this time window a NOTIFY is expected from scscf and in order to avoid race time conditions between scscf and pcscf REGISTER will be refused. Refuse REGISTER when pcontact is expired longer than 20 seconds - send PUBLISH (contact expired) to scscf to trigger NOTIFY. In both REGISTER refused scenarios routing script should reply 500 - Deregister in progress.   #### Pre-Submission Checklist    - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case a pcontact found in location db has to be inserted into pcscf cache depending on contact state also callbacks have to be registered for this pcontact. Registering of callback_pcscf_contact_cb is enabled in this module. Handling of contact expiry is usually triggered in the scscf (mem_timer_udomain which runs every 10 secs). Sending of NOTIFY to pcscf may take up to 20 seconds from start of expiry due to timing conditions. To avoid race time conditions between a REREGISTER and the expiry handler state machine in the scscf an approach is chosen to refuse a REREGISTER in time window of 20 seconds after pcontact expiry on the pcscf (thus allowing expiry handling to finish). REREGISTER is refused in this scenario with new return_code -2. In case a REREGISTER arrives at pcscf and the respective pcontact is expired longer than time window of 20 seconds registration also is refused with rc -2 and additionaly PUBLISH is sent to scscf with expiry = 0. The rc -2 shall be handled in register.cfg script as follows: pcscf_save_pending("location"); switch ($retcode) { case -1: # Missing/wrong Information in REGISTER. send_reply("400", "Information wrong - See log."); exit; break; case -2: # De-Register in Progress, or PUBLISH ongoing due to registration expiry, # or new REGISTER blocked because registration just expired (up to 20sec). append_to_reply("Retry-After: 30\r\n"); send_reply("500", "Deregister in progress - Please try again"); exit; break; } You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3317 -- Commit Summary -- * ims_registrar_pcscf: changes for ul db_mode DB_ONLY -- File Changes -- M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (21) M src/modules/ims_registrar_pcscf/notify.c (4) M src/modules/ims_registrar_pcscf/save.c (37) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3317.patch https://github.com/kamailio/kamailio/pull/3317.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3317 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3317(a)github.com>

2 11

Dialog-Module and CSeq tracking
by Carsten Bock 17 Mar '23

17 Mar '23

Hi, Quick question: Looking at the Dialog module and CSeq tracking functionality, I've noticed the following: - on the one hand, we are storing the current CSeq for each direction in the Dialog structure - on the other hand, we are storing a "Delta" of the received vs. updated CSeq as a Dialog Variable Does replacing the Delta with the CSeq already stored with the Dialog structure make sense? I am asking because of my latest changes, where there may be more sources for an updated CSeq (e.g., when sending a Request from script within the Dialog) and more use cases for an updated CSeq (Up and Downstream). I've updated the dialog module for my use already accordingly https://github.com/kamailio/kamailio/compare/master...carstenbock/dialog_cs… I wanted to hear other opinions and possible pitfalls as well... Thanks, Carsten -- Carsten Bock I CTO & Founder ng-voice GmbH Trostbrücke 1 I 20457 Hamburg I Germany T +49 179 2021244 I www.ng-voice.com Registry Office at Local Court Hamburg, HRB 120189 Managing Directors: Dr. David Bachmann, Carsten Bock

3 3

git:master:e8520177: auth_identity: add missing error handling for allocation errors, convert to memory log macros
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: e8520177f6fd70676251cfd2307c0ab40701a701 URL: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T21:14:20Z auth_identity: add missing error handling for allocation errors, convert to memory log macros --- Modified: src/modules/auth_identity/auth_dynstr.c Modified: src/modules/auth_identity/auth_hdrs.c Modified: src/modules/auth_identity/auth_http.c Modified: src/modules/auth_identity/auth_identity.c Modified: src/modules/auth_identity/auth_tables.c --- Diff: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab… Patch: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab…

1 0

git:master:7e617ab8: dmq: add missing memory allocation checks, convert to memory log macros
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 7e617ab89f5275f1b269382ae2c1fee508854cf1 URL: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T21:10:04Z dmq: add missing memory allocation checks, convert to memory log macros --- Modified: src/modules/dmq/dmq.c Modified: src/modules/dmq/dmq_funcs.c Modified: src/modules/dmq/dmqnode.c Modified: src/modules/dmq/message.c Modified: src/modules/dmq/notification_peer.c Modified: src/modules/dmq/peer.c Modified: src/modules/dmq/worker.c --- Diff: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee… Patch: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee…

1 0

git:master:aa4d015a: dispatcher: small formatting adaption related to 6aee3bd7c
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: aa4d015a58bb24ba5bda6e6133b0e9f314e2318e URL: https://github.com/kamailio/kamailio/commit/aa4d015a58bb24ba5bda6e6133b0e9f… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T17:20:14Z dispatcher: small formatting adaption related to 6aee3bd7c --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/aa4d015a58bb24ba5bda6e6133b0e9f… Patch: https://github.com/kamailio/kamailio/commit/aa4d015a58bb24ba5bda6e6133b0e9f… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 50ad98dc0f..d79fb7a6d3 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -4039,8 +4039,7 @@ ds_set_t *ds_avl_insert(ds_set_t **root, int id, int *setn) } if(!node) { node = shm_malloc(sizeof(ds_set_t)); - if(!(node)) - { + if(!(node)) { SHM_MEM_ERROR; return NULL; } diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 8ccc86fedc..5cb3d7aba2 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -360,15 +360,13 @@ static int mod_init(void) /* Initialize the counter */ ds_ping_reply_codes = (int **)shm_malloc(sizeof(unsigned int *)); - if(!(ds_ping_reply_codes)) - { + if(!(ds_ping_reply_codes)) { SHM_MEM_ERROR; return -1; } *ds_ping_reply_codes = 0; ds_ping_reply_codes_cnt = (int *)shm_malloc(sizeof(int)); - if(!(ds_ping_reply_codes_cnt)) - { + if(!(ds_ping_reply_codes_cnt)) { shm_free(ds_ping_reply_codes); SHM_MEM_ERROR; return -1;

1 0

git:master:6aee3bd7: dispatcher: add missing memory allocation checks, convert to memory log macros
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 6aee3bd7c86a1874cc140a7874b740981f14f5f5 URL: https://github.com/kamailio/kamailio/commit/6aee3bd7c86a1874cc140a7874b7409… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T17:17:28Z dispatcher: add missing memory allocation checks, convert to memory log macros --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatcher.c Modified: src/modules/dispatcher/ds_ht.c --- Diff: https://github.com/kamailio/kamailio/commit/6aee3bd7c86a1874cc140a7874b7409… Patch: https://github.com/kamailio/kamailio/commit/6aee3bd7c86a1874cc140a7874b7409…

1 0

Re: [kamailio/kamailio] nat_transversal: fix warning introduced at f301ca9cdcc044dd05e9d82139e1db368be6dc5c (6e03201)
by Victor Seva 14 Mar '23

14 Mar '23

@rfuchs Thanks! Pushed the PRIu64 macro versions -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/6e032019d992625abc2a3739423df9e… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/6e032019d992625abc2a3739423df9ea1c964356/104410654(a)github.com>

1 0

git:master:ef0427ea: nat_traversal:
by Victor Seva 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: ef0427ead03bfb738b6214b91c1763913e70a52d URL: https://github.com/kamailio/kamailio/commit/ef0427ead03bfb738b6214b91c17639… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-14T17:08:46+01:00 nat_traversal: --- Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/ef0427ead03bfb738b6214b91c17639… Patch: https://github.com/kamailio/kamailio/commit/ef0427ead03bfb738b6214b91c17639… --- diff --git a/src/modules/nat_traversal/nat_traversal.c b/src/modules/nat_traversal/nat_traversal.c index d21a8b7e01..28456c77d4 100644 --- a/src/modules/nat_traversal/nat_traversal.c +++ b/src/modules/nat_traversal/nat_traversal.c @@ -43,6 +43,7 @@ #include <ctype.h> #include <errno.h> #include <time.h> +#include <inttypes.h> #include <sys/types.h> #include <arpa/inet.h> @@ -923,7 +924,7 @@ static time_t get_register_expire( } } - LM_DBG("maximum expire for all contacts: %lu\n", (uint64_t)expire); + LM_DBG("maximum expire for all contacts: %" PRIu64 "\n", (uint64_t)expire); return (expire ? expire + now : 0); }

1 0

git:master:88412576: core: use PRIu64 macro to find out what format is needed for uint64_t
by Victor Seva 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 8841257671b6c5f3c4cfee3f1b7bb46d54faaf65 URL: https://github.com/kamailio/kamailio/commit/8841257671b6c5f3c4cfee3f1b7bb46… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-14T17:03:45+01:00 core: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/8841257671b6c5f3c4cfee3f1b7bb46… Patch: https://github.com/kamailio/kamailio/commit/8841257671b6c5f3c4cfee3f1b7bb46… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 205866163f..14e9243914 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -32,6 +32,7 @@ #include <string.h> #include <time.h> #include <stdint.h> +#include <inttypes.h> #include "../../core/mem/mem.h" #include "tmrec.h" @@ -272,7 +273,7 @@ int ac_print(ac_tm_t *_atp) return -1; } - printf("\nSys time: %lu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, + printf("\nSys time: %" PRIu64 "\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, _atp->t.tm_hour, _atp->t.tm_min, _atp->t.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_atp->t.tm_wday], _atp->t.tm_year+1900, _atp->t.tm_mon+1, _atp->t.tm_mday); @@ -512,15 +513,15 @@ int tr_print(tmrec_t *_trp) return -1; } printf("Recurrence definition\n-- start time ---\n"); - printf("Sys time: %lu\n", (uint64_t)_trp->dtstart); + printf("Sys time: %" PRIu64 "\n", (uint64_t)_trp->dtstart); printf("Time: %02d:%02d:%02d\n", _trp->ts.tm_hour, _trp->ts.tm_min, _trp->ts.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_trp->ts.tm_wday], _trp->ts.tm_year+1900, _trp->ts.tm_mon+1, _trp->ts.tm_mday); printf("---\n"); - printf("End time: %lu\n", (uint64_t)_trp->dtend); - printf("Duration: %lu\n", (uint64_t)_trp->duration); - printf("Until: %lu\n", (uint64_t)_trp->until); + printf("End time: %" PRIu64 "\n", (uint64_t)_trp->dtend); + printf("Duration: %" PRIu64 "\n", (uint64_t)_trp->duration); + printf("Until: %" PRIu64 "\n", (uint64_t)_trp->until); printf("Freq: %d\n", (int)_trp->freq); printf("Interval: %d\n", (int)_trp->interval); if(_trp->byday)

1 0

Re: [kamailio/kamailio] nat_transversal: fix warning introduced at f301ca9cdcc044dd05e9d82139e1db368be6dc5c (6e03201)
by Richard Fuchs 14 Mar '23

14 Mar '23

Eh, these are arch dependent. "long int" on 32-bit platforms is only 32 bits. Either use %llu and cast to "long long" or use the PRIu64 macro. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/6e032019d992625abc2a3739423df9e… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/6e032019d992625abc2a3739423df9ea1c964356/104404760(a)github.com>

1 0

[kamailio/kamailio] Statistic counters for LCR module (Issue #3372)
by Alessio Garzi 14 Mar '23

14 Mar '23

### Description I am in need to get some statistic counters related to each lcr gw currently loaded in Kamailio. Kamailio already provides the counters I need inside the KEX module with the following command: ``` kamcmd> stats.get_statistics core: core:bad_URIs_rcvd = 69 core:bad_msg_hdr = 2 core:drop_replies = 0 core:drop_requests = 8499 core:err_replies = 0 core:err_requests = 0 core:fwd_replies = 4 core:fwd_requests = 65 core:rcv_replies = 502088 ... ``` Here kamailio doing exactly what i want, it's exposing the counter data via xmlrpc which is great for attaching an external tool to build statistics. Unfortunately Kamailio KEX module is counting every single request/reply hitting the proxy server, the idea is to have the above stats related to the gateways currently loaded by the lcr module. In this way, for example I can tell how many request/replies I got from gw id X or gw id Y and produce gw based stats. Unfortunately the KEX module has no "concept" of "GW" and "LCR", so the idea is to implement the same counting logic inside LCR module. The counting should not be persistent (counters must go to zero every time kamailio restarts). When adding or deleting a new gateway, the counting in memory must reflect the status of the internal state or lcr gatewas, so, for example, after adding a new gateway and reloading lcr tables, the new counters must be immediately available through xmlrpc without a new kamailio restart. The same concept applies when the gateway is removed from the list. ### Expected behavior A possible implementation should give the user to query counters in a way similar to this: ``` # kamcmd lcr.stats { gw: { { gw_id: <id of lcr mysql table here> gw_name: <description of lcr mysql table here> requests: 0 requests_invite: 0 requests_cancel: 0 ... } { gw_id: <id of lcr mysql table here> gw_name: <description of lcr mysql table here> requests: 0 requests_invite: 0 requests_cancel: 0 ... } } } ``` Additionally, it would be helpful to set a gw id as argument in order to filter, for example: ``` # kamcmd lcr.stats 95 { gw: { { gw_id: 95 gw_name: <description of gw id 95> requests: 222 requests_invite: 1 requests_cancel: 1 requests_ack: 1 ... } } } ``` #### Actual observed behavior To my knowledge, nothing related to this issue has been implemented in Kamailio so far -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3372 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3372(a)github.com>

3 6

[kamailio/kamailio] lcr: add counters per gateway (PR #3391)
by Alessio Garzi 14 Mar '23

14 Mar '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3372 #### Description Implementing the suggesting lcr counters per gateway You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3391 -- Commit Summary -- * lcr: add counters per gateway -- File Changes -- M src/modules/lcr/lcr_mod.c (306) M src/modules/lcr/lcr_mod.h (52) M src/modules/lcr/lcr_rpc.c (460) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3391.patch https://github.com/kamailio/kamailio/pull/3391.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3391 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3391(a)github.com>

3 10

git:master:6e032019: nat_transversal: fix warning introduced at f301ca9cdcc044dd05e9d82139e1db368be6dc5c
by Victor Seva 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 6e032019d992625abc2a3739423df9ea1c964356 URL: https://github.com/kamailio/kamailio/commit/6e032019d992625abc2a3739423df9e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-14T12:01:32+01:00 nat_transversal: fix warning introduced at f301ca9cdcc044dd05e9d82139e1db368be6dc5c > nat_traversal.c: In function 'get_register_expire': > ../../core/parser/../dprint.h:321:73: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'long unsigned int' [-Wformat=] > 321 | fprintf(stderr, "%2d(%d) %s: %.*s%s%s%s" fmt, \ > | ^~~~~~~~~~~~~~~~~~~~~~~~ --- Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/6e032019d992625abc2a3739423df9e… Patch: https://github.com/kamailio/kamailio/commit/6e032019d992625abc2a3739423df9e… --- diff --git a/src/modules/nat_traversal/nat_traversal.c b/src/modules/nat_traversal/nat_traversal.c index d659aced45..d21a8b7e01 100644 --- a/src/modules/nat_traversal/nat_traversal.c +++ b/src/modules/nat_traversal/nat_traversal.c @@ -923,7 +923,7 @@ static time_t get_register_expire( } } - LM_DBG("maximum expire for all contacts: %llu\n", (uint64_t)expire); + LM_DBG("maximum expire for all contacts: %lu\n", (uint64_t)expire); return (expire ? expire + now : 0); }

1 0

git:master:ebfacdb7: core: tmrec fix build warning introduced at dd6339f817822cd0590aec2a9a467330bde499dd
by Victor Seva 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: ebfacdb7d7c3dfceb68e9550eec72b89d695fd4b URL: https://github.com/kamailio/kamailio/commit/ebfacdb7d7c3dfceb68e9550eec72b8… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-14T12:07:27+01:00 core: tmrec fix build warning introduced at dd6339f817822cd0590aec2a9a467330bde499dd > core/utils/tmrec.c: In function 'ac_print': > core/utils/tmrec.c:275:32: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] > 275 | printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, > | ~~~^ ~~~~~~~~~~~~~~~~~~~~ > | | | > | long long unsigned int long unsigned int > | %lu --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/ebfacdb7d7c3dfceb68e9550eec72b8… Patch: https://github.com/kamailio/kamailio/commit/ebfacdb7d7c3dfceb68e9550eec72b8… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index adae68edbf..205866163f 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -272,7 +272,7 @@ int ac_print(ac_tm_t *_atp) return -1; } - printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, + printf("\nSys time: %lu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, _atp->t.tm_hour, _atp->t.tm_min, _atp->t.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_atp->t.tm_wday], _atp->t.tm_year+1900, _atp->t.tm_mon+1, _atp->t.tm_mday); @@ -512,15 +512,15 @@ int tr_print(tmrec_t *_trp) return -1; } printf("Recurrence definition\n-- start time ---\n"); - printf("Sys time: %llu\n", (uint64_t)_trp->dtstart); + printf("Sys time: %lu\n", (uint64_t)_trp->dtstart); printf("Time: %02d:%02d:%02d\n", _trp->ts.tm_hour, _trp->ts.tm_min, _trp->ts.tm_sec); printf("Date: %s, %04d-%02d-%02d\n", _wdays[_trp->ts.tm_wday], _trp->ts.tm_year+1900, _trp->ts.tm_mon+1, _trp->ts.tm_mday); printf("---\n"); - printf("End time: %llu\n", (uint64_t)_trp->dtend); - printf("Duration: %llu\n", (uint64_t)_trp->duration); - printf("Until: %llu\n", (uint64_t)_trp->until); + printf("End time: %lu\n", (uint64_t)_trp->dtend); + printf("Duration: %lu\n", (uint64_t)_trp->duration); + printf("Until: %lu\n", (uint64_t)_trp->until); printf("Freq: %d\n", (int)_trp->freq); printf("Interval: %d\n", (int)_trp->interval); if(_trp->byday)

1 0

git:master:781ee072: lcr: fix building warnings initializating values
by Victor Seva 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 781ee072593f16a100ef00b5ef71fcfd6f8ded2b URL: https://github.com/kamailio/kamailio/commit/781ee072593f16a100ef00b5ef71fcf… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-14T11:55:34+01:00 lcr: fix building warnings initializating values > https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… > [...] > lcr_mod.c:2630:9: warning: 'tmp_tag.len' may be used uninitialized [-Wmaybe-uninitialized] --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/781ee072593f16a100ef00b5ef71fcf… Patch: https://github.com/kamailio/kamailio/commit/781ee072593f16a100ef00b5ef71fcf… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index b668160cb33..80b62f5d4c7 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -2526,10 +2526,21 @@ static int generate_uris(struct sip_msg *_m, char *r_uri, str *r_uri_user, { int_str gw_uri_val; struct usr_avp *gu_avp; - str scheme, prefix, hostname, port, params, transport, addr_str, tmp_tag; + str scheme = STR_NULL; + str prefix = STR_NULL; + str hostname = STR_NULL; + str port = STR_NULL; + str params = STR_NULL; + str transport = STR_NULL; + str addr_str = STR_NULL; + str tmp_tag = STR_NULL; char *at; - unsigned int strip; + unsigned int strip = 0; + if(!tag) { + LM_ERR("tag parameter is empty\n"); + return -1; + } gu_avp = search_first_avp(gw_uri_avp_type, gw_uri_avp, &gw_uri_val, 0); if(!gu_avp)

1 0

Re: [kamailio/kamailio] nat_traversal: cast to uint64_t when using time_t value (f301ca9)
by Victor Seva 14 Mar '23

14 Mar '23

From https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… ``` nat_traversal.c: In function 'get_register_expire': ../../core/parser/../dprint.h:321:73: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'long unsigned int' [-Wformat=] 321 | fprintf(stderr, "%2d(%d) %s: %.*s%s%s%s" fmt, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ ../../core/parser/../dprint.h:345:25: note: in expansion of macro 'LOG_FX' 345 | LOG_FX(facility, level, lname, prefix, _FUNC_NAME_, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:351:25: note: in expansion of macro 'LOG_FL' 351 | LOG_FL(facility, level, NULL, prefix, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:354:25: note: in expansion of macro 'LOG_FP' 354 | LOG_FP(DEFAULT_FACILITY, (level), LOC_INFO, fmt, ## args) | ^~~~~~ ../../core/parser/../dprint.h:401:45: note: in expansion of macro 'LOG' 401 | # define DBG(fmt, args...) LOG(L_DBG, fmt , ## args) | ^~~ ../../core/parser/../dprint.h:405:36: note: in expansion of macro 'DBG' 405 | # define DEBUG(fmt, args...) DBG(fmt , ## args) | ^~~ ../../core/parser/../dprint.h:422:16: note: in expansion of macro 'DEBUG' 422 | #define LM_DBG DEBUG | ^~~~~ nat_traversal.c:926:9: note: in expansion of macro 'LM_DBG' 926 | LM_DBG("maximum expire for all contacts: %llu\n", (uint64_t)expire); | ^~~~~~ ``` @miconda same here -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/f301ca9cdcc044dd05e9d82139e1db3… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/f301ca9cdcc044dd05e9d82139e1db368be6dc5c/104360216(a)github.com>

1 0

Re: [kamailio/kamailio] core: sruid - cast to uint64_t when using time_t value (33b3193)
by Victor Seva 14 Mar '23

14 Mar '23

From https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=… ``` core/utils/tmrec.c: In function 'ac_print': core/utils/tmrec.c:275:32: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 275 | printf("\nSys time: %llu\nTime: %02d:%02d:%02d\n", (uint64_t)_atp->time, | ~~~^ ~~~~~~~~~~~~~~~~~~~~ | | | | long long unsigned int long unsigned int | %lu core/utils/tmrec.c: In function 'tr_print': core/utils/tmrec.c:515:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 515 | printf("Sys time: %llu\n", (uint64_t)_trp->dtstart); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:521:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 521 | printf("End time: %llu\n", (uint64_t)_trp->dtend); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:522:30: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 522 | printf("Duration: %llu\n", (uint64_t)_trp->duration); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu core/utils/tmrec.c:523:27: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] 523 | printf("Until: %llu\n", (uint64_t)_trp->until); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~ | | | | | long unsigned int | long long unsigned int | %lu ``` @miconda it seems we need just ``%lu`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/33b319353a097ba8fd80e45dc4f008c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/33b319353a097ba8fd80e45dc4f008c2e9dfe813/104359936(a)github.com>

1 0

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)
by Guille0007 12 Mar '23

12 Mar '23

Thanks Herle for your answer, And indeed I made it work using your scripts. Where you only rewrite SDP Offer on Orig Invite and SDP Answer on Terminating183 Session Progress. And where it does not work anymore when you try to rewrite SDP offer at both Orig and Term Invite and SDP Answer on both Orig and term 183 Session Progress. Which is what would happen when *IMS *core uses a separate VRF from access. But anyway, thanks for your answer and thank you for the dockerized environment you made available to test VoLTE with Kamailio. Regards Le dim. 12 mars 2023 à 13:01, Supreeth Herle ***(a)***.***> a écrit : > Hey @Guille0007 <https://github.com/Guille0007> > > I cant recollect completely about the AAR fix I did. But, AAR works in the > docker_open5gs repo for a call. > > — > Reply to this email directly, view it on GitHub > <https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab…>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6NCYHDHEGSLIASOJ4C5FPLW3…> > . > You are receiving this because you were mentioned.Message ID: > <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104093331 > @github.com> > -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104131881(a)github.com>

1 0

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)
by Supreeth Herle 12 Mar '23

12 Mar '23

Hey @Guille0007 I cant recollect completely about the AAR fix I did. But, AAR works in the docker_open5gs repo for a call. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/104093331(a)github.com>

1 0

[kamailio/kamailio] Modified ruri-user and dispatcher failover (Issue #3388)
by mtryfoss 11 Mar '23

11 Mar '23

### Description We've got a situation where we use t_send_reply() to generate early 100 Trying, before an operation that might have a small delay. The result of this operation might lead to a change which adds parameters to ruri-user. This works as expected for normal operations, but when calling ds_next_dst()/ds_next_domain() the change to $rU is lost. ### Troubleshooting I then noticed that this is because t_send_reply() indirectly does a t_newtran() before change to $rU. If it's done in the opposite order, everything works as expected. A workaround is to use for example sl_send_reply() and t_set_auto_inv_100(0), which works for me. However, I'm unsure if this revert of user is expected behaviour? #### Reproduction $rU = $rU + ";npdi"; .. ds_select_dst(..); then trigger a condition which executes failure_route and then use ds_next_dst() to fork serially. $rU is then reverted to the original value in outgoing INVITE. ### Additional Information Reproduced in master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3388 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3388(a)github.com>

2 3

Re: [kamailio/kamailio] Fix for incorrect Flow-description in AAR Media (1a1c2cf)
by Guille0007 10 Mar '23

10 Mar '23

Hello Herlesupreth, I am struggling with pcscf Rx. At termination, PCSCF seems to request QoS for a flow between the IP/port of the SDP offer it receives and the IP/Port of the SDP Answer it receives. While it should request QoS for a flow between the IP/Port of the SDP offer it generates (after rewriting SDP) and the IP/Port of the SDP answer it receives from B. Is it why in the rtp.cfg from https://github.com/herlesupreeth/docker_open5gs you do not invoke rtpmanage on invite at termination? Does the fix you posted there solve that? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/1a1c2cf5dcea517a49438e8c29ecaab7b89b386a/103929108(a)github.com>

1 0

KEMI python 'KSR' has no attribute 'sanity'
by agural5＠gmail.com 10 Mar '23

10 Mar '23

Hello, I am trying to use KEMI KSR.sanity in python but got error: AttributeError: module 'KSR' has no attribute 'sanity' appreciate your help for solve this. Thanks!

3 2

[kamailio/kamailio] auth_ephemeral: fix authentication with secrets added at runtime (PR #3390)
by Dennis 10 Mar '23

10 Mar '23

- proper way to work with shm pointer to secret list   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description In case of adding secrets at runtime with autheph.add_secret rpc, authentication with new secrets not work, this is because rpc process modify local pointer to secret list, instead shm. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3390 -- Commit Summary -- * auth_ephemeral: fix authentication with secrets added at runtime -- File Changes -- M src/modules/auth_ephemeral/auth_ephemeral_mod.c (48) M src/modules/auth_ephemeral/auth_ephemeral_mod.h (1) M src/modules/auth_ephemeral/authorize.c (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3390.patch https://github.com/kamailio/kamailio/pull/3390.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3390 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3390(a)github.com>

3 6

git:master:6fa5a8fa: auth_ephemeral: fix authentication with secrets added at runtime (#3390)
by GitHub 10 Mar '23

10 Mar '23

Module: kamailio Branch: master Commit: 6fa5a8fa8ddfe09bdab2fb445bee94e51d86b7fc URL: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e… Author: Dennis <dennis_y(a)mail.ru> Committer: GitHub <noreply(a)github.com> Date: 2023-03-10T15:46:21+01:00 auth_ephemeral: fix authentication with secrets added at runtime (#3390) * auth_ephemeral: fix authentication with secrets added at runtime - proper way to work with shm pointer to secret list * fix: free secret_struct shm Free shm secret_struct in case the allocation error of secret_list pointer. --- Modified: src/modules/auth_ephemeral/auth_ephemeral_mod.c Modified: src/modules/auth_ephemeral/auth_ephemeral_mod.h Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e… Patch: https://github.com/kamailio/kamailio/commit/6fa5a8fa8ddfe09bdab2fb445bee94e…

1 0

git:master:e3b8b76d: utils/kamctl: allow the definition of a specific startup file at start process
by Daniel-Constantin Mierla 10 Mar '23

10 Mar '23

Module: kamailio Branch: master Commit: e3b8b76d7a8773af4e10ce011682931429cd4a87 URL: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… Author: Gustavo Almeida <gustavo.abcdef(a)hotmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-10T15:38:33+01:00 utils/kamctl: allow the definition of a specific startup file at start process - Added the possibility to specify an alternative file different from the default: kamailio.cfg, when starting kamailio, using the kamctl tool. This makes it possible to start kamailio by passing a startup file located in a specific folder (via ETCDIR env variable) and with a specific name, instead of using the default name: kamailio.cfg. --- Modified: utils/kamctl/kamctl Modified: utils/kamctl/kamctlrc --- Diff: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… Patch: https://github.com/kamailio/kamailio/commit/e3b8b76d7a8773af4e10ce011682931… --- diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index fbb237eb00..214cd21e5a 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -73,6 +73,10 @@ if [ -z "$MYLIBDIR" ] ; then fi fi +if [ -z "$STARTUP_CONFIG_FILE" ]; then + STARTUP_CONFIG_FILE="kamailio.cfg" +fi + ##### ------------------------------------------------ ##### ### load base functions # @@ -2007,9 +2011,9 @@ kamailio_start() { exit 1 fi if [ $SYSLOG = 1 ] ; then - $KAMBIN -P $PID_FILE -f $ETCDIR/kamailio.cfg $STARTOPTIONS 1>/dev/null 2>/dev/null + $KAMBIN -P $PID_FILE -f $ETCDIR/$STARTUP_CONFIG_FILE $STARTOPTIONS 1>/dev/null 2>/dev/null else - $KAMBIN -P $PID_FILE -E -f $ETCDIR/kamailio.cfg $STARTOPTIONS + $KAMBIN -P $PID_FILE -E -f $ETCDIR/$STARTUP_CONFIG_FILE $STARTOPTIONS fi sleep 3 if [ ! -s $PID_FILE ] ; then diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index fe9cc1fc48..ce0bd9d93b 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -159,6 +159,10 @@ ## PID file path - default is: /run/kamailio/kamailio.pid # PID_FILE=/run/kamailio/kamailio.pid +## Kamailio Startup Configuration File +## Default is: kamailio.cfg +# STARTUP_CONFIG_FILE=kamailio.cfg + ## Extra start options - default is: not set ## example: start Kamailio with 64MB shared memory: STARTOPTIONS="-m 64" # STARTOPTIONS=

1 0

[kamailio/kamailio] utils/kamctl: allow the definition of a specific startup file at star… (PR #3387)
by Gustavo Almeida 10 Mar '23

10 Mar '23

#### Pre-Submission Checklist    - [x ] Commit message has the format required by CONTRIBUTING guide - [x ] Commits are split per component (core, individual modules, libs, utils, ...) - [x ] Each component has a single commit (if not, squash them into one commit) - [x ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x ] PR should be backported to stable branches - [x ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added the possibility to specify an alternative file different from the default: `kamailio.cfg`, when starting `kamailio`, using the `kamctl` tool. This makes it possible to start `kamailio` by passing a startup file located in a specific folder (via `ETCDIR` env variable) and with a specific name, instead of using the default name: `kamailio.cfg`. Several local tests have been performed and it has been verified that it is now possible to perform the basic start/stop/restart operations of `kamailio` via `kamctl`, considering the use of a startup file other than the default: `kamailio.cfg`. Example of `.kamctlrc` used: ```sh ETCDIR="/etc/my-component/confs" RPCFIFOPATH="/run/my-component/my-component_rpc.fifo" PID_FILE="/run/my-component/my-component.pid" STARTUP_CONFIG_FILE="starter.cfg" STARTOPTIONS="-m 512 -M 64 -u user -g group" ``` Tested on `CentOS Linux release 7.9.2009 (Core)`. I think this change will be interesting for many users. Thanks You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3387 -- Commit Summary -- * utils/kamctl: allow the definition of a specific startup file at start process -- File Changes -- M utils/kamctl/kamctl (8) M utils/kamctl/kamctlrc (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3387.patch https://github.com/kamailio/kamailio/pull/3387.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3387 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3387(a)github.com>

3 4

Handling socket packet reception time (SO_TIMESTAMPNS) in Kamailio - possible new feature ?
by Chaigneau, Nicolas 09 Mar '23

09 Mar '23

Hello, I'm interested in retrieving the reception time, in the UDP buffer, of the SIP packets handled by Kamailio. I see there is a "struct timeval tval" in "struct sip_msg", but this is the timestamp of reading the packet by Kamailio, so not what I'm looking for. According to the kernel documentation, this could be achieved using SO_TIMESTAMPNS on the socket: https://www.kernel.org/doc/Documentation/networking/timestamping.txt Do you think adding this feature to Kamailio could be useful ? To implement this we would need, I think: - Only buid this if SO_TIMESTAMPNS is supported (Linux >= 2.6.22) - Add a configuration to enable / disable this feature - Set the SO_TIMESTAMPNS flag when creating the socket - Add a field in "struct sip_msg" to store the new timestamp - When receiving a packet, read the ancillary data, extract the SO_TIMESTAMPNS information and store the timestamp in "struct sip_msg" - Provide a new PV to make this accessible from Kamailio script What do you think ? Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.

1 0

[kamailio/kamailio] kamailio 5.2.3(commit c36229) crash at free_cell_helper (Issue #3379)
by polite 08 Mar '23

08 Mar '23

### Description kamailio 5.2.3 crash at free_cell_helper ### Troubleshooting #### Reproduction This cannot be reproduced at will. #### Debugging Data ``` [root@VM-110-141-centos /data/coredump]# gdb -c core_kamailio_1676550458 /usr/local/services/kamailio/sbin/kamailio GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-120.tl2 Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /usr/local/services/kamailio/sbin/kamailio...done. [New LWP 4452] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Missing separate debuginfo for /usr/local/services/kamailio/lib64/kamailio/libjansson.so.4 Try: yum --enablerepo='*debug*' install /usr/lib/debug/.build-id/fc/cf02c89115bf860ddba32e8b703205ffeeabf1.debug Core was generated by `/usr/local/services/kamailio/sbin/kamailio -f /usr/local/services/kamailio/etc/'. Program terminated with signal 11, Segmentation fault. #0 0x00007f8ede8e113a in free_cell_helper (dead_cell=0x7f8eb7dcb1b8, silent=0, fname=0x7f8ede9ece02 "timer.c", fline=689) at h_table.c:182 182 h_table.c: No such file or directory. Missing separate debuginfos, use: debuginfo-install bash-4.2.46-34.tl2.3.x86_64 cyrus-sasl-lib-2.1.26-23.el7.x86_64 glibc-2.17-323.tl2.x86_64 keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-51.tl2.x86_64 libcom_err-1.42.9-19.tl2.x86_64 libcurl-7.29.0-59.tl2.1.x86_64 libevent-2.0.21-4.el7.x86_64 libgcc-4.8.5-44.tl2.1.x86_64 libidn-1.28-4.el7.x86_64 libselinux-2.5-15.tl2.x86_64 libssh2-1.8.0-4.tl2.x86_64 libstdc++-4.8.5-44.tl2.1.x86_64 mariadb-libs-5.5.68-1.tl2.x86_64 nspr-4.32.0-1.tl2.x86_64 nss-3.67.0-4.tl2.x86_64 nss-softokn-freebl-3.67.0-3.tl2.x86_64 nss-util-3.67.0-1.tl2.x86_64 openldap-2.4.44-24.tl2.x86_64 openssl-libs-1.0.2k-22.tl2.1.x86_64 pcre-8.32-17.el7.x86_64 python-libs-2.7.5-90.tl2.1.x86_64 zlib-1.2.7-19.tl2.x86_64 (gdb) bt full #0 0x00007f8ede8e113a in free_cell_helper (dead_cell=0x7f8eb7dcb1b8, silent=0, fname=0x7f8ede9ece02 "timer.c", fline=689) at h_table.c:182 b = 0x7f8ede8decc4 <futex_release+29> "\211E\374\203}\374\002\017\224\300\017\266\300H\205\300t3H\213E\350\307\004$" i = 1 rpl = 0x7fffb5166580 tt = 0x7fffb51665a0 foo = 0x100000000 cbs = 0x7f8e00000001 cbs_tmp = 0x7f8e00000001 __FUNCTION__ = "free_cell_helper" #1 0x00007f8ede99381e in wait_handler (ti=367281959, wait_tl=0x7f8eb7dcb240, data=0x7f8eb7dcb1b8) at timer.c:689 p_cell = 0x7f8eb7dcb1b8 ret = 3080640456 unlinked = 0 rcount = 1 __FUNCTION__ = "wait_handler" #2 0x0000000000487769 in timer_list_expire (t=367281959, h=0x7f8eb7a318a8, slow_l=0x7f8eb7a34d70, slow_mark=42793) at core/timer.c:874 tl = 0x7f8eb7dcb240 ret = 0 #3 0x0000000000487bca in timer_handler () at core/timer.c:939 saved_ticks = 367281959 run_slow_timer = 0 i = 809 __FUNCTION__ = "timer_handler" #4 0x0000000000488074 in timer_main () at core/timer.c:978 No locals. #5 0x0000000000425a31 in main_loop () at main.c:1727 i = 8 pid = 0 si = 0x0 si_desc = "udp receiver child=7 sock=11.177.110.141:35560\000(175.27.32.249:15060)\000\177\000\000\223U{\000\000\000\000\000-\000\000\000\000\000\000\000\000\000\000 \000\000\000\000\000\000\000\004\000\000\000\000\257*\245\346\216\177\000\000\360\260y\000\000\000\000\000\000\227\265\342\216\177\000" nrprocs = 8 woneinit = 1 __FUNCTION__ = "main_loop" #6 0x000000000042c72d in main (argc=13, argv=0x7fffb5166bd8) at main.c:2696 cfg_stream = 0xfdc010 c = -1 r = 0 tmp = 0x7fffb5168757 "" tmp_len = 0 port = 0 proto = 2496 options = 0x76a700 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 99772630 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x7fffb5166a90 p = 0x7f8ee6a00d2d <intel_check_word+173> "H\205\300t\025\017\266P\003\017\266\312D9\371\017\204\316" st = {st_dev = 21, st_ino = 32759713, st_nlink = 2, st_mode = 16877, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1671615993, tv_nsec = 68240759}, st_mtim = {tv_sec = 1671620803, tv_nsec = 306084978}, st_ctim = {tv_sec = 1671620803, tv_nsec = 306084978}, __unused = {0, 0, 0}} __FUNCTION__ = "main" (gdb) info locals cfg_stream = 0xfdc010 c = -1 r = 0 tmp = 0x7fffb5168757 "" tmp_len = 0 port = 0 proto = 2496 options = 0x76a700 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 99772630 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x7fffb5166a90 p = 0x7f8ee6a00d2d <intel_check_word+173> "H\205\300t\025\017\266P\003\017\266\312D9\371\017\204\316" st = {st_dev = 21, st_ino = 32759713, st_nlink = 2, st_mode = 16877, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1671615993, tv_nsec = 68240759}, st_mtim = {tv_sec = 1671620803, tv_nsec = 306084978}, st_ctim = {tv_sec = 1671620803, tv_nsec = 306084978}, __unused = {0, 0, 0}} __FUNCTION__ = "main" (gdb) list 177 in h_table.c (gdb) ``` #### Log Messages kamailio.log ``` Feb 16 20:27:33 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4434]: INFO: {10 OPTIONS 3c7f4fb43ea4086d-4451(a)11.177.110.141} <script>: keepalive-host is up: OPTIONS sip:9.137.223.152:50180 (<null>) Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4425]: ALERT: <core> [main.c:756]: handle_sigs(): child process 4452 exited by a signal 11 Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4425]: ALERT: <core> [main.c:759]: handle_sigs(): core was generated Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4425]: INFO: <core> [main.c:781]: handle_sigs(): terminating due to SIGCHLD Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4470]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4469]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4462]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4466]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4467]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4468]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4464]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4449]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4460]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4465]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4461]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4440]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4459]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4429]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4457]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4430]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4456]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4442]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4432]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4458]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4437]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4444]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4463]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4439]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4454]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4434]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4448]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4451]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4436]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4447]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4450]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4435]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4431]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4441]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4446]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4428]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4445]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4427]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4453]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4438]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4455]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4433]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4443]: INFO: <core> [main.c:836]: sig_usr(): signal 15 received Feb 16 20:27:41 VM-110-141-centos /usr/local/services/kamailio/sbin/kamailio[4425]: CRITICAL: <core> [core/mem/q_malloc.c:137]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f8eb7d04778 (address 0x7f8eb7d047b0) end overwritten (1, abcdefed)! Memory allocator was called from dialplan: dp_db.c:687. Fragment marked by dialplan: dp_db.c:400. Exec from core/mem/q_malloc.c:504. ``` messages ``` [Thu Feb 16 20:27:44 2023] kamailio[4452]: segfault at 7f8e00000021 ip 00007f8ede8e113a sp 00007fffb51664a0 error 4 in tm.so[7f8ede8c5000+13a000] ``` #### SIP Traffic ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@VM-110-141-centos /usr/local/services/kamailio/sbin]# ./kamailio -version version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 compiled on 16:50:57 Jul 16 2019 with gcc 4.8.5 ``` * **Operating System**: ``` [root@VM-110-141-centos /data/coredump]# uname -a Linux VM-110-141-centos 4.14.105-1-tlinux3-0023 #1 SMP Mon Jan 10 18:17:33 CST 2022 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3379 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3379(a)github.com>

2 2

git:master:b15db86e: sqlops: do not allow empty name component in URL
by Henning Westerholt 06 Mar '23

06 Mar '23

Module: kamailio Branch: master Commit: b15db86e93120824dcfc879099432f3ec1c3b0c7 URL: https://github.com/kamailio/kamailio/commit/b15db86e93120824dcfc879099432f3… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-06T10:44:19Z sqlops: do not allow empty name component in URL --- Modified: src/modules/sqlops/sql_api.c --- Diff: https://github.com/kamailio/kamailio/commit/b15db86e93120824dcfc879099432f3… Patch: https://github.com/kamailio/kamailio/commit/b15db86e93120824dcfc879099432f3… --- diff --git a/src/modules/sqlops/sql_api.c b/src/modules/sqlops/sql_api.c index 237ddd8c1e..eaa03de6fd 100644 --- a/src/modules/sqlops/sql_api.c +++ b/src/modules/sqlops/sql_api.c @@ -677,6 +677,9 @@ int sql_parse_param(char *val) if(p>in.s+in.len || *p=='\0') goto error; name.len = p - name.s; + if(name.len==0) { + goto error; + } if(*p!='=') { while(p<in.s+in.len && (*p==' ' || *p=='\t' || *p=='\n' || *p=='\r'))

1 0

Kamailio v5.5.6 Released
by Daniel-Constantin Mierla 02 Mar '23

02 Mar '23

Hello, Kamailio SIP Server v5.5.6 stable release is out. This is a maintenance release of the stable branch 5.5 that includes fixes since the release of v5.5.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.5.x. Deployments running previous v5.5.x versions are strongly recommended to be upgraded to v5.5.6. Note that 5.5 is the second last stable branch, still officially maintained by Kamailio development team. The latest stable branch is 5.6, with v5.6.4 being release out of it. For more details about version 5.5.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2023/03/kamailio-v5-5-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com Kamailio Advanced Training - Online - March 27-30, 2023 - www.asipto.com

1 0

git:5.5:72dbb099: ChangeLog: content updated for v5.5.6
by Daniel-Constantin Mierla 02 Mar '23

02 Mar '23

Module: kamailio Branch: 5.5 Commit: 72dbb099774a57393106d2101d990ed8557dbdc6 URL: https://github.com/kamailio/kamailio/commit/72dbb099774a57393106d2101d990ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-02T11:26:18+01:00 ChangeLog: content updated for v5.5.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/72dbb099774a57393106d2101d990ed… Patch: https://github.com/kamailio/kamailio/commit/72dbb099774a57393106d2101d990ed…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev