I use Kamailio with `log_stderror=yes`. When Kamailio receives confirmation from the Websocket reverse proxy, it logs on stderr
```
23(24) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 22)
23(24) ERROR: <core> [core/parser/msg_parser.c:749]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 101 Switching Protocols
Sia: SIP/2.0/TCP 111.11.111.11:47418
Sec-WebSocket-Protocol: sip
Upgrade: websocket
Connection: upgrade
Sec-WebSocket-Accept: Ak3/c/aw3iyHnFkDDHabw1iXcqY=
Content-Length: 0
>
23(24) ERROR: <core> [core/msg_translator.c:3256]: build_sip_msg_from_buf(): parsing failed
```
Without the included `\n` here the subsequent messages are logged on the same line as `parsing failed`.
For the record, I use this NGINX configuration:
```
location /sip {
proxy_http_version 1.1;
proxy_set_header "Accept-Encoding" ""; # delete header before sending it to Kamailio
proxy_set_header "Pragma" "";
proxy_set_header "Cache-control" "";
proxy_set_header "User-Agent" "";
proxy_set_header Host $host;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;
proxy_pass http://123.12.123.12:5060;
proxy_read_timeout 86400;
}
```
and it leads to that unparsable message above.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3348
-- Commit Summary --
* core: msg_translator.c put new line after «parsing failed» error message
-- File Changes --
M src/core/msg_translator.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3348.patchhttps://github.com/kamailio/kamailio/pull/3348.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3348
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3348(a)github.com>
Module: kamailio
Branch: master
Commit: 51fa3da96c1eacd4d679598a3305180c9e818cfb
URL: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-03T09:28:58+01:00
core: typos in comments and EoL after log when parse msg fails
- GH #3348
---
Modified: src/core/msg_translator.c
---
Diff: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
Patch: https://github.com/kamailio/kamailio/commit/51fa3da96c1eacd4d679598a3305180…
---
diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c
index bc1b9736df..3ab6fae472 100644
--- a/src/core/msg_translator.c
+++ b/src/core/msg_translator.c
@@ -53,7 +53,7 @@
* lookup is performed on the host part and the reply is sent to the
* resulting ip. If a port is present or the host part is an ip address
* the dns lookup will be a "normal" one (A or AAAA).
- * - if rport is present, it's value will be used as the destination port
+ * - if rport is present, its value will be used as the destination port
* (and this will also disable srv lookups)
* - if no port is present the destination port will be taken from the srv
* lookup. If the srv lookup fails or is not performed (e.g. ip address
@@ -1459,7 +1459,7 @@ void process_lumps( struct sip_msg* msg,
/* skip len bytes from orig msg */
s_offset+=t->len;
} else if (t->op==LUMP_DEL && flag == FLAG_MSG_LUMPS_ONLY) {
- /* copy lump value and indent as necessarely */
+ /* copy lump value and indent as necessarily */
memcpy(new_buf+offset, orig + t->u.offset, t->len);
offset+=t->len;
if (new_buf[offset-1] != '\n') {
@@ -1592,7 +1592,7 @@ static inline int adjust_clen(struct sip_msg* msg, int body_delta, int proto)
/* The body has been changed, try to find
* existing Content-Length
*/
- /* no need for Content-Length if it's and UDP packet and
+ /* no need for Content-Length if it's an UDP packet and
* it hasn't Content-Length already */
if (msg->content_length==0){
/* content-length doesn't exist, append it */
@@ -1938,7 +1938,7 @@ int check_boundaries(struct sip_msg *msg, struct dest_info *send_info)
/** builds a request in memory from another sip request.
*
* Side-effects: - it adds lumps to the msg which are _not_ cleaned.
- * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENLENGTH_T
+ * The added lumps are HDR_VIA_T (almost always added), HDR_CONTENTLENGTH_T
* and HDR_ROUTE_T (when a Route: header is added as a result of a non-null
* msg->path_vec).
* - it might change send_info->proto and send_info->send_socket
@@ -2109,7 +2109,7 @@ char * build_req_buf_from_sip_req(struct sip_msg* msg,
}
received_buf = NULL;
}
- /* if rport needs to be updated, delete it if present and add it's value */
+ /* if rport needs to be updated, delete it if present and add its value */
if (rport_buf){
if (msg->via1->rport){ /* rport already present */
via_insert_param=del_lump(msg,
@@ -3075,7 +3075,7 @@ char* create_via_hf(unsigned int *len,
/* builds a char* buffer from message headers without body
* first line is excluded in case of skip_first_line=1
- * error is set -1 if the memory allocation failes
+ * error is set -1 if the memory allocation fails
*/
char * build_only_headers( struct sip_msg* msg, int skip_first_line,
unsigned int *returned_len,
@@ -3127,7 +3127,7 @@ char * build_only_headers( struct sip_msg* msg, int skip_first_line,
}
/* builds a char* buffer from message body
- * error is set -1 if the memory allocation failes
+ * error is set -1 if the memory allocation fails
*/
char * build_body( struct sip_msg* msg,
unsigned int *returned_len,
@@ -3253,7 +3253,7 @@ int build_sip_msg_from_buf(struct sip_msg *msg, char *buf, int len,
msg->buf = buf;
msg->len = len;
if (parse_msg(buf, len, msg)!=0) {
- LM_ERR("parsing failed");
+ LM_ERR("parsing failed\n");
return -1;
}
msg->set_global_address=default_global_address;
My reading of the original text:
> USE_NAPTR - if defined the naptr lookup support will be compiled in.
> NAPTR support still has to be enabled from Kamailio's config file (it's
> off by default).
was that USE_NAPTR was by default off (undefined). This change clarifies that by default USE_NAPTR is defined, but naptr support is by default disabled from the cofiguration file.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3353
-- Commit Summary --
* doc/tutorials/dns: USE_NAPTR is on by default
-- File Changes --
M doc/tutorials/dns.txt (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3353.patchhttps://github.com/kamailio/kamailio/pull/3353.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3353
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3353(a)github.com>
Module: kamailio
Branch: master
Commit: 8821d9a91ab3823d5b1d78d84332ab9965a7c6b2
URL: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-02-01T18:06:44+01:00
doc/tutorials/dns: USE_NAPTR is on by default
---
Modified: doc/tutorials/dns.txt
---
Diff: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
Patch: https://github.com/kamailio/kamailio/commit/8821d9a91ab3823d5b1d78d84332ab9…
---
diff --git a/doc/tutorials/dns.txt b/doc/tutorials/dns.txt
index 442f0900f6..0cfebff3f7 100644
--- a/doc/tutorials/dns.txt
+++ b/doc/tutorials/dns.txt
@@ -143,7 +143,7 @@ DNS Resolver Options
If set to yes - the additional part is checked against the search list.
The maximum time a DNS request can take (before failing) is:
- (dns_retr_time*dns_retr_no) * (search_list_domains) If dns_try_ipv6 is yes,
+ (dns_retr_time*dns_retr_no) * (search_list_domains). If dns_try_ipv6 is yes,
multiply it again by 2.
The option combination that produces the "fastest" DNS resolver config
@@ -167,8 +167,9 @@ DNS Resolver Compile Options
----------------------------
USE_NAPTR - if defined the naptr lookup support will be compiled in.
- NAPTR support still has to be enabled from Kamailio's config file (it's
- off by default).
+ NAPTR support still has to be enabled from Kamailio's config file.
+ USE_NAPTR is defined by default. NAPTR support is disabled from the
+ config file by default.
DNS Cache and Failover Config Variables
@@ -182,7 +183,7 @@ DNS Cache and Failover Config Variables
server.
Default: on.
- use_dns_failover = on |off - if on and sending a request fails (due to not
+ use_dns_failover = on | off - if on and sending a request fails (due to not
being allowed from an onsend_route, send failure, blocklisted destination
or, when using tm, invite timeout), and the destination resolves to
multiple ip addresses and/or multiple SRV records, the send will be
@@ -260,7 +261,7 @@ DNS Cache and Failover Config Variables
Default: no
dns_cache_init = on | off - if off, the DNS cache is not initialized
- at startup and cannot be enabled runtime, that saves some memory.
+ at startup and cannot be enabled at runtime, that saves some memory.
Default: on
DNS Cache Compile Options
@@ -301,7 +302,7 @@ DNS Cache Compile Options
If this option is not defined (experimental), everything in the AR
section will be added to the cache.
- Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it
+ Note: To remove a compile options, edit Kamailio's Makefile.defs and remove it
from DEFS list. To add a compile options add it to the make command line,
e.g.: make proper; make all extra_defs=-DUSE_DNS_FAILOVER
or for a permanent solution, edit Makefile.defs and add it to DEFS
On receiving:
```
BYE sip:127.3.4.84;line=sr-bkhov30ei16khxiahn60i3jelfjzcwdavb.a8bhyuzda8bbavz8ymwb4lsi0iqmoigitdx9vbqgv5fjhdb.j8wcg5x8evkyv5fyqdbnguztav1yamwha8bwqfz8ymwl28o** SIP/2.0
Route: <sip:7Vu+g0t42xO1vwWQTI5OE8SQTI5O1do=@111.11.111.11;transport=ws;r2=on;lr;nat=yes>
Route: <sip:127.3.4.84;line=sr-BkHOVzLFLnGq8S7T8q0D8Xcgo6YwnboD9b0bwo9imwMaclMU7WtTm1ygmpyamW.AmQNRmbdk8bGTB3YABgCEBq7ULlaQVg.eDFUAVkaeVkJ0LW6JcX8*>
Via: SIP/2.0/WSS 964rp9hud53v.invalid;branch=z9hG4bK47814
Max-Forwards: 70
To: <sip:99372@aegee.org>;tag=kejtvxx541
From: "Online" <sip:online@example.org>;tag=b7movp1df3
Call-ID: lo20t4jpu47jpvo9mkn1
CSeq: 5788 BYE
Supported: outbound
User-Agent: SIP.js/0.7.8
Content-Length: 0
```
Kamailio 5.6.3 logs:
```
20(21) ERROR: <core> [core/kemi.c:1573]: sr_kemi_core_to_proto_helper(): failed to parse nh uri [Of^U<B2>hr$-v`<A2>qa-a&jr^Y<FA>ce@1<B1>21168.0114<F1><B2>385D<FB>^Z<B2>a&sU'rD]
```
The logged unparsable part of nh uri is not part of the input.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3351
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3351(a)github.com>
Added Call-ID mask for Topos using API call of Topoh
Call ID mask using topoh API call instead of swapping with new ID. Call ID masking is done when a message is received from the upstream and unmasked before sending it to the upstream.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3334
-- Commit Summary --
* Topos: Added Call-ID mask
-- File Changes --
M src/modules/topos/doc/topos_admin.xml (20)
M src/modules/topos/topos_mod.c (126)
M src/modules/topos/tps_msg.c (31)
M src/modules/topos/tps_msg.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3334.patchhttps://github.com/kamailio/kamailio/pull/3334.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3334
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3334(a)github.com>
### Description
On server used WebRTC clients. Some time Kamailio start flooding messages like this
```
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
```
I have enabled debug logs and can see more detailed output.
```
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
DEBUG: websocket [ws_conn.c:485]: wsconn_put_id(): wsconn put id [49]
DEBUG: websocket [ws_conn.c:490]: wsconn_put_id(): wsc [0xffff7b4af448] refcnt [2]
DEBUG: websocket [ws_conn.c:425]: wsconn_put_mode(): wsconn_put start for [0xffff7b4af448] refcnt [2]
DEBUG: websocket [ws_conn.c:439]: wsconn_put_mode(): wsconn_put end for [0xffff7b4af448] refcnt [1]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [52]
DEBUG: websocket [ws_conn.c:467]: wsconn_get(): wsconn_get returns wsc [0xffff7b4df8f8] refcnt [2]
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
DEBUG: websocket [ws_conn.c:485]: wsconn_put_id(): wsconn put id [52]
DEBUG: websocket [ws_conn.c:490]: wsconn_put_id(): wsc [0xffff7b4df8f8] refcnt [2]
DEBUG: websocket [ws_conn.c:425]: wsconn_put_mode(): wsconn_put start for [0xffff7b4df8f8] refcnt [2]
DEBUG: websocket [ws_conn.c:439]: wsconn_put_mode(): wsconn_put end for [0xffff7b4df8f8] refcnt [1]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [61]
DEBUG: websocket [ws_conn.c:467]: wsconn_get(): wsconn_get returns wsc [0xffff7b57bfa0] refcnt [2]
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
DEBUG: websocket [ws_conn.c:485]: wsconn_put_id(): wsconn put id [61]
DEBUG: websocket [ws_conn.c:490]: wsconn_put_id(): wsc [0xffff7b57bfa0] refcnt [2]
DEBUG: websocket [ws_conn.c:425]: wsconn_put_mode(): wsconn_put start for [0xffff7b57bfa0] refcnt [2]
DEBUG: websocket [ws_conn.c:439]: wsconn_put_mode(): wsconn_put end for [0xffff7b57bfa0] refcnt [1]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [70]
DEBUG: websocket [ws_conn.c:467]: wsconn_get(): wsconn_get returns wsc [0xffff7b5cc770] refcnt [2]
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
DEBUG: websocket [ws_conn.c:485]: wsconn_put_id(): wsconn put id [70]
DEBUG: websocket [ws_conn.c:490]: wsconn_put_id(): wsc [0xffff7b5cc770] refcnt [2]
DEBUG: websocket [ws_conn.c:425]: wsconn_put_mode(): wsconn_put start for [0xffff7b5cc770] refcnt [2]
DEBUG: websocket [ws_conn.c:439]: wsconn_put_mode(): wsconn_put end for [0xffff7b5cc770] refcnt [1]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [0]
DEBUG: websocket [ws_conn.c:461]: wsconn_get(): wsconn_get for id [76]
DEBUG: websocket [ws_conn.c:467]: wsconn_get(): wsconn_get returns wsc [0xffff7b62d0d0] refcnt [2]
INFO: websocket [ws_frame.c:814]: ws_keepalive(): tcp connection has been lost
```
On the server installed commit 1d03d9e8312e6e9b494f6d243fe9b2b4ea890eaf
### Troubleshooting
I do not know.
For me it looks random.
#### Reproduction
I do not know.
For me it looks random.
#### Debugging Data
not applicable
#### Log Messages
provided above
#### SIP Traffic
not applicable
### Possible Solutions
not known
### Additional Information
* **Kamailio Version**
Used commit 1d03d9e8312e6e9b494f6d243fe9b2b4ea890eaf
* **Operating System**:
```
[root@sbc-stage-a0 kamailio]# cat /etc/os-release
NAME="CentOS Stream"
VERSION="8"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="CentOS Stream 8"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:8"
HOME_URL="https://centos.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_SUPPORT_PRODUCT_VERSION="CentOS Stream"
```
kernel
```
Linux sbc-stage-a0.nga911.com 4.18.0-365.el8.aarch64 #1 SMP Thu Feb 10 16:12:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3278
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3278(a)github.com>
https://www.kamailio.org/docs/modules/devel/modules/ims_dialog.html contains examples how to configure the module:
```
modparam("ims_dialog", "dlg_extra_hdrs", "Hint: credit expired\r\n")
modparam("ims_dialog", "detect_spirals", 1)
modparam("dialog", "profiles_with_value", "caller ; my_profile")
modparam("dialog", "profiles_no_value", "inbound ; outbound")
modparam("dialog", "bridge_controller", "sip:ctd@kamailio.org")
```
and others. As can be seen, the first parameter to modparam() is not consistent in the documentation.
In case really `dialog` shall be used, as the examples show, please spell explicitly in the documentation that `modparam("dialog"` is not a typo. Otherwise please adjust the examples.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3337
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3337(a)github.com>
Module: kamailio
Branch: master
Commit: efacfb572acdc027a35ba3104ecec080f5bfa94a
URL: https://github.com/kamailio/kamailio/commit/efacfb572acdc027a35ba3104ecec08…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-01-26T09:16:22+01:00
modules: readme files regenerated - erlang ... [skip ci]
---
Modified: src/modules/erlang/README
---
Diff: https://github.com/kamailio/kamailio/commit/efacfb572acdc027a35ba3104ecec08…
Patch: https://github.com/kamailio/kamailio/commit/efacfb572acdc027a35ba3104ecec08…
---
diff --git a/src/modules/erlang/README b/src/modules/erlang/README
index 5d69b5109e..949172cb13 100644
--- a/src/modules/erlang/README
+++ b/src/modules/erlang/README
@@ -205,7 +205,7 @@ modparam("erlang", "no_cnodes", 2)
alivename is the registered name of the Kamailio process.
- Note, if the no_cnodes greater then 1, then alivename of Kamailio
+ Note, if the no_cnodes is greater than 1, then alivename of Kamailio
process will be suffixed with number.
Example 1.2. Set cnode_alivename parameter
@@ -684,7 +684,7 @@ Chapter 2. Using Kamailio from Erlang
1. RPC calls from Erlang
This module implements the erlang transport and encoding interface for
- Kamailio RPCs. It's allow to call any exported RPC in Kamailio from
+ Kamailio RPCs. It's allowed to call any exported RPC in Kamailio from
erlang node.
The string in RPC response is binary encoded to allow from erlang side
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3339
-- Commit Summary --
* pkg: update www.kamailio.org links to HTTPS
* lib/srdb1: typos
* typos
* erlang: typos
-- File Changes --
M .github/CONTRIBUTING.md (6)
M .github/ISSUE_TEMPLATE/bug_report.md (4)
M .github/ISSUE_TEMPLATE/feature_request.md (4)
M INSTALL (10)
M README.md (6)
M pkg/kamailio/Makefile (2)
M pkg/kamailio/README.md (2)
M pkg/kamailio/alpine/APKBUILD (12)
M pkg/kamailio/deb/bionic/control (2)
M pkg/kamailio/deb/bionic/copyright (2)
M pkg/kamailio/deb/bionic/kamailio.init (2)
M pkg/kamailio/deb/bionic/rules (2)
M pkg/kamailio/deb/bionic/watch (2)
M pkg/kamailio/deb/bookworm/control (2)
M pkg/kamailio/deb/bookworm/copyright (2)
M pkg/kamailio/deb/bookworm/kamailio.init (2)
M pkg/kamailio/deb/bookworm/rules (2)
M pkg/kamailio/deb/bookworm/watch (2)
M pkg/kamailio/deb/bullseye/control (2)
M pkg/kamailio/deb/bullseye/copyright (2)
M pkg/kamailio/deb/bullseye/kamailio.init (2)
M pkg/kamailio/deb/bullseye/rules (2)
M pkg/kamailio/deb/bullseye/watch (2)
M pkg/kamailio/deb/buster/control (2)
M pkg/kamailio/deb/buster/copyright (2)
M pkg/kamailio/deb/buster/kamailio.init (2)
M pkg/kamailio/deb/buster/rules (2)
M pkg/kamailio/deb/buster/watch (2)
M pkg/kamailio/deb/debian/control (2)
M pkg/kamailio/deb/debian/copyright (2)
M pkg/kamailio/deb/debian/kamailio.init (2)
M pkg/kamailio/deb/debian/rules (2)
M pkg/kamailio/deb/debian/watch (2)
M pkg/kamailio/deb/focal/control (2)
M pkg/kamailio/deb/focal/copyright (2)
M pkg/kamailio/deb/focal/kamailio.init (2)
M pkg/kamailio/deb/focal/rules (2)
M pkg/kamailio/deb/focal/watch (2)
M pkg/kamailio/deb/jammy/control (2)
M pkg/kamailio/deb/jammy/copyright (2)
M pkg/kamailio/deb/jammy/kamailio.init (2)
M pkg/kamailio/deb/jammy/rules (2)
M pkg/kamailio/deb/jammy/watch (2)
M pkg/kamailio/deb/jessie/control (2)
M pkg/kamailio/deb/jessie/copyright (2)
M pkg/kamailio/deb/jessie/kamailio.init (2)
M pkg/kamailio/deb/jessie/rules (2)
M pkg/kamailio/deb/jessie/watch (2)
M pkg/kamailio/deb/precise/control (2)
M pkg/kamailio/deb/precise/copyright (2)
M pkg/kamailio/deb/precise/kamailio.init (2)
M pkg/kamailio/deb/precise/rules (2)
M pkg/kamailio/deb/precise/watch (2)
M pkg/kamailio/deb/sid/control (2)
M pkg/kamailio/deb/sid/copyright (2)
M pkg/kamailio/deb/sid/kamailio.init (2)
M pkg/kamailio/deb/sid/rules (2)
M pkg/kamailio/deb/sid/watch (2)
M pkg/kamailio/deb/stretch/control (2)
M pkg/kamailio/deb/stretch/copyright (2)
M pkg/kamailio/deb/stretch/kamailio.init (2)
M pkg/kamailio/deb/stretch/rules (2)
M pkg/kamailio/deb/stretch/watch (2)
M pkg/kamailio/deb/trusty/control (2)
M pkg/kamailio/deb/trusty/copyright (2)
M pkg/kamailio/deb/trusty/kamailio.init (2)
M pkg/kamailio/deb/trusty/rules (2)
M pkg/kamailio/deb/trusty/watch (2)
M pkg/kamailio/deb/wheezy/control (2)
M pkg/kamailio/deb/wheezy/copyright (2)
M pkg/kamailio/deb/wheezy/kamailio.init (2)
M pkg/kamailio/deb/wheezy/rules (2)
M pkg/kamailio/deb/wheezy/watch (2)
M pkg/kamailio/deb/xenial/control (2)
M pkg/kamailio/deb/xenial/copyright (2)
M pkg/kamailio/deb/xenial/kamailio.init (2)
M pkg/kamailio/deb/xenial/rules (2)
M pkg/kamailio/deb/xenial/watch (2)
M pkg/kamailio/gentoo/kamailio-9999.ebuild (2)
M pkg/kamailio/obs/README (2)
M pkg/kamailio/obs/kamailio.spec (6)
M src/lib/srdb1/db.h (14)
M src/lib/srdb1/db_query.c (2)
M src/lib/srdb1/db_query.h (20)
M src/lib/srdb1/db_res.h (2)
M src/lib/srdb1/db_row.c (4)
M src/lib/srdb1/db_row.h (2)
M src/lib/srdb1/db_val.c (4)
M src/lib/srdb1/db_val.h (2)
M src/lib/srdb1/schema/carrierroute.xml (2)
M src/lib/srdb1/schema/template.xml (2)
M src/modules/erlang/cnode.c (4)
M src/modules/erlang/doc/erlang_admin.xml (2)
M src/modules/erlang/doc/erlang_use.xml (2)
M src/modules/erlang/erl_api.c (2)
M src/modules/erlang/handle_emsg.c (2)
M src/modules/erlang/handle_rpc.c (2)
M src/modules/erlang/handle_rpc.h (2)
M src/modules/erlang/worker.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3339.patchhttps://github.com/kamailio/kamailio/pull/3339.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3339
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3339(a)github.com>
Module: kamailio
Branch: master
Commit: f9c3c270be33e790402834951c29d65fdf7240b6
URL: https://github.com/kamailio/kamailio/commit/f9c3c270be33e790402834951c29d65…
Author: dilyanpalauzov <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-01-26T09:08:01+01:00
INSTALL: updates to http urls and typo fixes
---
Modified: INSTALL
---
Diff: https://github.com/kamailio/kamailio/commit/f9c3c270be33e790402834951c29d65…
Patch: https://github.com/kamailio/kamailio/commit/f9c3c270be33e790402834951c29d65…
---
diff --git a/INSTALL b/INSTALL
index f1ffba91b1..5aeccba6d3 100644
--- a/INSTALL
+++ b/INSTALL
@@ -67,7 +67,7 @@ Requirements:
gcc >= 2.9x; 3.[12] recommended (it will work with older version
but it might require some options tweaking for best performance)
clang >= version 3.3
-- bison or yacc (Berkley Yacc)
+- bison or yacc (Berkeley Yacc)
- flex
- GNU make (on Linux this is the standard "make", on *BSD and Solaris it is
called "gmake") version >= 3.80 (recommended 3.81).
@@ -181,7 +181,7 @@ OS Notes:
see README of the module you want to use
Kamailio have APT deb repositories that allow you to
install the binaries easily - see the web site for more details:
- - http://kamailio.org
+ - https://kamailio.org
Cygwin (alpha state, partial support)
@@ -332,7 +332,7 @@ are grouped based on Debian packaging rules. For example:
make mode=debug PROFILE=-pg all
- compile only the print module
make modules=modules/print modules
- - compile by default only the print module, in debuging mode and with
+ - compile by default only the print module, in debugging mode and with
profiling:
make cfg modules=modules/print mode=debug PROFILE=-pg
make all
@@ -511,14 +511,14 @@ A) Getting Help
This guide gives you instructions on how to set up the Kamailio
on your box quickly. In case the default configuration does not fly, please
check the documentation at the Kamailio web site
- http://www.kamailio.org to learn how to configure Kamailio for your site.
+ https://www.kamailio.org to learn how to configure Kamailio for your site.
If the documentation does not resolve your problem you may try contacting
our user forum by E-mail at sr-users(a)lists.kamailio.org -- that is the
mailing list of the Kamailio community. To participate in the mailing list,
please subscribe at the following web address:
- https://lists.kamailio.org/cgi-bin/mailman/listinfo
+ https://lists.kamailio.org/
B) Disclaimers
Module: kamailio
Branch: master
Commit: 49c1ae28188c6df2d130a26d4180d1db4538575e
URL: https://github.com/kamailio/kamailio/commit/49c1ae28188c6df2d130a26d4180d1d…
Author: dilyanpalauzov <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-01-26T09:06:02+01:00
.github: typo fixes and updates to mailing lists links
---
Modified: .github/CONTRIBUTING.md
Modified: .github/ISSUE_TEMPLATE/bug_report.md
Modified: .github/ISSUE_TEMPLATE/feature_request.md
---
Diff: https://github.com/kamailio/kamailio/commit/49c1ae28188c6df2d130a26d4180d1d…
Patch: https://github.com/kamailio/kamailio/commit/49c1ae28188c6df2d130a26d4180d1d…
---
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index e7f1a9110c6..2c5d46842b8 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -29,7 +29,7 @@ changes to this document in a pull request.
Kamailio is a community managed project, with developers world wide. Any
contribution to code or documentation is very welcome and appreciated.
-In order to be easily able to track the changes and have a coherent ChangLog
+In order to be easily able to track the changes and have a coherent ChangeLog
and commit history, there are several *rules* required for each contribution.
## Contributing Code Or Content ##
@@ -116,7 +116,7 @@ changes were done.
At the end of the first line some CI flags can be added. Available at this
moment:
- * `[skip ci]` - skip continous integration builds for source code, recommended
+ * `[skip ci]` - skip continuous integration builds for source code, recommended
to be added when updating documentation, example configs or other utilities.
Example:
* `msilo: docs - updated example for m_dump() function [skip ci]`
@@ -270,4 +270,4 @@ released under BSD must be done under BSD as well.
For any question, do not hesitate to contact other developers via mailing list:
- * **[sr-dev [at] lists.kamailio.org](http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-d…
+ * **[sr-dev [at] lists.kamailio.org](https://lists.kamailio.org/mailman3/postorius/lists/sr-…
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
index 50a94c08bcb..e657ee1a979 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -9,11 +9,11 @@ Kamailio Project uses GitHub Issues only for bugs in the code or feature request
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
- * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
+ * https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
- * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
+ * https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
index 539adddc672..2c21427e600 100644
--- a/.github/ISSUE_TEMPLATE/feature_request.md
+++ b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -9,11 +9,11 @@ Kamailio Project uses GitHub Issues only for bugs in the code or feature request
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
- * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
+ * https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
- * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
+ * https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3343
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3343(a)github.com>
- Added warning about potential for OS Command Injection
- Updated invalid examples
previous example gives the following error:
pv_parse_spec2(): error searching pvar "rU.txt"
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Misuse of the exec module functions is a security concern. This PR updates the documentation to help Kamailio administrators use these functions securely.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3338
-- Commit Summary --
* exec: docs - added security warning
-- File Changes --
M src/modules/exec/doc/exec_admin.xml (24)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3338.patchhttps://github.com/kamailio/kamailio/pull/3338.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3338
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3338(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Expected behavior
#### Actual observed behavior
#### Debugging Data
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a improvement.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3342
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3342(a)github.com>
Module: kamailio
Branch: 5.5
Commit: f7ee24dc4fc3ffb1b6f9e4f73b63f249acd979e3
URL: https://github.com/kamailio/kamailio/commit/f7ee24dc4fc3ffb1b6f9e4f73b63f24…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-01-25T08:02:01Z
core: fix memory leak related to Require header parsing, this header also need to be freed
(cherry picked from commit 6c372bf644e1c9afa867433e5992e347c8fc4ff6)
(cherry picked from commit 3cc09ff6045c35feef5902e3cea6b313c49e8a77)
---
Modified: src/core/parser/hf.h
---
Diff: https://github.com/kamailio/kamailio/commit/f7ee24dc4fc3ffb1b6f9e4f73b63f24…
Patch: https://github.com/kamailio/kamailio/commit/f7ee24dc4fc3ffb1b6f9e4f73b63f24…
---
diff --git a/src/core/parser/hf.h b/src/core/parser/hf.h
index 8b5dfc9791..6a2d9fdae8 100644
--- a/src/core/parser/hf.h
+++ b/src/core/parser/hf.h
@@ -231,6 +231,7 @@ static inline int hdr_allocs_parse(struct hdr_field* hdr)
case HDR_PROXYAUTH_T:
case HDR_RECORDROUTE_T:
case HDR_REFER_TO_T:
+ case HDR_REQUIRE_T:
case HDR_ROUTE_T:
case HDR_RPID_T:
case HDR_SESSIONEXPIRES_T:
Module: kamailio
Branch: 5.6
Commit: 3cc09ff6045c35feef5902e3cea6b313c49e8a77
URL: https://github.com/kamailio/kamailio/commit/3cc09ff6045c35feef5902e3cea6b31…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-01-25T08:01:33Z
core: fix memory leak related to Require header parsing, this header also need to be freed
(cherry picked from commit 6c372bf644e1c9afa867433e5992e347c8fc4ff6)
---
Modified: src/core/parser/hf.h
---
Diff: https://github.com/kamailio/kamailio/commit/3cc09ff6045c35feef5902e3cea6b31…
Patch: https://github.com/kamailio/kamailio/commit/3cc09ff6045c35feef5902e3cea6b31…
---
diff --git a/src/core/parser/hf.h b/src/core/parser/hf.h
index 8b5dfc9791..6a2d9fdae8 100644
--- a/src/core/parser/hf.h
+++ b/src/core/parser/hf.h
@@ -231,6 +231,7 @@ static inline int hdr_allocs_parse(struct hdr_field* hdr)
case HDR_PROXYAUTH_T:
case HDR_RECORDROUTE_T:
case HDR_REFER_TO_T:
+ case HDR_REQUIRE_T:
case HDR_ROUTE_T:
case HDR_RPID_T:
case HDR_SESSIONEXPIRES_T:
Module: kamailio
Branch: master
Commit: 6c372bf644e1c9afa867433e5992e347c8fc4ff6
URL: https://github.com/kamailio/kamailio/commit/6c372bf644e1c9afa867433e5992e34…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2023-01-25T08:00:34Z
core: fix memory leak related to Require header parsing, this header also need to be freed
---
Modified: src/core/parser/hf.h
---
Diff: https://github.com/kamailio/kamailio/commit/6c372bf644e1c9afa867433e5992e34…
Patch: https://github.com/kamailio/kamailio/commit/6c372bf644e1c9afa867433e5992e34…
---
diff --git a/src/core/parser/hf.h b/src/core/parser/hf.h
index 8b5dfc9791..6a2d9fdae8 100644
--- a/src/core/parser/hf.h
+++ b/src/core/parser/hf.h
@@ -231,6 +231,7 @@ static inline int hdr_allocs_parse(struct hdr_field* hdr)
case HDR_PROXYAUTH_T:
case HDR_RECORDROUTE_T:
case HDR_REFER_TO_T:
+ case HDR_REQUIRE_T:
case HDR_ROUTE_T:
case HDR_RPID_T:
case HDR_SESSIONEXPIRES_T:
Module: kamailio
Branch: master
Commit: 5dabd1e7aa3574a41fc30ead60f9e3f68de0f471
URL: https://github.com/kamailio/kamailio/commit/5dabd1e7aa3574a41fc30ead60f9e3f…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-01-25T08:31:17+01:00
modules: readme files regenerated - tls ... [skip ci]
---
Modified: src/modules/tls/README
---
Diff: https://github.com/kamailio/kamailio/commit/5dabd1e7aa3574a41fc30ead60f9e3f…
Patch: https://github.com/kamailio/kamailio/commit/5dabd1e7aa3574a41fc30ead60f9e3f…
---
diff --git a/src/modules/tls/README b/src/modules/tls/README
index 21740840b4..a8b83eda17 100644
--- a/src/modules/tls/README
+++ b/src/modules/tls/README
@@ -1271,12 +1271,18 @@ modparam("tls", "renegotiation", 1)
Allow setting flags that control how the module is initialized and
works at runtime. Many flags (bits) can be set at the same time (set
- the parameter to the sum of corresponding values).
-
- If flag (bit) 1 is set (value 1), the memory management operations
- registered for TLS are wapped within a pthread mutex lock. It can be
- useful with newer versions of libssl and libcrypto, which have a more
- pthread multi-threading oriented design.
+ the parameter to the sum of corresponding values). The flags are
+ refered with 0-indexing.
+
+ If flag (bit) at index 0 is set (value 1), the memory management
+ operations registered for TLS are wapped within a pthread mutex lock.
+ It can be useful with newer versions of libssl and libcrypto, which
+ have a more pthread multi-threading oriented design.
+
+ If flag (bit) at index 1 is set (value 2), the module executes openssl
+ fork prepare API functions (see
+ https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_fork_prepare.html).
+ It is done only for openssl version greater or equal with 1.1.1.
Default value is 0.
Module: kamailio
Branch: master
Commit: 331aa5753beccd3ddb241219cf1988a506fa2de3
URL: https://github.com/kamailio/kamailio/commit/331aa5753beccd3ddb241219cf1988a…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-01-25T08:26:09+01:00
tls: update docs for init_mode with details about fork prepare option
---
Modified: src/modules/tls/doc/params.xml
---
Diff: https://github.com/kamailio/kamailio/commit/331aa5753beccd3ddb241219cf1988a…
Patch: https://github.com/kamailio/kamailio/commit/331aa5753beccd3ddb241219cf1988a…
---
diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml
index 49f1d1f85f..d90157ca24 100644
--- a/src/modules/tls/doc/params.xml
+++ b/src/modules/tls/doc/params.xml
@@ -1037,13 +1037,20 @@ modparam("tls", "renegotiation", 1)
<para>
Allow setting flags that control how the module is initialized and works
at runtime. Many flags (bits) can be set at the same time (set the
- parameter to the sum of corresponding values).
+ parameter to the sum of corresponding values). The flags are refered
+ with 0-indexing.
</para>
<para>
- If flag (bit) 1 is set (value 1), the memory management operations registered for TLS are
- wapped within a pthread mutex lock. It can be useful with newer versions
- of libssl and libcrypto, which have a more pthread multi-threading oriented
- design.
+ If flag (bit) at index 0 is set (value 1), the memory management operations
+ registered for TLS are wapped within a pthread mutex lock. It can be useful
+ with newer versions of libssl and libcrypto, which have a more pthread
+ multi-threading oriented design.
+ </para>
+ <para>
+ If flag (bit) at index 1 is set (value 2), the module executes openssl fork
+ prepare API functions (see
+ <ulink url="https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_fork_prepare.html">https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_fork_prepare.html</ulink>). It is done only for openssl version greater or equal
+ with 1.1.1.
</para>
<para>
Default value is 0.
### Description
When running kamdbctl for the first time with `DBENGINE=MYSQL` , it will try to create the same user twice which causes a failure. Because the user is already there, the create fails and the install script fails
As a new user this is very confusing as it leads you to believe that you're blocked. However, if you enable prompt and run it twice and then skip adding access the second time, you can continue.
```
root@924dfe238957:/# /usr/sbin/kamdbctl create
Create the database 'kamailio'? (y/n): y
-e \E[37;33mINFO: creating database kamailio ...
Create database users with access privileges? (y/n): y
-e \E[37;33mINFO: granting privileges to database kamailio ...
ERROR 1396 (HY000) at line 1: Operation CREATE USER failed for 'kamailio'@'mariadb'
ERROR 1396 (HY000) at line 1: Operation CREATE USER failed for 'kamailioro'@'mariadb'
```
### Troubleshooting
If you modify `./usr/lib/x86_64-linux-gnu/kamailio/kamctl/kamdbctl.mysql` to echo the command instead, then you get the following debugging info.
```
root@924dfe238957:/# /usr/sbin/kamdbctl create
Create the database 'kamailio'? (y/n): y
-e \E[37;33mINFO: creating database kamailio ...
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE DATABASE kamailio CHARACTER SET latin1;
Create database users with access privileges? (y/n): y
-e \E[37;33mINFO: granting privileges to database kamailio ...
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'mariadb' IDENTIFIED BY 'kamailiorw';
GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'mariadb';
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'mariadb' IDENTIFIED BY 'kamailioro';
GRANT SELECT ON kamailio.* TO 'kamailioro'@'mariadb';
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'localhost' IDENTIFIED BY 'kamailiorw';
GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'localhost';
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'localhost' IDENTIFIED BY 'kamailioro';
GRANT SELECT ON kamailio.* TO 'kamailioro'@'localhost';
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailio'@'mariadb' IDENTIFIED BY 'kamailiorw';
GRANT ALL PRIVILEGES ON kamailio.* TO 'kamailio'@'mariadb';
mysql -h mariadb -P 3306 -uroot -ppasswd -e CREATE USER 'kamailioro'@'mariadb' IDENTIFIED BY 'kamailioro';
GRANT SELECT ON kamailio.* TO 'kamailioro'@'mariadb';
```
As you can see ` 'kamailioro'@'mariadb'` and ` 'kamailioro'@'mariadb'` are added twice which creates a 1396 error.
#### Reproduction
```
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3280
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3280(a)github.com>
### Description
For secure websocket connections (wss), Kamailio seems to forget that the connection is secure, later trying to use a regular TCP `listen` option to send out messags.
I'd be happy to propose a patch, but I'm not sure what the expected behavior of Kamailio would be here.
Setup:
- One Kamailio acting as websocket endpoint with TLS configured, forwarding all packets via udp to another kamailio
- Another Kamailio handling all dialplan logic, including registers/invites
We have traced the issue:
- Client sends a `REGISTER` over secure websockets
- Kamailio1 forwards this to Kamailio 2, with `Path: <sip:kamailio1:port1;lr;received=sip:1.1.1.1:11111%3Btransport%3Dws>`
- Kamailio 2 stores the AOR in database using `registrar.store`
- In the location table, we can see `received = sip:1.1.1.1:11111;transport=ws`
- We try to send a SIP INVITE to the WebRTC client
- Kamailio 2 creates invite, adds header `Route: ` with option `transport=ws`
- INVITE arrives at Kamailio 1, which forwards it to the client using `t_relay`
- Kamailio 1 ends up in `get_send_socket2`, with parameter `proto = ws`
- Following the source code, we end up [here](https://github.com/kamailio/kamailio/blob/master/src/core/forward.c#L…, this will end up picking `sendipv4_tcp` as `send_sock`
- This picks a *TCP* listener, while in fact we need a *TLS* listener
- As a result, the outgoing message contains a wrong endpoint in the `Record-Route` header, causing issues in the SIP dialog later on
### Troubleshooting
#### Reproduction
Reproducing from scratch requires quite some setup, hopefully the above information will be enough to diagnose.
#### Debugging Data
See above.
#### Log Messages
See above.
#### SIP Traffic
See above, can provide exact SIP traces if required.
### Possible Solutions
We have been able to work around the issue like this:
```
if (pcre_match("$(hdr(Route)[0]{nameaddr.uri}{uri.param,received})", "%3Btransport%3Dws")) {
# Kamailio bug?
# in the received parameter of the route header, there is ';transport=ws'
# so kamailio starts looking for a *tcp* connection, while it should be looking for a *tls*
# connection.
xlog("L_NOTICE", "Websocket detected; forcing wss transport");
set_send_socket("tls:WEBSOCKET_IP:WEBSOCKET_PORT");
}
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
Tested with 5.4.4, but code doesn't seem to be changed in master.
* **Operating System**:
Ubuntu Focal.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3340
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3340(a)github.com>