Module: kamailio
Branch: master
Commit: e052fd8507115065b566912a6146dce329b19408
URL: https://github.com/kamailio/kamailio/commit/e052fd8507115065b566912a6146dce…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2022-06-10T07:08:24Z
dispatcher: extend documentation about default behaviour with missing match mode
---
Modified: src/modules/dispatcher/doc/dispatcher_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/e052fd8507115065b566912a6146dce…
Patch: https://github.com/kamailio/kamailio/commit/e052fd8507115065b566912a6146dce…
---
diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml
index a910b8480c5..1c9de29ba78 100644
--- a/src/modules/dispatcher/doc/dispatcher_admin.xml
+++ b/src/modules/dispatcher/doc/dispatcher_admin.xml
@@ -1764,8 +1764,10 @@ if(ds_list_exists("10")) {
</listitem>
<listitem>
<para><emphasis>mode</emphasis> - (optional) - a bitmask to specify
- how the matching should be done. If parameter is 0, all ip, port and
- proto are matched and active status is ignored.
+ how the matching should be done. If the parameter is missing,
+ the matching is done with ignoring the protocol (value 2).
+ If parameter is 0, all ip, port and proto are matched and
+ active status is ignored.
If bit one is set, then port is ignored.
If bit two is set, then protocol is ignored.
If bit three is set, then state must be active. The parameter
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Crash when length($uac_req(callid)) > 128
### Troubleshooting
#### Reproduction
```
function send_options()
local KAM_DOMAIN = "192.168.100.131"
-- length(callid) is 129
local callid = "0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0123456789-0000000"
local tu = "sip:1001@" .. KAM_DOMAIN
local sut = "sip:192.168.100.132:5080"
KSR.pv.sets("$uac_req(method)", "OPTIONS")
KSR.pv.sets("$uac_req(callid)", callid)
KSR.pv.sets("$uac_req(furi)", "sip:" .. "kamailio" .. "@" .. KAM_DOMAIN)
KSR.pv.sets("$uac_req(ruri)", tu)
KSR.pv.sets("$uac_req(turi)", tu)
KSR.pv.sets("$uac_req(ouri)", sut)
KSR.pv.seti("$uac_req(evroute)", 1)
KSR.uac.uac_req_send()
end
```
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
https://github.com/kamailio/kamailio/blob/5.5/src/modules/uac/uac_send.c#L4…
check len
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
Kamailio5.5.4
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Debian11
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3135
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3135(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This change modifies the `pv_auth_check` function to take an optional second password argument `passwd2`. The motivation for this change is to allow authenticating against two passwords, which is useful if you want to eg. rotate passwords periodically and still allow using the previous password during a transition period. You can technically do this with two calls to `pv_auth_check`, but with `nonce_count` enabled the first call will invalidate nc which will always cause the second call to fail.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3126
-- Commit Summary --
* auth: Add pv_auth_check overload with second passwd parameter
-- File Changes --
M src/modules/auth/auth_mod.c (143)
M src/modules/auth/doc/auth_functions.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3126.patchhttps://github.com/kamailio/kamailio/pull/3126.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3126
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3126(a)github.com>
Module: kamailio
Branch: 5.5
Commit: acdf07299ed28bc867b25de9f538d20faddac62c
URL: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-06-03T11:48:28+02:00
pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
In order to be more clear of who is the origin of the packages
(cherry picked from commit 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a)
---
Modified: pkg/kamailio/deb/bionic/control
Modified: pkg/kamailio/deb/bullseye/control
Modified: pkg/kamailio/deb/buster/control
Modified: pkg/kamailio/deb/debian/control
Modified: pkg/kamailio/deb/focal/control
Modified: pkg/kamailio/deb/jessie/control
Modified: pkg/kamailio/deb/precise/control
Modified: pkg/kamailio/deb/sid/control
Modified: pkg/kamailio/deb/stretch/control
Modified: pkg/kamailio/deb/trusty/control
Modified: pkg/kamailio/deb/wheezy/control
Modified: pkg/kamailio/deb/xenial/control
---
Diff: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20…
Patch: https://github.com/kamailio/kamailio/commit/acdf07299ed28bc867b25de9f538d20…
Module: kamailio
Branch: 5.6
Commit: 30c14ac9d71414f11a7c4a48c292496cd5d0145f
URL: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-06-03T11:45:30+02:00
pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
In order to be more clear of who is the origin of the packages
(cherry picked from commit 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a)
---
Modified: pkg/kamailio/deb/bionic/control
Modified: pkg/kamailio/deb/bookworm/control
Modified: pkg/kamailio/deb/bullseye/control
Modified: pkg/kamailio/deb/buster/control
Modified: pkg/kamailio/deb/debian/control
Modified: pkg/kamailio/deb/focal/control
Modified: pkg/kamailio/deb/jessie/control
Modified: pkg/kamailio/deb/precise/control
Modified: pkg/kamailio/deb/sid/control
Modified: pkg/kamailio/deb/stretch/control
Modified: pkg/kamailio/deb/trusty/control
Modified: pkg/kamailio/deb/wheezy/control
Modified: pkg/kamailio/deb/xenial/control
---
Diff: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496…
Patch: https://github.com/kamailio/kamailio/commit/30c14ac9d71414f11a7c4a48c292496…
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
By default when doing dns failover the tm module will try next ips only when receiving 503 code or no response.
the new failover_reply_codes provides a way to try next ip when receiving specific codes or class code.
for example try next ip even if the previous one returned 408
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3129
-- Commit Summary --
* Enable tm dns failover to try next ip on receiving code other than 503
-- File Changes --
M src/modules/tm/doc/params.xml (25)
M src/modules/tm/t_funcs.c (11)
M src/modules/tm/t_reply.c (12)
M src/modules/tm/t_reply.h (4)
M src/modules/tm/tm.c (139)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3129.patchhttps://github.com/kamailio/kamailio/pull/3129.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3129
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3129(a)github.com>
Module: kamailio
Branch: master
Commit: 1225d7fda1d8c3eb82c403dcd0cd38d57fc4ad2a
URL: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-06-03T11:40:46+02:00
pkg/kamailio/deb: update Maintainer and Vcs fields [skip ci]
In order to be more clear of who is the origin of the packages
---
Modified: pkg/kamailio/deb/bionic/control
Modified: pkg/kamailio/deb/bookworm/control
Modified: pkg/kamailio/deb/bullseye/control
Modified: pkg/kamailio/deb/buster/control
Modified: pkg/kamailio/deb/debian/control
Modified: pkg/kamailio/deb/focal/control
Modified: pkg/kamailio/deb/jessie/control
Modified: pkg/kamailio/deb/precise/control
Modified: pkg/kamailio/deb/sid/control
Modified: pkg/kamailio/deb/stretch/control
Modified: pkg/kamailio/deb/trusty/control
Modified: pkg/kamailio/deb/wheezy/control
Modified: pkg/kamailio/deb/xenial/control
---
Diff: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d…
Patch: https://github.com/kamailio/kamailio/commit/1225d7fda1d8c3eb82c403dcd0cd38d…
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
All ips destination of DNS Failover are tried only if either no response or 503 response.
I woud like to try others ips when receiving code other than 503 response (example when receiving 408 from a previous one).
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Expected behavior
#### Actual observed behavior
#### Debugging Data
```
None
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
None
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
obvious
```
### Possible Solutions
A possible solution will be to modify the reply_received function of tm's t_reply.c file.
```
int reply_received( struct sip_msg *p_msg )
{
}
```
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a improvement.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3122
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3122(a)github.com>
Module: kamailio
Branch: 5.6
Commit: 92e0dc0c3a8fe17d18fad944bfeb3d9102c2ca6c
URL: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-06-02T13:49:05+02:00
ctl: skip checking end tag for BINRPC_T_DOUBLE values
- related to GH #3123
(cherry picked from commit 72901b7822c5684f8a10faa91118f3fd6de6c01a)
---
Modified: src/modules/ctl/binrpc.h
---
Diff: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9…
Patch: https://github.com/kamailio/kamailio/commit/92e0dc0c3a8fe17d18fad944bfeb3d9…
---
diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h
index da4524878c..94ced22ea2 100644
--- a/src/modules/ctl/binrpc.h
+++ b/src/modules/ctl/binrpc.h
@@ -730,7 +730,7 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx,
type=*p & 0xf;
len=*p>>4;
p++;
- if (len & 8){
+ if ((type!=BINRPC_T_DOUBLE) && (len & 8)){
end_tag=1; /* possible end mark for array or structs */
/* we have to read len bytes and use them as the new len */
p=binrpc_read_int(&len, len&7, p, end, err);
Module: kamailio
Branch: master
Commit: 72901b7822c5684f8a10faa91118f3fd6de6c01a
URL: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-06-02T12:48:38+02:00
ctl: skip checking end tag for BINRPC_T_DOUBLE values
- related to GH #3123
---
Modified: src/modules/ctl/binrpc.h
---
Diff: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f…
Patch: https://github.com/kamailio/kamailio/commit/72901b7822c5684f8a10faa91118f3f…
---
diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h
index da4524878c..94ced22ea2 100644
--- a/src/modules/ctl/binrpc.h
+++ b/src/modules/ctl/binrpc.h
@@ -730,7 +730,7 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx,
type=*p & 0xf;
len=*p>>4;
p++;
- if (len & 8){
+ if ((type!=BINRPC_T_DOUBLE) && (len & 8)){
end_tag=1; /* possible end mark for array or structs */
/* we have to read len bytes and use them as the new len */
p=binrpc_read_int(&len, len&7, p, end, err);
Module: kamailio
Branch: master
Commit: a81266d38d500dfc7f7fda4c3903d375fabe8d24
URL: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-06-01T18:16:21+02:00
modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
---
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37…
Patch: https://github.com/kamailio/kamailio/commit/a81266d38d500dfc7f7fda4c3903d37…
---
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index 4a1aba9a15..d895e972a5 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -314,6 +314,8 @@ ipsec_create("location", "1");
+ 0x20 (32) - do not reset the destination URI.
+ 0x40 (64) - use user equipment client port as target for TCP
requests.
+ + 0x80 (128) - set transport parameter in the new dst uri for
+ TCP requests.
This is an optional parameter, default value - 0.
Example 1.12. ipsec_forward
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
`lost` is not build on FreeBSD environment.
The proposed patch fixes it and makes the module is consistent with the rest of modules.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3131
-- Commit Summary --
* lost: Makefile - support for FreeBSD build
-- File Changes --
M src/modules/lost/Makefile (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3131.patchhttps://github.com/kamailio/kamailio/pull/3131.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3131
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3131(a)github.com>
Module: kamailio
Branch: master
Commit: f1634883e64587e28df629fa902c7f4116338f2c
URL: https://github.com/kamailio/kamailio/commit/f1634883e64587e28df629fa902c7f4…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-06-01T14:16:40+02:00
modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
---
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/f1634883e64587e28df629fa902c7f4…
Patch: https://github.com/kamailio/kamailio/commit/f1634883e64587e28df629fa902c7f4…
---
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index dbbf9c55d5..4a1aba9a15 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -311,6 +311,9 @@ ipsec_create("location", "1");
+ 0x08 (8) - use new R-URI for IPSec tunnel search.
+ 0x10 (16) - do not look for alias parameter to set received
details.
+ + 0x20 (32) - do not reset the destination URI.
+ + 0x40 (64) - use user equipment client port as target for TCP
+ requests.
This is an optional parameter, default value - 0.
Example 1.12. ipsec_forward
Module: kamailio
Branch: master
Commit: 762fc6068a23e7afd3251be58732d054a9dadab0
URL: https://github.com/kamailio/kamailio/commit/762fc6068a23e7afd3251be58732d05…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-06-01T13:11:37+02:00
ims_ipsec_pcscf: ipsec_forward() option to use UE client port for requests over TCP
---
Modified: src/modules/ims_ipsec_pcscf/cmd.c
---
Diff: https://github.com/kamailio/kamailio/commit/762fc6068a23e7afd3251be58732d05…
Patch: https://github.com/kamailio/kamailio/commit/762fc6068a23e7afd3251be58732d05…
---
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c
index 8fa4d9cf23..35bcaa28fb 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -88,6 +88,8 @@ extern struct tm_binds tmb;
#define IPSEC_NOALIAS_SEARCH (1<<4)
/* if set - do not reset dst uri for IPsec forward */
#define IPSEC_NODSTURI_RESET (1<<5)
+/* if set - use user equipment client port as target for requests over TCP */
+#define IPSEC_TCPPORT_UEC (1<<6)
/* if set - delete unused tunnels before every registration */
#define IPSEC_CREATE_DELETE_UNUSED_TUNNELS 0x01
@@ -925,11 +927,20 @@ int ipsec_forward(struct sip_msg *m, udomain_t *d, int _cflags)
// for Request get the dest proto from the saved contact
dst_proto = pcontact->received_proto;
- // for Request sends from P-CSCF client port
- src_port = s->port_pc;
+ if(_cflags & IPSEC_TCPPORT_UEC) {
+ // for Request and TCP sends from P-CSCF server port, for Request and UDP sends from P-CSCF client port
+ src_port = dst_proto == PROTO_TCP ? s->port_ps : s->port_pc;
- // for Request sends to UE server port
- dst_port = s->port_us;
+ // for Request and TCP sends to UE client port, for Request and UDP sends to UE server port
+ dst_port = dst_proto == PROTO_TCP ? s->port_uc : s->port_us;
+
+ } else {
+ // for Request sends from P-CSCF client port
+ src_port = s->port_pc;
+
+ // for Request sends to UE server port
+ dst_port = s->port_us;
+ }
}
if(!(_cflags & IPSEC_NODSTURI_RESET)) {
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [X] Related to issue #3091
#### Description
`module_group_standard` and `slack` are not build on FreeBSD environment.
The proposed patch fixes it and makes the module is consistent with the rest of modules.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3130
-- Commit Summary --
* Makefile.groups: renamed malloc_test to misctest
* slack: Makefile - support for FreeBSD build
-- File Changes --
M src/Makefile.groups (2)
M src/modules/slack/Makefile (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3130.patchhttps://github.com/kamailio/kamailio/pull/3130.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3130
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3130(a)github.com>
```
[root@logan-0a kamailio]# make -C src/modules/outbound install
make: Entering directory '/root/kamailio/src/modules/outbound'
CC (gcc) [M outbound.so] config.o
CC (gcc) [M outbound.so] outbound_mod.o
outbound_mod.c: In function ‘mod_init’:
outbound_mod.c:112:25: warning: pointer targets in passing argument 1 of ‘SHA1’ differ in signedness [-Wpointer-sign]
SHA1(flow_token_secret.s, flow_token_secret.len, ob_key.s);
~~~~~~~~~~~~~~~~~^~
In file included from outbound_mod.c:28:
/usr/include/openssl/sha.h:44:16: note: expected ‘const unsigned char *’ but argument is of type ‘char *’
unsigned char *SHA1(const unsigned char *d, size_t n, unsigned char *md);
^~~~
outbound_mod.c:112:58: warning: pointer targets in passing argument 3 of ‘SHA1’ differ in signedness [-Wpointer-sign]
SHA1(flow_token_secret.s, flow_token_secret.len, ob_key.s);
~~~~~~^~
In file included from outbound_mod.c:28:
/usr/include/openssl/sha.h:44:16: note: expected ‘unsigned char *’ but argument is of type ‘char *’
unsigned char *SHA1(const unsigned char *d, size_t n, unsigned char *md);
^~~~
LD (gcc) [M outbound.so] outbound.so
touch /usr/local/lib64/kamailio//modules/outbound.so
install -m 755 outbound.so /usr/local/lib64/kamailio//modules
make: Leaving directory '/root/kamailio/src/modules/outbound'
```
Build on CentOS 8 Stream
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3128
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3128(a)github.com>
Module: kamailio
Branch: master
Commit: 80c941bd083854c4b55bd4af218cb65d06040d94
URL: https://github.com/kamailio/kamailio/commit/80c941bd083854c4b55bd4af218cb65…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-05-31T10:16:16+02:00
modules: readme files regenerated - ims_ipsec_pcscf ... [skip ci]
---
Modified: src/modules/ims_ipsec_pcscf/README
---
Diff: https://github.com/kamailio/kamailio/commit/80c941bd083854c4b55bd4af218cb65…
Patch: https://github.com/kamailio/kamailio/commit/80c941bd083854c4b55bd4af218cb65…
---
diff --git a/src/modules/ims_ipsec_pcscf/README b/src/modules/ims_ipsec_pcscf/README
index f02167fb7e..dbbf9c55d5 100644
--- a/src/modules/ims_ipsec_pcscf/README
+++ b/src/modules/ims_ipsec_pcscf/README
@@ -302,13 +302,15 @@ ipsec_create("location", "1");
* domain - Logical domain within the registrar. If a database is used
then this must be name of the table which stores the contacts.
flags - bitwise flag:
- + 0x01 - set force socket for request messages. Useful for ipsec
- and TCP.
- + 0x02 - reverse search for a contact in the memory. Useful when
- contact alias is disabled.
- + 0x04 - use destination URI for IPSec tunnel search. Useful for
- routing requests within dialog.
- + 0x08 - use new R-URI for IPSec tunnel search.
+ + 0x01 (1) - set force socket for request messages. Useful for
+ ipsec and TCP.
+ + 0x02 (2) - reverse search for a contact in the memory. Useful
+ when contact alias is disabled.
+ + 0x04 (4) - use destination URI for IPSec tunnel search. Useful
+ for routing requests within dialog.
+ + 0x08 (8) - use new R-URI for IPSec tunnel search.
+ + 0x10 (16) - do not look for alias parameter to set received
+ details.
This is an optional parameter, default value - 0.
Example 1.12. ipsec_forward
Module: kamailio
Branch: master
Commit: 07d9a77272ee0b8b3e25ee5ddb443cd3adb01890
URL: https://github.com/kamailio/kamailio/commit/07d9a77272ee0b8b3e25ee5ddb443cd…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-05-31T10:11:10+02:00
ims_ipsec_pcscf: docs for new flag for no alias use
---
Modified: src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/07d9a77272ee0b8b3e25ee5ddb443cd…
Patch: https://github.com/kamailio/kamailio/commit/07d9a77272ee0b8b3e25ee5ddb443cd…
---
diff --git a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
index 77a758b5c4..0715da7fae 100644
--- a/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
+++ b/src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml
@@ -284,24 +284,29 @@ ipsec_create("location", "1");
<itemizedlist>
<listitem>
<para>
- <emphasis>0x01</emphasis> - set force socket for request messages. Useful for ipsec and TCP.
+ <emphasis>0x01</emphasis> (1) - set force socket for request messages. Useful for ipsec and TCP.
</para>
</listitem>
<listitem>
<para>
- <emphasis>0x02</emphasis> - reverse search for a contact in the memory.
+ <emphasis>0x02</emphasis> (2) - reverse search for a contact in the memory.
Useful when contact alias is disabled.
</para>
</listitem>
<listitem>
<para>
- <emphasis>0x04</emphasis> - use destination URI for IPSec tunnel search. Useful for
+ <emphasis>0x04</emphasis> (4) - use destination URI for IPSec tunnel search. Useful for
routing requests within dialog.
</para>
</listitem>
<listitem>
<para>
- <emphasis>0x08</emphasis> - use new R-URI for IPSec tunnel search.
+ <emphasis>0x08</emphasis> (8) - use new R-URI for IPSec tunnel search.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <emphasis>0x10</emphasis> (16) - do not look for alias parameter to set received details.
</para>
</listitem>
</itemizedlist>