- sr-dev - kamailio.org

git: new commits in branch 5.8
by Daniel-Constantin Mierla 06 Mar '25

06 Mar '25

- URL: https://github.com/kamailio/kamailio/commit/ac730f356aee48488801951290123a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:27:59+01:00 core: more checks for extract_candidate() (cherry picked from commit 3198b66aa5dbda1c6a03f46a610073671cbd5157) (cherry picked from commit a5ac9e04b91971da44256373904450501f9a4493) - URL: https://github.com/kamailio/kamailio/commit/a8f9aa75a08b1fc0bcc66bfc8119e0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:28:12+01:00 presence: do not break on one notify sending failure - try all of them, debug message with successful and failure counters - GH #4118 (cherry picked from commit 65e51b776290a1981e9ac27fbe6b47813516bc8b) (cherry picked from commit 9e21ce85d0c97679f9e14f9c31108f2dcdad772e) - URL: https://github.com/kamailio/kamailio/commit/626253c7d41a67fed8c5f3af64caa3c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:28:25+01:00 core/parser/sdp: proper test for media ip separator (cherry picked from commit 200cdb318569191cd012dfe99b252f98fe9623b9) (cherry picked from commit 9c44aec667fc3c088612dd31935bce2eb082812d) - URL: https://github.com/kamailio/kamailio/commit/7997d33aa6cae817da0e55cca802eb4… Author: Bastian Triller <bastian.triller(a)gmail.com> Date: 2025-03-06T11:28:33+01:00 htable: Fix expiry on assignment Update cell expiry on assignment for htables w/o updateexpiry (analogue to #4079). (cherry picked from commit 75994f40c99ffa2c7c33e5fce5e3d3cd8db7d780) (cherry picked from commit b38925b0b3628539840de2b6240da75b9f9f3cc6) - URL: https://github.com/kamailio/kamailio/commit/ce3806e6b8ac668f149e655d0746782… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:28:43+01:00 htable: wrapped maco code in do {} while(0) (cherry picked from commit 65a296b3478503ed3519ea9156d8f46f5cb9ce2a) (cherry picked from commit dfa9239cf6df7644e9fe6b83cfc33aff518a19c6) - URL: https://github.com/kamailio/kamailio/commit/614e056628f6221cde6d6a307109edf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:28:55+01:00 http_async_client: check returned cell inside check_multi_info() (cherry picked from commit b16550fa72d23084b4221769fe74b1f3c357c9fd) (cherry picked from commit b4718cd7dca8e037664dbc49a1cfac684906ecea) - URL: https://github.com/kamailio/kamailio/commit/270ac18eeb5601fa5043a85961a62a4… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: 2025-03-06T11:29:52+01:00 db_oracle: fix warning: passing argument 2 of âdb_do_closeâ from incompatible pointer type [-Wincompatible-pointer-types] (cherry picked from commit 577a87861a8566e00f2700dfb227dcc8b26393b4) (cherry picked from commit 022940dec70272a19c86604d2fa9af83d8790bb1) - URL: https://github.com/kamailio/kamailio/commit/dfe9da5c1c79612cb6166dfabf89abd… Author: pinacolada1610 <starinchikova(a)gmail.com> Date: 2025-03-06T11:30:19+01:00 tcp: fix for local TCP/TLS socket matching with 'tcp_reuse_port' enabled - Changed the logic for matching a listening TCP/TLS-socket in tcp_reuse_port scenario, now it considers local port as well. With 'tcp_reuse_port' option enabled, the local port is meaningful and helps to differenciate between sockets on the same IP but different ports. (cherry picked from commit 0cb6e35d581398d2c5a7086a0d98b113fbb16138) (cherry picked from commit 1e362f2ba51c6ee9a9e005675a30202e42ceb3a7) - URL: https://github.com/kamailio/kamailio/commit/f4aed91f5ab78cddbe782e94306c3cf… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Date: 2025-03-06T11:30:52+01:00 janssonrpcc: fixed warning var may be used uninitialized (cherry picked from commit 3039c02404e05da05a031f6ccf68913a8c1c80eb) (cherry picked from commit ddd98b09c80dc0d15af080e37961b59ecde17689) - URL: https://github.com/kamailio/kamailio/commit/f270f8a6c86cc2541801914223858da… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:31:45+01:00 seas: remove redundant check (cherry picked from commit ab1b032771be9adbb1d643cd44beac0e09a31553) (cherry picked from commit c8be39750902ad69818f8247898070fce2d6a3a3) - URL: https://github.com/kamailio/kamailio/commit/724a58813d50dcfe965e69914fbdc93… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:32:08+01:00 msrp: variable for extra headers used in local replies (cherry picked from commit 7a73e08b0e5b4c3fbeb4f097c1f891d06c74651d) (cherry picked from commit c29d9d661b3954906cdee7e98a4f9b6502673490) - URL: https://github.com/kamailio/kamailio/commit/96945faccf3d689c1a2e90aca3b65bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:32:18+01:00 core: mem f malloc - additional check when getting to search very big fragments (cherry picked from commit ac909a7a019922676076bc47a28a3801c749becc) (cherry picked from commit 9d3392a55831124121b078201985c417c9f9982d) - URL: https://github.com/kamailio/kamailio/commit/0f8b36091a64de012377bd2460e2995… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:32:26+01:00 msrp: send failure response after referening the buffer (cherry picked from commit 5f8adb625b6bae81ef44613d774106bf3a943bb0) (cherry picked from commit 4ff58bb3e02b76e2489144867c8b0dc5041dc621) - URL: https://github.com/kamailio/kamailio/commit/88780735710c688293dcc3e1d52fd8a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:32:52+01:00 textops: catch return 0 when removing via param (cherry picked from commit 65645c761e94cedde04f100764d5c506590cb200) (cherry picked from commit a88946a84133660d5b2a466a231dff226c9db995) - URL: https://github.com/kamailio/kamailio/commit/8473c30705289dd5bf94c6426d2e8ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:34:44+01:00 core: socket info - use unsigned for current size in buffer for get flags (cherry picked from commit 462f9730eb55a3abbd50b9170eb6318eb43eb999) (cherry picked from commit eed2ccbb658b28433e71a95e9715934aa64c4cfb) - URL: https://github.com/kamailio/kamailio/commit/874148e9335fdf22e9187ff3dce524d… Author: pepelux <pepeluxx(a)gmail.com> Date: 2025-03-06T11:34:56+01:00 secfilter: fix secf_check_dst bug (cherry picked from commit 578c2abb36b9101bfc1dddc1505f7239e928b98e) (cherry picked from commit 086d228b29ab414a65521da78695786a979ef754) - URL: https://github.com/kamailio/kamailio/commit/77f2671979d0dcd70cdd3f490a0dad0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:35:08+01:00 tsilo: clean allocated memory on error for append by contact (cherry picked from commit 6fb38cb33095c11a1c90d7b88140ac159b9fd5ca) (cherry picked from commit f1549b99a69bf0dec4aad564afa1d6e328621752) - URL: https://github.com/kamailio/kamailio/commit/42260f34079ddad7662742a64696d25… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:35:28+01:00 core: pass fd - check for unexpected read size overflow (cherry picked from commit 6c12477f1dad2279431d703d1a4f63fcfc6543b8) (cherry picked from commit ac0a4a5052e9aaf6531130675c8140fdd5c11e97) - URL: https://github.com/kamailio/kamailio/commit/f123ebae553624525ca04d34ddd4c94… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:36:04+01:00 core: check for unexpected long value return by pathconf() (cherry picked from commit 2ba6d4ff2727031e7bca5d3d1da016bfe508b8df) (cherry picked from commit 718692c6d402b6942e0b1e8ebd8e64b306813495) - URL: https://github.com/kamailio/kamailio/commit/5e836af2ff198481bde0485a315bbfd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:36:28+01:00 ctl: free rpc struct in case of error (cherry picked from commit 4a71d3c9e6a4f92ef33ce8e62372b2c4dba62a56) (cherry picked from commit 5024235f876df4b3239ef746de700ade362cc7b2) - URL: https://github.com/kamailio/kamailio/commit/184f25c845bffc39d3aabff90d1f568… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:36:49+01:00 xprint: init globals when declared (cherry picked from commit b17038ec072b1854fa2fae1c2d4725c1471ef8ac) (cherry picked from commit cf3b3849cb2a3c4060281377e2adee09de5d47d9) - URL: https://github.com/kamailio/kamailio/commit/1f6dc4df8572c07280478858087182f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:00+01:00 xmlrpc: clean allocated buffer (cherry picked from commit ff712539566c903312ebba2f8e2585f9c80ffdcf) (cherry picked from commit e1398e53e9825db6c20590e1576d960ac0c3c429) - URL: https://github.com/kamailio/kamailio/commit/90122e3a46169e9f10dc7d8e01638d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:08+01:00 ctl: fifo - clean intermediary buffer (cherry picked from commit 4c4d7f7967a99d4dd4acdc5e198bce493bf15d67) (cherry picked from commit c68522f5c3c59cb915feb873bd3351e57a8db579) - URL: https://github.com/kamailio/kamailio/commit/ad7a3cc3751af2417e6000a2d689c35… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:17+01:00 xprint: break on first resolved ip address (cherry picked from commit 7c908137826071b8180bd93ff8ba3994be66da3a) (cherry picked from commit de5986433283b2fcff09b064420d43327270d390) - URL: https://github.com/kamailio/kamailio/commit/994bc2e752f2f969d04067329f34b29… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:30+01:00 tm: split reverse rte list function (cherry picked from commit e85d07e5b42ff25f81b74f68ab412e0ab27e7170) (cherry picked from commit a5576fb3476e327ef10135a85cf20f2e720803db) - URL: https://github.com/kamailio/kamailio/commit/34d093a1e7a60f9d13458fed46a513c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:37+01:00 tm: jump to error when failing to built content length for uac cancel (cherry picked from commit 27e1e9102f07047a3d2c2f28baa708f14be556a6) (cherry picked from commit d505c876c534cc4a4b8aff5ef1b5e28b151d8d06) - URL: https://github.com/kamailio/kamailio/commit/33921fd3fc01f95dae2c0a8e7e146c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:37:51+01:00 tm: rpc uac - jump to error when failing to create delayed context (cherry picked from commit aa081dbd1ee1901c6174ffddd556bda47b6ef732) (cherry picked from commit d0df1eef55cd9bb0bca2b0db007d94dbe4e8e95c) - URL: https://github.com/kamailio/kamailio/commit/33aebcd3a4f17df390153ad38cf73b4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:38:09+01:00 topoh: check on pointer only for via decode return - code reformatted (cherry picked from commit d0cd3c4b40fd791143122622a6d74703e1375832) (cherry picked from commit c7a4dd132478ff2d5f46c85594a44fee9c570f6d) - URL: https://github.com/kamailio/kamailio/commit/ce55c093d490fd19f10c50e11d12e18… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:38:19+01:00 pv: free next field on error when parsing xav* names (cherry picked from commit b875e7368dcc8e221007caafa3599c3e354404f7) (cherry picked from commit 8b7637140c5362bf90046ccb3b34ea74ef658c0a) - URL: https://github.com/kamailio/kamailio/commit/83a4165fc62710027ddf006058c66f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:38:45+01:00 ctl: refactored error handling and removed unnecessary code (cherry picked from commit edbb5b11e9453be3519e6e9a945937307c95709e) (cherry picked from commit 691eb2600c1fcf24d0d1f9b2648e7257499537a8) - URL: https://github.com/kamailio/kamailio/commit/eaa0d1af8a46fe9a74d0eb1bbb2fbf2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:38:54+01:00 xmlrpc: removed unnecessary code (cherry picked from commit e65b03cdd946d735a3ef33ae3582bcfad464d2c7) (cherry picked from commit 6d06293f3fe1c5897a3e01272fdc9ac409925f3d) - URL: https://github.com/kamailio/kamailio/commit/23de8c670eea22ae6cce3f3d8e5b9d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:07+01:00 sca: free replaces hdr on anchor lump failure (cherry picked from commit 01782191418f3d65c4aa5cb273140fec928d153a) (cherry picked from commit c8acc1f6e5441fd4514c2b7ead1e2bbe441f7895) - URL: https://github.com/kamailio/kamailio/commit/e804235ebdd344020891307b838769f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:26+01:00 call_control: free pv field in case of error (cherry picked from commit 8a96379cc1ef7aa42bc4be49834c538a3bffdf14) (cherry picked from commit 44764414c48fed1b90580cf62dd33e975f1f7ecd) - URL: https://github.com/kamailio/kamailio/commit/99852d486bd4180c4f571864bfccda5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:36+01:00 http_client: free dumplicated name in case of errors (cherry picked from commit 39ba53a2499dd1f0e080bb011d7438a60ea5faec) (cherry picked from commit 7274e353d7c05f5387c64aaf90197c9a8e8d1dd4) - URL: https://github.com/kamailio/kamailio/commit/e3c734871f1858e88617060f859c347… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:43+01:00 dlgs: return -1 for 0 tags count (cherry picked from commit 6a2a82555ee8bbfaca1e825c19d1532f22c2c629) (cherry picked from commit 975d3449ae01a9078009772e0e1b86c9a996d982) - URL: https://github.com/kamailio/kamailio/commit/7e5cf1d7dbcb027dd6aaeca3ad7df58… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:50+01:00 tsilo: free duplicated ruri and contact on error cases (cherry picked from commit d029de6380f8e30e0c82435b820744c21a5fbc78) (cherry picked from commit a6e99ff231ca5a42bd053d3a8f2f9d02682ab07d) - URL: https://github.com/kamailio/kamailio/commit/9fbc51b7f9d4bcb618f68a2b54427ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:39:57+01:00 db_redis: clean the keyname variable (cherry picked from commit aae4cb323d4ea9d07b4b8aec61a6c9bc03e2ab83) (cherry picked from commit c59d29abbdc65784ea6fbe6eb237dbadd3fb370d) - URL: https://github.com/kamailio/kamailio/commit/2e5863f54086ae695564861569f009c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:40:06+01:00 registrar: remove unnecessary condition (cherry picked from commit 6b7af1beb7fdaaec1b5d069fdfff3e3af5ca43ca) (cherry picked from commit dddb8b0c99f2822be5fff2693a105b391480bc77) - URL: https://github.com/kamailio/kamailio/commit/2a076e07ba9a1289ee89f4eba2cba87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:40:16+01:00 core: socket info - print index values in error message for overflow (cherry picked from commit 413c90202975886f4dfcb579a1157a19c3065341) (cherry picked from commit be47356fda7ee3862f335fd5b192e54c33dfe85c) - URL: https://github.com/kamailio/kamailio/commit/da3a94f0ce67709806f0aedfd6818e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:40:24+01:00 dialog: set keepalive local cseq value to 0 (cherry picked from commit 5d3ae2acfab38eda88c6369c0db18a286faba2e3) (cherry picked from commit 0c09b213cbd0a8b12128fa4fb16c01907684b0a6) - URL: https://github.com/kamailio/kamailio/commit/211abf00128a20b667a760b89d0ccb6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:41:10+01:00 dialog: get vars via value instead of reference for kemi functions - do lock/unlock - GH #4151 (cherry picked from commit 3b213f1d008656682f1733d59f6c3bacd474c4b9) (cherry picked from commit ea0fc8e213f6703d87a000216a2cc18764732fce) - URL: https://github.com/kamailio/kamailio/commit/83d8ebf769ec1313228e5b89164a13c… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2025-03-06T11:41:20+01:00 dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL - GH #4151 (cherry picked from commit 2b1ca7813cf5014553c807c1a5034c404b3685a5) (cherry picked from commit c20ad4abaec2632acfa069a73b1c0b195ccb8334) - URL: https://github.com/kamailio/kamailio/commit/11af1f47dd40d57a38848fbbd358054… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T11:41:27+01:00 sl: stats for 1xx replies - GH #4144 (cherry picked from commit f43c132db9b1dc71f623d592fb46d487ba492c7d) (cherry picked from commit ed21e7c97677572d732fa1020528fe92f3a9ee35) - URL: https://github.com/kamailio/kamailio/commit/0890a38d534e57527f87802b83c2b9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-06T13:36:52+01:00 Revert "secfilter: fix secf_check_dst bug" This reverts commit 874148e9335fdf22e9187ff3dce524dc0fa21879.

1 0

git:master:8b60b560: modules: readme files regenerated - auth ... [skip ci]
by Kamailio Dev 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: 8b60b56015ced6da3666c6613e1189b9a1f63d8f URL: https://github.com/kamailio/kamailio/commit/8b60b56015ced6da3666c6613e1189b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-03-05T13:16:09+01:00 modules: readme files regenerated - auth ... [skip ci] --- Modified: src/modules/auth/README --- Diff: https://github.com/kamailio/kamailio/commit/8b60b56015ced6da3666c6613e1189b… Patch: https://github.com/kamailio/kamailio/commit/8b60b56015ced6da3666c6613e1189b… --- diff --git a/src/modules/auth/README b/src/modules/auth/README index 193f91e0ef5..fcd73cc02a0 100644 --- a/src/modules/auth/README +++ b/src/modules/auth/README @@ -76,7 +76,7 @@ Daniel-Constantin Mierla 1.13. force_stateless_reply example 1.14. realm_prefix parameter example 1.15. force_stateless_reply example - 1.16. use SHA-256 example + 1.16. algorithm example 1.17. add Authentication-Info header example 1.18. consume_credentials example 1.19. consume_credentials example @@ -645,17 +645,18 @@ modparam("auth", "use_domain", 1) 3.18. algorithm (string) Configure hash algorithm used for digest authentication. Possible - values are "MD5" or "SHA-256". If left empty MD5 is used. If specified, - the specified algorithm is used and is also put in the 'algorithm' - field of the challenge header. - - Warning: SHA-256 hash values take twice the space of MD5 hash values. - So a buffer overflow might occur if this option is used in combination - with another auth_* module that does not allocate at least 65 bytes to - store hash values. SHA-256 can safely be used with the module auth_db - as it allocates 256 bytes to store HA1 values. - - Example 1.16. use SHA-256 example + values are "MD5", "SHA-256" or "SHA-512". If left empty MD5 is used. If + specified, the specified algorithm is used and is also put in the + 'algorithm' field of the challenge header. + + Warning: SHA-256/512 hash values take twice or more the space of MD5 + hash values. So a buffer overflow might occur if this option is used in + combination with another auth_* module that does not allocate at least + enough (65 or 129) bytes to store hash values. SHA-256/512 can safely + be used with the module auth_db as it allocates 256 bytes to store HA1 + values. + + Example 1.16. algorithm example ... modparam("auth", "algorithm", "SHA-256") ...

1 0

git:master:05c796ab: auth: docs updated for algorithm param
by Daniel-Constantin Mierla 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: 05c796ab406d5771d775769b380219c6bdcb67c1 URL: https://github.com/kamailio/kamailio/commit/05c796ab406d5771d775769b380219c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-05T13:00:15+01:00 auth: docs updated for algorithm param --- Modified: src/modules/auth/doc/auth_params.xml --- Diff: https://github.com/kamailio/kamailio/commit/05c796ab406d5771d775769b380219c… Patch: https://github.com/kamailio/kamailio/commit/05c796ab406d5771d775769b380219c… --- diff --git a/src/modules/auth/doc/auth_params.xml b/src/modules/auth/doc/auth_params.xml index 058c1d2706a..5e3f730bc39 100644 --- a/src/modules/auth/doc/auth_params.xml +++ b/src/modules/auth/doc/auth_params.xml @@ -705,20 +705,19 @@ modparam("auth", "use_domain", 1) <title><varname>algorithm</varname> (string)</title> <para> Configure hash algorithm used for digest authentication. - Possible values are "MD5" or "SHA-256". If left empty MD5 is used. - If specified, the specified algorithm is used and is also put in + Possible values are "MD5", "SHA-256" or "SHA-512". If left empty MD5 is + used. If specified, the specified algorithm is used and is also put in the 'algorithm' field of the challenge header. </para> <para> - Warning: SHA-256 hash values take twice the space of MD5 hash values. - So a buffer overflow might occur if this option is used in combination - with another auth_* module that does not allocate at least 65 bytes to - store hash values. - SHA-256 can safely be used with the module auth_db as it allocates 256 bytes - to store HA1 values. + Warning: SHA-256/512 hash values take twice or more the space of MD5 hash + values. So a buffer overflow might occur if this option is used in combination + with another auth_* module that does not allocate at least enough (65 or 129) + bytes to store hash values. SHA-256/512 can safely be used with the module + auth_db as it allocates 256 bytes to store HA1 values. </para> <example> - <title>use SHA-256 example</title> + <title>algorithm example</title> <programlisting> ... modparam("auth", "algorithm", "SHA-256")

1 0

git:master:f72ed8c5: auth: support for password hasing with SHA512
by Daniel-Constantin Mierla 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: f72ed8c5d769dc0d1434d72b51e365598aecaa82 URL: https://github.com/kamailio/kamailio/commit/f72ed8c5d769dc0d1434d72b51e3655… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-05T12:54:40+01:00 auth: support for password hasing with SHA512 --- Modified: src/modules/auth/auth_mod.c Modified: src/modules/auth/rfc2617_sha256.c Modified: src/modules/auth/rfc2617_sha256.h --- Diff: https://github.com/kamailio/kamailio/commit/f72ed8c5d769dc0d1434d72b51e3655… Patch: https://github.com/kamailio/kamailio/commit/f72ed8c5d769dc0d1434d72b51e3655…

1 0

git:master:d901d4ea: kamctl: CMDHASH to specify password hashing command
by Daniel-Constantin Mierla 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: d901d4eab24c2b8ddd5880da05083eafc9e0daea URL: https://github.com/kamailio/kamailio/commit/d901d4eab24c2b8ddd5880da05083ea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-05T12:22:04+01:00 kamctl: CMDHASH to specify password hashing command - like md5sum, sha256sum --- Modified: utils/kamctl/kamctl.base Modified: utils/kamctl/kamctlrc --- Diff: https://github.com/kamailio/kamailio/commit/d901d4eab24c2b8ddd5880da05083ea… Patch: https://github.com/kamailio/kamailio/commit/d901d4eab24c2b8ddd5880da05083ea… --- diff --git a/utils/kamctl/kamctl.base b/utils/kamctl/kamctl.base index ea0fff94362..e61b556c3d0 100644 --- a/utils/kamctl/kamctl.base +++ b/utils/kamctl/kamctl.base @@ -62,14 +62,19 @@ if [ -z "$GDB" ] ; then GDB="$TOOLPATH" fi fi -if [ -z "$MD5" ]; then - locate_tool md5sum md5 - if [ -z "$TOOLPATH" ] ; then - # now error, but we can look for alternative names if it is the case - echo "error: 'md5sum' or 'md5' tool not found: set MD5 variable to correct tool path" - exit +if [ -z "$CMDHASH" ]; then + if [ -z "$MD5" ]; then + locate_tool md5sum md5 + if [ -z "$TOOLPATH" ] ; then + # now error, but we can look for alternative names if it is the case + echo "error: 'md5sum' or 'md5' tool not found: set CMDHASH variable to correct tool path" + exit + fi + CMDHASH="$TOOLPATH" + else + # handle old variable setting md5 tool + CMDHASH="$MD5" fi - MD5="$TOOLPATH" fi if [ -z "$LAST_LINE" ] ; then locate_tool tail @@ -777,7 +782,7 @@ filter_json() # output: HA1 _gen_ha1() { - HA1=`echo -n "$1:$2:$3" | $MD5 | $AWK '{ print $1 }'` + HA1=`echo -n "$1:$2:$3" | $CMDHASH | $AWK '{ print $1 }'` if [ $? -ne 0 ] ; then echo "HA1 calculation failed" exit 1 @@ -788,7 +793,7 @@ _gen_ha1() # output: HA1B _gen_ha1b() { - HA1B=`echo -n "$1@$2:$2:$3" | $MD5 | $AWK '{ print $1 }'` + HA1B=`echo -n "$1@$2:$2:$3" | $CMDHASH | $AWK '{ print $1 }'` if [ $? -ne 0 ] ; then echo "HA1B calculation failed" exit 1 @@ -800,7 +805,7 @@ _gen_ha1b() _gen_phplib_id() { NOW=`date`; - PHPLIB_ID=`echo -n "$1$2:$3:$NOW" | $MD5 | $AWK '{ print $1 }'` + PHPLIB_ID=`echo -n "$1$2:$3:$NOW" | $CMDHASH | $AWK '{ print $1 }'` } # params: user, password diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 67af483d9c6..eb5c361f18b 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -79,8 +79,9 @@ # DEFAULT_Q="1.0" -## Program to calculate a message-digest fingerprint -# MD5="md5sum" +## Program to calculate the MD5/SHA256 message-digest fingerprint +# - md5sum, sha256sum +# CMDHASH="md5sum" ## awk tool # AWK="awk"

1 0

git:master:d13c1270: modules: readme files regenerated - app_python3 ... [skip ci]
by Kamailio Dev 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: d13c1270c8855a38f7ccc9a9c8ff6f556a822773 URL: https://github.com/kamailio/kamailio/commit/d13c1270c8855a38f7ccc9a9c8ff6f5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-03-05T10:31:09+01:00 modules: readme files regenerated - app_python3 ... [skip ci] --- Modified: src/modules/app_python3/README --- Diff: https://github.com/kamailio/kamailio/commit/d13c1270c8855a38f7ccc9a9c8ff6f5… Patch: https://github.com/kamailio/kamailio/commit/d13c1270c8855a38f7ccc9a9c8ff6f5… --- diff --git a/src/modules/app_python3/README b/src/modules/app_python3/README index 5ee3d8ff3b6..5a012417df5 100644 --- a/src/modules/app_python3/README +++ b/src/modules/app_python3/README @@ -27,6 +27,7 @@ Maxim Sobolev 3.2. script_name (string) 3.3. mod_init_function (string) 3.4. child_init_method (string) + 3.5. threads_mode (int) 4. Functions @@ -44,7 +45,8 @@ Maxim Sobolev 1.1. Set load parameter 1.2. Set mod_init_function parameter 1.3. Set child_init_method parameter - 1.4. python_exec usage + 1.4. Set threads_mode parameter + 1.5. python_exec usage Chapter 1. Admin Guide @@ -62,6 +64,7 @@ Chapter 1. Admin Guide 3.2. script_name (string) 3.3. mod_init_function (string) 3.4. child_init_method (string) + 3.5. threads_mode (int) 4. Functions @@ -124,6 +127,7 @@ Chapter 1. Admin Guide 3.2. script_name (string) 3.3. mod_init_function (string) 3.4. child_init_method (string) + 3.5. threads_mode (int) 3.1. load (string) @@ -166,6 +170,20 @@ modparam("app_python3", "mod_init_function", "my_mod_init") modparam("app_python3", "child_init_method", "my_child_init") ... +3.5. threads_mode (int) + + Control how locking for Python interpreter threads in done. If set to + 1, use Py_BLOCK_THREADS/Py_UNBLOCK_THREADS (new mode added for v6.0.x). + If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode + implemented initially). + + Default value is “0”. + + Example 1.4. Set threads_mode parameter +... +modparam("app_python3", "threads_mode", 1) +... + 4. Functions 4.1. python_exec(method [, args]) @@ -178,7 +196,7 @@ modparam("app_python3", "child_init_method", "my_child_init") Both parameters can contain pseudo-variables. - Example 1.4. python_exec usage + Example 1.5. python_exec usage ... python_exec("my_python_function"); python_exec("my_python_function", "my_params");

1 0

git:master:9ee8f962: app_python3s: docs for threads_mode parameter
by Daniel-Constantin Mierla 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: 9ee8f9624a00474ed3c9fbd60169abdffd0543a0 URL: https://github.com/kamailio/kamailio/commit/9ee8f9624a00474ed3c9fbd60169abd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-05T10:29:20+01:00 app_python3s: docs for threads_mode parameter --- Modified: src/modules/app_python3/doc/app_python3_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9ee8f9624a00474ed3c9fbd60169abd… Patch: https://github.com/kamailio/kamailio/commit/9ee8f9624a00474ed3c9fbd60169abd… --- diff --git a/src/modules/app_python3/doc/app_python3_admin.xml b/src/modules/app_python3/doc/app_python3_admin.xml index 7785007548c..87b97f0824d 100644 --- a/src/modules/app_python3/doc/app_python3_admin.xml +++ b/src/modules/app_python3/doc/app_python3_admin.xml @@ -160,6 +160,29 @@ modparam("app_python3", "child_init_method", "my_child_init") </example> </section> + <section id="app_python3.p.threads_mode"> + <title><varname>threads_mode</varname> (int)</title> + <para> + Control how locking for Python interpreter threads in done. If set + to 1, use Py_BLOCK_THREADS/Py_UNBLOCK_THREADS (new mode added for + v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() + (the mode implemented initially). + </para> + <para> + <emphasis> + Default value is <quote>0</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>threads_mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("app_python3", "threads_mode", 1) +... +</programlisting> + </example> + </section> + </section> <section> @@ -289,4 +312,3 @@ cfgengine "python" </section> </chapter> -

1 0

git:master:db7a19a8: app_python3: added threads_mode parameter
by Daniel-Constantin Mierla 05 Mar '25

05 Mar '25

Module: kamailio Branch: master Commit: db7a19a82605076e09224e07645e436f1e166ce8 URL: https://github.com/kamailio/kamailio/commit/db7a19a82605076e09224e07645e436… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-05T09:33:32+01:00 app_python3: added threads_mode parameter - control how python interpreter threading is done - GH #4153 --- Modified: src/modules/app_python3/app_python3_mod.c Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/db7a19a82605076e09224e07645e436… Patch: https://github.com/kamailio/kamailio/commit/db7a19a82605076e09224e07645e436…

1 0

[kamailio/kamailio] In function ksr_tm_event_response_sent(evname), header and body modifications are not applied (Issue #3997)
by JuanPascual2 05 Mar '25

05 Mar '25

Hello In the function ksr_tm_event_response_sent(evname), header and body modifications are not applied. **Example of modification:** KSR.textops.set_body("application/test", "teststbody") KSR.textops.remove_hf("Contact") KSR.hdr.append("X-My-Hdr: testhdrappend \r\n") In the Kamailio logs, we can see that the changes have been processed, but the response sent does not contain the changes. BR Juan **Configuration kamailio.cfg** modparam("tm", "event_callback_lres_sent", "ksr_tm_event_response_sent") **Configuration kamailio.lua** ----------------------- --Function ksr_tm_event_response_sent bug ----------------------- function ksr_tm_event_response_sent(evname) log.debug("\27[36m --> Sending reply: $rs $rr \27[0m") log.debug("\27[35m Reply sent ",evname,"\27[0m") KSR.textops.set_body("application/test", "teststbody") KSR.textops.remove_hf("Contact") KSR.hdr.append("X-My-Hdr: testhdrappend \r\n") end **Traces debug KAMAILIO** 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:96: --> Sending reply: $rs $rr 4(260) DEBUG: <core> [core/pvapi.c:502]: pv_spec_lookup(): PV <$rs> is not in cache 4(260) DEBUG: <core> [core/pvapi.c:386]: pv_cache_add(): pvar [$rs] added in cache 4(260) DEBUG: <core> [core/pvapi.c:502]: pv_spec_lookup(): PV <$rr> is not in cache 4(260) DEBUG: <core> [core/pvapi.c:386]: pv_cache_add(): pvar [$rr] added in cache 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:96: --> Sending reply: 200 OK 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:97: Reply sent tm:local-response-sent 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:97: Reply sent tm:local-response-sent 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: set_body is str: application/test 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[1] for: set_body is str: teststbody 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [To] type 3 4(260) DEBUG: <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=bb3c24ed793eec883784ff522b4e48d0 4(260) DEBUG: <core> [core/parser/parse_addr_spec.c:904]: parse_addr_spec(): end of header reached, state=29 4(260) DEBUG: <core> [core/parser/msg_parser.c:172]: get_hdr_field(): <To> [61]; uri=[sip:1234@sip.osp.com] 4(260) DEBUG: <core> [core/parser/msg_parser.c:174]: get_hdr_field(): to body (22)[<sip:1234@sip.osp.com>], to tag (32)[bb3c24ed793eec883784ff522b4e48d0] 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [From] type 4 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [CSeq] type 5 4(260) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <63723> <REGISTER> 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Call-ID] type 6 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Content-Type] type 11 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Contact] type 7 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Content-Length] type 12 4(260) DEBUG: <core> [core/parser/msg_parser.c:187]: get_hdr_field(): content_length=6 4(260) DEBUG: <core> [core/parser/msg_parser.c:91]: get_hdr_field(): found end of header 4(260) DEBUG: textops [textops.c:2597]: ki_set_body(): new body: [application/test] 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: remove_hf is str: Contact 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Contact] type 7 4(260) DEBUG: <core> [core/kemi.c:2350]: sr_kemi_hdr_remove(): remove hf: Contact 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: append is str: X-My-Hdr: testhdrappend 4(260) DEBUG: <core> [core/kemi.c:2224]: sr_kemi_hdr_append(): append hf: X-My-Hdr: testhdrappend 4(260) DEBUG: app_lua [app_lua_mod.c:166]: sr_kemi_config_engine_lua(): execution of route type 513 with name [ksr_tm_event_response_sent] returned 1 4(260) DEBUG: tm [t_reply.c:634]: _reply_light(): reply sent out - buf=0x786b611bb9e0: SIP/2.0 200 OK Via:... shmem=0x786b58ceea80: SIP/2.0 200 OK Via: 4(260) DEBUG: tm [t_funcs.c:133]: put_on_wait(): put T [0x786b58ceb770] on wait 4(260) DEBUG: tm [t_reply.c:650]: _reply_light(): finished 4(260) DEBUG: jsonrpcs [jsonrpcs_mod.c:443]: jsonrpc_send_mode(): sending response with body: (nil) - 200 OK 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:36: ksr_request_route: 23.11 ms 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:36: ksr_request_route: 23.11 ms 4(260) DEBUG: app_lua [app_lua_mod.c:169]: sr_kemi_config_engine_lua(): execution of route type 1 with no name returned 1 4(260) DEBUG: <core> [core/receive.c:531]: receive_msg(): request-route executed in: 23343 usec 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/receive.c:635]: receive_msg(): cleaning up 18(274) DEBUG: tm [timer.c:642]: wait_handler(): finished transaction: 0x786b58ce81a0 (p:0x786b58baa3c0/n:0x786b58baa3c0) 18(274) DEBUG: tm [h_table.c:133]: free_cell_helper(): freeing transaction 0x786b58ce81a0 from timer.c:651 18(274) DEBUG: tm [timer.c:642]: wait_handler(): finished transaction: 0x786b58ceb770 (p:0x786b58b729c0/n:0x786b58b729c0) 18(274) DEBUG: tm [h_table.c:133]: free_cell_helper(): freeing transaction 0x786b58ceb770 from timer.c:651 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3997 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3997(a)github.com>

4 8

[kamailio/kamailio] dispatcher module usage on kamailio 5.8.4 generate kamailio crash (Issue #4061)
by pgravet 05 Mar '25

05 Mar '25

### Description kamailio crash with signal 6 ### Troubleshooting #### Reproduction After each couple of dispatcher ping interval. #### Debugging Data No core dump file. #### Log Messages Dec 6 17:47:24 frnappcoe3router2 /usr/sbin/kamailio[1618]: INFO: ctl [io_listener.c:211]: io_listen_loop(): using epoll_lt as the io watch method (auto detected) Dec 6 17:47:34 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:frnappcoe3sfl05.orange-voicemail.net:5060> Dec 6 17:47:34 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:cs1-tool-misc.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:frnappcoe3sfl05.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1614]: NOTICE: <script>: tm:local-request called OPTIONS to <sip:cs1-tool-misc.orange-voicemail.net:5060> Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1608]: CRITICAL: <core> [core/mem/q_malloc.c:555]: qm_free(): BUG: freeing already freed pointer (0x7f178fa8a700), called from core: core/xavp.c: xavp_free(81), first free core: core/xavp.c: xavp_new_value(117) - ignoring Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1608]: CRITICAL: <core> [core/mem/q_malloc.c:136]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f178fa8a560 (address 0x7f178fa8a5a0) end overwritten (0, f00000000000)! Memory allocator was called from core: core/xavp.c:81. Fragment marked by (null):2882400237. Exec from core/mem/q_malloc.c:546. Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: ALERT: <core> [main.c:805]: handle_sigs(): child process 1608 exited by a signal 6 Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: ALERT: <core> [main.c:809]: handle_sigs(): core was not generated Dec 6 17:47:44 frnappcoe3router2 /usr/sbin/kamailio[1604]: INFO: <core> [main.c:832]: handle_sigs(): terminating due to SIGCHLD #### SIP Traffic ### Possible Solutions ### Additional Information [root@frnappcoe3router2 ~]# kamailio -v version: kamailio 5.8.4 (x86_64/linux) f1d83d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f1d83d compiled on 13:59:57 Nov 12 2024 with gcc 8.5.0 kamailio.cfg loadmodule "dispatcher.so" modparam("dispatcher", "list_file", DISPATCHER_FILE) modparam("dispatcher", "ds_probing_mode", 1) modparam("dispatcher", "ds_probing_threshold",3) modparam("dispatcher", "flags", 3) modparam("dispatcher", "ds_ping_from", "sip:siprouter@unisys.com") modparam("dispatcher", "xavp_dst", "_dsdst_") modparam("dispatcher", "xavp_ctx", "_dsctx_") modparam("dispatcher", "ds_hash_size", 8) modparam("dispatcher", "ds_ping_interval", 10) modparam("dispatcher", "ds_ping_reply_codes", "class=2;class=3") * **Operating System**: RHEL8.8 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4061 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4061(a)github.com>

5 11

git:6.0:f07bc9ef: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 04 Mar '25

04 Mar '25

Module: kamailio Branch: 6.0 Commit: f07bc9ef61b9eaecb528e57ee0228d0e690f16af URL: https://github.com/kamailio/kamailio/commit/f07bc9ef61b9eaecb528e57ee0228d0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-03-04T17:46:19+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/app_python3s/README Modified: src/modules/auth/README --- Diff: https://github.com/kamailio/kamailio/commit/f07bc9ef61b9eaecb528e57ee0228d0… Patch: https://github.com/kamailio/kamailio/commit/f07bc9ef61b9eaecb528e57ee0228d0… --- diff --git a/src/modules/app_python3s/README b/src/modules/app_python3s/README index 5b8d663797a..af38af3e8e0 100644 --- a/src/modules/app_python3s/README +++ b/src/modules/app_python3s/README @@ -28,6 +28,7 @@ Daniel-Constantin Mierla 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 4. Functions @@ -45,7 +46,8 @@ Daniel-Constantin Mierla 1.1. Set load parameter 1.2. Set script_init parameter 1.3. Set script_child_init parameter - 1.4. app_python3s_exec usage + 1.4. Set threads_mode parameter + 1.5. app_python3s_exec usage Chapter 1. Admin Guide @@ -62,6 +64,7 @@ Chapter 1. Admin Guide 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 4. Functions @@ -118,6 +121,7 @@ Chapter 1. Admin Guide 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 3.1. load (string) @@ -163,6 +167,20 @@ def ksr_script_child_init(): return 1 ... +3.4. threads_mode (int) + + Control how locking for Python interpreter threads in done. If set to + 1, use Py_BLOCK_THREADS/Py_UNBLOCK_THREADS (new mode added for v6.0.x). + If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode + implemented initially). + + Default value is “0”. + + Example 1.4. Set threads_mode parameter +... +modparam("app_python3s", "threads_mode", 1) +... + 4. Functions 4.1. app_python3s_exec(method [, param]) @@ -175,7 +193,7 @@ def ksr_script_child_init(): Both parameters can contain pseudo-variables. - Example 1.4. app_python3s_exec usage + Example 1.5. app_python3s_exec usage ... app_python3s_exec("my_python_function"); app_python3s_exec("my_python_function", "my_params"); diff --git a/src/modules/auth/README b/src/modules/auth/README index 826c0b04dcc..193f91e0ef5 100644 --- a/src/modules/auth/README +++ b/src/modules/auth/README @@ -86,7 +86,7 @@ Daniel-Constantin Mierla 1.23. pv_www_authenticate usage 1.24. pv_proxy_authenticate usage 1.25. pv_auth_check usage - 1.26. auth_get_www_authenticate + 1.26. auth_get_www_authenticate usage 1.27. auth_algorithm example Chapter 1. Admin Guide @@ -924,7 +924,7 @@ if (!pv_auth_check("$fd", "$avp(password)", "0", "1")) { This function can be used from ANY_ROUTE. - Example 1.26. auth_get_www_authenticate + Example 1.26. auth_get_www_authenticate usage ... if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { xlog("www authenticate header is [$var(wauth)]\n"); @@ -939,5 +939,14 @@ if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { Example 1.27. auth_algorithm example ... -auth_algorithm("$alg"); +if($fU == "alice") { + $var(alg) = "SHA-256"; +} else { + $var(alg) = "MD5"; +} +auth_algorithm("$var(alg)"); +if (!auth_check("$fd", "subscriber", "1")) { + auth_challenge("$fd", "1"); + exit; +} ...

1 0

git: new commits in branch 6.0
by Daniel-Constantin Mierla 04 Mar '25

04 Mar '25

- URL: https://github.com/kamailio/kamailio/commit/c8be39750902ad69818f8247898070f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:14:20+01:00 seas: remove redundant check (cherry picked from commit ab1b032771be9adbb1d643cd44beac0e09a31553) - URL: https://github.com/kamailio/kamailio/commit/60004b02856ebe03b1fc84b74ee8fb6… Author: Kaufman <bkaufman(a)bcmone.com> Date: 2025-03-04T17:14:35+01:00 pkg/kamailio/alpine: Add new modules - Add missing modules to alpine packages as listed in GH #4131 (cherry picked from commit f07d8ea527883009fece7fd2a1c61d0a90a0c660) - URL: https://github.com/kamailio/kamailio/commit/3ba48f9a83284f629654c0030f6f556… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: 2025-03-04T17:14:44+01:00 db_oracle: fix db_oracle build for oracle 18.3.0.0.0 (cherry picked from commit 77ce71fcd4cfb6f0f86313d95341e4abd0031b2c) - URL: https://github.com/kamailio/kamailio/commit/921acc45d7f9f96b15b801e270a9377… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:14:53+01:00 pv: small reworking of pointer conditions (cherry picked from commit 478310c56f0eb060c5f31b2ee8febbb6204d37e7) - URL: https://github.com/kamailio/kamailio/commit/c29d9d661b3954906cdee7e98a4f9b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:15:22+01:00 msrp: variable for extra headers used in local replies (cherry picked from commit 7a73e08b0e5b4c3fbeb4f097c1f891d06c74651d) - URL: https://github.com/kamailio/kamailio/commit/9d3392a55831124121b078201985c41… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:15:57+01:00 core: mem f malloc - additional check when getting to search very big fragments (cherry picked from commit ac909a7a019922676076bc47a28a3801c749becc) - URL: https://github.com/kamailio/kamailio/commit/4ff58bb3e02b76e2489144867c8b0dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:16:03+01:00 msrp: send failure response after referening the buffer (cherry picked from commit 5f8adb625b6bae81ef44613d774106bf3a943bb0) - URL: https://github.com/kamailio/kamailio/commit/703b3244a5a6fabc219d5772694584d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:16:16+01:00 topos_htable: use the xtag also for base64 key (cherry picked from commit 88b96d717be2a66a9351c01c861408743be40fc4) - URL: https://github.com/kamailio/kamailio/commit/b6fd791f533be6b044b0c18e44c36f7… Author: Kaufman <bkaufman(a)bcmone.com> Date: 2025-03-04T17:16:30+01:00 nghttp2: compilation with gcc 14 - Explicitly include nghttp2.h file GH #4135 (cherry picked from commit 1e5a91be57de02beedbd2b3b03031647b51eb7b6) - URL: https://github.com/kamailio/kamailio/commit/a88946a84133660d5b2a466a231dff2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:16:44+01:00 textops: catch return 0 when removing via param (cherry picked from commit 65645c761e94cedde04f100764d5c506590cb200) - URL: https://github.com/kamailio/kamailio/commit/89afe1e7bd4bdf9a4ad505ecd260b50… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:16:53+01:00 ims_isc: check return for parsing headers and anchor lump (cherry picked from commit efce6e76ba20f7b02101fb2f44cb149b609f4bef) - URL: https://github.com/kamailio/kamailio/commit/eed2ccbb658b28433e71a95e9715934… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:17:03+01:00 core: socket info - use unsigned for current size in buffer for get flags (cherry picked from commit 462f9730eb55a3abbd50b9170eb6318eb43eb999) - URL: https://github.com/kamailio/kamailio/commit/8d1b0139f3a62651f7f0dac6944b6e1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:17:20+01:00 ims_auth: amf passed as parameter to resync local auth vector (cherry picked from commit 6e76452c11189620663da84f879400575c673792) - URL: https://github.com/kamailio/kamailio/commit/626d9d823690dce4557deeaa2d62470… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:17:34+01:00 nghttp2: check return for setsockopt TCP_NODELAY (cherry picked from commit ad8f017b38e90746790ec9789f01abe6fab46e1b) - URL: https://github.com/kamailio/kamailio/commit/086d228b29ab414a65521da78695786… Author: pepelux <pepeluxx(a)gmail.com> Date: 2025-03-04T17:17:53+01:00 secfilter: fix secf_check_dst bug (cherry picked from commit 578c2abb36b9101bfc1dddc1505f7239e928b98e) - URL: https://github.com/kamailio/kamailio/commit/f1549b99a69bf0dec4aad564afa1d6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:19+01:00 tsilo: clean allocated memory on error for append by contact (cherry picked from commit 6fb38cb33095c11a1c90d7b88140ac159b9fd5ca) - URL: https://github.com/kamailio/kamailio/commit/ac0a4a5052e9aaf6531130675c8140f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:27+01:00 core: pass fd - check for unexpected read size overflow (cherry picked from commit 6c12477f1dad2279431d703d1a4f63fcfc6543b8) - URL: https://github.com/kamailio/kamailio/commit/718692c6d402b6942e0b1e8ebd8e64b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:36+01:00 core: check for unexpected long value return by pathconf() (cherry picked from commit 2ba6d4ff2727031e7bca5d3d1da016bfe508b8df) - URL: https://github.com/kamailio/kamailio/commit/0b42dcb9997dac347f007742f8936e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:46+01:00 lib/ims: renamed specific macros with pretty generic name (cherry picked from commit c45c71164ed40e06cdfab4ceda292d29d2d1459f) - URL: https://github.com/kamailio/kamailio/commit/d06d5e143e2586e0075c0c580f79f29… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:52+01:00 ims_charging: updates for lib/ims macro names (cherry picked from commit f1abcba4eeabccf96a8d16c2e63a47b27db62f88) - URL: https://github.com/kamailio/kamailio/commit/20cda1f11d6f20143a1271b3db9cf38… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:18:59+01:00 ims_qos_npn: updates for lib/ims macro names (cherry picked from commit b9c36860fc8a91fc6c73b456ff64b6191f61813b) - URL: https://github.com/kamailio/kamailio/commit/eee79e2a4650e1362ca460f3c329d5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:05+01:00 ims_registrar_scscf: updates for lib/ims macro names (cherry picked from commit 3fb1d7832006d290ee1c2e15ea1e731dc0768b5f) - URL: https://github.com/kamailio/kamailio/commit/85cf965d1a298f8c12064fd4f9790d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:12+01:00 db_sqlite: added prefix to internal helper function (cherry picked from commit f37940b9a113ab79611f851334af7f8fbb7b3f6a) - URL: https://github.com/kamailio/kamailio/commit/5024235f876df4b3239ef746de700ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:20+01:00 ctl: free rpc struct in case of error (cherry picked from commit 4a71d3c9e6a4f92ef33ce8e62372b2c4dba62a56) - URL: https://github.com/kamailio/kamailio/commit/cf3b3849cb2a3c4060281377e2adee0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:27+01:00 xprint: init globals when declared (cherry picked from commit b17038ec072b1854fa2fae1c2d4725c1471ef8ac) - URL: https://github.com/kamailio/kamailio/commit/e1398e53e9825db6c20590e1576d960… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:33+01:00 xmlrpc: clean allocated buffer (cherry picked from commit ff712539566c903312ebba2f8e2585f9c80ffdcf) - URL: https://github.com/kamailio/kamailio/commit/c68522f5c3c59cb915feb873bd3351e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:41+01:00 ctl: fifo - clean intermediary buffer (cherry picked from commit 4c4d7f7967a99d4dd4acdc5e198bce493bf15d67) - URL: https://github.com/kamailio/kamailio/commit/de5986433283b2fcff09b064420d433… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:19:50+01:00 xprint: break on first resolved ip address (cherry picked from commit 7c908137826071b8180bd93ff8ba3994be66da3a) - URL: https://github.com/kamailio/kamailio/commit/a5576fb3476e327ef10135a85cf20f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:20:09+01:00 tm: split reverse rte list function (cherry picked from commit e85d07e5b42ff25f81b74f68ab412e0ab27e7170) - URL: https://github.com/kamailio/kamailio/commit/d505c876c534cc4a4b8aff5ef1b5e28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:20:17+01:00 tm: jump to error when failing to built content length for uac cancel (cherry picked from commit 27e1e9102f07047a3d2c2f28baa708f14be556a6) - URL: https://github.com/kamailio/kamailio/commit/d0df1eef55cd9bb0bca2b0db007d94d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:20:28+01:00 tm: rpc uac - jump to error when failing to create delayed context (cherry picked from commit aa081dbd1ee1901c6174ffddd556bda47b6ef732) - URL: https://github.com/kamailio/kamailio/commit/c7a4dd132478ff2d5f46c85594a44fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:20:41+01:00 topoh: check on pointer only for via decode return - code reformatted (cherry picked from commit d0cd3c4b40fd791143122622a6d74703e1375832) - URL: https://github.com/kamailio/kamailio/commit/8b7637140c5362bf90046ccb3b34ea7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:20:49+01:00 pv: free next field on error when parsing xav* names (cherry picked from commit b875e7368dcc8e221007caafa3599c3e354404f7) - URL: https://github.com/kamailio/kamailio/commit/7310f99a85bb3cc581c1747ef0ac151… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:01+01:00 pv: free buf uri in case of error setting xto attr (cherry picked from commit a6d692be4283dc349c38b455ee71c4e21dcef6aa) - URL: https://github.com/kamailio/kamailio/commit/691eb2600c1fcf24d0d1f9b2648e725… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:10+01:00 ctl: refactored error handling and removed unnecessary code (cherry picked from commit edbb5b11e9453be3519e6e9a945937307c95709e) - URL: https://github.com/kamailio/kamailio/commit/6d06293f3fe1c5897a3e01272fdc9ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:16+01:00 xmlrpc: removed unnecessary code (cherry picked from commit e65b03cdd946d735a3ef33ae3582bcfad464d2c7) - URL: https://github.com/kamailio/kamailio/commit/8991e340e9eb26a3aba3333b4868a5e… Author: Gustavo Almeida <gustavo.abcdef(a)hotmail.com> Date: 2025-03-04T17:21:24+01:00 ims_auth: Fix CentOS 7 Build ims_auth: Fix non C99 compliant code (cherry picked from commit 2349e4088d3fd454b74de15dfcb9a3e19fc03663) - URL: https://github.com/kamailio/kamailio/commit/528b6e9805c23883a19e959475a566f… Author: Gustavo Almeida <gustavo.abcdef(a)hotmail.com> Date: 2025-03-04T17:21:30+01:00 ims_auth: Fix CentOS 7 Build - ims_auth: Fix non C99 compliant code (cherry picked from commit 7a65b3ce11a3afc0f5be47f61235166cb8938c78) - URL: https://github.com/kamailio/kamailio/commit/1887dfcbd930c6f1757fe5fe691f52c… Author: Gustavo Almeida <gustavo.abcdef(a)hotmail.com> Date: 2025-03-04T17:21:37+01:00 ims_registrar_pcscf: Fix CentOS 7 Build - ims_registrar_pcscf: Fix non C99 compliant code (cherry picked from commit e458ca15a4ca30448ea9aae20a93eb86e2ce92c0) - URL: https://github.com/kamailio/kamailio/commit/c8acc1f6e5441fd4514c2b7ead1e2bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:45+01:00 sca: free replaces hdr on anchor lump failure (cherry picked from commit 01782191418f3d65c4aa5cb273140fec928d153a) - URL: https://github.com/kamailio/kamailio/commit/47162f64626904ae799f8c47e4bc4ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:52+01:00 sdpops: check the limit for computed rtcp port (cherry picked from commit 34743f40056e230e6c6d1ae6bf72e369b6f6890f) - URL: https://github.com/kamailio/kamailio/commit/44764414c48fed1b90580cf62dd33e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:21:58+01:00 call_control: free pv field in case of error (cherry picked from commit 8a96379cc1ef7aa42bc4be49834c538a3bffdf14) - URL: https://github.com/kamailio/kamailio/commit/7274e353d7c05f5387c64aaf90197c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:05+01:00 http_client: free dumplicated name in case of errors (cherry picked from commit 39ba53a2499dd1f0e080bb011d7438a60ea5faec) - URL: https://github.com/kamailio/kamailio/commit/975d3449ae01a9078009772e0e1b86c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:12+01:00 dlgs: return -1 for 0 tags count (cherry picked from commit 6a2a82555ee8bbfaca1e825c19d1532f22c2c629) - URL: https://github.com/kamailio/kamailio/commit/a6e99ff231ca5a42bd053d3a8f2f9d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:19+01:00 tsilo: free duplicated ruri and contact on error cases (cherry picked from commit d029de6380f8e30e0c82435b820744c21a5fbc78) - URL: https://github.com/kamailio/kamailio/commit/c59d29abbdc65784ea6fbe6eb237dba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:27+01:00 db_redis: clean the keyname variable (cherry picked from commit aae4cb323d4ea9d07b4b8aec61a6c9bc03e2ab83) - URL: https://github.com/kamailio/kamailio/commit/21943c8bc2df36e818ff79256ccda99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:35+01:00 ims_auth: restructured function to avoid unnecessary condition (cherry picked from commit bf0cb8dd85c38c00435bfe6591b4b39b717b743c) - URL: https://github.com/kamailio/kamailio/commit/dddb8b0c99f2822be5fff2693a105b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:42+01:00 registrar: remove unnecessary condition (cherry picked from commit 6b7af1beb7fdaaec1b5d069fdfff3e3af5ca43ca) - URL: https://github.com/kamailio/kamailio/commit/be47356fda7ee3862f335fd5b192e54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:51+01:00 core: socket info - print index values in error message for overflow (cherry picked from commit 413c90202975886f4dfcb579a1157a19c3065341) - URL: https://github.com/kamailio/kamailio/commit/0c09b213cbd0a8b12128fa4fb16c019… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:22:59+01:00 dialog: set keepalive local cseq value to 0 (cherry picked from commit 5d3ae2acfab38eda88c6369c0db18a286faba2e3) - URL: https://github.com/kamailio/kamailio/commit/d18e367da12c85bd7a87a706d1f231f… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Date: 2025-03-04T17:23:07+01:00 kafka: Fix mod_destroy() crash A crash happened on mod_destroy() due to librdkafka thrd_join(), in case of multiple restarts, in case of ssl kafka connection. Init kafka only for timer and routing processes. Add checks for rk pointer. (cherry picked from commit 10012eeb17210ea7eb9549dc71be5af7e92b4a97) - URL: https://github.com/kamailio/kamailio/commit/3746f3f2c86a7a085f4abcd1c67c468… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:23:25+01:00 etc/kamailio.cfg: use send_reply_error() instead of sl_reply_error() (cherry picked from commit 6a7c8c232132078b97bd3023efaed30f369cfe63) - URL: https://github.com/kamailio/kamailio/commit/a786e4b5a910fef1b3472354bb112fb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:23:39+01:00 mediaproxy: avoid local variable hides global variable (cherry picked from commit 288010b92cd86e2210c079cbd00bf11536e0b0cb) - URL: https://github.com/kamailio/kamailio/commit/d62aac91f062984f215532292775909… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:23:47+01:00 xhttp_rpc: avoid local variable hides global variable (cherry picked from commit b38fbe7ab4988f916ed0dd4156c732e615980150) - URL: https://github.com/kamailio/kamailio/commit/5579fd3ca41d32f25a6dc69e2761bea… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:23:53+01:00 sipcapture: avoid local variable hides global variable (cherry picked from commit 4963f0af2f27e3e5164f54ec9b5c8713e911f1db) - URL: https://github.com/kamailio/kamailio/commit/914cc65f48333cd8df92650321228c4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:23:59+01:00 pv_headers: avoid local variable hides global variable (cherry picked from commit 1c302265c0fbf2083741fdbabfab8b922a00b8bc) - URL: https://github.com/kamailio/kamailio/commit/3b1e00e8f70ebef0b386b10d8d510ae… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:24:06+01:00 p_usrloc: avoid local variable hides global variable (cherry picked from commit c626bef15034fd6ff2e3eb3388ff0d73bf1557c4) - URL: https://github.com/kamailio/kamailio/commit/f8b7dedc7e8d0535b737cd5dfcf2fe2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:24:12+01:00 db2_ops: avoid local variable hides global variable (cherry picked from commit 79120639521f61d2b95a3be5f0faf8018afbd91c) - URL: https://github.com/kamailio/kamailio/commit/04989c2e1c65ee46f411f58c874fe18… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:24:33+01:00 db_cfg: avoid local variable hides global variable (cherry picked from commit b019dbc5dc88a58a50a3d272a30e6a1aa3b174c0) - URL: https://github.com/kamailio/kamailio/commit/61d577341b86b2d76c5849f60f2bbc6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-04T17:24:41+01:00 acc: avoid local variable hides global variable (cherry picked from commit ccf33100c1eba5dcd9494f1558ff03703fb8e7bf) - URL: https://github.com/kamailio/kamailio/commit/a8b8484dc2cc18954c56438e5f24507… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Date: 2025-03-04T17:24:54+01:00 dispatcher: skip ping for DS_NODNSARES_DST (cherry picked from commit 5f29b4491634c360ade5691977d622617ae014ad) - URL: https://github.com/kamailio/kamailio/commit/081c5e4167753a77ce5c036e3bf61e3… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Date: 2025-03-04T17:25:05+01:00 topos_htable: fix xtag and add more snprintf checks (cherry picked from commit e0e0884627609804661082a1235f87a7bbb5e67a) - URL: https://github.com/kamailio/kamailio/commit/ea0fc8e213f6703d87a000216a2cc18… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:25:34+01:00 dialog: get vars via value instead of reference for kemi functions - do lock/unlock - GH #4151 (cherry picked from commit 3b213f1d008656682f1733d59f6c3bacd474c4b9) - URL: https://github.com/kamailio/kamailio/commit/c20ad4abaec2632acfa069a73b1c0b1… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2025-03-04T17:25:43+01:00 dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL - GH #4151 (cherry picked from commit 2b1ca7813cf5014553c807c1a5034c404b3685a5) - URL: https://github.com/kamailio/kamailio/commit/ed21e7c97677572d732fa1020528fe9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:26:01+01:00 sl: stats for 1xx replies - GH #4144 (cherry picked from commit f43c132db9b1dc71f623d592fb46d487ba492c7d) - URL: https://github.com/kamailio/kamailio/commit/fb2109db4bfcf0239d7ae8aa99c5eaa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:26:11+01:00 ims_dialog: right timer function prototype for print_all_dlgs() (cherry picked from commit 6cdbaa1815bdcadc467f36109c6e3a7d00c344f5) - URL: https://github.com/kamailio/kamailio/commit/2e8f3eb6cc280661acc5c904d6ab915… Author: Henning Westerholt <hw(a)gilawa.com> Date: 2025-03-04T17:26:19+01:00 kamailio.cfg: small whitespace indention fix, spelling fix (cherry picked from commit 4f573561797b297131464699bd1ed6f0b5d7ed75) - URL: https://github.com/kamailio/kamailio/commit/4aa5804db1e8458ae639c8db20e8ede… Author: Henning Westerholt <hw(a)gilawa.com> Date: 2025-03-04T17:26:28+01:00 kamailio.cfg: small whitespace indention fix (cherry picked from commit 3b28e0151d15e7883c0ce81e63851fd9952dd2db) - URL: https://github.com/kamailio/kamailio/commit/c883d30934815e0dba0ae35538a636a… Author: Henning Westerholt <hw(a)gilawa.com> Date: 2025-03-04T17:26:47+01:00 misc/examples: update default webrtc cfg to current main kamailio.cfg state (cherry picked from commit 29e51c139725a58b2cbe9cfe409a1c62b3904a3e) - URL: https://github.com/kamailio/kamailio/commit/64350f8e6bb999971cf162470f7720f… Author: drTr0jan <drtr0jan(a)yandex.ru> Date: 2025-03-04T17:26:55+01:00 lib/ims: libxml2 is not needed - removed from cmake (cherry picked from commit 11a609d06b527470c535a20866c48cafdedcb820) - URL: https://github.com/kamailio/kamailio/commit/83e0e5ea61eb4287d88b1341021eaa7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:27:09+01:00 auth: docs - extended example for auth_algorithm() (cherry picked from commit 38544a774d92c86065709888d07c5b4f5bd013c5) - URL: https://github.com/kamailio/kamailio/commit/f6b717a90202b4fe099a36f37fcf1a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:27:25+01:00 app_python3s: added threads_mode parameter - control how python interpreter threading is done - GH #4153 (cherry picked from commit df8eb5460924b68919ee35fe8df3afeecdbbf714) - URL: https://github.com/kamailio/kamailio/commit/6e58d6b7831bfcfbd28835c673697ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T17:27:32+01:00 app_python3s: docs for threads_mode parameter (cherry picked from commit 445af28bef2d0874254b3e4c8224b3c1e7329d62)

1 0

git:master:8058449d: modules: readme files regenerated - app_python3s ... [skip ci]
by Kamailio Dev 04 Mar '25

04 Mar '25

Module: kamailio Branch: master Commit: 8058449dc2f64680b3f6d6c08865b182af7b2240 URL: https://github.com/kamailio/kamailio/commit/8058449dc2f64680b3f6d6c08865b18… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-03-04T13:46:10+01:00 modules: readme files regenerated - app_python3s ... [skip ci] --- Modified: src/modules/app_python3s/README --- Diff: https://github.com/kamailio/kamailio/commit/8058449dc2f64680b3f6d6c08865b18… Patch: https://github.com/kamailio/kamailio/commit/8058449dc2f64680b3f6d6c08865b18… --- diff --git a/src/modules/app_python3s/README b/src/modules/app_python3s/README index 5b8d663797a..af38af3e8e0 100644 --- a/src/modules/app_python3s/README +++ b/src/modules/app_python3s/README @@ -28,6 +28,7 @@ Daniel-Constantin Mierla 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 4. Functions @@ -45,7 +46,8 @@ Daniel-Constantin Mierla 1.1. Set load parameter 1.2. Set script_init parameter 1.3. Set script_child_init parameter - 1.4. app_python3s_exec usage + 1.4. Set threads_mode parameter + 1.5. app_python3s_exec usage Chapter 1. Admin Guide @@ -62,6 +64,7 @@ Chapter 1. Admin Guide 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 4. Functions @@ -118,6 +121,7 @@ Chapter 1. Admin Guide 3.1. load (string) 3.2. script_init (string) 3.3. script_child_init (string) + 3.4. threads_mode (int) 3.1. load (string) @@ -163,6 +167,20 @@ def ksr_script_child_init(): return 1 ... +3.4. threads_mode (int) + + Control how locking for Python interpreter threads in done. If set to + 1, use Py_BLOCK_THREADS/Py_UNBLOCK_THREADS (new mode added for v6.0.x). + If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode + implemented initially). + + Default value is “0”. + + Example 1.4. Set threads_mode parameter +... +modparam("app_python3s", "threads_mode", 1) +... + 4. Functions 4.1. app_python3s_exec(method [, param]) @@ -175,7 +193,7 @@ def ksr_script_child_init(): Both parameters can contain pseudo-variables. - Example 1.4. app_python3s_exec usage + Example 1.5. app_python3s_exec usage ... app_python3s_exec("my_python_function"); app_python3s_exec("my_python_function", "my_params");

1 0

git:master:445af28b: app_python3s: docs for threads_mode parameter
by Daniel-Constantin Mierla 04 Mar '25

04 Mar '25

Module: kamailio Branch: master Commit: 445af28bef2d0874254b3e4c8224b3c1e7329d62 URL: https://github.com/kamailio/kamailio/commit/445af28bef2d0874254b3e4c8224b3c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T13:37:27+01:00 app_python3s: docs for threads_mode parameter --- Modified: src/modules/app_python3s/doc/app_python3s_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/445af28bef2d0874254b3e4c8224b3c… Patch: https://github.com/kamailio/kamailio/commit/445af28bef2d0874254b3e4c8224b3c… --- diff --git a/src/modules/app_python3s/doc/app_python3s_admin.xml b/src/modules/app_python3s/doc/app_python3s_admin.xml index b1ebfc7bd0d..8381dda274f 100644 --- a/src/modules/app_python3s/doc/app_python3s_admin.xml +++ b/src/modules/app_python3s/doc/app_python3s_admin.xml @@ -149,6 +149,28 @@ def ksr_script_child_init(): KSR.info("child init python script\n") return 1 ... +</programlisting> + </example> + </section> + <section id="app_python3s.p.threads_mode"> + <title><varname>threads_mode</varname> (int)</title> + <para> + Control how locking for Python interpreter threads in done. If set + to 1, use Py_BLOCK_THREADS/Py_UNBLOCK_THREADS (new mode added for + v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() + (the mode implemented initially). + </para> + <para> + <emphasis> + Default value is <quote>0</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>threads_mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("app_python3s", "threads_mode", 1) +... </programlisting> </example> </section>

1 0

git:master:df8eb546: app_python3s: added threads_mode parameter
by Daniel-Constantin Mierla 04 Mar '25

04 Mar '25

Module: kamailio Branch: master Commit: df8eb5460924b68919ee35fe8df3afeecdbbf714 URL: https://github.com/kamailio/kamailio/commit/df8eb5460924b68919ee35fe8df3afe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-03-04T13:29:23+01:00 app_python3s: added threads_mode parameter - control how python interpreter threading is done - GH #4153 --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/df8eb5460924b68919ee35fe8df3afe… Patch: https://github.com/kamailio/kamailio/commit/df8eb5460924b68919ee35fe8df3afe…

1 0

[kamailio/kamailio] github: [skip ci]: bump wolletd/clang-format-checker from 1.11 to 1.12 (PR #4162)
by dependabot[bot] 03 Mar '25

03 Mar '25

Bumps [wolletd/clang-format-checker](https://github.com/wolletd/clang-format-check… from 1.11 to 1.12. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/ab6a81f3b… Merge pull request <a href="https://redirect.github.com/wolletd/clang-format-checker/issues/… from WolleTD/update-clang</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/4c205c944… Add clang-format 18 and 19</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/ea3c82c3a… Merge branch 'update-action'</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/e734d6075… Update actions to NodeJS 20</li> <li>See full diff in <a href="https://github.com/wolletd/clang-format-checker/compare/v1.11...… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4162 -- Commit Summary -- * github: [skip ci]: bump wolletd/clang-format-checker from 1.11 to 1.12 -- File Changes -- M .github/workflows/pull_request.yml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4162.patch https://github.com/kamailio/kamailio/pull/4162.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4162 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4162(a)github.com>

2 1

git:master:019b4c2f: github: [skip ci]: bump wolletd/clang-format-checker from 1.11 to 1.12
by Victor Seva 03 Mar '25

03 Mar '25

Module: kamailio Branch: master Commit: 019b4c2f9b1cc1b0c4469bd59a5795ea9c6b634c URL: https://github.com/kamailio/kamailio/commit/019b4c2f9b1cc1b0c4469bd59a5795e… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-03-03T23:50:08+01:00 github: [skip ci]: bump wolletd/clang-format-checker from 1.11 to 1.12 Bumps [wolletd/clang-format-checker](https://github.com/wolletd/clang-format-check… from 1.11 to 1.12. - [Release notes](https://github.com/wolletd/clang-format-checker/releases) - [Commits](https://github.com/wolletd/clang-format-checker/compare/v1.11...v1… --- updated-dependencies: - dependency-name: wolletd/clang-format-checker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/019b4c2f9b1cc1b0c4469bd59a5795e… Patch: https://github.com/kamailio/kamailio/commit/019b4c2f9b1cc1b0c4469bd59a5795e… --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 543f7c05238..351b0ba9542 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -13,7 +13,7 @@ jobs: contents: read # to fetch code (actions/checkout) steps: - uses: actions/checkout@v4 - - uses: wolletd/clang-format-checker(a)v1.11 + - uses: wolletd/clang-format-checker(a)v1.12 with: target-ref: master build:

1 0

git:master:e2893bef: modules: readme files regenerated - auth ... [skip ci]
by Kamailio Dev 28 Feb '25

28 Feb '25

Module: kamailio Branch: master Commit: e2893bef50a5c4dbb1b4cb329fde8908299e3520 URL: https://github.com/kamailio/kamailio/commit/e2893bef50a5c4dbb1b4cb329fde890… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-02-28T19:46:10+01:00 modules: readme files regenerated - auth ... [skip ci] --- Modified: src/modules/auth/README --- Diff: https://github.com/kamailio/kamailio/commit/e2893bef50a5c4dbb1b4cb329fde890… Patch: https://github.com/kamailio/kamailio/commit/e2893bef50a5c4dbb1b4cb329fde890… --- diff --git a/src/modules/auth/README b/src/modules/auth/README index 826c0b04dcc..193f91e0ef5 100644 --- a/src/modules/auth/README +++ b/src/modules/auth/README @@ -86,7 +86,7 @@ Daniel-Constantin Mierla 1.23. pv_www_authenticate usage 1.24. pv_proxy_authenticate usage 1.25. pv_auth_check usage - 1.26. auth_get_www_authenticate + 1.26. auth_get_www_authenticate usage 1.27. auth_algorithm example Chapter 1. Admin Guide @@ -924,7 +924,7 @@ if (!pv_auth_check("$fd", "$avp(password)", "0", "1")) { This function can be used from ANY_ROUTE. - Example 1.26. auth_get_www_authenticate + Example 1.26. auth_get_www_authenticate usage ... if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { xlog("www authenticate header is [$var(wauth)]\n"); @@ -939,5 +939,14 @@ if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { Example 1.27. auth_algorithm example ... -auth_algorithm("$alg"); +if($fU == "alice") { + $var(alg) = "SHA-256"; +} else { + $var(alg) = "MD5"; +} +auth_algorithm("$var(alg)"); +if (!auth_check("$fd", "subscriber", "1")) { + auth_challenge("$fd", "1"); + exit; +} ...

1 0

git:master:38544a77: auth: docs - extended example for auth_algorithm()
by Daniel-Constantin Mierla 28 Feb '25

28 Feb '25

Module: kamailio Branch: master Commit: 38544a774d92c86065709888d07c5b4f5bd013c5 URL: https://github.com/kamailio/kamailio/commit/38544a774d92c86065709888d07c5b4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-28T19:31:11+01:00 auth: docs - extended example for auth_algorithm() --- Modified: src/modules/auth/doc/auth_functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/38544a774d92c86065709888d07c5b4… Patch: https://github.com/kamailio/kamailio/commit/38544a774d92c86065709888d07c5b4… --- diff --git a/src/modules/auth/doc/auth_functions.xml b/src/modules/auth/doc/auth_functions.xml index 6a789e9e5b4..3a0a695719d 100644 --- a/src/modules/auth/doc/auth_functions.xml +++ b/src/modules/auth/doc/auth_functions.xml @@ -402,7 +402,7 @@ if (!pv_auth_check("$fd", "$avp(password)", "0", "1")) { This function can be used from ANY_ROUTE. </para> <example> - <title>auth_get_www_authenticate</title> + <title>auth_get_www_authenticate usage</title> <programlisting format="linespecific"> ... if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { @@ -417,13 +417,22 @@ if (auth_get_www_authenticate("$fd", "0", "$var(wauth)")) { <para> Set hash algorithm used for digest authentication thus overriding algorithm parameter. Possible values are the same as those of - algorithm parameter. The parameter may be a pseudo variable. + algorithm parameter. The parameter may be a pseudo variable. </para> <example> - <title>auth_algorithm example</title> + <title>auth_algorithm example</title> <programlisting> ... -auth_algorithm("$alg"); +if($fU == "alice") { + $var(alg) = "SHA-256"; +} else { + $var(alg) = "MD5"; +} +auth_algorithm("$var(alg)"); +if (!auth_check("$fd", "subscriber", "1")) { + auth_challenge("$fd", "1"); + exit; +} ... </programlisting> </example>

1 0

[kamailio/kamailio] AUTH Module algorithm parameter using MD5 and SHA-256 (Issue #4160)
by Mesa Proyectos SAS 28 Feb '25

28 Feb '25

voztovoice created an issue (kamailio/kamailio#4160)  ### Description  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4160 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4160(a)github.com>

3 4

[kamailio/kamailio] AUTH Module algorithm parameter using MD5 and SHA-256 (Issue #4161)
by Mesa Proyectos SAS 28 Feb '25

28 Feb '25

voztovoice created an issue (kamailio/kamailio#4161) As Asterisk PBX since version 20.12 supports **SHA-256** for digest authentication, it would be useful to be able to configure the authentication algorithm according to the device with which kamailio communicates. It could be by indicating the two algorithms at the same time in this parameter: **modparam("auth", "algorithm", "MD5,SHA-256")** or have a function that allows activate one or the other depending on the device with which Kamailio communicates. This because all the softphones I have tested so far do not support SHA-256 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4161 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4161(a)github.com>

2 2

[kamailio/kamailio] [bug] /kamdbctl create kamailio_5_8_5 failied (Issue #4159)
by QuincyGao 28 Feb '25

28 Feb '25

QuincyGao created an issue (kamailio/kamailio#4159)  ### Description  kamdbctl create db failed with mysql5.7, not find `ims_icscf-create.sql` file ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` ./kamdbctl create kamailio_5_8_5 INFO: creating database kamailio_5_8_5 ... INFO: granting privileges to database kamailio_5_8_5 ... INFO: creating standard tables into kamailio_5_8_5 ... INFO: Core Kamailio tables successfully created. Create the presence related tables? (y/n): y INFO: creating presence tables into kamailio_5_8_5 ... INFO: Presence tables successfully created. Create the tables for imc cpl siptrace domainpolicy carrierroute drouting userblocklist htable purple uac pipelimit mtree sca mohqueue rtpproxy rtpengine secfilter ims_icscf? (y/n): y INFO: creating extra tables into kamailio_5_8_5 ... /usr/local/lib64/kamailio//kamctl/kamdbctl.mysql: line 365: /usr/local/share/kamailio//mysql/ims_icscf-create.sql: No such file or directory ERROR: Creating extra tables failed at ims_icscf! ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -V version: kamailio 5.8.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled on 13:51:42 Feb 27 2025 with gcc 4.8.5 ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4159 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4159(a)github.com>

2 2

[kamailio/kamailio] Module snmpstats reporting inconsistent call success metrics on intense peaks of failed calls (Issue #4006)
by igorpotjevlesh 28 Feb '25

28 Feb '25

### Description We are plotting the call success rate on each of our proxies. Using the Kamailio snmpstats module, we try to obtain three counters in order to plot them on a graph: - Total Calls - Active Calls - Error Calls Most of the time, everything works well and we obtain sensible values: `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 309 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 95 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 214 -> Error calls However, **when our proxies are facing intense peaks of failed calls in a short timespan**, sometimes, the **"Error Calls"** counter returns a value **higher than "Total Calls"**. As a result, **"Active Calls"** suddenly reaches a value close to the **maximum of a _Gauge32_** (because ${TotalCalls} - {ErrorCalls} < 0$). `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 153 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 4294967226 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 223 -> Error calls As a result, our graphs make no more sense. ### Troubleshooting There seems to be a bug causing Total calls to be lower than Error calls when a high number of failed calls are received in a short time window. Moreover, there is an integer overflow resulting to the negative result of the substraction being converted to a _Gauge32_. Maybe setting it to 0 in case of a negative result would be safer ? #### Reproduction Using the following configuration for the snmpstats module of your Kamailio proxy: ``` # -------- snmpstats params ------- modparam("snmpstats", "snmpgetPath", "/usr/bin/") modparam("snmpstats", "snmpCommunity", "mycommunity") modparam("snmpstats", "sipEntityType", "proxyServer") ``` On intense peaks of failed calls, get the call success metrics using `snmpwalk` : `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 153 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 4294967226 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 223-> Error calls ### Additional Information **Kamailio Version**: `kamailio -v` > version: kamailio 5.6.4 (x86_64/linux) a004cf flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_ MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_S R_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, U SE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SI ZE 65535, DEFAULT PKG_SIZE 64MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf compiled on 16:10:41 May 22 2023 with gcc 4.4.7 * **Operating System**: `uname -r` > 2.6.32-279.el6.x86_64 `lsb_release -a` > LSB Version: :core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch Distributor ID: RedHatEnterpriseServer Description: Red Hat Enterprise Linux Server release 6.3 (Santiago) Release: 6.3 Codename: Santiago -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4006 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4006(a)github.com>

2 5

git:master:1f3b4505: dialplan: cmake - add pcre2
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 1f3b45056caf298062c6fbe683660ac6c158331a URL: https://github.com/kamailio/kamailio/commit/1f3b45056caf298062c6fbe683660ac… Author: drTr0jan <drtr0jan(a)yandex.ru> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T11:50:31+01:00 dialplan: cmake - add pcre2 --- Modified: src/modules/dialplan/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/1f3b45056caf298062c6fbe683660ac… Patch: https://github.com/kamailio/kamailio/commit/1f3b45056caf298062c6fbe683660ac… --- diff --git a/src/modules/dialplan/CMakeLists.txt b/src/modules/dialplan/CMakeLists.txt index 9c8de963961..9d716f3ebb0 100644 --- a/src/modules/dialplan/CMakeLists.txt +++ b/src/modules/dialplan/CMakeLists.txt @@ -1,3 +1,14 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) + +find_package(pcre2 QUIET) +if(NOT pcre2_FOUND) + message(STATUS "PCRE2 library not found... looking with pkg-config") + find_package(PkgConfig REQUIRED) + # TODO: verify we want 8-bit libpcre2 + pkg_check_modules(pcre2 REQUIRED IMPORTED_TARGET libpcre2-8) + add_library(PCRE2::8BIT ALIAS PkgConfig::pcre2) +endif() + +target_link_libraries(${module_name} PRIVATE PCRE2::8BIT)

1 0

git:master:41b2cba7: sctp: cmake - search for libsctp on linux only
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 41b2cba74a9fff204b2cc671670073d008b3c6b1 URL: https://github.com/kamailio/kamailio/commit/41b2cba74a9fff204b2cc671670073d… Author: drTr0jan <drtr0jan(a)yandex.ru> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T11:50:31+01:00 sctp: cmake - search for libsctp on linux only --- Modified: src/modules/sctp/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/41b2cba74a9fff204b2cc671670073d… Patch: https://github.com/kamailio/kamailio/commit/41b2cba74a9fff204b2cc671670073d… --- diff --git a/src/modules/sctp/CMakeLists.txt b/src/modules/sctp/CMakeLists.txt index 22e51fd7c08..0913855cb22 100644 --- a/src/modules/sctp/CMakeLists.txt +++ b/src/modules/sctp/CMakeLists.txt @@ -14,11 +14,11 @@ endif() target_include_directories(${module_name} PRIVATE ${SCTP_INCLUDE_DIR}) -find_library( - SCTP_LIBRARY - NAMES sctp - PATHS /usr/lib /usr/local/lib) +if(CMAKE_SYSTEM_NAME STREQUAL "Linux") + find_library( + SCTP_LIBRARY + NAMES sctp + PATHS /usr/lib /usr/local/lib) -if(UNIX) target_link_libraries(${module_name} PRIVATE ${SCTP_LIBRARY}) endif()

1 0

git:master:11a609d0: lib/ims: libxml2 is not needed - removed from cmake
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 11a609d06b527470c535a20866c48cafdedcb820 URL: https://github.com/kamailio/kamailio/commit/11a609d06b527470c535a20866c48ca… Author: drTr0jan <drtr0jan(a)yandex.ru> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T11:50:31+01:00 lib/ims: libxml2 is not needed - removed from cmake --- Modified: src/lib/ims/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/11a609d06b527470c535a20866c48ca… Patch: https://github.com/kamailio/kamailio/commit/11a609d06b527470c535a20866c48ca… --- diff --git a/src/lib/ims/CMakeLists.txt b/src/lib/ims/CMakeLists.txt index a501df57c48..914a09b9eab 100644 --- a/src/lib/ims/CMakeLists.txt +++ b/src/lib/ims/CMakeLists.txt @@ -1,4 +1,2 @@ -find_package(LibXml2 REQUIRED) - file(GLOB SRC_FILES "*.c") target_sources(kamailio PUBLIC ${SRC_FILES})

1 0

git:master:29e51c13: misc/examples: update default webrtc cfg to current main kamailio.cfg state
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 29e51c139725a58b2cbe9cfe409a1c62b3904a3e URL: https://github.com/kamailio/kamailio/commit/29e51c139725a58b2cbe9cfe409a1c6… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T10:37:34Z misc/examples: update default webrtc cfg to current main kamailio.cfg state --- Modified: misc/examples/webrtc/kamailio-default-websocket.cfg --- Diff: https://github.com/kamailio/kamailio/commit/29e51c139725a58b2cbe9cfe409a1c6… Patch: https://github.com/kamailio/kamailio/commit/29e51c139725a58b2cbe9cfe409a1c6…

1 0

git:master:3b28e015: kamailio.cfg: small whitespace indention fix
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 3b28e0151d15e7883c0ce81e63851fd9952dd2db URL: https://github.com/kamailio/kamailio/commit/3b28e0151d15e7883c0ce81e63851fd… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T10:32:40Z kamailio.cfg: small whitespace indention fix --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/3b28e0151d15e7883c0ce81e63851fd… Patch: https://github.com/kamailio/kamailio/commit/3b28e0151d15e7883c0ce81e63851fd… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index a9b675b6bd9..4cdd0091cb3 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -1016,7 +1016,7 @@ event_route[xhttp:request] { xhttp_reply("200", "OK", "text/html", "<html><body>Wrong URL $hu</body></html>"); - exit; + exit; } #!endif

1 0

git:master:4f573561: kamailio.cfg: small whitespace indention fix, spelling fix
by Henning Westerholt 25 Feb '25

25 Feb '25

Module: kamailio Branch: master Commit: 4f573561797b297131464699bd1ed6f0b5d7ed75 URL: https://github.com/kamailio/kamailio/commit/4f573561797b297131464699bd1ed6f… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-02-25T09:29:37Z kamailio.cfg: small whitespace indention fix, spelling fix --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/4f573561797b297131464699bd1ed6f… Patch: https://github.com/kamailio/kamailio/commit/4f573561797b297131464699bd1ed6f… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index a46f5734bfc..a9b675b6bd9 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -157,13 +157,13 @@ import_file "kamailio-local.cfg" #!endif # - flags -# FLT_ - per transaction (message) flags +# FLT_ - per transaction (message) flags #!define FLT_ACC 1 #!define FLT_ACCMISSED 2 #!define FLT_ACCFAILED 3 #!define FLT_NATS 5 -# FLB_ - per branch flags +# FLB_ - per branch flags #!define FLB_NATB 6 #!define FLB_NATSIPPING 7 @@ -192,7 +192,7 @@ children=8 # tcp_children=8 /* UDP receiving mode: - * - 0: multi-process (defaut) + * - 0: multi-process (default) * - 1: multi-threaded with async worker group 'udp' * - 2: per socket configuration (see core cookbook) */ # async_workers_group="name=udp;workers=8"

1 0

git:master:6cdbaa18: ims_dialog: right timer function prototype for print_all_dlgs()
by Daniel-Constantin Mierla 24 Feb '25

24 Feb '25

Module: kamailio Branch: master Commit: 6cdbaa1815bdcadc467f36109c6e3a7d00c344f5 URL: https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-24T12:30:26+01:00 ims_dialog: right timer function prototype for print_all_dlgs() --- Modified: src/modules/ims_dialog/dlg_handlers.c Modified: src/modules/ims_dialog/dlg_handlers.h --- Diff: https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7… Patch: https://github.com/kamailio/kamailio/commit/6cdbaa1815bdcadc467f36109c6e3a7… --- diff --git a/src/modules/ims_dialog/dlg_handlers.c b/src/modules/ims_dialog/dlg_handlers.c index 3487d7f4c2a..4acc5c3ad45 100644 --- a/src/modules/ims_dialog/dlg_handlers.c +++ b/src/modules/ims_dialog/dlg_handlers.c @@ -2048,7 +2048,7 @@ void internal_print_all_dlg(struct dlg_cell *dlg) * \return void */ -void print_all_dlgs() +void print_all_dlgs(unsigned int ticks, void *param) { //print all dialog information - this is just for testing and is set to happen every 10 seconds diff --git a/src/modules/ims_dialog/dlg_handlers.h b/src/modules/ims_dialog/dlg_handlers.h index fd8ef143352..5aafb054b18 100644 --- a/src/modules/ims_dialog/dlg_handlers.h +++ b/src/modules/ims_dialog/dlg_handlers.h @@ -196,7 +196,7 @@ void dlg_tmcb_dummy(struct cell *t, int type, struct tmcb_params *param); * \return void */ -void print_all_dlgs(); +void print_all_dlgs(unsigned int ticks, void *param); /*! * \brief Helper function that prints all the properties of a dialog including all the dlg_out's

1 0

[kamailio/kamailio] sl: doesn't handle 1xx_replies while metric exists (Issue #4144)
by Boris Korzun 24 Feb '25

24 Feb '25

### Description There're `1xx_replies` metric in `sl` module. But the metric doesn't work. ### Troubleshooting There're no handle in `void update_sl_stats(int code)`. https://github.com/kamailio/kamailio/blob/f37940b9a113ab79611f851334af7f8fb… ### Proposal Remove `1xx_replies` from `sl` module. Or add the handling. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4144 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4144(a)github.com>

2 2

git:master:f43c132d: sl: stats for 1xx replies
by Daniel-Constantin Mierla 24 Feb '25

24 Feb '25

Module: kamailio Branch: master Commit: f43c132db9b1dc71f623d592fb46d487ba492c7d URL: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-24T09:57:38+01:00 sl: stats for 1xx replies - GH #4144 --- Modified: src/modules/sl/sl_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… Patch: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… --- diff --git a/src/modules/sl/sl_stats.c b/src/modules/sl/sl_stats.c index 3394e0251f0..8e8c835c23b 100644 --- a/src/modules/sl/sl_stats.c +++ b/src/modules/sl/sl_stats.c @@ -148,7 +148,7 @@ void update_sl_stats(int code) my_stats = &(*sl_stats)[process_no]; - if(code >= 700 || code < 200) { + if(code >= 700 || code < 100) { my_stats->err[RT_xxx]++; } else if(code >= 600) { my_stats->err[RT_6xx]++; @@ -203,7 +203,7 @@ void update_sl_stats(int code) my_stats->err[RT_3xx]++; break; } - } else { /* 2xx */ + } else if(code >= 200) { switch(code) { case 200: my_stats->err[RT_200]++; @@ -215,6 +215,8 @@ void update_sl_stats(int code) my_stats->err[RT_2xx]++; break; } + } else { /* 1xx */ + my_stats->err[RT_1xx]++; } }

1 0

[kamailio/kamailio] SEGV in dialog module (PR #4151)
by Dennis 24 Feb '25

24 Feb '25

Fixes for SEGV in dialog module.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Hi ! The problem - periodically, 2-3 times in а month, kamailio dumps core with SEGV. Different OS versions (Ubuntu 18,20,22), different kamailio versions from 5.7.1 up to 5.8.4, high call load, python kemi, actively used dialog module. Analyzing core files shows more or less the same picture - SEGV happends in dialog mododule around the dialog vars, can be in rpc call (dlg.list), in destroy dlg, in accessing dlg variable. Backtrace can look like: ``` Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 236 dlg_var.c: No such file or directory. (gdb) bt full #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 var = 0x8 var_list = <optimized out> #1 0x00007fa2a2ce0397 in get_dlg_varref (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:297 var = 0x0 __func__ = "get_dlg_varref" #2 0x00007fa2a2ccd429 in ki_dlg_var_get_mode (msg=<optimized out>, name=0x7ffe67990d68, rmode=0) at dialog.c:2462 dlg = 0x7fa2818849b8 pval = <optimized out> #3 0x000055e2d5b87cbb in sr_kemi_exec_func (ket=ket@entry=0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728>, msg=msg@entry=0x7fa2a34577c0, pno=pno@entry=1, vps=vps@entry=0x7ffe67990d60) at core/kemiexec.c:82 ret = <optimized out> __func__ = "sr_kemi_exec_func" #4 0x00007fa2a2930376 in sr_apy_kemi_exec_func_ex (ket=ket@entry=0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728>, self=self@entry=0x7fa280ce2b80, args=args@entry=0x7fa2804ba3a0, idx=idx@entry=485) at apy_kemi.c:327 fname = <optimized out> i = <optimized out> ret = <optimized out> vps = {{vtype = 2, v = {n = -2142122656, l = 140335914274144, s = {s = 0x7fa28051cd60 "rtpe_setid", len = 10}, dict = 0x7fa28051cd60}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = { n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}} env_P = <optimized out> lmsg = 0x7fa2a34577c0 xret = <optimized out> slen = 10 alen = 1 pobj = <optimized out> __func__ = "sr_apy_kemi_exec_func_ex" #5 0x00007fa2a2931f45 in sr_apy_kemi_exec_func (self=0x7fa280ce2b80, args=0x7fa2804ba3a0, idx=485) at apy_kemi.c:356 ket = 0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728> ret = 0x0 pstate = 0x0 pframe = 0x0 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} tz = {tz_minuteswest = 2, tz_dsttime = 0} tdiff = <optimized out> __func__ = "sr_apy_kemi_exec_func" #6 0x00007fa2a266f697 in ?? () from /lib/x86_64-linux-gnu/libpython3.8.so.1.0 ``` Inspecting dlg vars, the chain look like this: ``` (gdb) frame 0 #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 236 in dlg_var.c (gdb) p *dlg.vars $1 = {key = {s = 0x7fa2833ea040 "mos", len = 3}, value = {s = 0x7fa2833ea0b0 "4.3", len = 3}, vflags = 1, next = 0x7fa2825fa3d0} (gdb) p *$.next $2 = {key = {s = 0x7fa200332e34 <error: Cannot access memory at address 0x7fa200332e34>, len = -1061109568}, value = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 49}, vflags = 1, next = 0x8} (gdb) ``` Additionaly, inspecting logs i found that this is happends in SIP race conditions, f.e. when caller and calle sends BYE at the same time and kamailio processing two different transactions of same dialog in two different workers, so present some competition from identical scenarios. Long time i can't reproduce this in lab, until insert an artificial delay into the scenario which process BYE request to increase competition. This code quickly causes SEGV in race conditions with BYE: ``` #kemi get/set dlg var while time.time()-start < 0.5: for i in ('bbb','ccc'): dlgvar=KSR.dialog.var_get(i) KSR.dialog.var_sets(i,str(random.randint(1,500000))) ``` SEGV not fire if i change dialog var_get/set to kamscript variant: ``` while time.time()-start < 0.5: for i in ('bbb','ccc'): dlgvar=KSR.pv.get(f"$dlg_var({i})") KSR.pv.sets(f"$dlg_var({i})", str(random.randint(1,500000))) ``` By analyzing source i found some places which are not properly covered by locks, and some dangerous places where direct pointer to dialog var structure used, which can change in concurrent process, so in first case i insert the locks, in second - it is better to use the clone of variable in private PV buffer. Also found some mistakes with dialog flags, which can potentionaly affect DMQ and DB dialog behavior. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4151 -- Commit Summary -- * dialog: covering by locks accessing/changing variables in kemi functions -- File Changes -- M src/modules/dialog/dialog.c (36) M src/modules/dialog/dlg_hash.h (2) M src/modules/dialog/dlg_var.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4151.patch https://github.com/kamailio/kamailio/pull/4151.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4151 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4151(a)github.com>

3 7

[kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)
by Javi Montoro 24 Feb '25

24 Feb '25

Hi There, We found a situation where topos seems to break, let me explain... Assuming the following scenario: ``` Caller ---- Callee A: ------INVITE-----> Record-Route:A.A.A.A, Record-Route:B.B.B.B B: <-----200 OK------ C: <-----INVITE------ Route: A.A.A.A, B.B.B.B D: ------200 OK-----> Record-Route:B.B.B.B, Record-Route:A.A.A.A (reversed order) E: <======INVITE===== Route: B.B.B.B, A.A.A.A (wrong) ``` A and B establish the connection from caller to callee, and topos works fine. C (re-INVITE from callee) sends the Route header according to the Record-Routes from the original INVITE (A) D is the 200 OK sent from the caller to the first re-INVITE (C) coming from the callee, with the Record-Route headers reversed, because is the order in which the callee received them; and according to the RFC it's working as intended: ``` When a UAS responds to a request with a response that establishes a dialog (such as a 2xx to INVITE), the UAS MUST copy all Record-Route header field values from the request into the response (including the URIs, URI parameters, and any Record-Route header field parameters, whether they are known or unknown to the UAS) and MUST maintain the order of those values. [...] [When a UAC receives a response...] The route set MUST be set to the list of URIs in the Record-Route header field from the response, taken in reverse order and preserving all URI parameters. ``` E takes the Route order from the last 200 OK ignoring they are in reversed order and assuming the top one is the first one, when it should be the other way around, sending to an IP address not reachable from the callee. And I think here is the issue, topos should not update the path on the Record-Routes from a 200 OK but if it does, it should take the reverse order When disabling topos, everything works fine, or with topos enabled, by setting rr_update=0 works for us, but what if there is a real path update, rr_update=0 wouldn't work for us anymore. The Kamailio version is 5.8.0-rc0 Let me know if you need more information. Thanks a lot, Javi -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3778 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3778(a)github.com>

5 16

git:master:2b1ca781: dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 2b1ca7813cf5014553c807c1a5034c404b3685a5 URL: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T10:49:47+01:00 dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL - GH #4151 --- Modified: src/modules/dialog/dlg_hash.h Modified: src/modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… Patch: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… --- diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h index 804b736b4ee..5d19841465a 100644 --- a/src/modules/dialog/dlg_hash.h +++ b/src/modules/dialog/dlg_hash.h @@ -70,7 +70,7 @@ #define DLG_FLAG_TM (1 << 9) /*!< dialog is set in transaction */ #define DLG_FLAG_EXPIRED (1 << 10) /*!< dialog is expired */ -#define DLG_FLAG_CHANGED_PROF (1 << 10) /*!< dialog-profiles changed DMQ*/ +#define DLG_FLAG_CHANGED_PROF (1 << 11) /*!< dialog-profiles changed - DMQ */ #define DLG_FLAG_DB_LOAD_EXTRA (1 << 12) /*!< dialog loaded extra from db */ /* internal flags stored in db */ diff --git a/src/modules/dialog/dlg_var.c b/src/modules/dialog/dlg_var.c index db5f61c4e05..3368728297c 100644 --- a/src/modules/dialog/dlg_var.c +++ b/src/modules/dialog/dlg_var.c @@ -197,8 +197,8 @@ int set_dlg_variable_unsafe(struct dlg_cell *dlg, str *key, str *val) it_prev->next = it->next; else *var_list = it->next; - /* Set the delete-flag for the current var: */ - it->vflags &= DLG_FLAG_DEL; + /* set the delete-flag for the current var */ + it->vflags |= DLG_FLAG_DEL; } else { /* replace the current it with var and free the it */ var->next = it->next;

1 0

git:master:3b213f1d: dialog: get vars via value instead of reference for kemi functions
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 3b213f1d008656682f1733d59f6c3bacd474c4b9 URL: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T10:49:47+01:00 dialog: get vars via value instead of reference for kemi functions - do lock/unlock - GH #4151 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… Patch: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 6871cc960e3..382941c9925 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1852,32 +1852,36 @@ static int fixup_dlg_bridge(void **param, int param_no) return 0; } -static str *ki_dlg_get_var_helper( - sip_msg_t *msg, str *sc, str *sf, str *st, str *key) +static int ki_dlg_get_var_helper( + sip_msg_t *msg, str *sc, str *sf, str *st, str *key, str *val) { dlg_cell_t *dlg = NULL; unsigned int dir = 0; - str *val = NULL; if(sc == NULL || sc->s == NULL || sc->len == 0) { LM_ERR("invalid Call-ID parameter\n"); - return val; + return -1; } if(sf == NULL || sf->s == NULL || sf->len == 0) { LM_ERR("invalid From tag parameter\n"); - return val; + return -1; } if(st == NULL) { LM_ERR("invalid To tag parameter\n"); - return val; + return -1; } dlg = get_dlg(sc, sf, st, &dir); - if(dlg == NULL) - return val; - val = get_dlg_varref(dlg, key); + if(dlg == NULL) { + LM_DBG("dialog not found for call-id: %.*s\n", sc->len, sc->s); + return -1; + } + if(get_dlg_varval(dlg, key, val) != 0) { + dlg_release(dlg); + return -1; + } dlg_release(dlg); - return val; + return 0; } /** @@ -1888,18 +1892,15 @@ static sr_kemi_xval_t _sr_kemi_dialog_xval = {0}; static sr_kemi_xval_t *ki_dlg_get_var( sip_msg_t *msg, str *sc, str *sf, str *st, str *key) { - str *val = NULL; - memset(&_sr_kemi_dialog_xval, 0, sizeof(sr_kemi_xval_t)); - val = ki_dlg_get_var_helper(msg, sc, sf, st, key); - if(!val) { + if(ki_dlg_get_var_helper(msg, sc, sf, st, key, &_sr_kemi_dialog_xval.v.s) + < 0) { sr_kemi_xval_null(&_sr_kemi_dialog_xval, SR_KEMI_XVAL_NULL_NONE); return &_sr_kemi_dialog_xval; } _sr_kemi_dialog_xval.vtype = SR_KEMIP_STR; - _sr_kemi_dialog_xval.v.s = *val; return &_sr_kemi_dialog_xval; } @@ -2504,8 +2505,12 @@ static int ki_dlg_var_sets(sip_msg_t *msg, str *name, str *val) int ret; dlg = dlg_get_msg_dialog(msg); + if(dlg) { + dlg_cell_lock(dlg); + } ret = set_dlg_variable_unsafe(dlg, name, val); if(dlg) { + dlg_cell_unlock(dlg); dlg_release(dlg); } @@ -2518,7 +2523,6 @@ static int ki_dlg_var_sets(sip_msg_t *msg, str *name, str *val) static sr_kemi_xval_t *ki_dlg_var_get_mode(sip_msg_t *msg, str *name, int rmode) { dlg_cell_t *dlg; - str *pval; memset(&_sr_kemi_dialog_xval, 0, sizeof(sr_kemi_xval_t)); @@ -2527,14 +2531,12 @@ static sr_kemi_xval_t *ki_dlg_var_get_mode(sip_msg_t *msg, str *name, int rmode) sr_kemi_xval_null(&_sr_kemi_dialog_xval, rmode); return &_sr_kemi_dialog_xval; } - pval = get_dlg_varref(dlg, name); - if(pval == NULL || pval->s == NULL) { + if(get_dlg_varval(dlg, name, &_sr_kemi_dialog_xval.v.s) < 0) { sr_kemi_xval_null(&_sr_kemi_dialog_xval, rmode); goto done; } _sr_kemi_dialog_xval.vtype = SR_KEMIP_STR; - _sr_kemi_dialog_xval.v.s = *pval; done: dlg_release(dlg); @@ -2572,7 +2574,12 @@ static int ki_dlg_var_rm(sip_msg_t *msg, str *name) dlg_cell_t *dlg; dlg = dlg_get_msg_dialog(msg); - set_dlg_variable_unsafe(dlg, name, NULL); + if(dlg) { + dlg_cell_lock(dlg); + set_dlg_variable_unsafe(dlg, name, NULL); + dlg_cell_unlock(dlg); + dlg_release(dlg); + } return 1; }

1 0

git:master:862a0f5f: modules: readme files regenerated - dmq ... [skip ci]
by Kamailio Dev 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 862a0f5fa50ad2d6f97078e3d856f6379e53ff1d URL: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-02-21T09:01:09+01:00 modules: readme files regenerated - dmq ... [skip ci] --- Modified: src/modules/dmq/README Modified: src/modules/dmq_usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63… Patch: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63…

1 0

[kamailio/kamailio] dmq and dmq_usrloc additions (PR #4134)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Add new api function to dmq to get local socket. Use that in dmq_usrloc. Sync dmq_usrloc UL_CONTACT_EXPIRE. Very useful for lost TCP connections, so contacts will be expired on all dmq nodes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4134 -- Commit Summary -- * dmq: add new api function * dmq_usrloc: new value for replicate_socket_info * dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions -- File Changes -- M src/modules/dmq/bind_dmq.c (1) M src/modules/dmq/bind_dmq.h (2) M src/modules/dmq/dmq_funcs.c (5) M src/modules/dmq/dmq_funcs.h (1) M src/modules/dmq_usrloc/dmq_usrloc.c (3) M src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml (26) M src/modules/dmq_usrloc/usrloc_sync.c (22) M src/modules/dmq_usrloc/usrloc_sync.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4134.patch https://github.com/kamailio/kamailio/pull/4134.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4134 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4134(a)github.com>

2 4

git:master:f9b503b3: dmq_usrloc: warn log when no dmq module server socket found
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: f9b503b35758b9f0f261ebf7e83ffbbe1d537f9f URL: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: warn log when no dmq module server socket found --- Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… Patch: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… --- diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 1760616aed5..87e151b4fa3 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -317,7 +317,7 @@ int usrloc_dmq_initialize() dmq_server_socket = usrloc_dmqb.get_dmq_server_socket(); dmq_server_socket_local = lookup_local_socket(&dmq_server_socket); if(dmq_server_socket_local == 0) { - LM_DBG("dmq local server socket <%.*s> not found ...ignoring\n", + LM_WARN("dmq local server socket <%.*s> not found ...ignoring\n", dmq_server_socket.len, dmq_server_socket.s); }

1 0

git:master:a83ec388: dmq_usrloc: add modparam for cflags replication
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: a83ec38863fca0473685b81f708938660a08da81 URL: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: add modparam for cflags replication --- Modified: src/modules/dmq_usrloc/dmq_usrloc.c Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… Patch: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… --- diff --git a/src/modules/dmq_usrloc/dmq_usrloc.c b/src/modules/dmq_usrloc/dmq_usrloc.c index 8c4544b1633..a568d3d3148 100644 --- a/src/modules/dmq_usrloc/dmq_usrloc.c +++ b/src/modules/dmq_usrloc/dmq_usrloc.c @@ -37,6 +37,7 @@ static int child_init(int); int dmq_usrloc_enable = 0; int _dmq_usrloc_sync = 1; int _dmq_usrloc_replicate_socket_info = 0; +int _dmq_usrloc_replicate_cflags = 1; int _dmq_usrloc_batch_size = 0; int _dmq_usrloc_batch_msg_contacts = 1; int _dmq_usrloc_batch_msg_size = 60000; @@ -54,6 +55,7 @@ static param_export_t params[] = { {"enable", PARAM_INT, &dmq_usrloc_enable}, {"sync", PARAM_INT, &_dmq_usrloc_sync}, {"replicate_socket_info", PARAM_INT, &_dmq_usrloc_replicate_socket_info}, + {"replicate_cflags", PARAM_INT, &_dmq_usrloc_replicate_cflags}, {"batch_msg_contacts", PARAM_INT, &_dmq_usrloc_batch_msg_contacts}, {"batch_msg_size", PARAM_INT, &_dmq_usrloc_batch_msg_size}, {"batch_size", PARAM_INT, &_dmq_usrloc_batch_size}, diff --git a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml index ff612b32eda..5d6727b5c83 100644 --- a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml +++ b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml @@ -292,6 +292,44 @@ modparam("dmq_usrloc", "replicate_socket_info", 1) </programlisting> </example> </section> + <section id="usrloc_dmq.p.replicate_cflags"> + <title><varname>replicate_cflags</varname> (int)</title> + <para> + The parameter controls whether the cflags replication is active or not. + This is important for anycast scenarios. + The value can be: + <itemizedlist> + <listitem> + <para> + 0 - disabled + </para> + </listitem> + <listitem> + <para> + 1 - enabled, replicate cflags + </para> + </listitem> + <listitem> + <para> + > 1 - enabled, set cflags corresponding to this value, on replicated peers + </para> + </listitem> + </itemizedlist> + </para> + <para> + <emphasis> + Default value is 1. + </emphasis> + </para> + <example> + <title>Set <varname>replicate_cflags</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dmq_usrloc", "replicate_cflags", 97) # will set cflags corresponding to 1 + 32 + 64 +... + </programlisting> + </example> + </section> <section id="usrloc_dmq.p.usrloc_delete"> <title><varname>usrloc_delete</varname> (int)</title> <para> diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 73017c52877..1760616aed5 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -60,6 +60,7 @@ static void srjson_to_xavp(srjson_t *json, sr_xavp_t **xavp); extern int _dmq_usrloc_sync; extern int _dmq_usrloc_replicate_socket_info; +extern int _dmq_usrloc_replicate_cflags; extern int _dmq_usrloc_batch_msg_contacts; extern int _dmq_usrloc_batch_msg_size; extern int _dmq_usrloc_batch_size; @@ -421,7 +422,12 @@ static int usrloc_dmq_execute_action(srjson_t *jdoc_action, dmq_node_t *node) } else if(strcmp(it->string, "flags") == 0) { flags = SRJSON_GET_UINT(it); } else if(strcmp(it->string, "cflags") == 0) { - cflags = SRJSON_GET_UINT(it); + if(_dmq_usrloc_replicate_cflags == 1) { + cflags = SRJSON_GET_UINT(it); + } else if(_dmq_usrloc_replicate_cflags > 1) { + cflags = _dmq_usrloc_replicate_cflags; + } + // else don't replicate cflags } else if(strcmp(it->string, "q") == 0) { q = SRJSON_GET_UINT(it); } else if(strcmp(it->string, "last_modified") == 0) {

1 0

git:master:2a1bd40c: dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 2a1bd40c0264a600107c653e5803760d7173bdc2 URL: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions --- Modified: src/modules/dmq_usrloc/dmq_usrloc.c Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… Patch: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… --- diff --git a/src/modules/dmq_usrloc/dmq_usrloc.c b/src/modules/dmq_usrloc/dmq_usrloc.c index 98f3b222728..8c4544b1633 100644 --- a/src/modules/dmq_usrloc/dmq_usrloc.c +++ b/src/modules/dmq_usrloc/dmq_usrloc.c @@ -43,6 +43,7 @@ int _dmq_usrloc_batch_msg_size = 60000; int _dmq_usrloc_batch_usleep = 0; str _dmq_usrloc_domain = str_init("location"); int _dmq_usrloc_delete = 1; +int _dmq_usrloc_delete_expired = 0; usrloc_api_t dmq_ul; @@ -59,6 +60,7 @@ static param_export_t params[] = { {"batch_usleep", PARAM_INT, &_dmq_usrloc_batch_usleep}, {"usrloc_domain", PARAM_STR, &_dmq_usrloc_domain}, {"usrloc_delete", PARAM_INT, &_dmq_usrloc_delete}, + {"usrloc_delete_expired", PARAM_INT, &_dmq_usrloc_delete_expired}, {0, 0, 0} }; @@ -116,6 +118,7 @@ static int mod_init(void) LM_ERR("Error in dmq_usrloc_initialize()\n"); } } + return 0; } diff --git a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml index b94947e2c77..ff612b32eda 100644 --- a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml +++ b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml @@ -303,11 +303,30 @@ modparam("dmq_usrloc", "replicate_socket_info", 1) </emphasis> </para> <example> - <title>Set <varname>usrloc_domain</varname> parameter</title> + <title>Set <varname>usrloc_delete</varname> parameter</title> <programlisting format="linespecific"> ... modparam("dmq_usrloc", "usrloc_delete", 0) ... +</programlisting> + </example> + </section> + <section id="usrloc_dmq.p.usrloc_delete_expired"> + <title><varname>usrloc_delete_expired</varname> (int)</title> + <para> + Enable (1) or disable (0) synchronizing usrloc expire actions using delete actions. In other words, sync delete of (UL_CONTACT_EXPIRE) expired contacts. + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>usrloc_delete_expired</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dmq_usrloc", "usrloc_delete_expired", 1) +... </programlisting> </example> </section> diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 00cf877e64b..73017c52877 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -66,6 +66,7 @@ extern int _dmq_usrloc_batch_size; extern int _dmq_usrloc_batch_usleep; extern str _dmq_usrloc_domain; extern int _dmq_usrloc_delete; +extern int _dmq_usrloc_delete_expired; static int add_contact(str aor, ucontact_info_t *ci) { @@ -1043,7 +1044,9 @@ void dmq_ul_cb_contact(ucontact_t *ptr, int type, void *param) } break; case UL_CONTACT_EXPIRE: - //usrloc_dmq_send_contact(ptr, aor, DMQ_UPDATE); + if(_dmq_usrloc_delete_expired >= 1) { + usrloc_dmq_send_contact(ptr, aor, DMQ_RM, 0); + } LM_DBG("Contact <%.*s> expired\n", aor.len, aor.s); break; }

1 0

git:master:7d4cd4ca: dmq_usrloc: new value for replicate_socket_info
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 7d4cd4cac82815c44fafa465efb8f15c51d64810 URL: https://github.com/kamailio/kamailio/commit/7d4cd4cac82815c44fafa465efb8f15… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: new value for replicate_socket_info To always use local dmq server_socket in "Socket:" field of replicated contacts. --- Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c Modified: src/modules/dmq_usrloc/usrloc_sync.h --- Diff: https://github.com/kamailio/kamailio/commit/7d4cd4cac82815c44fafa465efb8f15… Patch: https://github.com/kamailio/kamailio/commit/7d4cd4cac82815c44fafa465efb8f15… --- diff --git a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml index cd1b5279d86..b94947e2c77 100644 --- a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml +++ b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml @@ -271,6 +271,11 @@ modparam("dmq_usrloc", "usrloc_domain", "my_domain") 2 - enabled, replicate socket by socket name </para> </listitem> + <listitem> + <para> + 3 - enabled, use local socket from dmq server_socket modparam + </para> + </listitem> </itemizedlist> </para> <para> diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index ab134872d93..00cf877e64b 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -38,6 +38,7 @@ static str dmq_400_rpl = str_init("Bad Request"); static str dmq_500_rpl = str_init("Server Internal Error"); static int *usrloc_dmq_recv = 0; +static struct socket_info *dmq_server_socket_local = 0; dmq_api_t usrloc_dmqb; dmq_peer_t *usrloc_dmq_peer = NULL; @@ -287,6 +288,7 @@ void usrloc_get_all_ucontact(dmq_node_t *node) int usrloc_dmq_initialize() { dmq_peer_t not_peer; + str dmq_server_socket; /* load the DMQ API */ if(dmq_load_api(&usrloc_dmqb) != 0) { @@ -308,6 +310,15 @@ int usrloc_dmq_initialize() } else { LM_DBG("dmq peer registered\n"); } + + /* get local socket from DMQ API */ + dmq_server_socket = usrloc_dmqb.get_dmq_server_socket(); + dmq_server_socket_local = lookup_local_socket(&dmq_server_socket); + if(dmq_server_socket_local == 0) { + LM_DBG("dmq local server socket <%.*s> not found ...ignoring\n", + dmq_server_socket.len, dmq_server_socket.s); + } + return 0; error: return -1; @@ -430,8 +441,10 @@ static int usrloc_dmq_execute_action(srjson_t *jdoc_action, dmq_node_t *node) ci.ruid = ruid; ci.c = &c; ci.received = received; - if(_dmq_usrloc_replicate_socket_info - & (DMQ_USRLOC_REPLICATE_SOCKET | DMQ_USRLOC_REPLICATE_SOCKNAME)) + if(_dmq_usrloc_replicate_socket_info == DMQ_USRLOC_REPLICATE_SOCKET_LOCAL) { + sock = dmq_server_socket_local; + } + if(_dmq_usrloc_replicate_socket_info != 0) ci.sock = sock; ci.path = &path; ci.expires = expires; diff --git a/src/modules/dmq_usrloc/usrloc_sync.h b/src/modules/dmq_usrloc/usrloc_sync.h index cb55f3bb344..85cfc27e414 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.h +++ b/src/modules/dmq_usrloc/usrloc_sync.h @@ -31,6 +31,7 @@ #define DMQ_USRLOC_REPLICATE_SOCKET 1 #define DMQ_USRLOC_REPLICATE_SOCKNAME 2 +#define DMQ_USRLOC_REPLICATE_SOCKET_LOCAL 3 extern usrloc_api_t dmq_ul;

1 0

git:master:e1fef001: dmq: add new api function
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: e1fef0016d6162c4177c0d05cefdf0546685d183 URL: https://github.com/kamailio/kamailio/commit/e1fef0016d6162c4177c0d05cefdf05… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq: add new api function To return the dmq local server socket address. --- Modified: src/modules/dmq/bind_dmq.c Modified: src/modules/dmq/bind_dmq.h Modified: src/modules/dmq/dmq_funcs.c Modified: src/modules/dmq/dmq_funcs.h --- Diff: https://github.com/kamailio/kamailio/commit/e1fef0016d6162c4177c0d05cefdf05… Patch: https://github.com/kamailio/kamailio/commit/e1fef0016d6162c4177c0d05cefdf05… --- diff --git a/src/modules/dmq/bind_dmq.c b/src/modules/dmq/bind_dmq.c index ea38d982503..a0cdaeada20 100644 --- a/src/modules/dmq/bind_dmq.c +++ b/src/modules/dmq/bind_dmq.c @@ -37,5 +37,6 @@ int bind_dmq(dmq_api_t *api) api->send_message = dmq_send_message; api->bcast_message = bcast_dmq_message; api->find_dmq_node_uri = find_dmq_node_uri2; + api->get_dmq_server_socket = get_dmq_server_socket; return 0; } diff --git a/src/modules/dmq/bind_dmq.h b/src/modules/dmq/bind_dmq.h index a946718fa11..f6b7a378d14 100644 --- a/src/modules/dmq/bind_dmq.h +++ b/src/modules/dmq/bind_dmq.h @@ -36,6 +36,7 @@ typedef int (*bcast_message_t)(dmq_peer_t *peer, str *body, dmq_node_t *except, typedef int (*send_message_t)(dmq_peer_t *peer, str *body, dmq_node_t *node, dmq_resp_cback_t *resp_cback, int max_forwards, str *content_type); typedef dmq_node_t *(*find_dmq_node_uri_t)(str *uri); +typedef str (*get_dmq_server_socket_t)(); typedef struct dmq_api { @@ -43,6 +44,7 @@ typedef struct dmq_api bcast_message_t bcast_message; send_message_t send_message; find_dmq_node_uri_t find_dmq_node_uri; + get_dmq_server_socket_t get_dmq_server_socket; } dmq_api_t; typedef int (*bind_dmq_f)(dmq_api_t *api); diff --git a/src/modules/dmq/dmq_funcs.c b/src/modules/dmq/dmq_funcs.c index a5ba3b4866c..52d0d6bbc18 100644 --- a/src/modules/dmq/dmq_funcs.c +++ b/src/modules/dmq/dmq_funcs.c @@ -566,3 +566,8 @@ void ping_servers(unsigned int ticks, void *param) LM_ERR("error broadcasting message\n"); } } + +str get_dmq_server_socket() +{ + return dmq_server_socket; +} diff --git a/src/modules/dmq/dmq_funcs.h b/src/modules/dmq/dmq_funcs.h index 3f04a860f9f..ba8688d361f 100644 --- a/src/modules/dmq/dmq_funcs.h +++ b/src/modules/dmq/dmq_funcs.h @@ -70,5 +70,6 @@ int ki_dmq_bcast_message( int is_from_remote_node(sip_msg_t *msg); int ki_dmq_t_replicate(struct sip_msg *msg); int ki_dmq_t_replicate_mode(struct sip_msg *msg, int mode); +str get_dmq_server_socket(); #endif

1 0

[kamailio/kamailio] dmq: added remove_inactive parameter (PR #4146)
by Viktor Litvinov 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Add new parameter for dmq module "remove_inactive" that controls removing nodes behavior. Default value is 1, so the behavior will not changed by default. This is useful especially with notification peers that are defined as dns record together with enabled multi_notify option. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4146 -- Commit Summary -- * dmq: added remove_inactive parameter -- File Changes -- M src/modules/dmq/dmq.c (2) M src/modules/dmq/dmq.h (1) M src/modules/dmq/doc/dmq_admin.xml (20) M src/modules/dmq/notification_peer.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4146.patch https://github.com/kamailio/kamailio/pull/4146.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4146 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4146(a)github.com>

2 2

git:master:bd62a2fc: dmq: added remove_inactive parameter
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: bd62a2fcd24eb038156c7d80c66e8d8c14e4e6a3 URL: https://github.com/kamailio/kamailio/commit/bd62a2fcd24eb038156c7d80c66e8d8… Author: Viktor Litvinov <viktor.litvinov(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:52:22+01:00 dmq: added remove_inactive parameter --- Modified: src/modules/dmq/dmq.c Modified: src/modules/dmq/dmq.h Modified: src/modules/dmq/doc/dmq_admin.xml Modified: src/modules/dmq/notification_peer.c --- Diff: https://github.com/kamailio/kamailio/commit/bd62a2fcd24eb038156c7d80c66e8d8… Patch: https://github.com/kamailio/kamailio/commit/bd62a2fcd24eb038156c7d80c66e8d8… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 7c430ac0f53..5fc5f84c500 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -68,6 +68,7 @@ str dmq_notification_channel = str_init("notification_peer"); int dmq_multi_notify = 0; static sip_uri_t dmq_notification_uri = {0}; int dmq_ping_interval = 60; +int dmq_remove_inactive = 1; /* TM bind */ struct tm_binds _dmq_tmb = {0}; @@ -125,6 +126,7 @@ static param_export_t params[] = { {"notification_channel", PARAM_STR, &dmq_notification_channel}, {"multi_notify", PARAM_INT, &dmq_multi_notify}, {"worker_usleep", PARAM_INT, &dmq_worker_usleep}, + {"remove_inactive", PARAM_INT, &dmq_remove_inactive}, {0, 0, 0} }; diff --git a/src/modules/dmq/dmq.h b/src/modules/dmq/dmq.h index 6ebce766d40..cca70bc3266 100644 --- a/src/modules/dmq/dmq.h +++ b/src/modules/dmq/dmq.h @@ -50,6 +50,7 @@ extern str dmq_server_socket; extern sip_uri_t dmq_server_uri; extern str_list_t *dmq_notification_address_list; extern int dmq_multi_notify; +extern int dmq_remove_inactive; /* sl and tm */ extern struct tm_binds _dmq_tmb; extern sl_api_t _dmq_slb; diff --git a/src/modules/dmq/doc/dmq_admin.xml b/src/modules/dmq/doc/dmq_admin.xml index dade156af06..b75b43e8490 100644 --- a/src/modules/dmq/doc/dmq_admin.xml +++ b/src/modules/dmq/doc/dmq_admin.xml @@ -297,6 +297,26 @@ modparam("dmq", "ping_interval", 90) </programlisting> </example> </section> + <section id="dmq.p.remove_inactive"> + <title><varname>remove_inactive</varname>(int)</title> + <para> + A value of zero disable removing dmq nodes. Node status will be changed to pending. + A non-zero value (default is 1) enable removing nodes. + For node that is defined as notification address status will be changed to pending. + Otherwise it will be marked as disabled and then will be removed. + </para> + <para> + <emphasis>Default value is <quote>1</quote>.</emphasis> + </para> + <example> + <title>Set <varname>remove_inactive</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dmq", "remove_inactive", 0) +... +</programlisting> + </example> + </section> </section> <section> diff --git a/src/modules/dmq/notification_peer.c b/src/modules/dmq/notification_peer.c index 0b8a41b3b91..7a88209a7b4 100644 --- a/src/modules/dmq/notification_peer.c +++ b/src/modules/dmq/notification_peer.c @@ -628,6 +628,11 @@ int notification_resp_callback_f( run_init_callbacks(); } } else if(code == 408) { + if(!dmq_remove_inactive) { + /* put the node in pending state */ + update_dmq_node_status(dmq_node_list, node, DMQ_NODE_PENDING); + return 0; + } /* TODO this probably do not work for dmq_multi_notify */ slp = dmq_notification_address_list; while(slp != NULL) {

1 0

[kamailio/kamailio] topos_htable: fix xtag and add more snprintf checks (PR #4133)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Few fixes to topos_htable module. To be backported in 6.0 branch. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4133 -- Commit Summary -- * topos_htable: fix xtag and add more snprintf checks -- File Changes -- M src/modules/topos_htable/topos_htable_storage.c (25) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4133.patch https://github.com/kamailio/kamailio/pull/4133.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4133 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4133(a)github.com>

2 3

git:master:e0e08846: topos_htable: fix xtag and add more snprintf checks
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: e0e0884627609804661082a1235f87a7bbb5e67a URL: https://github.com/kamailio/kamailio/commit/e0e0884627609804661082a1235f87a… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:47:15+01:00 topos_htable: fix xtag and add more snprintf checks --- Modified: src/modules/topos_htable/topos_htable_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/e0e0884627609804661082a1235f87a… Patch: https://github.com/kamailio/kamailio/commit/e0e0884627609804661082a1235f87a… --- diff --git a/src/modules/topos_htable/topos_htable_storage.c b/src/modules/topos_htable/topos_htable_storage.c index 043652e5280..eec48ce7641 100644 --- a/src/modules/topos_htable/topos_htable_storage.c +++ b/src/modules/topos_htable/topos_htable_storage.c @@ -185,7 +185,7 @@ static int tps_htable_insert_initial_method_branch( } if(ret < 0 || ret >= TPS_HTABLE_SIZE_VAL) { - LM_ERR("failed to build htable value\n"); + LM_ERR("failed to build htable val\n"); return -1; } @@ -758,7 +758,7 @@ static int tps_htable_insert_dialog_helper(tps_data_t *td, int set_expire) td->a_uuid.len, td->a_uuid.s) : snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%.*s", td->b_uuid.len, td->b_uuid.s); - if(ret < 0) { + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { LM_ERR("failed to build htable key\n"); return -1; } @@ -771,6 +771,11 @@ static int tps_htable_insert_dialog_helper(tps_data_t *td, int set_expire) ret = snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%s", _tps_base64_buf[0]); } + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { + LM_ERR("failed to build htable key\n"); + return -1; + } + // build val rectime = (unsigned long)time(NULL); @@ -849,7 +854,7 @@ static int tps_htable_insert_dialog_helper(tps_data_t *td, int set_expire) td->x_context.s); } - if(ret < 0) { + if(ret < 0 || ret >= TPS_HTABLE_SIZE_VAL) { LM_ERR("failed to build htable val\n"); return -1; } @@ -919,7 +924,7 @@ int tps_htable_load_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) md->a_uuid.len, md->a_uuid.s) : snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%.*s", md->b_uuid.len, md->b_uuid.s); - if(ret < 0) { + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { LM_ERR("failed to build htable key\n"); return -1; } @@ -931,6 +936,10 @@ int tps_htable_load_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) _tps_base64_buf[0], TPS_BASE64_SIZE - 1); ret = snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%s", _tps_base64_buf[0]); } + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { + LM_ERR("failed to build htable key\n"); + return -1; + } hkey.s = _tps_htable_key_buf; hkey.len = strlen(_tps_htable_key_buf); @@ -1190,7 +1199,7 @@ int tps_htable_end_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) sd->a_uuid.len, sd->a_uuid.s) : snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%.*s", sd->b_uuid.len, sd->b_uuid.s); - if(ret < 0) { + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { LM_ERR("failed to build htable key\n"); return -1; } @@ -1202,6 +1211,10 @@ int tps_htable_end_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) _tps_base64_buf[0], TPS_BASE64_SIZE - 1); ret = snprintf(ptr, TPS_HTABLE_SIZE_KEY, "%s", _tps_base64_buf[0]); } + if(ret < 0 || ret >= TPS_HTABLE_SIZE_KEY) { + LM_ERR("failed to build htable key\n"); + return -1; + } // dialog ended -- keep it for branch lifetime only

1 0

git:master:c67afd6b: modules: readme files regenerated - nathelper ... [skip ci]
by Kamailio Dev 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: c67afd6ba65c612125b13ea9f264657a532f7396 URL: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-02-21T08:46:10+01:00 modules: readme files regenerated - nathelper ... [skip ci] --- Modified: src/modules/nathelper/README --- Diff: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657… Patch: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657…

1 0

[kamailio/kamailio] dispatcher: skip ping for DS_NODNSARES_DST (PR #4150)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Dispatcher timer regularly pings the nodes. Should skip resolving and pinging the no-dns-A flag ones since those node do not have an A record by definition. Otherwise that no-dns-A flag(state) is overwritten by the pinging process. This leads to node removal from group, after RPC commands e.g. "kamcmd dispatcher.add/remove". You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4150 -- Commit Summary -- * dispatcher: skip ping for DS_NODNSARES_DST -- File Changes -- M src/modules/dispatcher/dispatch.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4150.patch https://github.com/kamailio/kamailio/pull/4150.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4150 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4150(a)github.com>

2 2

git:master:5f29b449: dispatcher: skip ping for DS_NODNSARES_DST
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 5f29b4491634c360ade5691977d622617ae014ad URL: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:44:12+01:00 dispatcher: skip ping for DS_NODNSARES_DST --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… Patch: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 9968eab5537..fb0e233df7c 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -4114,6 +4114,9 @@ void ds_ping_set(ds_set_t *node) /* skip addresses with no-ping flag */ if((node->dlist[j].flags & DS_NOPING_DST) != 0) continue; + /* skip addresses with no-DNS-A flag */ + if((node->dlist[j].flags & DS_NODNSARES_DST) != 0) + continue; /* If the Flag of the entry has "Probing set, send a probe: */ if(ds_ping_result_helper(node, j)) { LM_DBG("probing set #%d, URI %.*s\n", node->id,

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev