- sr-dev - kamailio.org

git:master:ef62bfb2: core: mem/tlsf - handle return codes during memory pool init
by Daniel-Constantin Mierla 25 Apr '22

25 Apr '22

Module: kamailio Branch: master Commit: ef62bfb27514dc7ec3b603bee661cfac18c4fe93 URL: https://github.com/kamailio/kamailio/commit/ef62bfb27514dc7ec3b603bee661cfa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-25T09:46:18+02:00 core: mem/tlsf - handle return codes during memory pool init --- Modified: src/core/mem/tlsf_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/ef62bfb27514dc7ec3b603bee661cfa… Patch: https://github.com/kamailio/kamailio/commit/ef62bfb27514dc7ec3b603bee661cfa… --- diff --git a/src/core/mem/tlsf_malloc.c b/src/core/mem/tlsf_malloc.c index 19b71a8be3..805ada03cc 100644 --- a/src/core/mem/tlsf_malloc.c +++ b/src/core/mem/tlsf_malloc.c @@ -936,7 +936,13 @@ tlsf_t tlsf_create(void* mem) tlsf_t tlsf_create_with_pool(void* mem, size_t bytes) { tlsf_t tlsf = tlsf_create(mem); - tlsf_add_pool(tlsf, (char*)mem + tlsf_size(), bytes - tlsf_size()); + if(tlsf) { + pool_t p; + p = tlsf_add_pool(tlsf, (char*)mem + tlsf_size(), bytes - tlsf_size()); + if(!p) { + return NULL; + } + } return tlsf; } @@ -1387,6 +1393,12 @@ int tlsf_malloc_init_pkg_manager(void) _tlsf_pkg_pool = malloc(pkg_mem_size); if (_tlsf_pkg_pool) { _tlsf_pkg_block = tlsf_create_with_pool(_tlsf_pkg_pool, pkg_mem_size); + if(_tlsf_pkg_block==NULL) { + LM_CRIT("could not create tlsf pkg memory pool\n"); + fprintf(stderr, "could not create tlsf pkg memory pool: %ld bytes\n", + pkg_mem_size); + return -1; + } } else { LOG(L_CRIT, "could not initialize tlsf pkg memory pool\n"); fprintf(stderr, "Too much tlsf pkg memory demanded: %ld bytes\n", @@ -1639,6 +1651,12 @@ int tlsf_malloc_init_shm_manager(void) _tlsf_shm_pool = shm_core_get_pool(); if (_tlsf_shm_pool) { _tlsf_shm_block = tlsf_create_with_pool(_tlsf_shm_pool, shm_mem_size); + if(!_tlsf_shm_block) { + LM_CRIT("could not create tlsf shm memory pool\n"); + fprintf(stderr, "could not create tlsf shm memory pool: %ld bytes\n", + shm_mem_size); + return -1; + } } else { LOG(L_CRIT, "could not initialize tlsf shm memory pool\n"); fprintf(stderr, "Too much tlsf shm memory demanded: %ld bytes\n",

1 0

git:master:5504c68c: kamdbctl: version set to 5.6.0
by Daniel-Constantin Mierla 25 Apr '22

25 Apr '22

Module: kamailio Branch: master Commit: 5504c68c88d6f8fcc85db4d18b818203a748329d URL: https://github.com/kamailio/kamailio/commit/5504c68c88d6f8fcc85db4d18b81820… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-25T09:46:18+02:00 kamdbctl: version set to 5.6.0 --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/5504c68c88d6f8fcc85db4d18b81820… Patch: https://github.com/kamailio/kamailio/commit/5504c68c88d6f8fcc85db4d18b81820… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index 89ddc81477..60c20f224d 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='5.4.0' +VERSION='5.6.0' PATH=$PATH:/usr/local/sbin/

1 0

git:5.4:de2f80e1: pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: 5.4 Commit: de2f80e103faac3dad820fabbe772a4d7085c3d8 URL: https://github.com/kamailio/kamailio/commit/de2f80e103faac3dad820fabbe772a4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T11:08:11+02:00 pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules (cherry picked from commit ec22a2127750b5422d5ab01a23c4ea7404bad3cf) (cherry picked from commit 9333fe21023bb0a902b2fbf58c9ee556946d0a30) --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/de2f80e103faac3dad820fabbe772a4… Patch: https://github.com/kamailio/kamailio/commit/de2f80e103faac3dad820fabbe772a4…

1 0

git:5.4:0c3ef261: pkg/kamailio/deb: update copyright with new paths
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: 5.4 Commit: 0c3ef2619024673edc52a4d39b74dbea491cdea3 URL: https://github.com/kamailio/kamailio/commit/0c3ef2619024673edc52a4d39b74dbe… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T11:08:02+02:00 pkg/kamailio/deb: update copyright with new paths * remove duplicate-globbing-patterns (cherry picked from commit 0030a756375217f4e1b5de55f96c6b2ba89a87d4) (cherry picked from commit 0d4a53e415a531a4270b18e141a5f922682ed507) --- Modified: pkg/kamailio/deb/bionic/copyright Modified: pkg/kamailio/deb/buster/copyright Modified: pkg/kamailio/deb/debian/copyright Modified: pkg/kamailio/deb/focal/copyright Modified: pkg/kamailio/deb/jessie/copyright Modified: pkg/kamailio/deb/precise/copyright Modified: pkg/kamailio/deb/sid/copyright Modified: pkg/kamailio/deb/stretch/copyright Modified: pkg/kamailio/deb/trusty/copyright Modified: pkg/kamailio/deb/wheezy/copyright Modified: pkg/kamailio/deb/xenial/copyright --- Diff: https://github.com/kamailio/kamailio/commit/0c3ef2619024673edc52a4d39b74dbe… Patch: https://github.com/kamailio/kamailio/commit/0c3ef2619024673edc52a4d39b74dbe…

1 0

git:5.5:0d4a53e4: pkg/kamailio/deb: update copyright with new paths
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: 5.5 Commit: 0d4a53e415a531a4270b18e141a5f922682ed507 URL: https://github.com/kamailio/kamailio/commit/0d4a53e415a531a4270b18e141a5f92… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T11:06:23+02:00 pkg/kamailio/deb: update copyright with new paths * remove duplicate-globbing-patterns (cherry picked from commit 0030a756375217f4e1b5de55f96c6b2ba89a87d4) --- Modified: pkg/kamailio/deb/bionic/copyright Modified: pkg/kamailio/deb/bullseye/copyright Modified: pkg/kamailio/deb/buster/copyright Modified: pkg/kamailio/deb/debian/copyright Modified: pkg/kamailio/deb/focal/copyright Modified: pkg/kamailio/deb/jessie/copyright Modified: pkg/kamailio/deb/precise/copyright Modified: pkg/kamailio/deb/sid/copyright Modified: pkg/kamailio/deb/stretch/copyright Modified: pkg/kamailio/deb/trusty/copyright Modified: pkg/kamailio/deb/wheezy/copyright Modified: pkg/kamailio/deb/xenial/copyright --- Diff: https://github.com/kamailio/kamailio/commit/0d4a53e415a531a4270b18e141a5f92… Patch: https://github.com/kamailio/kamailio/commit/0d4a53e415a531a4270b18e141a5f92…

1 0

git:5.5:9333fe21: pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: 5.5 Commit: 9333fe21023bb0a902b2fbf58c9ee556946d0a30 URL: https://github.com/kamailio/kamailio/commit/9333fe21023bb0a902b2fbf58c9ee55… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T11:06:44+02:00 pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules (cherry picked from commit ec22a2127750b5422d5ab01a23c4ea7404bad3cf) --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/9333fe21023bb0a902b2fbf58c9ee55… Patch: https://github.com/kamailio/kamailio/commit/9333fe21023bb0a902b2fbf58c9ee55…

1 0

git:master:ec22a212: pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: master Commit: ec22a2127750b5422d5ab01a23c4ea7404bad3cf URL: https://github.com/kamailio/kamailio/commit/ec22a2127750b5422d5ab01a23c4ea7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T10:28:46+02:00 pkg/kamailio/deb: add breaks/replaces to kamailio-cnxcc-modules --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/ec22a2127750b5422d5ab01a23c4ea7… Patch: https://github.com/kamailio/kamailio/commit/ec22a2127750b5422d5ab01a23c4ea7…

1 0

git:master:e59fcc4d: Revert "pkg/kamailio/deb: remove radius old Breaks/Replaces"
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: master Commit: e59fcc4d828e12e1fc506775477772c8fa5c2ef5 URL: https://github.com/kamailio/kamailio/commit/e59fcc4d828e12e1fc506775477772c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T10:27:06+02:00 Revert "pkg/kamailio/deb: remove radius old Breaks/Replaces" This reverts commit 61ea9c85140766ff6fd3201d3117803114436bd4. --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/e59fcc4d828e12e1fc506775477772c… Patch: https://github.com/kamailio/kamailio/commit/e59fcc4d828e12e1fc506775477772c…

1 0

git:master:0030a756: pkg/kamailio/deb: update copyright with new paths
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: master Commit: 0030a756375217f4e1b5de55f96c6b2ba89a87d4 URL: https://github.com/kamailio/kamailio/commit/0030a756375217f4e1b5de55f96c6b2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T09:17:53+02:00 pkg/kamailio/deb: update copyright with new paths * remove duplicate-globbing-patterns --- Modified: pkg/kamailio/deb/bionic/copyright Modified: pkg/kamailio/deb/bookworm/copyright Modified: pkg/kamailio/deb/bullseye/copyright Modified: pkg/kamailio/deb/buster/copyright Modified: pkg/kamailio/deb/debian/copyright Modified: pkg/kamailio/deb/focal/copyright Modified: pkg/kamailio/deb/jessie/copyright Modified: pkg/kamailio/deb/precise/copyright Modified: pkg/kamailio/deb/sid/copyright Modified: pkg/kamailio/deb/stretch/copyright Modified: pkg/kamailio/deb/trusty/copyright Modified: pkg/kamailio/deb/wheezy/copyright Modified: pkg/kamailio/deb/xenial/copyright --- Diff: https://github.com/kamailio/kamailio/commit/0030a756375217f4e1b5de55f96c6b2… Patch: https://github.com/kamailio/kamailio/commit/0030a756375217f4e1b5de55f96c6b2…

1 0

git:master:61ea9c85: pkg/kamailio/deb: remove radius old Breaks/Replaces
by Victor Seva 23 Apr '22

23 Apr '22

Module: kamailio Branch: master Commit: 61ea9c85140766ff6fd3201d3117803114436bd4 URL: https://github.com/kamailio/kamailio/commit/61ea9c85140766ff6fd3201d3117803… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-23T09:25:09+02:00 pkg/kamailio/deb: remove radius old Breaks/Replaces --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/61ea9c85140766ff6fd3201d3117803… Patch: https://github.com/kamailio/kamailio/commit/61ea9c85140766ff6fd3201d3117803…

1 0

git:master:3da9060a: janssonrpcc: do not set TCP_KEEPIDLE if not available in the OS
by Daniel-Constantin Mierla 22 Apr '22

22 Apr '22

Module: kamailio Branch: master Commit: 3da9060a4479b5d1275088213b560f9e3b250394 URL: https://github.com/kamailio/kamailio/commit/3da9060a4479b5d1275088213b560f9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-22T13:17:01+02:00 janssonrpcc: do not set TCP_KEEPIDLE if not available in the OS --- Modified: src/modules/janssonrpcc/janssonrpc_connect.c --- Diff: https://github.com/kamailio/kamailio/commit/3da9060a4479b5d1275088213b560f9… Patch: https://github.com/kamailio/kamailio/commit/3da9060a4479b5d1275088213b560f9… --- diff --git a/src/modules/janssonrpcc/janssonrpc_connect.c b/src/modules/janssonrpcc/janssonrpc_connect.c index b6f4d69912..6f5048efd4 100644 --- a/src/modules/janssonrpcc/janssonrpc_connect.c +++ b/src/modules/janssonrpcc/janssonrpc_connect.c @@ -316,8 +316,12 @@ int set_keepalive(int fd, int keepalive, int cnt, int idle, int intvl) { res = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT, &idle, sizeof(idle)); assert(res == 0); +#ifdef HAVE_TCP_KEEPIDLE res = setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, &idle, sizeof(idle)); assert(res == 0); +#else + LM_INFO("TCP_KEEPIDLE option not available - ignoring\n"); +#endif res = setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, &intvl, sizeof(intvl)); assert(res == 0);

1 0

git:master:dbf9b284: ims_diameter_server: 0-terminate value converted to json
by Daniel-Constantin Mierla 22 Apr '22

22 Apr '22

Module: kamailio Branch: master Commit: dbf9b28402d9506c5761476febc31fbf45eb08fa URL: https://github.com/kamailio/kamailio/commit/dbf9b28402d9506c5761476febc31fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-22T12:29:35+02:00 ims_diameter_server: 0-terminate value converted to json --- Modified: src/modules/ims_diameter_server/avp_helper.c --- Diff: https://github.com/kamailio/kamailio/commit/dbf9b28402d9506c5761476febc31fb… Patch: https://github.com/kamailio/kamailio/commit/dbf9b28402d9506c5761476febc31fb… --- diff --git a/src/modules/ims_diameter_server/avp_helper.c b/src/modules/ims_diameter_server/avp_helper.c index 04e2d6d967..73c0e047ea 100644 --- a/src/modules/ims_diameter_server/avp_helper.c +++ b/src/modules/ims_diameter_server/avp_helper.c @@ -164,9 +164,10 @@ int AAAmsg2json(AAAMessage * request, str * dest) { } dest->len = strlen(out); - dest->s = pkg_malloc(dest->len); + dest->s = pkg_malloc(dest->len + 1); if (dest->s) { memcpy(dest->s, out, dest->len); + dest->s[dest->len] = '\0'; free(out); } else { LM_WARN("Failed to allocate %d bytes for the JSON\n", dest->len);

1 0

git:master:b8b6c915: janssonrpcc: close fd in case of error
by Daniel-Constantin Mierla 22 Apr '22

22 Apr '22

Module: kamailio Branch: master Commit: b8b6c915a0f8d3f820e6c51a272ccd8d8c8f9ac7 URL: https://github.com/kamailio/kamailio/commit/b8b6c915a0f8d3f820e6c51a272ccd8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-22T13:05:54+02:00 janssonrpcc: close fd in case of error --- Modified: src/modules/janssonrpcc/janssonrpc_connect.c --- Diff: https://github.com/kamailio/kamailio/commit/b8b6c915a0f8d3f820e6c51a272ccd8… Patch: https://github.com/kamailio/kamailio/commit/b8b6c915a0f8d3f820e6c51a272ccd8… --- diff --git a/src/modules/janssonrpcc/janssonrpc_connect.c b/src/modules/janssonrpcc/janssonrpc_connect.c index 0ba40f1643..b6f4d69912 100644 --- a/src/modules/janssonrpcc/janssonrpc_connect.c +++ b/src/modules/janssonrpcc/janssonrpc_connect.c @@ -338,7 +338,7 @@ void bev_connect(jsonrpc_server_t* server) } else { INFO("setting up socket"); fd = socket(AF_INET, SOCK_STREAM, 0); - if (fd <= 0) { + if (fd < 0) { server->keep_alive_socket_fd = -1; ERR("could not setup socket"); } else { @@ -346,6 +346,9 @@ void bev_connect(jsonrpc_server_t* server) } } if (!fd_is_valid(fd)) { // make sure socket is valid + if (fd >= 0) { + close(fd); + } fd = -1; server->keep_alive_socket_fd = -1; }

1 0

git:master:55255570: tcpops: remove explicit compile warning about unavailable TCP_KEEPIDLE
by Daniel-Constantin Mierla 22 Apr '22

22 Apr '22

Module: kamailio Branch: master Commit: 55255570cf74f8c86d7757a3fb08ac3aad7cfa55 URL: https://github.com/kamailio/kamailio/commit/55255570cf74f8c86d7757a3fb08ac3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-22T13:15:57+02:00 tcpops: remove explicit compile warning about unavailable TCP_KEEPIDLE --- Modified: src/modules/tcpops/tcpops.c --- Diff: https://github.com/kamailio/kamailio/commit/55255570cf74f8c86d7757a3fb08ac3… Patch: https://github.com/kamailio/kamailio/commit/55255570cf74f8c86d7757a3fb08ac3… --- diff --git a/src/modules/tcpops/tcpops.c b/src/modules/tcpops/tcpops.c index cb1728390c..fa886c5460 100644 --- a/src/modules/tcpops/tcpops.c +++ b/src/modules/tcpops/tcpops.c @@ -168,7 +168,6 @@ int tcpops_keepalive_enable(int fd, int idle, int count, int interval, int close LM_ERR("failed to set keepalive idle interval: %s\n", strerror(errno)); } #else - #warning "TCP_KEEPIDLE option not supported by this platform" LM_DBG("TCP_KEEPIDLE option not available - ignoring\n"); #endif

1 0

git:master:1e97d6e6: evrexec: free resources in case of failure
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 1e97d6e63c89c7a27be7152ac38192d056fef7c8 URL: https://github.com/kamailio/kamailio/commit/1e97d6e63c89c7a27be7152ac38192d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T20:00:11+02:00 evrexec: free resources in case of failure --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1e97d6e63c89c7a27be7152ac38192d… Patch: https://github.com/kamailio/kamailio/commit/1e97d6e63c89c7a27be7152ac38192d… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 253197d100..3087e65369 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -259,11 +259,14 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) if(it->sockfd==-1) { LM_ERR("failed to create socket - address: %.*s (%d/%s)\n", it->sockaddr.len, it->sockaddr.s, errno, strerror(errno)); + freeaddrinfo(res); return; } if(bind(it->sockfd, res->ai_addr, res->ai_addrlen)==-1) { LM_ERR("failed to bind socket - address: %.*s (%d/%s)\n", it->sockaddr.len, it->sockaddr.s, errno, strerror(errno)); + close(it->sockfd); + freeaddrinfo(res); return; } freeaddrinfo(res);

1 0

git:master:e2df1d91: pua_reginfo: clang format code files
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: e2df1d91de0e0351a7976720d1e9a101af746cf7 URL: https://github.com/kamailio/kamailio/commit/e2df1d91de0e0351a7976720d1e9a10… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T16:07:17+02:00 pua_reginfo: clang format code files --- Modified: src/modules/pua_reginfo/notify.c Modified: src/modules/pua_reginfo/notify.h Modified: src/modules/pua_reginfo/pua_reginfo.c Modified: src/modules/pua_reginfo/pua_reginfo.h Modified: src/modules/pua_reginfo/subscribe.c Modified: src/modules/pua_reginfo/subscribe.h Modified: src/modules/pua_reginfo/usrloc_cb.c Modified: src/modules/pua_reginfo/usrloc_cb.h --- Diff: https://github.com/kamailio/kamailio/commit/e2df1d91de0e0351a7976720d1e9a10… Patch: https://github.com/kamailio/kamailio/commit/e2df1d91de0e0351a7976720d1e9a10…

1 0

[kamailio/kamailio] ims_registrar_scscf: replace unregistered state with deregistered (PR #3076)
by Kristiyan Peychev 21 Apr '22

21 Apr '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This is the actual application of PR #3051; registration termination requests work properly now. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3076 -- Commit Summary -- * ims_registrar_scscf: replace unregistered state with deregistered where relevant for CxDx Registration Termination Requests -- File Changes -- M src/modules/ims_registrar_scscf/cxdx_callbacks.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3076.patch https://github.com/kamailio/kamailio/pull/3076.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3076 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3076(a)github.com>

3 2

git:master:27a98c58: ims_registrar_scscf: replace unregistered state with deregistered where relevant for CxDx Registration Termination Requests
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 27a98c580f41a279417a8493461ff0567b3ce12a URL: https://github.com/kamailio/kamailio/commit/27a98c580f41a279417a8493461ff05… Author: Kristiyan Peychev <kristiyan.peychev(a)flolive.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T15:30:05+02:00 ims_registrar_scscf: replace unregistered state with deregistered where relevant for CxDx Registration Termination Requests --- Modified: src/modules/ims_registrar_scscf/cxdx_callbacks.c --- Diff: https://github.com/kamailio/kamailio/commit/27a98c580f41a279417a8493461ff05… Patch: https://github.com/kamailio/kamailio/commit/27a98c580f41a279417a8493461ff05… --- diff --git a/src/modules/ims_registrar_scscf/cxdx_callbacks.c b/src/modules/ims_registrar_scscf/cxdx_callbacks.c index ca601bd991..00fc280b4d 100644 --- a/src/modules/ims_registrar_scscf/cxdx_callbacks.c +++ b/src/modules/ims_registrar_scscf/cxdx_callbacks.c @@ -90,10 +90,9 @@ AAAMessage* cxdx_process_rtr(AAAMessage *rtr) { while (impucontact) { LM_DBG("Deleting contact with AOR [%.*s]\n", impucontact->contact->aor.len, impucontact->contact->aor.s); ul.lock_contact_slot_i(impucontact->contact->sl); - impucontact->contact->state = CONTACT_DELETE_PENDING; if (r->shead) { //send NOTIFY to all subscribers of this IMPU. - notify_subscribers(r, impucontact->contact, 0, 0, IMS_REGISTRAR_CONTACT_UNREGISTERED); + notify_subscribers(r, impucontact->contact, 0, 0, IMS_REGISTRAR_CONTACT_DEREGISTERED); } impucontact->contact->state = CONTACT_DELETED; ul.unlock_contact_slot_i(impucontact->contact->sl); @@ -119,10 +118,9 @@ AAAMessage* cxdx_process_rtr(AAAMessage *rtr) { while (impucontact) { LM_DBG("Deleting contact with AOR [%.*s]\n", impucontact->contact->aor.len, impucontact->contact->aor.s); ul.lock_contact_slot_i(impucontact->contact->sl); - impucontact->contact->state = CONTACT_DELETE_PENDING; if (r->shead) { //send NOTIFY to all subscribers of this IMPU. - notify_subscribers(r, impucontact->contact, 0, 0, IMS_REGISTRAR_CONTACT_UNREGISTERED); + notify_subscribers(r, impucontact->contact, 0, 0, IMS_REGISTRAR_CONTACT_DEREGISTERED); } impucontact->contact->state = CONTACT_DELETED; ul.unlock_contact_slot_i(impucontact->contact->sl);

1 0

[kamailio/kamailio] add function t_continue_skip_timer to enable skipping of timer checks (PR #3080)
by Kristiyan Peychev 21 Apr '22

21 Apr '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This is done because IMS third party registration requests would be skipped because t_continue would get called on the transaction _way_ before the timer timeout. All this resulted in the correct route not being called. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3080 -- Commit Summary -- * tm: add function t_continue_skip_timer to enable skipping of timer checks * ims_registrar_scscf: use t_continue_skip_timer instead of t_continue when processing CxDx SAR -- File Changes -- M src/modules/ims_registrar_scscf/cxdx_sar.c (2) M src/modules/tm/t_lookup.c (2) M src/modules/tm/t_suspend.c (15) M src/modules/tm/t_suspend.h (2) M src/modules/tm/tm_load.c (1) M src/modules/tm/tm_load.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3080.patch https://github.com/kamailio/kamailio/pull/3080.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3080 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3080(a)github.com>

2 2

git:master:2067f110: tm: add function t_continue_skip_timer to enable skipping of timer checks
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 2067f110336244826b183a649cb987fac94ffe1c URL: https://github.com/kamailio/kamailio/commit/2067f110336244826b183a649cb987f… Author: Kristiyan Peychev <kristiyan.peychev(a)flolive.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T15:29:37+02:00 tm: add function t_continue_skip_timer to enable skipping of timer checks This is done because third party registration requests would be skipped because t_continue would get called on the transaction _way_ before the timer timeout. All this resulted in the correct route not being called. --- Modified: src/modules/tm/t_lookup.c Modified: src/modules/tm/t_suspend.c Modified: src/modules/tm/t_suspend.h Modified: src/modules/tm/tm_load.c Modified: src/modules/tm/tm_load.h --- Diff: https://github.com/kamailio/kamailio/commit/2067f110336244826b183a649cb987f… Patch: https://github.com/kamailio/kamailio/commit/2067f110336244826b183a649cb987f… --- diff --git a/src/modules/tm/t_lookup.c b/src/modules/tm/t_lookup.c index b90672b3e4..f041116bb8 100644 --- a/src/modules/tm/t_lookup.c +++ b/src/modules/tm/t_lookup.c @@ -1587,7 +1587,7 @@ int t_get_canceled_ident(struct sip_msg* msg, unsigned int* hash_index, * 0). * @param hash_index - searched transaction hash_index (part of the ident). * @param label - searched transaction label (part of the ident). - * @param filter - if 1, skip transaction put on-wait (terminated state). + * @param filter - if 1, filter out transactions put on-wait (terminated state). * @return -1 on error/not found, 1 on success (found) * Side-effects: sets T and T_branch (T_branch always to T_BR_UNDEFINED). */ diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index bae9747282..f0255d6647 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -163,8 +163,8 @@ int t_suspend(struct sip_msg *msg, * 0 - success * <0 - failure */ -int t_continue_helper(unsigned int hash_index, unsigned int label, - struct action *rtact, str *cbname, str *cbparam) +static int t_continue_helper(unsigned int hash_index, unsigned int label, + struct action *rtact, str *cbname, str *cbparam, int skip_timer) { tm_cell_t *t; tm_cell_t *backup_T = T_UNDEFINED; @@ -192,7 +192,7 @@ int t_continue_helper(unsigned int hash_index, unsigned int label, backup_T = get_t(); backup_T_branch = get_t_branch(); - if (t_lookup_ident_filter(&t, hash_index, label, 1) < 0) { + if (t_lookup_ident_filter(&t, hash_index, label, skip_timer) < 0) { set_t(backup_T, backup_T_branch); LM_WARN("active transaction not found\n"); return -1; @@ -592,13 +592,18 @@ int t_continue_helper(unsigned int hash_index, unsigned int label, int t_continue(unsigned int hash_index, unsigned int label, struct action *route) { - return t_continue_helper(hash_index, label, route, NULL, NULL); + return t_continue_helper(hash_index, label, route, NULL, NULL, 1); +} +int t_continue_skip_timer(unsigned int hash_index, unsigned int label, + struct action *route) +{ + return t_continue_helper(hash_index, label, route, NULL, NULL, 0); } int t_continue_cb(unsigned int hash_index, unsigned int label, str *cbname, str *cbparam) { - return t_continue_helper(hash_index, label, NULL, cbname, cbparam); + return t_continue_helper(hash_index, label, NULL, cbname, cbparam, 0); } /* Revoke the suspension of the SIP request, i.e. diff --git a/src/modules/tm/t_suspend.h b/src/modules/tm/t_suspend.h index fcbe182ad1..07c4e7bc37 100644 --- a/src/modules/tm/t_suspend.h +++ b/src/modules/tm/t_suspend.h @@ -29,6 +29,8 @@ typedef int (*t_suspend_f)(struct sip_msg *msg, int t_continue(unsigned int hash_index, unsigned int label, struct action *route); +int t_continue_skip_timer(unsigned int hash_index, unsigned int label, + struct action *route); typedef int (*t_continue_f)(unsigned int hash_index, unsigned int label, struct action *route); diff --git a/src/modules/tm/tm_load.c b/src/modules/tm/tm_load.c index 911be5d917..65515a3a28 100644 --- a/src/modules/tm/tm_load.c +++ b/src/modules/tm/tm_load.c @@ -115,6 +115,7 @@ int load_tm( struct tm_binds *tmb) tmb->t_get_canceled_ident = t_get_canceled_ident; tmb->t_suspend = t_suspend; tmb->t_continue = t_continue; + tmb->t_continue_skip_timer = t_continue_skip_timer; tmb->t_continue_cb = t_continue_cb; tmb->t_cancel_suspend = t_cancel_suspend; tmb->t_get_reply_totag = t_get_reply_totag; diff --git a/src/modules/tm/tm_load.h b/src/modules/tm/tm_load.h index a0f3afde00..8190ee977c 100644 --- a/src/modules/tm/tm_load.h +++ b/src/modules/tm/tm_load.h @@ -95,6 +95,7 @@ struct tm_binds { t_get_canceled_ident_f t_get_canceled_ident; t_suspend_f t_suspend; t_continue_f t_continue; + t_continue_f t_continue_skip_timer; t_continue_cb_f t_continue_cb; t_cancel_suspend_f t_cancel_suspend; tget_reply_totag_f t_get_reply_totag;

1 0

git:master:89421e18: ims_registrar_scscf: use t_continue_skip_timer instead of t_continue when processing CxDx SAR
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 89421e184a8b47557dcfc6c348d60dde347a9417 URL: https://github.com/kamailio/kamailio/commit/89421e184a8b47557dcfc6c348d60dd… Author: Kristiyan Peychev <kristiyan.peychev(a)flolive.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T15:29:37+02:00 ims_registrar_scscf: use t_continue_skip_timer instead of t_continue when processing CxDx SAR --- Modified: src/modules/ims_registrar_scscf/cxdx_sar.c --- Diff: https://github.com/kamailio/kamailio/commit/89421e184a8b47557dcfc6c348d60dd… Patch: https://github.com/kamailio/kamailio/commit/89421e184a8b47557dcfc6c348d60dd… --- diff --git a/src/modules/ims_registrar_scscf/cxdx_sar.c b/src/modules/ims_registrar_scscf/cxdx_sar.c index 951b9d26f5..e0097921e2 100644 --- a/src/modules/ims_registrar_scscf/cxdx_sar.c +++ b/src/modules/ims_registrar_scscf/cxdx_sar.c @@ -286,7 +286,7 @@ void async_cdp_callback(int is_timeout, void *param, AAAMessage *saa, long elaps //free path vector pkg memory // reset_path_vector(req); - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); free_saved_transaction_data(data); return;

1 0

git:master:858ecd29: modules: readme files regenerated - sanity ... [skip ci]
by Kamailio Dev 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 858ecd297c9c53e3f6d0575868d409c4dd3460cf URL: https://github.com/kamailio/kamailio/commit/858ecd297c9c53e3f6d0575868d409c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-21T14:46:14+02:00 modules: readme files regenerated - sanity ... [skip ci] --- Modified: src/modules/sanity/README --- Diff: https://github.com/kamailio/kamailio/commit/858ecd297c9c53e3f6d0575868d409c… Patch: https://github.com/kamailio/kamailio/commit/858ecd297c9c53e3f6d0575868d409c… --- diff --git a/src/modules/sanity/README b/src/modules/sanity/README index 4493c7f3cd..ac3e2ca927 100644 --- a/src/modules/sanity/README +++ b/src/modules/sanity/README @@ -77,18 +77,18 @@ Chapter 1. Admin Guide * ruri scheme - (2) - checks if the URI scheme of the request URI is supported (sip[s]|tel[s]) by Kamailio * required headers - (4) -checks if the minimum set of required - headers to, from, cseq, callid and via is present in the request. + headers To, From, CSeq, Call-ID and Via is present in the request. * via sip version - (8) - disabled. * via protocol - (16) - disabled. - * Cseq method - (32) - checks if the method from the Cseq header is + * Cseq method - (32) - checks if the method from the CSeq header is equal to the request method. - * Cseq value - (64) - checks if the number in the Cseq header is a + * Cseq value - (64) - checks if the number in the CSeq header is a valid unsigned integer. * content length - (128) - checks if the size of the body matches - with the value from the content length header. - * expires value - (256) - checks if the value of the expires header + with the value from the Content-Length header. + * expires value - (256) - checks if the value of the Expires header is a valid unsigned integer. - * proxy require - (512) - checks if all items of the proxy require + * proxy require - (512) - checks if all items of the Proxy-Require header are present in the list of the extensions from the module parameter proxy_require. * parse uri's - (1024) - checks if the specified URIs are present and @@ -100,9 +100,9 @@ Chapter 1. Admin Guide scheme differs from "digest", * duplicated To/From tags (4096) - checks for the presence of duplicated tags in To/From headers. - * authorization header (8192) - checks if the Authorization is valid - if the scheme is "digest" (see "digest credentials" above), always - returns success for other schemes. + * Authorization header (8192) - checks if the Authorization header is + valid if the scheme is "digest" (see "digest credentials" above), + always returns success for other schemes. * first via header (16384) - checks if the first Via header is available, can be parsed and has an address value. @@ -153,9 +153,10 @@ modparam("sanity", "uri_checks", 3) 3.3. proxy_require (string) This parameter sets the list of supported SIP extensions for this - Kamailio. The value is expected as a comma separated list of - extensions. This list is separated into single tokens. Each token from - a proxy require header will be compared with the tokens from this list. + Kamailio. The value is expected as a comma separated list (leading and + trailing whitespaces are stripped from each token) of extensions. This + list is separated into single tokens. Each token from a proxy require + header will be compared with the tokens from this list. Example 1.3. Set proxy_require parameter ...

1 0

[kamailio/kamailio] sanity: Use str_list implementation from core (PR #3088)
by Bastian Triller 21 Apr '22

21 Apr '22

* Remove redundant str_list implementation. * Improve docs   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  * use str_list implementation from core * typo fixes, doc improvements You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3088 -- Commit Summary -- * sanity: Use str_list implementation from core -- File Changes -- M src/modules/sanity/doc/sanity_admin.xml (17) M src/modules/sanity/sanity.c (60) M src/modules/sanity/sanity.h (4) M src/modules/sanity/sanity_mod.c (8) M src/modules/sanity/sanity_mod.h (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3088.patch https://github.com/kamailio/kamailio/pull/3088.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3088 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3088(a)github.com>

2 2

git:master:acafe707: sanity: Use str_list implementation from core
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: acafe70708a13ac7f549cb113d99af53ee0ac088 URL: https://github.com/kamailio/kamailio/commit/acafe70708a13ac7f549cb113d99af5… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T14:32:05+02:00 sanity: Use str_list implementation from core * Remove redundant str_list implementation. * Improve docs --- Modified: src/modules/sanity/doc/sanity_admin.xml Modified: src/modules/sanity/sanity.c Modified: src/modules/sanity/sanity.h Modified: src/modules/sanity/sanity_mod.c Modified: src/modules/sanity/sanity_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/acafe70708a13ac7f549cb113d99af5… Patch: https://github.com/kamailio/kamailio/commit/acafe70708a13ac7f549cb113d99af5…

1 0

git:master:c3091228: topos: restore attributes based on direction for early dialog requests
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: c309122864eaa2bfa58253290bed49084ccc9302 URL: https://github.com/kamailio/kamailio/commit/c309122864eaa2bfa58253290bed490… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T14:28:26+02:00 topos: restore attributes based on direction for early dialog requests - GH #3090 --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/c309122864eaa2bfa58253290bed490… Patch: https://github.com/kamailio/kamailio/commit/c309122864eaa2bfa58253290bed490… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index c16a0adacb..cd781328e5 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -863,10 +863,9 @@ int tps_request_received(sip_msg_t *msg, int dialog) mtsd.direction = direction; } - tps_storage_lock_release(&lkey); - if(use_branch) { + if(use_branch && direction == TPS_DIR_DOWNSTREAM) { nuri = stsd.b_contact; } else { if(direction == TPS_DIR_UPSTREAM) { @@ -884,7 +883,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) } } - if(use_branch) { + if(use_branch && direction == TPS_DIR_DOWNSTREAM) { if(tps_reappend_route(msg, &stsd, &stsd.s_rr, 1) < 0) { LM_ERR("failed to reappend s-route\n"); return -1;

1 0

git:master:098955e2: xmlops: coherent formatting
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: 098955e23289b82db40d5cef76ee03bf09e8a0da URL: https://github.com/kamailio/kamailio/commit/098955e23289b82db40d5cef76ee03b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T09:02:01+02:00 xmlops: coherent formatting --- Modified: src/modules/xmlops/pv_xml.c Modified: src/modules/xmlops/pv_xml.h Modified: src/modules/xmlops/xmlops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/098955e23289b82db40d5cef76ee03b… Patch: https://github.com/kamailio/kamailio/commit/098955e23289b82db40d5cef76ee03b…

1 0

git:master:ceb688b3: topos: use direction for loading invite record for other early dialog requests
by Daniel-Constantin Mierla 21 Apr '22

21 Apr '22

Module: kamailio Branch: master Commit: ceb688b3d364bb7b8d9f52b7238d560cb4e30b3d URL: https://github.com/kamailio/kamailio/commit/ceb688b3d364bb7b8d9f52b7238d560… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-21T09:02:01+02:00 topos: use direction for loading invite record for other early dialog requests - GH #3090 --- Modified: src/modules/topos/tps_msg.c Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/ceb688b3d364bb7b8d9f52b7238d560… Patch: https://github.com/kamailio/kamailio/commit/ceb688b3d364bb7b8d9f52b7238d560… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index c7de5e514f..c16a0adacb 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -803,6 +803,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) uint32_t direction = TPS_DIR_DOWNSTREAM; int ret; int use_branch = 0; + unsigned int metid = 0; LM_DBG("handling incoming request\n"); @@ -835,11 +836,11 @@ int tps_request_received(sip_msg_t *msg, int dialog) if(tps_storage_load_dialog(msg, &mtsd, &stsd) < 0) { goto error; } - if(((((get_cseq(msg)->method_id) & (METHOD_PRACK|METHOD_UPDATE)) - && stsd.b_contact.len <= 0)) || (((get_cseq(msg)->method_id) - & (METHOD_BYE) && stsd.b_contact.len <= 0) && (0 == dialog))) { + metid = get_cseq(msg)->method_id; + if((metid & (METHOD_BYE|METHOD_PRACK|METHOD_UPDATE)) + && stsd.b_contact.len <= 0) { /* no B-side contact, look for INVITE transaction record */ - if((get_cseq(msg)->method_id) & (METHOD_UPDATE)) { + if(metid & (METHOD_BYE|METHOD_UPDATE)) { /* detect direction - via from-tag */ if(tps_dlg_detect_direction(msg, &stsd, &direction) < 0) { goto error; @@ -917,7 +918,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) goto error; } } - if((get_cseq(msg)->method_id)&(METHOD_SUBSCRIBE)) { + if(metid & METHOD_SUBSCRIBE) { if(tps_storage_update_dialog(msg, &mtsd, &stsd, TPS_DBU_CONTACT|TPS_DBU_TIME)<0) { goto error; } diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 1a67c0252c..56d56776a4 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1146,7 +1146,11 @@ int tps_db_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; - db_vals[nr_keys].val.str_val = TPS_STRZ(md->b_tag); + if(md->direction==TPS_DIR_DOWNSTREAM) { + db_vals[nr_keys].val.str_val = TPS_STRZ(md->b_tag); + } else { + db_vals[nr_keys].val.str_val = TPS_STRZ(md->a_tag); + } nr_keys++; db_keys[nr_keys]=&tt_col_s_method;

1 0

[kamailio/kamailio] Kamailio tries to parse HTTP replies as SIP ? (Issue #3081)
by Alexandru Pirvulescu 20 Apr '22

20 Apr '22

### Description This is a longstanding error when using websockets or the HTTP client (this one is a bit newer, didn't see it for long). Searching the net has led me here: https://lists.kamailio.org/pipermail/sr-users/2018-January/099881.html It looks like Kamailio cannot parse HTTP responses, but that message is ambigous. Why would it try to parse them in the first place? ``` 32(203) ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 100 Continue ``` ``` 47(89) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 101 Switching Protocols ```  ### Troubleshooting Except confirming that the messages are legit, there is nothing else that I can do. #### Reproduction  The first error is generated by making HTTP requests using the HTTP client embedded in Kamailio. The second error happens on each WebRTC call served by Kamailio. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  HTTP responses should not go through the core message parser. Not sure if this can be described as a "solution". ### Additional Information * **Kamailio Version** - output of `kamailio -v` For the 100 parsing error. The used HTTP clients are `http_client` and `http_async_client` modules. ``` # kamailio -v version: kamailio 5.5.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` For the 101 parsing error. Kamailio is a WebRTC server for `sipML5` library. ``` # kamailio -v version: kamailio 5.4.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**:  ``` # uname -a Linux gke-dev-1-sbc-out-dbbddabc-amiw 5.4.0-1054-gke #57-Ubuntu SMP Fri Oct 1 03:16:03 UTC 2021 x86_64 GNU/Linux ``` ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3081 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3081(a)github.com>

2 2

[kamailio/kamailio] xhttp: fix typo (PR #3089)
by liviu-rolo 19 Apr '22

19 Apr '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3089 -- Commit Summary -- * fix typo -- File Changes -- M src/modules/xhttp/xhttp_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3089.patch https://github.com/kamailio/kamailio/pull/3089.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3089 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3089(a)github.com>

2 2

git:master:f406d036: fix typo
by Henning Westerholt 19 Apr '22

19 Apr '22

Module: kamailio Branch: master Commit: f406d036af6abd7330b6b250bba04f2875f073d0 URL: https://github.com/kamailio/kamailio/commit/f406d036af6abd7330b6b250bba04f2… Author: liviu-rolo <82887358+liviu-rolo(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-19T12:06:58+02:00 fix typo --- Modified: src/modules/xhttp/xhttp_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f406d036af6abd7330b6b250bba04f2… Patch: https://github.com/kamailio/kamailio/commit/f406d036af6abd7330b6b250bba04f2… --- diff --git a/src/modules/xhttp/xhttp_mod.c b/src/modules/xhttp/xhttp_mod.c index 1aec2763d9..31b2efb4d6 100644 --- a/src/modules/xhttp/xhttp_mod.c +++ b/src/modules/xhttp/xhttp_mod.c @@ -145,7 +145,7 @@ static int mod_init(void) if(cfg_get(tcp, tcp_cfg, accept_no_cl)==0) { LM_WARN("tcp_accept_no_cl not set - usually required" - " to handle HTTP requests with no Content-Lenght\n"); + " to handle HTTP requests with no Content-Length\n"); } /* bind the SL API */

1 0

git:master:24776e14: modules: readme files regenerated - presence ... [skip ci]
by Kamailio Dev 19 Apr '22

19 Apr '22

Module: kamailio Branch: master Commit: 24776e1463742b11cf0201093105129235216d7b URL: https://github.com/kamailio/kamailio/commit/24776e1463742b11cf0201093105129… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-19T12:01:16+02:00 modules: readme files regenerated - presence ... [skip ci] --- Modified: src/modules/presence/README --- Diff: https://github.com/kamailio/kamailio/commit/24776e1463742b11cf0201093105129… Patch: https://github.com/kamailio/kamailio/commit/24776e1463742b11cf0201093105129… --- diff --git a/src/modules/presence/README b/src/modules/presence/README index c06ccdd6ec..9e378a5681 100644 --- a/src/modules/presence/README +++ b/src/modules/presence/README @@ -1340,8 +1340,8 @@ r * each watcher. It either gets the body received by the PUBLISH, or the bod y * generated by the agg_nbody function. - * The module can deceide if it makes a copy of the original body, which is -then + * The module can decide if it makes a copy of the original body, which is t +hen * manipulated, or if it works directly in the original body. If the module makes a * copy of the original body, it also has to register the aux_free_body() to

1 0

[kamailio/kamailio] presence: fix typos (PR #3087)
by liviu-rolo 19 Apr '22

19 Apr '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3087 -- Commit Summary -- * fix typos -- File Changes -- M src/modules/presence/doc/presence_devel.xml (2) M src/modules/presence/event_list.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3087.patch https://github.com/kamailio/kamailio/pull/3087.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3087 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3087(a)github.com>

2 2

git:master:f63a4645: fix typos
by Henning Westerholt 19 Apr '22

19 Apr '22

Module: kamailio Branch: master Commit: f63a4645afe1c52050bbd8050bf3c392acc985b8 URL: https://github.com/kamailio/kamailio/commit/f63a4645afe1c52050bbd8050bf3c39… Author: Liviu Andron <liviu.andron(a)bjtmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-19T11:46:06+02:00 fix typos --- Modified: src/modules/presence/doc/presence_devel.xml Modified: src/modules/presence/event_list.h --- Diff: https://github.com/kamailio/kamailio/commit/f63a4645afe1c52050bbd8050bf3c39… Patch: https://github.com/kamailio/kamailio/commit/f63a4645afe1c52050bbd8050bf3c39… --- diff --git a/src/modules/presence/doc/presence_devel.xml b/src/modules/presence/doc/presence_devel.xml index 608fa6eeb5..2bb1953764 100644 --- a/src/modules/presence/doc/presence_devel.xml +++ b/src/modules/presence/doc/presence_devel.xml @@ -115,7 +115,7 @@ typedef struct pres_ev * If a module registers the aux_body_processing callback, it gets called for * each watcher. It either gets the body received by the PUBLISH, or the body * generated by the agg_nbody function. - * The module can deceide if it makes a copy of the original body, which is then + * The module can decide if it makes a copy of the original body, which is then * manipulated, or if it works directly in the original body. If the module makes a * copy of the original body, it also has to register the aux_free_body() to * free this "per watcher" body. diff --git a/src/modules/presence/event_list.h b/src/modules/presence/event_list.h index 3f30cb8265..7874a1f967 100644 --- a/src/modules/presence/event_list.h +++ b/src/modules/presence/event_list.h @@ -88,7 +88,7 @@ struct pres_ev * 0 - the standard mechanism (allocating new etag for each Publish) * 1 - allocating an etag only for an initial Publish * */ - /* fileds that deal with authorization rules*/ + /* fields that deal with authorization rules*/ /* * req_auth -> flag 0 - if not require * is_watcher_allowed - get subscription state from xcap rules @@ -114,7 +114,7 @@ struct pres_ev * If a module registers the aux_body_processing callback, it gets called for * each watcher. It either gets the body received by the PUBLISH, or the body * generated by the agg_nbody function. - * The module can deceide if it makes a copy of the original body, which is then + * The module can decide if it makes a copy of the original body, which is then * manipulated, or if it works directly in the original body. If the module makes a * copy of the original body, it also has to register the aux_free_body() to * free this "per watcher" body.

1 0

[kamailio/kamailio] htable: wrong printf format (PR #3086)
by liviu-rolo 19 Apr '22

19 Apr '22

"%*.s" used instead of "%.*s"   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description "%*.s" used instead of "%.*s": "The result is padded with space characters" (https://en.cppreference.com/w/cpp/io/c/fprintf) Probably harmless (but still wrong) if the string ends with '\0'. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3086 -- Commit Summary -- * wrong printf format -- File Changes -- M src/modules/htable/ht_db.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3086.patch https://github.com/kamailio/kamailio/pull/3086.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3086 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3086(a)github.com>

2 2

git:master:c259eb64: wrong printf format
by Henning Westerholt 19 Apr '22

19 Apr '22

Module: kamailio Branch: master Commit: c259eb6421713165d0800c030a589c867fe4da22 URL: https://github.com/kamailio/kamailio/commit/c259eb6421713165d0800c030a589c8… Author: liviu-rolo <82887358+liviu-rolo(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-19T11:45:27+02:00 wrong printf format "%*.s" used instead of "%.*s": "The result is padded with space characters" (https://en.cppreference.com/w/cpp/io/c/fprintf) Probably harmless (but still wrong) if the string ends with '\0'. --- Modified: src/modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/c259eb6421713165d0800c030a589c8… Patch: https://github.com/kamailio/kamailio/commit/c259eb6421713165d0800c030a589c8… --- diff --git a/src/modules/htable/ht_db.c b/src/modules/htable/ht_db.c index cbce085f6c..bbcba99913 100644 --- a/src/modules/htable/ht_db.c +++ b/src/modules/htable/ht_db.c @@ -495,7 +495,7 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) if (ht->htexpire > 0 && expires.n > 0) { expires.n -= now; if(ht_set_cell_expire(ht, &hname, 0, &expires)) { - LM_ERR("error setting expires to hash entry [%*.s]\n", hname.len, hname.s); + LM_ERR("error setting expires to hash entry [%.*s]\n", hname.len, hname.s); goto error; } }

1 0

git:master:95bf86dc: siprepo: updates to kemi exports signatures
by Daniel-Constantin Mierla 19 Apr '22

19 Apr '22

Module: kamailio Branch: master Commit: 95bf86dc2900b707d4b9bfa2005fcea6c17c3410 URL: https://github.com/kamailio/kamailio/commit/95bf86dc2900b707d4b9bfa2005fcea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-19T08:50:51+02:00 siprepo: updates to kemi exports signatures --- Modified: src/modules/siprepo/siprepo_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/95bf86dc2900b707d4b9bfa2005fcea… Patch: https://github.com/kamailio/kamailio/commit/95bf86dc2900b707d4b9bfa2005fcea… --- diff --git a/src/modules/siprepo/siprepo_mod.c b/src/modules/siprepo/siprepo_mod.c index 59473b0388..35a9778743 100644 --- a/src/modules/siprepo/siprepo_mod.c +++ b/src/modules/siprepo/siprepo_mod.c @@ -344,18 +344,18 @@ static void siprepo_timer_exec(unsigned int ticks, int worker, void *param) static sr_kemi_t sr_kemi_sworker_exports[] = { { str_init("siprepo"), str_init("sr_msg_push"), SR_KEMIP_INT, ki_sr_msg_push, - { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + { SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { str_init("siprepo"), str_init("sr_msg_pull"), SR_KEMIP_INT, ki_sr_msg_pull, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, - SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { str_init("siprepo"), str_init("sr_msg_async_pull"), SR_KEMIP_INT, ki_sr_msg_async_pull, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, - SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE } + SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE } }, { str_init("siprepo"), str_init("sr_msg_rm"), SR_KEMIP_INT, ki_sr_msg_rm,

1 0

git:master:9601f651: pv_headers: update kemi exports signatures to match c code
by Daniel-Constantin Mierla 18 Apr '22

18 Apr '22

Module: kamailio Branch: master Commit: 9601f651ecdbf5e816f15fc6aedce9981d4afae7 URL: https://github.com/kamailio/kamailio/commit/9601f651ecdbf5e816f15fc6aedce99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-18T09:16:34+02:00 pv_headers: update kemi exports signatures to match c code --- Modified: src/modules/pv_headers/pv_headers.c --- Diff: https://github.com/kamailio/kamailio/commit/9601f651ecdbf5e816f15fc6aedce99… Patch: https://github.com/kamailio/kamailio/commit/9601f651ecdbf5e816f15fc6aedce99… --- diff --git a/src/modules/pv_headers/pv_headers.c b/src/modules/pv_headers/pv_headers.c index be43bb29f4..fb20dfcc02 100644 --- a/src/modules/pv_headers/pv_headers.c +++ b/src/modules/pv_headers/pv_headers.c @@ -590,13 +590,13 @@ static sr_kemi_t pvh_kemi_exports[] = { }, { str_init("pv_headers"), str_init("pvh_header_param_exists"), SR_KEMIP_INT, pvh_header_param_exists, - { SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE} }, { str_init("pv_headers"), str_init("pvh_remove_header_param"), SR_KEMIP_INT, pvh_remove_header_param, - { SR_KEMIP_STR, SR_KEMIP_INT, SR_KEMIP_NONE, - SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE} + { SR_KEMIP_INT, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE} }, {{0, 0}, {0, 0}, 0, NULL, {0, 0, 0, 0, 0, 0}} };

1 0

git:master:6cddfb88: kamctl: version set to 5.6.0
by Daniel-Constantin Mierla 16 Apr '22

16 Apr '22

Module: kamailio Branch: master Commit: 6cddfb888d5622a986f2e5b57fe3a36f81632cfd URL: https://github.com/kamailio/kamailio/commit/6cddfb888d5622a986f2e5b57fe3a36… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-16T15:24:59+02:00 kamctl: version set to 5.6.0 --- Modified: utils/kamctl/kamctl --- Diff: https://github.com/kamailio/kamailio/commit/6cddfb888d5622a986f2e5b57fe3a36… Patch: https://github.com/kamailio/kamailio/commit/6cddfb888d5622a986f2e5b57fe3a36… --- diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index a83720fcde..b4b861763a 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -5,7 +5,7 @@ #=================================================================== ### version for this script -VERSION='5.4.0' +VERSION='5.6.0' PATH=$PATH:/usr/local/sbin/

1 0

git:master:03726a3f: ims_registrar_scscf: fix build warning
by Victor Seva 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: 03726a3f04f860ead060ad2f7984b587ad10ab43 URL: https://github.com/kamailio/kamailio/commit/03726a3f04f860ead060ad2f7984b58… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-15T13:23:49+02:00 ims_registrar_scscf: fix build warning > userdata_parser.c: In function 'parse_user_data': > userdata_parser.c:930:23: warning: pointer targets in passing argument 1 > of 'xmlParseMemory' differ in signedness [-Wpointer-sign] > 930 | doc = xmlParseMemory((unsigned char *)xml.s, xml.len); > | ^~~~~~~~~~~~~~~~~~~~~~ > | | > | unsigned char * > In file included from /usr/include/libxml2/libxml/globals.h:18, > from /usr/include/libxml2/libxml/threads.h:35, > from /usr/include/libxml2/libxml/xmlmemory.h:218, > from /usr/include/libxml2/libxml/tree.h:1307, > from /usr/include/libxml2/libxml/xmlschemas.h:19, > from userdata_parser.h:47, > from userdata_parser.c:44: > /usr/include/libxml2/libxml/parser.h:846:32: note: expected 'const char > *' but argument is of type 'unsigned char *' > 846 | xmlParseMemory (const char *buffer, > | ~~~~~~~~~~~~^~~~~~ --- Modified: src/modules/ims_registrar_scscf/userdata_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/03726a3f04f860ead060ad2f7984b58… Patch: https://github.com/kamailio/kamailio/commit/03726a3f04f860ead060ad2f7984b58… --- diff --git a/src/modules/ims_registrar_scscf/userdata_parser.c b/src/modules/ims_registrar_scscf/userdata_parser.c index d8b08b5491..43a5657c5b 100644 --- a/src/modules/ims_registrar_scscf/userdata_parser.c +++ b/src/modules/ims_registrar_scscf/userdata_parser.c @@ -927,7 +927,7 @@ ims_subscription *parse_user_data(str xml) if (!ctxtInit) parser_init(scscf_user_data_dtd,scscf_user_data_xsd); doc=0; - doc = xmlParseMemory((unsigned char *)xml.s, xml.len); + doc = xmlParseMemory(xml.s, xml.len); if (!doc){ LM_ERR("This is not a valid XML <%.*s>\n", xml.len,xml.s); goto error;

1 0

git:master:3e46fc12: pv: remove unused variable
by Victor Seva 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: 3e46fc12adbee2c8d0b0dc4de4814d343762c52d URL: https://github.com/kamailio/kamailio/commit/3e46fc12adbee2c8d0b0dc4de4814d3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-15T13:17:25+02:00 pv: remove unused variable > pv_branch.c:623:13: warning: unused variable 's' [-Wunused-variable] --- Modified: src/modules/pv/pv_branch.c --- Diff: https://github.com/kamailio/kamailio/commit/3e46fc12adbee2c8d0b0dc4de4814d3… Patch: https://github.com/kamailio/kamailio/commit/3e46fc12adbee2c8d0b0dc4de4814d3… --- diff --git a/src/modules/pv/pv_branch.c b/src/modules/pv/pv_branch.c index 83cc273f12..22f3e7afa5 100644 --- a/src/modules/pv/pv_branch.c +++ b/src/modules/pv/pv_branch.c @@ -620,7 +620,6 @@ int pv_get_rcv(struct sip_msg *msg, pv_param_t *param, int pv_set_rcv(sip_msg_t *msg, pv_param_t *param, int op, pv_value_t *val) { sr_net_info_t *neti = NULL; - str s; neti = ksr_evrt_rcvnetinfo_get();

1 0

git:master:6c15b875: pv_headers: fix build warning
by Victor Seva 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: 6c15b875c9763013afc1aafc1ae06c96c4e2c698 URL: https://github.com/kamailio/kamailio/commit/6c15b875c9763013afc1aafc1ae06c9… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-15T11:29:53+02:00 pv_headers: fix build warning pvh_func.c:392:35: warning: division 'sizeof (char *) / sizeof (char)' pvh_func.c:407:66: warning: division 'sizeof (char *) / sizeof (char)' --- Modified: src/modules/pv_headers/pvh_func.c --- Diff: https://github.com/kamailio/kamailio/commit/6c15b875c9763013afc1aafc1ae06c9… Patch: https://github.com/kamailio/kamailio/commit/6c15b875c9763013afc1aafc1ae06c9… --- diff --git a/src/modules/pv_headers/pvh_func.c b/src/modules/pv_headers/pvh_func.c index 4ca72d217d..c2a3f98e41 100644 --- a/src/modules/pv_headers/pvh_func.c +++ b/src/modules/pv_headers/pvh_func.c @@ -389,8 +389,7 @@ int pvh_remove_header_param(struct sip_msg *msg, int idx, str *hname, str *eleme char *token; char *result = (char*)pkg_malloc(elements->len - toRemove->len); char *t = (char*)pkg_malloc(elements->len); - int maxSize = sizeof(elements->s)/sizeof(char); - maxSize = maxSize < elements->len?elements->len:maxSize; + int maxSize = elements->len; if (result == NULL || t == NULL) { @@ -404,7 +403,7 @@ int pvh_remove_header_param(struct sip_msg *msg, int idx, str *hname, str *eleme token = strtok_r(t, ", ", &next_token); while(token) { - int notTarget = strncmp(token, toRemove->s, sizeof(toRemove->s)/sizeof(char)); + int notTarget = strncmp(token, toRemove->s, toRemove->len); if (notTarget) { int n = snprintf(result + offset, maxSize - offset, "%s", token);

1 0

git:master:8964b1a9: pkg/kamailio/deb: version set 5.6.0~pre0
by Victor Seva 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: 8964b1a9819d9fd644a5a30b0fe4de9b3146501d URL: https://github.com/kamailio/kamailio/commit/8964b1a9819d9fd644a5a30b0fe4de9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-04-15T09:04:56+02:00 pkg/kamailio/deb: version set 5.6.0~pre0 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/8964b1a9819d9fd644a5a30b0fe4de9… Patch: https://github.com/kamailio/kamailio/commit/8964b1a9819d9fd644a5a30b0fe4de9…

1 0

git:master:a1d89de0: Makefile.defs: version set to 5.6.0-pre0
by Daniel-Constantin Mierla 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: a1d89de03b0274b642d35ee875a1985ee51a2cd8 URL: https://github.com/kamailio/kamailio/commit/a1d89de03b0274b642d35ee875a1985… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-15T08:30:04+02:00 Makefile.defs: version set to 5.6.0-pre0 - testing phase for v5.6.x series --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/a1d89de03b0274b642d35ee875a1985… Patch: https://github.com/kamailio/kamailio/commit/a1d89de03b0274b642d35ee875a1985… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index c167e2c11f..90aa777782 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 6 SUBLEVEL = 0 -EXTRAVERSION = -dev4 +EXTRAVERSION = -pre0 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:a0f53622: Makefile.defs: version set to 5.6.0-dev4
by Daniel-Constantin Mierla 15 Apr '22

15 Apr '22

Module: kamailio Branch: master Commit: a0f53622fd624562d9f65ac212b2d91363f2714c URL: https://github.com/kamailio/kamailio/commit/a0f53622fd624562d9f65ac212b2d91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-15T08:29:16+02:00 Makefile.defs: version set to 5.6.0-dev4 - mark the end of development for 5.6.x series --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/a0f53622fd624562d9f65ac212b2d91… Patch: https://github.com/kamailio/kamailio/commit/a0f53622fd624562d9f65ac212b2d91… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index d3ca839c0d..c167e2c11f 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 6 SUBLEVEL = 0 -EXTRAVERSION = -dev3 +EXTRAVERSION = -dev4 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

[kamailio/kamailio] Compilation warning with gcc-12 (Issue #3073)
by Anthony Messina 14 Apr '22

14 Apr '22

When building for Fedora 36 with gcc-12.0.1: ``` Makefile.defs:1683: You are using an old and unsupported gcc version (12.0.1), compile at your own risk! ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3073 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3073(a)github.com>

2 4

git:master:3bdd15c8: modules: readme files regenerated - corex ... [skip ci]
by Kamailio Dev 14 Apr '22

14 Apr '22

Module: kamailio Branch: master Commit: 3bdd15c8dd60d445fc9f86b7579ddd2e1a862bc4 URL: https://github.com/kamailio/kamailio/commit/3bdd15c8dd60d445fc9f86b7579ddd2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-14T16:01:13+02:00 modules: readme files regenerated - corex ... [skip ci] --- Modified: src/modules/corex/README --- Diff: https://github.com/kamailio/kamailio/commit/3bdd15c8dd60d445fc9f86b7579ddd2… Patch: https://github.com/kamailio/kamailio/commit/3bdd15c8dd60d445fc9f86b7579ddd2… --- diff --git a/src/modules/corex/README b/src/modules/corex/README index b3bc69a9fd..be898f0d7f 100644 --- a/src/modules/corex/README +++ b/src/modules/corex/README @@ -62,6 +62,7 @@ Muhammad Shahzad Shafi 4.22. via_use_xavp_fields(flags) 4.23. is_faked_msg() 4.24. is_socket_name(sockname) + 4.25. forward_reply() 5. RPC Commands @@ -114,8 +115,9 @@ Muhammad Shahzad Shafi 1.28. via_use_xavp_fields usage 1.29. is_faked_msg usage 1.30. is_socket_name usage - 1.31. event_route[network:msg] use cases - 1.32. Sample PERL code for do_compress and do_uncompress + 1.31. forward_reply usage + 1.32. event_route[network:msg] use cases + 1.33. Sample PERL code for do_compress and do_uncompress Chapter 1. Admin Guide @@ -162,6 +164,7 @@ Chapter 1. Admin Guide 4.22. via_use_xavp_fields(flags) 4.23. is_faked_msg() 4.24. is_socket_name(sockname) + 4.25. forward_reply() 5. RPC Commands @@ -351,6 +354,7 @@ modparam("corex", "nio_msg_avp", "$avp(msg)") 4.22. via_use_xavp_fields(flags) 4.23. is_faked_msg() 4.24. is_socket_name(sockname) + 4.25. forward_reply() 4.1. append_branch([ uri, [ q ] ]) @@ -744,6 +748,19 @@ event_route[dispatcher:dst-down] { } ... +4.25. forward_reply() + + Forward received reply on demand. + + This function can be used in CORE_ONREPLY_ROUTE. + + Example 1.31. forward_reply usage +... +route[reply] { + forward_reply(); +} +... + 5. RPC Commands 5.1. corex.debug @@ -907,7 +924,7 @@ event_route[dispatcher:dst-down] { Next is a basic usage example where encoding and decoding is done using PERL. - Example 1.31. event_route[network:msg] use cases + Example 1.32. event_route[network:msg] use cases ... loadmodule "app_perl.so" loadmodule "corex.so" @@ -938,7 +955,7 @@ event_route[network:msg] { } ... - Example 1.32. Sample PERL code for do_compress and do_uncompress + Example 1.33. Sample PERL code for do_compress and do_uncompress ... use strict; use warnings;

1 0

git:master:eeb04173: siprepo: parse msg for pull operation
by Daniel-Constantin Mierla 14 Apr '22

14 Apr '22

Module: kamailio Branch: master Commit: eeb0417340a120da5f3267aef5e08600dad3107b URL: https://github.com/kamailio/kamailio/commit/eeb0417340a120da5f3267aef5e0860… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-14T12:20:54+02:00 siprepo: parse msg for pull operation --- Modified: src/modules/siprepo/siprepo_data.c Modified: src/modules/siprepo/siprepo_data.h --- Diff: https://github.com/kamailio/kamailio/commit/eeb0417340a120da5f3267aef5e0860… Patch: https://github.com/kamailio/kamailio/commit/eeb0417340a120da5f3267aef5e0860… --- diff --git a/src/modules/siprepo/siprepo_data.c b/src/modules/siprepo/siprepo_data.c index 55deed3b75..ef81b7694c 100644 --- a/src/modules/siprepo/siprepo_data.c +++ b/src/modules/siprepo/siprepo_data.c @@ -35,6 +35,8 @@ #include "../../core/trim.h" #include "../../core/ut.h" #include "../../core/receive.h" +#include "../../core/globals.h" +#include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" @@ -193,6 +195,9 @@ int siprepo_msg_set(sip_msg_t *msg, str *msgid) it->mtype = msg->first_line.type; it->itime = time(NULL); + it->msgno = msg->id; + it->pid = msg->pid; + it->mflags = msg->flags; _siprepo_table[slotid].plist->prev = it; it->next = _siprepo_table[slotid].plist; @@ -308,6 +313,7 @@ int siprepo_msg_pull(sip_msg_t *msg, str *callid, str *msgid, str *rname) int rtno; sr_kemi_eng_t *keng = NULL; str evname = str_init("siprepo:msg"); + char lbuf[BUF_SIZE]; it = siprepo_msg_find(msg, callid, msgid, 1); if(it==NULL) { @@ -316,10 +322,35 @@ int siprepo_msg_pull(sip_msg_t *msg, str *callid, str *msgid, str *rname) lock_release(&_siprepo_table[slotid].lock); return 1; } - memset(&lmsg, 0, sizeof(sip_msg_t)); slotid = it->hid % _siprepo_table_size; + memset(&lmsg, 0, sizeof(sip_msg_t)); + lmsg.buf = lbuf; + memcpy(lmsg.buf, it->dbuf.s, it->dbuf.len); + lmsg.len = it->dbuf.len; + lmsg.rcv = it->rcv; + lmsg.id = it->msgno; + lmsg.pid = it->pid; + lmsg.set_global_address = default_global_address; + lmsg.set_global_port = default_global_port; + + if(parse_msg(lmsg.buf, lmsg.len, &lmsg) != 0) { + LM_ERR("failed to parse msg id [%.*s]\n", msgid->len, msgid->s); + lock_release(&_siprepo_table[slotid].lock); + return 1; + } + if(unlikely(parse_headers(&lmsg, HDR_FROM_F|HDR_TO_F|HDR_CALLID_F|HDR_CSEQ_F, 0) + < 0)) { + LOG(cfg_get(core, core_cfg, sip_parser_log), + "parsing relevant headers failed\n"); + } + /* set log prefix */ + log_prefix_set(&lmsg); + + /* ... clear branches from previous message */ + clear_branches(); if(it->mtype==SIP_REQUEST) { + ruri_mark_new(); rtype = REQUEST_ROUTE; } else { rtype = CORE_ONREPLY_ROUTE; @@ -340,7 +371,10 @@ int siprepo_msg_pull(sip_msg_t *msg, str *callid, str *msgid, str *rname) } set_route_type(rtbk); ksr_msg_env_reset(); - + LM_DBG("cleaning up\n"); + free_sip_msg(&lmsg); + /* reset log prefix */ + log_prefix_set(NULL); return 0; } diff --git a/src/modules/siprepo/siprepo_data.h b/src/modules/siprepo/siprepo_data.h index ed568fa90a..ba519a558a 100644 --- a/src/modules/siprepo/siprepo_data.h +++ b/src/modules/siprepo/siprepo_data.h @@ -38,7 +38,9 @@ typedef struct siprepo_msg { str vbranch; str dbuf; unsigned int cseqmetid; + int msgno; int pid; + flag_t mflags; receive_info_t rcv; time_t itime; struct siprepo_msg *next;

1 0

git:master:b08bfd02: siprepo: added rmode parameter for push and pull functions
by Daniel-Constantin Mierla 14 Apr '22

14 Apr '22

Module: kamailio Branch: master Commit: b08bfd0226f244bb44299ce8177efbd6f5bf0c11 URL: https://github.com/kamailio/kamailio/commit/b08bfd0226f244bb44299ce8177efbd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-14T12:28:47+02:00 siprepo: added rmode parameter for push and pull functions --- Modified: src/modules/siprepo/siprepo_data.c Modified: src/modules/siprepo/siprepo_data.h Modified: src/modules/siprepo/siprepo_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b08bfd0226f244bb44299ce8177efbd… Patch: https://github.com/kamailio/kamailio/commit/b08bfd0226f244bb44299ce8177efbd…

1 0

git:master:a23ede72: corex: added forward_reply() function
by Daniel-Constantin Mierla 14 Apr '22

14 Apr '22

Module: kamailio Branch: master Commit: a23ede7247b52ddc53dc0186810923dc1ae8c51c URL: https://github.com/kamailio/kamailio/commit/a23ede7247b52ddc53dc0186810923d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-14T12:11:37+02:00 corex: added forward_reply() function - forward received reply on demand --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a23ede7247b52ddc53dc0186810923d… Patch: https://github.com/kamailio/kamailio/commit/a23ede7247b52ddc53dc0186810923d… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index 765bedf5f1..3c6b6a59f4 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -34,6 +34,7 @@ #include "../../core/str_list.h" #include "../../core/events.h" #include "../../core/onsend.h" +#include "../../core/forward.h" #include "../../core/dns_cache.h" #include "../../core/parser/parse_uri.h" #include "../../core/parser/parse_param.h" @@ -47,6 +48,7 @@ MODULE_VERSION static int nio_intercept = 0; +static int w_forward_reply(sip_msg_t *msg, char *p1, char *p2); static int w_append_branch(sip_msg_t *msg, char *su, char *sq); static int w_send_udp(sip_msg_t *msg, char *su, char *sq); static int w_send_tcp(sip_msg_t *msg, char *su, char *sq); @@ -105,6 +107,8 @@ static tr_export_t mod_trans[] = { }; static cmd_export_t cmds[]={ + {"forward_reply", (cmd_function)w_forward_reply, 0, 0, + 0, CORE_ONREPLY_ROUTE }, {"append_branch", (cmd_function)w_append_branch, 0, 0, 0, REQUEST_ROUTE | FAILURE_ROUTE }, {"append_branch", (cmd_function)w_append_branch, 1, fixup_spve_null, @@ -249,6 +253,7 @@ static int child_init(int rank) return 0; } + /** * destroy module function */ @@ -256,6 +261,15 @@ static void mod_destroy(void) { } +/** + * forward reply based on via + */ +static int w_forward_reply(sip_msg_t *msg, char *p1, char *p2) +{ + forward_reply(msg); + return 1; +} + /** * config wrapper for append branch */

1 0

git:master:ba66bc87: corex: docs for forward_reply() function
by Daniel-Constantin Mierla 14 Apr '22

14 Apr '22

Module: kamailio Branch: master Commit: ba66bc87ac05403f494d2820ef53a40b321881b0 URL: https://github.com/kamailio/kamailio/commit/ba66bc87ac05403f494d2820ef53a40… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-14T12:14:42+02:00 corex: docs for forward_reply() function --- Modified: src/modules/corex/doc/corex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ba66bc87ac05403f494d2820ef53a40… Patch: https://github.com/kamailio/kamailio/commit/ba66bc87ac05403f494d2820ef53a40… --- diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml index da9d8ea101..2675a559ac 100644 --- a/src/modules/corex/doc/corex_admin.xml +++ b/src/modules/corex/doc/corex_admin.xml @@ -904,6 +904,27 @@ event_route[dispatcher:dst-down] { xinfo("matched local socket name\n"); } ... +</programlisting> + </example> + </section> + <section id="corex.f.forward_reply"> + <title> + <function moreinfo="none">forward_reply()</function> + </title> + <para> + Forward received reply on demand. + </para> + <para> + This function can be used in CORE_ONREPLY_ROUTE. + </para> + <example> + <title><function>forward_reply</function> usage</title> + <programlisting format="linespecific"> +... +route[reply] { + forward_reply(); +} +... </programlisting> </example> </section>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev