- sr-dev - kamailio.org

git:master:22041301: evrexec: use structure of exec context attributes
by Daniel-Constantin Mierla 31 Mar '22

31 Mar '22

Module: kamailio Branch: master Commit: 220413010fa1e268501edd8808dc02fcc8b9d0d1 URL: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T17:28:29+02:00 evrexec: use structure of exec context attributes --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… Patch: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 89a189c9c8..e3d131ff9f 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -52,7 +52,14 @@ typedef struct evrexec_task { evrexec_task_t *_evrexec_list = NULL; -static str *pv_evr_data = NULL; +typedef struct evrexec_info { + str data; + str srcip; + str srcport; + int srcportno; +} evrexec_info_t; + +static evrexec_info_t _evrexec_info = { 0 }; /** module functions */ static int mod_init(void); @@ -222,7 +229,6 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) struct sockaddr_storage src_addr; socklen_t src_addr_len; ssize_t count; - str evr_data = STR_NULL; char srchostval[NI_MAXHOST]; char srcportval[NI_MAXSERV]; @@ -282,9 +288,8 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) LM_DBG("received data from %s port %s\n", srchostval, srcportval); } - evr_data.s = rcvbuf; - evr_data.len = (int)count; - pv_evr_data = &evr_data; + _evrexec_info.data.s = rcvbuf; + _evrexec_info.data.len = (int)count; fmsg = faked_msg_next(); set_route_type(LOCAL_ROUTE); @@ -302,7 +307,7 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) LM_ERR("error running event route kemi callback\n"); } } - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } /* avoid exiting the process */ while(1) { sleep(3600); } @@ -412,13 +417,13 @@ int evrexec_param(modparam_t type, void *val) */ static int pv_get_evr(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) { - if(param==NULL || pv_evr_data==NULL) { + if(param==NULL || _evrexec_info.data.s==NULL) { return pv_get_null(msg, param, res); } switch(param->pvn.u.isname.name.n) { case 0: /* data */ - return pv_get_strval(msg, param, res, pv_evr_data); + return pv_get_strval(msg, param, res, &_evrexec_info.data); default: return pv_get_null(msg, param, res); } @@ -489,12 +494,12 @@ void rpc_evr_run(rpc_t *rpc, void *c) evr_data.len = strlen(evr_data.s); } - pv_evr_data = &evr_data; + _evrexec_info.data = evr_data; keng = sr_kemi_eng_get(); if(keng==NULL) { evr_id = route_lookup(&event_rt, evr_name.s); if(evr_id == -1) { - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); LM_ERR("event route not found: %.*s\n", evr_name.len, evr_name.s); rpc->fault(c, 500, "Event route not found"); return; @@ -522,7 +527,7 @@ void rpc_evr_run(rpc_t *rpc, void *c) } } set_route_type(rtbk); - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } /**

1 0

git:master:0292cae2: evrexec: exposed src ip and port via variable
by Daniel-Constantin Mierla 31 Mar '22

31 Mar '22

Module: kamailio Branch: master Commit: 0292cae2812628e433cc07af6a45bf229e2ba708 URL: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-31T08:23:58+02:00 evrexec: exposed src ip and port via variable --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… Patch: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index e3d131ff9f..253197d100 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -286,6 +286,11 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) NI_NUMERICHOST | NI_NUMERICSERV); if(ret == 0) { LM_DBG("received data from %s port %s\n", srchostval, srcportval); + _evrexec_info.srcip.s = srchostval; + _evrexec_info.srcip.len = strlen(_evrexec_info.srcip.s); + _evrexec_info.srcport.s = srcportval; + _evrexec_info.srcport.len = strlen(_evrexec_info.srcport.s); + str2sint(&_evrexec_info.srcport, &_evrexec_info.srcportno); } _evrexec_info.data.s = rcvbuf; @@ -424,6 +429,19 @@ static int pv_get_evr(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) switch(param->pvn.u.isname.name.n) { case 0: /* data */ return pv_get_strval(msg, param, res, &_evrexec_info.data); + case 1: /* srcpip */ + if(_evrexec_info.srcip.s==NULL) { + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_evrexec_info.srcip); + case 2: /* srcport */ + if(_evrexec_info.srcport.s==NULL) { + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_evrexec_info.srcport); + case 3: /* srcportno */ + return pv_get_sintval(msg, param, res, _evrexec_info.srcportno); + default: return pv_get_null(msg, param, res); } @@ -445,6 +463,27 @@ static int pv_parse_evr_name(pv_spec_p sp, str *in) goto error; } break; + case 5: + if(strncmp(in->s, "srcip", 5)==0) { + sp->pvp.pvn.u.isname.name.n = 1; + } else { + goto error; + } + break; + case 7: + if(strncmp(in->s, "srcport", 7)==0) { + sp->pvp.pvn.u.isname.name.n = 2; + } else { + goto error; + } + break; + case 9: + if(strncmp(in->s, "srcportno", 9)==0) { + sp->pvp.pvn.u.isname.name.n = 3; + } else { + goto error; + } + break; default: goto error; }

1 0

git:master:b81000ca: evrexec: log src ip and port
by Daniel-Constantin Mierla 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: b81000ca0f3332a00831ce9d6e774027beb4a605 URL: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T13:01:03+02:00 evrexec: log src ip and port --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… Patch: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 71e7c94921..89a189c9c8 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -223,6 +223,8 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) socklen_t src_addr_len; ssize_t count; str evr_data = STR_NULL; + char srchostval[NI_MAXHOST]; + char srcportval[NI_MAXSERV]; if(parse_protohostport(&it->sockaddr, &phostp)<0 || phostp.port==0 || phostp.host.len>62 || phostp.sport.len>5) { @@ -273,6 +275,13 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) } rcvbuf[count] = '\0'; + ret = getnameinfo((struct sockaddr *)&src_addr, src_addr_len, srchostval, + sizeof(srchostval), srcportval, sizeof(srcportval), + NI_NUMERICHOST | NI_NUMERICSERV); + if(ret == 0) { + LM_DBG("received data from %s port %s\n", srchostval, srcportval); + } + evr_data.s = rcvbuf; evr_data.len = (int)count; pv_evr_data = &evr_data;

1 0

[kamailio/kamailio] When using t_relay to convert sip message udp to tcp, the source port changes (Issue #3069)
by zhangyang 30 Mar '22

30 Mar '22

My cfg file is written like this ： $du = "sip:"+$rd+":"+$rp+";transport=tcp"; ![image](https://user-images.githubusercontent.com/16113837/160795856-945514d5-b36b-4b1a-95a1-41d60bf0de7a.png) when i use $du = "sip:"+$rd+":"+$rp+";transport=udp"; the sip message will be normal ![image](https://user-images.githubusercontent.com/16113837/160796099-0d498eb2-e6a8-4703-9f4a-0e7d9b069bef.png) excuse me, can you tell me the reason ? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3069 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3069(a)github.com>

2 3

[kamailio/kamailio] Kamailio 5.4.x dialog profiles functionality dead-lock on certain high-load scenarios (Issue #2923)
by Henning Westerholt 30 Mar '22

30 Mar '22

### Description The Kamailio 5.4.x dialog profiles functionality can lead to dead-lock on certain high-load scenarios. The Kamailio dialog profiles are used to track parallel channels for about 200 outgoing PSTN carrier interconnections. During high traffic times (like several thousands parallel calls) the Kamailio server will frequently (e.g. hourly) goes into an end-less loop while executing get_profile_size in the configuration script. This causes the locking for the dialog profiles never be released and Kamailio will stop serving traffic. Internal monitoring tools and RPC commands stay working, as long as they do not touch the dialog functionality. A similar (dedicated) Kamailio setup is used for tracking parallel channels for customers. Here the dead-lock is not observed that frequently, but aparentely also some crashes happens in a much longer time interval. ### Troubleshooting After analysis of the back-traces with GDB the get_profile_size() function was removed from the configuration script. After this change the crash did not happened anymore for several days. #### Reproduction Issue could not be reproduced so far. #### Debugging Data ##### bt 1 (some data removed) (gdb) bt \# 0 0x00007f57cf3b00da in get_profile_size (profile=0x7f50ccbc7e80, value=0x7ffd9928f300) at dlg_profile.c:859 n = 364 i = 12 ph = 0x7f50d3e4b7d0 \# 1 0x00007f57cf419c67 in w_get_profile_size_helper (msg=0x7f57d699d418, profile=0x7f50ccbc7e80, value=0x7ffd9928f300, spd=0x7f57d6916960) at dialog.c:941 \# 2 0x00007f57cf41a459 in w_get_profile_size3 (msg=0x7f57d699d418, profile=0x7f50ccbc7e80, value=0x7f57d6935118, result=0x7f57d6916960) at dialog.c:982 \# 3 0x0000000000463fea in do_action (h=0x7ffd99293610, a=0x7f57d6936488, msg=0x7f57d699d418) at core/action.c:1094 \# 4 0x00000000004711ee in run_actions (h=0x7ffd99293610, a=0x7f57d6936488, msg=0x7f57d699d418) at core/action.c:1581 \# 5 0x000000000046058b in do_action (h=0x7ffd99293610, a=0x7f57d690fda8, msg=0x7f57d699d418) at core/action.c:700 The first back-trace was taking from a running process with gdb. The counter in f0 does not increased that much during this time, probably due the overflow of the loop counter. ##### bt2 (analysis with data structure with gdb scripts) Here the loop counter in f0 showed a really high value. Expected size of dialog profiles hash table: (gdb) p profile->entries[3] $4 = {first = 0x7f9bfd4aad98, content = 2068} (gdb) p profile->entries[7] $3 = {first = 0x7f9c12079f70, content = 784} (gdb) p profile->entries[12] $6 = {first = 0x7f9c02be5d50, content = 7600} (gdb) p profile->entries[14] $2 = {first = 0x7f9bff636de8, content = 6764} hash table bucket 14 shows a lot of corruption and the loop never ends (carrier names and IPs replaced). The list for hash bucket 7 got linked to the list for hash bucket 14: counter 6755: prev 0x7f9c0b9dcde0 - current 0x7f9c02e5b378 - next 0x7f9c0a5f9ba0 - value carrier1-XX.XX - hash 14 counter 6756: prev 0x7f9c02e5b378 - current 0x7f9c0a5f9ba0 - next 0x7f9c0860b968 - value carrier1-XX.XX▒▒▒▒ - hash 14 counter 6757: prev 0x7f9c0a5f9ba0 - current 0x7f9c0860b968 - next 0x7f9bfe3f3a78 - value carrier1-XX.XX▒▒▒▒ - hash 14 counter 6758: prev 0x7f9c0860b968 - current 0x7f9bfe3f3a78 - next 0x7f9c10d977f0 - value carrier1-XX.XX - hash 14 counter 6759: prev 0x7f9bfe3f3a78 - current 0x7f9c10d977f0 - next 0x7f9c0ae198b0 - value carrier2-XX.XX▒▒▒▒ - hash 7 counter 6760: prev 0x7f9c10d977f0 - current 0x7f9c0ae198b0 - next 0x7f9c12079f70 - value carrier3-XX.XX - hash 7 counter 6761: prev 0x7f9c0ae198b0 - current 0x7f9c12079f70 - next 0x7f9c011f2540 - value-carrier2-XX.XX▒▒▒▒ - hash 7 counter 6762: prev 0x7f9c12079f70 - current 0x7f9c011f2540 - next 0x7f9bfff886f0 - value carrier2-XX.XX▒▒▒▒ - hash 7 counter 6763: prev 0x7f9c011f2540 - current 0x7f9bfff886f0 - next 0x7f9c05db00a8 - value carrier3-XX.XX= - hash 7 [...] counter 28270: prev 0x7f9c019d06e8 - current 0x7f9bfaf18290 - next 0x7f9c12c90680 - value carrier2-XX.XX▒▒▒▒ - hash 7 counter 28271: prev 0x7f9bfaf18290 - current 0x7f9c12c90680 - next 0x7f9c086a2b58 - value-carrier2-XX.XX▒▒▒▒ - hash 7 counter 28272: prev 0x7f9c12c90680 - current 0x7f9c086a2b58 - next 0x7f9c0b4f09e8 - value carrier2-XX.XX▒▒▒▒ - hash 7 [...] hash table bucket 7 is still consistent regarding the loop, but already shows initial sign of corruption. There is one item of the list for hash bucket 14 visible: counter 780: prev 0x7f9c0db57ac8 - current 0x7f9c02225700 - next 0x7f9bfbf7db08 - value carrier2-XX.XX▒▒▒▒ - hash 7 counter 781: prev 0x7f9c02225700 - current 0x7f9bfbf7db08 - next 0x7f9c10d977f0 - value carrier1-XX.XX- hash 14 counter 782: prev 0x7f9bfe3f3a78 - current 0x7f9c10d977f0 - next 0x7f9c0ae198b0 - value carrier2-XX.XX▒▒▒▒ - hash 7 counter 783: prev 0x7f9c10d977f0 - current 0x7f9c0ae198b0 - next 0x7f9c12079f70 - value carrier3-XX.XX - hash 7 total size of hash table is 784 #### Log Messages No special log messages observed. #### SIP Traffic SIP traffic looked ok during analysis of the core dumps. ### Possible Solutions * adding additional safe-guards for the get_profile_size function to not access data from other hash buckets * stopping the loop counter after some threshold * finding and fixing the source of the internal data corruption (obviously) * refactoring the dialog modules to use another approach for storing the dialog profile information ### Additional Information * **Kamailio version**: Kamailio 5.4.7, compiled from git repository * **Operating System**: CentOS 7.9 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2923

3 6

git:master:e792de60: modules: readme files regenerated - evrexec ... [skip ci]
by Kamailio Dev 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: e792de60d24386cdd3816b67d4778f4eba33b0f0 URL: https://github.com/kamailio/kamailio/commit/e792de60d24386cdd3816b67d4778f4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-30T08:46:20+02:00 modules: readme files regenerated - evrexec ... [skip ci] --- Modified: src/modules/evrexec/README --- Diff: https://github.com/kamailio/kamailio/commit/e792de60d24386cdd3816b67d4778f4… Patch: https://github.com/kamailio/kamailio/commit/e792de60d24386cdd3816b67d4778f4… --- diff --git a/src/modules/evrexec/README b/src/modules/evrexec/README index f7363c4c43..4d80d4c006 100644 --- a/src/modules/evrexec/README +++ b/src/modules/evrexec/README @@ -57,11 +57,12 @@ Chapter 1. Admin Guide 1. Overview The module executes event route blocks or KEMI functions on dedicated - processes at startup. The execution can be delayed for a specified - interval of time. + processes at startup, upon an RPC command or data received on a custom + UDP socket. - The actions in the event route should be a loop or other tasks that run - forever. + For startup event route, the execution can be delayed for a specified + interval of time. The actions in the event route should be a loop or + other tasks that run forever. 2. Dependencies @@ -87,7 +88,8 @@ Chapter 1. Admin Guide The definition of an exec task. The value of the parameter must have the following format: - * "name=_string_;wait=_number_;workers=_number_" + * "name=_string_;wait=_number_;workers=_number_;sockaddr=_udp_socket_ + " The parameter can be set multiple times to get more exec tasks in same configuration file. @@ -97,15 +99,20 @@ Chapter 1. Admin Guide will retrieve the index of the works in string format. * workers - if set to 0 or 1 the task is executed in a dedicated process. Any number > 1 will create more dedicated processes, each - of them executing the task. + of them executing the startup task. For UDP data execution (when + 'sockaddr' is set), only 1 worker process is created. * wait - timer interval in micro-seconds to wait inside the dedicated process before executing the task. + * sockaddr - full UDP socket address in format 'udp:ip:port' + (example: 'udp:127.0.0.1:54321'). Default value is NULL. Example 1.1. Set exec parameter ... modparam("evrexec", "exec", "name=evrexec:timer;wait=1000;workers=1;") +modparam("evrexec", "exec", "name=evrexec:udp;sockaddr=udp:127.0.0.1:4444;worker +s=1;") ... event_route[evrexec:timer] { $var(x) = 0; @@ -115,6 +122,11 @@ event_route[evrexec:timer] { sleep("600"); } } + +event_route[evrexec:udp] { + xinfo("udp socket data: [$evr(data)]\n"); +} + ... 4. RPC Commands

1 0

git:master:b3f59ded: core: keep references to proto and port parts by parse_protohostport()
by Daniel-Constantin Mierla 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: b3f59ded7d5ea9b183e4d301ca2a69aaeb966e65 URL: https://github.com/kamailio/kamailio/commit/b3f59ded7d5ea9b183e4d301ca2a69a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T08:26:32+02:00 core: keep references to proto and port parts by parse_protohostport() --- Modified: src/core/socket_info.c Modified: src/core/socket_info.h --- Diff: https://github.com/kamailio/kamailio/commit/b3f59ded7d5ea9b183e4d301ca2a69a… Patch: https://github.com/kamailio/kamailio/commit/b3f59ded7d5ea9b183e4d301ca2a69a… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 00d7bdf289..500945a22a 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -2271,11 +2271,14 @@ int parse_protohostport(str* ins, sr_phostp_t *r) if (second) { /* 2 ':' found => check if valid */ if (parse_proto((unsigned char*)ins->s, first-ins->s, &r->proto)<0) goto error_proto; + r->sproto.s = ins->s; + r->sproto.len = first-ins->s; tmp.s=second+1; tmp.len=(ins->s + ins->len) - tmp.s; if (str2int(&tmp, (unsigned int *)&(r->port))<0) goto error_port; + r->sport = tmp; r->host.s=first+1; r->host.len=(int)(second-r->host.s); @@ -2288,10 +2291,13 @@ int parse_protohostport(str* ins, sr_phostp_t *r) /* invalid port => it's proto:host */ if (parse_proto((unsigned char*)ins->s, first-ins->s, &r->proto)<0) goto error_proto; + r->sproto.s = ins->s; + r->sproto.len = first-ins->s; r->host.s=first+1; r->host.len=(int)(p-r->host.s); }else{ /* valid port => its host:port */ + r->sport = tmp; r->host.s=ins->s; r->host.len=(int)(first-r->host.s); } diff --git a/src/core/socket_info.h b/src/core/socket_info.h index 4bf7b3e96c..50e4a063c1 100644 --- a/src/core/socket_info.h +++ b/src/core/socket_info.h @@ -151,8 +151,10 @@ inline static struct socket_info* get_first_socket(void) /* structure to break down 'proto:host:port' */ typedef struct _sr_phostp { + str sproto; int proto; str host; + str sport; int port; } sr_phostp_t;

1 0

git:master:a2d97f89: evrexec: execute event route on data received on a custom udp socket
by Daniel-Constantin Mierla 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: a2d97f897b5ee1cc550480af02af8d79b94a8ef3 URL: https://github.com/kamailio/kamailio/commit/a2d97f897b5ee1cc550480af02af8d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T08:27:12+02:00 evrexec: execute event route on data received on a custom udp socket --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a2d97f897b5ee1cc550480af02af8d7… Patch: https://github.com/kamailio/kamailio/commit/a2d97f897b5ee1cc550480af02af8d7…

1 0

git:master:a074608c: evrexec: docs for sockaddr attribute
by Daniel-Constantin Mierla 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: a074608ca41e70b21de27e050869883e70e13033 URL: https://github.com/kamailio/kamailio/commit/a074608ca41e70b21de27e050869883… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T08:40:45+02:00 evrexec: docs for sockaddr attribute --- Modified: src/modules/evrexec/doc/evrexec_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a074608ca41e70b21de27e050869883… Patch: https://github.com/kamailio/kamailio/commit/a074608ca41e70b21de27e050869883… --- diff --git a/src/modules/evrexec/doc/evrexec_admin.xml b/src/modules/evrexec/doc/evrexec_admin.xml index bcd6af5f49..565b33f560 100644 --- a/src/modules/evrexec/doc/evrexec_admin.xml +++ b/src/modules/evrexec/doc/evrexec_admin.xml @@ -17,12 +17,13 @@ <title>Overview</title> <para> The module executes event route blocks or KEMI functions on dedicated - processes at startup. The execution can be delayed for a specified - interval of time. + processes at startup, upon an RPC command or data received on a custom + UDP socket. </para> <para> - The actions in the event route should be a loop or other tasks that - run forever. + For startup event route, the execution can be delayed for a specified + interval of time. The actions in the event route should be a loop or + other tasks that run forever. </para> </section> <section> @@ -66,7 +67,7 @@ <itemizedlist> <listitem> <para> - "name=_string_;wait=_number_;workers=_number_" + "name=_string_;wait=_number_;workers=_number_;sockaddr=_udp_socket_" </para> </listitem> </itemizedlist> @@ -88,7 +89,8 @@ <para> <emphasis>workers</emphasis> - if set to 0 or 1 the task is executed in a dedicated process. Any number > 1 will create more dedicated - processes, each of them executing the task. + processes, each of them executing the startup task. For UDP data + execution (when 'sockaddr' is set), only 1 worker process is created. </para> </listitem> <listitem> @@ -97,6 +99,13 @@ inside the dedicated process before executing the task. </para> </listitem> + <listitem> + <para> + <emphasis>sockaddr</emphasis> - full UDP socket address in format + 'udp:ip:port' (example: 'udp:127.0.0.1:54321'). + </para> + </listitem> + </itemizedlist> <para> <emphasis> @@ -108,6 +117,7 @@ <programlisting format="linespecific"> ... modparam("evrexec", "exec", "name=evrexec:timer;wait=1000;workers=1;") +modparam("evrexec", "exec", "name=evrexec:udp;sockaddr=udp:127.0.0.1:4444;workers=1;") ... event_route[evrexec:timer] { $var(x) = 0; @@ -117,6 +127,11 @@ event_route[evrexec:timer] { sleep("600"); } } + +event_route[evrexec:udp] { + xinfo("udp socket data: [$evr(data)]\n"); +} + ... </programlisting> </example>

1 0

[kamailio/kamailio] More than TCP 800 concurrent calls, slows Kamailio (LUA FILE API REQUESTS) (Issue #3068)
by giofrigo 29 Mar '22

29 Mar '22

### Description Hello Guys I am having this issue where kamailio is receiving requests from SIPp (we are currently testing the platform and doing QA) but if we do more than 800 concurrent calls kamailio starts failing and slowing the requests, The scenario is the following: I am sending 5000 calls at 100 CPS on TCP and I am having this route in the configuration file: ``` # Handle the calls to api route[CALL_API] { xlog("L_NOTICE"," Call request $var(call_request) method: $rm \n"); $var(loop_true)=1; while ($var(loop_true)) { if(!lua_run("call_request","$var(call_request)","$sht(token=>new_token)")) { xlog("L_NOTICE", "SCRIPT: failed to execute lua function!\n"); } if ($var(loop_true)){ sleep("1"); } } xlog("L_NOTICE", "SCRIPT: Sucess to execute lua function!\n"); } ``` So I am executing a LUA script for the requests and the API response will tell the destination of the call. At 800 concurrent calls, I can notice SLOWLINESS in the SIPp testing tool, and then I will start receiving 408 timeouts. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.8 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**:  ``` BUT KAMAILIO IS RUNNING IN A DOCKER CONTAINER Linux ip-10-10-0-27.us-west-1.compute.internal 4.14.246-187.474.amzn2.x86_64 #1 SMP Tue Sep 7 21:48:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux ``` This sounds like a load issue or something because I believe there's a time that it's been added every time we hit the backend and wait for the response. any help will be appreciated Regards Gio -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3068 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3068(a)github.com>

2 3

git:master:d1bb4892: modules: readme files regenerated - stirshaken ... [skip ci]
by Kamailio Dev 29 Mar '22

29 Mar '22

Module: kamailio Branch: master Commit: d1bb4892c74062a0e4a6f932b76c1bdb3fa59ebb URL: https://github.com/kamailio/kamailio/commit/d1bb4892c74062a0e4a6f932b76c1bd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-29T20:01:24+02:00 modules: readme files regenerated - stirshaken ... [skip ci] --- Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/d1bb4892c74062a0e4a6f932b76c1bd… Patch: https://github.com/kamailio/kamailio/commit/d1bb4892c74062a0e4a6f932b76c1bd…

1 0

git:master:1989193a: stirshaken: docs - removed extra section ending tag
by Daniel-Constantin Mierla 29 Mar '22

29 Mar '22

Module: kamailio Branch: master Commit: 1989193a1ce22b06be0fef23e84e92084d9ecdc6 URL: https://github.com/kamailio/kamailio/commit/1989193a1ce22b06be0fef23e84e920… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-29T19:57:52+02:00 stirshaken: docs - removed extra section ending tag --- Modified: src/modules/stirshaken/doc/stirshaken_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1989193a1ce22b06be0fef23e84e920… Patch: https://github.com/kamailio/kamailio/commit/1989193a1ce22b06be0fef23e84e920… --- diff --git a/src/modules/stirshaken/doc/stirshaken_admin.xml b/src/modules/stirshaken/doc/stirshaken_admin.xml index 12032f83ba..1e7c7001ef 100644 --- a/src/modules/stirshaken/doc/stirshaken_admin.xml +++ b/src/modules/stirshaken/doc/stirshaken_admin.xml @@ -57,7 +57,6 @@ </itemizedlist> </para> </section> - </section> <section> <title>Parameters</title> <section>

1 0

git:master:68bb7859: modules: readme files regenerated - stirshaken ... [skip ci]
by Kamailio Dev 25 Mar '22

25 Mar '22

Module: kamailio Branch: master Commit: 68bb785914a8f2efef678974e845e7e7a36382ea URL: https://github.com/kamailio/kamailio/commit/68bb785914a8f2efef678974e845e7e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-25T13:16:25+01:00 modules: readme files regenerated - stirshaken ... [skip ci] --- Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/68bb785914a8f2efef678974e845e7e… Patch: https://github.com/kamailio/kamailio/commit/68bb785914a8f2efef678974e845e7e…

1 0

[kamailio/kamailio] stirshaken: Add PVs to allow access to x509 subject and ppt grants (PR #3063)
by mrtrev 25 Mar '22

25 Mar '22

- added vs_certsubject_pvname and vs_pptgrants_pvname config params - adjusted log level of load/unload events   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3063 -- Commit Summary -- * stirshaken: Add PVs to allow access to x509 subject and ppt grants -- File Changes -- M src/modules/stirshaken/doc/stirshaken_admin.xml (41) M src/modules/stirshaken/stirshaken_mod.c (72) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3063.patch https://github.com/kamailio/kamailio/pull/3063.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3063 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3063(a)github.com>

2 4

git:master:363b9da8: stirshaken: Add PVs to allow access to x509 subject and ppt grants
by Daniel-Constantin Mierla 25 Mar '22

25 Mar '22

Module: kamailio Branch: master Commit: 363b9da8516ee56b9892f760b24c531c19cee3b5 URL: https://github.com/kamailio/kamailio/commit/363b9da8516ee56b9892f760b24c531… Author: Trevor Peirce <trev(a)acrovoice.ca> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-25T13:12:37+01:00 stirshaken: Add PVs to allow access to x509 subject and ppt grants - added vs_certsubject_pvname and vs_pptgrants_pvname config params - adjusted log level of load/unload events --- Modified: src/modules/stirshaken/doc/stirshaken_admin.xml Modified: src/modules/stirshaken/stirshaken_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/363b9da8516ee56b9892f760b24c531… Patch: https://github.com/kamailio/kamailio/commit/363b9da8516ee56b9892f760b24c531…

1 0

[kamailio/kamailio] siptrace: add direction attribute to exported by module pseudo-variable (PR #3061)
by Dennis 24 Mar '22

24 Mar '22

- Add direction attribute to event route siptrace pseudo-variable.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3061 -- Commit Summary -- * siptrace: add direction attribute to exported by module pseudo-variable -- File Changes -- M src/modules/siptrace/siptrace.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3061.patch https://github.com/kamailio/kamailio/pull/3061.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3061 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3061(a)github.com>

2 2

git:master:2f9c0c4d: siptrace: add direction attribute to exported by module pseudo-variable
by Daniel-Constantin Mierla 24 Mar '22

24 Mar '22

Module: kamailio Branch: master Commit: 2f9c0c4d2b6551bb0f8f1915d2585d96c3bca8cb URL: https://github.com/kamailio/kamailio/commit/2f9c0c4d2b6551bb0f8f1915d2585d9… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-24T14:08:09+01:00 siptrace: add direction attribute to exported by module pseudo-variable - Add direction attribute to event route siptrace pseudo-variable. --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/2f9c0c4d2b6551bb0f8f1915d2585d9… Patch: https://github.com/kamailio/kamailio/commit/2f9c0c4d2b6551bb0f8f1915d2585d9… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 95c9b8ac7a..9540e83d06 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2601,6 +2601,8 @@ int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, return pv_get_strval(msg, param, res, &host); case 9: /* dst_hostip */ return pv_get_strval(msg, param, res, &host); + case 10: /* direction */ + return pv_get_strzval(msg, param, res, siptrace_event_data->dir); default: LM_ERR("unexpected config param\n"); return pv_get_null(msg, param, res); @@ -2644,6 +2646,8 @@ int pv_parse_siptrace_name(pv_spec_t *sp, str *in) sp->pvp.pvn.u.isname.name.n = 8; else if(strncmp(in->s, "dst_hostip", 10)==0) sp->pvp.pvn.u.isname.name.n = 9; + else if(strncmp(in->s, "direction", 10)==0) + sp->pvp.pvn.u.isname.name.n = 10; else goto error; break; default:

1 0

licensing of videos and images from Kamailio World?
by Daniel Pocock 24 Mar '22

24 Mar '22

There are various pages about the videos from Kamailio World but nothing there about the license... https://www.kamailio.org/w/2020/09/kamailio-world-2020-online-video-recordi… https://www.youtube.com/c/KamailioWorld/ There is a fair use doctrine that people can generally use a screenshot or extract from copyrighted material but it is better to have some explicit statement there. Could anybody please clarify this and update the web page? There are two details required: 1. Who owns the copyright? By default, the name of the volunteer(s) who recorded the videos or if the work was done under contract, was copyright transferred to Kamailio, Asipto or anybody else? 2. Which license? The CC BY SA 4.0 license might be a good choice consistent with existing Kamailio licensing: BY: must credit the original work (Kamailio or volunteer) SA: (ShareAlike) - derivative works must also be CC BY SA (viral effect, like the GPL used for Kamailio itself) https://creativecommons.org/choose/ I suspect that many speakers are motivated to use their videos in some commercial context and may not be keen to apply the No Derivatives (ND) or Non-Commercial (NC) constraints from Creative Commons. Thanks to those who produced and shared these works for the community. Regards, Daniel -- https://danielpocock.com

3 7

git:master:8d5d5a87: etc/kamailio.cfg: add return to root blocks
by Daniel-Constantin Mierla 24 Mar '22

24 Mar '22

Module: kamailio Branch: master Commit: 8d5d5a872c0bafa2e591b69fa5d8c17179e1e4a4 URL: https://github.com/kamailio/kamailio/commit/8d5d5a872c0bafa2e591b69fa5d8c17… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-24T11:10:32+01:00 etc/kamailio.cfg: add return to root blocks - make it more explicit for returned code --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/8d5d5a872c0bafa2e591b69fa5d8c17… Patch: https://github.com/kamailio/kamailio/commit/8d5d5a872c0bafa2e591b69fa5d8c17… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 56c1ea791e..2333eacacc 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -567,6 +567,8 @@ request_route { # user location service route(LOCATION); + + return; } # Wrapper for relaying requests @@ -1002,6 +1004,7 @@ route[TOVOICEMAIL] { branch_route[MANAGE_BRANCH] { xdbg("new branch [$T_branch_idx] to $ru\n"); route(NATMANAGE); + return; } # Manage incoming replies @@ -1010,6 +1013,7 @@ reply_route { xlog("Malformed SIP response from $si:$sp\n"); drop; } + return; } # Manage incoming replies in transaction context @@ -1018,6 +1022,7 @@ onreply_route[MANAGE_REPLY] { if(status=~"[12][0-9][0-9]") { route(NATMANAGE); } + return; } # Manage failure routing cases @@ -1051,4 +1056,5 @@ failure_route[MANAGE_FAILURE] { exit; } #!endif + return; }

1 0

bug in tm module?
by dpaape＠frontier.com 23 Mar '22

23 Mar '22

Hello I'm running K5.5.3 and have checked the 'issues' link in github and saw nothing regarding what I am seeing. I think that there is a bug in the tm module with respect to the "tm:local-response" event route. In the "t_reply.c" file, there is a static variable called '_tm_local_response_set_lookup'. This variable is initialized at load time to zero. It is checked in the '_reply_light()' routine and will initiate a local callback from the config script if "armed". The problem as I see it is that if the callback is readied, the variable is set to one. But it is never reset.So the practical outworking is as follows. A register is received and the request_route arms the callback. The register requires an authorization (local database sqlite). After the 401 is sent back, the callback via the module event route is called as expected. All good except that the module event route script fragment is never executed again after the first call.I'm no expert on the tm module but I would think that somewhere in there, the variable should be reset to zero so that subsequent transactions can initiate the event route again. thanks for any help,Dan

1 0

[kamailio/kamailio] core parsing of SIP message failed (Issue #3062)
by soroshsabz 22 Mar '22

22 Mar '22

ITNOA ### Description I try to connect Kamailio and Freeswitch together, and initiate call from Zoiper5 soft phone through Kamailio My Kamailio config is below ``` #!ifdef ACCDB_COMMENT ALTER TABLE acc ADD COLUMN src_user VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE acc ADD COLUMN src_domain VARCHAR(128) NOT NULL DEFAULT ''; ALTER TABLE acc ADD COLUMN src_ip varchar(64) NOT NULL default ''; ALTER TABLE acc ADD COLUMN dst_ouser VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE acc ADD COLUMN dst_user VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE acc ADD COLUMN dst_domain VARCHAR(128) NOT NULL DEFAULT ''; ALTER TABLE missed_calls ADD COLUMN src_user VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE missed_calls ADD COLUMN src_domain VARCHAR(128) NOT NULL DEFAULT ''; ALTER TABLE missed_calls ADD COLUMN src_ip varchar(64) NOT NULL default ''; ALTER TABLE missed_calls ADD COLUMN dst_ouser VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE missed_calls ADD COLUMN dst_user VARCHAR(64) NOT NULL DEFAULT ''; ALTER TABLE missed_calls ADD COLUMN dst_domain VARCHAR(128) NOT NULL DEFAULT ''; #!endif ####### Include Local Config If Exists ######### import_file "kamailio-local.cfg" ####### Defined Values ######### # *** Value defines - IDs used later in config #!ifdef WITH_DEBUG #!define DBGLEVEL 3 #!else #!define DBGLEVEL 2 #!endif #!ifdef WITH_MYSQL # - database URL - used to connect to database server by modules such # as: auth_db, acc, usrloc, a.s.o. #!trydef DBURL "mysql://kamailio:kamailiorw@localhost/kamailio" #!endif #!ifdef WITH_MULTIDOMAIN # - the value for 'use_domain' parameters #!define MULTIDOMAIN 1 #!else #!define MULTIDOMAIN 0 #!endif # - flags # FLT_ - per transaction (message) flags # FLB_ - per branch flags #!define FLT_ACC 1 #!define FLT_ACCMISSED 2 #!define FLT_ACCFAILED 3 #!define FLT_NATS 5 #!define FLB_NATB 6 #!define FLB_NATSIPPING 7 ####### Global Parameters ######### /* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */ debug=DBGLEVEL /* set to 'yes' to print log messages to terminal or use '-E' cli option */ log_stderror=yes memdbg=5 memlog=5 log_facility=LOG_LOCAL0 log_prefix="{$mt $hdr(CSeq) $ci} " /* number of SIP routing processes for each UDP socket * - value inherited by tcp_children and sctp_children when not set explicitely */ children=8 /* uncomment the next line to disable TCP (default on) */ disable_tcp=yes /* number of SIP routing processes for all TCP/TLS sockets */ # tcp_children=8 /* uncomment the next line to disable the auto discovery of local aliases * based on reverse DNS on IPs (default on) */ auto_aliases=no /* add local domain aliases - it can be set many times */ # alias="sip.mydomain.com" /* listen sockets - if none set, Kamailio binds to all local IP addresses * - basic prototype (full prototype can be found in Wiki - Core Cookbook): * listen=[proto]:[localip]:[lport] advertise [publicip]:[pport] * - it can be set many times to add more sockets to listen to */ listen=udp:172.28.72.99:5060 advertise 172.28.72.99:5060 #listen=tcp:172.28.72.99:5060 /* life time of TCP connection when there is no traffic * - a bit higher than registration expires to cope with UA behind NAT */ tcp_connection_lifetime=3605 /* upper limit for TCP connections (it includes the TLS connections) */ tcp_max_connections=2048 #!ifdef WITH_JSONRPC tcp_accept_no_cl=yes #!endif #!ifdef WITH_TLS enable_tls=no /* upper limit for TLS connections */ tls_max_connections=2048 #!endif /* set it to yes to enable sctp and load sctp.so module */ enable_sctp=no ####### Custom Parameters ######### /* These parameters can be modified runtime via RPC interface * - see the documentation of 'cfg_rpc' module. * * Format: group.id = value 'desc' description * Access: $sel(cfg_get.group.id) or @cfg_get.group.id */ #!ifdef WITH_PSTN /* PSTN GW Routing * * - pstn.gw_ip: valid IP or hostname as string value, example: * pstn.gw_ip = "10.0.0.101" desc "My PSTN GW Address" * * - by default is empty to avoid misrouting */ pstn.gw_ip = "" desc "PSTN GW Address" pstn.gw_port = "" desc "PSTN GW Port" #!endif #!ifdef WITH_VOICEMAIL /* VoiceMail Routing on offline, busy or no answer * * - by default Voicemail server IP is empty to avoid misrouting */ voicemail.srv_ip = "" desc "VoiceMail IP Address" voicemail.srv_port = "5060" desc "VoiceMail Port" #!endif ####### Modules Section ######## /* set paths to location of modules */ # mpath="/usr/lib/x86_64-linux-gnu/kamailio/modules/" #!ifdef WITH_MYSQL loadmodule "db_mysql.so" #!endif #!ifdef WITH_JSONRPC loadmodule "xhttp.so" #!endif loadmodule "jsonrpcs.so" loadmodule "kex.so" loadmodule "corex.so" loadmodule "tm.so" loadmodule "tmx.so" loadmodule "sl.so" loadmodule "rr.so" loadmodule "pv.so" loadmodule "maxfwd.so" loadmodule "usrloc.so" loadmodule "registrar.so" loadmodule "textops.so" loadmodule "textopsx.so" loadmodule "siputils.so" loadmodule "xlog.so" loadmodule "sanity.so" loadmodule "ctl.so" loadmodule "cfg_rpc.so" loadmodule "acc.so" loadmodule "counters.so" #!ifdef WITH_AUTH loadmodule "auth.so" loadmodule "auth_db.so" #!ifdef WITH_IPAUTH loadmodule "permissions.so" #!endif #!endif #!ifdef WITH_ALIASDB loadmodule "alias_db.so" #!endif #!ifdef WITH_SPEEDDIAL loadmodule "speeddial.so" #!endif #!ifdef WITH_MULTIDOMAIN loadmodule "domain.so" #!endif #!ifdef WITH_PRESENCE loadmodule "presence.so" loadmodule "presence_xml.so" #!endif #!ifdef WITH_NAT loadmodule "nathelper.so" #!ifdef WITH_RTPENGINE loadmodule "rtpengine.so" #!else loadmodule "rtpproxy.so" #!endif #!endif #!ifdef WITH_TLS loadmodule "tls.so" #!endif #!ifdef WITH_ANTIFLOOD loadmodule "htable.so" loadmodule "pike.so" #!endif #!ifdef WITH_DEBUG loadmodule "debugger.so" #!endif # ----------------- setting module-specific parameters --------------- # ----- jsonrpcs params ----- modparam("jsonrpcs", "pretty_format", 1) /* set the path to RPC fifo control file */ # modparam("jsonrpcs", "fifo_name", "/run/kamailio/kamailio_rpc.fifo") /* set the path to RPC unix socket control file */ # modparam("jsonrpcs", "dgram_socket", "/run/kamailio/kamailio_rpc.sock") #!ifdef WITH_JSONRPC modparam("jsonrpcs", "transport", 7) #!endif # ----- ctl params ----- /* set the path to RPC unix socket control file */ # modparam("ctl", "binrpc", "unix:/run/kamailio/kamailio_ctl") # ----- sanity params ----- modparam("sanity", "autodrop", 0) # ----- tm params ----- # auto-discard branches from previous serial forking leg modparam("tm", "failure_reply_mode", 3) # default retransmission timeout: 30sec modparam("tm", "fr_timer", 30000) # default invite retransmission timeout after 1xx: 120sec modparam("tm", "fr_inv_timer", 120000) # ----- rr params ----- # set next param to 1 to add value to ;lr param (helps with some UAs) modparam("rr", "enable_full_lr", 0) # do not append from tag to the RR (no need for this script) modparam("rr", "append_fromtag", 0) # ----- registrar params ----- modparam("registrar", "method_filtering", 1) /* uncomment the next line to disable parallel forking via location */ # modparam("registrar", "append_branches", 0) /* uncomment the next line not to allow more than 10 contacts per AOR */ # modparam("registrar", "max_contacts", 10) /* max value for expires of registrations */ modparam("registrar", "max_expires", 3600) /* set it to 1 to enable GRUU */ modparam("registrar", "gruu_enabled", 0) /* set it to 0 to disable Path handling */ modparam("registrar", "use_path", 1) /* save Path even if not listed in Supported header */ modparam("registrar", "path_mode", 0) # ----- acc params ----- /* what special events should be accounted ? */ modparam("acc", "early_media", 0) modparam("acc", "report_ack", 0) modparam("acc", "report_cancels", 0) /* by default ww do not adjust the direct of the sequential requests. * if you enable this parameter, be sure the enable "append_fromtag" * in "rr" module */ modparam("acc", "detect_direction", 0) /* account triggers (flags) */ modparam("acc", "log_flag", FLT_ACC) modparam("acc", "log_missed_flag", FLT_ACCMISSED) modparam("acc", "log_extra", "src_user=$fU;src_domain=$fd;src_ip=$si;" "dst_ouser=$tU;dst_user=$rU;dst_domain=$rd") modparam("acc", "failed_transaction_flag", FLT_ACCFAILED) /* enhanced DB accounting */ #!ifdef WITH_ACCDB modparam("acc", "db_flag", FLT_ACC) modparam("acc", "db_missed_flag", FLT_ACCMISSED) modparam("acc", "db_url", DBURL) modparam("acc", "db_extra", "src_user=$fU;src_domain=$fd;src_ip=$si;" "dst_ouser=$tU;dst_user=$rU;dst_domain=$rd") #!endif # ----- usrloc params ----- modparam("usrloc", "timer_interval", 60) modparam("usrloc", "timer_procs", 1) modparam("usrloc", "use_domain", MULTIDOMAIN) /* enable DB persistency for location entries */ #!ifdef WITH_USRLOCDB modparam("usrloc", "db_url", DBURL) modparam("usrloc", "db_mode", 2) #!endif # ----- auth_db params ----- #!ifdef WITH_AUTH modparam("auth_db", "db_url", DBURL) modparam("auth_db", "calculate_ha1", yes) modparam("auth_db", "password_column", "password") modparam("auth_db", "load_credentials", "") modparam("auth_db", "use_domain", MULTIDOMAIN) # ----- permissions params ----- #!ifdef WITH_IPAUTH modparam("permissions", "db_url", DBURL) modparam("permissions", "db_mode", 1) #!endif #!endif # ----- alias_db params ----- #!ifdef WITH_ALIASDB modparam("alias_db", "db_url", DBURL) modparam("alias_db", "use_domain", MULTIDOMAIN) #!endif # ----- speeddial params ----- #!ifdef WITH_SPEEDDIAL modparam("speeddial", "db_url", DBURL) modparam("speeddial", "use_domain", MULTIDOMAIN) #!endif # ----- domain params ----- #!ifdef WITH_MULTIDOMAIN modparam("domain", "db_url", DBURL) /* register callback to match myself condition with domains list */ modparam("domain", "register_myself", 1) #!endif #!ifdef WITH_PRESENCE # ----- presence params ----- modparam("presence", "db_url", DBURL) # ----- presence_xml params ----- modparam("presence_xml", "db_url", DBURL) modparam("presence_xml", "force_active", 1) #!endif #!ifdef WITH_NAT #!ifdef WITH_RTPENGINE # ----- rtpengine params ----- modparam("rtpengine", "rtpengine_sock", "udp:127.0.0.1:2223") #!else # ----- rtpproxy params ----- modparam("rtpproxy", "rtpproxy_sock", "udp:127.0.0.1:7722") #!endif # ----- nathelper params ----- modparam("nathelper", "natping_interval", 30) modparam("nathelper", "ping_nated_only", 1) modparam("nathelper", "sipping_bflag", FLB_NATSIPPING) modparam("nathelper", "sipping_from", "sip:pinger@kamailio.org") # params needed for NAT traversal in other modules modparam("nathelper|registrar", "received_avp", "$avp(RECEIVED)") modparam("usrloc", "nat_bflag", FLB_NATB) #!endif #!ifdef WITH_TLS # ----- tls params ----- modparam("tls", "config", "/etc/kamailio/tls.cfg") #!endif #!ifdef WITH_ANTIFLOOD # ----- pike params ----- modparam("pike", "sampling_time_unit", 2) modparam("pike", "reqs_density_per_unit", 16) modparam("pike", "remove_latency", 4) # ----- htable params ----- /* ip ban htable with autoexpire after 5 minutes */ modparam("htable", "htable", "ipban=>size=8;autoexpire=300;") #!endif #!ifdef WITH_DEBUG # ----- debugger params ----- modparam("debugger", "cfgtrace", 1) modparam("debugger", "log_level_name", "exec") #!endif ####### Routing Logic ######## /* Main SIP request routing logic * - processing of any incoming SIP request starts with this route * - note: this is the same as route { ... } */ request_route { # per request initial checks # route(REQINIT); # NAT detection #route(NATDETECT); # CANCEL processing if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } exit; } # handle retransmissions if (!is_method("ACK")) { if(t_precheck_trans()) { t_check_trans(); exit; } t_check_trans(); } if (is_method("REGISTER")) { xdbg("request from gggggggggggggggggggggggggggggggggggggggggg - $rm from $fu (IP:$si:$sp)\n"); } rewritehostport("172.28.69.52:5060"); # handle requests within SIP dialogs # route(WITHINDLG); ### only initial requests (no To tag) # authentication # route(AUTH); # record routing for dialog forming requests (in case they are routed) # - remove preloaded route headers #remove_hf("Route"); #if (is_method("INVITE|SUBSCRIBE")) { # record_route(); #} # account only INVITEs #if (is_method("INVITE")) { # setflag(FLT_ACC); # do accounting #} # dispatch requests to foreign domains #route(SIPOUT); ### requests for my local domains # handle presence related requests #route(PRESENCE); # handle registrations # route(REGISTRAR); #if ($rU==$null) { # # request with no Username in RURI # sl_send_reply("484","Address Incomplete"); # exit; #} # dispatch destinations to PSTN #route(PSTN); # user location service #route(LOCATION); } # Wrapper for relaying requests route[RELAY] { # enable additional event routes for forwarded requests # - serial forking, RTP relaying handling, a.s.o. if (is_method("INVITE|BYE|SUBSCRIBE|UPDATE")) { if(!t_is_set("branch_route")) t_on_branch("MANAGE_BRANCH"); } if (is_method("INVITE|SUBSCRIBE|UPDATE")) { if(!t_is_set("onreply_route")) t_on_reply("MANAGE_REPLY"); } if (is_method("INVITE")) { if(!t_is_set("failure_route")) t_on_failure("MANAGE_FAILURE"); } if (!t_relay()) { sl_reply_error(); } exit; } # Per SIP request initial checks route[REQINIT] { # no connect for sending replies set_reply_no_connect(); # enforce symmetric signaling # - send back replies to the source address of request force_rport(); #!ifdef WITH_ANTIFLOOD # flood detection from same IP and traffic ban for a while # be sure you exclude checking trusted peers, such as pstn gateways # - local host excluded (e.g., loop to self) if(src_ip!=myself) { if($sht(ipban=>$si)!=$null) { # ip is already blocked xdbg("request from blocked IP - $rm from $fu (IP:$si:$sp)\n"); exit; } if (!pike_check_req()) { xlog("L_ALERT","ALERT: pike blocking $rm from $fu (IP:$si:$sp)\n"); $sht(ipban=>$si) = 1; exit; } } #!endif if($ua =~ "friendly|scanner|sipcli|sipvicious|VaxSIPUserAgent") { # silent drop for scanners - uncomment next line if want to reply # sl_send_reply("200", "OK"); exit; } if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } if(is_method("OPTIONS") && uri==myself && $rU==$null) { sl_send_reply("200","Keepalive"); exit; } if(!sanity_check("17895", "7")) { xlog("Malformed SIP request from $si:$sp\n"); exit; } } # Handle requests within SIP dialogs route[WITHINDLG] { if (!has_totag()) return; # sequential request withing a dialog should # take the path determined by record-routing if (loose_route()) { route(DLGURI); if (is_method("BYE")) { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } else if ( is_method("ACK") ) { # ACK is forwarded statelessly route(NATMANAGE); } else if ( is_method("NOTIFY") ) { # Add Record-Route for in-dialog NOTIFY as per RFC 6665. record_route(); } route(RELAY); exit; } if (is_method("SUBSCRIBE") && uri == myself) { # in-dialog subscribe requests route(PRESENCE); exit; } if ( is_method("ACK") ) { if ( t_check_trans() ) { # no loose-route, but stateful ACK; # must be an ACK after a 487 # or e.g. 404 from upstream server route(RELAY); exit; } else { # ACK without matching transaction ... ignore and discard exit; } } sl_send_reply("404","Not here"); exit; } # Handle SIP registrations route[REGISTRAR] { if (!is_method("REGISTER")) return; if(isflagset(FLT_NATS)) { setbflag(FLB_NATB); #!ifdef WITH_NATSIPPING # do SIP NAT pinging setbflag(FLB_NATSIPPING); #!endif } if (!save("location")) { sl_reply_error(); } exit; } # User location service route[LOCATION] { #!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") { if(sd_lookup("speed_dial")) { route(SIPOUT); } } #!endif #!ifdef WITH_ALIASDB # search in DB-based aliases if(alias_db_lookup("dbaliases")) { route(SIPOUT); } #!endif $avp(oexten) = $rU; if (!lookup("location")) { $var(rc) = $rc; route(TOVOICEMAIL); t_newtran(); switch ($var(rc)) { case -1: case -3: send_reply("404", "Not Found"); exit; case -2: send_reply("405", "Method Not Allowed"); exit; } } # when routing via usrloc, log the missed calls also if (is_method("INVITE")) { setflag(FLT_ACCMISSED); } route(RELAY); exit; } # Presence server processing route[PRESENCE] { if(!is_method("PUBLISH|SUBSCRIBE")) return; if(is_method("SUBSCRIBE") && $hdr(Event)=="message-summary") { route(TOVOICEMAIL); # returns here if no voicemail server is configured sl_send_reply("404", "No voicemail service"); exit; } #!ifdef WITH_PRESENCE #!ifdef WITH_MSGREBUILD # apply changes in case the request headers or body were modified msg_apply_changes(); #!endif if (!t_newtran()) { sl_reply_error(); exit; } if(is_method("PUBLISH")) { handle_publish(); t_release(); } else if(is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } exit; #!endif # if presence enabled, this part will not be executed if (is_method("PUBLISH") || $rU==$null) { sl_send_reply("404", "Not here"); exit; } return; } # IP authorization and user authentication route[AUTH] { #!ifdef WITH_AUTH #!ifdef WITH_IPAUTH if((!is_method("REGISTER")) && allow_source_address()) { # source IP allowed return; } #!endif if (is_method("REGISTER") || from_uri==myself) { # authenticate requests if (!auth_check("$fd", "subscriber", "1")) { auth_challenge("$fd", "0"); exit; } # user authenticated - remove auth header if(!is_method("REGISTER|PUBLISH")) consume_credentials(); } # if caller is not local subscriber, then check if it calls # a local destination, otherwise deny, not an open relay here if (from_uri!=myself && uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!else # authentication not enabled - do not relay at all to foreign networks if(uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!endif return; } # Caller NAT detection route[NATDETECT] { #!ifdef WITH_NAT if (nat_uac_test("19")) { if (is_method("REGISTER")) { fix_nated_register(); } else { if(is_first_hop()) { set_contact_alias(); } } setflag(FLT_NATS); } #!endif return; } # RTPProxy control and signaling updates for NAT traversal route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { if(has_totag()) { if(check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) return; #!ifdef WITH_RTPENGINE if(nat_uac_test("8")) { rtpengine_manage("replace-origin replace-session-connection"); } else { rtpengine_manage("trust-address replace-origin replace-session-connection"); } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; } # URI update for dialog requests route[DLGURI] { #!ifdef WITH_NAT if(!isdsturiset()) { handle_ruri_alias(); } #!endif return; } # Routing to foreign domains route[SIPOUT] { if (uri==myself) return; append_hf("P-Hint: outbound\r\n"); route(RELAY); exit; } # PSTN GW routing route[PSTN] { #!ifdef WITH_PSTN # check if PSTN GW IP is defined if (strempty($sel(cfg_get.pstn.gw_ip))) { xlog("SCRIPT: PSTN routing enabled but pstn.gw_ip not defined\n"); return; } # route to PSTN dialed numbers starting with '+' or '00' # (international format) # - update the condition to match your dialing rules for PSTN routing if(!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) return; # only local users allowed to call if(from_uri!=myself) { sl_send_reply("403", "Not Allowed"); exit; } # normalize target number for pstn gateway # - convert leading 00 to + if (starts_with("$rU", "00")) { strip(2); prefix("+"); } if (strempty($sel(cfg_get.pstn.gw_port))) { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip); } else { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip) + ":" + $sel(cfg_get.pstn.gw_port); } route(RELAY); exit; #!endif return; } # JSONRPC over HTTP(S) routing #!ifdef WITH_JSONRPC event_route[xhttp:request] { set_reply_close(); set_reply_no_connect(); if(src_ip!=127.0.0.1) { xhttp_reply("403", "Forbidden", "text/html", "<html><body>Not allowed from $si</body></html>"); exit; } if ($hu =~ "^/RPC") { jsonrpc_dispatch(); exit; } xhttp_reply("200", "OK", "text/html", "<html><body>Wrong URL $hu</body></html>"); exit; } #!endif # Routing to voicemail server route[TOVOICEMAIL] { #!ifdef WITH_VOICEMAIL if(!is_method("INVITE|SUBSCRIBE")) return; # check if VoiceMail server IP is defined if (strempty($sel(cfg_get.voicemail.srv_ip))) { xlog("SCRIPT: VoiceMail routing enabled but IP not defined\n"); return; } if(is_method("INVITE")) { if($avp(oexten)==$null) return; $ru = "sip:" + $avp(oexten) + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } else { if($rU==$null) return; $ru = "sip:" + $rU + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } route(RELAY); exit; #!endif return; } # Manage outgoing branches branch_route[MANAGE_BRANCH] { xdbg("new branch [$T_branch_idx] to $ru\n"); route(NATMANAGE); } # Manage incoming replies reply_route { if(!sanity_check("17604", "6")) { xlog("Malformed SIP response from $si:$sp\n"); drop; } } # Manage incoming replies in transaction context onreply_route[MANAGE_REPLY] { xdbg("incoming reply\n"); if(status=~"[12][0-9][0-9]") { route(NATMANAGE); } } # Manage failure routing cases failure_route[MANAGE_FAILURE] { route(NATMANAGE); if (t_is_canceled()) exit; #!ifdef WITH_BLOCK3XX # block call redirect based on 3xx replies. if (t_check_status("3[0-9][0-9]")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_BLOCK401407 # block call redirect based on 401, 407 replies. if (t_check_status("401|407")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_VOICEMAIL # serial forking # - route to voicemail on busy or no answer (timeout) if (t_check_status("486|408")) { $du = $null; route(TOVOICEMAIL); exit; } #!endif } ``` As you can see I just one thing in `request_route` ``` request_route { # per request initial checks # route(REQINIT); # NAT detection #route(NATDETECT); # CANCEL processing if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } exit; } # handle retransmissions if (!is_method("ACK")) { if(t_precheck_trans()) { t_check_trans(); exit; } t_check_trans(); } if (is_method("REGISTER")) { xdbg("request from gggggggggggggggggggggggggggggggggggggggggg - $rm from $fu (IP:$si:$sp)\n"); } rewritehostport("172.28.69.52:5060"); ``` The `172.28.69.52` is ip of my Freeswitch After I try to call from Zoiper5, I get below error in Kamailio log and Zoiper does not work. ``` 4(10) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 4(10) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) ``` ### Troubleshooting #### Reproduction * pull official Kamailio docker image `kamailio/kamailio 5.4.6-buster` * then run below command ``` docker run --net=host --name kamailio \ -v /home/ssoroosh/kamailio:/etc/kamailio \ kamailio/kamailio:5.4.6-buster ``` #### Debugging Data I do not have any debug data #### Log Messages ``` Listening on udp: 172.28.72.99 [172.28.72.99]:5060 advertise 172.28.72.99:5060 Aliases: 0(1) INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded 0(1) INFO: rr [rr_mod.c:185]: mod_init(): outbound module not available 0(1) INFO: <core> [main.c:2919]: main(): processes (at least): 16 - shm size: 67108864 - pkg size: 8388608 0(1) INFO: <core> [core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 212992 0(1) INFO: <core> [core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984 13(19) INFO: jsonrpcs [jsonrpcs_sock.c:443]: jsonrpc_dgram_process(): a new child 0/19 15(21) INFO: ctl [io_listener.c:210]: io_listen_loop(): io_listen_loop: using epoll_lt as the io watch method (auto detected) 2(8) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 2(8) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 2(8) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<�> 2(8) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 4(10) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 4(10) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 4(10) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 4(10) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 1(7) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 1(7) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 1(7) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 1(7) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 3(9) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 3(9) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 3(9) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 3(9) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 5(11) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 5(11) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 5(11) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 5(11) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 8(14) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 8(14) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 8(14) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 8(14) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 1(7) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 1(7) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 1(7) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 1(7) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 5(11) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 5(11) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 5(11) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 5(11) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 4(10) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 4(10) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 4(10) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 4(10) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 5(11) INFO: <core> [core/parser/parse_fline.c:156]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 5(11) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 0) 5(11) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 5(11) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 6(12) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 6(12) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<�> 6(12) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 7(13) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 7(13) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 7(13) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 8(14) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 8(14) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 8(14) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 2(8) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 2(8) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 2(8) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 4(10) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 4(10) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 4(10) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 1(7) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 1(7) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 1(7) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 3(9) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 3(9) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 3(9) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 5(11) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 5(11) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 5(11) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 6(12) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 6(12) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 6(12) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) 7(13) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 41) 7(13) ERROR: <core> [core/parser/msg_parser.c:681]: parse_msg(): ERROR: parse_msg: message=<��> 7(13) ERROR: <core> [core/receive.c:310]: receive_msg(): core parsing of SIP message failed (172.28.64.1:51370/1) ``` #### SIP Traffic My pcap is attached [sip.zip](https://github.com/kamailio/kamailio/files/8326814/sip.zip) ### Possible Solutions I have not any solution yet. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**: ``` Linux master 5.4.0-104-generic #118-Ubuntu SMP Wed Mar 2 19:02:41 UTC 2022 x86_64 GNU/Linux root@master:/home# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3062 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3062(a)github.com>

2 3

[kamailio/kamailio] siptrace: fix pkg memory leak when module configured with core callbacks (PR #3059)
by Dennis 22 Mar '22

22 Mar '22

- Correctly freeng pkg memory in core callbacks when body modifications take place with X-Siptrace headers, also fix potential pkg_free with not dynamicaly allocated objects.  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Releated to [57b1d5375927b987b162fcf0e2c99a39b717bd65](https://github.com/kamailio/kamai… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3059 -- Commit Summary -- * siptrace: fix pkg memory leak when module configured with core callbacks -- File Changes -- M src/modules/siptrace/siptrace.c (38) M src/modules/siptrace/siptrace_data.h (2) M src/modules/siptrace/siptrace_send.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3059.patch https://github.com/kamailio/kamailio/pull/3059.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3059 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3059(a)github.com>

2 1

git:master:fc50ce1d: siptrace: fix pkg memory leak when module configured with core callbacks
by Daniel-Constantin Mierla 22 Mar '22

22 Mar '22

Module: kamailio Branch: master Commit: fc50ce1dbd31bbd28a11d672ed9bdbe9bd4ae5d0 URL: https://github.com/kamailio/kamailio/commit/fc50ce1dbd31bbd28a11d672ed9bdbe… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-22T08:24:47+01:00 siptrace: fix pkg memory leak when module configured with core callbacks - Correctly freeng pkg memory in core callbacks when body modifications take place with X-Siptrace headers, also fix potential pkg_free with not dynamicaly allocated objects. --- Modified: src/modules/siptrace/siptrace.c Modified: src/modules/siptrace/siptrace_data.h Modified: src/modules/siptrace/siptrace_send.c --- Diff: https://github.com/kamailio/kamailio/commit/fc50ce1dbd31bbd28a11d672ed9bdbe… Patch: https://github.com/kamailio/kamailio/commit/fc50ce1dbd31bbd28a11d672ed9bdbe…

1 0

[kamailio/kamailio] Update uac_admin.xml (PR #3056)
by genajan 22 Mar '22

22 Mar '22

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3056 -- Commit Summary -- * Update uac_admin.xml -- File Changes -- M src/modules/uac/doc/uac_admin.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3056.patch https://github.com/kamailio/kamailio/pull/3056.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3056 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3056(a)github.com>

2 3

git:master:51dcda9a: modules: readme files regenerated - uac ... [skip ci]
by Kamailio Dev 22 Mar '22

22 Mar '22

Module: kamailio Branch: master Commit: 51dcda9aab961aa86c77c7e0a99bc91aee860d52 URL: https://github.com/kamailio/kamailio/commit/51dcda9aab961aa86c77c7e0a99bc91… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-22T08:16:22+01:00 modules: readme files regenerated - uac ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/51dcda9aab961aa86c77c7e0a99bc91… Patch: https://github.com/kamailio/kamailio/commit/51dcda9aab961aa86c77c7e0a99bc91… --- diff --git a/src/modules/uac/README b/src/modules/uac/README index 3c804906dd..f1a6e6f5e8 100644 --- a/src/modules/uac/README +++ b/src/modules/uac/README @@ -595,7 +595,7 @@ modparam("uac", "reg_active", 0) Timer interval (in seconds) at which remote registrations are cleaned up in case of failure or removed. When setting it take in consideration the maximum value for retransmission timeout, this param should be - greater than it. This value also impacts how ofter the reload for + greater than it. This value also impacts how often the reload for remote registrations table can be executed -- the RPC command will fail if executed in less than reg_gc_interval value since the last reload.

1 0

git:master:faefa6cc: uac: docs - fixed typo
by Daniel-Constantin Mierla 22 Mar '22

22 Mar '22

Module: kamailio Branch: master Commit: faefa6ccc3ce9a774ca977aa35b8da07b46daf02 URL: https://github.com/kamailio/kamailio/commit/faefa6ccc3ce9a774ca977aa35b8da0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-22T08:11:38+01:00 uac: docs - fixed typo - GH #3056 --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/faefa6ccc3ce9a774ca977aa35b8da0… Patch: https://github.com/kamailio/kamailio/commit/faefa6ccc3ce9a774ca977aa35b8da0… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 3ce59d3e11..a15fbbc90b 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -567,7 +567,7 @@ modparam("uac", "reg_active", 0) Timer interval (in seconds) at which remote registrations are cleaned up in case of failure or removed. When setting it take in consideration the maximum value for retransmission timeout, this param should be greater - than it. This value also impacts how ofter the reload for remote + than it. This value also impacts how often the reload for remote registrations table can be executed -- the RPC command will fail if executed in less than reg_gc_interval value since the last reload. </para>

1 0

[kamailio/kamailio] utils: fixed sinitiser error (PR #3057)
by sergey-safarov 22 Mar '22

22 Mar '22

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description fixed sinitizer memory leaks You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3057 -- Commit Summary -- * utils: fixed sinitiser error -- File Changes -- M utils/kamcmd/kamcmd.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3057.patch https://github.com/kamailio/kamailio/pull/3057.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3057 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3057(a)github.com>

2 1

git:master:d28ca884: utils: fixed sinitiser error
by Daniel-Constantin Mierla 22 Mar '22

22 Mar '22

Module: kamailio Branch: master Commit: d28ca884548b0f24a618ed9cbdc8e1b9538f2574 URL: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-22T08:09:12+01:00 utils: fixed sinitiser error [root@localhost]# kamcmd cfg.seti param_group param_name value ================================================================= ==2409977==ERROR: LeakSanitizer: detected memory leaks Direct leak of 38 byte(s) in 1 object(s) allocated from: #0 0xffff98c250af in malloc (/lib64/libasan.so.5+0xd50af) #1 0x41549f in parse_listen_id /root/kamailio/utils/kamcmd/parse_listen_id.c:133 #2 0x4144fb in main /root/kamailio/utils/kamcmd/kamcmd.c:2075 #3 0xffff97dc0de3 in __libc_start_main (/lib64/libc.so.6+0x20de3) #4 0x40260b (/usr/local/sbin/kamcmd+0x40260b) --- Modified: utils/kamcmd/kamcmd.c --- Diff: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… Patch: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… --- diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c index 141f309aaf..e940ab8ae1 100644 --- a/utils/kamcmd/kamcmd.c +++ b/utils/kamcmd/kamcmd.c @@ -2106,6 +2106,7 @@ int main(int argc, char** argv) fprintf(stderr, "ERROR: Bad socket type for %s\n", sock_name); goto error; } + free(sock_id->buf); /* not needed anymore */ free(sock_id); /* not needed anymore */ sock_id=0;

1 0

[kamailio/kamailio] {param.value, name[, delimiter]}, and delimiter is comma (Issue #3060)
by hance2010 22 Mar '22

22 Mar '22

### Description  ### Expected behavior $var(s) = "a=1,b=2,c=3"; $var(s1) = $(var(s){param.value,b,,}); /* 2 */ #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.5.4 ``` * **Operating System**:  ``` debian11 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3060 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3060(a)github.com>

2 2

git:master:16a5234b: modules: readme files regenerated - auth_db ... [skip ci]
by Kamailio Dev 21 Mar '22

21 Mar '22

Module: kamailio Branch: master Commit: 16a5234b11f139ec6b2be99499c970234dec90c3 URL: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-21T15:16:26+01:00 modules: readme files regenerated - auth_db ... [skip ci] --- Modified: src/modules/auth_db/README --- Diff: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… Patch: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… --- diff --git a/src/modules/auth_db/README b/src/modules/auth_db/README index 287f1517c5..2825c58d2f 100644 --- a/src/modules/auth_db/README +++ b/src/modules/auth_db/README @@ -448,7 +448,8 @@ if (!proxy_authorize("$fd", "subscriber)) { user. All other requests: From header must match the authentication user. If bit 2 is set as well (flags==3), the ID check is skipped for INVITE, BYE, PRACK, UPDATE, MESSAGE - these requests can come - with anonymous caller id. + with anonymous caller id. If set to 0, then all user checks are + skipped. Additionally all domains in the checked URIs and the realm in the authentication header will be checked to match the provided realm parameter.

1 0

git:master:c67c568a: auth_db: document flag 0 for auth_check function
by Henning Westerholt 21 Mar '22

21 Mar '22

Module: kamailio Branch: master Commit: c67c568ad476879529cd04f7a5b1b77401a8f428 URL: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-03-21T14:11:32Z auth_db: document flag 0 for auth_check function --- Modified: src/modules/auth_db/doc/auth_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… Patch: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… --- diff --git a/src/modules/auth_db/doc/auth_db_admin.xml b/src/modules/auth_db/doc/auth_db_admin.xml index 422738e869..e112332b40 100644 --- a/src/modules/auth_db/doc/auth_db_admin.xml +++ b/src/modules/auth_db/doc/auth_db_admin.xml @@ -549,7 +549,8 @@ if (!proxy_authorize("$fd", "subscriber)) { match the authentication user. All other requests: From header must match the authentication user. If bit 2 is set as well (flags==3), the ID check is skipped for INVITE, BYE, PRACK, UPDATE, MESSAGE - - these requests can come with anonymous caller id. + - these requests can come with anonymous caller id. If set to 0, + then all user checks are skipped. </para> <para> Additionally all domains in the checked URIs and the realm in the

1 0

git:master:0b7a7107: ims_qos: free result of getaddrinfo()
by Daniel-Constantin Mierla 17 Mar '22

17 Mar '22

Module: kamailio Branch: master Commit: 0b7a71070f3845e4c7e89e149a80b3db8872bb1e URL: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-17T09:34:56+01:00 ims_qos: free result of getaddrinfo() --- Modified: src/modules/ims_qos/ims_qos_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… Patch: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index 18d111eb67..08018d9c45 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -649,10 +649,13 @@ uint16_t check_ip_version(str ip) return 0; } if (res->ai_family == AF_INET) { + freeaddrinfo(res); return AF_INET; } else if (res->ai_family == AF_INET6) { + freeaddrinfo(res); return AF_INET6; } else { + freeaddrinfo(res); LM_ERR("unknown IP format \n"); return 0; }

1 0

git:master:782b4773: cdp: init the entire msg structure
by Daniel-Constantin Mierla 17 Mar '22

17 Mar '22

Module: kamailio Branch: master Commit: 782b4773119e21a9354d698c0f405d7162166a4a URL: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-17T09:00:36+01:00 cdp: init the entire msg structure --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… Patch: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index 5aed0a36f4..0bff4131d3 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -346,6 +346,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) char control[CMSG_SPACE(sizeof(new_fd))]; }control_un; + memset(&msg, 0, sizeof(struct msghdr)); msg.msg_control=control_un.control; msg.msg_controllen=sizeof(control_un.control); #else

1 0

git:master:b32a9caf: core: parse uri - extra check when user part is missing before @
by Daniel-Constantin Mierla 16 Mar '22

16 Mar '22

Module: kamailio Branch: master Commit: b32a9caf4797370a4704b5f94d2d704b6e52fdef URL: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T10:11:43+01:00 core: parse uri - extra check when user part is missing before @ --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… Patch: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index edc46acea1..adc94fbc0a 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1241,14 +1241,15 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) /* port value too large */ goto error_invalid_port; } - if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@' - && uri->user.len<=0) { + if(uri->host.len>0 && uri->user.len<=0 &&uri->host.s>buf && (*(uri->host.s-1)=='@' + || *uri->host.s=='@')) { /* '@' before host, but no user part */ goto error_bad_uri; } #ifdef EXTRA_DEBUG /* do stuff */ + LM_DBG("state=%d\n", state); LM_DBG("parsed uri:\n type=%d user=<%.*s>(%d)\n passwd=<%.*s>(%d)\n" " host=<%.*s>(%d)\n port=<%.*s>(%d): %d\n params=<%.*s>(%d)\n" " headers=<%.*s>(%d)\n",

1 0

git:master:dad44317: db_berkeley: covert blob values
by Daniel-Constantin Mierla 16 Mar '22

16 Mar '22

Module: kamailio Branch: master Commit: dad443172628c3736b057fa24343c265ed3827b2 URL: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T09:12:03+01:00 db_berkeley: covert blob values --- Modified: src/modules/db_berkeley/km_bdb_val.c --- Diff: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… Patch: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… --- diff --git a/src/modules/db_berkeley/km_bdb_val.c b/src/modules/db_berkeley/km_bdb_val.c index d895a870c9..e75ad4dc3b 100644 --- a/src/modules/db_berkeley/km_bdb_val.c +++ b/src/modules/db_berkeley/km_bdb_val.c @@ -266,10 +266,10 @@ int km_bdb_val2str(db_val_t *_v, char *_s, int *_len) LM_ERR("Destination buffer too short for blob\n"); return -7; } else { - LM_DBG("Converting BLOB [%s]\n", _s); - _s = VAL_BLOB(_v).s; - *_len = 0; - return -8; + LM_DBG("Converted BLOB\n"); + memcpy(_s, VAL_BLOB(_v).s, l); + *_len = l; + return 0; } break;

1 0

git:master:b8c4d8b8: db_redis: init allocated structure
by Daniel-Constantin Mierla 16 Mar '22

16 Mar '22

Module: kamailio Branch: master Commit: b8c4d8b8d0f06267f2bc1a760307345fd06745ce URL: https://github.com/kamailio/kamailio/commit/b8c4d8b8d0f06267f2bc1a760307345… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T09:00:35+01:00 db_redis: init allocated structure --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/b8c4d8b8d0f06267f2bc1a760307345… Patch: https://github.com/kamailio/kamailio/commit/b8c4d8b8d0f06267f2bc1a760307345… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index dc0dc2136f..68536816a8 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -1783,7 +1783,7 @@ static int db_redis_perform_delete(const db1_con_t* _h, km_redis_con_t *con, con db_keys[j] = &tmp->key; } - db_vals = (db_val_t*) pkg_malloc(all_type_keys_count * sizeof(db_val_t)); + db_vals = (db_val_t*) pkg_mallocxz(all_type_keys_count * sizeof(db_val_t)); if (!db_vals) { LM_ERR("Failed to allocate memory for manual db vals\n"); goto error;

1 0

git:master:476d763d: core: 0-terminate string for very long local network interface names
by Daniel-Constantin Mierla 16 Mar '22

16 Mar '22

Module: kamailio Branch: master Commit: 476d763d8ee504b71c13063ca002ecfe158da94e URL: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T09:04:33+01:00 core: 0-terminate string for very long local network interface names --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… Patch: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index afb1dd5603..00d7bdf289 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1333,6 +1333,7 @@ static int build_iface_list(void) case IFA_LABEL: LM_DBG("iface name is %s\n", (char*)RTA_DATA(rtap)); strncpy(name, (char*)RTA_DATA(rtap), MAX_IF_LEN-1); + name[MAX_IF_LEN-1] = '\0'; break; case IFA_BROADCAST: case IFA_ANYCAST:

1 0

git:master:b7fa610c: core: resolve - use macro value for comparison
by Daniel-Constantin Mierla 16 Mar '22

16 Mar '22

Module: kamailio Branch: master Commit: b7fa610ca381dff572d0276fabe7101acdc3ced1 URL: https://github.com/kamailio/kamailio/commit/b7fa610ca381dff572d0276fabe7101… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T08:35:24+01:00 core: resolve - use macro value for comparison --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/b7fa610ca381dff572d0276fabe7101… Patch: https://github.com/kamailio/kamailio/commit/b7fa610ca381dff572d0276fabe7101… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index c2ea36d9ec..336b958ea3 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -841,7 +841,7 @@ struct rdata* get_record(char* name, int type, int flags) #endif p+=skip; rec_name_len=strlen(rec_name); - if (unlikely(rec_name_len>255)){ + if (unlikely(rec_name_len>MAX_DNS_NAME-2)){ LM_ERR("dn_expand(rec_name): name too long (%d)\n", rec_name_len); goto error;

1 0

git:5.3:879be1b8: db_text: fix db url in example config
by Ovidiu Sas 15 Mar '22

15 Mar '22

Module: kamailio Branch: 5.3 Commit: 879be1b8996bc1f4768ef7b54631a17caa14d0a1 URL: https://github.com/kamailio/kamailio/commit/879be1b8996bc1f4768ef7b54631a17… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2022-03-15T12:14:05-04:00 db_text: fix db url in example config (cherry picked from commit b98cbddfaf271887276c4be8a98a0708dab4d091) --- Modified: src/modules/db_text/doc/db_text.cfg --- Diff: https://github.com/kamailio/kamailio/commit/879be1b8996bc1f4768ef7b54631a17… Patch: https://github.com/kamailio/kamailio/commit/879be1b8996bc1f4768ef7b54631a17… --- diff --git a/src/modules/db_text/doc/db_text.cfg b/src/modules/db_text/doc/db_text.cfg index 8c94d7c56a..de2202f9fc 100644 --- a/src/modules/db_text/doc/db_text.cfg +++ b/src/modules/db_text/doc/db_text.cfg @@ -41,7 +41,7 @@ loadmodule "modules/auth_db/auth_db.so" # use dbtext database for persistent storage modparam("usrloc", "db_mode", 2) -modparam("usrloc|auth_db", "db_url", "db_text:///tmp/kamailiodb") +modparam("usrloc|auth_db", "db_url", "text:///tmp/kamailiodb") # -- auth params -- #

1 0

git:5.4:053b3db1: db_text: fix db url in example config
by Ovidiu Sas 15 Mar '22

15 Mar '22

Module: kamailio Branch: 5.4 Commit: 053b3db11a89d0bbb86ca95f9fd9b242cfb68f78 URL: https://github.com/kamailio/kamailio/commit/053b3db11a89d0bbb86ca95f9fd9b24… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2022-03-15T12:13:25-04:00 db_text: fix db url in example config (cherry picked from commit b98cbddfaf271887276c4be8a98a0708dab4d091) --- Modified: src/modules/db_text/doc/db_text.cfg --- Diff: https://github.com/kamailio/kamailio/commit/053b3db11a89d0bbb86ca95f9fd9b24… Patch: https://github.com/kamailio/kamailio/commit/053b3db11a89d0bbb86ca95f9fd9b24… --- diff --git a/src/modules/db_text/doc/db_text.cfg b/src/modules/db_text/doc/db_text.cfg index 8c94d7c56a..de2202f9fc 100644 --- a/src/modules/db_text/doc/db_text.cfg +++ b/src/modules/db_text/doc/db_text.cfg @@ -41,7 +41,7 @@ loadmodule "modules/auth_db/auth_db.so" # use dbtext database for persistent storage modparam("usrloc", "db_mode", 2) -modparam("usrloc|auth_db", "db_url", "db_text:///tmp/kamailiodb") +modparam("usrloc|auth_db", "db_url", "text:///tmp/kamailiodb") # -- auth params -- #

1 0

git:5.5:4c893825: db_text: fix db url in example config
by Ovidiu Sas 15 Mar '22

15 Mar '22

Module: kamailio Branch: 5.5 Commit: 4c8938252d583bcfe720231e9f579ee461095c6d URL: https://github.com/kamailio/kamailio/commit/4c8938252d583bcfe720231e9f579ee… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2022-03-15T12:12:44-04:00 db_text: fix db url in example config (cherry picked from commit b98cbddfaf271887276c4be8a98a0708dab4d091) --- Modified: src/modules/db_text/doc/db_text.cfg --- Diff: https://github.com/kamailio/kamailio/commit/4c8938252d583bcfe720231e9f579ee… Patch: https://github.com/kamailio/kamailio/commit/4c8938252d583bcfe720231e9f579ee… --- diff --git a/src/modules/db_text/doc/db_text.cfg b/src/modules/db_text/doc/db_text.cfg index 8c94d7c56a..de2202f9fc 100644 --- a/src/modules/db_text/doc/db_text.cfg +++ b/src/modules/db_text/doc/db_text.cfg @@ -41,7 +41,7 @@ loadmodule "modules/auth_db/auth_db.so" # use dbtext database for persistent storage modparam("usrloc", "db_mode", 2) -modparam("usrloc|auth_db", "db_url", "db_text:///tmp/kamailiodb") +modparam("usrloc|auth_db", "db_url", "text:///tmp/kamailiodb") # -- auth params -- #

1 0

git:master:b98cbddf: db_text: fix db url in example config
by Ovidiu Sas 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: b98cbddfaf271887276c4be8a98a0708dab4d091 URL: https://github.com/kamailio/kamailio/commit/b98cbddfaf271887276c4be8a98a070… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2022-03-15T12:09:15-04:00 db_text: fix db url in example config --- Modified: src/modules/db_text/doc/db_text.cfg --- Diff: https://github.com/kamailio/kamailio/commit/b98cbddfaf271887276c4be8a98a070… Patch: https://github.com/kamailio/kamailio/commit/b98cbddfaf271887276c4be8a98a070… --- diff --git a/src/modules/db_text/doc/db_text.cfg b/src/modules/db_text/doc/db_text.cfg index 8c94d7c56a..de2202f9fc 100644 --- a/src/modules/db_text/doc/db_text.cfg +++ b/src/modules/db_text/doc/db_text.cfg @@ -41,7 +41,7 @@ loadmodule "modules/auth_db/auth_db.so" # use dbtext database for persistent storage modparam("usrloc", "db_mode", 2) -modparam("usrloc|auth_db", "db_url", "db_text:///tmp/kamailiodb") +modparam("usrloc|auth_db", "db_url", "text:///tmp/kamailiodb") # -- auth params -- #

1 0

git:master:d4af1304: db_text: reworked the checks for database and table names
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: d4af1304778c10213cb1f98e23938c6c4b912723 URL: https://github.com/kamailio/kamailio/commit/d4af1304778c10213cb1f98e23938c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T13:01:10+01:00 db_text: reworked the checks for database and table names --- Modified: src/modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/d4af1304778c10213cb1f98e23938c6… Patch: https://github.com/kamailio/kamailio/commit/d4af1304778c10213cb1f98e23938c6… --- diff --git a/src/modules/db_text/dbt_file.c b/src/modules/db_text/dbt_file.c index 6480210ebc..ec74c298bd 100644 --- a/src/modules/db_text/dbt_file.c +++ b/src/modules/db_text/dbt_file.c @@ -94,28 +94,22 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) enum {DBT_FLINE_ST, DBT_NLINE_ST, DBT_DATA_ST} state; - if(!tbn || !tbn->s || tbn->len<=0 || tbn->len>=255) + if(!tbn || !tbn->s || tbn->len<=0 || tbn->len>=255) { + LM_ERR("invalid table name\n"); return NULL; + } + if(!dbn || !dbn->s || dbn->len<=0 || dbn->len>=255) { + LM_ERR("invalid database name\n"); + return NULL; + } LM_DBG("request for table [%.*s] (len: %d)\n", tbn->len, tbn->s, tbn->len); + LM_DBG("database is [%.*s] (len: %d)\n", dbn->len, dbn->s, dbn->len); - path[0] = 0; - if(dbn && dbn->s && dbn->len>0) - { - LM_DBG("db is [%.*s] (len: %d)\n", dbn->len, dbn->s, dbn->len); - if(dbn->len+tbn->len<511) - { - strncpy(path, dbn->s, dbn->len); - path[dbn->len] = '/'; - strncpy(path+dbn->len+1, tbn->s, tbn->len); - path[dbn->len+tbn->len+1] = 0; - } - } - if(path[0] == 0) - { - strncpy(path, tbn->s, tbn->len); - path[tbn->len] = 0; - } + strncpy(path, dbn->s, dbn->len); + path[dbn->len] = '/'; + strncpy(path+dbn->len+1, tbn->s, tbn->len); + path[dbn->len+tbn->len+1] = 0; LM_DBG("loading file [%s]\n", path); fin = fopen(path, "rt");

1 0

git:master:e513d1cc: seas: check for header type value for flags comparison
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: e513d1cc549fea43eebc5fc504bb01270adbc10e URL: https://github.com/kamailio/kamailio/commit/e513d1cc549fea43eebc5fc504bb012… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:41:59+01:00 seas: check for header type value for flags comparison --- Modified: src/modules/seas/seas_action.c --- Diff: https://github.com/kamailio/kamailio/commit/e513d1cc549fea43eebc5fc504bb012… Patch: https://github.com/kamailio/kamailio/commit/e513d1cc549fea43eebc5fc504bb012… --- diff --git a/src/modules/seas/seas_action.c b/src/modules/seas/seas_action.c index 83be6307d0..de8fc9be65 100644 --- a/src/modules/seas/seas_action.c +++ b/src/modules/seas/seas_action.c @@ -1278,7 +1278,7 @@ int extract_allowed_headers(struct sip_msg *my_msg,int strip_top_vias,int allow_ vb=NULL; for(hf=my_msg->headers;hf;hf=hf->next){ - if(forbidden_hdrs & HDR_T2F(hf->type)){ + if((hf->type>0) && (forbidden_hdrs & HDR_T2F(hf->type))){ LM_DBG("Skipping header (%.*s)\n",hf->name.len,hf->name.s); continue; }else if(hf->type==HDR_VIA_T && strip_top_vias > 0){

1 0

git:master:67e0fa5e: core: parser digest - warn if the header type is not set properly
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 67e0fa5e53ef5d4dd9802e3027b2bc7ff6dcb671 URL: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:30:58+01:00 core: parser digest - warn if the header type is not set properly --- Modified: src/core/parser/digest/digest.c --- Diff: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… Patch: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… --- diff --git a/src/core/parser/digest/digest.c b/src/core/parser/digest/digest.c index ccc62a6551..83cce621f0 100644 --- a/src/core/parser/digest/digest.c +++ b/src/core/parser/digest/digest.c @@ -259,8 +259,9 @@ int find_credentials(struct sip_msg* msg, str* realm, hdr_flags=HDR_PROXYAUTH_F; break; default: + LM_WARN("unexpected header type %d - using authorization\n", hftype); hook = &(msg->authorization); - hdr_flags=HDR_T2F(hftype); + hdr_flags=HDR_AUTHORIZATION_F; break; }

1 0

git:master:f9a38d6b: core: parser - catch special header types for get_hdr()
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: f9a38d6b621a2c3966a3c85dce6fdd2e6bb8d431 URL: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:35:12+01:00 core: parser - catch special header types for get_hdr() --- Modified: src/core/parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… Patch: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… --- diff --git a/src/core/parser/msg_parser.c b/src/core/parser/msg_parser.c index a348503544..6455c9e539 100644 --- a/src/core/parser/msg_parser.c +++ b/src/core/parser/msg_parser.c @@ -1012,10 +1012,14 @@ hdr_field_t* get_hdr(const sip_msg_t* const msg, const enum _hdr_types_t ht) { hdr_field_t *hdr; - if (msg->parsed_flag & HDR_T2F(ht)) + if (ht == HDR_ERROR_T || ht == HDR_EOH_T) { + return NULL; + } + if (msg->parsed_flag & HDR_T2F(ht)) { for(hdr = msg->headers; hdr; hdr = hdr->next) { if(hdr->type == ht) return hdr; } + } return NULL; }

1 0

git:master:5c774d6e: ims_auth: warn if the header type is not set properly
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 5c774d6eced2ad52cb341b9e36419aac6c0506cb URL: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:38:42+01:00 ims_auth: warn if the header type is not set properly --- Modified: src/modules/ims_auth/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… Patch: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… --- diff --git a/src/modules/ims_auth/utils.c b/src/modules/ims_auth/utils.c index 94d02e3fe7..b745af0275 100644 --- a/src/modules/ims_auth/utils.c +++ b/src/modules/ims_auth/utils.c @@ -71,8 +71,9 @@ int ims_find_credentials(struct sip_msg* _m, str* _realm, hdr_flags = HDR_PROXYAUTH_F; break; default: + LM_WARN("unexpected header type %d - using authorization\n", _hftype); hook = &(_m->authorization); - hdr_flags = HDR_T2F(_hftype); + hdr_flags = HDR_AUTHORIZATION_F; break; }

1 0

git:master:8b20e604: core: parse - fix typo in comment of previous commit
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 8b20e6045dbebdb784a4e8f66d81fc79c0a17304 URL: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:18:23+01:00 core: parse - fix typo in comment of previous commit --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… Patch: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 8f7a53f77b..edc46acea1 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1238,7 +1238,7 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) /* common sanity checks */ if(uri->port.len>5) { - /* port value to large */ + /* port value too large */ goto error_invalid_port; } if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@'

1 0

git:master:eda4b3c5: core: parse uri - sanity check for user part
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: eda4b3c51ce12d4fe052b7e9ad40be1ef6e56444 URL: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:11:09+01:00 core: parse uri - sanity check for user part --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… Patch: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 6cbf22a7c7..8f7a53f77b 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1236,8 +1236,16 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) break; /* do nothing, avoids a compilation warning */ } - if(uri->port.len>5) + /* common sanity checks */ + if(uri->port.len>5) { + /* port value to large */ goto error_invalid_port; + } + if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@' + && uri->user.len<=0) { + /* '@' before host, but no user part */ + goto error_bad_uri; + } #ifdef EXTRA_DEBUG /* do stuff */

1 0

git:master:692d15ce: pua_reginfo: init uri buffer
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 692d15ce9bcc329fff55060dcdc8e5161f12c30e URL: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:00:41+01:00 pua_reginfo: init uri buffer --- Modified: src/modules/pua_reginfo/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… Patch: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… --- diff --git a/src/modules/pua_reginfo/notify.c b/src/modules/pua_reginfo/notify.c index ee533a6a63..07fceba899 100644 --- a/src/modules/pua_reginfo/notify.c +++ b/src/modules/pua_reginfo/notify.c @@ -239,6 +239,7 @@ int process_body(str notify_body, udomain_t * domain) { /* Temporary */ int mem_only = 1; + uri[0] = '\0'; doc = xmlParseMemory(notify_body.s, notify_body.len); if(doc== NULL) { LM_ERR("Error while parsing the xml body message, Body is:\n%.*s\n",

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev