Hello,
I am planning to release a new version from branch 5.4, respectively
5.4.8, sometime next week, likely on Wednesday or Thursday (Mar 9/10, 2022).
If anyone is aware of issues not yet reported to bug tracker or missing
backports, report them in order to try to get the fixes in this release.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
March 28-31, 2022 (Europe Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Enable UTC time format for expires and last_modified columns.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3036
-- Commit Summary --
* p_usrloc: add UTC_timestamps parameter
-- File Changes --
M src/modules/p_usrloc/doc/p_usrloc_admin.xml (22)
M src/modules/p_usrloc/p_usrloc_mod.c (18)
M src/modules/p_usrloc/p_usrloc_mod.h (4)
M src/modules/p_usrloc/ucontact.c (12)
M src/modules/p_usrloc/udomain.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3036.patchhttps://github.com/kamailio/kamailio/pull/3036.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3036
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3036(a)github.com>
…ecific_Application_Id
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
I've ran into issues when working with certain HSS's that sent more AVP's than were allocated.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3031
-- Commit Summary --
* cdp: increase the amount of avps allocated when reading AVP_Vendor_Specific_Application_Id
-- File Changes --
M src/modules/cdp/peerstatemachine.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3031.patchhttps://github.com/kamailio/kamailio/pull/3031.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3031
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3031(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
cplc: manage case where TZ environment variable is not set.
When TZ environment variable was not set, only the first time based CPL worked correctly.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3045
-- Commit Summary --
* cplc: manage case where TZ environment variable is not set.
-- File Changes --
M src/modules/cplc/cpl_switches.h (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3045.patchhttps://github.com/kamailio/kamailio/pull/3045.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3045
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3045(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x ] Commit message has the format required by CONTRIBUTING guide
- [x ] Commits are split per component (core, individual modules, libs, utils, ...)
- [x ] Each component has a single commit (if not, squash them into one commit)
- [x ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
topos_redis: contact on A side is never updated on dialog update
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3044
-- Commit Summary --
* topos_redis: contact on A side is never updated on dialog update
-- File Changes --
M src/modules/topos_redis/topos_redis_storage.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3044.patchhttps://github.com/kamailio/kamailio/pull/3044.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3044
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3044(a)github.com>
Module: kamailio
Branch: master
Commit: 415f20804e423b503d5e0d1743e28c9f509f9c21
URL: https://github.com/kamailio/kamailio/commit/415f20804e423b503d5e0d1743e28c9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-03-03T09:03:12+01:00
blst: docs - small formatting updates
---
Modified: src/modules/blst/doc/blst_functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/415f20804e423b503d5e0d1743e28c9…
Patch: https://github.com/kamailio/kamailio/commit/415f20804e423b503d5e0d1743e28c9…
---
diff --git a/src/modules/blst/doc/blst_functions.xml b/src/modules/blst/doc/blst_functions.xml
index 96b4b6c389..48e7d59b6e 100644
--- a/src/modules/blst/doc/blst_functions.xml
+++ b/src/modules/blst/doc/blst_functions.xml
@@ -38,15 +38,15 @@ else
</title>
<para>
Adds the source of the current message to the blocklist for
- the time interval specified in the <emphasis>Retry-After</emphasis>
+ the time interval specified in the <emphasis>Retry-After</emphasis>
header.
- If the <emphasis>Retry-After</emphasis> header is missing, it will
+ If the <emphasis>Retry-After</emphasis> header is missing, it will
fail (returns false).
- If the <emphasis>Retry-After</emphasis> value is less than
- <varname>min</varname>, then <varname>min</varname> seconds will be
+ If the <emphasis>Retry-After</emphasis> value is less than
+ <varname>min</varname>, then <varname>min</varname> seconds will be
used instead.
If the <emphasis>Retry-After</emphasis> value is greater than
- <varname>max</varname>, then <varname>max</varname> seconds will be
+ <varname>max</varname>, then <varname>max</varname> seconds will be
used instead.
</para>
<example>
@@ -117,7 +117,7 @@ if (msg_status==503){ # blocklist 503 source for Retry-After seconds
works for local replies to the current message.
</para>
<para>
- The variants of these functions with no parameters will ignore
+ The variants of these functions with no parameters will ignore
everything (equivalent to passing 0xff).
</para>
<para>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
```
apt install kamailio kamailio-*
find /usr/lib/x86_64-linux-gnu/kamailio/modules -name jwt.so
and nothing.
```
<!--
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio5.5.2
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
debian10
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2883
Module: kamailio
Branch: 5.5
Commit: 42b80a2cf0fa1b2e7192ade5844df670a49480ff
URL: https://github.com/kamailio/kamailio/commit/42b80a2cf0fa1b2e7192ade5844df67…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-03-02T10:15:05+01:00
core: fixed comment typo
(cherry picked from commit c37ccdc6e3bad0af4644941a872f510c51936c58)
---
Modified: src/core/sr_module.h
---
Diff: https://github.com/kamailio/kamailio/commit/42b80a2cf0fa1b2e7192ade5844df67…
Patch: https://github.com/kamailio/kamailio/commit/42b80a2cf0fa1b2e7192ade5844df67…
---
diff --git a/src/core/sr_module.h b/src/core/sr_module.h
index 99c1dc1de1..df47e18965 100644
--- a/src/core/sr_module.h
+++ b/src/core/sr_module.h
@@ -154,7 +154,7 @@ typedef int (*param_func_t)( modparam_t type, void* val);
@warning child_init(PROC_MAIN) is again called
in the same process (main), but latter
(before tcp), so make sure you don't init things
- twice, bot in PROC_MAIN and PROC_INT */
+ twice, both in PROC_MAIN and PROC_INT */
#define PROC_NOCHLDINIT -128 /**< no child init functions will be called
if this rank is used in fork_process() */
Module: kamailio
Branch: 5.5
Commit: b83292042aae87c445e05c3f82231ca6d335cc96
URL: https://github.com/kamailio/kamailio/commit/b83292042aae87c445e05c3f82231ca…
Author: James Van Vleet <james(a)vanvleet.net>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-03-02T10:14:11+01:00
Erlang: Revert breaking change
Revert https://github.com/kamailio/kamailio/commit/6542a367638ec5f8a2b62994f8c309e…
xavp_add_xavp_value returns the root and not the xavp it added and that was the reason for the code the commit removed. Changed a variable name to help make that more clear.
Also related to https://github.com/kamailio/kamailio/issues/2069.
(cherry picked from commit 1ed58f0de4f7a3ab3a81dd84c1c3b94fa1df2c4b)
---
Modified: src/modules/erlang/pv_xbuff.c
---
Diff: https://github.com/kamailio/kamailio/commit/b83292042aae87c445e05c3f82231ca…
Patch: https://github.com/kamailio/kamailio/commit/b83292042aae87c445e05c3f82231ca…
---
diff --git a/src/modules/erlang/pv_xbuff.c b/src/modules/erlang/pv_xbuff.c
index 894c36784c..b19a22ac8e 100644
--- a/src/modules/erlang/pv_xbuff.c
+++ b/src/modules/erlang/pv_xbuff.c
@@ -86,11 +86,15 @@ sr_xavp_t *xbuff_new(str *name)
if(!xbuffs_root)
{
- xbuff = xavp_add_xavp_value(&xbuff_list,name,&xbuff_val,xavp_get_crt_list());
- } else {
- xbuff = xavp_get_child(&xbuff_list, name);
+ xbuffs_root = xavp_add_xavp_value(&xbuff_list,name,&xbuff_val,xavp_get_crt_list());
+ if (!xbuffs_root){
+ LM_ERR("cannot create xbuffs_root \n");
+ return NULL;
+ }
}
+ xbuff = xavp_get_child(&xbuff_list, name);
+
if (!xbuff) {
xbuff_val.type = SR_XTYPE_NULL;
Module: kamailio
Branch: master
Commit: eee5068e2f315b6d391e6fe7b6aef4875afcf574
URL: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-03-02T08:39:26+01:00
jwt: add missing tag in doc
error instroduced at aaa142d293105ef27f7e4b6143fc3fb18c9a5a75
---
Modified: src/modules/jwt/doc/jwt_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48…
Patch: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48…
---
diff --git a/src/modules/jwt/doc/jwt_admin.xml b/src/modules/jwt/doc/jwt_admin.xml
index 45d98c7689..a72c518efe 100644
--- a/src/modules/jwt/doc/jwt_admin.xml
+++ b/src/modules/jwt/doc/jwt_admin.xml
@@ -115,6 +115,7 @@ modparam("jwt", "key_mode", 1)
added as string value.
</para>
</listitem>
+ <listitem>
<para>
headers - the list of headers to be added to JWT, in the format
"name1=value1;name2=value2;..." (same as the SIP parameters format).
Module: kamailio
Branch: master
Commit: 9d1f223c7705a7ed8d888f50f2611dea1649ffa5
URL: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-03-01T14:01:17+01:00
modules: readme files regenerated - corex ... [skip ci]
---
Modified: src/modules/corex/README
---
Diff: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de…
Patch: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de…
---
diff --git a/src/modules/corex/README b/src/modules/corex/README
index d1721ffa84..dc28b471ec 100644
--- a/src/modules/corex/README
+++ b/src/modules/corex/README
@@ -249,10 +249,13 @@ modparam("corex", "alias_subdomains", "udp:sip-router.org:5060")
The format of the value follows the SIP params style:
"attr1=val1;attr2=val2;...". The attributes can be:
- * type - it can be "A" (IPv4) or "AAAA" (IPv6)
+ * type - it can be "A" (IPv4), "AAAA" (IPv6) or "SRV"
* name - the domain name
* addr - the IP address
* ttl - TTL value
+ * priority - priority value for SRV record
+ * weight - weight value for SRV record
+ * port - port value for SRV record
* flags - can be: 1 - the domain is unresolvable (like blocklisted);
2 - the record is permanent (never times out, never deleted, never
overwritten)
Module: kamailio
Branch: master
Commit: 78c8d084e30373aacc456fd41062b68e6e82ea6f
URL: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68…
Author: Victor Seva <vseva(a)sipwise.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-03-01T10:35:23+01:00
db_redis: clean previous connection before trying to reconnect
---
Modified: src/modules/db_redis/redis_connection.c
---
Diff: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68…
Patch: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68…
---
diff --git a/src/modules/db_redis/redis_connection.c b/src/modules/db_redis/redis_connection.c
index 1166117961..5cf36ffb36 100644
--- a/src/modules/db_redis/redis_connection.c
+++ b/src/modules/db_redis/redis_connection.c
@@ -124,6 +124,11 @@ int db_redis_connect(km_redis_con_t *con) {
#endif
reply = NULL;
+ if(con->con) {
+ LM_DBG("free old connection first\n");
+ redisFree(con->con);
+ }
+
// TODO: introduce require_master mod-param and check if we're indeed master
// TODO: on carrier, if we have db fail-over, the currently connected
// redis server will become slave without dropping connections?
<!-- Kamailio Pull Request Template -->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #3037
#### Description
I can not remember the last time I wrote any C which was likely a class assignment last century. Anyways I came across this issue and it seemed in reach to get the ball rolling. I know this PR needs more work but my goal is to share my progress to help move this feature forward.
Based on https://github.com/svaarala/duktape/tree/master/extras/module-node
added:
- duk_module_node.h
- duk_module_node.c
updated:
- app_jsdt_api.h
- app_jsdt_api.c
Included the extra header and initialize the bindings after 'load JS context' was created.
added `cb_resolve_module` to resolve the full file system path for requested_id and parent_id
added `cb_load_module` function which uses `jsdt_load_file` to load resolved file
With absolute and relative modules working I met my current requirements to allow breaking routing into multiple smaller files.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3038
-- Commit Summary --
* app_jsdt: add duk_module_node for JS module resolution
-- File Changes --
M src/modules/app_jsdt/app_jsdt_api.c (65)
M src/modules/app_jsdt/app_jsdt_api.h (3)
A src/modules/app_jsdt/duk_module_node.c (333)
A src/modules/app_jsdt/duk_module_node.h (17)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3038.patchhttps://github.com/kamailio/kamailio/pull/3038.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3038
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3038(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [X] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Commits are separated per change dedication, even though they concern the same component.
- core: add support of ICE media options to SDP parser
- core: improve an existing data structures cloning in the SDP parser
---
core: add support of ICE media options to SDP parser
In the current implementation only parsing of ICE candidate
attributes is supported, which makes it Possible to work
with ICE candidates and parameters specifically related per
candidate, but makes it Impossible to work
with ICE options of the media stream level (ICE options which
have an impact on the whole specific media stream).
ICE candidate attributes and ICE media options have different
dedication.
In order to target this matter, a new linked list is introduced
to store ICE media stream options.
Additionally, now when parsing media stream's attributes,
a couple of new helper functions have been introduced to
properly extract and store ICE media options:
- extract_ice_option()
- add_sdp_ice_opt()
The following extraction approaches are supported:
- multi-valued ICE options attribute (more than one value per a= header)
- one value per attribute (multiple a= headers with ICE options present)
Also now the way how a "zeroed" on-hold is detected is improved,
in case of the ICE (re)negotiation (when the connection address is equal
to '0.0.0.0', the media port is equal to '9' and ice-option 'trickle' is
present) the SDP is Not considered as an on-hold case, and it clearly
detects it's the ICE (re)negotiation (RFC 8840), which for e.g.
leads to a proper work of other side modules' functions (which use SDP
parser's data structures),
such as 'is_audio_on_hold()' from the textops.so module.
---
core: improve existing data structures cloning in the SDP parser
It's been noticed that the cloning of SDP session(s) and
SDP stream(s) structures doesn't allocate the ICE candidate attributes,
nor it allocates (recently introduced) ICE media stream options.
In order to target this a couple of new functions have been introduced:
- clone_sdp_opt_attr()
- clone_sdp_ice_attr()
And additionally the following functions have been improved, in order to
properly clone/free ICE candidate attributes and (recently introduced)
ICE media stream options:
- clone_sdp_stream_cell()
- free_cloned_sdp_stream()
- free_sdp()
- print_sdp_stream()
Additionally for a proper new structure length calculation, the following
function is fixed:
- clone_sdp_session_cell()
---
Tagging project members to review the changes: @miconda @henningw @linuxmaniac
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3034
-- Commit Summary --
* core: add support of ICE media options to SDP parser
* core: improve an existing data structures cloning in the SDP parser
-- File Changes --
M src/core/parser/sdp/sdp.c (290)
M src/core/parser/sdp/sdp.h (40)
M src/core/parser/sdp/sdp_helpr_funcs.c (60)
M src/core/parser/sdp/sdp_helpr_funcs.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3034.patchhttps://github.com/kamailio/kamailio/pull/3034.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3034
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3034(a)github.com>
Module: kamailio
Branch: master
Commit: 236fada43f610b910490f7e0c216ac9aa3d9480c
URL: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
Author: Donat Zenichev <dzenichev(a)sipwise.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-02-28T09:13:21+01:00
core: add support of ICE media options to SDP parser
In the current implementation only parsing of ICE candidate
attributes is supported, which makes it Possible to work
with ICE candidates and parameters specifically related per
candidate, but makes it Impossible to work
with ICE options of the media stream level (ICE options which
have an impact on the whole specific media stream).
ICE candidate attributes and ICE media options have different
dedication.
In order to target this matter, a new linked list is introduced
to store ICE media stream options.
Additionally, now when parsing media stream's attributes,
a couple of new helper functions have been introduced to
properly extract and store ICE media options:
- extract_ice_option()
- add_sdp_ice_opt()
The following extraction approaches are supported:
- multi-valued ICE options attribute (more than one value per a= header)
- one value per attribute (multiple a= headers with ICE options present)
Also now the way how a "zeroed" on-hold is detected is improved,
in case of the ICE (re)negotiation (when the connection address is equal
to '0.0.0.0', the media port is equal to '9' and ice-option 'trickle' is
present) the SDP is Not considered as an on-hold case, and it clearly
detects it's the ICE (re)negotiation (RFC 8840), which for e.g.
leads to a proper work of other side modules' functions (which use SDP
parser's data structures),
such as 'is_audio_on_hold()' from the textops.so module.
---
Modified: src/core/parser/sdp/sdp.c
Modified: src/core/parser/sdp/sdp.h
Modified: src/core/parser/sdp/sdp_helpr_funcs.c
Modified: src/core/parser/sdp/sdp_helpr_funcs.h
---
Diff: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
Patch: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
Module: kamailio
Branch: master
Commit: fe7d7c571b6c8d446cf66a1cf27d335d98f5f945
URL: https://github.com/kamailio/kamailio/commit/fe7d7c571b6c8d446cf66a1cf27d335…
Author: Donat Zenichev <dzenichev(a)sipwise.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-02-28T09:13:21+01:00
core: improve an existing data structures cloning in the SDP parser
It's been noticed that the cloning of SDP session(s) and
SDP stream(s) structures doesn't allocate the ICE candidate attributes,
nor it allocates (recently introduced) ICE media stream options.
In order to target this a couple of new functions have been introduced:
- clone_sdp_opt_attr()
- clone_sdp_ice_attr()
And additionally the following functions have been improved, in order to
properly clone/free ICE candidate attributes and (recently introduced)
ICE media stream options:
- clone_sdp_stream_cell()
- free_cloned_sdp_stream()
- free_sdp()
- print_sdp_stream()
Additionally for a proper new structure length calculation, the following
function is fixed:
- clone_sdp_session_cell()
---
Modified: src/core/parser/sdp/sdp.c
---
Diff: https://github.com/kamailio/kamailio/commit/fe7d7c571b6c8d446cf66a1cf27d335…
Patch: https://github.com/kamailio/kamailio/commit/fe7d7c571b6c8d446cf66a1cf27d335…