fixes the deleted space after "erlang"
introduced by a593f518dd62fd68c330eb42470ce5d5e1dce636
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3041
-- Commit Summary --
* pkg::deb: Missing spaces
-- File Changes --
M pkg/kamailio/deb/bionic/rules (2)
M pkg/kamailio/deb/bullseye/rules (2)
M pkg/kamailio/deb/buster/rules (2)
M pkg/kamailio/deb/focal/rules (2)
M pkg/kamailio/deb/jessie/rules (2)
M pkg/kamailio/deb/stretch/rules (2)
M pkg/kamailio/deb/trusty/rules (2)
M pkg/kamailio/deb/xenial/rules (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3041.patchhttps://github.com/kamailio/kamailio/pull/3041.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3041
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3041(a)github.com>
### Description
Kamailio uses Ducktape 2 without module-node or module-ducktape, requiring all routing in a single file.
https://wiki.duktape.org/howtomodules
I'm attempting to add module-node support and creating this issue to track with PR.
Response from mailing list
> Hello,
>
> I didn't notice that require() was not in the duktape 2.x, I will try to add support for module-duktape when I get a chance. If someone wants to do it, pull requests are welcome -- it does not seem to be complex:
> * https://github.com/svaarala/duktape/tree/master/extras/module-duktape
> The module-node sounds interesting, but not being familiar with node.js, looks it need more work to enable it:
> * https://github.com/svaarala/duktape/tree/master/extras/module-node
>
> Cheers,
> Daniel
### Expected behavior
Include the required() JS file
`
var test = require('./test');
`
#### Actual observed behavior
Calling require() in a JSDT script throws TypeError: undefined not callable
#### Log Messages
```
ERROR: app_jsdt [app_jsdt_api.c:448]: jsdt_kemi_load_script(): failed running: TypeError: undefined not callable
```
### Possible Solutions
I played around a little with `module-duktape` but wasn't smart enough to define a `Duktape.modSearch()` that would work as desired. I'm probably missing something obvious. I've recently been playing with `asterisk/node-ari-client` which got me curious if `module-node` might be more aligned with thinking.
### Additional Information
* **Kamailio Version** - kamailio 5.5.4
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3037
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3037(a)github.com>
Module: kamailio
Branch: master
Commit: c37ccdc6e3bad0af4644941a872f510c51936c58
URL: https://github.com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-02-25T09:13:46+01:00
core: fixed comment typo
---
Modified: src/core/sr_module.h
---
Diff: https://github.com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
Patch: https://github.com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
---
diff --git a/src/core/sr_module.h b/src/core/sr_module.h
index 33f4f00095..251be938b0 100644
--- a/src/core/sr_module.h
+++ b/src/core/sr_module.h
@@ -160,7 +160,7 @@ void ksr_module_set_flag(unsigned int flag);
@warning child_init(PROC_MAIN) is again called
in the same process (main), but latter
(before tcp), so make sure you don't init things
- twice, bot in PROC_MAIN and PROC_INT */
+ twice, both in PROC_MAIN and PROC_INT */
#define PROC_NOCHLDINIT -128 /**< no child init functions will be called
if this rank is used in fork_process() */
hello all
we have seen a segmentation fault on a kamailio 5.4.4
```
#0 0x00007feb664346ad in print_lists (dlg=0x7feaa5f65290) at dlg_var.c:277
277 varlist = varlist->next;
Missing separate debuginfos, use: debuginfo-install bzip2-libs-1.0.6-13.el7.x86_64 cyrus-sasl-lib-2.1.26-20.el7_2.x86_64 elfutils-libelf-0.166-2.el7.x86_64 elfutils-libs-0.166-2.el7.x86_64 glibc-2.17-157.el7_3.5.x86_64 jansson-2.10-1.el7.x86_64 keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-8.el7.x86_64 libattr-2.4.46-12.el7.x86_64 libcap-2.22-8.el7.x86_64 libcom_err-1.42.9-9.el7.x86_64 libcurl-7.29.0-35.el7.centos.x86_64 libev-4.15-7.el7.x86_64 libevent-2.0.21-4.el7.x86_64 libgcc-4.8.5-16.el7.x86_64 libidn-1.28-4.el7.x86_64 libselinux-2.5-6.el7.x86_64 libssh2-1.4.3-10.el7_2.1.x86_64 libuuid-2.23.2-33.el7_3.2.x86_64 libxml2-2.9.1-6.el7_2.3.x86_64 nspr-4.13.1-1.0.el7_3.x86_64 nss-3.28.4-1.2.el7_3.x86_64 nss-softokn-freebl-3.16.2.3-14.4.el7.x86_64 nss-util-3.28.4-1.0.el7_3.x86_64 openldap-2.4.40-13.el7.x86_64 openssl-libs-1.0.2k-19.el7.x86_64 pcre-8.32-15.el7_2.1.x86_64 systemd-libs-219-30.el7_3.9.x86_64 xz-libs-5.2.2-1.el7.x86_64 zlib-1.2.7-17.el7.x86_64
(gdb) bt
#0 0x00007feb664346ad in print_lists (dlg=0x7feaa5f65290) at dlg_var.c:277
#1 0x00007feb664367ff in pv_set_dlg_variable (msg=0x7feb6a881bd8, param=0x7feb6adc85a0, op=254, val=0x7ffea166a7a0) at dlg_var.c:443
#2 0x00000000004bbaf2 in lval_pvar_assign (h=0x7ffea166bbd0, msg=0x7feb6a881bd8, lv=0x7feb6adc8668, rv=0x7feb6adc87e8) at core/lvalue.c:352
#3 0x00000000004bc5f0 in lval_assign (h=0x7ffea166bbd0, msg=0x7feb6a881bd8, lv=0x7feb6adc8668, rve=0x7feb6adc87e0) at core/lvalue.c:400
#4 0x0000000000487ddf in do_action (h=0x7ffea166bbd0, a=0x7feb6adc8f80, msg=0x7feb6a881bd8) at core/action.c:1455
#5 0x0000000000489b1b in run_actions (h=0x7ffea166bbd0, a=0x7feb6adc8338, msg=0x7feb6a881bd8) at core/action.c:1581
#6 0x000000000047c6d7 in do_action (h=0x7ffea166bbd0, a=0x7feb6adce4c0, msg=0x7feb6a881bd8) at core/action.c:1067
#7 0x0000000000489b1b in run_actions (h=0x7ffea166bbd0, a=0x7feb6adc3190, msg=0x7feb6a881bd8) at core/action.c:1581
#8 0x000000000048a25f in run_top_route (a=0x7feb6adc3190, msg=0x7feb6a881bd8, c=0x7ffea166bbd0) at core/action.c:1666
#9 0x00007feb69eab0a2 in reply_received (p_msg=0x7feb6a881bd8) at t_reply.c:2543
#10 0x000000000059dc77 in do_forward_reply (msg=0x7feb6a881bd8, mode=0) at core/forward.c:764
#11 0x000000000059f949 in forward_reply (msg=0x7feb6a881bd8) at core/forward.c:865
#12 0x00000000005f095a in receive_msg (
buf=0xacec80 <buf.7134> "SIP/2.0 100 Trying\r\nVia: SIP/2.0/UDP 79.170.70.13;branch=z9hG4bK7837.ffc6315fbd54de1e6a00b32fa1cc0eda.1\r\nVia: SIP/2.0/UDP 79.170.66.28:5080;received=79.170.66.28;rport=5080;branch=z9hG4bK83ve3c7ty27QF"..., len=426, rcv_info=0x7ffea166c6c0) at core/receive.c:509
#13 0x00000000004e3cd7 in udp_rcv_loop () at core/udp_server.c:543
#14 0x0000000000429f56 in main_loop () at main.c:1689
#15 0x0000000000434034 in main (argc=15, argv=0x7ffea166cf58) at main.c:2876
```
[Uploading core_kamailio_mia_osp_feb18.log…]()
could you please take a look to the attached full backtrace?
thanks a lot and regards
david
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3039
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3039(a)github.com>
Module: kamailio
Branch: master
Commit: a63fde36f440b6d79cea6cdb0dfeee6258d96698
URL: https://github.com/kamailio/kamailio/commit/a63fde36f440b6d79cea6cdb0dfeee6…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-02-23T14:25:46+01:00
pkg/kamailio/deb: add kamailio-nats-modules to bookworm
https://tracker.debian.org/news/1305763/natsc-320-1-migrated-to-testing/
---
Modified: pkg/kamailio/deb/bookworm/control
Modified: pkg/kamailio/deb/bookworm/rules
Modified: pkg/kamailio/deb/debian/backports/bookworm
---
Diff: https://github.com/kamailio/kamailio/commit/a63fde36f440b6d79cea6cdb0dfeee6…
Patch: https://github.com/kamailio/kamailio/commit/a63fde36f440b6d79cea6cdb0dfeee6…
---
diff --git a/pkg/kamailio/deb/bookworm/control b/pkg/kamailio/deb/bookworm/control
index 8f425be82c..4e670a602c 100644
--- a/pkg/kamailio/deb/bookworm/control
+++ b/pkg/kamailio/deb/bookworm/control
@@ -29,6 +29,7 @@ Build-Depends:
libmongoc-dev,
libmono-2.0-dev [amd64 armel armhf i386 mipsel kfreebsd-amd64 kfreebsd-i386 ppc64 ppc64el s390x],
libmosquitto-dev,
+ libnats-dev,
libncurses5-dev,
libpcre3-dev,
libperl-dev,
@@ -840,6 +841,24 @@ Description: Libwebsockets module for the Kamailio SIP server
This package contains the lwcs module, which provides a client-side WebSockets
API through libwebsockets.
+Package: kamailio-nats-modules
+Architecture: any
+Multi-Arch: same
+Pre-Depends:
+ ${misc:Pre-Depends},
+Depends:
+ kamailio (= ${binary:Version}),
+ ${misc:Depends},
+ ${shlibs:Depends},
+Description: Nats module for the Kamailio SIP server
+ Kamailio is a very fast and flexible SIP (RFC3261)
+ server. Written entirely in C, Kamailio can handle thousands calls
+ per second even on low-budget hardware.
+ .
+ This package contains the nats module, which provides a NATS consumer for Kamailio.
+ NATS is a real time distributed messaging platform, more details about it can be
+ found at nats.io.
+
Package: kamailio-extra-modules
Architecture: any
Multi-Arch: same
diff --git a/pkg/kamailio/deb/bookworm/rules b/pkg/kamailio/deb/bookworm/rules
index ddf8846c9d..2161ac0bb4 100755
--- a/pkg/kamailio/deb/bookworm/rules
+++ b/pkg/kamailio/deb/bookworm/rules
@@ -21,7 +21,7 @@ include /usr/share/dpkg/buildflags.mk
export RADCLI=1
# modules not in the "main" kamailio package
-EXCLUDED_MODULES= java python nats
+EXCLUDED_MODULES= java python
# extra modules to skip, because they are not compilable now
# - regardless if they go to the main kamailio package or to some module package,
@@ -37,7 +37,7 @@ PACKAGE_GROUPS=mysql postgres berkeley unixodbc radius presence \
snmpstats carrierroute xmpp cpl redisgeoip geoip2 \
sqlite json mono ruby ims sctp \
tls outbound websocket autheph kazoo cnxcc \
- erlangsystemd phonenum mongodb rabbitmq python3 mqtt secsipid lwsc
+ erlang nats systemd phonenum mongodb rabbitmq python3 mqtt secsipid lwsc
# module groups to be packaged onto kamailio-extra-modules
EXTRA_GROUPS=gzcompress uuid ev jansson http_async
diff --git a/pkg/kamailio/deb/debian/backports/bookworm b/pkg/kamailio/deb/debian/backports/bookworm
index 21dafb2d11..1d39bd6509 100755
--- a/pkg/kamailio/deb/debian/backports/bookworm
+++ b/pkg/kamailio/deb/debian/backports/bookworm
@@ -35,13 +35,6 @@ sed -i -e '/^ python,/d' -e '/python-dev/d' \
sed -i -e 's/ python [ ,$]*//' ${DIST}/rules
sed -i -e '/^EXCLUDED_MODULES=/s/$/ python/' ${DIST}/rules
-# no libnats-dev
-sed -i -e '/^ libnats-dev,/d' \
- -e '/^Package: kamailio-nats-modules/,/^$/d' \
- ${DIST}/control
-sed -i -e 's/ nats [ ,$]*//' ${DIST}/rules
-sed -i -e '/^EXCLUDED_MODULES=/s/$/ nats/' ${DIST}/rules
-
wrap-and-sort -sat -d ${DIST}
# clean backports scripts
### Description
At the moment db_redis driver does not support interfacing with a redis cluster. This is a proposal to add support to it.
The db_redis module will get a new module parameter to enable cluster support (with default 0 - disabled):
```
modparam("db_redis", "cluster", 1)
```
The redis url used by other modules needs to specify all nodes in the cluster, and must NOT include redis database number (since it's not supported in cluster mode):
```
#!define DBURL_USRLOC "redis://10.0.1.1:6379,10.0.1.2:6379,10.0.1.3:6379"
```
The implementation is going to use the [hiredis-cluster](https://github.com/Nordix/hiredis-cluster) library (BSD license). If cluster mode is not enabled the module will behave like before, i.e. all calls to redis will use hiredis library directly.
If you find this proposal sensible, I'll start coding it.
Feedback is welcome, of course!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2977
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/2977(a)github.com>
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The IP checksum is part of the header and must be zeroed before checksumming.
This patch also silences another (benign) warning.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3035
-- Commit Summary --
* nathelper: Fix uninitialized data
-- File Changes --
M src/modules/nathelper/nathelper.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3035.patchhttps://github.com/kamailio/kamailio/pull/3035.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3035
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3035(a)github.com>
…ugh the ipsec tunnel
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
I've fixed an issue that would ignore legitimate replies that are sent by real-world UEs, causing calls to completely break due to timeouts.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3029
-- Commit Summary --
* ims_ipsec_pcscf: fix issues with UEs not sending certain replies through the ipsec tunnel
-- File Changes --
M src/modules/ims_ipsec_pcscf/cmd.c (108)
M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (13)
M src/modules/ims_ipsec_pcscf/ipsec.c (39)
D src/modules/ims_ipsec_pcscf/port_gen.c (227)
D src/modules/ims_ipsec_pcscf/port_gen.h (41)
M src/modules/ims_ipsec_pcscf/sec_agree.c (26)
M src/modules/ims_ipsec_pcscf/spi_gen.c (119)
M src/modules/ims_ipsec_pcscf/spi_gen.h (6)
M src/modules/ims_ipsec_pcscf/spi_list.c (72)
M src/modules/ims_ipsec_pcscf/spi_list.h (13)
M src/modules/ims_ipsec_pcscf/spi_list_tests.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3029.patchhttps://github.com/kamailio/kamailio/pull/3029.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3029
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3029(a)github.com>
When running as a P-CSCF a crash would occur with certain in-dialog
replies. The `msg->contact->parsed` pointer is unreliably reused and
would point to garbage.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
When running as a P-CSCF a crash would occur with certain in-dialog replies. The `msg->contact->parsed` pointer is unreliably reused and would point to garbage.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3032
-- Commit Summary --
* ims: fix a crash with contact parsing
-- File Changes --
M src/lib/ims/ims_getters.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3032.patchhttps://github.com/kamailio/kamailio/pull/3032.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3032
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3032(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2069
#### Description
The Erlang module is not working at all with newer Kamailio versions. One of the issues was already found in #2069 but no code was submitted. The second one I believe is related to https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… in that the erlang module assumes that pvi.type is zero and uses that field to type the custom fields it manages and this commit starts populating pvi.type with a 4.
I don't have a solid grasp on pvapi.c so if the experts have a better way to fix this up I am all ears. These two commits do get the module working properly and I am able to use both the custom erlang PV terms and the RPC feature from my proxy now.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3024
-- Commit Summary --
* Erlang: Erlang module assumes pvi.type is zero
* Erlang: Revert breaking change
-- File Changes --
M src/modules/erlang/pv_atom.c (3)
M src/modules/erlang/pv_pid.c (3)
M src/modules/erlang/pv_ref.c (3)
M src/modules/erlang/pv_xbuff.c (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3024.patchhttps://github.com/kamailio/kamailio/pull/3024.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3024
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3024(a)github.com>
Module: kamailio
Branch: master
Commit: 1ed58f0de4f7a3ab3a81dd84c1c3b94fa1df2c4b
URL: https://github.com/kamailio/kamailio/commit/1ed58f0de4f7a3ab3a81dd84c1c3b94…
Author: James Van Vleet <james(a)vanvleet.net>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-02-18T15:40:04+01:00
Erlang: Revert breaking change
Revert https://github.com/kamailio/kamailio/commit/6542a367638ec5f8a2b62994f8c309e…
xavp_add_xavp_value returns the root and not the xavp it added and that was the reason for the code the commit removed. Changed a variable name to help make that more clear.
Also related to https://github.com/kamailio/kamailio/issues/2069.
---
Modified: src/modules/erlang/pv_xbuff.c
---
Diff: https://github.com/kamailio/kamailio/commit/1ed58f0de4f7a3ab3a81dd84c1c3b94…
Patch: https://github.com/kamailio/kamailio/commit/1ed58f0de4f7a3ab3a81dd84c1c3b94…
---
diff --git a/src/modules/erlang/pv_xbuff.c b/src/modules/erlang/pv_xbuff.c
index 894c36784c..b19a22ac8e 100644
--- a/src/modules/erlang/pv_xbuff.c
+++ b/src/modules/erlang/pv_xbuff.c
@@ -86,11 +86,15 @@ sr_xavp_t *xbuff_new(str *name)
if(!xbuffs_root)
{
- xbuff = xavp_add_xavp_value(&xbuff_list,name,&xbuff_val,xavp_get_crt_list());
- } else {
- xbuff = xavp_get_child(&xbuff_list, name);
+ xbuffs_root = xavp_add_xavp_value(&xbuff_list,name,&xbuff_val,xavp_get_crt_list());
+ if (!xbuffs_root){
+ LM_ERR("cannot create xbuffs_root \n");
+ return NULL;
+ }
}
+ xbuff = xavp_get_child(&xbuff_list, name);
+
if (!xbuff) {
xbuff_val.type = SR_XTYPE_NULL;
Module: kamailio
Branch: master
Commit: 537d11183d4907101e69d00e92e3530d2eb7cb5e
URL: https://github.com/kamailio/kamailio/commit/537d11183d4907101e69d00e92e3530…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-02-18T09:04:27+01:00
async: docs - fixed typos
---
Modified: src/modules/async/doc/async_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/537d11183d4907101e69d00e92e3530…
Patch: https://github.com/kamailio/kamailio/commit/537d11183d4907101e69d00e92e3530…
---
diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml
index 4955f00036..7185cbff52 100644
--- a/src/modules/async/doc/async_admin.xml
+++ b/src/modules/async/doc/async_admin.xml
@@ -93,9 +93,9 @@ modparam("async", "workers", 2)
<para>
Enables millisecond timer for async_ms_sleep() and async_ms_route() functions.
The integer value is the timer resolution in milliseconds. A smaller timer
- resultion will generate a higher load on the system. If you set ms_timer
- to 1 you will get a timer with 1 millisecond resultion, a setting of 20
- provides a resultion of 20ms.
+ resolution will generate a higher load on the system. If you set ms_timer
+ to 1 you will get a timer with 1 millisecond resolution, a setting of 20
+ provides a resolution of 20ms.
</para>
<para>
<emphasis>
Hello,
Kamailio SIP Server v5.5.4 stable release is out.
This is a maintenance release of the latest stable branch, 5.5, that
includes fixes since the release of v5.5.3. There is no change to
database schema or configuration language structure that you have to do
on previous installations of v5.5.x. Deployments running previous v5.5.x
versions are strongly recommended to be upgraded to v5.5.4.
For more details about version 5.5.4 (including links and guidelines to
download the tarball or from GIT repository), visit:
* https://www.kamailio.org/w/2022/02/kamailio-v5-5-4-released/
RPM, Debian/Ubuntu packages will be available soon as well.
Many thanks to all contributing and using Kamailio!
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
ERROR: connect_unix_sock: connect(/var/run/kamailio//kamailio_ctl): No such file or directory [2]
Thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3033
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3033(a)github.com>
#3029 ## Description
While the `kex` module exports a way to temporarily change the debug level, it cannot retrieve the current level.
### Expected behavior
I can write Python code like this:
```
if KSR.kex.getdebug() > 2:
... # generate detailed and somewhat-time-consuming debug output
... # which would just get dropped on the floor otherwise
```
#### Actual observed behavior
If there is a way to get Kamailio's current and/or configured debug level, I didn't find it.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3030
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3030(a)github.com>
Hello,
I am considering to release Kamailio v5.5.4 later this week, likely on
Thursday, Feb 17, 2022. This is the usual heads up
notification to see if anyone is aware of issues not yet reported to bug
tracker and if yes, do it as soon as possible to give them a chance to
be fixed.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
Feb 21-24, 2022 (America Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
Hello,
I want to announce the availability of sipexer v1.0.0 - a sip cli tool
that can facilitate testing and monitoring of SIP signalling systems. It
tries to have a modern approach, with a flexible templating system,
supporting both IPv4 and IPv6 with all the common transport layers,
respectively UDP, TCP, TLS and WebSocket (for WebRTC).
The project can be found at:
* https://github.com/miconda/sipexer
It is written in Go language for better portability, binaries for Linux,
MacOS and Windows are made available for download in the release page:
* https://github.com/miconda/sipexer/releases/tag/v1.0.0
Among its features:
* send OPTIONS request (quick SIP ping to check if server is alive)
* do registration and un-registration with customized expires value
and contact URI
* authentication with plain or HA1 passwords
* set custom SIP headers
* template system for building SIP requests
* fields in the templates can be set via command line parameters or a
JSON file
* variables for setting field values (e.g., random number, data,
time, environment variables, uuid, random string, …)
* simulate SIP calls at signalling layer (INVITE-wait-BYE)
* respond to requests coming during SIP calls (e.g., OPTIONS keepalives)
* send instant messages with SIP MESSAGE requests
* color output mode for easier troubleshooting
* support for many transport layers: IPv4 and IPv6, UDP, TCP, TLS and
WebSocket (for WebRTC)
* send SIP requests of any type (e.g., INFO, SUBSCRIBE, NOTIFY, …)
One usage example that could ease the testing of Kamailio is initiating
registrations or simulating calls over WebSocket without the need of
having a JavaScript soft phone application running in a web browser.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://www.asipto.com