- sr-dev - kamailio.org

[kamailio/kamailio] mhomed does not work with virtual IPs created by keepalived (Issue #3002)
by ccolumbu999 15 Jan '22

15 Jan '22

### Description I enabled mhomed=1 as well as ip_free_bind=1, but kamailio does not recognize that there is internal and external traffic. For example I also enabled modparam("rr", "enable_double_rr", 1), but the 2 Record-Routes both have the external IP. In addition fix_nated_contact() and fix_nated_sdp don't work because they think all traffic is coming from the external IP.  ### Troubleshooting I tried a lot of things. #### Reproduction Set up a server with keepalived and a virtual IP and use any standard NAT config and it won't work.  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions I thought that ip_free_bind=1 would fix this issue, but it does not seem to have any effect.  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3002 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3002(a)github.com>

2 3

git:master:3da3a780: kex: use unsigned long for rpc stats.fetchn values
by Daniel-Constantin Mierla 14 Jan '22

14 Jan '22

Module: kamailio Branch: master Commit: 3da3a780c9a9a4fc7a0852193080da2cbaa2adcf URL: https://github.com/kamailio/kamailio/commit/3da3a780c9a9a4fc7a0852193080da2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-14T16:50:07+01:00 kex: use unsigned long for rpc stats.fetchn values --- Modified: src/modules/kex/core_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/3da3a780c9a9a4fc7a0852193080da2… Patch: https://github.com/kamailio/kamailio/commit/3da3a780c9a9a4fc7a0852193080da2… --- diff --git a/src/modules/kex/core_stats.c b/src/modules/kex/core_stats.c index a1f14a7dc6..ec543d1b60 100644 --- a/src/modules/kex/core_stats.c +++ b/src/modules/kex/core_stats.c @@ -496,7 +496,7 @@ static void rpc_fetch_add_stat(rpc_t* rpc, void* ctx, void* hst, char* g, char* snprintf(nbuf, 127, "%s.%s", g, n); if (numeric) { - res = rpc->struct_add(hst, "d", nbuf, val); + res = rpc->struct_add(hst, "j", nbuf, val); } else { res = rpc->struct_printf(hst, nbuf, "%lu", val); }

1 0

git:master:6794a120: statsc: use long long for rpc output value
by Daniel-Constantin Mierla 14 Jan '22

14 Jan '22

Module: kamailio Branch: master Commit: 6794a120f3c2466985fe1d837f00c5366df8e1c1 URL: https://github.com/kamailio/kamailio/commit/6794a120f3c2466985fe1d837f00c53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-14T16:19:28+01:00 statsc: use long long for rpc output value --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/6794a120f3c2466985fe1d837f00c53… Patch: https://github.com/kamailio/kamailio/commit/6794a120f3c2466985fe1d837f00c53… --- diff --git a/src/modules/statsc/statsc_mod.c b/src/modules/statsc/statsc_mod.c index 1ee13c3cec..6baf2bea4a 100644 --- a/src/modules/statsc/statsc_mod.c +++ b/src/modules/statsc/statsc_mod.c @@ -354,7 +354,8 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) int cmode; str sname; int range; - int k, m, n, v; + int k, m, n; + int64_t v; time_t tn; void* th; void* ts; @@ -433,7 +434,7 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) rpc->fault(ctx, 500, "Error creating rpc (5)"); return; } - v = (int)sm->vals[k]; + v = sm->vals[k]; switch(cmode) { case 1: break; @@ -442,13 +443,13 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) continue; } if(k==0) { - v -= (int)sm->vals[statsc_items-1]; + v -= sm->vals[statsc_items-1]; } else { - v -= (int)sm->vals[k-1]; + v -= sm->vals[k-1]; } break; } - if(rpc->struct_add(ti, "udd", + if(rpc->struct_add(ti, "uLd", "timestamp", (unsigned int)_statsc_info->slist->vals[k], "value", v, "index", m++)<0) { @@ -464,7 +465,7 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) rpc->fault(ctx, 500, "Error creating rpc (7)"); return; } - v = (int)sm->vals[k]; + v = sm->vals[k]; switch(cmode) { case 1: break; @@ -472,10 +473,10 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) if(n==k-1) { continue; } - v -= (int)sm->vals[k-1]; + v -= sm->vals[k-1]; break; } - if(rpc->struct_add(ti, "udd", + if(rpc->struct_add(ti, "uLd", "timestamp", (unsigned int)_statsc_info->slist->vals[k], "value", v, "index", m++)<0) {

1 0

[kamailio/kamailio] add parameter presence : default_expires (Issue #2996)
by adita76 14 Jan '22

14 Jan '22

### Description Similar to pua:default_expires, a default expire value could be added for subscriptions. The default expiration values are now hard coded for presence modules, in presence_*/add_events.c files. ### Expected behavior Default expiration value that is configurable. #### Actual observed behavior Default expiration value is 3600. ### Possible Solutions Adding a parameter presence : default_expires and use it in all presence_*/add_events.c files. I can implement this myself. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2996 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2996(a)github.com>

2 2

[kamailio/kamailio] server crashes every 10 hours (#2101)
by ekke56 14 Jan '22

14 Jan '22

### Description  ### Troubleshooting coredump data below. #### Reproduction  #### Debugging Data  ``` (gdb) bt full #0 0x000000000046ccdd in get_hash1_raw (s=0x5da51296 <Address 0x5da51296 out of bounds>, len=9) at core/hashes.h:109 p = 0x5da51296 <Address 0x5da51296 out of bounds> v = 4100353960 h = 0 #1 0x000000000046cfb6 in str_hash_get (ht=0xa6d6c0 <cnts_hash_table>, key=0x5da51296 <Address 0x5da51296 out of bounds>, len=9) at core/str_hash.h:94 h = 0 e = 0x19 #2 0x000000000046debe in cnt_hash_lookup (group=0x7ffc2db9d7c0, name=0x7eff79693b80) at core/counters.c:420 e = 0x7eff80c48c88 first = 0xbd8191bc2e950d55 cnt_rec = 0x7eff80c48cb0 #3 0x000000000046e752 in counter_lookup_str (handle=0x7ffc2db9d7d0, group=0x7ffc2db9d7c0, name=0x7eff79693b80) at core/counters.c:541 cnt_rec = 0x19 #4 0x00007eff7d65b447 in get_stat (name=0x7eff79693b80) at ../../core/counters.h:197 h = {id = 13} grp = {s = 0x0, len = 0} #5 0x00007eff7d65c113 in statsc_svalue (name=0x7eff79693b80, res=0x7eff79693f4b) at statsc_mod.c:149 stat = 0xd __FUNCTION__ = "statsc_svalue" #6 0x00007eff7d65db79 in statsc_timer (ticks=113205942, param=0x0) at statsc_mod.c:274 sm = 0x7eff79693b70 tn = 1571099286 n = 115 __FUNCTION__ = "statsc_timer" #7 0x00000000005db7f9 in sr_wtimer_exec (ticks=113205942, param=0x0) at core/timer_proc.c:390 wt = 0x7eff80c56f48 wn = 0x0 wp = 0x0 cs = 0 __FUNCTION__ = "sr_wtimer_exec" #8 0x00000000005daa29 in fork_sync_timer (child_id=-1, desc=0x7c8a71 "secondary timer", make_sock=1, f=0x5db4f2 <sr_wtimer_exec>, param=0x0, interval=1000) at core/timer_proc.c:224 pid = 0 ts1 = 1811295077 ts2 = 1000 #9 0x00000000005dbb26 in sr_wtimer_start () at core/timer_proc.c:416 __FUNCTION__ = "sr_wtimer_start" #10 0x0000000000425a33 in main_loop () at main.c:1729 i = 8 pid = 3615 si = 0x0 si_desc = "udp receiver child=7 sock=91.216.86.57:5060\000\377~\000\000@۹-\374\177\000\000\020\207A\000\000\000\000\000\020\336\271-\374\177\000\000\323c{\000\000\000\000\000\031\000\000\000\000\000\000\000\000\000\000\004\000\000\000\000\000\000\200\000\000\000\000\000__:\201\377~\000\000\250\346\260v\377~\000\000\270\314À\377~\000" nrprocs = 8 woneinit = 1 __FUNCTION__ = "main_loop" #11 0x000000000042c72a in main (argc=7, argv=0x7ffc2db9def8) at main.c:2696 cfg_stream = 0x1ee3010 c = -1 r = 0 tmp = 0x7ffc2db9ef2c "" tmp_len = 0 port = 0 proto = 0 options = 0x76a9a0 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 ---Type <return> to continue, or q <return> to quit--- info locals seed = 2620966285 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x2 p = 0x0 st = {st_dev = 20, st_ino = 22346, st_nlink = 2, st_mode = 16832, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1568107728, tv_nsec = 458000000}, st_mtim = { tv_sec = 1571064422, tv_nsec = 57000000}, st_ctim = {tv_sec = 1571064422, tv_nsec = 57000000}, __unused = {0, 0, 0}} __FUNCTION__ = "main" (gdb) list 104 register unsigned v; 105 register unsigned h; 106 107 h=0; 108 109 hash_update_str(s, s+len, p, v, h); 110 return hash_finish(h); 111 } 112 113 ``` #### Log Messages  ``` no relevant messages ``` #### SIP Traffic  ``` seems to be triggered by internal timer ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.4 (x86_64/linux) 759867 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 759867 compiled on 12:20:22 Sep 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` CentOS Linux release 7.4.1708 (Core) Linux xxx 3.10.0-957.12.2.el7.x86_64 #1 SMP Tue May 14 21:24:32 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2101

3 20

git:master:22558e34: modules: readme files regenerated - statsc ... [skip ci]
by Kamailio Dev 14 Jan '22

14 Jan '22

Module: kamailio Branch: master Commit: 22558e3407a49dbf7ef84669190df0c98c8a8d58 URL: https://github.com/kamailio/kamailio/commit/22558e3407a49dbf7ef84669190df0c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-01-14T09:16:13+01:00 modules: readme files regenerated - statsc ... [skip ci] --- Modified: src/modules/statsc/README --- Diff: https://github.com/kamailio/kamailio/commit/22558e3407a49dbf7ef84669190df0c… Patch: https://github.com/kamailio/kamailio/commit/22558e3407a49dbf7ef84669190df0c… --- diff --git a/src/modules/statsc/README b/src/modules/statsc/README index 2ef41cc72d..d06f3925b2 100644 --- a/src/modules/statsc/README +++ b/src/modules/statsc/README @@ -103,6 +103,8 @@ modparam("statsc", "interval", 300) How many items to store for each statistic. + Note: it must be set before any 'track' parameter. + Default value is 100. Example 1.2. Set items parameter

1 0

git:master:f517f8c6: statsc: note that items param must be set before track
by Daniel-Constantin Mierla 14 Jan '22

14 Jan '22

Module: kamailio Branch: master Commit: f517f8c655e676f5872eda5f81f5244eac4eed25 URL: https://github.com/kamailio/kamailio/commit/f517f8c655e676f5872eda5f81f5244… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-14T09:02:39+01:00 statsc: note that items param must be set before track --- Modified: src/modules/statsc/doc/statsc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f517f8c655e676f5872eda5f81f5244… Patch: https://github.com/kamailio/kamailio/commit/f517f8c655e676f5872eda5f81f5244… --- diff --git a/src/modules/statsc/doc/statsc_admin.xml b/src/modules/statsc/doc/statsc_admin.xml index 9794349690..3dd6d80051 100644 --- a/src/modules/statsc/doc/statsc_admin.xml +++ b/src/modules/statsc/doc/statsc_admin.xml @@ -81,6 +81,9 @@ modparam("statsc", "interval", 300) <para> How many items to store for each statistic. </para> + <para> + Note: it must be set before any 'track' parameter. + </para> <para> <emphasis> Default value is 100.

1 0

git:master:b29c79c8: stats: detect of mod param items is set after track
by Daniel-Constantin Mierla 14 Jan '22

14 Jan '22

Module: kamailio Branch: master Commit: b29c79c8d83fd23064e50dcee02e5f85ec51328d URL: https://github.com/kamailio/kamailio/commit/b29c79c8d83fd23064e50dcee02e5f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-14T08:55:06+01:00 stats: detect of mod param items is set after track - it can lead to crash if items is set to greater value than the default one (GH #2101) - round up for better memory alignment in the allocated structures --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b29c79c8d83fd23064e50dcee02e5f8… Patch: https://github.com/kamailio/kamailio/commit/b29c79c8d83fd23064e50dcee02e5f8…

1 0

[kamailio/kamailio] Infinity read from closed socket (#2658)
by sergey-safarov 13 Jan '22

13 Jan '22

### Description I observing a case when Kamailio stop processing calls. What is found: *Lot of connections with CLOSE_WAIT state* ``` [root@sbc-13 ~]# netstat -anp | grep 5060 tcp 129 0 100.85.118.66:5060 0.0.0.0:* LISTEN 56907/kamailio tcp 153 0 100.85.118.66:5060 3.101.84.132:21929 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:32738 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:39084 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:28843 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:57939 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:27823 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:15820 CLOSE_WAIT - tcp 0 0 100.85.118.66:5060 207.244.110.239:11587 ESTABLISHED 56907/kamailio tcp 153 0 100.85.118.66:5060 3.101.84.132:11972 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:57245 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:54344 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:41416 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:3644 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:61657 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:49325 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:65334 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:48657 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:1612 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:7879 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:56626 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:57247 CLOSE_WAIT - tcp 153 0 100.85.118.66:5060 3.101.84.132:30494 CLOSE_WAIT - ``` At this time on two core server, one core loaded 100% and another core is free. And top show ``` %Cpu(s): 29.4 us, 26.5 sy ``` As about 26% CPU cycles proceed kernel call, using `strace` utility I found Kamailio process (with top CSP usage) continusly make thus kernel calls. ``` recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) recvfrom(58, 0x7ffdb46a5ab0, 232, MSG_PEEK, NULL, NULL) = -1 EAGAIN (Resource temporarily unavailable) ``` *Then I check 58 process file descriptor* ``` [root@sbc-13 ~]# ls -la /proc/56907/fd/58 lrwx------. 1 kamailio kamailio 64 Mar 3 10:49 /proc/56907/fd/58 -> 'socket:[3931924]' ``` *Info about open socket* ``` [root@sbc-13 ~]# lsof -a -p 56907| grep 3931924 kamailio 56907 kamailio 58u IPv4 3931924 0t0 TCP ip-100-85-118-66.us-west-1.compute.internal:sip->207.244.110.239:11495 (ESTABLISHED) ``` *Info about Kamailio 56907 process* ``` [root@sbc-13 ~]# kamcmd core.ps | tail 56903 tcp receiver (generic) child=4 56904 tcp receiver (generic) child=5 56905 tcp receiver (generic) child=6 56906 tcp receiver (generic) child=7 56907 tcp main process ``` Then using gdb I have created core file and back trace here ``` (gdb) bt full #0 0x00007f07d3639b1e in recv () from /lib64/libpthread.so.0 No symbol table info available. #1 0x0000000000528817 in tcpconn_read_haproxy (c=0x7f07ce98d930) at core/tcp_main.c:953 bytes = -1 retval = 0 size = 3454406656 port = 32519 p = 0x7ef068 "" end = 0x7f07d335c4c0 <syslog> "\363\017\036\372H\201\354", <incomplete sequence \330> src_ip = 0x6e9646 <qm_shm_malloc+103> dst_ip = 0x7ffdb46a5c20 v2sig = "\r\n\r\n\000\r\nQUIT\n" hdr = {v1 = {line = "\300\304\065\323\004", '\000' <repeats 11 times>, "\370ؘ\316\004\000\000\000t\251\205\000\000\000\000\000\320[j\264\375\177\000\000\004\331m\000\000\000\000\000\320[j\264\375\177\000\000\306\331m\000\000\000\000\000\b\342u\316\a\177\000\000\000\020\346\315\a\177\000\000\367b\201\000\000\000\000\000y\251\205\000n\004\000\000\260\235\201\000\000\000\000\000\247\227\201"}, v2 = {sig = "\300\304\065\323\004\000\000\000\000\000\000", ver_cmd = 0 '\000', fam = 0 '\000', len = 0, addr = {ip4 = {src_addr = 3466123512, dst_addr = 4, src_port = 43380, dst_port = 133}, ip6 = {src_addr = "\370ؘ\316\004\000\000\000t\251\205\000\000\000\000", dst_addr = "\320[j\264\375\177\000\000\004\331m\000\000\000\000", src_port = 23504, dst_port = 46186}, unx = {src_addr = "\370ؘ\316\004\000\000\000t\251\205\000\000\000\000\000\320[j\264\375\177\000\000\004\331m\000\000\000\000\000\320[j\264\375\177\000\000\306\331m\000\000\000\000\000\b\342u\316\a\177\000\000\000\020\346\315\a\177\000\000\367b\201\000\000\000\000\000y\251\205\000n\004\000\000\260\235\201\000\000\000\000\000\247\227\201\000\000\000\000\000\240C\000\000\000\000\000\000\000\020\346", <incomplete sequence \315>, dst_addr = "\a\177\000\000PB\226\316\a\177\000\000\000\020\346\315\a\177\000\000\274\332\366\312\a\177\000\000Ȧ\351͗\002\000\000\240\370\366\312\a\177\000\000S\342\366\312\a\177\000\000@\342u\316\a\177\000\000\000\000\000\000\000\000P\225\001\000\000\000\000\000\000\000\003\000\000\000\001\b\000\000\300[j\264\375\177\000\000R\031Q\000\000\000\000\000hV\313\322\a\177\000"}}}} __func__ = "tcpconn_read_haproxy" #2 0x0000000000529cc8 in tcpconn_new (sock=58, su=0x7ffdb46a5e00, local_addr=0x7f07d2cb5668, ba=0x7f07d2cb5610, type=2, state=3) at core/tcp_main.c:1164 c = 0x7f07ce98d930 rd_b_size = 16384 ret = 32519 __func__ = "tcpconn_new" #3 0x000000000055194e in handle_new_connect (si=0x7f07d2cb5610) at core/tcp_main.c:4259 su = {s = {sa_family = 2, sa_data = ",\347\317\364n\357\000\000\000\000\000\000\000"}, sin = {sin_family = 2, sin_port = 59180, sin_addr = {s_addr = 4017026255}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 2, sin6_port = 59180, sin6_flowinfo = 4017026255, sin6_addr = {__in6_u = {__u6_addr8 = "\000\000\000\000\000\000\000\000h\360~\000\000\000\000", __u6_addr16 = {0, 0, 0, 0, 61544, 126, 0, 0}, __u6_addr32 = {0, 0, 8319080, 0}}}, sin6_scope_id = 67108864}, sas = {ss_family = 2, __ss_padding = ",\347\317\364n\357\000\000\000\000\000\000\000\000h\360~\000\000\000\000\000\000\000\000\004\000\000\000\000\360^j\264\375\177\000\000\023FU\000\000\000\000\000\230_\226\316\a\177\000\000\300\225\264\000\000\000\000\000\377\377\377\377\001\000\000\000\060٘\316\a\177\000\000\060٘\316\a\177\000\000\377\377\377\377\377\377\377\377\220^j\264\375\177\000\000\000\000\000\000\000\000\000\000\300\304\065\323\a\177\000", __ss_align = 8235966803625406752}} sock_name = {s = {sa_family = 23984, sa_data = "j\264\375\177\000\000\376\023Q\000\000\000\000"}, sin = {sin_family = 23984, sin_port = 46186, sin_addr = {s_addr = 32765}, sin_zero = "\376\023Q\000\000\000\000"}, sin6 = {sin6_family = 23984, sin6_port = 46186, sin6_flowinfo = 32765, sin6_addr = {__in6_u = {__u6_addr8 = "\376\023Q\000\000\000\000\000\310ژ\316\a\177\000", __u6_addr16 = {5118, 81, 0, 0, 56008, 52888, 32519, 0}, __u6_addr32 = {5313534, 0, 3466123976, 32519}}}, sin6_scope_id = 3454980136}, sas = {ss_family = 23984, __ss_padding = "j\264\375\177\000\000\376\023Q\000\000\000\000\000\310ژ\316\a\177\000\000(\320\356\315\a\177\000\000\030\"\202\000_\376\377\377\000\000\000\000\000\000\000\000\300\304\065\323\a\177\000\000\363:\204\000\000\000\000\000h\360~\000\000\000\000\000\000\000\000\004\000\000\000\000\360^j\264\375\177\000\000\245\222T\000\000\000\000\000\250\376\314\322\002\000\000\000\000\000\000\000\002\000\000\000Dc\201\000\241\001\000", __ss_align = 0}} sock_name_len = 32519 dst_su = 0x7f07d2cb5668 tcpconn = 0xffffffffce98d930 su_len = 16 new_sock = 58 __func__ = "handle_new_connect" #4 0x0000000000554aac in handle_io (fm=0x7f07d2ccfa40, ev=1, idx=-1) at core/tcp_main.c:4517 ret = 16 __func__ = "handle_io" #5 0x000000000051c992 in io_wait_loop_epoll (h=0xaf4760 <io_h>, t=5, repeat=0) at core/io_wait.h:1070 n = 1 r = 0 fm = 0x7f07d2ccfa40 revents = 1 __func__ = "io_wait_loop_epoll" #6 0x000000000055800f in tcp_main_loop () at core/tcp_main.c:4808 si = 0x0 r = 8 __func__ = "tcp_main_loop" #7 0x000000000042ca0b in main_loop () at main.c:1788 i = 8 pid = 0 si = 0x0 si_desc = "udp receiver child=7 sock=[2600:1f1c:6d5:aa03::7]:5060\000\061\063\062:5060)\000\000\000\000\060\000\000\000\370bj\264\375\177\000\000\020bj\264\375\177\000\000\000\334ѯ\344lFߨE\201\000\000\000\000\000\250\203\306\322k\000\000\000\363:\204\000\000\000\000\000\270o\305\322\a\177\000" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #8 0x0000000000435d95 in main (argc=11, argv=0x7ffdb46a6828) at main.c:2895 cfg_stream = 0x156b2a0 c = -1 r = 0 tmp = 0x7ffdb46a6ee3 "" tmp_len = 0 port = 0 proto = 0 ahost = 0x0 aport = 0 options = 0x7f1e48 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 2702569434 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 n_lst = 0x7ffdb46d4268 p = 0x7f07d3309db5 <handle_intel.constprop+197> "H\205\300uf\213t$\004M\215\216\244" st = {st_dev = 24, st_ino = 19244, st_nlink = 2, st_mode = 16832, st_uid = 985, st_gid = 979, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1613817804, tv_nsec = 114998890}, st_mtim = {tv_sec = 1614768566, tv_nsec = 7667804}, st_ctim = {tv_sec = 1614768566, tv_nsec = 7667804}, __glibc_reserved = {0, 0, 0}} tbuf = '\000' <repeats 16 times>, "\214\344'\323\a\177\000\000\330Am\264\375\177\000\000\000\000\000\000 ", '\000' <repeats 19 times>, "X_\376\323\a\177\000\000\000ej\264\375\177\000\000\a\000\000\000\000\000\000\000\020U\376\323\a\177\000\000\a\000\000\000\t\000\000\000\210\351 \324\a\177\000\000\034\021\377\323\a\177\000\000\000\000\000\000\000\000\000\000H\037\377\323\a\177\000\000Pdj\264\375\177\000\000\260\344'\323\a\177\000\000\300\363\037\324\a\177\000\000\000\000\000\000\000\000\000\000\320dj\264\375\177", '\000' <repeats 26 times>, "\200W\376\323\a\177\000\000"... option_index = 12 long_options = {{name = 0x7f4056 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x7ef4e1 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x7f405b "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x7f4061 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x7f4067 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x7f4070 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x7f407a "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x7f4084 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x7f408f "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x7f4098 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x7f40a3 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x7f40a9 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x7f40b3 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" ``` We use enabled haproxy protocol. Loos as Kamailio does not properly close the socket when the socket closed on the client-side. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@sbc-13 ~]# kamailio -v version: kamailio 5.5.0-dev4 (x86_64/linux) 06656a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 06656a compiled on 04:01:58 Mar 1 2021 with gcc 8.3.1 ``` * **Operating System**: ``` [root@sbc-13 ~]# cat /etc/os-release NAME="CentOS Linux" VERSION="8" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="8" PLATFORM_ID="platform:el8" PRETTY_NAME="CentOS Linux 8" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:8" HOME_URL="https://centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-8" CENTOS_MANTISBT_PROJECT_VERSION="8" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2658

3 9

git:master:795a0907: db_unixodbc: catch queries without result to skip printing error logs
by Daniel-Constantin Mierla 13 Jan '22

13 Jan '22

Module: kamailio Branch: master Commit: 795a09077ccc5dd06f9074978dc77dd81389512b URL: https://github.com/kamailio/kamailio/commit/795a09077ccc5dd06f9074978dc77dd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-13T16:49:33+01:00 db_unixodbc: catch queries without result to skip printing error logs - GH #2810 --- Modified: src/modules/db_unixodbc/dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/795a09077ccc5dd06f9074978dc77dd… Patch: https://github.com/kamailio/kamailio/commit/795a09077ccc5dd06f9074978dc77dd… --- diff --git a/src/modules/db_unixodbc/dbase.c b/src/modules/db_unixodbc/dbase.c index f2e1a3b12e..bbbb6e2d38 100644 --- a/src/modules/db_unixodbc/dbase.c +++ b/src/modules/db_unixodbc/dbase.c @@ -252,6 +252,8 @@ void db_unixodbc_close(db1_con_t* _h) */ static int db_unixodbc_store_result(const db1_con_t* _h, db1_res_t** _r) { + SQLSMALLINT cols = 0; + if ((!_h) || (!_r)) { LM_ERR("invalid parameter value\n"); @@ -266,6 +268,14 @@ static int db_unixodbc_store_result(const db1_con_t* _h, db1_res_t** _r) return -2; } + SQLNumResultCols(CON_RESULT(_h), &cols); + if(cols==0) { + /* no result */ + (*_r)->col.n = 0; + (*_r)->n = 0; + return 0; + } + if (db_unixodbc_convert_result(_h, *_r) < 0) { LM_ERR("failed to convert result\n");

1 0

git:master:0ed12822: tm: update uri when refreshing local uac shortcuts
by Daniel-Constantin Mierla 13 Jan '22

13 Jan '22

Module: kamailio Branch: master Commit: 0ed1282238da6cdd8a4dbef1b61493b70a850a6b URL: https://github.com/kamailio/kamailio/commit/0ed1282238da6cdd8a4dbef1b61493b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-13T13:49:46+01:00 tm: update uri when refreshing local uac shortcuts --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/0ed1282238da6cdd8a4dbef1b61493b… Patch: https://github.com/kamailio/kamailio/commit/0ed1282238da6cdd8a4dbef1b61493b… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index 9cbc9d5f88..7dfcefb6ea 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -160,9 +160,9 @@ static inline unsigned int dlg2hash( dlg_t* dlg ) } /** - * refresh hdr shortcuts inside new buffer + * refresh r-uri and hdr shortcuts inside new buffer */ -int uac_refresh_hdr_shortcuts(tm_cell_t *tcell, char *buf, int buf_len) +int uac_refresh_shortcuts(tm_cell_t *tcell, int branch, char *buf, int buf_len) { sip_msg_t lreq; struct cseq_body *cs; @@ -175,6 +175,7 @@ int uac_refresh_hdr_shortcuts(tm_cell_t *tcell, char *buf, int buf_len) LM_ERR("failed to parse headers in new message\n"); goto error; } + tcell->uac[branch].uri = *GET_RURI(&lreq); tcell->from.s = lreq.from->name.s; tcell->from.len = lreq.from->len; tcell->to.s = lreq.to->name.s; @@ -541,7 +542,7 @@ static inline int t_uac_prepare(uac_req_t *uac_r, if (unlikely(refresh_shortcuts==E_DROP)) { ret=E_DROP; goto error1; - } + } } #endif @@ -576,7 +577,7 @@ static inline int t_uac_prepare(uac_req_t *uac_r, request->buffer = buf; request->buffer_len = buf_len; if(unlikely(refresh_shortcuts==1)) { - if(uac_refresh_hdr_shortcuts(new_cell, buf, buf_len)<0) { + if(uac_refresh_shortcuts(new_cell, 0, buf, buf_len)<0) { LM_ERR("failed to refresh header shortcuts\n"); goto error1; }

1 0

git:master:55d185de: dispatcher: reworked management of ping reply codes and classes
by Daniel-Constantin Mierla 13 Jan '22

13 Jan '22

Module: kamailio Branch: master Commit: 55d185de535503ab860c0475e07d2d4af64f3ab0 URL: https://github.com/kamailio/kamailio/commit/55d185de535503ab860c0475e07d2d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-13T12:16:14+01:00 dispatcher: reworked management of ping reply codes and classes - do not generate all the 100 replies code for a class, but compare to be in in the range --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/55d185de535503ab860c0475e07d2d4… Patch: https://github.com/kamailio/kamailio/commit/55d185de535503ab860c0475e07d2d4…

1 0

git:master:29ebde9c: dispatcher: removed module name from log message
by Daniel-Constantin Mierla 13 Jan '22

13 Jan '22

Module: kamailio Branch: master Commit: 29ebde9cfe746c1dd9083a5fc4b26a32c39ca0a4 URL: https://github.com/kamailio/kamailio/commit/29ebde9cfe746c1dd9083a5fc4b26a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-13T10:37:46+01:00 dispatcher: removed module name from log message - updates to debug messages --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/29ebde9cfe746c1dd9083a5fc4b26a3… Patch: https://github.com/kamailio/kamailio/commit/29ebde9cfe746c1dd9083a5fc4b26a3… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index fbf65d33fe..216a04f297 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1151,7 +1151,7 @@ static int ds_parse_reply_codes() list_size += 100; } } - LM_DBG("Should be %d Destinations.\n", list_size); + LM_DBG("expecting %d reply codes\n", list_size); if(list_size > 0) { /* Allocate Memory for the new list: */ @@ -1206,7 +1206,7 @@ static int ds_parse_reply_codes() } /* Print the list as INFO: */ for(i = 0; i < *ds_ping_reply_codes_cnt; i++) { - LM_DBG("Dispatcher: Now accepting Reply-Code %d (%d/%d) as valid\n", + LM_DBG("now accepting reply code %d (%d/%d) as valid\n", (*ds_ping_reply_codes)[i], (i + 1), *ds_ping_reply_codes_cnt); } return 0;

1 0

[kamailio/kamailio] Adding listen flag to ignore matches in grep_sock_info when an IP is not active locally (Issue #2984)
by rhys-hanrahan 12 Jan '22

12 Jan '22

### Description As per my thread on sr-users: **Active/active keepalived - Kamailio includes non-local virtual IP in "myself" which breaks DMQ call routing**, I am seeing issues due to the behavior of `check_self` and more specifically `grep_sock_info`. I have attached a patch with a proposed new feature that would allow changing this behaviour slightly, although I've avoided changing any default behaviour. I have a setup with keepalived in active/active mode, with two virtual IPs. The goal is that each VIP is active only one one node at a time, but in the event of a failure, both VIPs would become active on one node. The issue I am facing is that in order for this to work, I need to have both nodes listen on both virtual IPs at all times, but this means that both nodes always consider traffic to those IPs local to themselves, even when that is not the case. This breaks many things, basically anything with `uri == myself`. But even internally in Kamailio itself, this is causing problems. For example: PATH support is broken and this is not easily fixed in the config because `lookup()` is actually using `check_self()` internally. I am sure there are many other features which will not work right in the above scenario, and this is why I'm proposing a change in the code itself, instead of just trying to solve it in the config. I've attached a patch file with my proposed change and would appreciate any feedback as to my overall approach. If this seems OK then I will put together a pull request for your review. Thanks! ### Expected behavior Kamailio should detect what IP addresses are currently active locally on it's system before considering the socket a match. If the IP is not currently there, it should ignore the match as if it is not currently listening on this IP (because it really is not!) #### Actual observed behavior Right now, Kamailio looks blindly at all "listen" sockets and looks for a match, regardless of if that IP is currently active locally or not, and this causes the false results of `check_self` ### Possible Solutions As mentioned, I'm attaching a patch showing my overall approach. Basically: * I am using pre-existing functions as much as possible for best compatibility e.g. IPv6 and IPv4. * I use `dns_resolvehost()` which seems to have a caching function built-in and so I am hoping the performance impact of my change would be negligible. * My code only makes a change _if_ the virtual flag is set, and if not, existing behaviour is kept so as to avoid any breaking changes. [RT59671-kamailio-add-listen-virtual-check2.patch.txt](https://github.com/ka… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2984 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2984(a)github.com>

3 3

[kamailio/kamailio] integer overflow in 'core.shmmem' output (#2824)
by Julius Flohr 12 Jan '22

12 Jan '22

Hi, we are using kamailio with more than 4GB of shared memory. When using 'core.shmem' we are expierencing an integer overflow in the output. The issue can be found here: https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fc… I currently don't have the time to setup a build environment so I can't fix it myself. cheers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2824

3 3

git:master:f619cae5: corex: rpc shm stats values printed as unsigned long
by Daniel-Constantin Mierla 12 Jan '22

12 Jan '22

Module: kamailio Branch: master Commit: f619cae55ffeb4596da852d9ed75773c3217de50 URL: https://github.com/kamailio/kamailio/commit/f619cae55ffeb4596da852d9ed75773… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-12T17:03:58+01:00 corex: rpc shm stats values printed as unsigned long - GH #2824 --- Modified: src/modules/corex/corex_rpc_shm.c --- Diff: https://github.com/kamailio/kamailio/commit/f619cae55ffeb4596da852d9ed75773… Patch: https://github.com/kamailio/kamailio/commit/f619cae55ffeb4596da852d9ed75773… --- diff --git a/src/modules/corex/corex_rpc_shm.c b/src/modules/corex/corex_rpc_shm.c index 7bf10553dd..615fb892bc 100644 --- a/src/modules/corex/corex_rpc_shm.c +++ b/src/modules/corex/corex_rpc_shm.c @@ -46,9 +46,9 @@ static void corex_rpc_shm_info(rpc_t* rpc, void* ctx) rpc->fault(ctx, 500, "Internal error creating rpc"); return; } - if(rpc->struct_add(th, "su", + if(rpc->struct_add(th, "sj", "name", (_shm_root.mname)?_shm_root.mname:"unknown", - "size", (unsigned int)shm_mem_size) <0) { + "size", shm_mem_size) <0) { rpc->fault(ctx, 500, "Internal error adding fields"); return; } @@ -69,13 +69,13 @@ static void corex_rpc_shm_stats(rpc_t* rpc, void* c) shm_info(&mi); rpc->add(c, "{", &th); - rpc->struct_add(th, "uuuuuu", - "total", (unsigned int)(mi.total_size), - "free", (unsigned int)(mi.free), - "used", (unsigned int)(mi.used), - "real_used",(unsigned int)(mi.real_used), - "max_used", (unsigned int)(mi.max_used), - "fragments", (unsigned int)mi.total_frags + rpc->struct_add(th, "jjjjjj", + "total", mi.total_size, + "free", mi.free, + "used", mi.used, + "real_used", mi.real_used, + "max_used", mi.max_used, + "fragments", mi.total_frags ); }

1 0

git:master:3a11426b: kamcmd: double/float values printed without decimals when they are 0
by Daniel-Constantin Mierla 12 Jan '22

12 Jan '22

Module: kamailio Branch: master Commit: 3a11426bdf0a4a458f2531689110fee84451da88 URL: https://github.com/kamailio/kamailio/commit/3a11426bdf0a4a458f2531689110fee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-12T17:05:21+01:00 kamcmd: double/float values printed without decimals when they are 0 - cope better with long (long) values stored in double fields --- Modified: utils/kamcmd/kamcmd.c --- Diff: https://github.com/kamailio/kamailio/commit/3a11426bdf0a4a458f2531689110fee… Patch: https://github.com/kamailio/kamailio/commit/3a11426bdf0a4a458f2531689110fee… --- diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c index f1cbc24d68..141f309aaf 100644 --- a/utils/kamcmd/kamcmd.c +++ b/utils/kamcmd/kamcmd.c @@ -427,7 +427,11 @@ void print_binrpc_val(struct binrpc_val* v, int ident) printf("%c", (v->u.end)?'}':'{'); break; case BINRPC_T_DOUBLE: - printf("%f", v->u.fval); + if(v->u.fval == (double)((long long int)v->u.fval)) { + printf("%lld", (long long int)v->u.fval); + } else { + printf("%f", v->u.fval); + } break; default: printf("ERROR: unknown type %d\n", v->type);

1 0

git:master:7162dc0a: ctl: float/double values are stored over a long long int instead of int
by Daniel-Constantin Mierla 12 Jan '22

12 Jan '22

Module: kamailio Branch: master Commit: 7162dc0a7368f61e3b32231a2ad00e72ee29d82e URL: https://github.com/kamailio/kamailio/commit/7162dc0a7368f61e3b32231a2ad00e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-12T17:02:11+01:00 ctl: float/double values are stored over a long long int instead of int - cope with larger values than MAX_INT/1000, supporint now up to MAX_LLONG/1000 --- Modified: src/modules/ctl/binrpc.h --- Diff: https://github.com/kamailio/kamailio/commit/7162dc0a7368f61e3b32231a2ad00e7… Patch: https://github.com/kamailio/kamailio/commit/7162dc0a7368f61e3b32231a2ad00e7… --- diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h index cb7204fffd..bb34cd3be5 100644 --- a/src/modules/ctl/binrpc.h +++ b/src/modules/ctl/binrpc.h @@ -205,6 +205,31 @@ inline static int binrpc_add_tag(struct binrpc_pkt* pkt, int type, int end) +/* writes a minimal long long, returns the new offset and sets + * len to the number of bytes written (<=8) + * to check for oveflow use: returned_value-p != *len + * (Note: if *len==0 using the test above succeeds even if p>=end) + */ +inline static unsigned char* binrpc_write_llong( unsigned char* p, + unsigned char* end, + long long i, int *len) +{ + int size; + unsigned long long u; + + u = (unsigned long long)i; + + for (size=8; size && ((u & (0xffull<<56))==0); u<<=8, size--); + *len=size; + for(; (p<end) && (size); p++, size--){ + *p=(unsigned char)(u>>56); + u<<=8; + } + return p; +} + + + /* writes a minimal int, returns the new offset and sets * len to the number of bytes written (<=4) * to check for oveflow use: returned_value-p != *len @@ -330,6 +355,23 @@ inline static int binrpc_hdr_change_len(unsigned char* hdr, int hdr_len, } +/* int format: size TYPE <val> */ +inline static int binrpc_add_llong_type(struct binrpc_pkt* pkt, long long i, int type) +{ + + unsigned char* p; + int size; + + p=binrpc_write_llong(pkt->crt+1, pkt->end, i, &size); + if ((pkt->crt>=pkt->end) || ((int)(p-pkt->crt-1)!=size)) + goto error_len; + *(pkt->crt)=(size<<4) | type; + pkt->crt=p; + return 0; +error_len: + return E_BINRPC_OVERFLOW; +} + /* int format: size BINRPC_T_INT <val> */ inline static int binrpc_add_int_type(struct binrpc_pkt* pkt, int i, int type) @@ -351,9 +393,9 @@ inline static int binrpc_add_int_type(struct binrpc_pkt* pkt, int i, int type) /* double format: FIXME: for now a hack: fixed point represented in - * an int (=> max 3 decimals, < MAX_INT/1000) */ + * a long long (=> max 3 decimals, < MAX_LLONG/1000) */ #define binrpc_add_double_type(pkt, f, type)\ - binrpc_add_int_type((pkt), (int)((f)*1000), (type)) + binrpc_add_llong_type((pkt), (long long)((f)*1000), (type)) @@ -516,6 +558,35 @@ static inline int binrpc_addfault( struct binrpc_pkt* pkt, /* parsing incoming messages */ +static inline unsigned char* binrpc_read_llong( long long* i, + int len, + unsigned char* s, + unsigned char* end, + int *err + ) +{ + unsigned char* start; + unsigned long long u; + + start=s; + *i=0; + u = 0; + *err=0; + for(;len>0; len--, s++){ + if (s>=end){ + *err=E_BINRPC_MORE_DATA; + *i = (long long)u; + return start; + } + u<<=8; + u|=*s; + }; + *i = (long long)u; + return s; +} + + + static inline unsigned char* binrpc_read_int( int* i, int len, unsigned char* s, @@ -638,8 +709,8 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, int end_tag; int tmp; unsigned char* p; - int i; - + long long ll; + p=buf; end_tag=0; *err=0; @@ -758,10 +829,10 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, } break; case BINRPC_T_DOUBLE: /* FIXME: hack: represented as fixed point - inside an int */ + inside an long long */ if (ctx->in_struct && smode==0) goto error_record; - p=binrpc_read_int(&i, len, p, end, err); - v->u.fval=((double)i)/1000; + p=binrpc_read_llong(&ll, len, p, end, err); + v->u.fval=((double)ll)/1000; break; default: if (ctx->in_struct){

1 0

[kamailio/kamailio] SEGV on unknown address (Issue #2993)
by taotao gu 12 Jan '22

12 Jan '22

Linux x1-1 5.11.0-43-generic #47~20.04.2-Ubuntu SMP Mon Dec 13 11:06:56 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux poc [https://github.com/gtt1995/poc/blob/main/kamailio/148907.testcase](https://… AddressSanitizer:DEADLYSIGNAL ================================================================= ==2350==ERROR: AddressSanitizer: SEGV on unknown address 0x608000010000 (pc 0x7f8ec09469c3 bp 0x7ffd84505c90 sp 0x7ffd84505718 T0) ==2350==The signal is caused by a READ memory access. SCARINESS: 20 (wild-addr-read) #0 0x7f8ec09469c3 in libc.so.6 #1 0x7f8ec0835209 in libc.so.6 #2 0x7f8ec08d5f32 in libc.so.6 #3 0x7f8ec08d63e9 in syslog #4 0x64a045 in parse_identityinfo /src/kamailio/src/core/parser/parse_identityinfo.c:315:3 #5 0x64b29b in parse_identityinfo_header /src/kamailio/src/core/parser/parse_identityinfo.c:346:2 #6 0x576467 in LLVMFuzzerTestOneInput /src/kamailio/misc/fuzz/fuzz_parse_msg.c:53:5 #7 0x456e73 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) cxa_noexception.cpp:0 #8 0x45665a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) cxa_noexception.cpp:0 #9 0x457efb in fuzzer::Fuzzer::MutateAndTestOne() cxa_noexception.cpp:0 #10 0x4589e5 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) cxa_noexception.cpp:0 #11 0x44812d in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) cxa_noexception.cpp:0 #12 0x471172 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10 #13 0x7f8ec07e20b2 in __libc_start_main #14 0x41fa0d in _start AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0x18b9c3) ==2350==ABORTING MS: 3 ChangeBinInt-ShuffleBytes-EraseBytes-; base unit: ae3912c98bceb907c57e00fbcb572ff78ca2f12c 0x2d,0x2d,0x32,0x32,0x52,0x52,0x41,0x52,0xec,0x53,0x52,0x52,0x20,0x73,0x2d,0x34,0x38,0x39,0x31,0x36,0x9,0x48,0x48,0x48,0x1a,0xa,0x50,0x72,0x69,0x76,0x61,0x63,0x79,0x3a,0xa,0x20,0x73,0x32,0xa,0x49,0x64,0x65,0x6e,0x74,0x69,0x74,0x79,0x2d,0x49,0x6e,0x66,0x6f,0x3a,0x3c,0x3a,0x3a,0x3a,0x3a,0xff,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xea,0xa,0xa,0xff,0xff,0xff,0xff,0xff, --22RRAR\354SRR s-48916\011HHH\032\012Privacy:\012 s2\012Identity-Info:<::::\377\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\352\012\012\377\377\377\377\377 artifact_prefix='/clusterfuzz/run_bot/clusterfuzz/bot/inputs/fuzzer-testcases/'; Test unit written to /clusterfuzz/run_bot/clusterfuzz/bot/inputs/fuzzer-testcases/crash-9886d78e9acf21b875f4e58d2d14222a4ed1e86f Base64: LS0yMlJSQVLsU1JSIHMtNDg5MTYJSEhIGgpQcml2YWN5OgogczIKSWRlbnRpdHktSW5mbzo8Ojo6Ov/q6urq6urq6urq6urq6urq6urq6goK//////8= stat::number_of_executed_units: 14639 stat::average_exec_per_sec: 1219 stat::new_units_added: 1293 stat::slowest_unit_time_sec: 0 stat::peak_rss_mb: 142 INFO: exiting: 77 time: 85s +----------------------------------------Release Build Unsymbolized Stacktrace (diff)----------------------------------------+ ==2350==The signal is caused by a READ memory access. SCARINESS: 20 (wild-addr-read) #0 0x7f8ec09469c3 (/lib/x86_64-linux-gnu/libc.so.6+0x18b9c3) #1 0x7f8ec0835209 (/lib/x86_64-linux-gnu/libc.so.6+0x7a209) #2 0x7f8ec08d5f32 (/lib/x86_64-linux-gnu/libc.so.6+0x11af32) #3 0x7f8ec08d63e9 (/lib/x86_64-linux-gnu/libc.so.6+0x11b3e9) #4 0x64a045 (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x64a045) #5 0x64b29b (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x64b29b) #6 0x576467 (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x576467) #7 0x456e73 (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x456e73) #8 0x45665a (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x45665a) #9 0x457efb (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x457efb) #10 0x4589e5 (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x4589e5) #11 0x44812d (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x44812d) #12 0x471172 (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x471172) #13 0x7f8ec07e20b2 (/lib/x86_64-linux-gnu/libc.so.6+0x270b2) #14 0x41fa0d (/clusterfuzz/run_bot/clusterfuzz/bot/builds/kamailio_libfuzzer_asan/custom/fuzz_parse_msg+0x41fa0d) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2993 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2993(a)github.com>

3 3

git:master:40e59d9c: core: parser - print ascii code and position of invalid char for identity info
by Daniel-Constantin Mierla 12 Jan '22

12 Jan '22

Module: kamailio Branch: master Commit: 40e59d9c3b8ec531cb9e26093c43647a43108dfd URL: https://github.com/kamailio/kamailio/commit/40e59d9c3b8ec531cb9e26093c43647… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-12T14:12:42+01:00 core: parser - print ascii code and position of invalid char for identity info --- Modified: src/core/parser/parse_identityinfo.c --- Diff: https://github.com/kamailio/kamailio/commit/40e59d9c3b8ec531cb9e26093c43647… Patch: https://github.com/kamailio/kamailio/commit/40e59d9c3b8ec531cb9e26093c43647… --- diff --git a/src/core/parser/parse_identityinfo.c b/src/core/parser/parse_identityinfo.c index 7afd473f23..dc0aba5d9b 100644 --- a/src/core/parser/parse_identityinfo.c +++ b/src/core/parser/parse_identityinfo.c @@ -311,8 +311,8 @@ void parse_identityinfo(char *buffer, char *end, struct identityinfo_body *ii_b) parseerror: if(p < end) { - LM_ERR("unexpected char [%c] in status %d: [%.*s]\n", *p, status, - (int)(p - buffer), buffer); + LM_ERR("unexpected char [%c/%d] in status %d - pos %d: [%.*s]\n", *p, *p, + status, (int)(p - buffer), (int)(p - buffer), buffer); } else { LM_ERR("unexpected end of buffer - status %d\n", status); }

1 0

[kamailio/kamailio] module_db_mysql: Allow '@' in username/password for db_url URIs (#1346)
by Florian Floimair 12 Jan '22

12 Jan '22

#### Pre-Submission Checklist    - [x ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - It is allowed to use '@' within a username and/or a password for MySQL. Database as a Service providers like e.g. Microsoft Azure use these in usernames by default. The existing URI parser always treated the '@' as a separator between username:password and host:port/db parts of the URI. The parser now checks how many '@' characters are present in the URI and only treats the last occurence as separator for the host:port/db part. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1346 -- Commit Summary -- * module_db_mysql: Allow '@' in username/password for db_url URIs -- File Changes -- M src/modules/db_mysql/my_uri.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1346.patch https://github.com/kamailio/kamailio/pull/1346.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1346

2 4

Wiki edit access
by Rhys Hanrahan 12 Jan '22

12 Jan '22

Hi All, I’m trying to update the cookbook to document PR #2985, but it looks like I need edit access on the wiki? My username is “rhys”. Can someone give me access? Thanks! Rhys Hanrahan | Chief Information Officer e: rhys(a)nexusone.com.au<mailto:rhys@nexusone.com.au> [www.nexusone.com.au]<http://www.nexusone.com.au/> [signature_214001646] <http://www.fusiontech.com.au/> NEXUS ONE | FUSION TECHNOLOGY SOLUTIONS p: 1800 NEXUS1 (1800 639 871) or 1800 565 845 | a: Suite 12.03 Level 12, 227 Elizabeth Street, Sydney NSW 2000 www.nexusone.com.au<http://www.nexusone.com.au/> | www.fusiontech.com.au<http://www.fusiontech.com.au/> The information in this email and any accompanying attachments may contain; a. Confidential information of Fusion Technology Solutions Pty Ltd, Nexus One Pty Ltd or third parties; b. Legally privileged information of Fusion Technology Solutions Pty Ltd, Nexus One Pty Ltd or third parties; and or c. Copyright material Fusion Technology Solutions Pty Ltd, Nexus One Pty Ltd or third parties. If you have received this email in error, please notify the sender immediately and delete this message. Fusion Technology Solutions Pty Ltd, Nexus One Pty Ltd does not accept any responsibility for loss or damage arising from the use or distribution of this email. Please consider the environment before printing this email.

2 1

git:master:c818e163: presence: small spelling fix in XML entity ID
by Henning Westerholt 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: c818e16367ff997ecb059141f4752d6e8ba6136f URL: https://github.com/kamailio/kamailio/commit/c818e16367ff997ecb059141f4752d6… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-01-11T15:10:50Z presence: small spelling fix in XML entity ID --- Modified: src/modules/presence/doc/presence_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c818e16367ff997ecb059141f4752d6… Patch: https://github.com/kamailio/kamailio/commit/c818e16367ff997ecb059141f4752d6… --- diff --git a/src/modules/presence/doc/presence_admin.xml b/src/modules/presence/doc/presence_admin.xml index 25e43ef0b6..7e425105aa 100644 --- a/src/modules/presence/doc/presence_admin.xml +++ b/src/modules/presence/doc/presence_admin.xml @@ -1229,7 +1229,7 @@ pres_refresh_watchers("sip:test@kamailio.org", "presence", 1); </example> </section> - <section id="presence.f.pres_update_whatchers"> + <section id="presence.f.pres_update_watchers"> <title> <function moreinfo="none">pres_update_watchers(uri, event)</function> </title>

1 0

git:master:6ba9249e: evapi: small spelling fix in comment
by Henning Westerholt 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 6ba9249e49e5eafe164beae46996161a3950def4 URL: https://github.com/kamailio/kamailio/commit/6ba9249e49e5eafe164beae46996161… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-01-11T15:10:30Z evapi: small spelling fix in comment --- Modified: src/modules/evapi/evapi_dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/6ba9249e49e5eafe164beae46996161… Patch: https://github.com/kamailio/kamailio/commit/6ba9249e49e5eafe164beae46996161… --- diff --git a/src/modules/evapi/evapi_dispatch.c b/src/modules/evapi/evapi_dispatch.c index 1b8bff4402..6249fc869a 100644 --- a/src/modules/evapi/evapi_dispatch.c +++ b/src/modules/evapi/evapi_dispatch.c @@ -578,7 +578,7 @@ void evapi_accept_client(struct ev_loop *loop, struct ev_io *watcher, int revent return; } - /* start watcher to read messages from whatchers */ + /* start watcher to read messages from watchers */ ev_io_init(evapi_client, evapi_recv_client, csock, EV_READ); ev_io_start(loop, evapi_client); }

1 0

[kamailio/kamailio] hostname in kubernetes (#2119)
by lazedo 11 Jan '22

11 Jan '22

### Description gethostname not accurate in kubernetes  ### Troubleshooting #### Reproduction  on a recent test with kamailio in kubernetes, found that gethostname can return only the hostname and not the fqdn. this depends on the kind of object is used (deployment/statefulset) ### Possible Solutions  the below patch fixed the issues i was having ``` diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c index 5f77aa9..f65b4dd 100644 --- a/src/modules/ipops/ipops_pv.c +++ b/src/modules/ipops/ipops_pv.c @@ -455,6 +455,11 @@ if (gethostname(hbuf, 512)<0) { LM_WARN("gethostname failed - host pvs will be null\n"); return -1; + } else { + struct hostent* h; + if((h = gethostbyname(hbuf)) != NULL) { + memcpy(hbuf, h->h_name, 512); + } } hlen = strlen(hbuf); ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` latest master ``` * **Operating System**:  ``` buster & centos7 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2119

4 10

[kamailio/kamailio] erlang: getting null value in erl_xbuff in response of erl_rpc request (#2069)
by vipulpatel310 11 Jan '22

11 Jan '22

### Description **I did:** I have installed kamailio 5.2.4 in ubuntu system and configured kamailio script to connect with erlang node also it sends rpc request to erlang node and get response which I have printed in a logs. ... $erl_list(L) = "two"; $erl_list(L) = "one"; xlog("L_ALERT","Before RPC: $erl_list(args=>format)\n"); erl_rpc("erlang", "list_to_tuple", "$erl_list(args)", "$erl_xbuff(repl)"); xlogl("L_ALERT","type(reply): $erl_xbuff(repl=>type), format(repl): $erl_xbuff(repl=>format)\n"); ... **Expected to happen:** Response should be get from erlang node against RPC request and it should be store in erl_xbuff. And it should be print logs like: ALERT: <script>: 501:type(reply): tuple, format(repl): {"one", "two"} **Actually happened:** Response is getting properly. but the problem is to store data into xbuff so it print logs like: ALERT: <script>: 501:type(reply): <null>, format(repl): <null> ### Troubleshooting I have check with older version 4.3.0 and it works fine. getting this problem after 5.2.0 version So, I have compare 5.2.0 and 4.3.0 version code. I found one change in pv_xbuff.c file which is creating a problem when I revert the change then it works fine. #### Reproduction It will be reproducible everytime. Just sends rpc request and get the value in xbuff. check xbuff value #### Log Messages Problem logs: ``` ALERT: <script>: Before RPC: [["one", "two"]] WARNING: <core> [core/mem/q_malloc.c:480]: qm_free(): WARNING: free(0) called from erlang: pv_xbuff.c: xavp_decode(1209) ALERT: <script>: 501:type(reply): <null>, format(repl): <null> ``` logs after change: ``` ALERT: <script>: Before RPC: [["one", "two"]] WARNING: <core> [core/mem/q_malloc.c:480]: qm_free(): WARNING: free(0) called from erlang: pv_xbuff.c: xavp_decode(1209) ALERT: <script>: 501:type(reply): tuple, format(repl): {"one", "two"} ``` ### Possible Solutions revert the 6542a367638ec5f8a2b62994f8c309e7a2533962 commit. It will work fine ### Additional Information ``` version: kamailio 5.2.4 (x86_64/linux) 759867 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 759867 compiled on 11:52:55 Sep 4 2019 with gcc 7.4.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 18.04 LTS Release: 18.04 Codename: bionic Linux hostname.domain.com 4.15.0-20-generic #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2069

2 3

[kamailio/kamailio] kamailio can't support send Rx_AAR for origin call (#1793)
by lsm808 11 Jan '22

11 Jan '22

Hi All, When kamailio(kamailio-5.0) receive 200 OK message, we need to send Rx_AAR for origin and term call. Rx_AAR("MT_aar_reply", "origin","",2); for origin call Rx_AAR("MT_aar_reply", "term","",2); for term call. But from source code ims_qos_mod.c, we see lots of part like below to not support for a request. Even we comments them, there are still lots of issues, could we support the scenarios like below: when kamailio receive 200 OK, we can send Rx_AAR for term and origin call. //We don't ever do AAR on request for calling scenario... if (msg->first_line.type != SIP_REPLY) { // Added by vlv // LM_DBG("Can't do AAR for call session in request\n"); // return result; } -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1793

2 4

[kamailio/kamailio] while passing different callid then actual for rtpengine_offer, rtpengine_answer and rtpengine_delete, rtpstats will not populate the stastics of rtpengine (#1788)
by Surendra Tiwari 11 Jan '22

11 Jan '22

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1788

2 4

[kamailio/kamailio] siptrace: option ping from nathelper do not get duplicated (#1722)
by Roman Dissauer 11 Jan '22

11 Jan '22

### Description when using kamailio with mod siptrace in trace mode, option pings from nathelper module and tls encrypted packets do not get duplicated ### Troubleshooting #### Reproduction  version: kamailio 5.1.6 (x86_64/linux) modparam("nathelper", "ping_nated_only", 0) modparam("siptrace", "trace_mode", 1) modparam("siptrace", "duplicate_uri", "sip:10.1.1.1:5888") when listening on sip:10.1.1.1:5888 all the duplicated sip packets arrive except option pings from nathelper and tls encrypted traffic (which should then be already decrypted by kamailio) ### Possible Solutions  seems that core triggers are not evaluated when using tls or nathelper option pings ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Linux AT1LKAM04 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1722

3 8

[kamailio/kamailio] evapi: if there is no evapi clients are connected to kamailio, evapi trying to send data. (#1700)
by Surendra Tiwari 11 Jan '22

11 Jan '22

### Description right now, evapi module trying to send data even if no clients are connected .in the case new transaction is created and even suspended also. kamailio should not create the transaction if no evapi client is connected to kamailio.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1700

2 3

[kamailio/kamailio] Feature request: Increase number of "custom fields" in sipcapture-module (#1278)
by mihovilkolaric 11 Jan '22

11 Jan '22

The module sipcapture provides the modparams "custom_field1_header" to "custom_field3_header", to store the content of up to three arbitrary header fields as separate columns in the database. They can be used as all other "standard" columns in homer. However I found out that searching/filtering for even more (standardized, as well as private) header fields would be very helpful (I identified about ten interesting additional headers, but the number is constantly increasing ;-) ). Could you thus please increase the number of custom fields? (I suppose the most flexible solution could be something as the db_extra in the acc-module, which is not fixed to certain columns (regarding number of columns, as well as their names) (see https://www.kamailio.org/docs/modules/5.0.x/modules/acc.html#acc.p.db_extra ).) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1278

2 2

[kamailio/kamailio] Diameter AVP handling from kamailio.cfg (#922)
by miricz 11 Jan '22

11 Jan '22

Below feature were discussed with Carsten Bock Currently Diameter AVP values and especially Experimental Result Code is not available from the kamailio.cfg Therefore I would like to request such kind of feature. I would like to use it mainly on Cx interface for Server-Assignment-Answer (SAA), Location-Info-Answer (LIA), Multimedia-Auth-Answer (MAA), Push-Profile-Answer (PPA) It should be implemented such a way like in the ims_charging module. Thank you very much in advance! _Cheers, Zoltan_ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/922

2 2

[kamailio] add socket activation support (#293)
by zabbal 11 Jan '22

11 Jan '22

Having (optional) support for socket activation in Kamailio would bring several benefits: * Security: systemd can listen on privileged ports or socket paths and start Kamailio with privileges already dropped. * Major upgrades or reconfigurations of Kamailio requiring a full restart are possible without having the listening socket(s) ever go away. * Any service dependent on Kamailio doesn't have to wait for it to finish starting (or start at all). --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/293

3 4

[kamailio/kamailio] pv needed to get access to X509v3 Subject Alternative Names of peer's SSL certificate (#707)
by juha-h 11 Jan '22

11 Jan '22

A sip proxy may serve many domains listed in its SSL certificate X509v3 Subject Alternative Name field. In order to find out if a peer sip proxy is serving a particular domain, access would be needed in config file to this list of domains. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/707

4 4

[kamailio/kamailio] dispatcher: Fix handling of inactive destination for alg 13 (PR #2964)
by mtryfoss 11 Jan '22

11 Jan '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Alg 13 did try to distribute calls to inactive destinations. If the highest priority destination is inactive, hash is not updated and the xavp is not set. This is resulting in failover mechanism not working at all for the given call. When the hash variable is not updated, it makes alg 13 behave like round robin if the scenario above occurs. If you got two destinations and the highest priority is out of service, 50% of the calls will fail. Now I tried a more simple approach updating hash with the first entry of the sorted list. Also fixed a typo in a variable name. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2964 -- Commit Summary -- * dispatcher: Fix handling of inactive destination for alg 13 -- File Changes -- M src/modules/dispatcher/dispatch.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2964.patch https://github.com/kamailio/kamailio/pull/2964.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2964

2 6

git:master:adba3caa: dispatcher: Fix handling of inactive destination for alg 13
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: adba3caa2d12d1f8b89d720fbb9a6a9cdc8b2573 URL: https://github.com/kamailio/kamailio/commit/adba3caa2d12d1f8b89d720fbb9a6a9… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T12:46:33+01:00 dispatcher: Fix handling of inactive destination for alg 13 Alg 13 did try to distribute calls to inactive destinations. If the highest priority destination is inactive, hash is not updated and the xavp is not set. This is resulting in failover mechanism not working at all for the given call. When the hash variable is not updated, it makes alg 13 behave like round robin if the scenario above occurs. If you got two destinations and the highest priority is out of service, 50% of the calls will fail. Now I tried a more simple approach updating hash with the first entry of the sorted list. --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/adba3caa2d12d1f8b89d720fbb9a6a9… Patch: https://github.com/kamailio/kamailio/commit/adba3caa2d12d1f8b89d720fbb9a6a9… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 26836433f1..fad6334fa4 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -2201,7 +2201,7 @@ int ds_manage_route_algo13(ds_set_t *idx, ds_select_state_t *rstate) { } for(y=0; y<idx->nr ;y++) { - int latency_proirity_handicap = 0; + int latency_priority_handicap = 0; ds_dest_t * ds_dest = &idx->dlist[z]; int gw_priority = ds_dest->priority; int gw_latency = ds_dest->latency_stats.estimate; @@ -2211,19 +2211,15 @@ int ds_manage_route_algo13(ds_set_t *idx, ds_select_state_t *rstate) { gw_latency = ds_dest->latency_stats.estimate - ds_dest->latency_stats.average; if(!gw_inactive) { if(gw_latency > gw_priority && gw_priority > 0) - latency_proirity_handicap = gw_latency / gw_priority; - ds_dest->attrs.rpriority = gw_priority - latency_proirity_handicap; + latency_priority_handicap = gw_latency / gw_priority; + ds_dest->attrs.rpriority = gw_priority - latency_priority_handicap; if(ds_dest->attrs.rpriority < 1 && gw_priority > 0) ds_dest->attrs.rpriority = 1; - if(ds_dest->attrs.rpriority > active_priority) { - hash = z; - active_priority = ds_dest->attrs.rpriority; - } ds_sorted[y].idx = z; ds_sorted[y].priority = ds_dest->attrs.rpriority; LM_DBG("[active]idx[%d]uri[%.*s]priority[%d-%d=%d]latency[%dms]flag[%d]\n", z, ds_dest->uri.len, ds_dest->uri.s, - gw_priority, latency_proirity_handicap, + gw_priority, latency_priority_handicap, ds_dest->attrs.rpriority, gw_latency, ds_dest->flags); } else { ds_sorted[y].idx = -1; @@ -2237,10 +2233,15 @@ int ds_manage_route_algo13(ds_set_t *idx, ds_select_state_t *rstate) { else z = (z + 1) % idx->nr; } - idx->last = (hash + 1) % idx->nr; - LM_DBG("priority[%d]gateway_selected[%d]next_index[%d]\n", active_priority, hash, idx->last); ds_sorted_by_priority(ds_sorted, idx->nr); + // the list order might have changed after sorting - update hash + if(idx->nr > 0) { + hash = ds_sorted[0].idx; + active_priority = ds_sorted[0].priority; + } ds_manage_routes_fill_reodered_xavp(ds_sorted, idx, rstate); + idx->last = (hash + 1) % idx->nr; + LM_DBG("priority[%d]gateway_selected[%d]next_index[%d]\n", active_priority, hash, idx->last); pkg_free(ds_sorted); return hash; }

1 0

git:master:1c43e8b4: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 1c43e8b4ed63d29ef912211e368faaea6a62dcd8 URL: https://github.com/kamailio/kamailio/commit/1c43e8b4ed63d29ef912211e368faae… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-01-11T12:46:26+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/1c43e8b4ed63d29ef912211e368faae… Patch: https://github.com/kamailio/kamailio/commit/1c43e8b4ed63d29ef912211e368faae… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 8b85f1f05e..533a41caab 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -1985,10 +1985,13 @@ kamcmd dlg.list_ctx * mkey - matching key. It can be: 'ruri' - match against R-URI of the dialog; 'furi' - match against From header URI of the dialog; 'turi' - match against the To header URI of the dialog; 'callid' - - match against Call-Id value. + match against Call-Id value; 'start_ts' - match against start + timestamp. * mop - matching operator. It can be: 'eq' - match using string comparison; 're' - match using regular expression; 'sw' - match - using starts-with (prefix) comparison. + using starts-with (prefix) comparison; 'gt' - match using integer + greater comparison; 'lt' - match using integer lesser comparison. + Integer comparison can be used only with 'start_ts' key. * mval - matching value. RPC Command Format: @@ -1997,6 +2000,8 @@ kamcmd dlg.list_match furi eq sip:alice@test.com 2 ... kamcmd dlg.list_match furi sw sip:alice@ ... +kamcmd dlg.list_match start_ts gt s:1641550904 +... 9.4. dlg.list_match_ctx

1 0

[kamailio/kamailio] add filtering based on start timestamp to dlg.list_match (PR #2997)
by Riccardo-78 11 Jan '22

11 Jan '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2997 -- Commit Summary -- * dialog: add filter based on start timestamp to dlg.list_match * dialog: update documentation -- File Changes -- M src/modules/dialog/dialog.c (49) M src/modules/dialog/doc/dialog_admin.xml (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2997.patch https://github.com/kamailio/kamailio/pull/2997.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2997 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/2997(a)github.com>

2 5

git:master:97293a53: dialog: update documentation
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 97293a53060b2b2329018ca7bbeb02a26b0a4afe URL: https://github.com/kamailio/kamailio/commit/97293a53060b2b2329018ca7bbeb02a… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T12:45:40+01:00 dialog: update documentation --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/97293a53060b2b2329018ca7bbeb02a… Patch: https://github.com/kamailio/kamailio/commit/97293a53060b2b2329018ca7bbeb02a… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index d456d545ef..290e68d4d6 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -2500,12 +2500,16 @@ dlg_reset_property("timeout-noreset"); <emphasis>mkey</emphasis> - matching key. It can be: 'ruri' - match against R-URI of the dialog; 'furi' - match against From header URI of the dialog; 'turi' - match against the To header - URI of the dialog; 'callid' - match against Call-Id value. + URI of the dialog; 'callid' - match against Call-Id value; + 'start_ts' - match against start timestamp. </para></listitem> <listitem><para> <emphasis>mop</emphasis> - matching operator. It can be: 'eq' - match using string comparison; 're' - match using regular - expression; 'sw' - match using starts-with (prefix) comparison. + expression; 'sw' - match using starts-with (prefix) comparison; + 'gt' - match using integer greater comparison; 'lt' - match + using integer lesser comparison. Integer comparison can be used + only with 'start_ts' key. </para></listitem> <listitem><para> <emphasis>mval</emphasis> - matching value. @@ -2517,6 +2521,8 @@ dlg_reset_property("timeout-noreset"); &kamcmd; dlg.list_match furi eq sip:alice@test.com 2 ... &kamcmd; dlg.list_match furi sw sip:alice@ +... +&kamcmd; dlg.list_match start_ts gt s:1641550904 ... </programlisting> </section>

1 0

git:master:b177f05e: dialog: add filter based on start timestamp to dlg.list_match
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: b177f05ee8b3a6bf553160ececdb3508a99a65b0 URL: https://github.com/kamailio/kamailio/commit/b177f05ee8b3a6bf553160ececdb350… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T12:45:40+01:00 dialog: add filter based on start timestamp to dlg.list_match --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/b177f05ee8b3a6bf553160ececdb350… Patch: https://github.com/kamailio/kamailio/commit/b177f05ee8b3a6bf553160ececdb350… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index da3ce7cbfd..a25224318c 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -2932,6 +2932,8 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) str mop = {NULL, 0}; str mval = {NULL, 0}; str sval = {NULL, 0}; + unsigned int ival = 0; + unsigned int mival = 0; int n = 0; int m = 0; int vkey = 0; @@ -2960,6 +2962,8 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) vkey = 2; } else if(mkey.len==6 && strncmp(mkey.s, "callid", mkey.len)==0) { vkey = 3; + } else if(mkey.len==8 && strncmp(mkey.s, "start_ts", mkey.len)==0) { + vkey = 4; } else { LM_ERR("invalid key %.*s\n", mkey.len, mkey.s); rpc->fault(c, 500, "Invalid matching key parameter"); @@ -2983,6 +2987,10 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) } } else if(strncmp(mop.s, "sw", 2)==0) { vop = 2; + } else if(strncmp(mop.s, "gt", 2)==0) { + vop = 3; + } else if(strncmp(mop.s, "lt", 2)==0) { + vop = 4; } else { LM_ERR("invalid matching operator %.*s\n", mop.len, mop.s); rpc->fault(c, 500, "Invalid matching operator parameter"); @@ -2992,6 +3000,18 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) n = 0; } + if (vkey == 4 && vop <= 2) { + LM_ERR("Matching operator %.*s not supported with start_ts key\n", mop.len, mop.s); + rpc->fault(c, 500, "Matching operator not supported with start_ts key"); + return; + } + + if (vkey != 4 && vop >= 3) { + LM_ERR("Matching operator %.*s not supported with key %.*s\n", mop.len, mop.s, mkey.len, mkey.s); + rpc->fault(c, 500, "Matching operator not supported"); + return; + } + for(i=0; i<d_table->size; i++) { dlg_lock(d_table, &(d_table->entries[i])); for(dlg=d_table->entries[i].first; dlg!=NULL; dlg=dlg->next) { @@ -3009,6 +3029,9 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) case 3: sval = dlg->callid; break; + case 4: + ival = dlg->start_ts; + break; } switch(vop) { case 0: @@ -3031,6 +3054,17 @@ static void rpc_dlg_list_match_ex(rpc_t *rpc, void *c, int with_context) matched = 1; } break; + case 3: + /* greater than */ + if (str2int(&mval, &mival) == 0 && ival > mival) { + matched = 1; + } + break; + case 4: + if (str2int(&mval, &mival) == 0 && ival < mival) { + matched = 1; + } + break; } if (matched==1) { m++;

1 0

[kamailio/kamailio] cannot use ring_insert_callid when defined log_prefix (Issue #2989)
by sergey-safarov 11 Jan '22

11 Jan '22

### Description I want to convert 183 messages to 180 using the `ring_insert_callid` function. This does not work when used `log_prefix`. Generated error like > siputils [ring.c:300]: conv183(): 183 message got parsed too far! #### Reproduction you can start kamailio using config file like ``` log_prefix="{$mt $hdr(CSeq) $ci} " listen=udp:eth0:5060 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "sl.so" loadmodule "siputils.so" modparam("siputils", "ring_timeout", 30) request_route { xlog("L_ERR", "Test1: $rc\n"); if (is_request()) { ring_insert_callid(); } $du = "sip:192.168.0.1;tranport=udp"; forward(); } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2989 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2989(a)github.com>

4 13

git:5.5:2ab37358: pkg/kamailio/deb: add --atexit=no
by Victor Seva 11 Jan '22

11 Jan '22

Module: kamailio Branch: 5.5 Commit: 2ab373588c1052da3b92739f7ac92e23ed4f0561 URL: https://github.com/kamailio/kamailio/commit/2ab373588c1052da3b92739f7ac92e2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-01-11T09:38:11+01:00 pkg/kamailio/deb: add --atexit=no This helps with openssl1.1 see #2912 (cherry picked from commit b5258d9b0e88de4b9a7c58997b651e790e2cc87e) --- Modified: pkg/kamailio/deb/bionic/kamailio.init Modified: pkg/kamailio/deb/bionic/kamailio.service Modified: pkg/kamailio/deb/bullseye/kamailio.init Modified: pkg/kamailio/deb/bullseye/kamailio.service Modified: pkg/kamailio/deb/buster/kamailio.init Modified: pkg/kamailio/deb/buster/kamailio.service Modified: pkg/kamailio/deb/debian/kamailio.init Modified: pkg/kamailio/deb/debian/kamailio.service Modified: pkg/kamailio/deb/focal/kamailio.init Modified: pkg/kamailio/deb/focal/kamailio.service Modified: pkg/kamailio/deb/jessie/kamailio.init Modified: pkg/kamailio/deb/jessie/kamailio.service Modified: pkg/kamailio/deb/precise/kamailio.init Modified: pkg/kamailio/deb/sid/kamailio.init Modified: pkg/kamailio/deb/sid/kamailio.service Modified: pkg/kamailio/deb/stretch/kamailio.init Modified: pkg/kamailio/deb/stretch/kamailio.service Modified: pkg/kamailio/deb/trusty/kamailio.init Modified: pkg/kamailio/deb/wheezy/kamailio.init Modified: pkg/kamailio/deb/xenial/kamailio.init Modified: pkg/kamailio/deb/xenial/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/2ab373588c1052da3b92739f7ac92e2… Patch: https://github.com/kamailio/kamailio/commit/2ab373588c1052da3b92739f7ac92e2…

1 0

git:master:b5258d9b: pkg/kamailio/deb: add --atexit=no
by Victor Seva 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: b5258d9b0e88de4b9a7c58997b651e790e2cc87e URL: https://github.com/kamailio/kamailio/commit/b5258d9b0e88de4b9a7c58997b651e7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-01-11T09:35:08+01:00 pkg/kamailio/deb: add --atexit=no This helps with openssl1.1 see #2912 --- Modified: pkg/kamailio/deb/bionic/kamailio.init Modified: pkg/kamailio/deb/bionic/kamailio.service Modified: pkg/kamailio/deb/bookworm/kamailio.init Modified: pkg/kamailio/deb/bookworm/kamailio.service Modified: pkg/kamailio/deb/bullseye/kamailio.init Modified: pkg/kamailio/deb/bullseye/kamailio.service Modified: pkg/kamailio/deb/buster/kamailio.init Modified: pkg/kamailio/deb/buster/kamailio.service Modified: pkg/kamailio/deb/debian/kamailio.init Modified: pkg/kamailio/deb/debian/kamailio.service Modified: pkg/kamailio/deb/focal/kamailio.init Modified: pkg/kamailio/deb/focal/kamailio.service Modified: pkg/kamailio/deb/jessie/kamailio.init Modified: pkg/kamailio/deb/jessie/kamailio.service Modified: pkg/kamailio/deb/precise/kamailio.init Modified: pkg/kamailio/deb/sid/kamailio.init Modified: pkg/kamailio/deb/sid/kamailio.service Modified: pkg/kamailio/deb/stretch/kamailio.init Modified: pkg/kamailio/deb/stretch/kamailio.service Modified: pkg/kamailio/deb/trusty/kamailio.init Modified: pkg/kamailio/deb/wheezy/kamailio.init Modified: pkg/kamailio/deb/xenial/kamailio.init Modified: pkg/kamailio/deb/xenial/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/b5258d9b0e88de4b9a7c58997b651e7… Patch: https://github.com/kamailio/kamailio/commit/b5258d9b0e88de4b9a7c58997b651e7…

1 0

git:master:9f679c6e: pkg/kamailio/deb: version set 5.6.0~dev3
by Victor Seva 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 9f679c6e1c036a8bda42807fea6a42b8d1d2230c URL: https://github.com/kamailio/kamailio/commit/9f679c6e1c036a8bda42807fea6a42b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-01-11T09:29:51+01:00 pkg/kamailio/deb: version set 5.6.0~dev3 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/9f679c6e1c036a8bda42807fea6a42b… Patch: https://github.com/kamailio/kamailio/commit/9f679c6e1c036a8bda42807fea6a42b…

1 0

git:master:b7815d04: avpops: init variable to fix warning
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: b7815d04ced35d5b5ccbcdaa39d41ef4a2cb2ad0 URL: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:41:35+01:00 avpops: init variable to fix warning --- Modified: src/modules/avpops/avpops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… Patch: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… --- diff --git a/src/modules/avpops/avpops_impl.c b/src/modules/avpops/avpops_impl.c index 8a6e4c2b2d..28f270fe17 100644 --- a/src/modules/avpops/avpops_impl.c +++ b/src/modules/avpops/avpops_impl.c @@ -505,7 +505,7 @@ int ops_dbstore_avps (struct sip_msg* msg, struct fis_param *sp, avp_list_t avp_list; struct usr_avp *avp; unsigned short name_type; - int_str avp_name; + int_str avp_name = {0}; int_str i_s; str uuid; int keys_nr;

1 0

git:master:102b7c62: db_text: init variable to fix warning
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 102b7c62ae9877151ce542b8b5747051fb954acb URL: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T09:02:11+01:00 db_text: init variable to fix warning --- Modified: src/modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… Patch: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… --- diff --git a/src/modules/db_text/dbt_file.c b/src/modules/db_text/dbt_file.c index 8b88ed8074..6480210ebc 100644 --- a/src/modules/db_text/dbt_file.c +++ b/src/modules/db_text/dbt_file.c @@ -87,7 +87,7 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) char path[512]; char *buf; int c, crow, ccol, bp, sign, max_auto; - dbt_val_t dtval; + dbt_val_t dtval = {0}; dbt_table_p dtp = NULL; dbt_column_p colp, colp0 = NULL; dbt_row_p rowp, rowp0 = NULL;

1 0

git:master:682f9984: dialog: init variable to fix warning
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 682f9984fc4942d5f786f0ca9d798630d618f8da URL: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T09:02:35+01:00 dialog: init variable to fix warning --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… Patch: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index 38dc105fb8..36d43f90f3 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -106,7 +106,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no srjson_t *it = NULL; dlg_dmq_action_t action = DLG_DMQ_NONE; - dlg_iuid_t iuid; + dlg_iuid_t iuid = {0}; str profiles = {0, 0}, callid = {0, 0}, tag1 = {0,0}, tag2 = {0,0}, contact1 = {0,0}, contact2 = {0,0}, k={0,0}, v={0,0}; str cseq1 = {0,0}, cseq2 = {0,0}, route_set1 = {0,0}, route_set2 = {0,0},

1 0

git:master:5443db4d: dispatcher: safety checks for str fields
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 5443db4d632c8502dc622cc28fe2847fb0c147c1 URL: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:20:30+01:00 dispatcher: safety checks for str fields --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… Patch: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 661b4a9533..26836433f1 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1192,7 +1192,7 @@ unsigned int ds_get_hash(str *x, str *y) if(!x && !y) return 0; h = 0; - if(x) { + if(x && x->s) { p = x->s; if(x->len >= 4) { for(; p <= (x->s + x->len - 4); p += 4) { @@ -1207,7 +1207,7 @@ unsigned int ds_get_hash(str *x, str *y) } h += v ^ (v >> 3); } - if(y) { + if(y && y->s) { p = y->s; if(y->len >= 4) { for(; p <= (y->s + y->len - 4); p += 4) {

1 0

git:master:55f23d09: rls: free xml doc in case of error
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 55f23d09faee06a892dde13e371d144b98bae68f URL: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:30:46+01:00 rls: free xml doc in case of error --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… Patch: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index d42c29666b..0f31e7c877 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -183,6 +183,7 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, subs_t* dialog= NULL; int len_est = 0; int resource_added = 0; /* Flag to indicate that we have added at least one resource */ + int ok = 0; /* generate the boundary string */ boundary_string= generate_string(BOUNDARY_STRING_LEN); @@ -430,6 +431,7 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, } done: + ok = 1; if (dbmode == RLS_DB_ONLY && rls_dbf.end_transaction) { if (rls_dbf.end_transaction(rls_db) < 0) @@ -454,6 +456,11 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, LM_ERR("in abort_transaction\n"); } + if(ok==0) { + if(rlmi_doc!=NULL) { + xmlFreeDoc(rlmi_doc); + } + } return; }

1 0

git:master:33c40170: presence: utils - use memcpy instead of strncpy for coherence
by Daniel-Constantin Mierla 11 Jan '22

11 Jan '22

Module: kamailio Branch: master Commit: 33c40170e73adc71e2ad66d8dbb6c776b771ce5d URL: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:19:06+01:00 presence: utils - use memcpy instead of strncpy for coherence --- Modified: src/modules/presence/utils_func.h --- Diff: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… Patch: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… --- diff --git a/src/modules/presence/utils_func.h b/src/modules/presence/utils_func.h index 27fcc07d0a..5c5d58b22a 100644 --- a/src/modules/presence/utils_func.h +++ b/src/modules/presence/utils_func.h @@ -137,7 +137,7 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) contact->len += 1; p += 1; } - strncpy(p, ip.s, ip.len); + memcpy(p, ip.s, ip.len); contact->len += ip.len; p += ip.len; if(msg->rcv.bind_address->address.af == AF_INET6) { @@ -145,7 +145,7 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) contact->len += 1; p += 1; } - if(contact->len > LCONTACT_BUF_SIZE - 21) { + if(contact->len > LCONTACT_BUF_SIZE - 22) { LM_ERR("buffer overflow\n"); goto error; } @@ -156,8 +156,9 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) } contact->len += len; p += len; - strncpy(p, proto, plen); + memcpy(p, proto, plen); contact->len += plen; + contact->s[contact->len] = '\0'; return 0; error:

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev