- sr-dev - kamailio.org

git:master:b9124539: misc: kemi-code-gen.py - generate code for ruby functions with xval return
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: b91245397f1c61313b853fc770f20a860f07b395 URL: https://github.com/kamailio/kamailio/commit/b91245397f1c61313b853fc770f20a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-10T08:42:43+01:00 misc: kemi-code-gen.py - generate code for ruby functions with xval return --- Modified: misc/tools/kemi/kemi-code-gen.py --- Diff: https://github.com/kamailio/kamailio/commit/b91245397f1c61313b853fc770f20a8… Patch: https://github.com/kamailio/kamailio/commit/b91245397f1c61313b853fc770f20a8… --- diff --git a/misc/tools/kemi/kemi-code-gen.py b/misc/tools/kemi/kemi-code-gen.py index ba5d4bcfff..7def9fcf25 100644 --- a/misc/tools/kemi/kemi-code-gen.py +++ b/misc/tools/kemi/kemi-code-gen.py @@ -4,7 +4,7 @@ PRINTPARAMS=3 # - print mode: typedefs, js, lua, python, pythonparams, ruby, sqlang -PRINTMODE="lua" +PRINTMODE="ruby" # - two tabs for python params, three for the other cases # PRINTTABS="\t\t" PRINTTABS="\t\t\t" @@ -155,33 +155,16 @@ def printCodeIfPythonParams(prefix): def printCodeIfRuby(prefix): global PRINTELSE - sfunc = PRINTTABS + "\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_R->msg,\n" + PRINTTABS + "\t\t\t" - for i, c in enumerate(prefix): - if i==0: - if c == 's': - print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " - else: - print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " - PRINTELSE = "} else " - elif i==PRINTPARAMS-1: - if c == 's': - print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR) {") - sfunc += "&vps[" + str(i) +"].s);" - else: - print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT) {") - sfunc += "vps[" + str(i) +"].n);" - else: - if c == 's': - print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " - else: - print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " - - print(sfunc) - print(PRINTTABS + "\treturn sr_kemi_ruby_return_int(ket, ret);") + sparams = printCodeIfParams(prefix) + print("\t\t\t\tif(ket->rtype==SR_KEMIP_XVAL) {") + sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(env_R->msg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_ruby_return_xval(ket, xret);") + print("\t\t\t\t} else {") + sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_R->msg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_ruby_return_int(ket, ret);") + print("\t\t\t\t}") def printCodeIfSQLang(prefix):

1 0

git:master:466fcb28: app_python: update to handle xval return for functions with 3 parameters
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 466fcb283ccf0de92d78c90ca7df7830f8e8ced5 URL: https://github.com/kamailio/kamailio/commit/466fcb283ccf0de92d78c90ca7df783… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-10T08:08:11+01:00 app_python: update to handle xval return for functions with 3 parameters - fix for functions like KSR.sqlops.sql_result_get() --- Modified: src/modules/app_python/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/466fcb283ccf0de92d78c90ca7df783… Patch: https://github.com/kamailio/kamailio/commit/466fcb283ccf0de92d78c90ca7df783…

1 0

git:master:871475c6: app_python3: update to handle xval return for functions with 3 parameters
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 871475c6aba89bd6506255665d304206325bbf4c URL: https://github.com/kamailio/kamailio/commit/871475c6aba89bd6506255665d30420… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-10T08:11:54+01:00 app_python3: update to handle xval return for functions with 3 parameters - fix for functions like KSR.sqlops.sql_result_get() --- Modified: src/modules/app_python3/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/871475c6aba89bd6506255665d30420… Patch: https://github.com/kamailio/kamailio/commit/871475c6aba89bd6506255665d30420…

1 0

git:master:6064b1ee: app_jsdt: update to handle xval return for functions with 3 parameters
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 6064b1ee64fa2fa6682c671f554acaead5ca1898 URL: https://github.com/kamailio/kamailio/commit/6064b1ee64fa2fa6682c671f554acae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T21:01:04+01:00 app_jsdt: update to handle xval return for functions with 3 parameters - fix for functions like KSR.sqlops.sql_result_get() --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/6064b1ee64fa2fa6682c671f554acae… Patch: https://github.com/kamailio/kamailio/commit/6064b1ee64fa2fa6682c671f554acae…

1 0

git:master:5a048b94: misc: kemi-code-gen.py - generate code for python functions with xval return
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 5a048b9489ce4a5c48e632376f7472b26efefb45 URL: https://github.com/kamailio/kamailio/commit/5a048b9489ce4a5c48e632376f7472b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-10T08:07:23+01:00 misc: kemi-code-gen.py - generate code for python functions with xval return --- Modified: misc/tools/kemi/kemi-code-gen.py --- Diff: https://github.com/kamailio/kamailio/commit/5a048b9489ce4a5c48e632376f7472b… Patch: https://github.com/kamailio/kamailio/commit/5a048b9489ce4a5c48e632376f7472b… --- diff --git a/misc/tools/kemi/kemi-code-gen.py b/misc/tools/kemi/kemi-code-gen.py index dd77d61655..2a024f826e 100644 --- a/misc/tools/kemi/kemi-code-gen.py +++ b/misc/tools/kemi/kemi-code-gen.py @@ -4,7 +4,7 @@ PRINTPARAMS=3 # - print mode: typedefs, js, lua, python, pythonparams, ruby, sqlang -PRINTMODE="js" +PRINTMODE="python" # - two tabs for python params, three for the other cases # PRINTTABS="\t\t" PRINTTABS="\t\t\t" @@ -60,10 +60,8 @@ def printCodeIfJS(prefix): sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(env_J->msg,\n" + PRINTTABS + "\t\t\t" print(sfunc + sparams) print(PRINTTABS + "\t\treturn sr_kemi_jsdt_return_xval(J, ket, xret);") - print("\t\t\t\t} else {") sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_J->msg,\n" + PRINTTABS + "\t\t\t" - print(sfunc + sparams) print(PRINTTABS + "\t\treturn sr_kemi_jsdt_return_int(J, ket, ret);") print("\t\t\t\t}") @@ -100,10 +98,8 @@ def printCodeIfLua(prefix): sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(env_L->msg,\n" + PRINTTABS + "\t\t\t" print(sfunc + sparams) print(PRINTTABS + "\t\treturn sr_kemi_lua_return_xval(L, ket, xret);") - print("\t\t\t\t} else {") sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_L->msg,\n" + PRINTTABS + "\t\t\t" - print(sfunc + sparams) print(PRINTTABS + "\t\treturn sr_kemi_lua_return_int(L, ket, ret);") print("\t\t\t\t}") @@ -111,33 +107,40 @@ def printCodeIfLua(prefix): def printCodeIfPython(prefix): global PRINTELSE - sfunc = PRINTTABS + "\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(lmsg,\n" + PRINTTABS + "\t\t\t" + sparams = "" for i, c in enumerate(prefix): if i==0: if c == 's': print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " PRINTELSE = "} else " elif i==PRINTPARAMS-1: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR) {") - sfunc += "&vps[" + str(i) +"].s);" + sparams += "&vps[" + str(i) +"].s);" else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT) {") - sfunc += "vps[" + str(i) +"].n);" + sparams += "vps[" + str(i) +"].n);" else: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " - print(sfunc) - print(PRINTTABS + "\treturn sr_kemi_apy_return_int(ket, ret);") + print("\t\t\t\tif(ket->rtype==SR_KEMIP_XVAL) {") + sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(lmsg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_apy_return_xval(ket, xret);") + print("\t\t\t\t} else {") + sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(lmsg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_apy_return_int(ket, ret);") + print("\t\t\t\t}") def printCodeIfPythonParams(prefix):

1 0

git:master:a99f581a: misc: kemi-code-gen.py - generate code for javascript functions with xval return
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: a99f581a519123e7c47479b724308a5dc239393a URL: https://github.com/kamailio/kamailio/commit/a99f581a519123e7c47479b724308a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T20:42:01+01:00 misc: kemi-code-gen.py - generate code for javascript functions with xval return --- Modified: misc/tools/kemi/kemi-code-gen.py --- Diff: https://github.com/kamailio/kamailio/commit/a99f581a519123e7c47479b724308a5… Patch: https://github.com/kamailio/kamailio/commit/a99f581a519123e7c47479b724308a5… --- diff --git a/misc/tools/kemi/kemi-code-gen.py b/misc/tools/kemi/kemi-code-gen.py index 6c2893a688..dd77d61655 100644 --- a/misc/tools/kemi/kemi-code-gen.py +++ b/misc/tools/kemi/kemi-code-gen.py @@ -4,7 +4,7 @@ PRINTPARAMS=3 # - print mode: typedefs, js, lua, python, pythonparams, ruby, sqlang -PRINTMODE="lua" +PRINTMODE="js" # - two tabs for python params, three for the other cases # PRINTTABS="\t\t" PRINTTABS="\t\t\t" @@ -31,33 +31,42 @@ def printCodeIfEnd(sretfunc): def printCodeIfJS(prefix): global PRINTELSE - sfunc = PRINTTABS + "\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_J->msg,\n" + PRINTTABS + "\t\t\t" + sparams = "" for i, c in enumerate(prefix): if i==0: if c == 's': print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " PRINTELSE = "} else " elif i==PRINTPARAMS-1: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR) {") - sfunc += "&vps[" + str(i) +"].s);" + sparams += "&vps[" + str(i) +"].s);" else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT) {") - sfunc += "vps[" + str(i) +"].n);" + sparams += "vps[" + str(i) +"].n);" else: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " - print(sfunc) - print(PRINTTABS + "\treturn sr_kemi_jsdt_return_int(J, ket, ret);") + print("\t\t\t\tif(ket->rtype==SR_KEMIP_XVAL) {") + sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(env_J->msg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_jsdt_return_xval(J, ket, xret);") + + print("\t\t\t\t} else {") + sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_J->msg,\n" + PRINTTABS + "\t\t\t" + + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_jsdt_return_int(J, ket, ret);") + print("\t\t\t\t}") def printCodeIfLua(prefix):

1 0

git:master:72cc434e: core: kemi - added typedefs for functions with three params and xval return
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 72cc434ef75a0667c843206cf84fe080bb912dd3 URL: https://github.com/kamailio/kamailio/commit/72cc434ef75a0667c843206cf84fe08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T20:12:22+01:00 core: kemi - added typedefs for functions with three params and xval return --- Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/72cc434ef75a0667c843206cf84fe08… Patch: https://github.com/kamailio/kamailio/commit/72cc434ef75a0667c843206cf84fe08… --- diff --git a/src/core/kemi.h b/src/core/kemi.h index 6493ab5009..26e9bd4860 100644 --- a/src/core/kemi.h +++ b/src/core/kemi.h @@ -180,6 +180,16 @@ typedef sr_kemi_xval_t* (*sr_kemi_xfmns_f)(sip_msg_t*, int, str*); typedef sr_kemi_xval_t* (*sr_kemi_xfmsn_f)(sip_msg_t*, str*, int); typedef sr_kemi_xval_t* (*sr_kemi_xfmss_f)(sip_msg_t*, str*, str*); +/* return xval, params sip_msg_t and three int|str params */ +typedef sr_kemi_xval_t* (*sr_kemi_xfmnnn_f)(sip_msg_t*, int, int, int); +typedef sr_kemi_xval_t* (*sr_kemi_xfmnns_f)(sip_msg_t*, int, int, str*); +typedef sr_kemi_xval_t* (*sr_kemi_xfmnsn_f)(sip_msg_t*, int, str*, int); +typedef sr_kemi_xval_t* (*sr_kemi_xfmnss_f)(sip_msg_t*, int, str*, str*); +typedef sr_kemi_xval_t* (*sr_kemi_xfmsnn_f)(sip_msg_t*, str*, int, int); +typedef sr_kemi_xval_t* (*sr_kemi_xfmsns_f)(sip_msg_t*, str*, int, str*); +typedef sr_kemi_xval_t* (*sr_kemi_xfmssn_f)(sip_msg_t*, str*, str*, int); +typedef sr_kemi_xval_t* (*sr_kemi_xfmsss_f)(sip_msg_t*, str*, str*, str*); + sr_kemi_t* sr_kemi_lookup(str *mname, int midx, str *fname); int sr_kemi_modules_add(sr_kemi_t *klist);

1 0

git:master:8bce8a73: misc: kemi-code-gen.py - generate code for lua functions with 3 params and xval return
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: 8bce8a738e16303985ed386213e1d86a1a6a7878 URL: https://github.com/kamailio/kamailio/commit/8bce8a738e16303985ed386213e1d86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T20:15:31+01:00 misc: kemi-code-gen.py - generate code for lua functions with 3 params and xval return --- Modified: misc/tools/kemi/kemi-code-gen.py --- Diff: https://github.com/kamailio/kamailio/commit/8bce8a738e16303985ed386213e1d86… Patch: https://github.com/kamailio/kamailio/commit/8bce8a738e16303985ed386213e1d86… --- diff --git a/misc/tools/kemi/kemi-code-gen.py b/misc/tools/kemi/kemi-code-gen.py index 8593c154140..6c2893a6884 100644 --- a/misc/tools/kemi/kemi-code-gen.py +++ b/misc/tools/kemi/kemi-code-gen.py @@ -2,9 +2,9 @@ # - print IF conditions with param types for KEMI interpreters # - print typedefs for functions -PRINTPARAMS=4 +PRINTPARAMS=3 # - print mode: typedefs, js, lua, python, pythonparams, ruby, sqlang -PRINTMODE="sqlang" +PRINTMODE="lua" # - two tabs for python params, three for the other cases # PRINTTABS="\t\t" PRINTTABS="\t\t\t" @@ -62,33 +62,42 @@ def printCodeIfJS(prefix): def printCodeIfLua(prefix): global PRINTELSE - sfunc = PRINTTABS + "\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_L->msg,\n" + PRINTTABS + "\t\t\t" + sparams = "" for i, c in enumerate(prefix): if i==0: if c == 's': print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + PRINTELSE + "if(ket->ptypes[0]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " PRINTELSE = "} else " elif i==PRINTPARAMS-1: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR) {") - sfunc += "&vps[" + str(i) +"].s);" + sparams += "&vps[" + str(i) +"].s);" else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT) {") - sfunc += "vps[" + str(i) +"].n);" + sparams += "vps[" + str(i) +"].n);" else: if c == 's': print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_STR") - sfunc += "&vps[" + str(i) +"].s, " + sparams += "&vps[" + str(i) +"].s, " else: print(PRINTTABS + "\t\t&& ket->ptypes[" + str(i) + "]==SR_KEMIP_INT") - sfunc += "vps[" + str(i) +"].n, " + sparams += "vps[" + str(i) +"].n, " - print(sfunc) - print(PRINTTABS + "\treturn sr_kemi_lua_return_int(L, ket, ret);") + print("\t\t\t\tif(ket->rtype==SR_KEMIP_XVAL) {") + sfunc = PRINTTABS + "\t\txret = ((sr_kemi_xfm" + prefix + "_f)(ket->func))(env_L->msg,\n" + PRINTTABS + "\t\t\t" + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_lua_return_xval(L, ket, xret);") + + print("\t\t\t\t} else {") + sfunc = PRINTTABS + "\t\tret = ((sr_kemi_fm" + prefix + "_f)(ket->func))(env_L->msg,\n" + PRINTTABS + "\t\t\t" + + print(sfunc + sparams) + print(PRINTTABS + "\t\treturn sr_kemi_lua_return_int(L, ket, ret);") + print("\t\t\t\t}") def printCodeIfPython(prefix):

1 0

git:master:da9eee21: app_lua: update to handle xval return for functions with 3 parameters
by Daniel-Constantin Mierla 10 Dec '21

10 Dec '21

Module: kamailio Branch: master Commit: da9eee2125fc6e632bcbeae4d9133bb39c412dee URL: https://github.com/kamailio/kamailio/commit/da9eee2125fc6e632bcbeae4d9133bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T20:37:51+01:00 app_lua: update to handle xval return for functions with 3 parameters - fix for functions like KSR.sqlops.sql_result_get() --- Modified: src/modules/app_lua/app_lua_api.c --- Diff: https://github.com/kamailio/kamailio/commit/da9eee2125fc6e632bcbeae4d9133bb… Patch: https://github.com/kamailio/kamailio/commit/da9eee2125fc6e632bcbeae4d9133bb…

1 0

[kamailio/kamailio] Network route priority (Issue #2968)
by xaled1 09 Dec '21

09 Dec '21

Hi, if event_route[network:msg] and event_route[siptrace:msg] both are enabled, then event_route[siptrace:msg] seems to be called before event_route[network:msg] when a message has been received (and event_route[siptrace:msg] called after event_route[network:msg], if a message has been sent) As network:msg (nio) is designed to process compression or encryption, it makes sense, that it is called before event_route[siptrace:msg], that is meant to work on a SIP message (when receiving data from the network). When sending a message, it makes sense, to call siptrace:msg before network:msg. Is there any option to change this priority (e.g. defining anchors/priorities)? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2968

2 2

git:master:cd2f5d4c: core: enclose in quotes the value for #!defenvs
by Daniel-Constantin Mierla 09 Dec '21

09 Dec '21

Module: kamailio Branch: master Commit: cd2f5d4ca2a3ec31c1e67cd08ad025a152241e35 URL: https://github.com/kamailio/kamailio/commit/cd2f5d4ca2a3ec31c1e67cd08ad025a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-09T10:41:41+01:00 core: enclose in quotes the value for #!defenvs --- Modified: src/core/cfg.lex Modified: src/core/ppcfg.c Modified: src/core/ppcfg.h --- Diff: https://github.com/kamailio/kamailio/commit/cd2f5d4ca2a3ec31c1e67cd08ad025a… Patch: https://github.com/kamailio/kamailio/commit/cd2f5d4ca2a3ec31c1e67cd08ad025a… --- diff --git a/src/core/cfg.lex b/src/core/cfg.lex index 551cfab014..84f5630483 100644 --- a/src/core/cfg.lex +++ b/src/core/cfg.lex @@ -2087,6 +2087,7 @@ int pp_define_env(const char *text, int len, int qmode) char *r; str defname; str defvalue; + str newval; r = strchr(text, '='); @@ -2115,6 +2116,13 @@ int pp_define_env(const char *text, int len, int qmode) LM_ERR("cannot set define name [%s]\n", (char*)text); return -1; } + if(qmode==KSR_PPDEF_QUOTED) { + if(pp_def_qvalue(&defvalue, &newval) < 0) { + LM_ERR("failed to enclose in quotes the value\n"); + return -1; + } + defvalue = newval; + } if(pp_define_set(defvalue.len, defvalue.s, qmode)<0) { LM_ERR("cannot set define value [%s]\n", (char*)text); return -1; diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index 67391557f8..3d91679df6 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -48,6 +48,31 @@ static pp_subst_rule_t *pp_subst_rules_tail = NULL; static int _pp_ifdef_level = 0; static str_list_t *_ksr_substdef_strlist = NULL; +int pp_def_qvalue(str *defval, str *outval) +{ + str newval; + str_list_t *sb; + + if(pv_get_buffer_size() < defval->len + 4) { + LM_ERR("defined value is too large\n"); + return -1; + } + newval.s = pv_get_buffer(); + newval.s[0] = '"'; + memcpy(newval.s + 1, defval->s, defval->len); + newval.s[defval->len + 1] = '"'; + newval.s[defval->len + 2] = '\0'; + newval.len = defval->len + 2; + sb = str_list_block_add(&_ksr_substdef_strlist, newval.s, newval.len); + if(sb==NULL) { + LM_ERR("failed to link quoted value [%.*s]\n", defval->len, defval->s); + return -1; + } + *outval = sb->s; + + return 0; +} + int pp_subst_add(char *data) { struct subst_expr* se; @@ -163,22 +188,11 @@ int pp_substdef_add(char *data, int mode) } } if(mode==KSR_PPDEF_QUOTED) { - if(pv_get_buffer_size() < defvalue.len + 4) { - LM_ERR("defined value is too large\n"); - return -1; - } - newval.s = pv_get_buffer(); - newval.s[0] = '"'; - memcpy(newval.s + 1, defvalue.s, defvalue.len); - newval.s[defvalue.len + 1] = '"'; - newval.s[defvalue.len + 2] = '\0'; - newval.len = defvalue.len + 2; - sb = str_list_block_add(&_ksr_substdef_strlist, newval.s, newval.len); - if(sb==NULL) { - LM_ERR("failed to handle substdef: [%s]\n", data); + if(pp_def_qvalue(&defvalue, &newval) < 0) { + LM_ERR("failed to enclose in quotes the value\n"); return -1; } - defvalue = sb->s; + defvalue = newval; } if(pp_define_set(defvalue.len, defvalue.s, KSR_PPDEF_QUOTED)<0) { LM_ERR("cannot set define value\n"); diff --git a/src/core/ppcfg.h b/src/core/ppcfg.h index a8d27f7083..d08884775c 100644 --- a/src/core/ppcfg.h +++ b/src/core/ppcfg.h @@ -34,6 +34,8 @@ typedef struct ksr_ppdefine { int dtype; } ksr_ppdefine_t; +int pp_def_qvalue(str *defval, str *outval); + str* pp_get_define_name(int idx); ksr_ppdefine_t* pp_get_define(int idx);

1 0

[kamailio/kamailio] rtpengine: Fix set selection (PR #2965)
by Stefan Mititelu 08 Dec '21

08 Dec '21

When set_rtpengine_set() config function is called.   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  After calling set_rtpengine_set(), the new set is not set for further rtpengine delete(). This is because active_rtpp_set is set to default_rtpp_set when msg id != current_msg_id (which is set once by set_rtpengine_set()) I've removed the msg id != current_msg_id condition, and initialized active_rtpp_set in mod_init(). Basically tested locally with 2 sets with 1 rtpengine each. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2965 -- Commit Summary -- * rtpengine: Fix set selection -- File Changes -- M src/modules/rtpengine/rtpengine.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2965.patch https://github.com/kamailio/kamailio/pull/2965.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2965

2 3

git:master:02be5bef: pv: added $msg(lpart) - return last part of the message
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: master Commit: 02be5bef89625a53b2f67f8ca8d3acd4073b6c2b URL: https://github.com/kamailio/kamailio/commit/02be5bef89625a53b2f67f8ca8d3acd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T15:17:11+01:00 pv: added $msg(lpart) - return last part of the message - headers and body (skips first line) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/02be5bef89625a53b2f67f8ca8d3acd… Patch: https://github.com/kamailio/kamailio/commit/02be5bef89625a53b2f67f8ca8d3acd… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index dc1f6a59a2..de5d5b41c8 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -4114,6 +4114,8 @@ int pv_parse_msg_attrs_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 4; else if(strncmp(in->s, "fpart", 5)==0) sp->pvp.pvn.u.isname.name.n = 7; + else if(strncmp(in->s, "lpart", 5)==0) + sp->pvp.pvn.u.isname.name.n = 9; else goto error; break; case 8: @@ -4210,6 +4212,12 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) s.len = msg->unparsed - s.s; trim(&s); return pv_get_sintval(msg, param, res, s.len); + case 9: /* last part - headers + body */ + if(msg->headers==NULL || msg->headers->name.s==NULL) + return pv_get_null(msg, param, res); + s.s = msg->headers->name.s; + s.len = msg->buf + msg->len - s.s; + return pv_get_strval(msg, param, res, &s); default: return pv_get_null(msg, param, res);

1 0

git:master:dfbeb92a: pkg/kamailio/deb: fix lintian warnings
by Victor Seva 08 Dec '21

08 Dec '21

Module: kamailio Branch: master Commit: dfbeb92a956009fc57070ac988cb0177f9c8192f URL: https://github.com/kamailio/kamailio/commit/dfbeb92a956009fc57070ac988cb017… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2021-12-08T11:21:20+01:00 pkg/kamailio/deb: fix lintian warnings --- Added: pkg/kamailio/deb/bionic/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/bionic/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/bookworm/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/bookworm/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/bullseye/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/bullseye/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/buster/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/buster/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/debian/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/debian/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/focal/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/focal/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/jessie/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/jessie/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/precise/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/precise/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/stretch/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/stretch/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/trusty/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/trusty/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/wheezy/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/wheezy/kamailio-systemd-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-secsipid-modules.lintian-overrides Added: pkg/kamailio/deb/xenial/kamailio-systemd-modules.lintian-overrides Modified: pkg/kamailio/deb/bionic/copyright Modified: pkg/kamailio/deb/bionic/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/bookworm/copyright Modified: pkg/kamailio/deb/bookworm/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/bullseye/copyright Modified: pkg/kamailio/deb/bullseye/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/buster/copyright Modified: pkg/kamailio/deb/buster/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/debian/copyright Modified: pkg/kamailio/deb/debian/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/focal/copyright Modified: pkg/kamailio/deb/focal/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/jessie/copyright Modified: pkg/kamailio/deb/jessie/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/precise/copyright Modified: pkg/kamailio/deb/precise/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/sid/copyright Modified: pkg/kamailio/deb/sid/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/stretch/copyright Modified: pkg/kamailio/deb/stretch/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/trusty/copyright Modified: pkg/kamailio/deb/trusty/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/wheezy/copyright Modified: pkg/kamailio/deb/wheezy/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/xenial/copyright Modified: pkg/kamailio/deb/xenial/kamailio-tls-modules.lintian-overrides --- Diff: https://github.com/kamailio/kamailio/commit/dfbeb92a956009fc57070ac988cb017… Patch: https://github.com/kamailio/kamailio/commit/dfbeb92a956009fc57070ac988cb017…

1 0

Kamailio v5.3.9 Released
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Hello, Kamailio SIP Server v5.3.9 stable release is out. This is a maintenance release of the old stable branch, 5.3, that includes fixes since the release of v5.3.8. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.3.x. Deployments running previous v5.3.x versions are strongly recommended to be upgraded to v5.3.9 or even better to v5.4.x or 5.5.x series. For more details about version 5.3.9 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2021/12/kamailio-v5-3-9-released/ RPM, Debian/Ubuntu packages will be available soon as well. Note: the branch 5.3 is an old stable branch, v5.3.9 being the last planned release out of it, to mark the end of official maintenance. The maintained stable branches are now 5.4 and 5.5, at this time with v5.5.3 being the latest stable release. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

1 0

git:5.3:a5fd0a85: ChangeLog: content updated for v5.3.9
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.3 Commit: a5fd0a856717119ee53164ea2d8aa2892bc56b7a URL: https://github.com/kamailio/kamailio/commit/a5fd0a856717119ee53164ea2d8aa28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T10:15:16+01:00 ChangeLog: content updated for v5.3.9 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/a5fd0a856717119ee53164ea2d8aa28… Patch: https://github.com/kamailio/kamailio/commit/a5fd0a856717119ee53164ea2d8aa28…

1 0

git:5.3:6a04f278: pkg: version set to 5.3.9 for rpm and alpine specs
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.3 Commit: 6a04f278372864b0c0bfa4be78d0f97283df9909 URL: https://github.com/kamailio/kamailio/commit/6a04f278372864b0c0bfa4be78d0f97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:39:04+01:00 pkg: version set to 5.3.9 for rpm and alpine specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/6a04f278372864b0c0bfa4be78d0f97… Patch: https://github.com/kamailio/kamailio/commit/6a04f278372864b0c0bfa4be78d0f97… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index e8ee911c30..0476654b73 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.3.8 +pkgver=5.3.9 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 31d713b1f3..391ff883d0 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.3.8 +%define ver 5.3.9 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

git:5.3:0cac7679: pkg/kamailio/deb: version set to 5.3.9
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.3 Commit: 0cac76792652237f362428ffbc62b29e73365aac URL: https://github.com/kamailio/kamailio/commit/0cac76792652237f362428ffbc62b29… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:40:15+01:00 pkg/kamailio/deb: version set to 5.3.9 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/0cac76792652237f362428ffbc62b29… Patch: https://github.com/kamailio/kamailio/commit/0cac76792652237f362428ffbc62b29…

1 0

git:5.3:91823791: Makefile.defs: set version to 5.3.9
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.3 Commit: 91823791bf485d18edfd01fdf0f923fcb09f736b URL: https://github.com/kamailio/kamailio/commit/91823791bf485d18edfd01fdf0f923f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:41:06+01:00 Makefile.defs: set version to 5.3.9 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/91823791bf485d18edfd01fdf0f923f… Patch: https://github.com/kamailio/kamailio/commit/91823791bf485d18edfd01fdf0f923f… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 45db7086cc..f36fa6a7c4 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 3 -SUBLEVEL = 8 +SUBLEVEL = 9 EXTRAVERSION = # memory manager switcher

1 0

git:5.3:76c052b2: auth_ephemeral: fix sha256/384/512
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.3 Commit: 76c052b2dc86856e854c2ba1aad39a891bfb121e URL: https://github.com/kamailio/kamailio/commit/76c052b2dc86856e854c2ba1aad39a8… Author: Justin-lavelle <justinl(a)broadvoice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:32:20+01:00 auth_ephemeral: fix sha256/384/512 - sha256/384/512 broken due to use of sha1 password length, change to check and use proper lengths for each - sha384 mistakenly using sha256 method (cherry picked from commit de2bee1805c2c89565e9b28afb50fac375d0b5ba) (cherry picked from commit 52a01e54483c5e50fedec649689e5f142c16315a) (cherry picked from commit e04db74dc1e1706f4f3c8c2b6fcd3dba98534f04) --- Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/76c052b2dc86856e854c2ba1aad39a8… Patch: https://github.com/kamailio/kamailio/commit/76c052b2dc86856e854c2ba1aad39a8… --- diff --git a/src/modules/auth_ephemeral/authorize.c b/src/modules/auth_ephemeral/authorize.c index bb92a4a2190..ff5012ade51 100644 --- a/src/modules/auth_ephemeral/authorize.c +++ b/src/modules/auth_ephemeral/authorize.c @@ -69,11 +69,11 @@ static inline int get_pass(str *_username, str *_secret, str *_password) break; case AUTHEPH_SHA384: hmac_len = SHA384_DIGEST_LENGTH; - if (HMAC(EVP_sha256(), _secret->s, _secret->len, + if (HMAC(EVP_sha384(), _secret->s, _secret->len, (unsigned char *) _username->s, _username->len, hmac_sha1, &hmac_len) == NULL) { - LM_ERR("HMAC-SHA256 failed\n"); + LM_ERR("HMAC-SHA384 failed\n"); return -1; } break; @@ -88,7 +88,7 @@ static inline int get_pass(str *_username, str *_secret, str *_password) } break; default: - LM_ERR("Inavlid SHA Algorithm\n"); + LM_ERR("Invalid SHA Algorithm\n"); return -1; } @@ -479,7 +479,26 @@ int autheph_proxy(struct sip_msg *_m, char *_realm, char *_p2) int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) { - char generated_password[base64_enc_len(SHA_DIGEST_LENGTH)]; + unsigned int hmac_len = SHA_DIGEST_LENGTH; + switch(autheph_sha_alg) { + case AUTHEPH_SHA1: + hmac_len = SHA_DIGEST_LENGTH; + break; + case AUTHEPH_SHA256: + hmac_len = SHA256_DIGEST_LENGTH; + break; + case AUTHEPH_SHA384: + hmac_len = SHA384_DIGEST_LENGTH; + break; + case AUTHEPH_SHA512: + hmac_len = SHA512_DIGEST_LENGTH; + break; + default: + LM_ERR("Invalid SHA Algorithm\n"); + return AUTH_ERROR; + } + + char generated_password[base64_enc_len(hmac_len)]; str sgenerated_password; struct secret *secret_struct; @@ -515,14 +534,17 @@ int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) secret_struct = secret_list; while (secret_struct != NULL) { - LM_DBG("trying secret: %.*s\n", + LM_DBG("trying secret: %.*s (%i)\n", secret_struct->secret_key.len, - secret_struct->secret_key.s); + secret_struct->secret_key.s, + secret_struct->secret_key.len); if (get_pass(susername, &secret_struct->secret_key, &sgenerated_password) == 0) { - LM_DBG("generated password: %.*s\n", - sgenerated_password.len, sgenerated_password.s); + LM_DBG("generated password: %.*s (%i)\n", + sgenerated_password.len, + sgenerated_password.s, + sgenerated_password.len); if (spassword->len == sgenerated_password.len && strncmp(spassword->s, sgenerated_password.s, spassword->len) == 0)

1 0

git:5.4:e04db74d: auth_ephemeral: fix sha256/384/512
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.4 Commit: e04db74dc1e1706f4f3c8c2b6fcd3dba98534f04 URL: https://github.com/kamailio/kamailio/commit/e04db74dc1e1706f4f3c8c2b6fcd3db… Author: Justin-lavelle <justinl(a)broadvoice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:31:41+01:00 auth_ephemeral: fix sha256/384/512 - sha256/384/512 broken due to use of sha1 password length, change to check and use proper lengths for each - sha384 mistakenly using sha256 method (cherry picked from commit de2bee1805c2c89565e9b28afb50fac375d0b5ba) (cherry picked from commit 52a01e54483c5e50fedec649689e5f142c16315a) --- Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/e04db74dc1e1706f4f3c8c2b6fcd3db… Patch: https://github.com/kamailio/kamailio/commit/e04db74dc1e1706f4f3c8c2b6fcd3db… --- diff --git a/src/modules/auth_ephemeral/authorize.c b/src/modules/auth_ephemeral/authorize.c index bb92a4a2190..ff5012ade51 100644 --- a/src/modules/auth_ephemeral/authorize.c +++ b/src/modules/auth_ephemeral/authorize.c @@ -69,11 +69,11 @@ static inline int get_pass(str *_username, str *_secret, str *_password) break; case AUTHEPH_SHA384: hmac_len = SHA384_DIGEST_LENGTH; - if (HMAC(EVP_sha256(), _secret->s, _secret->len, + if (HMAC(EVP_sha384(), _secret->s, _secret->len, (unsigned char *) _username->s, _username->len, hmac_sha1, &hmac_len) == NULL) { - LM_ERR("HMAC-SHA256 failed\n"); + LM_ERR("HMAC-SHA384 failed\n"); return -1; } break; @@ -88,7 +88,7 @@ static inline int get_pass(str *_username, str *_secret, str *_password) } break; default: - LM_ERR("Inavlid SHA Algorithm\n"); + LM_ERR("Invalid SHA Algorithm\n"); return -1; } @@ -479,7 +479,26 @@ int autheph_proxy(struct sip_msg *_m, char *_realm, char *_p2) int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) { - char generated_password[base64_enc_len(SHA_DIGEST_LENGTH)]; + unsigned int hmac_len = SHA_DIGEST_LENGTH; + switch(autheph_sha_alg) { + case AUTHEPH_SHA1: + hmac_len = SHA_DIGEST_LENGTH; + break; + case AUTHEPH_SHA256: + hmac_len = SHA256_DIGEST_LENGTH; + break; + case AUTHEPH_SHA384: + hmac_len = SHA384_DIGEST_LENGTH; + break; + case AUTHEPH_SHA512: + hmac_len = SHA512_DIGEST_LENGTH; + break; + default: + LM_ERR("Invalid SHA Algorithm\n"); + return AUTH_ERROR; + } + + char generated_password[base64_enc_len(hmac_len)]; str sgenerated_password; struct secret *secret_struct; @@ -515,14 +534,17 @@ int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) secret_struct = secret_list; while (secret_struct != NULL) { - LM_DBG("trying secret: %.*s\n", + LM_DBG("trying secret: %.*s (%i)\n", secret_struct->secret_key.len, - secret_struct->secret_key.s); + secret_struct->secret_key.s, + secret_struct->secret_key.len); if (get_pass(susername, &secret_struct->secret_key, &sgenerated_password) == 0) { - LM_DBG("generated password: %.*s\n", - sgenerated_password.len, sgenerated_password.s); + LM_DBG("generated password: %.*s (%i)\n", + sgenerated_password.len, + sgenerated_password.s, + sgenerated_password.len); if (spassword->len == sgenerated_password.len && strncmp(spassword->s, sgenerated_password.s, spassword->len) == 0)

1 0

git:5.5:52a01e54: auth_ephemeral: fix sha256/384/512
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: 5.5 Commit: 52a01e54483c5e50fedec649689e5f142c16315a URL: https://github.com/kamailio/kamailio/commit/52a01e54483c5e50fedec649689e5f1… Author: Justin-lavelle <justinl(a)broadvoice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:31:14+01:00 auth_ephemeral: fix sha256/384/512 - sha256/384/512 broken due to use of sha1 password length, change to check and use proper lengths for each - sha384 mistakenly using sha256 method (cherry picked from commit de2bee1805c2c89565e9b28afb50fac375d0b5ba) --- Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/52a01e54483c5e50fedec649689e5f1… Patch: https://github.com/kamailio/kamailio/commit/52a01e54483c5e50fedec649689e5f1… --- diff --git a/src/modules/auth_ephemeral/authorize.c b/src/modules/auth_ephemeral/authorize.c index bb92a4a2190..ff5012ade51 100644 --- a/src/modules/auth_ephemeral/authorize.c +++ b/src/modules/auth_ephemeral/authorize.c @@ -69,11 +69,11 @@ static inline int get_pass(str *_username, str *_secret, str *_password) break; case AUTHEPH_SHA384: hmac_len = SHA384_DIGEST_LENGTH; - if (HMAC(EVP_sha256(), _secret->s, _secret->len, + if (HMAC(EVP_sha384(), _secret->s, _secret->len, (unsigned char *) _username->s, _username->len, hmac_sha1, &hmac_len) == NULL) { - LM_ERR("HMAC-SHA256 failed\n"); + LM_ERR("HMAC-SHA384 failed\n"); return -1; } break; @@ -88,7 +88,7 @@ static inline int get_pass(str *_username, str *_secret, str *_password) } break; default: - LM_ERR("Inavlid SHA Algorithm\n"); + LM_ERR("Invalid SHA Algorithm\n"); return -1; } @@ -479,7 +479,26 @@ int autheph_proxy(struct sip_msg *_m, char *_realm, char *_p2) int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) { - char generated_password[base64_enc_len(SHA_DIGEST_LENGTH)]; + unsigned int hmac_len = SHA_DIGEST_LENGTH; + switch(autheph_sha_alg) { + case AUTHEPH_SHA1: + hmac_len = SHA_DIGEST_LENGTH; + break; + case AUTHEPH_SHA256: + hmac_len = SHA256_DIGEST_LENGTH; + break; + case AUTHEPH_SHA384: + hmac_len = SHA384_DIGEST_LENGTH; + break; + case AUTHEPH_SHA512: + hmac_len = SHA512_DIGEST_LENGTH; + break; + default: + LM_ERR("Invalid SHA Algorithm\n"); + return AUTH_ERROR; + } + + char generated_password[base64_enc_len(hmac_len)]; str sgenerated_password; struct secret *secret_struct; @@ -515,14 +534,17 @@ int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) secret_struct = secret_list; while (secret_struct != NULL) { - LM_DBG("trying secret: %.*s\n", + LM_DBG("trying secret: %.*s (%i)\n", secret_struct->secret_key.len, - secret_struct->secret_key.s); + secret_struct->secret_key.s, + secret_struct->secret_key.len); if (get_pass(susername, &secret_struct->secret_key, &sgenerated_password) == 0) { - LM_DBG("generated password: %.*s\n", - sgenerated_password.len, sgenerated_password.s); + LM_DBG("generated password: %.*s (%i)\n", + sgenerated_password.len, + sgenerated_password.s, + sgenerated_password.len); if (spassword->len == sgenerated_password.len && strncmp(spassword->s, sgenerated_password.s, spassword->len) == 0)

1 0

[kamailio/kamailio] auth_ephemeral broken for sha256/384/512 (Issue #2963)
by Justin LaVelle 08 Dec '21

08 Dec '21

### Description When using `auth_ephemeral` module I found that using anything other than the default sha1 would fail and crash Kamailio.  ### Troubleshooting #### Log Messages  ``` *** stack smashing detected ***: <unknown> terminated 13(85) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 15 0(65) ALERT: <core> [main.c:788]: handle_sigs(): child process 77 exited by a signal 6 0(65) ALERT: <core> [main.c:791]: handle_sigs(): core was generated ``` #### SIP Traffic  ``` N/A ``` ### Possible Solutions  I dug into the code and have a Pull Request to fix the issue. https://github.com/kamailio/kamailio/pull/2962 ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.0-dev2 (x86_64/linux) 3c905e flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 3c905e -dirty compiled on 11:02:49 Dec 4 2021 with gcc 8.3.0 ``` * **Operating System**:  ``` Docker debian:debian on MacOS Mojave 10.14 Linux 47b9de1080dc 5.10.47-linuxkit #1 SMP Sat Jul 3 21:51:47 UTC 2021 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2963

2 2

[kamailio/kamailio] auth_ephemeral: fix sha256/384/512 (PR #2962)
by Justin LaVelle 08 Dec '21

08 Dec '21

- sha256/384/512 broken due to use of sha1 password length, change to check and use proper lengths for each - sha384 mistakenly using sha256 method - update logging to include length You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2962 -- Commit Summary -- * auth_ephemeral: fix sha256/384/512 -- File Changes -- M src/modules/auth_ephemeral/authorize.c (38) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2962.patch https://github.com/kamailio/kamailio/pull/2962.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2962

3 4

git:master:de2bee18: auth_ephemeral: fix sha256/384/512
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: master Commit: de2bee1805c2c89565e9b28afb50fac375d0b5ba URL: https://github.com/kamailio/kamailio/commit/de2bee1805c2c89565e9b28afb50fac… Author: Justin-lavelle <justinl(a)broadvoice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:30:07+01:00 auth_ephemeral: fix sha256/384/512 - sha256/384/512 broken due to use of sha1 password length, change to check and use proper lengths for each - sha384 mistakenly using sha256 method --- Modified: src/modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/de2bee1805c2c89565e9b28afb50fac… Patch: https://github.com/kamailio/kamailio/commit/de2bee1805c2c89565e9b28afb50fac… --- diff --git a/src/modules/auth_ephemeral/authorize.c b/src/modules/auth_ephemeral/authorize.c index bb92a4a2190..ff5012ade51 100644 --- a/src/modules/auth_ephemeral/authorize.c +++ b/src/modules/auth_ephemeral/authorize.c @@ -69,11 +69,11 @@ static inline int get_pass(str *_username, str *_secret, str *_password) break; case AUTHEPH_SHA384: hmac_len = SHA384_DIGEST_LENGTH; - if (HMAC(EVP_sha256(), _secret->s, _secret->len, + if (HMAC(EVP_sha384(), _secret->s, _secret->len, (unsigned char *) _username->s, _username->len, hmac_sha1, &hmac_len) == NULL) { - LM_ERR("HMAC-SHA256 failed\n"); + LM_ERR("HMAC-SHA384 failed\n"); return -1; } break; @@ -88,7 +88,7 @@ static inline int get_pass(str *_username, str *_secret, str *_password) } break; default: - LM_ERR("Inavlid SHA Algorithm\n"); + LM_ERR("Invalid SHA Algorithm\n"); return -1; } @@ -479,7 +479,26 @@ int autheph_proxy(struct sip_msg *_m, char *_realm, char *_p2) int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) { - char generated_password[base64_enc_len(SHA_DIGEST_LENGTH)]; + unsigned int hmac_len = SHA_DIGEST_LENGTH; + switch(autheph_sha_alg) { + case AUTHEPH_SHA1: + hmac_len = SHA_DIGEST_LENGTH; + break; + case AUTHEPH_SHA256: + hmac_len = SHA256_DIGEST_LENGTH; + break; + case AUTHEPH_SHA384: + hmac_len = SHA384_DIGEST_LENGTH; + break; + case AUTHEPH_SHA512: + hmac_len = SHA512_DIGEST_LENGTH; + break; + default: + LM_ERR("Invalid SHA Algorithm\n"); + return AUTH_ERROR; + } + + char generated_password[base64_enc_len(hmac_len)]; str sgenerated_password; struct secret *secret_struct; @@ -515,14 +534,17 @@ int ki_autheph_authenticate(sip_msg_t *_m, str *susername, str *spassword) secret_struct = secret_list; while (secret_struct != NULL) { - LM_DBG("trying secret: %.*s\n", + LM_DBG("trying secret: %.*s (%i)\n", secret_struct->secret_key.len, - secret_struct->secret_key.s); + secret_struct->secret_key.s, + secret_struct->secret_key.len); if (get_pass(susername, &secret_struct->secret_key, &sgenerated_password) == 0) { - LM_DBG("generated password: %.*s\n", - sgenerated_password.len, sgenerated_password.s); + LM_DBG("generated password: %.*s (%i)\n", + sgenerated_password.len, + sgenerated_password.s, + sgenerated_password.len); if (spassword->len == sgenerated_password.len && strncmp(spassword->s, sgenerated_password.s, spassword->len) == 0)

1 0

git:master:743a9d33: src/Makefile.defs: link -lrt if glibc <= 2.17
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Module: kamailio Branch: master Commit: 743a9d33dcc3a6220bba217c14810dafb53355b2 URL: https://github.com/kamailio/kamailio/commit/743a9d33dcc3a6220bba217c14810da… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-08T09:21:53+01:00 src/Makefile.defs: link -lrt if glibc <= 2.17 - GH #2921 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/743a9d33dcc3a6220bba217c14810da… Patch: https://github.com/kamailio/kamailio/commit/743a9d33dcc3a6220bba217c14810da… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index cde1faa6df..8fab3fd812 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -1888,6 +1888,13 @@ ifeq ($(OS), linux) ifeq ($(NO_SELECT),) C_DEFS+=-DHAVE_SELECT endif + ifeq ($(CC_NAME), gcc) + # link librt for glibc <= 2.17 + GLIBCVER:=$(shell ldd --version | head -1 | awk '{ sub(/\./, "", $NF); print $NF }' ) + ifeq ($(shell [ $(GLIBCVER) -le 217 ] && echo librt), librt) + LIBS+=-lrt + endif + endif endif ifeq ($(OS), gnu_kfreebsd)

1 0

Releasing Kamailio 5.3.9 - last in 5.3.x series
by Daniel-Constantin Mierla 08 Dec '21

08 Dec '21

Hello, it is time to mark the end of official packaging for 5.3.x releases, therefore during the next days I am going to cut the v5.3.9 release from branch 5.3, likely on Wednesday, Dec 8, 2021. In other words, if no major regression is detected shortly after this release, the v5.3.9 is going to be the last one from the 5.3 branch. It is strongly recommended to move to a series that is under active maintenance, respectively 5.5.x or 5.4.x. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online Feb 21-24, 2022 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

1 1

[kamailio/kamailio] core: allow empty matches (#2869)
by Bastian Triller 07 Dec '21

07 Dec '21

Anchors like ^ and $ match beginning resp. ending of strings but their matches are zero length, which is ok. The anchors can be used to pre-/append a prefix/suffix via e.g. subst_hf("X-My-Header", "/^/prefix /", "a"); subst_hf("X-My-Header", "/$/ suffix/", "a");   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2869 -- Commit Summary -- * <a href="https://github.com/kamailio/kamailio/pull/2869/commits/63190fb0f0580a276146…">core: allow empty matches</a> -- File Changes -- M src/core/data_lump.c (2) M src/core/re.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2869.patch https://github.com/kamailio/kamailio/pull/2869.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2869

3 7

git:master:4d06b1e4: htable: Modify previous commit to create new API for RPC and keep old API for backwards compatibility
by Olle E. Johansson 07 Dec '21

07 Dec '21

Module: kamailio Branch: master Commit: 4d06b1e4bbd371d247301ece057a3c26ae876a9f URL: https://github.com/kamailio/kamailio/commit/4d06b1e4bbd371d247301ece057a3c2… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2021-12-07T10:12:32+01:00 htable: Modify previous commit to create new API for RPC and keep old API for backwards compatibility Thanks to @miconda for a hint! --- Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/ht_api.h Modified: src/modules/htable/ht_dmq.c Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/4d06b1e4bbd371d247301ece057a3c2… Patch: https://github.com/kamailio/kamailio/commit/4d06b1e4bbd371d247301ece057a3c2… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index 45623e0165..daf088d1f8 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -655,14 +655,33 @@ static void ht_cell_unlink(ht_t *ht, int idx, ht_cell_t *it) ht->entries[idx].esize--; } -/* Delete htable entry + +/* Delete entry in htable. +Return: + - 1 on error in argument + 0 otherwise +*/ +int ht_del_cell(ht_t *ht, str *name) +{ + int ret; + + ret = ht_del_cell_confirm(ht, name); + if (ret == -1) + return -1; + return 0; +} + +/* Delete htable entry with confirmation + +oldapi = 1 means to always return 0 +oldapi = 0 means to return 1 on successful deletion Return: -1 on error in argument 0 on entry not found 1 on entry found and deleted */ -int ht_del_cell(ht_t *ht, str *name) +int ht_del_cell_confirm(ht_t *ht, str *name) { unsigned int idx; unsigned int hid; diff --git a/src/modules/htable/ht_api.h b/src/modules/htable/ht_api.h index b9c1551180..4cee835325 100644 --- a/src/modules/htable/ht_api.h +++ b/src/modules/htable/ht_api.h @@ -91,6 +91,7 @@ int ht_init_tables(void); int ht_destroy(void); int ht_set_cell(ht_t *ht, str *name, int type, int_str *val, int mode); int ht_del_cell(ht_t *ht, str *name); +int ht_del_cell_confirm(ht_t *ht, str *name); ht_cell_t* ht_cell_value_add(ht_t *ht, str *name, int val, ht_cell_t *old); int ht_cell_exists(ht_t *ht, str *name); diff --git a/src/modules/htable/ht_dmq.c b/src/modules/htable/ht_dmq.c index 42e1847d30..6368fb0137 100644 --- a/src/modules/htable/ht_dmq.c +++ b/src/modules/htable/ht_dmq.c @@ -410,6 +410,10 @@ int ht_dmq_replicate_action(ht_dmq_action_t action, str* htname, str* cname, return -1; } +/* Replay DMQ action + +Return 0 for non-error. Allt other returns are parsed as error. +*/ int ht_dmq_replay_action(ht_dmq_action_t action, str* htname, str* cname, int type, int_str* val, int mode) { diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index d491e2e767..78f151daf3 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -1454,7 +1454,7 @@ static void htable_rpc_delete(rpc_t* rpc, void* c) { LM_ERR("dmq replication failed\n"); } - res = ht_del_cell(ht, &keyname); + res = ht_del_cell_confirm(ht, &keyname); if (res == -1) { rpc->fault(c, 500, "Internal error");

1 0

git:master:cbd9fc13: htable: Add return code on successful deletion of item, update RPC commands with replies
by Olle E. Johansson 07 Dec '21

07 Dec '21

Module: kamailio Branch: master Commit: cbd9fc13ab11270df4b541afd9dc9b51517cdd12 URL: https://github.com/kamailio/kamailio/commit/cbd9fc13ab11270df4b541afd9dc9b5… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2021-12-07T08:52:08+01:00 htable: Add return code on successful deletion of item, update RPC commands with replies --- Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/cbd9fc13ab11270df4b541afd9dc9b5… Patch: https://github.com/kamailio/kamailio/commit/cbd9fc13ab11270df4b541afd9dc9b5… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index d4310afa3d..45623e0165 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -655,6 +655,13 @@ static void ht_cell_unlink(ht_t *ht, int idx, ht_cell_t *it) ht->entries[idx].esize--; } +/* Delete htable entry + +Return: + -1 on error in argument + 0 on entry not found + 1 on entry found and deleted +*/ int ht_del_cell(ht_t *ht, str *name) { unsigned int idx; @@ -689,7 +696,7 @@ int ht_del_cell(ht_t *ht, str *name) ht_cell_unlink(ht, idx, it); ht_slot_unlock(ht, idx); ht_cell_free(it); - return 0; + return 1; } it = it->next; } diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index a20b3d6e8d..d491e2e767 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -1438,6 +1438,7 @@ static const char* htable_store_doc[2] = { static void htable_rpc_delete(rpc_t* rpc, void* c) { str htname, keyname; ht_t *ht; + int res; if (rpc->scan(c, "SS", &htname, &keyname) < 2) { rpc->fault(c, 500, "Not enough parameters (htable name & key name"); @@ -1453,7 +1454,17 @@ static void htable_rpc_delete(rpc_t* rpc, void* c) { LM_ERR("dmq replication failed\n"); } - ht_del_cell(ht, &keyname); + res = ht_del_cell(ht, &keyname); + + if (res == -1) { + rpc->fault(c, 500, "Internal error"); + return; + } else if (res == 0) { + rpc->fault(c, 404, "Key not found in htable."); + return; + } + rpc->rpl_printf(c, "Ok. Key deleted."); + return; } /*! \brief RPC htable.get command to get one item */ @@ -1561,7 +1572,7 @@ static void htable_rpc_sets(rpc_t* rpc, void* c) { rpc->fault(c, 500, "Failed to set the item"); return; } - + rpc->rpl_printf(c, "Ok. Key set to new value."); return; } @@ -1596,7 +1607,7 @@ static void htable_rpc_seti(rpc_t* rpc, void* c) { rpc->fault(c, 500, "Failed to set the item"); return; } - + rpc->rpl_printf(c, "Ok. Key set to new value."); return; }

2 4

git:master:7556fbfa: pv: free escaped value for {val.json} transformations
by Daniel-Constantin Mierla 07 Dec '21

07 Dec '21

Module: kamailio Branch: master Commit: 7556fbfa38ac4dad00494944dd02fc60f65cfcb5 URL: https://github.com/kamailio/kamailio/commit/7556fbfa38ac4dad00494944dd02fc6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-07T09:27:44+01:00 pv: free escaped value for {val.json} transformations --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/7556fbfa38ac4dad00494944dd02fc6… Patch: https://github.com/kamailio/kamailio/commit/7556fbfa38ac4dad00494944dd02fc6… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 5d7e0d32b3..5f45fa8e66 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -2580,6 +2580,7 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, return 0; } if(sv.len >= TR_BUFFER_SIZE - 1) { + free(sv.s); LM_ERR("escaped value is too long\n"); return -1; } @@ -2588,6 +2589,7 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, _tr_buffer[sv.len] = '\0'; val->rs.s = _tr_buffer; val->rs.len = sv.len; + free(sv.s); } break; case TR_VAL_JSONQE: @@ -2601,7 +2603,8 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, val->rs.len = 2; val->flags = PV_VAL_STR; } else if(val->flags&PV_TYPE_INT) { - break; + /* no change needed */ + return 0; } else if(val->flags&PV_VAL_STR) { ksr_str_json_escape(&val->rs, &sv, &emode); if(sv.s==NULL) { @@ -2613,6 +2616,7 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, return 0; } if(sv.len >= TR_BUFFER_SIZE - 3) { + free(sv.s); LM_ERR("escaped value is too long\n"); return -1; } @@ -2623,6 +2627,7 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, _tr_buffer[sv.len + 2] = '\0'; val->rs.s = _tr_buffer; val->rs.len = sv.len + 2; + free(sv.s); } break;

1 0

git:master:5b1177df: pv: added {val.jsonqe} - quoted json value
by Daniel-Constantin Mierla 07 Dec '21

07 Dec '21

Module: kamailio Branch: master Commit: 5b1177df2193968a3efc26bcf07eba80a59304e7 URL: https://github.com/kamailio/kamailio/commit/5b1177df2193968a3efc26bcf07eba8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-07T09:27:43+01:00 pv: added {val.jsonqe} - quoted json value --- Modified: src/modules/pv/pv_trans.c Modified: src/modules/pv/pv_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/5b1177df2193968a3efc26bcf07eba8… Patch: https://github.com/kamailio/kamailio/commit/5b1177df2193968a3efc26bcf07eba8… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index e221cb300e..5d7e0d32b3 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -2590,6 +2590,41 @@ int tr_eval_val(struct sip_msg *msg, tr_param_t *tp, int subtype, val->rs.len = sv.len; } break; + case TR_VAL_JSONQE: + if(val->flags&PV_VAL_NULL) { + val->ri = 0; + tr_set_crt_buffer(); + val->rs.s = _tr_buffer; + val->rs.s[0] = '"'; + val->rs.s[1] = '"'; + val->rs.s[2] = '\0'; + val->rs.len = 2; + val->flags = PV_VAL_STR; + } else if(val->flags&PV_TYPE_INT) { + break; + } else if(val->flags&PV_VAL_STR) { + ksr_str_json_escape(&val->rs, &sv, &emode); + if(sv.s==NULL) { + LM_ERR("failed to escape the value\n"); + return -1; + } + if(emode==0) { + /* no escape was needed */ + return 0; + } + if(sv.len >= TR_BUFFER_SIZE - 3) { + LM_ERR("escaped value is too long\n"); + return -1; + } + tr_set_crt_buffer(); + _tr_buffer[0] = '"'; + memcpy(_tr_buffer + 1, sv.s, sv.len); + _tr_buffer[sv.len + 1] = '"'; + _tr_buffer[sv.len + 2] = '\0'; + val->rs.s = _tr_buffer; + val->rs.len = sv.len + 2; + } + break; default: LM_ERR("unknown subtype %d\n", @@ -3847,6 +3882,9 @@ char* tr_parse_val(str* in, trans_t *t) } else if(name.len==4 && strncasecmp(name.s, "json", 4)==0) { t->subtype = TR_VAL_JSON; goto done; + } else if(name.len==6 && strncasecmp(name.s, "jsonqe", 6)==0) { + t->subtype = TR_VAL_JSONQE; + goto done; } diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h index 329f09a8a2..ff5cbebff8 100644 --- a/src/modules/pv/pv_trans.h +++ b/src/modules/pv/pv_trans.h @@ -73,7 +73,7 @@ enum _tr_urialias_subtype { }; enum _tr_val_subtype { - TR_VAL_NONE=0, TR_VAL_N0, TR_VAL_NE, TR_VAL_JSON + TR_VAL_NONE=0, TR_VAL_N0, TR_VAL_NE, TR_VAL_JSON, TR_VAL_JSONQE };

1 0

git:master:9517cf47: htable: Fix spelling errors in error and debug messages
by Olle E. Johansson 07 Dec '21

07 Dec '21

Module: kamailio Branch: master Commit: 9517cf47f512f561c6461edc3cbca3410e773735 URL: https://github.com/kamailio/kamailio/commit/9517cf47f512f561c6461edc3cbca34… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2021-12-07T08:30:51+01:00 htable: Fix spelling errors in error and debug messages --- Modified: src/modules/htable/api.c Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/ht_var.c Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/9517cf47f512f561c6461edc3cbca34… Patch: https://github.com/kamailio/kamailio/commit/9517cf47f512f561c6461edc3cbca34…

1 0

git:5.3:3e21c4d9: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 3e21c4d96e9f88ef9013467ea43acae6c31f307c URL: https://github.com/kamailio/kamailio/commit/3e21c4d96e9f88ef9013467ea43acae… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-12-06T15:01:40+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/3e21c4d96e9f88ef9013467ea43acae… Patch: https://github.com/kamailio/kamailio/commit/3e21c4d96e9f88ef9013467ea43acae… --- diff --git a/src/modules/textops/README b/src/modules/textops/README index 3a9a6658a0..0d6b9347dd 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -222,9 +222,13 @@ Chapter 1. Admin Guide The module implements text based operations over the SIP message processed by Kamailio. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the message - at text level, e.g., regular expression search and replace, Perl-like + at text level, e.g., regular expression search, replace or substitutions, checks for method type, header presence, insert of new - header and date, etc. + header and date, string comparisons, multi-part body operations, etc. + + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. 2. Known Limitations @@ -545,7 +549,7 @@ replace_hdrs_str("Kamailio", "Kamailio SIP Proxy", "a"); 4.15. subst('/re/repl/flags') - Replaces re with repl (sed or perl like). + Replaces re with repl. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -626,7 +630,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ 4.18. subst_body('/re/repl/flags') - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -647,7 +651,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; 4.19. subst_hf(hf, subexp, flags) - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. Meaning of the parameters is as follows: * hf - header field name. @@ -713,7 +717,7 @@ set_reply_body("test", "text/plain"); Example 1.22. filter_body usage ... if (has_body("multipart/mixed")) { - if (filter_body("application/sdp") { + if (filter_body("application/sdp")) { remove_hf("Content-Type"); append_hf("Content-Type: application/sdp\r\n"); } else {

1 0

git:5.3:6a230024: core: clarification for -b cli parameter
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 6a230024af804ab97a2e260e5a644ad1f58d8c76 URL: https://github.com/kamailio/kamailio/commit/6a230024af804ab97a2e260e5a644ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:42:18+01:00 core: clarification for -b cli parameter (cherry picked from commit f068a9ad1892777bfb9a6d1bcfd17a291578c6b6) (cherry picked from commit 68a694676df0e0a0d0a8d0180ebc39f9893b49bc) (cherry picked from commit 748cd0834cc9118fec1ee69b749daad7203346fb) --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/6a230024af804ab97a2e260e5a644ad… Patch: https://github.com/kamailio/kamailio/commit/6a230024af804ab97a2e260e5a644ad… --- diff --git a/src/main.c b/src/main.c index 6ca7feb5ef..0e16009e19 100644 --- a/src/main.c +++ b/src/main.c @@ -164,8 +164,8 @@ Options:\n\ (like for 'alias' global parameter)\n\ -A define Add config pre-processor define (e.g., -A WITH_AUTH,\n\ -A 'FLT_ACC=1', -A 'DEFVAL=\"str-val\"')\n\ - -b nr Maximum receive buffer size which will not be exceeded by\n\ - auto-probing procedure even if OS allows\n\ + -b nr Maximum OS UDP receive buffer size which will not be exceeded by\n\ + auto-probing-and-increase procedure even if OS allows\n\ -c Check configuration file for syntax errors\n\ -d Debugging mode (multiple -d increase the level)\n\ -D Control how daemonize is done:\n\

1 0

git:5.3:3c50cf57: msrp: fix some tcpconn where memory was never cleaned up
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 3c50cf570b41114925e689ca7c5dbd55b8d78d58 URL: https://github.com/kamailio/kamailio/commit/3c50cf570b41114925e689ca7c5dbd5… Author: Nacho Garcia Segovia <nacho.gs(a)zaleos.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:41:41+01:00 msrp: fix some tcpconn where memory was never cleaned up Thanks to Jason Shugart at INdigital. Fix consist of caring of removing references to previously retrieved tcp connections. GH #2880 (cherry picked from commit bf371ccbfa1c89fefcd9d9322ae75189d97fc862) (cherry picked from commit f4ebe527c25ecedb3caffa8a361b5c42a2dd6b88) (cherry picked from commit dccc47c4fbb306150d88be40bf2463d4926c75bd) --- Modified: src/modules/msrp/msrp_netio.c --- Diff: https://github.com/kamailio/kamailio/commit/3c50cf570b41114925e689ca7c5dbd5… Patch: https://github.com/kamailio/kamailio/commit/3c50cf570b41114925e689ca7c5dbd5… --- diff --git a/src/modules/msrp/msrp_netio.c b/src/modules/msrp/msrp_netio.c index 92f7cf525b..859432aa6d 100644 --- a/src/modules/msrp/msrp_netio.c +++ b/src/modules/msrp/msrp_netio.c @@ -74,6 +74,7 @@ int msrp_relay(msrp_frame_t *mf) char *l; int port; sr_event_param_t evp = {0}; + int ret; if(mf->buf.len>=MSRP_MAX_FRAME_SIZE-1) return -1; @@ -169,12 +170,17 @@ int msrp_relay(msrp_frame_t *mf) wsev.len = p - reqbuf; wsev.id = con->id; evp.data = (void *)&wsev; - return sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + tcpconn_put(con); + return ret; } else if (tcp_send(dst, 0, reqbuf, p - reqbuf) < 0) { LM_ERR("forwarding frame failed\n"); + tcpconn_put(con); return -1; } + + tcpconn_put(con); } else if (tcp_send(dst, 0, reqbuf, p - reqbuf) < 0) { LM_ERR("forwarding frame failed\n"); @@ -195,6 +201,7 @@ int msrp_reply(msrp_frame_t *mf, str *code, str *text, str *xhdrs) char *p; char *l; sr_event_param_t evp = {0}; + int ret; /* no reply for a reply */ if(mf->fline.msgtypeid==MSRP_REPLY) @@ -301,7 +308,9 @@ int msrp_reply(msrp_frame_t *mf, str *code, str *text, str *xhdrs) wsev.len = p - rplbuf; wsev.id = con->id; evp.data = (void *)&wsev; - return sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + tcpconn_put(con); + return ret; } else if (tcp_send(&env->srcinfo, 0, rplbuf, p - rplbuf) < 0) {

1 0

git:5.3:00e02d7d: core: io wait - remove log level string from debug message
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 00e02d7db1acdaaaf3193d701ba96081b7337331 URL: https://github.com/kamailio/kamailio/commit/00e02d7db1acdaaaf3193d701ba9608… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:41:52+01:00 core: io wait - remove log level string from debug message (cherry picked from commit 4608914cf9d3878c79560730ddad8e0800c38397) (cherry picked from commit 706b1ceb9cb5139c4464873c8df6d99c541dda7b) (cherry picked from commit 09ac130c86186334a1a1dd37d47f40b17a83b650) --- Modified: src/core/io_wait.h --- Diff: https://github.com/kamailio/kamailio/commit/00e02d7db1acdaaaf3193d701ba9608… Patch: https://github.com/kamailio/kamailio/commit/00e02d7db1acdaaaf3193d701ba9608… --- diff --git a/src/core/io_wait.h b/src/core/io_wait.h index 04186c72ad..f83c6ff6bf 100644 --- a/src/core/io_wait.h +++ b/src/core/io_wait.h @@ -371,7 +371,7 @@ inline static int io_watch_add( io_wait_h* h, LM_CRIT("maximum fd number exceeded: %d/%d\n", h->fd_no, h->max_fd_no); goto error; } - DBG("DBG: io_watch_add(%p, %d, %d, %p), fd_no=%d\n", + DBG("processing io_watch_add(%p, %d, %d, %p) - fd_no=%d\n", h, fd, type, data, h->fd_no); /* hash sanity check */ e=get_fd_map(h, fd);

1 0

git:5.3:31947769: textops: docs update to state regex params expect posix format
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 319477691bfed48749eea5c40626f033bfbcf842 URL: https://github.com/kamailio/kamailio/commit/319477691bfed48749eea5c40626f03… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:40:43+01:00 textops: docs update to state regex params expect posix format (cherry picked from commit b19aab7fe00f72d0c9e54a7a106ec7a065a3d02b) (cherry picked from commit a78acd8f40ed38b161a075bef74febd93acb092c) (cherry picked from commit e4eda3f5131e2788670a1f9f8342a2889e9b1107) --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/319477691bfed48749eea5c40626f03… Patch: https://github.com/kamailio/kamailio/commit/319477691bfed48749eea5c40626f03… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 4d5a7372ed..59eba31655 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -19,9 +19,15 @@ The module implements text based operations over the SIP message processed by &kamailio;. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the - message at text level, e.g., regular expression search and replace, - Perl-like substitutions, checks for method type, header presence, - insert of new header and date, etc. + message at text level, e.g., regular expression search, replace + or substitutions, checks for method type, header presence, + insert of new header and date, string comparisons, multi-part body + operations, etc. + </para> + <para> + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. </para> </section> <section> @@ -555,7 +561,7 @@ replace_hdrs_str("&kamailio;", "&kamailio; SIP Proxy", "a"); <function moreinfo="none">subst('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like). + Replaces re with repl. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -692,7 +698,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ <function moreinfo="none">subst_body('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -732,7 +738,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; <function moreinfo="none">subst_hf(hf, subexp, flags)</function> </title> <para> - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

1 0

git:5.3:cfaf76db: timer: extend internal static HTTP message to have one header
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: cfaf76db114ff10005ee37ce33aa05b4b24116fd URL: https://github.com/kamailio/kamailio/commit/cfaf76db114ff10005ee37ce33aa05b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:40:52+01:00 timer: extend internal static HTTP message to have one header (cherry picked from commit c3629f877500373028d2c7cdefd976cddda31c15) (cherry picked from commit a9c5f3e4d29dccda79eee8e594d4316e32196db5) (cherry picked from commit 3d5f1a75a1413126532b6bed41f2e5ec7acc57fb) --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/cfaf76db114ff10005ee37ce33aa05b… Patch: https://github.com/kamailio/kamailio/commit/cfaf76db114ff10005ee37ce33aa05b… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 9880a8420b0..224a6bed572 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -159,7 +159,7 @@ static unsigned int timer_msg_no = 0; static ticks_t timer_handler(ticks_t ticks, struct timer_ln* tl, void* data) { /*?min length of first line of message is 16 char!?*/ -#define MSG "GET /timer HTTP/0.9\n\n" +#define MSG "GET /timer HTTP/0.9\r\nUser-Agent: internal\r\n\r\n" sip_msg_t* msg; timer_action_t *a; run_act_ctx_t ra_ctx;

1 0

git:5.3:4ba9945e: core: parse main headers after updating msg buffer
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 4ba9945e26199b5a64b2e5cd02062ef9f866ac1a URL: https://github.com/kamailio/kamailio/commit/4ba9945e26199b5a64b2e5cd02062ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:41:03+01:00 core: parse main headers after updating msg buffer - same group of headers as for the case of receiving the message - applies for msg_apply_changes() as well - related to GH #2877 (cherry picked from commit d5c1b4693b6e47b4123b5f9417b5fd88d4dafd1f) (cherry picked from commit 992c5a349454e40c87c8918283ffde7302da9d8e) (cherry picked from commit 49f3ec66c9e187584f403ca19e3b436abd20376a) --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/4ba9945e26199b5a64b2e5cd02062ef… Patch: https://github.com/kamailio/kamailio/commit/4ba9945e26199b5a64b2e5cd02062ef… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index bb8d60c1ce..cc9943fe74 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -3284,7 +3284,13 @@ int sip_msg_update_buffer(sip_msg_t *msg, str *obuf) * valid/safe for config */ return 0; } - + if(parse_headers(msg, HDR_FROM_F|HDR_TO_F|HDR_CALLID_F|HDR_CSEQ_F, 0) < 0) { + LM_ERR("parsing main headers of new sip message failed [[%.*s]]\n", + msg->len, msg->buf); + /* exit config execution - sip_msg_t structure is no longer + * valid/safe for config */ + return 0; + } return 1; }

1 0

git:5.3:401c65ba: textops: fix broken example for filter_body
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.3 Commit: 401c65ba3a8168af370c9a3e9c9e445eb66ebbf3 URL: https://github.com/kamailio/kamailio/commit/401c65ba3a8168af370c9a3e9c9e445… Author: Sven Uhlig <git(a)resident-uhlig.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:40:20+01:00 textops: fix broken example for filter_body (cherry picked from commit f8c1cabaeadb8ee145174843ed11bbbb0c3276b0) (cherry picked from commit d9c34770caa305fc6cafa18e255f3c05342305dc) --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/401c65ba3a8168af370c9a3e9c9e445… Patch: https://github.com/kamailio/kamailio/commit/401c65ba3a8168af370c9a3e9c9e445… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 47d482aec7e..4d5a7372edb 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -859,7 +859,7 @@ set_reply_body("test", "text/plain"); <programlisting format="linespecific"> ... if (has_body("multipart/mixed")) { - if (filter_body("application/sdp") { + if (filter_body("application/sdp")) { remove_hf("Content-Type"); append_hf("Content-Type: application/sdp\r\n"); } else {

1 0

git:5.4:2296c8d8: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 2296c8d889797daf0eb5cedb4970f8f957a42f20 URL: https://github.com/kamailio/kamailio/commit/2296c8d889797daf0eb5cedb4970f8f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-12-06T14:46:31+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/sipdump/README Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/2296c8d889797daf0eb5cedb4970f8f… Patch: https://github.com/kamailio/kamailio/commit/2296c8d889797daf0eb5cedb4970f8f… --- diff --git a/src/modules/sipdump/README b/src/modules/sipdump/README index e1841bf545..01d3a721df 100644 --- a/src/modules/sipdump/README +++ b/src/modules/sipdump/README @@ -289,8 +289,8 @@ event_route[sipdump:msg] { examples shows how to delete the files older than 2 days using Kamailio modules. ... -loadmodule "rtimer.so -loadmodule "exec.so +loadmodule "rtimer.so" +loadmodule "exec.so" ... modparam("rtimer", "timer", "name=tjobs;interval=300;mode=1;") modparam("rtimer", "exec", "timer=tjobs;route=TCLEAN") diff --git a/src/modules/textops/README b/src/modules/textops/README index dd1fc06a8b..1810c74782 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -237,9 +237,13 @@ Chapter 1. Admin Guide The module implements text based operations over the SIP message processed by Kamailio. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the message - at text level, e.g., regular expression search and replace, Perl-like + at text level, e.g., regular expression search, replace or substitutions, checks for method type, header presence, insert of new - header and date, etc. + header and date, string comparisons, multi-part body operations, etc. + + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. 2. Known Limitations @@ -565,7 +569,7 @@ replace_hdrs_str("Kamailio", "Kamailio SIP Proxy", "a"); 4.15. subst('/re/repl/flags') - Replaces re with repl (sed or perl like). + Replaces re with repl. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -646,7 +650,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ 4.18. subst_body('/re/repl/flags') - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -667,7 +671,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; 4.19. subst_hf(hf, subexp, flags) - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. Meaning of the parameters is as follows: * hf - header field name.

1 0

git:5.4:09ac130c: core: io wait - remove log level string from debug message
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 09ac130c86186334a1a1dd37d47f40b17a83b650 URL: https://github.com/kamailio/kamailio/commit/09ac130c86186334a1a1dd37d47f40b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:31:35+01:00 core: io wait - remove log level string from debug message (cherry picked from commit 4608914cf9d3878c79560730ddad8e0800c38397) (cherry picked from commit 706b1ceb9cb5139c4464873c8df6d99c541dda7b) --- Modified: src/core/io_wait.h --- Diff: https://github.com/kamailio/kamailio/commit/09ac130c86186334a1a1dd37d47f40b… Patch: https://github.com/kamailio/kamailio/commit/09ac130c86186334a1a1dd37d47f40b… --- diff --git a/src/core/io_wait.h b/src/core/io_wait.h index 04186c72ad..f83c6ff6bf 100644 --- a/src/core/io_wait.h +++ b/src/core/io_wait.h @@ -371,7 +371,7 @@ inline static int io_watch_add( io_wait_h* h, LM_CRIT("maximum fd number exceeded: %d/%d\n", h->fd_no, h->max_fd_no); goto error; } - DBG("DBG: io_watch_add(%p, %d, %d, %p), fd_no=%d\n", + DBG("processing io_watch_add(%p, %d, %d, %p) - fd_no=%d\n", h, fd, type, data, h->fd_no); /* hash sanity check */ e=get_fd_map(h, fd);

1 0

git:5.4:748cd083: core: clarification for -b cli parameter
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 748cd0834cc9118fec1ee69b749daad7203346fb URL: https://github.com/kamailio/kamailio/commit/748cd0834cc9118fec1ee69b749daad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:32:09+01:00 core: clarification for -b cli parameter (cherry picked from commit f068a9ad1892777bfb9a6d1bcfd17a291578c6b6) (cherry picked from commit 68a694676df0e0a0d0a8d0180ebc39f9893b49bc) --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/748cd0834cc9118fec1ee69b749daad… Patch: https://github.com/kamailio/kamailio/commit/748cd0834cc9118fec1ee69b749daad… --- diff --git a/src/main.c b/src/main.c index 3a67f841e6..6b53133e31 100644 --- a/src/main.c +++ b/src/main.c @@ -170,8 +170,8 @@ Options:\n\ default is yes.\n\ -A define Add config pre-processor define (e.g., -A WITH_AUTH,\n\ -A 'FLT_ACC=1', -A 'DEFVAL=\"str-val\"')\n\ - -b nr Maximum receive buffer size which will not be exceeded by\n\ - auto-probing procedure even if OS allows\n\ + -b nr Maximum OS UDP receive buffer size which will not be exceeded by\n\ + auto-probing-and-increase procedure even if OS allows\n\ -c Check configuration file for syntax errors\n\ -d Debugging level control (multiple -d to increase the level from 0)\n\ --debug=val Debugging level value\n\

1 0

git:5.4:afc7f4c2: db_redis: don't leave unconsumed redis replies in case of error on update
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: afc7f4c2e9c8c9176e655303fa1d949cbb4ecdec URL: https://github.com/kamailio/kamailio/commit/afc7f4c2e9c8c9176e655303fa1d949… Author: Andrii Pogrebennyk <andrii(a)ng-voice.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:32:25+01:00 db_redis: don't leave unconsumed redis replies in case of error on update Execute db_redis_consume_replies on failed update same as in db_redis_insert: if db_redis_perform_update encounters an error it was leaving unconsumed data thus causing unexpected reply later on when reading from the same connection. (cherry picked from commit bbd7b2ed5827252680e9d8949c193699da0a76b2) (cherry picked from commit 7b371b77702471e62d8bd2ee957c44df73f1db80) --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/afc7f4c2e9c8c9176e655303fa1d949… Patch: https://github.com/kamailio/kamailio/commit/afc7f4c2e9c8c9176e655303fa1d949… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index c9a25adf36..ac1bd2b946 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -2249,6 +2249,7 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con db_redis_key_free(&all_type_keys); db_redis_key_free(&new_type_keys); + db_redis_consume_replies(con); return 0; error: @@ -2260,6 +2261,7 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con db_redis_key_free(&type_keys); db_redis_key_free(&set_keys); db_redis_key_free(&new_type_keys); + db_redis_consume_replies(con); return -1; }

1 0

git:5.4:88ec70c9: tls: print src/dst port in error message
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 88ec70c9b056a91a187a68dcb0aa88345a5874e7 URL: https://github.com/kamailio/kamailio/commit/88ec70c9b056a91a187a68dcb0aa883… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:30:16+01:00 tls: print src/dst port in error message - related to GH #2872 (cherry picked from commit daedf1201c2776ccc1040e03f8f63d256e75a43a) (cherry picked from commit 058ed2e1e4fdaf4ff99cd6db5a96793d6b420483) --- Modified: src/modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/88ec70c9b056a91a187a68dcb0aa883… Patch: https://github.com/kamailio/kamailio/commit/88ec70c9b056a91a187a68dcb0aa883… --- diff --git a/src/modules/tls/tls_server.c b/src/modules/tls/tls_server.c index 5ca11894f7..53c806a376 100644 --- a/src/modules/tls/tls_server.c +++ b/src/modules/tls/tls_server.c @@ -1284,10 +1284,10 @@ int tls_h_read_f(struct tcp_connection* c, int* flags) TLS_ERR(err_src); memset(ip_buf, 0, sizeof(ip_buf)); ip_addr2sbuf(&(c->rcv.src_ip), ip_buf, sizeof(ip_buf)); - ERR("source IP: %s\n", ip_buf); + ERR("src addr: %s:%d\n", ip_buf, c->rcv.src_port); memset(ip_buf, 0, sizeof(ip_buf)); ip_addr2sbuf(&(c->rcv.dst_ip), ip_buf, sizeof(ip_buf)); - ERR("destination IP: %s\n", ip_buf); + ERR("dst addr: %s:%d\n", ip_buf, c->rcv.dst_port); goto error; #if OPENSSL_VERSION_NUMBER >= 0x00907000L /*0.9.7*/

1 0

git:5.4:dccc47c4: msrp: fix some tcpconn where memory was never cleaned up
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: dccc47c4fbb306150d88be40bf2463d4926c75bd URL: https://github.com/kamailio/kamailio/commit/dccc47c4fbb306150d88be40bf2463d… Author: Nacho Garcia Segovia <nacho.gs(a)zaleos.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:30:38+01:00 msrp: fix some tcpconn where memory was never cleaned up Thanks to Jason Shugart at INdigital. Fix consist of caring of removing references to previously retrieved tcp connections. GH #2880 (cherry picked from commit bf371ccbfa1c89fefcd9d9322ae75189d97fc862) (cherry picked from commit f4ebe527c25ecedb3caffa8a361b5c42a2dd6b88) --- Modified: src/modules/msrp/msrp_netio.c --- Diff: https://github.com/kamailio/kamailio/commit/dccc47c4fbb306150d88be40bf2463d… Patch: https://github.com/kamailio/kamailio/commit/dccc47c4fbb306150d88be40bf2463d… --- diff --git a/src/modules/msrp/msrp_netio.c b/src/modules/msrp/msrp_netio.c index 92f7cf525b8..859432aa6d2 100644 --- a/src/modules/msrp/msrp_netio.c +++ b/src/modules/msrp/msrp_netio.c @@ -74,6 +74,7 @@ int msrp_relay(msrp_frame_t *mf) char *l; int port; sr_event_param_t evp = {0}; + int ret; if(mf->buf.len>=MSRP_MAX_FRAME_SIZE-1) return -1; @@ -169,12 +170,17 @@ int msrp_relay(msrp_frame_t *mf) wsev.len = p - reqbuf; wsev.id = con->id; evp.data = (void *)&wsev; - return sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + tcpconn_put(con); + return ret; } else if (tcp_send(dst, 0, reqbuf, p - reqbuf) < 0) { LM_ERR("forwarding frame failed\n"); + tcpconn_put(con); return -1; } + + tcpconn_put(con); } else if (tcp_send(dst, 0, reqbuf, p - reqbuf) < 0) { LM_ERR("forwarding frame failed\n"); @@ -195,6 +201,7 @@ int msrp_reply(msrp_frame_t *mf, str *code, str *text, str *xhdrs) char *p; char *l; sr_event_param_t evp = {0}; + int ret; /* no reply for a reply */ if(mf->fline.msgtypeid==MSRP_REPLY) @@ -301,7 +308,9 @@ int msrp_reply(msrp_frame_t *mf, str *code, str *text, str *xhdrs) wsev.len = p - rplbuf; wsev.id = con->id; evp.data = (void *)&wsev; - return sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + ret = sr_event_exec(SREV_TCP_WS_FRAME_OUT, &evp); + tcpconn_put(con); + return ret; } else if (tcp_send(&env->srcinfo, 0, rplbuf, p - rplbuf) < 0) {

1 0

git:5.4:3d5f1a75: timer: extend internal static HTTP message to have one header
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 3d5f1a75a1413126532b6bed41f2e5ec7acc57fb URL: https://github.com/kamailio/kamailio/commit/3d5f1a75a1413126532b6bed41f2e5e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:28:02+01:00 timer: extend internal static HTTP message to have one header (cherry picked from commit c3629f877500373028d2c7cdefd976cddda31c15) (cherry picked from commit a9c5f3e4d29dccda79eee8e594d4316e32196db5) --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/3d5f1a75a1413126532b6bed41f2e5e… Patch: https://github.com/kamailio/kamailio/commit/3d5f1a75a1413126532b6bed41f2e5e… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 9880a8420b..224a6bed57 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -159,7 +159,7 @@ static unsigned int timer_msg_no = 0; static ticks_t timer_handler(ticks_t ticks, struct timer_ln* tl, void* data) { /*?min length of first line of message is 16 char!?*/ -#define MSG "GET /timer HTTP/0.9\n\n" +#define MSG "GET /timer HTTP/0.9\r\nUser-Agent: internal\r\n\r\n" sip_msg_t* msg; timer_action_t *a; run_act_ctx_t ra_ctx;

1 0

git:5.4:49f3ec66: core: parse main headers after updating msg buffer
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 49f3ec66c9e187584f403ca19e3b436abd20376a URL: https://github.com/kamailio/kamailio/commit/49f3ec66c9e187584f403ca19e3b436… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:29:42+01:00 core: parse main headers after updating msg buffer - same group of headers as for the case of receiving the message - applies for msg_apply_changes() as well - related to GH #2877 (cherry picked from commit d5c1b4693b6e47b4123b5f9417b5fd88d4dafd1f) (cherry picked from commit 992c5a349454e40c87c8918283ffde7302da9d8e) --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/49f3ec66c9e187584f403ca19e3b436… Patch: https://github.com/kamailio/kamailio/commit/49f3ec66c9e187584f403ca19e3b436… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 1ecb566592..683b4a3b00 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -3315,7 +3315,13 @@ int sip_msg_update_buffer(sip_msg_t *msg, str *obuf) * valid/safe for config */ return 0; } - + if(parse_headers(msg, HDR_FROM_F|HDR_TO_F|HDR_CALLID_F|HDR_CSEQ_F, 0) < 0) { + LM_ERR("parsing main headers of new sip message failed [[%.*s]]\n", + msg->len, msg->buf); + /* exit config execution - sip_msg_t structure is no longer + * valid/safe for config */ + return 0; + } return 1; }

1 0

git:5.4:1dcda242: sipdump: docs - fix example config snippet
by Daniel-Constantin Mierla 06 Dec '21

06 Dec '21

Module: kamailio Branch: 5.4 Commit: 1dcda2425d28c182cf2b85f6f53ebe94c4f28ea1 URL: https://github.com/kamailio/kamailio/commit/1dcda2425d28c182cf2b85f6f53ebe9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-12-06T14:29:56+01:00 sipdump: docs - fix example config snippet (cherry picked from commit f202cfe647c6a1ac92a3c2b8e2ee056d678fb802) (cherry picked from commit 8df8974bb0f9754b126cac75eed76360e12d8a22) --- Modified: src/modules/sipdump/doc/sipdump_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1dcda2425d28c182cf2b85f6f53ebe9… Patch: https://github.com/kamailio/kamailio/commit/1dcda2425d28c182cf2b85f6f53ebe9… --- diff --git a/src/modules/sipdump/doc/sipdump_admin.xml b/src/modules/sipdump/doc/sipdump_admin.xml index 0a603c2803..d6a679d215 100644 --- a/src/modules/sipdump/doc/sipdump_admin.xml +++ b/src/modules/sipdump/doc/sipdump_admin.xml @@ -309,8 +309,8 @@ event_route[sipdump:msg] { </para> <programlisting format="linespecific"> ... -loadmodule "rtimer.so -loadmodule "exec.so +loadmodule "rtimer.so" +loadmodule "exec.so" ... modparam("rtimer", "timer", "name=tjobs;interval=300;mode=1;") modparam("rtimer", "exec", "timer=tjobs;route=TCLEAN")

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev