- sr-dev - kamailio.org

[kamailio/kamailio] siptrace: aadded siptrace pseudo var (#2752)
by sergey-safarov 09 Jun '21

09 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I want to get the source (destination) IP address of the message during `event_route[siptrace:msg]` route. I added the ability to get socket info in this route block. Now added ``` $siptrace(src_uri) $siptrace(dst_uri) ``` This pseudovars return string like ``` udp:8.8.8.8:5060 ``` I think `src_uri` and `dst_uri` is not correct here because this socket info, not SIP uri. I expecting suggestion on how to get these params and from current implementation: ``` src_ip src_port src_proto dst_ip dst_port dst_proto ``` As reference, I take `sipdump` pseudovariable You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2752 -- Commit Summary -- * siptrace: aadded siptrace pseudo var -- File Changes -- M src/modules/siptrace/siptrace.c (72) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2752.patch https://github.com/kamailio/kamailio/pull/2752.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2752

2 6

git:master:7bf207bf: siptrace: use src/dst_addr instead src/dst_uri for $siptrace(...) vars
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 7bf207bf6bd60bd1c50fb9321d31c4d48562b5b7 URL: https://github.com/kamailio/kamailio/commit/7bf207bf6bd60bd1c50fb9321d31c4d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:31:31+02:00 siptrace: use src/dst_addr instead src/dst_uri for $siptrace(...) vars - the format is proto:ip:proto, not a sip uri --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/7bf207bf6bd60bd1c50fb9321d31c4d… Patch: https://github.com/kamailio/kamailio/commit/7bf207bf6bd60bd1c50fb9321d31c4d… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index b411886f54..89a0618d02 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2528,10 +2528,10 @@ int pv_parse_siptrace_name(pv_spec_t *sp, str *in) switch(in->len) { - case 7: - if(strncmp(in->s, "src_uri", 7)==0) + case 8: + if(strncmp(in->s, "src_addr", 8)==0) sp->pvp.pvn.u.isname.name.n = 0; - else if(strncmp(in->s, "dst_uri", 7)==0) + else if(strncmp(in->s, "dst_addr", 8)==0) sp->pvp.pvn.u.isname.name.n = 1; else goto error; break;

1 0

git:master:36817c3e: core: cfg.lex - accept IPv4/6 as alternative keywords for INET/6
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 36817c3ea53daae9706c1caa695af98f9ca987bd URL: https://github.com/kamailio/kamailio/commit/36817c3ea53daae9706c1caa695af98… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:19:24+02:00 core: cfg.lex - accept IPv4/6 as alternative keywords for INET/6 --- Modified: src/core/cfg.lex --- Diff: https://github.com/kamailio/kamailio/commit/36817c3ea53daae9706c1caa695af98… Patch: https://github.com/kamailio/kamailio/commit/36817c3ea53daae9706c1caa695af98… --- diff --git a/src/core/cfg.lex b/src/core/cfg.lex index ff8096d9f2..45d9114c05 100644 --- a/src/core/cfg.lex +++ b/src/core/cfg.lex @@ -512,8 +512,8 @@ TLS "tls"|"TLS" SCTP "sctp"|"SCTP" WS "ws"|"WS" WSS "wss"|"WSS" -INET "inet"|"INET" -INET6 "inet6"|"INET6" +INET "inet"|"INET"|"ipv4"|"IPv4"|"IPV4" +INET6 "inet6"|"INET6"|"ipv6"|"IPv6"|"IPV6" SSLv23 "sslv23"|"SSLv23"|"SSLV23" SSLv2 "sslv2"|"SSLv2"|"SSLV2" SSLv3 "sslv3"|"SSLv3"|"SSLV3"

1 0

git:master:e5f13086: pv: support INET/6 as alternative IPv4/6 for $K(key)
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: e5f130860d909e9a4348db170d4001332e90427e URL: https://github.com/kamailio/kamailio/commit/e5f130860d909e9a4348db170d40013… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:27:57+02:00 pv: support INET/6 as alternative IPv4/6 for $K(key) - these are the keywords in the config --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/e5f130860d909e9a4348db170d40013… Patch: https://github.com/kamailio/kamailio/commit/e5f130860d909e9a4348db170d40013… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 0af3e640cd..6e70010816 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3632,6 +3632,7 @@ int pv_parse_K_name(pv_spec_p sp, str *in) if(strncmp(in->s, "WS", 2)==0) sp->pvp.pvn.u.isname.name.n = 6; else goto error; + break; case 3: if(strncmp(in->s, "UDP", 3)==0) sp->pvp.pvn.u.isname.name.n = 2; @@ -3646,12 +3647,19 @@ int pv_parse_K_name(pv_spec_p sp, str *in) case 4: if(strncmp(in->s, "IPv4", 4)==0) sp->pvp.pvn.u.isname.name.n = 0; + else if(strncmp(in->s, "INET", 4)==0) + sp->pvp.pvn.u.isname.name.n = 0; else if(strncmp(in->s, "IPv6", 4)==0) sp->pvp.pvn.u.isname.name.n = 1; else if(strncmp(in->s, "SCTP", 4)==0) sp->pvp.pvn.u.isname.name.n = 5; else goto error; break; + case 5: + if(strncmp(in->s, "INET6", 5)==0) + sp->pvp.pvn.u.isname.name.n = 1; + else goto error; + break; default: goto error; }

1 0

git:master:a8c9d0ae: pv: added missing WS and WSS to $K(key) variable
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: a8c9d0ae4fbafba89ef12737419037d141eed1d3 URL: https://github.com/kamailio/kamailio/commit/a8c9d0ae4fbafba89ef12737419037d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:15:38+02:00 pv: added missing WS and WSS to $K(key) variable --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/a8c9d0ae4fbafba89ef12737419037d… Patch: https://github.com/kamailio/kamailio/commit/a8c9d0ae4fbafba89ef12737419037d… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index a4bfe21985..0af3e640cd 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3628,6 +3628,10 @@ int pv_parse_K_name(pv_spec_p sp, str *in) switch(in->len) { + case 2: + if(strncmp(in->s, "WS", 2)==0) + sp->pvp.pvn.u.isname.name.n = 6; + else goto error; case 3: if(strncmp(in->s, "UDP", 3)==0) sp->pvp.pvn.u.isname.name.n = 2; @@ -3635,6 +3639,8 @@ int pv_parse_K_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 3; else if(strncmp(in->s, "TLS", 3)==0) sp->pvp.pvn.u.isname.name.n = 4; + else if(strncmp(in->s, "WSS", 3)==0) + sp->pvp.pvn.u.isname.name.n = 7; else goto error; break; case 4: @@ -3706,6 +3712,10 @@ int pv_get_K(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_uintval(msg, param, res, PROTO_TLS); case 5: return pv_get_uintval(msg, param, res, PROTO_SCTP); + case 6: + return pv_get_uintval(msg, param, res, PROTO_WS); + case 7: + return pv_get_uintval(msg, param, res, PROTO_WSS); default: return pv_get_uintval(msg, param, res, AF_INET); }

1 0

git:master:11acfd85: pv: extended $nh(k) to work for replies using 2nd via
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 11acfd857d1b9c5e7e4c10efd8f1eb239c77e8a8 URL: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T12:02:08+02:00 pv: extended $nh(k) to work for replies using 2nd via --- Modified: src/modules/pv/pv_branch.c --- Diff: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… Patch: https://github.com/kamailio/kamailio/commit/11acfd857d1b9c5e7e4c10efd8f1eb2… --- diff --git a/src/modules/pv/pv_branch.c b/src/modules/pv/pv_branch.c index d3e34c681a..594a88f1f5 100644 --- a/src/modules/pv/pv_branch.c +++ b/src/modules/pv/pv_branch.c @@ -669,6 +669,81 @@ int pv_parse_rcv_name(pv_spec_p sp, str *in) return -1; } +/** + * + */ +int pv_get_nh_reply(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res) +{ + static char rpluribuf[MAX_URI_SIZE]; + str suri = STR_NULL; + str host = STR_NULL; + str sproto = STR_NULL; + unsigned int port = 0; + + if(parse_headers( msg, HDR_VIA2_F, 0)==-1) { + LM_DBG("no 2nd via parsed\n"); + return pv_get_null(msg, param, res); + } + if((msg->via2==0) || (msg->via2->error!=PARSE_OK)) { + return pv_get_null(msg, param, res); + } + if(msg->via2->rport && msg->via2->rport->value.s) { + LM_DBG("using 'rport'\n"); + if(str2int(&msg->via2->rport->value, &port)<0) { + LM_ERR("invalid rport value\n"); + return pv_get_null(msg, param, res); + } + } + if(msg->via2->received) { + LM_DBG("using 'received'\n"); + host = msg->via2->received->value; + } else { + LM_DBG("using via host\n"); + host = msg->via2->host; + } + if(port==0) { + port = (msg->via2->port)?msg->via2->port:SIP_PORT; + } + + switch(param->pvn.u.isname.name.n) { + case 0: /* uri */ + if(get_valid_proto_string(msg->via2->proto, 1, 0, &sproto)<0) { + sproto.s = "udp"; + sproto.len = 3; + } + suri.len = snprintf(rpluribuf, MAX_URI_SIZE, "sip:%.*s:%u;transport=%.*s", + host.len, host.s, port, sproto.len, sproto.s); + if(suri.len<=0 || suri.len>=MAX_URI_SIZE) { + LM_DBG("building the dst uri failed (%d)\n", suri.len); + return pv_get_null(msg, param, res); + } + suri.s = rpluribuf; + return pv_get_strval(msg, param, res, &suri); + case 1: /* user - not in Via */ + return pv_get_null(msg, param, res); + case 2: /* domain/host */ + return pv_get_strval(msg, param, res, &host); + case 3: /* port */ + return pv_get_uintval(msg, param, res, port); + case 4: /* proto */ + if(get_valid_proto_string(msg->via2->proto, 0, 0, &sproto)<0) { + /* default to udp */ + sproto.s = "udp"; + sproto.len = 3; + return pv_get_strintval(msg, param, res, &sproto, PROTO_UDP); + } + return pv_get_strintval(msg, param, res, &sproto, + (int)msg->via2->proto); + } + + LM_ERR("unknown specifier\n"); + return pv_get_null(msg, param, res); +} + +/** + * + */ int pv_get_nh(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { @@ -678,8 +753,10 @@ int pv_get_nh(struct sip_msg *msg, pv_param_t *param, if(msg==NULL || res==NULL) return -1; - if(msg->first_line.type == SIP_REPLY) /* REPLY doesnt have r/d-uri */ - return pv_get_null(msg, param, res); + if(msg->first_line.type == SIP_REPLY) { + /* REPLY doesnt have r/d-uri - use second Via */ + return pv_get_nh_reply(msg, param, res); + } if (msg->dst_uri.s != NULL && msg->dst_uri.len>0) {

1 0

[kamailio/kamailio] app_perl: Ignore __DIE__ signals that come from eval blocks (#2745)
by rodolfojcj 09 Jun '21

09 Jun '21

### Description If possible, I would like that the `kamailio/src/modules/app_perl/lib/perl/Kamailio.pm` file does not generate error messages to the system log files, which are not actual errors and are caused by `eval` blocks of third-party Perl modules that my code depends on. To illustrate the current setup, let's consider the following: - In file `/etc/kamailio/kamailio_52.cfg` ```perl modparam( "app_perl", "filename", "/opt/myprogram/perllib/MyKamailio.pm" ) ``` - In file `/opt/myprogram/perllib/MyKamailio.pm`: ```perl use Crypt::JWT qw( decode_jwt encode_jwt ); ``` - It happens that `Crypt::JWT` depends on `CryptX`, which in turn needs a `JSON::XS` implementation, which could be either `Cpanel::JSON::XS` or `JSON::XS`or `JSON::PP`, in that order of preference. That need is resolved at runtime, as we can see in the following code fragment taken from the file at https://github.com/DCIT/perl-CryptX/blob/master/lib/CryptX.pm: ```perl BEGIN { if (eval { require Cpanel::JSON::XS }) { Cpanel::JSON::XS->import(qw(encode_json decode_json)); $has_json = 1; } elsif (eval { require JSON::XS }) { JSON::XS->import(qw(encode_json decode_json)); $has_json = 2; } elsif (eval { require JSON::PP }) { JSON::PP->import(qw(encode_json decode_json)); $has_json = 3; } else { $has_json = 0; } } ``` - In my system, `Cpanel::JSON::XS` is not installed because it is not needed. I could install it, but unfortunately that module intermittently causes a segmentation fault, as described in the issue report at https://github.com/rurban/Cpanel-JSON-XS/issues/179. ### Expected behavior I would expect two things: - The operating system log files, like `/var/log/syslog`, adds only entries like the following ones after restarting Kamailio: May 25 14:30:06 myserver systemd[1]: kamailio.service: Succeeded. May 25 14:30:06 myserver systemd[1]: Stopped Kamailio server. May 25 14:30:06 myserver systemd[1]: Starting Kamailio server... May 25 14:30:06 myserver systemd[1]: Started Kamailio server. - The output of commands like `systemctl status kamailio.service` only shows informational messages of success. ### Actual observed behavior - The operating system log files, like `/var/log/syslog`, also adds error messages like the following one after restarting Kamailio: May 25 14:30:06 myserver /sbin/kamailio[1827476]: ERROR: app_perl [kamailioxs.xs:1041]: XS_Kamailio__Message_log(): perl error: Can't locate Cpanel/JSON/XS.pm in @INC (you may need to install the Cpanel::JSON::XS module) (@INC contains: /opt/myprogram/perllib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl) at /usr/local/lib/x86_64-linux-gnu/perl/5.30.0/CryptX.pm line 14. - The output of commands like `systemctl status kamailio.service` adds that same error message at its end. ### What could be changed in Kamailio? The `kamailio/src/modules/app_perl/lib/perl/Kamailio.pm` file could ignore, or bypass, the `__DIE__` signals coming from `eval` blocks, like this changed code fragment shows: ```perl $SIG{'__DIE__'} = sub { die @_ if( $^S or not defined $^S ); Kamailio::Message::log(undef, L_ERR, "perl error: $_[0]\n"); }; ``` That changed is based on the following references: - The [Override die with END or CORE::GLOBAL::die](https://www.effectiveperlprogramming.com/2011/05/overrid… article, which says: > There’s a Perl special variable that can help. The documentation for die recommends that you start your `__DIE__` handler by checking `$^S` before you continue. Inside the handler, the special handler is turned off so `die` inside `$SIG{__DIE__}` is the real `die`. The value of `$^S` will be true if it came from within an `eval`, so this just re-throws the exception without handling it. - The [Perl documentation for the `$^S` variable](https://perldoc.perl.org/perlvar#%24%5ES), which says: > Current state of the interpreter. $^S State --------- ------------------------------------- undef Parsing module, eval, or main program true (1) Executing an eval false (0) Otherwise > The first state may happen in `$SIG{__DIE__}` and `$SIG{__WARN__}` handlers. - The [Perl documentation for the `die` function](https://perldoc.perl.org/functions/die), which says: > You can arrange for a callback to be run just before the `die` does its deed, by setting the `$SIG{__DIE__}` hook. The associated handler is called with the exception as an argument, and can change the exception, if it sees fit, by calling `die` again. See `"%SIG"` in perlvar for details on setting `%SIG` entries, and `eval` for some examples. Although this feature was to be run only right before your program was to exit, this is not currently so: the `$SIG{__DIE__}` hook is currently called even inside `eval`ed blocks/strings! If one wants the hook to do nothing in such situations, put ```perl die @_ if $^S; ``` > as the first line of the handler (see "`$^S`" in perlvar). Because this promotes strange action at a distance, this counterintuitive behavior may be fixed in a future release. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ```bash root@myserver:~# kamailio -V version: kamailio 5.4.3 (x86_64/linux) e19ae3 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: e19ae3 compiled on 17:51:35 Feb 14 2021 with gcc 9.3.0 ``` * **Operating System**: ```bash root@myserver:~# uname -a Linux myserver 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` ```bash root@myserver:~# cat /etc/os-release NAME="Ubuntu" VERSION="20.04.1 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.1 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal ``` * **Perl version**: ```bash root@myserver:~# perl -V Summary of my perl5 (revision 5 version 30 subversion 0) configuration: Platform: osname=linux osvers=4.19.0 archname=x86_64-linux-gnu-thread-multi uname='linux localhost 4.19.0 #1 smp debian 4.19.0 x86_64 gnulinux ' config_args='-Dmksymlinks -Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=-DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/perl-Wfb2Cd/perl-5.30.0=. -fstack-protector-strong -Wformat -Werror=format-security -Dldflags= -Wl,-Bsymbolic-functions -Wl,-z,relro -Dlddlflags=-shared -Wl,-Bsymbolic-functions -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.30 -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.30 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux-gnu/perl5/5.30 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.30.0 -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.30.0 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -Ui_xlocale -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib -Dlibperl=libperl.so.5.30.0' hint=recommended useposix=true d_sigaction=define useithreads=define usemultiplicity=define use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='x86_64-linux-gnu-gcc' ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' optimize='-O2 -g' cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='' gccversion='9.3.0' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='x86_64-linux-gnu-gcc' ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=libc-2.31.so so=so useshrplib=true libperl=libperl.so.5.30 gnulibc_version='2.31' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -L/usr/local/lib -fstack-protector-strong' Characteristics of this binary (from libperl): Compile-time options: HAS_TIMES MULTIPLICITY PERLIO_LAYERS PERL_COPY_ON_WRITE PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP PERL_OP_PARENT PERL_PRESERVE_IVUV USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO USE_PERL_ATOF USE_REENTRANT_API USE_THREAD_SAFE_LOCALE Locally applied patches: DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS default for modules installed from CPAN. DEBPKG:debian/db_file_ver - https://bugs.debian.org/340047 Remove overly restrictive DB_File version check. DEBPKG:debian/doc_info - Replace generic man(1) instructions with Debian-specific information. DEBPKG:debian/enc2xs_inc - https://bugs.debian.org/290336 Tweak enc2xs to follow symlinks and ignore missing @INC directories. DEBPKG:debian/errno_ver - https://bugs.debian.org/343351 Remove Errno version check due to upgrade problems with long-running processes. DEBPKG:debian/libperl_embed_doc - https://bugs.debian.org/186778 Note that libperl-dev package is required for embedded linking DEBPKG:fixes/respect_umask - Respect umask during installation DEBPKG:debian/writable_site_dirs - Set umask approproately for site install directories DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of libperl.a under /usr/lib DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or perllocal.pod for perl or vendor DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to the binary targets. DEBPKG:debian/instmodsh_doc - Debian policy doesn't install .packlist files for core or vendor. DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH as per Debian policy. DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to /etc/perl/Net as /usr may not be writable. DEBPKG:debian/perlivp - https://bugs.debian.org/510895 Make perlivp skip include directories in /usr/local DEBPKG:debian/squelch-locale-warnings - https://bugs.debian.org/508764 Squelch locale warnings in Debian package maintainer scripts DEBPKG:debian/patchlevel - https://bugs.debian.org/567489 List packaged patches for 5.30.0-9ubuntu0.2 in patchlevel.h DEBPKG:fixes/document_makemaker_ccflags - https://bugs.debian.org/628522 [rt.cpan.org #68613] Document that CCFLAGS should include $Config{ccflags} DEBPKG:debian/find_html2text - https://bugs.debian.org/640479 Configure CPAN::Distribution with correct name of html2text DEBPKG:debian/perl5db-x-terminal-emulator.patch - https://bugs.debian.org/668490 Invoke x-terminal-emulator rather than xterm in perl5db.pl DEBPKG:debian/cpan-missing-site-dirs - https://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with nonexisting site dirs if a parent is writable DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] https://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' option not respected DEBPKG:debian/makemaker-pasthru - https://bugs.debian.org/758471 Pass LD settings through to subdirectories DEBPKG:debian/makemaker-manext - https://bugs.debian.org/247370 Make EU::MakeMaker honour MANnEXT settings in generated manpage headers DEBPKG:debian/kfreebsd-softupdates - https://bugs.debian.org/796798 Work around Debian Bug#796798 DEBPKG:fixes/autodie-scope - https://bugs.debian.org/798096 Fix a scoping issue with "no autodie" and the "system" sub DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in Memoize DEBPKG:debian/hurd-softupdates - https://bugs.debian.org/822735 Fix t/op/stat.t failures on hurd DEBPKG:fixes/math_complex_doc_great_circle - https://bugs.debian.org/697567 [rt.cpan.org #114104] Math::Trig: clarify definition of great_circle_midpoint DEBPKG:fixes/math_complex_doc_see_also - https://bugs.debian.org/697568 [rt.cpan.org #114105] Math::Trig: add missing SEE ALSO DEBPKG:fixes/math_complex_doc_angle_units - https://bugs.debian.org/731505 [rt.cpan.org #114106] Math::Trig: document angle units DEBPKG:fixes/cpan_web_link - https://bugs.debian.org/367291 CPAN: Add link to main CPAN web site DEBPKG:debian/hppa_op_optimize_workaround - https://bugs.debian.org/838613 Temporarily lower the optimization of op.c on hppa due to gcc-6 problems DEBPKG:debian/installman-utf8 - https://bugs.debian.org/840211 Generate man pages with UTF-8 characters DEBPKG:fixes/getopt-long-4 - https://bugs.debian.org/864544 [rt.cpan.org #122068] Fix issue #122068. DEBPKG:debian/hppa_opmini_optimize_workaround - https://bugs.debian.org/869122 Lower the optimization level of opmini.c on hppa DEBPKG:debian/sh4_op_optimize_workaround - https://bugs.debian.org/869373 Also lower the optimization level of op.c and opmini.c on sh4 DEBPKG:debian/perldoc-pager - https://bugs.debian.org/870340 [rt.cpan.org #120229] Fix perldoc terminal escapes when sensible-pager is less DEBPKG:debian/prune_libs - https://bugs.debian.org/128355 Prune the list of libraries wanted to what we actually need. DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian DEBPKG:debian/configure-regen - https://bugs.debian.org/762638 Regenerate Configure et al. after probe unit changes DEBPKG:debian/deprecate-with-apt - https://bugs.debian.org/747628 Point users to Debian packages of deprecated core modules DEBPKG:debian/disable-stack-check - https://bugs.debian.org/902779 [perl #133327] Disable debugperl stack extension checks for binary compatibility with perl DEBPKG:fixes/eumm-usrmerge - https://bugs.debian.org/913637 Avoid mangling /bin non-perl shebangs on merged-/usr systems DEBPKG:debian/perlbug-editor - https://bugs.debian.org/922609 Use "editor" as the default perlbug editor, as per Debian policy DEBPKG:fixes/gid-parsing - [79e302e] https://bugs.debian.org/941985 [perl #134169] (perl #134169) mg.c reset endptr after use DEBPKG:fixes/CVE-2020-10543.patch - [PATCH v530 1/4] regcomp.c: Prevent integer overflow from nested regex quantifiers. DEBPKG:fixes/CVE-2020-10878-1.patch - [PATCH v530 2/4] study_chunk: extract rck_elide_nothing DEBPKG:fixes/CVE-2020-10878-2.patch - [PATCH v530 3/4] regcomp: use long jumps if there is any possibility of overflow DEBPKG:fixes/CVE-2020-12723.patch - [PATCH v530 4/4] study_chunk: avoid mutating regexp program within GOSUB Built under linux Compiled at Oct 19 2020 10:56:54 @INC: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base ``` Please evaluate the situation and let me know your feedback and what I could help with. Thanks in advance for your time and attention. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2745

3 3

git:master:8275046a: siptrace: aadded siptrace pseudo var
by Daniel-Constantin Mierla 09 Jun '21

09 Jun '21

Module: kamailio Branch: master Commit: 8275046a250a80018f42f8dbadaa245094c6f5ff URL: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-09T09:21:16+02:00 siptrace: aadded siptrace pseudo var --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… Patch: https://github.com/kamailio/kamailio/commit/8275046a250a80018f42f8dbadaa245… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 012644bfa0..b411886f54 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -195,6 +195,10 @@ static str trace_local_ip = {NULL, 0}; static db1_con_t *db_con = NULL; /*!< database connection */ static db_func_t db_funcs; /*!< Database functions */ +int pv_parse_siptrace_name(pv_spec_t *sp, str *in); +int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res); + /*! \brief * Exported functions */ @@ -276,6 +280,14 @@ stat_export_t siptrace_stats[] = { /* clang-format on */ #endif +static pv_export_t mod_pvs[] = { + + { {"siptrace", (sizeof("siptrace")-1)}, PVT_OTHER, pv_get_siptrace, 0, + pv_parse_siptrace_name, 0, 0, 0 }, + + { {0, 0}, 0, 0, 0, 0, 0, 0, 0 } +}; + /*! \brief module exports */ /* clang-format off */ struct module_exports exports = { @@ -283,9 +295,9 @@ struct module_exports exports = { DEFAULT_DLFLAGS, /*!< dlopen flags */ cmds, /*!< exported functions */ params, /*!< exported parameters */ - 0, /*!< exported rpc functions */ - 0, /*!< exported pseudo-variables */ - 0, /*!< response function */ + 0, /*!< exported rpc functions */ + mod_pvs, /*!< exported pseudo-variables */ + 0, /*!< response function */ mod_init, /*!< module initialization function */ child_init, /*!< child initialization function */ destroy /*!< destroy function */ @@ -2039,6 +2051,8 @@ static void trace_free_info(void* trace_info) shm_free(trace_info); } +static siptrace_data_t* siptrace_event_data = NULL; + static int siptrace_exec_evcb_msg(siptrace_data_t *sto) { int backup_rt; @@ -2068,6 +2082,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); + siptrace_event_data = sto; if(_siptrace_evrt_msg_idx>=0) { run_top_route(event_rt.rlist[_siptrace_evrt_msg_idx], &msg, &ctx); } else { @@ -2080,6 +2095,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) sr_kemi_act_ctx_set(bctx); } } + siptrace_event_data = NULL; free_sip_msg(&msg); set_route_type(backup_rt); @@ -2482,6 +2498,56 @@ static sr_kemi_t sr_kemi_siptrace_exports[] = { { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; + +/** + * + */ +int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res) +{ + if (siptrace_event_data==NULL) { + return pv_get_null(msg, param, res); + } + + switch(param->pvn.u.isname.name.n) { + case 1: /* dst_uri*/ + return pv_get_strval(msg, param, res, &siptrace_event_data->toip); + default: + /* 0 - src_uri */ + return pv_get_strval(msg, param, res, &siptrace_event_data->fromip); + } +} + +/** + * + */ +int pv_parse_siptrace_name(pv_spec_t *sp, str *in) +{ + if(sp==NULL || in==NULL || in->len<=0) + return -1; + + switch(in->len) + { + case 7: + if(strncmp(in->s, "src_uri", 7)==0) + sp->pvp.pvn.u.isname.name.n = 0; + else if(strncmp(in->s, "dst_uri", 7)==0) + sp->pvp.pvn.u.isname.name.n = 1; + else goto error; + break; + default: + goto error; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = 0; + + return 0; + +error: + LM_ERR("unknown PV snd name %.*s\n", in->len, in->s); + return -1; +} + /* clang-format on */ /**

1 0

git:master:10bc5b24: pv: new variable $hflc(hname)
by Daniel-Constantin Mierla 08 Jun '21

08 Jun '21

Module: kamailio Branch: master Commit: 10bc5b244db34e57beb9e5b4ec546396fb12a76b URL: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-08T13:25:54+02:00 pv: new variable $hflc(hname) - return the number of bodies for known headers that can also be as a comma separated list - supported now is Via header --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… Patch: https://github.com/kamailio/kamailio/commit/10bc5b244db34e57beb9e5b4ec54639… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 2738a8b7a2..3a904e3161 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -110,6 +110,8 @@ static pv_export_t mod_pvs[] = { 0, 0, 0}, {{"hfl", (sizeof("hfl")-1)}, PVT_HDR, pv_get_hfl, 0, pv_parse_hfl_name, pv_parse_index, 0, 0}, + {{"hflc", (sizeof("hflc")-1)}, PVT_HDRC, pv_get_hflc, 0, pv_parse_hfl_name, + 0, 0, 0}, {{"var", (sizeof("var")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, pv_set_scriptvar, pv_parse_scriptvar_name, 0, 0, 0}, {{"vz", (sizeof("vz")-1)}, PVT_SCRIPTVAR, pv_get_scriptvar, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 1b39ef3fb8..a4bfe21985 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2421,6 +2421,70 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); } +/** + * + */ +int pv_get_hflc(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + pv_value_t tv = {0}; + via_body_t *vb = NULL; + hdr_field_t *hf = NULL; + int n = 0; + + if(msg==NULL || res==NULL || param==NULL) + return -1; + + /* get the name */ + if(param->pvn.type == PV_NAME_PVAR) { + if(pv_get_spec_name(msg, param, &tv)!=0 || (!(tv.flags&PV_VAL_STR))) { + LM_ERR("invalid name\n"); + return pv_get_sintval(msg, param, res, 0); + } + } else { + if(param->pvn.u.isname.type == AVP_NAME_STR) { + tv.flags = PV_VAL_STR; + tv.rs = param->pvn.u.isname.name.s; + } else { + tv.flags = 0; + tv.ri = param->pvn.u.isname.name.n; + } + } + + if (parse_headers(msg, HDR_EOH_F, 0)<0) { + LM_DBG("failed to parse sip headers\n"); + return pv_get_sintval(msg, param, res, 0); + } + + if((tv.flags == 0) && (tv.ri==HDR_VIA_T)) { + if(msg->h_via1==NULL) { + LM_WARN("no Via header\n"); + return pv_get_sintval(msg, param, res, 0); + } + /* count Via header bodies */ + for(hf=msg->h_via1; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_VIA_T) { + for(vb=(via_body_t*)hf->parsed; vb!=NULL; vb=vb->next) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); + } + + for (hf=msg->headers; hf; hf=hf->next) { + if(tv.flags == 0) { + if (tv.ri==hf->type) { + n++; + } + } else { + if (cmp_hdrname_str(&hf->name, &tv.rs)==0) { + n++; + } + } + } + return pv_get_sintval(msg, param, res, n); +} + /** * */ diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 179df8fd0b..d001104647 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -255,6 +255,8 @@ int pv_get_hdrc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); +int pv_get_hflc(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); + int pv_get_scriptvar(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

[kamailio/kamailio] tm: prevent t_suspend memory leak (#2763)
by Julien Chavanton 07 Jun '21

07 Jun '21

When suspending while already in t_continue when processing a reply / suspending twice in a reply. Thanks to @giavac https://github.com/kamailio/kamailio/pull/2721 we can now suspend more then once in a reply route. This is working well, however a memory leak was detected. This modification is proposing a solution that will prevent calling `sip_msg_cloner` over an already twice over the same pointer, creating the memory leak.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) I assume this is a non "breaking change" since it can only trigger in a very the specific case that was not supported anyway. Conditions when this alternate behavior can trigger: 1- must be in t_suspend 2- must be in a reply `if (msg->first_line.type == SIP_REPLY) {` 3- must have an already cloned `if (t->uac[branch].reply) {` An alternate solution would be to free everything in the cloned message and recreate it. #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) load test done that included connections, failures and timeouts while suspending multiple times. ``` 6(31) INFO: tm [t_suspend.c:126]: t_suspend(): [>>>SUSPEND<<<] cloning message ! 53(78) INFO: tm [t_suspend.c:136]: t_suspend(): [>>>SUSPEND<<<] message already cloned, re-using ! ``` ``` Total 100000 INVITE calls sent in 1710825 ms at rate of 58/sec Total 100000 connection responses received in 1714999 ms at rate of 58/sec: >> Detailed connection responses received: - 200 connection responses: 24924 (OK) - 404 connection responses: 25145 (Not Found) - 408 connection responses: 24912 (Request Timeout) - 500 connection responses: 25019 (Internal Server Error) >> Detailed disconnection responses received: - 200 disconnection responses: 24924 (OK) ------ TOTAL responses: 24924 (rate=14/sec) ``` #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2763 -- Commit Summary -- * tm: prevent t_suspend memory leak -- File Changes -- M src/modules/tm/t_suspend.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2763.patch https://github.com/kamailio/kamailio/pull/2763.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2763

2 4

git:master:09218156: tm: prevent t_suspend memory leak (#2763)
by GitHub 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 09218156f3831ec9642d9ebf20d8668229ab16d6 URL: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-06-07T08:13:36-07:00 tm: prevent t_suspend memory leak (#2763) When suspending while already in t_continue when processing a reply / suspending twice in a reply. Co-authored-by: Julien Chavanton <jchavanton(a)subspace.com> --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… Patch: https://github.com/kamailio/kamailio/commit/09218156f3831ec9642d9ebf20d8668… --- diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index 04f906f53c..826307d20a 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -118,18 +118,23 @@ int t_suspend(struct sip_msg *msg, LM_ERR("failed find UAC branch\n"); return -1; } - LM_DBG("found a a match with branch id [%d] - " - "cloning reply message to t->uac[branch].reply\n", branch); - sip_msg_len = 0; - t->uac[branch].reply = sip_msg_cloner( msg, &sip_msg_len ); + if (!t->uac[branch].reply) { + sip_msg_len = 0; + LM_DBG("found a match with branch id [%d] - " + "cloning reply message to t->uac[branch].reply\n", branch); + t->uac[branch].reply = sip_msg_cloner( msg, &sip_msg_len ); - if (! t->uac[branch].reply ) { - LM_ERR("can't alloc' clone memory\n"); - return -1; + if (! t->uac[branch].reply ) { + LM_ERR("can't alloc' clone memory\n"); + return -1; + } + t->uac[branch].end_reply = ((char*)t->uac[branch].reply) + sip_msg_len; + } else { + LM_DBG("found a match with branch id [%d] - " + "message already cloned to t->uac[branch].reply\n", branch); + // This can happen when suspending more than once in a reply. } - t->uac[branch].end_reply = ((char*)t->uac[branch].reply) + sip_msg_len; - LM_DBG("saving transaction data\n"); t->uac[branch].reply->flags = msg->flags; t->flags |= T_ASYNC_SUSPENDED;

1 0

git:master:7747872f: mtree: docs - section id for mt_match() function
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 7747872f066ead3488cbfc854873506bda4f7390 URL: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:23:50+02:00 mtree: docs - section id for mt_match() function --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… Patch: https://github.com/kamailio/kamailio/commit/7747872f066ead3488cbfc854873506… --- diff --git a/src/modules/mtree/doc/mtree_admin.xml b/src/modules/mtree/doc/mtree_admin.xml index 09eb86092c..2416d8fb8d 100644 --- a/src/modules/mtree/doc/mtree_admin.xml +++ b/src/modules/mtree/doc/mtree_admin.xml @@ -454,7 +454,7 @@ modparam("mtree", "mt_allow_duplicates", 1) <section> <title>Functions</title> <section> - <title> + <title id="mtree.f.mt_match"> <function moreinfo="none">mt_match(mtree, pv, mode)</function> </title> <para>

1 0

[kamailio/kamailio] Sl (#2767)
by sergey-safarov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description HTTP request do not trigger `SREV_NET_DATA_RECV` (please check [`receive_msg`](https://github.com/kamailio/kamailio/blob/0e806316b84be8388dad670e964e54011000b4a4/src/core/receive.c#L321)) This PR adds the same behavior for HTTP responces. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2767 -- Commit Summary -- * core: published sip_check_fline function in .h file * sl: disabled SREV_NET_DATA_SENT for HTTP respones -- File Changes -- M src/core/receive.h (1) M src/modules/sl/sl_funcs.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2767.patch https://github.com/kamailio/kamailio/pull/2767.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2767

2 1

git:master:4168d7c5: sl: disabled SREV_NET_DATA_SENT for HTTP respones
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 4168d7c55955a01c3a30c67d5e8a510be52120ff URL: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 sl: disabled SREV_NET_DATA_SENT for HTTP respones more details at GH #2767 --- Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… Patch: https://github.com/kamailio/kamailio/commit/4168d7c55955a01c3a30c67d5e8a510… --- diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 86ad65c5e8..e80259d61d 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -210,7 +210,11 @@ int sl_reply_helper(struct sip_msg *msg, int code, char *reason, str *tag) dst.comp=msg->via1->comp_no; #endif dst.send_flags=msg->rpl_send_flags; - ret = msg_send(&dst, buf.s, buf.len); + if(sip_check_fline(buf.s, buf.len) == 0) + ret = msg_send_buffer(&dst, buf.s, buf.len, 0); + else + ret = msg_send_buffer(&dst, buf.s, buf.len, 1); + mhomed=backup_mhomed; keng = sr_kemi_eng_get();

1 0

git:master:c336eed3: core: published sip_check_fline function in .h file
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: c336eed393f2fedae16dbcf004e143fdd38c46e2 URL: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:17:32+02:00 core: published sip_check_fline function in .h file --- Modified: src/core/receive.h --- Diff: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… Patch: https://github.com/kamailio/kamailio/commit/c336eed393f2fedae16dbcf004e143f… --- diff --git a/src/core/receive.h b/src/core/receive.h index d4ce7895a8..433bf6a72e 100644 --- a/src/core/receive.h +++ b/src/core/receive.h @@ -32,6 +32,7 @@ #include "ip_addr.h" int receive_msg(char* buf, unsigned int len, struct receive_info *ri); +int sip_check_fline(char *buf, unsigned int len); unsigned int inc_msg_no(void); void ksr_msg_env_reset(void);

1 0

[kamailio/kamailio] Smsops 7bit support special chars (#2756)
by alexyosifov 07 Jun '21

07 Jun '21

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2756 -- Commit Summary -- * Add README.md * Merge branch 'master' of github.com:alexyosifov/kamailio * Merge remote-tracking branch 'remote_yosifov/master' * Merge branch 'master' of github.com:alexyosifov/kamailio * smsops: support for 7bit special chars -- File Changes -- M src/modules/smsops/smsops_impl.c (256) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2756.patch https://github.com/kamailio/kamailio/pull/2756.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2756

3 4

git:master:f82c4775: smsops: support for 7bit special chars
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: f82c4775efca0580401f4b1a48dcb4d2cf26814f URL: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:13:17+02:00 smsops: support for 7bit special chars - Added support for 7bit special chars for MO/MT SMSs. --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d… Patch: https://github.com/kamailio/kamailio/commit/f82c4775efca0580401f4b1a48dcb4d…

1 0

[kamailio/kamailio] app_perl change to ignore "die" signals from eval blocks (#2754)
by rodolfojcj 07 Jun '21

07 Jun '21

Proposed fix for issue #2745. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2754 -- Commit Summary -- * app_perl change to ignore "die" signals from eval blocks -- File Changes -- M src/modules/app_perl/lib/perl/Kamailio.pm (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2754.patch https://github.com/kamailio/kamailio/pull/2754.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2754

2 2

git:master:50557b84: app_perl change to ignore "die" signals from eval blocks
by Daniel-Constantin Mierla 07 Jun '21

07 Jun '21

Module: kamailio Branch: master Commit: 50557b8433e137a9095b4d48df8ac9b8c3fd8807 URL: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… Author: rodolfojcj <458749+rodolfojcj(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-07T15:11:27+02:00 app_perl change to ignore "die" signals from eval blocks --- Modified: src/modules/app_perl/lib/perl/Kamailio.pm --- Diff: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… Patch: https://github.com/kamailio/kamailio/commit/50557b8433e137a9095b4d48df8ac9b… --- diff --git a/src/modules/app_perl/lib/perl/Kamailio.pm b/src/modules/app_perl/lib/perl/Kamailio.pm index eda5ede8b7..aa587424e1 100644 --- a/src/modules/app_perl/lib/perl/Kamailio.pm +++ b/src/modules/app_perl/lib/perl/Kamailio.pm @@ -40,6 +40,7 @@ bootstrap Kamailio; BEGIN { $SIG{'__DIE__'} = sub { + die @_ if( $^S or not defined $^S ); Kamailio::Message::log(undef, L_ERR, "perl error: $_[0]\n"); }; $SIG{'__WARN__'} = sub {

1 0

git:master:0e806316: mtree: docs - added section ids for parameters
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: 0e806316b84be8388dad670e964e54011000b4a4 URL: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T17:59:58+02:00 mtree: docs - added section ids for parameters --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540… Patch: https://github.com/kamailio/kamailio/commit/0e806316b84be8388dad670e964e540…

1 0

[kamailio/kamailio] evapi: Evapi MAX clients set to 8 can it be made configurable parameter? (#2762)
by Balajee 04 Jun '21

04 Jun '21

### Description Evapi max client is set to 8 in [evapi module](https://github.com/kamailio/kamailio/blob/master/src/modules/evapi/… Can this be increased or can be made as configuration parameter?  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2762

2 2

[kamailio/kamailio] pv: fixed error "pv_get_method(): no CSEQ header" (#2761)
by sergey-safarov 04 Jun '21

04 Jun '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description pv: fixed error "pv_get_method(): no CSEQ header" when sent HTTP request like ``` HTTP/1.1 200 OK Sia: SIP/2.0/TCP 8.8.8.8:39813 Content-Type: application/json Server: kamailio Content-Length: 49 {"data":{"status-code":200,"reason-phrase":"OK"}} ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2761 -- Commit Summary -- * pv: fixed error "pv_get_method(): no CSEQ header" -- File Changes -- M src/modules/pv/pv_core.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2761.patch https://github.com/kamailio/kamailio/pull/2761.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2761

2 7

git:master:de8c85ce: pv: pv_get_method fixed error "pv_get_method(): no CSEQ header"
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: de8c85ceae93779cdf7d6aea2eabb7567d69d7ce URL: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T16:22:49+02:00 pv: pv_get_method fixed error "pv_get_method(): no CSEQ header" GH #2761: Error obeserver when sent HTTP reply like HTTP/1.1 200 OK Sia: SIP/2.0/TCP 8.8.8.8:39813 Content-Type: application/json Server: kamailio Content-Length: 49 {"data":{"status-code":200,"reason-phrase":"OK"}} --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… Patch: https://github.com/kamailio/kamailio/commit/de8c85ceae93779cdf7d6aea2eabb75… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 5b011ea248..1b39ef3fb8 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -147,6 +147,9 @@ int pv_get_method(struct sip_msg *msg, pv_param_t *param, (int)msg->first_line.u.request.method_value); } + if (IS_HTTP_REPLY(msg)) + return pv_get_null(msg, param, res); + if(msg->cseq==NULL && ((parse_headers(msg, HDR_CSEQ_F, 0)==-1) || (msg->cseq==NULL))) {

1 0

git:master:c264fbc6: pv: test for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: c264fbc66a4690b073c72ffa8fc095227ce0ae8b URL: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T15:29:50+02:00 pv: test for HDR_ERROR_T after header name parsing --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… Patch: https://github.com/kamailio/kamailio/commit/c264fbc66a4690b073c72ffa8fc0952… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 8f398cdf43..5b011ea248 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3501,8 +3501,8 @@ int pv_parse_hdr_name(pv_spec_p sp, str *in) s.s = p; s.len = in->len+1; - if (parse_hname2_short(s.s, s.s + s.len, &hdr)==0) - { + parse_hname2_short(s.s, s.s + s.len, &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", s.len, s.s); goto error; }

1 0

git:master:b775bbdf: dmq: warning about protocol made info
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: b775bbdff501de0ca1f1a0bc1ab39a3b790c166f URL: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-04T09:08:06+02:00 dmq: warning about protocol made info --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… Patch: https://github.com/kamailio/kamailio/commit/b775bbdff501de0ca1f1a0bc1ab39a3… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 1db7cdd1f4..817fc3f3bb 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -161,7 +161,7 @@ static int make_socket_str_from_uri(struct sip_uri *uri, str *socket) } if(get_valid_proto_string(uri->proto, 0, 0, &sproto)<0) { - LM_WARN("unknown transport protocol - fall back to udp\n"); + LM_INFO("unknown transport protocol - fall back to udp\n"); sproto.s = "udp"; sproto.len = 3; }

1 0

git:master:490ae559: dialog: safety checks for bind addr fields
by Daniel-Constantin Mierla 04 Jun '21

04 Jun '21

Module: kamailio Branch: master Commit: 490ae559d2b77b13b3f3831e7ff1aa58980e4086 URL: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T15:28:31+02:00 dialog: safety checks for bind addr fields - they can be null on non-local sockets - GH #2757 --- Modified: src/modules/dialog/dlg_db_handler.c --- Diff: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… Patch: https://github.com/kamailio/kamailio/commit/490ae559d2b77b13b3f3831e7ff1aa5… --- diff --git a/src/modules/dialog/dlg_db_handler.c b/src/modules/dialog/dlg_db_handler.c index 1bfcb2cad7..b6a49da2a4 100644 --- a/src/modules/dialog/dlg_db_handler.c +++ b/src/modules/dialog/dlg_db_handler.c @@ -802,6 +802,7 @@ int update_dialog_dbinfo_unsafe(struct dlg_cell * cell) int i; struct dlg_var *var; srjson_doc_t jdoc; + str sempty = str_init(""); db_val_t values[DIALOG_TABLE_COL_NO]; @@ -870,14 +871,25 @@ int update_dialog_dbinfo_unsafe(struct dlg_cell * cell) SET_STR_VALUE(values+6, cell->tag[DLG_CALLEE_LEG]); SET_PROPER_NULL_FLAG(cell->tag[DLG_CALLEE_LEG], values, 6); - LM_DBG("caller sock_info is %.*s, callee sock_info is %.*s\n", - cell->bind_addr[DLG_CALLER_LEG]->sock_str.len, - cell->bind_addr[DLG_CALLER_LEG]->sock_str.s, - cell->bind_addr[DLG_CALLEE_LEG]->sock_str.len, - cell->bind_addr[DLG_CALLEE_LEG]->sock_str.s); - SET_STR_VALUE(values+7, cell->bind_addr[DLG_CALLER_LEG]->sock_str); - SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); + if(cell->bind_addr[DLG_CALLER_LEG]) { + LM_DBG("caller sock_info is %.*s\n", + cell->bind_addr[DLG_CALLER_LEG]->sock_str.len, + cell->bind_addr[DLG_CALLER_LEG]->sock_str.s); + SET_STR_VALUE(values+7, cell->bind_addr[DLG_CALLER_LEG]->sock_str); + } else { + LM_DBG("no caller sock_info\n"); + SET_STR_VALUE(values+7, sempty); + } + if(cell->bind_addr[DLG_CALLEE_LEG]) { + LM_DBG("callee sock_info is %.*s\n", + cell->bind_addr[DLG_CALLEE_LEG]->sock_str.len, + cell->bind_addr[DLG_CALLEE_LEG]->sock_str.s); + SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); + } else { + LM_DBG("no callee sock_info\n"); + SET_STR_VALUE(values+8, sempty); + } SET_STR_VALUE(values+12, cell->cseq[DLG_CALLER_LEG]); SET_STR_VALUE(values+13, cell->cseq[DLG_CALLEE_LEG]);

1 0

git:master:e8fa2b3e: pv: support Contact header in $hfl(...)
by Daniel-Constantin Mierla 03 Jun '21

03 Jun '21

Module: kamailio Branch: master Commit: e8fa2b3e8e5a789ac6d6d35f75ec61d09f487d6c URL: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T11:11:50+02:00 pv: support Contact header in $hfl(...) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… Patch: https://github.com/kamailio/kamailio/commit/e8fa2b3e8e5a789ac6d6d35f75ec61d… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 073d0dccb8..8f398cdf43 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2191,6 +2191,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) pv_value_t tv = {0}; via_body_t *vb = NULL; rr_t *rrb = NULL; + contact_t *cb = NULL; hdr_field_t *hf = NULL; int n = 0; str sval = STR_NULL; @@ -2358,6 +2359,62 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_null(msg, param, res); } + if((tv.flags == 0) && (tv.ri==HDR_CONTACT_T)) { + if(msg->contact==NULL) { + LM_DBG("no Contact header\n"); + return pv_get_null(msg, param, res); + } + if(parse_contact_headers(msg) < 0) { + LM_DBG("failed to parse Contact headers\n"); + return pv_get_null(msg, param, res); + } + if(idx<0) { + n = 1; + /* count Contact header bodies */ + for(hf=msg->contact; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_CONTACT_T) { + for(cb=(((contact_body_t*)hf->parsed)->contacts); + cb!=NULL; cb=cb->next) { + n++; + } + } + } + + idx = -idx; + if(idx>n) { + LM_DBG("index out of range\n"); + return pv_get_null(msg, param, res); + } + idx = n - idx; + } + if(idx==0) { + cb = ((contact_body_t*)msg->contact->parsed)->contacts; + sval.s = cb->name.s; + sval.len = cb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n=0; + for(hf=msg->contact; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_CONTACT_T) { + for(cb=(((contact_body_t*)hf->parsed)->contacts); + cb!=NULL; cb=cb->next) { + if(n==idx) { + sval.s = cb->name.s; + sval.len = cb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n++; + } + } + } + LM_DBG("unexpected contact index out of range\n"); + return pv_get_null(msg, param, res); + } + return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); }

1 0

git:master:25834469: core: select - test for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 03 Jun '21

03 Jun '21

Module: kamailio Branch: master Commit: 2583446968d81a9351caab1cfdd2cc86434850f3 URL: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-03T10:55:22+02:00 core: select - test for HDR_ERROR_T after header name parsing --- Modified: src/core/select_core.c --- Diff: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… Patch: https://github.com/kamailio/kamailio/commit/2583446968d81a9351caab1cfdd2cc8… --- diff --git a/src/core/select_core.c b/src/core/select_core.c index 029f880a48..02d393a6ba 100644 --- a/src/core/select_core.c +++ b/src/core/select_core.c @@ -595,7 +595,7 @@ int select_msg_header(str* res, select_t* s, struct sip_msg* msg) { /* get all headers */ char *c; - res->s = SIP_MSG_START(msg) + msg->first_line.len; + res->s = SIP_MSG_START(msg) + msg->first_line.len; c = get_body(msg); res->len = c - res->s; return 0; @@ -607,7 +607,7 @@ int select_anyheader(str* res, select_t* s, struct sip_msg* msg) int hi; char c; struct hdr_field hdr; - + if(msg==NULL) { if (res!=NULL) return -1; @@ -622,13 +622,15 @@ int select_anyheader(str* res, select_t* s, struct sip_msg* msg) /* if header name is parseable, parse it and set SEL_PARAM_DIV */ c=s->params[2].v.s.s[s->params[2].v.s.len]; s->params[2].v.s.s[s->params[2].v.s.len]=':'; - if (parse_hname2_short(s->params[2].v.s.s,s->params[2].v.s.s+(s->params[2].v.s.len<3?4:s->params[2].v.s.len+1), - &hdr)==0) { + parse_hname2_short(s->params[2].v.s.s,s->params[2].v.s.s + +(s->params[2].v.s.len<3?4:s->params[2].v.s.len+1), + &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("fixup_call:parse error\n"); return -1; } s->params[2].v.s.s[s->params[2].v.s.len]=c; - + if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) { /* pkg_free(s->params[1].v.s.s); */ /* don't free it (the mem can leak only once at startup)

1 0

[kamailio/kamailio] Update resolve.c handle type 41 (#2759)
by Andrew Webster 03 Jun '21

03 Jun '21

Possible solution to https://github.com/kamailio/kamailio/issues/2758   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2759 -- Commit Summary -- * Update resolve.c handle type 41 -- File Changes -- M src/core/resolve.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2759.patch https://github.com/kamailio/kamailio/pull/2759.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2759

2 2

git:master:cb2705f2: textops: check for HDR_ERROR_T after header name parsing
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: cb2705f21e56f884e733febc2362055da3ef2693 URL: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T21:21:59+02:00 textops: check for HDR_ERROR_T after header name parsing --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… Patch: https://github.com/kamailio/kamailio/commit/cb2705f21e56f884e733febc2362055… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 40ea02c273..e93bc82bf2 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -1816,7 +1816,8 @@ static int ki_remove_hf_idx(sip_msg_t* msg, str* hname, int idx) return -1; } - if(parse_hname2_str(hname, &hfm)==NULL) { + parse_hname2_str(hname, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("failed to parse header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2098,12 +2099,13 @@ static int ki_hname_gparam(str *hname, gparam_t *gp) gp->v.str = *hname; - if (parse_hname2_short(hbuf, hbuf + gp->v.str.len + 1, &hdr)==0) { + parse_hname2_short(hbuf, hbuf + gp->v.str.len + 1, &hdr); + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name: %.*s\n", hname->len, hname->s); return -1; } - if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) { + if (hdr.type!=HDR_OTHER_T) { LM_DBG("using hdr type (%d) instead of <%.*s>\n", hdr.type, gp->v.str.len, gp->v.str.s); gp->v.str.s = NULL; @@ -3713,17 +3715,19 @@ static int hname_fixup(void** param, int param_no) gp->v.str.s[gp->v.str.len] = ':'; gp->v.str.len++; - if (parse_hname2_short(gp->v.str.s, gp->v.str.s + gp->v.str.len, &hdr)==0) + parse_hname2_short(gp->v.str.s, gp->v.str.s + gp->v.str.len, &hdr); + + gp->v.str.len--; + gp->v.str.s[gp->v.str.len] = c; + + if(hdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name\n"); pkg_free(gp); return E_UNSPEC; } - gp->v.str.len--; - gp->v.str.s[gp->v.str.len] = c; - - if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) + if (hdr.type!=HDR_OTHER_T) { LM_DBG("using hdr type (%d) instead of <%.*s>\n", hdr.type, gp->v.str.len, gp->v.str.s);

1 0

git:master:4cd55a86: textops: find_hdr_line_start() - search for header name with colon
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: 4cd55a86cdc3477da0ca4c384227833ec404bfa2 URL: https://github.com/kamailio/kamailio/commit/4cd55a86cdc3477da0ca4c384227833… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T21:22:48+02:00 textops: find_hdr_line_start() - search for header name with colon --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/4cd55a86cdc3477da0ca4c384227833… Patch: https://github.com/kamailio/kamailio/commit/4cd55a86cdc3477da0ca4c384227833… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index e93bc82bf2..75a00f16a8 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -1619,7 +1619,7 @@ static inline int find_hdr_line_start(char *hname, unsigned int hname_len, while (hname_len <= len) { /* attempt to find a header name */ - parse_sip_header_name(start, start + hname_len, &h2, 1, 0); + parse_sip_header_name(start, start + hname_len, &h2, 0, 0); if(h2.type!=HDR_ERROR_T) { if(h1.type>0 && h1.type==h2.type) { *buf = start;

1 0

git:master:785bbaa0: core: kemi - check hdr type HDR_ERROR_T after parsing
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: 785bbaa0f16f83353ad1d776816f439608a67858 URL: https://github.com/kamailio/kamailio/commit/785bbaa0f16f83353ad1d776816f439… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T18:57:53+02:00 core: kemi - check hdr type HDR_ERROR_T after parsing --- Modified: src/core/kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/785bbaa0f16f83353ad1d776816f439… Patch: https://github.com/kamailio/kamailio/commit/785bbaa0f16f83353ad1d776816f439… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index 324e7cd6cf..bee8a98f07 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -1988,7 +1988,8 @@ static int sr_kemi_hdr_append_after(sip_msg_t *msg, str *txt, str *hname) hbuf[hname->len] = ':'; hbuf[hname->len+1] = '\0'; - if (parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm)==0) { + parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2056,7 +2057,8 @@ int sr_kemi_hdr_remove(sip_msg_t *msg, str *hname) hbuf[hname->len] = ':'; hbuf[hname->len+1] = '\0'; - if (parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm)==0) { + parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2106,7 +2108,8 @@ static int sr_kemi_hdr_is_present(sip_msg_t *msg, str *hname) hbuf[hname->len] = ':'; hbuf[hname->len+1] = '\0'; - if (parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm)==0) { + parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2188,7 +2191,8 @@ static int sr_kemi_hdr_insert_before(sip_msg_t *msg, str *txt, str *hname) hbuf[hname->len] = ':'; hbuf[hname->len+1] = '\0'; - if (parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm)==0) { + parse_hname2_short(hbuf, hbuf+hname->len+1, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); return -1; } @@ -2305,7 +2309,8 @@ static sr_kemi_xval_t* sr_kemi_hdr_get_mode(sip_msg_t *msg, str *hname, int idx, sr_kemi_xval_null(&_sr_kemi_xval, rmode); return &_sr_kemi_xval; } - if (parse_hname2_str(hname, &shdr)==0) { + parse_hname2_str(hname, &shdr); + if(shdr.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); sr_kemi_xval_null(&_sr_kemi_xval, rmode); return &_sr_kemi_xval; @@ -2426,7 +2431,8 @@ static int sr_kemi_hdr_match_content(sip_msg_t *msg, str *hname, str *op, return SR_KEMI_FALSE; } - if (parse_hname2_str(hname, &hfm)==0) { + parse_hname2_str(hname, &hfm); + if(hfm.type==HDR_ERROR_T) { LM_ERR("error parsing header name [%.*s]\n", hname->len, hname->s); return SR_KEMI_FALSE; }

1 0

git:master:95034f62: xprint: check hdr type HDR_ERROR_T after parsing
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: 95034f62d4a0cf536da1c5c26c748c1cf8ccb280 URL: https://github.com/kamailio/kamailio/commit/95034f62d4a0cf536da1c5c26c748c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T18:48:50+02:00 xprint: check hdr type HDR_ERROR_T after parsing --- Modified: src/modules/xprint/xp_lib.c --- Diff: https://github.com/kamailio/kamailio/commit/95034f62d4a0cf536da1c5c26c748c1… Patch: https://github.com/kamailio/kamailio/commit/95034f62d4a0cf536da1c5c26c748c1… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index b2bcc077b7..4adb5c31c6 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -1481,16 +1481,17 @@ static int _xl_parse_format(char *s, xl_elog_p *el, int shm, xl_parse_cb parse_c /* ugly hack for compact header names -- !!fake length!! * -- parse_hname2 expects name buffer length >= 4 */ - if (parse_hname2(e->hparam.s, + parse_hname2(e->hparam.s, e->hparam.s + ((e->hparam.len<4)?4:e->hparam.len), - &hdr)==0) + &hdr); + if(hdr.type==HDR_ERROR_T) { - LOG(L_ERR,"xprint: xl_parse_format: strange error\n"); + LOG(L_ERR,"xprint: xl_parse_format: header parsing error\n"); goto error; } e->hparam.len--; e->hparam.s[e->hparam.len] = c; - if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) + if (hdr.type!=HDR_OTHER_T) { LOG(L_INFO,"INFO:xprint: xl_parse_format: using " "hdr type (%d) instead of <%.*s>\n",

1 0

git:master:d3b693fa: xprint: remove history and svn id
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: d3b693fa5725b45f24d68956658800de7b9ec19c URL: https://github.com/kamailio/kamailio/commit/d3b693fa5725b45f24d68956658800d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T18:45:22+02:00 xprint: remove history and svn id --- Modified: src/modules/xprint/xp_lib.c Modified: src/modules/xprint/xp_lib.h --- Diff: https://github.com/kamailio/kamailio/commit/d3b693fa5725b45f24d68956658800d… Patch: https://github.com/kamailio/kamailio/commit/d3b693fa5725b45f24d68956658800d… --- diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c index 5771b77399..b2bcc077b7 100644 --- a/src/modules/xprint/xp_lib.c +++ b/src/modules/xprint/xp_lib.c @@ -1,7 +1,5 @@ /** - * $Id$ - * - * XLOG module + * XPRINT module * * Copyright (C) 2001-2003 FhG Fokus * @@ -27,15 +25,6 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -/* History: - * -------- - * 2004-10-20 - added header name specifier (ramona) - * 2005-07-04 - added color printing support via escape sequesnces - * contributed by Ingo Wolfsberger (ramona) - * 2005-12-23 - parts from private branch merged (mma) - * - */ - #include <stdio.h> #include <stdlib.h> #include <string.h> diff --git a/src/modules/xprint/xp_lib.h b/src/modules/xprint/xp_lib.h index 9c8812029a..fb429dec9b 100644 --- a/src/modules/xprint/xp_lib.h +++ b/src/modules/xprint/xp_lib.h @@ -1,6 +1,4 @@ /* - * $Id$ - * * Copyright (C) 2001-2003 FhG Fokus * * This file is part of ser, a free SIP server. @@ -20,8 +18,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */

1 0

git:master:260a825a: core: parser/parse_hname2 - option to skip printing logs on parse failure
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: 260a825a48ac6f8b845a4b934f86ea3e04c120d4 URL: https://github.com/kamailio/kamailio/commit/260a825a48ac6f8b845a4b934f86ea3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T18:00:35+02:00 core: parser/parse_hname2 - option to skip printing logs on parse failure --- Modified: src/core/parser/parse_hname2.c Modified: src/core/parser/parse_hname2.h --- Diff: https://github.com/kamailio/kamailio/commit/260a825a48ac6f8b845a4b934f86ea3… Patch: https://github.com/kamailio/kamailio/commit/260a825a48ac6f8b845a4b934f86ea3… --- diff --git a/src/core/parser/parse_hname2.c b/src/core/parser/parse_hname2.c index ab56fa4ea5..20398a9595 100644 --- a/src/core/parser/parse_hname2.c +++ b/src/core/parser/parse_hname2.c @@ -219,21 +219,25 @@ int ksr_hname_init_config(void) * - fills hdr structure (must not be null) * - set hdr->type=HDR_ERROR_T in case of parsing error * - if emode==1, then parsing does not expect : after header name + * - if logmode==1, then print error log messages on parsing failure * - returns pointer after : if emode==0 or after header name if emode==1 + * in case of parsing error, returns begin and sets hdr->type to HDR_ERROR_T */ char *parse_sip_header_name(char* const begin, const char* const end, - hdr_field_t* const hdr, int emode) + hdr_field_t* const hdr, int emode, int logmode) { char *p; int i; - if (end <= begin) { + if (begin == NULL || end == NULL || end <= begin) { hdr->type = HDR_ERROR_T; return begin; } if(_ksr_hname_chars_idx[(unsigned char)(*begin)] == 0) { - LM_ERR("invalid start of header name for [%.*s]\n", - (int)(end-begin), begin); + if(likely(logmode)) { + LM_ERR("invalid start of header name for [%.*s]\n", + (int)(end-begin), begin); + } hdr->type = HDR_ERROR_T; return begin; } @@ -262,8 +266,10 @@ char *parse_sip_header_name(char* const begin, const char* const end, } if(*p != ' ' && *p != '\t') { /* no white space - bad header name format */ - LM_ERR("invalid header name for [%.*s]\n", - (int)(end-begin), begin); + if(likely(logmode)) { + LM_ERR("invalid header name for [%.*s]\n", + (int)(end-begin), begin); + } hdr->type = HDR_ERROR_T; return begin; } @@ -271,8 +277,10 @@ char *parse_sip_header_name(char* const begin, const char* const end, if(p == end) { /* no : found - emode==0 */ - LM_ERR("invalid end of header name for [%.*s]\n", - (int)(end-begin), begin); + if(likely(logmode)) { + LM_ERR("invalid end of header name for [%.*s]\n", + (int)(end-begin), begin); + } hdr->type = HDR_ERROR_T; return begin; } @@ -298,7 +306,7 @@ char *parse_sip_header_name(char* const begin, const char* const end, char* parse_hname2(char* const begin, const char* const end, struct hdr_field* const hdr) { - return parse_sip_header_name(begin, end, hdr, 0); + return parse_sip_header_name(begin, end, hdr, 0, 1); } /** @@ -307,11 +315,11 @@ char* parse_hname2(char* const begin, const char* const end, struct hdr_field* c */ char* parse_hname2_short(char* const begin, const char* const end, struct hdr_field* const hdr) { - return parse_sip_header_name(begin, end, hdr, 0); + return parse_sip_header_name(begin, end, hdr, 0, 1); } char* parse_hname2_str (str* const hbuf, hdr_field_t* const hdr) { - return parse_sip_header_name(hbuf->s, hbuf->s + hbuf->len, hdr, 1); + return parse_sip_header_name(hbuf->s, hbuf->s + hbuf->len, hdr, 1, 1); } diff --git a/src/core/parser/parse_hname2.h b/src/core/parser/parse_hname2.h index 2c864857d6..fc52c1c802 100644 --- a/src/core/parser/parse_hname2.h +++ b/src/core/parser/parse_hname2.h @@ -35,6 +35,15 @@ /** Fast 32-bit header field name parser. * @file */ + +char *parse_sip_header_name(char* const begin, const char* const end, + hdr_field_t* const hdr, int emode, int logmode); + +/* macro to find header name without printing errors in failure case */ +#define find_hname2_str(hbuf, hdr) \ + parse_sip_header_name((hbuf)->s, (hbuf)->s + (hbuf)->len, hdr, 1, 0) + + char* parse_hname2(char* const begin, const char* const end, struct hdr_field* const hdr); char* parse_hname2_short(char* const begin, const char* const end, struct hdr_field* const hdr); char* parse_hname2_str (str* const hbuf, hdr_field_t* const hdr);

1 0

git:master:a4d94268: textops: find_hdr_line_start() - locate header name without error logs
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: a4d94268c7cf5d31e3660b543b10ef6e7ca891ab URL: https://github.com/kamailio/kamailio/commit/a4d94268c7cf5d31e3660b543b10ef6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T18:02:24+02:00 textops: find_hdr_line_start() - locate header name without error logs --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/a4d94268c7cf5d31e3660b543b10ef6… Patch: https://github.com/kamailio/kamailio/commit/a4d94268c7cf5d31e3660b543b10ef6… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index cbc2309cfe..40ea02c273 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -1611,13 +1611,16 @@ static inline int find_hdr_line_start(char *hname, unsigned int hname_len, start = *buf; len = *buf_len; - if(parse_hname2_str(&sname, &h1)==NULL) { + parse_hname2_str(&sname, &h1); + if(h1.type!=HDR_ERROR_T) { LM_ERR("not a header name: %.*s\n", hname_len, hname); return 0; } while (hname_len <= len) { - if(parse_hname2(start, start + hname_len, &h2)!=NULL) { + /* attempt to find a header name */ + parse_sip_header_name(start, start + hname_len, &h2, 1, 0); + if(h2.type!=HDR_ERROR_T) { if(h1.type>0 && h1.type==h2.type) { *buf = start; *buf_len = len; @@ -1628,6 +1631,7 @@ static inline int find_hdr_line_start(char *hname, unsigned int hname_len, return 1; } } + /* jump to next line */ if ((ch = memchr(start, 13, len - 1))) { if (*(ch + 1) != 10) { LM_ERR("No LF after CR\n");

1 0

[kamailio/kamailio] core kamailio 5.4 (#2740)
by descartin 02 Jun '21

02 Jun '21

Dear all we have seen a core in a running production kamailio instance today, i attach you the bt in dropbox version: kamailio 5.4.4 (x86_64/linux) 0ddb01-dirty centos7 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 20:13:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux https://www.dropbox.com/s/3dg72cbuz7nvx5b/core_kamailio_21mayo?dl=0 https://www.dropbox.com/s/iyko32fwfxj8aam/core_kamailio_21mayo_2?dl=0 seems there might be a relation async module when delaying a request after communicating with the rtpengine ?¿ could you please take a look? thanks a lot and regards david -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2740

3 10

git:master:f3332c7d: pv: suport also Route headers in $hfl(...)
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: f3332c7dddda83d18ea1b1dc86fea5ad3886e010 URL: https://github.com/kamailio/kamailio/commit/f3332c7dddda83d18ea1b1dc86fea5a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T16:57:05+02:00 pv: suport also Route headers in $hfl(...) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/f3332c7dddda83d18ea1b1dc86fea5a… Patch: https://github.com/kamailio/kamailio/commit/f3332c7dddda83d18ea1b1dc86fea5a… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 65afab14e9..073d0dccb8 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2227,6 +2227,10 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } if((tv.flags == 0) && (tv.ri==HDR_VIA_T)) { + if(msg->h_via1==NULL) { + LM_WARN("no Via header\n"); + return pv_get_null(msg, param, res); + } if(idx<0) { n = 1; /* count Via header bodies */ @@ -2271,17 +2275,28 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) LM_DBG("unexpected via index out of range\n"); return pv_get_null(msg, param, res); } - if((tv.flags == 0) && (tv.ri==HDR_RECORDROUTE_T)) { + if((tv.flags == 0) && (tv.ri==HDR_RECORDROUTE_T || tv.ri==HDR_ROUTE_T)) { + if(tv.ri==HDR_RECORDROUTE_T) { + hf=msg->record_route; + } else { + hf=msg->route; + } + if(hf==NULL) { + LM_DBG("no %s header\n", (tv.ri==HDR_ROUTE_T)?"route":"record-route"); + return pv_get_null(msg, param, res); + } + if(idx<0) { n = 1; - /* count Record-Route header bodies */ - for(hf=msg->record_route; hf!=NULL; hf=hf->next) { - if(hf->type==HDR_RECORDROUTE_T) { + /* count Record-Route/Route header bodies */ + for(; hf!=NULL; hf=hf->next) { + if(hf->type==tv.ri) { if(parse_rr(hf) == -1) { - LM_ERR("failed parsing rr header\n"); + LM_ERR("failed parsing %s header\n", + (tv.ri==HDR_ROUTE_T)?"route":"record-route"); return pv_get_null(msg, param, res); } - for(rrb=(rr_t*)hf->parsed; vb!=NULL; rrb=rrb->next) { + for(rrb=(rr_t*)hf->parsed; rrb!=NULL; rrb=rrb->next) { n++; } } @@ -2289,17 +2304,24 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) idx = -idx; if(idx>n) { - LM_DBG("index out of rr headers range\n"); + LM_DBG("index out of %s headers range\n", + (tv.ri==HDR_ROUTE_T)?"route":"record-route"); return pv_get_null(msg, param, res); } idx = n - idx; } if(idx==0) { - if(parse_rr(msg->record_route) == -1) { - LM_ERR("failed parsing rr header\n"); + if(tv.ri==HDR_RECORDROUTE_T) { + hf=msg->record_route; + } else { + hf=msg->route; + } + if(parse_rr(hf) == -1) { + LM_ERR("failed parsing %s header\n", + (tv.ri==HDR_ROUTE_T)?"route":"record-route"); return pv_get_null(msg, param, res); } - rrb = (rr_t*)(msg->record_route->parsed); + rrb = (rr_t*)(hf->parsed); sval.s = rrb->nameaddr.name.s; sval.len = rrb->len; trim(&sval); @@ -2307,13 +2329,19 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return 0; } n=0; - for(hf=msg->record_route; hf!=NULL; hf=hf->next) { - if(hf->type==HDR_RECORDROUTE_T) { + if(tv.ri==HDR_RECORDROUTE_T) { + hf=msg->record_route; + } else { + hf=msg->route; + } + for(; hf!=NULL; hf=hf->next) { + if(hf->type==tv.ri) { if(parse_rr(hf) == -1) { - LM_ERR("failed parsing rr header\n"); + LM_ERR("failed parsing %s header\n", + (tv.ri==HDR_ROUTE_T)?"route":"record-route"); return pv_get_null(msg, param, res); } - for(rrb=(rr_t*)hf->parsed; vb!=NULL; rrb=rrb->next) { + for(rrb=(rr_t*)hf->parsed; rrb!=NULL; rrb=rrb->next) { if(n==idx) { sval.s = rrb->nameaddr.name.s; sval.len = rrb->len; @@ -2325,7 +2353,8 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) } } } - LM_DBG("unexpected record-route index out of range\n"); + LM_DBG("unexpected %s index out of range\n", + (tv.ri==HDR_ROUTE_T)?"route":"record-route"); return pv_get_null(msg, param, res); }

1 0

Kamailio v5.4.6 Released
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Hello, Kamailio SIP Server v5.4.6 stable release is out. This is a maintenance release of the latest stable branch, 5.4, that includes fixes since the release of v5.4.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.4.x. Deployments running previous v5.4.x versions are strongly recommended to be upgraded to v5.4.6. Note that 5.4 is the second last stable branch, still officially maintained by Kamailio development team. The latest stable branch is 5.5, with v5.5.0 being release out of it. For more details about version 5.4.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2021/06/kamailio-v5-4-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online - June 7-10, 2021 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

1 0

Kamailio v5.4.5 Released
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Hello, Kamailio SIP Server v5.4.6 stable release is out. This is a maintenance release of the latest stable branch, 5.4, that includes fixes since the release of v5.4.5. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.4.x. Deployments running previous v5.4.x versions are strongly recommended to be upgraded to v5.4.6. Note that 5.4 is the second last stable branch, still officially maintained by Kamailio development team. The latest stable branch is 5.5, with v5.5.0 being release out of it. For more details about version 5.4.6 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2021/06/kamailio-v5-4-6-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online - June 7-10, 2021 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

1 0

git:master:7d1e1a34: pv: support for Record-Route in $hfl(...)
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: master Commit: 7d1e1a349d5590f3754976b2e169fd30795c7f1b URL: https://github.com/kamailio/kamailio/commit/7d1e1a349d5590f3754976b2e169fd3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T12:23:40+02:00 pv: support for Record-Route in $hfl(...) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/7d1e1a349d5590f3754976b2e169fd3… Patch: https://github.com/kamailio/kamailio/commit/7d1e1a349d5590f3754976b2e169fd3… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 4dc6d56882..65afab14e9 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2190,6 +2190,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) int idxf = 0; pv_value_t tv = {0}; via_body_t *vb = NULL; + rr_t *rrb = NULL; hdr_field_t *hf = NULL; int n = 0; str sval = STR_NULL; @@ -2228,7 +2229,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) if((tv.flags == 0) && (tv.ri==HDR_VIA_T)) { if(idx<0) { n = 1; - /* count Vua header bodies */ + /* count Via header bodies */ for(hf=msg->h_via1; hf!=NULL; hf=hf->next) { if(hf->type==HDR_VIA_T) { for(vb=(via_body_t*)hf->parsed; vb!=NULL; vb=vb->next) { @@ -2270,6 +2271,64 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) LM_DBG("unexpected via index out of range\n"); return pv_get_null(msg, param, res); } + if((tv.flags == 0) && (tv.ri==HDR_RECORDROUTE_T)) { + if(idx<0) { + n = 1; + /* count Record-Route header bodies */ + for(hf=msg->record_route; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_RECORDROUTE_T) { + if(parse_rr(hf) == -1) { + LM_ERR("failed parsing rr header\n"); + return pv_get_null(msg, param, res); + } + for(rrb=(rr_t*)hf->parsed; vb!=NULL; rrb=rrb->next) { + n++; + } + } + } + + idx = -idx; + if(idx>n) { + LM_DBG("index out of rr headers range\n"); + return pv_get_null(msg, param, res); + } + idx = n - idx; + } + if(idx==0) { + if(parse_rr(msg->record_route) == -1) { + LM_ERR("failed parsing rr header\n"); + return pv_get_null(msg, param, res); + } + rrb = (rr_t*)(msg->record_route->parsed); + sval.s = rrb->nameaddr.name.s; + sval.len = rrb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n=0; + for(hf=msg->record_route; hf!=NULL; hf=hf->next) { + if(hf->type==HDR_RECORDROUTE_T) { + if(parse_rr(hf) == -1) { + LM_ERR("failed parsing rr header\n"); + return pv_get_null(msg, param, res); + } + for(rrb=(rr_t*)hf->parsed; vb!=NULL; rrb=rrb->next) { + if(n==idx) { + sval.s = rrb->nameaddr.name.s; + sval.len = rrb->len; + trim(&sval); + res->rs = sval; + return 0; + } + n++; + } + } + } + LM_DBG("unexpected record-route index out of range\n"); + return pv_get_null(msg, param, res); + } + return pv_get_hdr_helper(msg, param, res, &tv, idx, idxf); }

1 0

git:5.4:be668987: ChangeLog: content updated for v5.4.6
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: 5.4 Commit: be668987e9296232a00fa7bba82bc72abd72a743 URL: https://github.com/kamailio/kamailio/commit/be668987e9296232a00fa7bba82bc72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T11:27:34+02:00 ChangeLog: content updated for v5.4.6 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/be668987e9296232a00fa7bba82bc72… Patch: https://github.com/kamailio/kamailio/commit/be668987e9296232a00fa7bba82bc72…

1 0

git:5.4:0546511e: pkg/kamailio/deb: version set 5.4.6
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: 5.4 Commit: 0546511ed7eb47004c2df2f0806dff413468a1c4 URL: https://github.com/kamailio/kamailio/commit/0546511ed7eb47004c2df2f0806dff4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T11:23:35+02:00 pkg/kamailio/deb: version set 5.4.6 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/0546511ed7eb47004c2df2f0806dff4… Patch: https://github.com/kamailio/kamailio/commit/0546511ed7eb47004c2df2f0806dff4…

1 0

git:5.4:a2b34363: Makefile.defs: version set to 5.4.6
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: 5.4 Commit: a2b34363aa5e97f171d933b08dc57f8e7a1b3d58 URL: https://github.com/kamailio/kamailio/commit/a2b34363aa5e97f171d933b08dc57f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T10:44:48+02:00 Makefile.defs: version set to 5.4.6 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/a2b34363aa5e97f171d933b08dc57f8… Patch: https://github.com/kamailio/kamailio/commit/a2b34363aa5e97f171d933b08dc57f8… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 621f646b23..40bbef82bc 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 4 -SUBLEVEL = 5 +SUBLEVEL = 6 EXTRAVERSION = # memory manager switcher

1 0

git:5.4:aaa556f2: pkg: version set to 5.4.6 for rpms and apline
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Module: kamailio Branch: 5.4 Commit: aaa556f2d5a80e7a0bfa609d2478a9b75a530d0b URL: https://github.com/kamailio/kamailio/commit/aaa556f2d5a80e7a0bfa609d2478a9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-02T10:12:15+02:00 pkg: version set to 5.4.6 for rpms and apline --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/aaa556f2d5a80e7a0bfa609d2478a9b… Patch: https://github.com/kamailio/kamailio/commit/aaa556f2d5a80e7a0bfa609d2478a9b… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index e6576c616a..f4ff87ce2d 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.4.5 +pkgver=5.4.6 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index ba4cb80618..e73c048b22 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.4.5 +%define ver 5.4.6 %define rel dev1.0%{dist} %if 0%{?fedora}

1 0

Releasing Kamailio v5.4.6
by Daniel-Constantin Mierla 02 Jun '21

02 Jun '21

Hello, I am considering to release Kamailio v5.4.6 sometime next week, likely on Wednesday or Thursday (June 2 or 3, 2021). This is the usual heads up notification to see if anyone is aware of issues not yet reported to bug tracker and if yes, do it as soon as possible to give them a chance to be fixed. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online - June 7-10, 2021 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

1 1

param.count broken in latest master?
by Juha Heinanen 01 Jun '21

01 Jun '21

This used to work: $var(count) = $(var(servers){param.count,%}); but latest master gives: Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) INFO: pv [pv_shv.c:60]: shvar_init_locks(): locks array size 16 Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) ERROR: pv [pv_trans.c:3254]: tr_parse_paramlist(): invalid count transformation: count,%}! Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) ERROR: <core> [core/pvapi.c:1799]: tr_lookup(): error parsing [{param.count,%}] Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) ERROR: <core> [core/pvapi.c:1106]: pv_parse_spec2(): bad tr in pvar name "var" Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) ERROR: <core> [core/pvapi.c:1131]: pv_parse_spec2(): invalid parsing in [$(var(servers){param.count,%})] at (4) Jun 1 16:02:04 lab sip-proxy[11965]: 0(12020) CRITICAL: <core> [core/cfg.y:3683]: yyerror_at(): parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 7591, column 19-48: Can't get from cache: $(var(servers){param.count,%}) -- Juha

2 3

git:master:6e8e5ed1: pv: fix {param.count} transformation broken by previous commit
by Daniel-Constantin Mierla 01 Jun '21

01 Jun '21

Module: kamailio Branch: master Commit: 6e8e5ed121028bd851d7de214271881a0bb1e4d3 URL: https://github.com/kamailio/kamailio/commit/6e8e5ed121028bd851d7de214271881… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-01T19:45:16+02:00 pv: fix {param.count} transformation broken by previous commit --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/6e8e5ed121028bd851d7de214271881… Patch: https://github.com/kamailio/kamailio/commit/6e8e5ed121028bd851d7de214271881… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 6ad760f19a..98cce7caa8 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -3203,6 +3203,28 @@ char* tr_parse_paramlist(str* in, trans_t *t) goto unknown; } + if(t->subtype == TR_PL_COUNT) { + if(*p==TR_PARAM_MARKER) { + start_pos = ++p; + _tr_parse_sparamx(p, p0, tp, spec, ps, in, s, 1); + t->params = tp; + tp = 0; + if (t->params->type != TR_PARAM_SPEC && p - start_pos != 1) { + LM_ERR("invalid separator in transformation: " + "%.*s\n", in->len, in->s); + goto error; + } + while(*p && (*p==' ' || *p=='\t' || *p=='\n')) p++; + if(*p!=TR_RBRACKET) { + LM_ERR("invalid name transformation: %.*s!\n", + in->len, in->s); + goto error; + } + } + goto done; + } + + /* now transformations with mandatory parameters */ if(*p!=TR_PARAM_MARKER) { LM_ERR("invalid %.*s transformation: %.*s\n", @@ -3223,29 +3245,15 @@ char* tr_parse_paramlist(str* in, trans_t *t) while(is_in_str(p, in) && (*p==' ' || *p=='\t' || *p=='\n')) p++; } - if(t->subtype == TR_PL_COUNT) { - if(*p==TR_PARAM_MARKER) { - start_pos = ++p; - _tr_parse_sparamx(p, p0, tp, spec, ps, in, s, 1); - t->params = tp; - tp = 0; - if (tp->type != TR_PARAM_SPEC && p - start_pos != 1) { - LM_ERR("invalid separator in transformation: " - "%.*s\n", in->len, in->s); - goto error; - } - } - } else { - if(*p==TR_PARAM_MARKER) { - start_pos = ++p; - _tr_parse_sparam(p, p0, tp, spec, ps, in, s); - t->params->next = tp; - tp = 0; - if (p - start_pos != 1) { - LM_ERR("invalid separator in transformation: " - "%.*s\n", in->len, in->s); - goto error; - } + if(*p==TR_PARAM_MARKER) { + start_pos = ++p; + _tr_parse_sparam(p, p0, tp, spec, ps, in, s); + t->params->next = tp; + tp = 0; + if (p - start_pos != 1) { + LM_ERR("invalid separator in transformation: " + "%.*s\n", in->len, in->s); + goto error; } } @@ -3256,6 +3264,7 @@ char* tr_parse_paramlist(str* in, trans_t *t) goto error; } +done: t->name = name; return p;

1 0

git:5.4:df8fb404: mtree: check if pv_count var is r/w
by Daniel-Constantin Mierla 01 Jun '21

01 Jun '21

Module: kamailio Branch: 5.4 Commit: df8fb404c1f3d016f97872d78fe07d604de6ef8b URL: https://github.com/kamailio/kamailio/commit/df8fb404c1f3d016f97872d78fe07d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-01T11:12:13+02:00 mtree: check if pv_count var is r/w - reported by GH #2750 (cherry picked from commit 63b0345207ba67fcc6290d6dfc55f99ba58b13c9) (cherry picked from commit 7323d812dc4a39c0e60f11668e09a50ef586a8f7) --- Modified: src/modules/mtree/mtree_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/df8fb404c1f3d016f97872d78fe07d6… Patch: https://github.com/kamailio/kamailio/commit/df8fb404c1f3d016f97872d78fe07d6… --- diff --git a/src/modules/mtree/mtree_mod.c b/src/modules/mtree/mtree_mod.c index c04f031cfd..63180bbfb7 100644 --- a/src/modules/mtree/mtree_mod.c +++ b/src/modules/mtree/mtree_mod.c @@ -203,7 +203,7 @@ static int mod_init(void) } if(pv_parse_spec(&count_param, &pv_count) < 0 - || !(pv_is_w(&pv_weight))) + || !(pv_is_w(&pv_count))) { LM_ERR("cannot parse count pv or pv is read-only\n"); return -1;

1 0

git:5.4:b5ae51af: core: parse via - fixed whitespacing
by Daniel-Constantin Mierla 01 Jun '21

01 Jun '21

Module: kamailio Branch: 5.4 Commit: b5ae51af479d4e54e5d8c3f5e85908e68183e9d4 URL: https://github.com/kamailio/kamailio/commit/b5ae51af479d4e54e5d8c3f5e85908e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-06-01T11:12:22+02:00 core: parse via - fixed whitespacing (cherry picked from commit 01664d1d82dcfe952fce29033b4fcd5e44cf2319) (cherry picked from commit 19901d0cdb6cf06a84315c19a27986bca7a05025) --- Modified: src/core/parser/parse_via.h --- Diff: https://github.com/kamailio/kamailio/commit/b5ae51af479d4e54e5d8c3f5e85908e… Patch: https://github.com/kamailio/kamailio/commit/b5ae51af479d4e54e5d8c3f5e85908e… --- diff --git a/src/core/parser/parse_via.h b/src/core/parser/parse_via.h index fca486e358..e4957961f1 100644 --- a/src/core/parser/parse_via.h +++ b/src/core/parser/parse_via.h @@ -13,8 +13,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ @@ -32,11 +32,11 @@ struct sip_msg; /* via param types - * WARNING: keep in sync with parse_via.c FIN_HIDDEN... + * WARNING: keep in sync with parse_via.c FIN_HIDDEN... * and with tm/sip_msg.c via_body_cloner */ enum { - PARAM_HIDDEN=230, PARAM_TTL, PARAM_BRANCH, + PARAM_HIDDEN=230, PARAM_TTL, PARAM_BRANCH, PARAM_MADDR, PARAM_RECEIVED, PARAM_RPORT, PARAM_I, PARAM_ALIAS, #ifdef USE_COMP PARAM_COMP, @@ -60,12 +60,12 @@ typedef struct via_param { /* Format: name/version/transport host:port;params comment */ - /* WARNING: keep in sync with tm/sip_msg.c via_body_cloner */ -typedef struct via_body { +/* WARNING: keep in sync with tm/sip_msg.c via_body_cloner */ +typedef struct via_body { int error; str hdr; /* Contains "Via" or "v" */ str name; - str version; + str version; str transport; str host; short proto; /* transport */ @@ -80,7 +80,7 @@ typedef struct via_body { struct via_param* param_lst; /* list of parameters*/ struct via_param* last_param; /*last via parameter, internal use*/ - /* shortcuts to "important" params*/ + /* shortcuts to "important" params*/ struct via_param* branch; str tid; /* transaction id, part of branch */ struct via_param* received; @@ -90,8 +90,8 @@ typedef struct via_body { #ifdef USE_COMP struct via_param* comp; /* see rfc3486 */ #endif - struct via_body* next; /* pointer to next via body string if - compact via or null */ + struct via_body* next; /* pointer to next via body string + if compact via or null */ } via_body_t;

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev