- sr-dev - kamailio.org

git:master:8e2541ec: timer: formatted exported structures
by Daniel-Constantin Mierla 28 Oct '24

28 Oct '24

Module: kamailio Branch: master Commit: 8e2541ec6126b5665e92cde5eaf17f5a4970cb8d URL: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-28T06:45:09+01:00 timer: formatted exported structures --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… Patch: https://github.com/kamailio/kamailio/commit/8e2541ec6126b5665e92cde5eaf17f5… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 2f3f1b1bf34..5cb92a8847c 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -144,15 +144,18 @@ static int sel_executed(str *res, select_t *s, sip_msg_t *msg) return 0; } +/* clang-format off */ select_row_t sel_declaration[] = { - {NULL, SEL_PARAM_STR, STR_STATIC_INIT(MODULE_NAME), sel_root, + {NULL, SEL_PARAM_STR, STR_STATIC_INIT(MODULE_NAME), sel_root, SEL_PARAM_EXPECTED}, - {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("timer"), sel_timer, + {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("timer"), sel_timer, SEL_PARAM_EXPECTED | CONSUME_NEXT_STR | FIXUP_CALL}, - {sel_timer, SEL_PARAM_STR, STR_STATIC_INIT("enabled"), sel_enabled, 0}, - {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("executed"), sel_executed, 0}, + {sel_timer, SEL_PARAM_STR, STR_STATIC_INIT("enabled"), sel_enabled, 0}, + {sel_root, SEL_PARAM_STR, STR_STATIC_INIT("executed"), sel_executed, 0}, - {NULL, SEL_PARAM_STR, STR_NULL, NULL, 0}}; + {NULL, SEL_PARAM_STR, STR_NULL, NULL, 0} +}; +/* clang-format on */ static unsigned int timer_msg_no = 0; @@ -485,30 +488,37 @@ static void destroy_mod(void) } } +/* clang-format off */ /* * Exported functions */ -static cmd_export_t cmds[] = {{MODULE_NAME "_enable", timer_enable_func, 2, - timer_enable_fixup, 0, ANY_ROUTE}, - {0, 0, 0, 0, 0, 0}}; +static cmd_export_t cmds[] = { + {MODULE_NAME "_enable", timer_enable_func, 2, timer_enable_fixup, + 0, ANY_ROUTE}, + + {0, 0, 0, 0, 0, 0} +}; /* * Exported parameters */ static param_export_t params[] = { - {"declare_timer", PARAM_STRING | PARAM_USE_FUNC, (void *)declare_timer}, - {0, 0, 0}}; + {"declare_timer", PARAM_STRING | PARAM_USE_FUNC, (void *)declare_timer}, + + {0, 0, 0 } +}; struct module_exports exports = { - MODULE_NAME, /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* Exported commands */ - params, /* Exported parameters */ - 0, /* Exported RPC functions */ - 0, /* pseudo-variables exports */ - 0, /* response function */ - mod_init, /* module initialization function */ - child_init, /* per-child init function */ - destroy_mod /* destroy function */ + MODULE_NAME, /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* Exported commands */ + params, /* Exported parameters */ + 0, /* Exported RPC functions */ + 0, /* pseudo-variables exports */ + 0, /* response function */ + mod_init, /* module initialization function */ + child_init, /* per-child init function */ + destroy_mod /* destroy function */ }; +/* clang-format on */

1 0

git:master:a4f0ee5d: topos: deal with BYE without contact header for mode 1
by Daniel-Constantin Mierla 28 Oct '24

28 Oct '24

Module: kamailio Branch: master Commit: a4f0ee5da93ad64d449c7a95ecad2f3d70aeb975 URL: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-28T06:33:28+01:00 topos: deal with BYE without contact header for mode 1 --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… Patch: https://github.com/kamailio/kamailio/commit/a4f0ee5da93ad64d449c7a95ecad2f3… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index e87232285f6..b0658da36a1 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -297,33 +297,40 @@ int tps_storage_fill_contact( /* extract the contact address */ if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { - LM_WARN("bad sip message or missing Contact hdr\n"); - return -1; - } - if(parse_contact(msg->contact) < 0 - || ((contact_body_t *)msg->contact->parsed)->contacts - == NULL - || ((contact_body_t *)msg->contact->parsed) - ->contacts->next - != NULL) { - LM_ERR("bad Contact header\n"); - return -1; + if(get_cseq(msg)->method_id != METHOD_BYE) { + LM_WARN("bad sip message or missing Contact header\n"); + return -1; + } else { + LM_DBG("BYE with no contact - skipping it\n"); + } } - if(parse_uri(((contact_body_t *)msg->contact->parsed) - ->contacts->uri.s, - ((contact_body_t *)msg->contact->parsed) - ->contacts->uri.len, - &curi) - < 0) { - LM_ERR("failed to parse the contact uri\n"); - return -1; - } - if(curi.user.len > 0) { - memcpy(td->cp, curi.user.s, curi.user.len); - td->cp += curi.user.len; - cuser_len = curi.user.len; - } else { - LM_DBG("no contact user - skipping it\n"); + if(msg->contact != NULL) { + if(parse_contact(msg->contact) < 0 + || ((contact_body_t *)msg->contact->parsed) + ->contacts + == NULL + || ((contact_body_t *)msg->contact->parsed) + ->contacts->next + != NULL) { + LM_ERR("bad Contact header\n"); + return -1; + } + if(parse_uri(((contact_body_t *)msg->contact->parsed) + ->contacts->uri.s, + ((contact_body_t *)msg->contact->parsed) + ->contacts->uri.len, + &curi) + < 0) { + LM_ERR("failed to parse the contact uri\n"); + return -1; + } + if(curi.user.len > 0) { + memcpy(td->cp, curi.user.s, curi.user.len); + td->cp += curi.user.len; + cuser_len = curi.user.len; + } else { + LM_DBG("no contact user - skipping it\n"); + } } } else { /* extract the ruri */

1 0

git:master:d10257fb: core: parser sdp - check len gor extracting fmtp
by Daniel-Constantin Mierla 26 Oct '24

26 Oct '24

Module: kamailio Branch: master Commit: d10257fbfdbb3e3e73c0fe60a224585822bdd7b3 URL: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:46:01+02:00 core: parser sdp - check len gor extracting fmtp --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… Patch: https://github.com/kamailio/kamailio/commit/d10257fbfdbb3e3e73c0fe60a224585… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index fe5b464e473..0e61fe5ca5d 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -218,8 +218,12 @@ int extract_fmtp(str *body, str *fmtp_payload, str *fmtp_string) char *cp, *cp1; int len; + if(body->len <= 7) { + return -1; + } if(strncasecmp(body->s, "a=fmtp:", 7) != 0) { - /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", body->len, body->s); */ + /*LM_DBG("We are not pointing to an a=fmtp: attribute =>`%.*s'\n", + * body->len, body->s); */ return -1; }

1 0

git:master:3e5f8dec: dispatcher: debug messages for checking active destinations
by Daniel-Constantin Mierla 26 Oct '24

26 Oct '24

Module: kamailio Branch: master Commit: 3e5f8deced0cb05710e631601e9098505f1d230a URL: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-26T07:40:07+02:00 dispatcher: debug messages for checking active destinations --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… Patch: https://github.com/kamailio/kamailio/commit/3e5f8deced0cb05710e631601e90985… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index f17963cc3bf..83bb7636206 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3945,11 +3945,15 @@ int ds_is_active_uri(sip_msg_t *msg, int group, str *uri) for(j = 0; j < list->nr; j++) { if(!ds_skip_dst(list->dlist[j].flags)) { if(uri == NULL || uri->s == NULL || uri->len <= 0) { + LM_DBG("one destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } if((list->dlist[j].uri.len == uri->len) && (memcmp(list->dlist[j].uri.s, uri->s, uri->len) == 0)) { + LM_DBG("destination active: %d %.*s\n", group, + list->dlist[j].uri.len, list->dlist[j].uri.s); return 1; } }

1 0

[kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)
by uv-2722 24 Oct '24

24 Oct '24

### Description Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get the following errors during installation. ### Troubleshooting #### Reproduction Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl support. Then install kamailio 5.8.1 from source with db_redis module  #### Log Messages  ``` 37.77 CC (gcc) [M db_redis.so] db_redis_mod.o 37.85 CC (gcc) [M db_redis.so] redis_connection.o 37.90 redis_connection.c: In function 'db_redis_connect': 37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did you mean 'redisContext'? 37.90 129 | redisSSLContext *ssl = NULL; 37.90 | ^~~~~~~~~~~~~~~ 37.90 | redisContext 37.90 redis_connection.c:166:17: warning: implicit declaration of function 'redisInitOpenSSL' [-Wimplicit-function-declaration] 37.90 166 | redisInitOpenSSL(); 37.90 | ^~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:23: warning: implicit declaration of function 'redisCreateSSLContext' [-Wimplicit-function-declaration] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^~~~~~~~~~~~~~~~~~~~~ 37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 37.90 167 | ssl = redisCreateSSLContext( 37.90 | ^ 37.91 redis_connection.c:196:17: warning: implicit declaration of function 'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? [-Wimplicit-function-declaration] 37.91 196 | redisClusterSetOptionEnableSSL(con->con, ssl); 37.91 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37.91 | redisClusterSetOptionMaxRetry 37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1 37.93 make[1]: *** [Makefile:508: modules] Error 1 37.93 make[1]: Leaving directory '/root/build/kamailio/src' 37.93 make: *** [Makefile:34: all] Error 2 ``` ### Additional Information * **Kamailio Version**: ``` Kamailio 5.8.1 ``` * **Operating System**:  ``` Debian 12 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3893 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3893(a)github.com>

4 8

git:master:a6b924be: topos: extended error log message
by Daniel-Constantin Mierla 23 Oct '24

23 Oct '24

Module: kamailio Branch: master Commit: a6b924be7fd7d4ce6a92ad5a0247077b09a29474 URL: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: extended error log message - ensure headers are parsed for storage record --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… Patch: https://github.com/kamailio/kamailio/commit/a6b924be7fd7d4ce6a92ad5a0247077… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 1fe7319b926..e87232285f6 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,10 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(parse_headers(msg, HDR_EOH_F, 0) == -1) { + return -1; + } + if(get_cseq(msg)->method_id == METHOD_ACK) { if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { /* ACK with no Contact - nothing to store */ @@ -649,7 +653,8 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) return 0; error: - LM_ERR("failed to store\n"); + LM_ERR("failed to store (dlg: %d dir: %d metid: %d)\n", dialog, dir, + get_cseq(msg)->method_id); return ret; }

1 0

git:master:824e8131: topos: catch ACK without contact that needs no storage updates
by Daniel-Constantin Mierla 23 Oct '24

23 Oct '24

Module: kamailio Branch: master Commit: 824e81319b60054feb81c37b3a8be80523f8c95d URL: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-23T08:22:14+02:00 topos: catch ACK without contact that needs no storage updates --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… Patch: https://github.com/kamailio/kamailio/commit/824e81319b60054feb81c37b3a8be80… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 946092c04f9..1fe7319b926 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -594,6 +594,12 @@ int tps_storage_record(sip_msg_t *msg, tps_data_t *td, int dialog, int dir) str suid; str *sx = NULL; + if(get_cseq(msg)->method_id == METHOD_ACK) { + if(parse_headers(msg, HDR_CONTACT_F, 0) < 0 || msg->contact == NULL) { + /* ACK with no Contact - nothing to store */ + return 0; + } + } if(_tps_context_value.len > 0) { sx = &_tps_context_value; } else if(_tps_context_param.len > 0) {

1 0

[kamailio/kamailio] nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! (Issue #4005)
by Md. Mostafijur Rahman 22 Oct '24

22 Oct '24

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### Log Messages  ``` Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 1 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {2 1 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 407 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3050]: INFO: {1 1 INVITE udfal237dcbsaao5u84v} <script>: FS_FAULT Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 1 ACK udfal237dcbsaao5u84v} <script>: ACK from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: INVITE from: sip:voc_104@sip-dev.cleverstack.in (IP:103.133.141.52:54169) to: sip:voc_106@sip-pd.cleverstack.in , ru=sip:voc_106@sip-pd.cleverstack.in Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} nathelper [nathelper.c:745]: set_contact_alias(): you can't update contact twice, check your config! Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to sip:voc_106@sip-pd.cleverstack.in -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:wss Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: INFO: {1 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine offer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3071]: ERROR: {1 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3046]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 100 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: #015#012FS_REPLY - <null> : INVITE : 183 Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Branch [0] to <null> -- FLAGS: 8192 Checking Conditions Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: UDP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: INFO: {2 2 INVITE udfal237dcbsaao5u84v} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:1) RTP-Engine answer: via-branch=extra trust-address replace-origin replace-session-connection rtcp-mux-demux ICE=remove RTP/AVP Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=20 callid=udfal237dcbsaao5u84v Oct 23 02:08:17 ip145 /usr/sbin/kamailio[3042]: ERROR: {2 2 INVITE udfal237dcbsaao5u84v} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: INVITE from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request INVITE from FS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg || sip:voc_104@51.79.190.145 --> sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: FS_TO_KAM || looking for registered extension Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: LOCATION || exturl = sip:voc_106@sip-dev.cleverstack.in Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Branch [0] to sip:g321jqm6@14gassrhfn7h.invalid;transport=ws;lhst=103.133.141.52:53161;lm=midreg -- FLAGS: 8320 Checking Conditions Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Source Protocol:udp Destination Protocol: WS Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: Saving RtpEngine ID: 4 into SIP R-Route params Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: INFO: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <script>: HANDLE_NAT_SDP: (Branch:[0] EngineID:4) RTP-Engine offer: trust-address replace-origin replace-session-connection rtcp-mux-offer DTLS=passive SDES-off ICE=force RTP/SAVPF via-branch=extra DTLS-fingerprint=sha-256 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:3397]: select_rtpp_node(): rtpengine failed to select new for calllen=36 callid=1cd1065f-aec7-4360-8631-3198d673c841 Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} rtpengine [rtpengine.c:2737]: rtpp_function_call(): no available proxies Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/forward.c:231]: get_send_socket2(): protocol/port mismatch (forced udp:51.79.190.145:5560, to ws:103.133.141.52:53161) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: WARNING: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2864]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} <core> [core/msg_translator.c:2040]: build_req_buf_from_sip_req(): could not create Via header Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:479]: prepare_new_uac(): could not build request Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} tm [t_fwd.c:1757]: t_forward_nonack(): failure to add branches Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3051]: ERROR: {1 90260957 INVITE 1cd1065f-aec7-4360-8631-3198d673c841} sl [sl_funcs.c:418]: sl_reply_error(): stateless error reply used: No error (2/SL) Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: ACK from: sip:voc_104@51.79.190.145 (IP:51.79.190.145:5062) to: sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg , ru=sip:u9l1bt5k@m2kc1a56vh3q.invalid;transport=ws;lhst=103.133.141.52:53934;lm=midreg Oct 23 02:08:18 ip145 /usr/sbin/kamailio[3043]: INFO: {1 90260957 ACK 1cd1065f-aec7-4360-8631-3198d673c841} <script>: SOURCE_CLASSIFY: request ACK from FS ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.3.9 ``` * **Operating System**:  ``` Centos7 & Debian 12 both have same issue ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4005 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4005(a)github.com>

2 4

[kamailio/kamailio] [JWT Module] Failed to decode JWT value (Issue #4003)
by Lyuboslav Alexandrov 22 Oct '24

22 Oct '24

### Description  Tried to verify a dubious JWT, but I get a token decoding error. I tried different variations of the key, such as `.pem`, `.key` extensions, `PKCS1`, `PKCS8` formats, reading the key from a variable or file. ### Troubleshooting #### Reproduction  Have the following Kamailio config: ``` loadmodule "jwt.so" ... modparam("jwt", "key_mode", 0) .... $var(authorization_header_value) = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiYmQ1NzlhZTYyZjg2ODE5N2I5OTk1YTFkOWM4NGZkOGFiNWIyYWI4Nzk5YzM0OWVmYjBkNjg1NWFiNDcwYWUzOTYyMzFmYzc5NjIxZDQxODciLCJpYXQiOjE3MjkxODU3MTguNjQxMjI1LCJuYmYiOjE3MjkxODU3MTguNjQxMjI"; $var(jwt_verification) = jwt_verify("/etc/kamailio/oauth_pub.pem", "RS256", "sub='$fU'", "$var(authorization_header_value)" ); ... ``` oauth_pub.pem: ``` -----BEGIN PUBLIC KEY----- MIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA5mfAgdn7JaiRS2Bsov4S zTlGLSe2wxbdUxIreTcqs88PmWOBtuSeQg5tU3CRnPtsuuRJrlUniV5g56YAHrnt Qe8meu877iTrcJB6Cii3n+d7SgwCfjMvaFBR+mdGsidAyGBpRhoPrH7SD6CRpBLr Mxylcgqw4uH/0HdF+B8P5motUQz/tul/UKsq1nvC2AOOzFel1IsUah8dQuxzMx+P RYcsngJam8TkGr6QidTXc2rD4lEoCD1s/huGUq55bc19J3yRliN2j8cO9j1bGTsp GYEVtA3PiH/73BZTa3FHbhRYqhvjYacC8eWBFhwThC9CgPyOXrq4L7p9tJAlNwmd dQHhIzZ9vugQuhfnuUTb0/r2tjpsSPL7etgJdxtZ4Xh9aBEpYn//RAgu5Dkauc2S XF+uLWwBptFTM3SNppDPMdjRkYakWjVP2pgBGMmrINFb8RQAPEJzD1gVt0fYCxaY jiazbSc9FPfSbFENHq+r8D7OivpiW0q9+tSZbYmAFzZekoUAoboQThSdRcOy9tFz 196xfg4dOyxkRGGHstz28qBv340ppjnHQd+RZOvbr8s2zEIxGiOpfX8CuLur/nKl Ld3qtzg0caqDz6nsYK+95rExnbtU+gFcHnwtMdk3R8X6lVHzDeTjO2Nk4Zo023zo qFH/rRyJBOp98fQPOpx5qncCAwEAAQ== -----END PUBLIC KEY----- ``` #### Debugging Data  #### Log Messages  ``` [jwt_mod.c:501]: ki_jwt_verify_key(): failed to decode jwt value ``` #### SIP Traffic  ### Possible Solutions  I've wrote a C++ program using `libjwt` to make sure the issue is not neither my key, nor `libjwt`. And they aren't. Here is the program: ```cpp #include <iostream> #include <string> #include <jwt.h> static const char jwt_test[] = "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIyIiwianRpIjoiZDY2NDQ4MTdhYWRhNTQ1MDI1YmUwZmU1M2I1ZmFhYTdkZGI3NTY5NTBiMDYxMzk5MzFmNTQ1ZjhkMmE4N2ZhYjU0ODgzNjJhZGNiMWQ5ZTkiLCJpYXQiOjE3MjkyMjg5NjIuMzg5MDI3LCJuYmYiOjE3MjkyMjg5NjIuMzg5MDMzLCJleHAiOjE3MjkyNzIxNjIuMzc5MTg3LCJzdWIiOiIxNDQ0ODEiLCJzY29wZXMiOltdLCJ1c2VyIjp7ImlkIjoxNDQ0ODEsImFjY291bnRfaWQiOjEyOTMyNn0sIm1veHRyYS10b2tlbiI6Ik1WUXpNekZVTU1hdlFET2hNVlNabEdRZ1ptQUNPRmNGU1JKZEVGNGZTQTFFRWxJLVVCMTRkREZVTVZkbFkxY0xjaHhrWkhrU1pnVjVERUppQ0dKSEJWZGxYQTFMQmwwYUF4MUdHbHdkX0RmbHhORGRNMXMzOXlabjhMMEV5USIsImRldmljZSI6eyJpZCI6ImY4MzI0NDkyLWJiYjQtNGJiNC04ZWQxLWZlMTM1OWQwOTNlNSIsInR5cGUiOiJ3ZWIiLCJ2ZXJzaW9uIjoiMS43LjAifX0.E_6jsC7yxPZgHRry55J0oOBzw25tvlfnWRBqSwLVFeAtavkVrYGmH9BGaByaAhebKNijy2WUg1X8Ug0N9Z9cc3P8u2wDSlvlzTNrxnPqdxMrKtP5wiIbImXboobFqKXLRmbor_9I7r0lBlX-e0xSis-PTaBqH40hDYPj0rR5cqnrszSkEMd2jFdiLL5BoF0pqysvrXA631KKA9oHGzAivib_GOddHeUOAVs7-hMVdnDqgrzZ6lDYkQndutrHpwILZWz09ngJBbRh_mN_cE4dDxghgeSotXADT-h5DlokV8ChkgkmHh6m4gU2lvnb7aY9dbCp9R44T1Rpz1P_HhPQ27p1Sgin40Oc2abBwDePw_chl0ajJHuhJCiK7YHbcmzcv3dZ-igVMYpMqhGIlyyuAHCSrKFVFLhodA1xlyCmMqJfFPOZ6DdKzbAQDWPN2xsCMy7WkGT5KmBQR5wWJRIRbTj4OUWo6iUrQdNyjB0F1RKqkuZlz414Hj0tkS5GlS1rfxOtS4yc2m_ERGomSmpDgoq2zpA5o3oJJWXqA7TzT8X_9Up5DkVQCMGW6Z2OT9Sr8hNjIXB1qgYiiZtNf9_b4bma5JEwVvR2-qcZ92V6owFTYx78smdyOgAaMlBQ_9AM6kARz4ZnC3Mz2feJT2qKLP-z9senqIB8k_xNx2lbU2w"; static unsigned char key[16384]; static size_t key_len; static void read_key(const char *key_file) { FILE *fp = fopen(key_file, "r"); int ret = 0; fp = fopen(key_file, "r"); key_len = fread(key, 1, sizeof(key), fp); fclose(fp); key[key_len] = '\0'; } int main() { jwt_t *jwt = NULL; int ret = 0; read_key("oauth_pub.pem"); ret = jwt_decode(&jwt, jwt_test, key, key_len); printf("Decoding exit status: %d\n", ret); printf("User ID: %s\n", jwt_get_grant(jwt, "sub")); return 0; } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) 3fa5f4 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 3fa5f4 compiled on 10:39:56 Jun 12 2024 with gcc 8.5.0 ``` * **Operating System**:  ``` Rocky Linux 8.10 (Green Obsidian) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4003 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4003(a)github.com>

2 3

git:master:c67d8fa0: lrkproxy: use core str comparison functions and macros
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c67d8fa0b1015d73b34430f6f8a6afe22ca10cbe URL: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 lrkproxy: use core str comparison functions and macros --- Modified: src/modules/lrkproxy/lrkproxy_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… Patch: https://github.com/kamailio/kamailio/commit/c67d8fa0b1015d73b34430f6f8a6afe… --- diff --git a/src/modules/lrkproxy/lrkproxy_hash.c b/src/modules/lrkproxy/lrkproxy_hash.c index dc0b365eed6..7daeb6596b1 100644 --- a/src/modules/lrkproxy/lrkproxy_hash.c +++ b/src/modules/lrkproxy/lrkproxy_hash.c @@ -34,24 +34,6 @@ static void lrkproxy_hash_table_free_row_lock(gen_lock_t *row_lock); static struct lrkproxy_hash_table *lrkproxy_hash_table; -/* get from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* get from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* get from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -321,8 +303,8 @@ int lrkproxy_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(lrkproxy_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -403,13 +385,13 @@ int lrkproxy_hash_table_remove(str callid, str viabranch, enum lrk_operation op) viabranch.len, viabranch.s, entry->viabranch.len, entry->viabranch.s); // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE) - || str_equal(entry->callid, callid)) { - // if ((str_equal(entry->callid, callid) && str_equal(entry->viabranch, viabranch)) || - // (str_equal(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { + || STR_EQ(entry->callid, callid)) { + // if ((STR_EQ(entry->callid, callid) && STR_EQ(entry->viabranch, viabranch)) || + // (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry // set pointers; exclude entry @@ -496,10 +478,10 @@ struct lrkproxy_hash_entry *lrkproxy_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0) - || str_equal(entry->callid, callid)) { + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0) + || STR_EQ(entry->callid, callid)) { // node = entry->node; // unlock

1 0

git:master:9ee18988: pipelimit: use core str comparison functions
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 9ee189883549faffb21d3ae113dafd7ad95757af URL: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 pipelimit: use core str comparison functions --- Modified: src/modules/pipelimit/pl_ht.h --- Diff: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… Patch: https://github.com/kamailio/kamailio/commit/9ee189883549faffb21d3ae113dafd7… --- diff --git a/src/modules/pipelimit/pl_ht.h b/src/modules/pipelimit/pl_ht.h index 8ee6568ea69..86eab1092dc 100644 --- a/src/modules/pipelimit/pl_ht.h +++ b/src/modules/pipelimit/pl_ht.h @@ -98,16 +98,6 @@ typedef struct str_map extern str_map_t algo_names[]; -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - /** * converts a mapped str to an int * \return 0 if found, -1 otherwise @@ -115,7 +105,7 @@ static inline int str_i_cmp(const str *a, const str *b) static inline int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_i_cmp(&map->str, key)) { + if(!str_strcasecmp(&map->str, key)) { *ret = map->id; return 0; }

1 0

git:master:c44a3499: ratelimit: use core str comparison functions
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c44a349964081d397ab9efa3504737bf369f8cf5 URL: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:35+02:00 ratelimit: use core str comparison functions --- Modified: src/modules/ratelimit/ratelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… Patch: https://github.com/kamailio/kamailio/commit/c44a349964081d397ab9efa3504737b… --- diff --git a/src/modules/ratelimit/ratelimit.c b/src/modules/ratelimit/ratelimit.c index 5cac92464db..295102bd08e 100644 --- a/src/modules/ratelimit/ratelimit.c +++ b/src/modules/ratelimit/ratelimit.c @@ -60,9 +60,6 @@ MODULE_VERSION #define RXL(m, str, i) (int)((m)[i].rm_eo - (m)[i].rm_so) #define RXS(m, str, i) (str) + (m)[i].rm_so -static inline int str_cmp(const str *a, const str *b); -static inline int str_i_cmp(const str *a, const str *b); - typedef struct str_map { str str; @@ -256,7 +253,7 @@ struct module_exports exports = { static int str_map_str(const str_map_t *map, const str *key, int *ret) { for(; map->str.s; map++) - if(!str_cmp(&map->str, key)) { + if(!str_strcmp(&map->str, key)) { *ret = map->id; return 0; } @@ -704,16 +701,6 @@ static void destroy(void) } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - -static inline int str_i_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncasecmp(a->s, b->s, a->len)); -} - str queue_other = str_init("*"); /** @@ -727,10 +714,10 @@ static int find_queue(struct sip_msg *msg, str *method, int *queue) *queue = -1; for(i = 0; i < *nqueues; i++) - if(!str_i_cmp(queues[i].method, method)) { + if(!str_strcasecmp(queues[i].method, method)) { *queue = i; return 0; - } else if(!str_i_cmp(queues[i].method, &queue_other)) { + } else if(!str_strcasecmp(queues[i].method, &queue_other)) { *queue = i; }

1 0

git:master:ef9fa6fb: rtpengine: use core str comparison functions and macros
by Victor Seva 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: ef9fa6fb34859890afef70fc3803de360979e213 URL: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-22T16:45:34+02:00 rtpengine: use core str comparison functions and macros --- Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… Patch: https://github.com/kamailio/kamailio/commit/ef9fa6fb34859890afef70fc3803de3… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e31feb3ceeb..e04bb5e9fb3 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -859,11 +859,6 @@ static int bind_force_send_ip(int sock_idx) return 0; } -static inline int str_cmp(const str *a, const str *b) -{ - return !(a->len == b->len && !strncmp(a->s, b->s, a->len)); -} - static inline int str_eq(const str *p, const char *q) { int l = strlen(q); @@ -963,7 +958,7 @@ struct rtpp_node *get_rtpp_node(struct rtpp_set *rtpp_list, str *url) lock_get(rtpp_list->rset_lock); rtpp_node = rtpp_list->rn_first; while(rtpp_node) { - if(str_cmp(&rtpp_node->rn_url, url) == 0) { + if(str_strcmp(&rtpp_node->rn_url, url) == 0) { lock_release(rtpp_list->rset_lock); return rtpp_node; } @@ -4247,7 +4242,7 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, if(!bencode_dictionary_get_str(tag_dict, "label", &check)) continue; LM_DBG("rtpengine: XXX got label %.*s\n", check.len, check.s); - if(str_cmp(&check, &label)) + if(str_strcmp(&check, &label)) continue; LM_DBG("rtpengine: XXX label match\n"); medias = @@ -5800,4 +5795,4 @@ static int bind_rtpengine(rtpengine_api_t *api) api->rtpengine_delete = ki_rtpengine_delete; return 0; -} \ No newline at end of file +} diff --git a/src/modules/rtpengine/rtpengine_hash.c b/src/modules/rtpengine/rtpengine_hash.c index de6dbc9d5ed..2c7f8f2f0ba 100644 --- a/src/modules/rtpengine/rtpengine_hash.c +++ b/src/modules/rtpengine/rtpengine_hash.c @@ -11,24 +11,6 @@ static void rtpengine_hash_table_free_row_lock(gen_lock_t *row_lock); static struct rtpengine_hash_table *rtpengine_hash_table; -/* from sipwise rtpengine */ -static int str_cmp_str(const str a, const str b) -{ - if(a.len < b.len) - return -1; - if(a.len > b.len) - return 1; - if(a.len == 0 && b.len == 0) - return 0; - return memcmp(a.s, b.s, a.len); -} - -/* from sipwise rtpengine */ -static int str_equal(str a, str b) -{ - return (str_cmp_str(a, b) == 0); -} - /* from sipwise rtpengine */ static unsigned int str_hash(str s) { @@ -254,8 +236,8 @@ int rtpengine_hash_table_insert( while(entry) { // if found, don't add new entry - if(str_equal(entry->callid, new_entry->callid) - && str_equal(entry->viabranch, new_entry->viabranch)) { + if(STR_EQ(entry->callid, new_entry->callid) + && STR_EQ(entry->viabranch, new_entry->viabranch)) { // unlock lock_release(rtpengine_hash_table->row_locks[hash_index]); LM_NOTICE("callid=%.*s, viabranch=%.*s already in hashtable, " @@ -324,9 +306,9 @@ int rtpengine_hash_table_remove( while(entry) { // if callid found, delete entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { // set pointers; exclude entry last_entry->next = entry->next; @@ -407,9 +389,9 @@ struct rtpp_node *rtpengine_hash_table_lookup( while(entry) { // if callid found, return entry - if((str_equal(entry->callid, callid) - && str_equal(entry->viabranch, viabranch)) - || (str_equal(entry->callid, callid) && viabranch.len == 0 + if((STR_EQ(entry->callid, callid) + && STR_EQ(entry->viabranch, viabranch)) + || (STR_EQ(entry->callid, callid) && viabranch.len == 0 && op == OP_DELETE)) { node = entry->node;

1 0

[kamailio/kamailio] rtpengine: use core STR_EQ macro (PR #4004)
by Victor Seva 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description don't reinvent the wheel and just use core macro You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4004 -- Commit Summary -- * rtpengine: use core STR_EQ macro -- File Changes -- M src/modules/rtpengine/rtpengine.c (11) M src/modules/rtpengine/rtpengine_hash.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4004.patch https://github.com/kamailio/kamailio/pull/4004.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4004 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4004(a)github.com>

1 2

[kamailio/kamailio] [WIP] ims_registrar_scscf: fixing em_max_expires (PR #3989)
by Dragos Vingarzan 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case of Emergency-Registrations the S-CSCF was wrongly setting the expires of the `;sos` contacts to `em_min_expires` if they were above `em_max_expires`. Other smaller related fixes: - Fixed also another typo in the config params definition. - Added some code to more easily make sense of which attributes of a struct are set with what. - Added conditions to respect the parameter documentation which indicate that if set to 0, the expires conditions won't be used. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3989 -- Commit Summary -- * ims_registrar_scscf: fixing em_max_expires -- File Changes -- M src/modules/ims_registrar_scscf/config.c (26) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2) M src/modules/ims_registrar_scscf/save.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3989.patch https://github.com/kamailio/kamailio/pull/3989.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3989 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3989(a)github.com>

1 7

git:master:3f38206d: ims_registrar_scscf: fixing em_max_expires
by Dragos Vingarzan 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 3f38206d88af0fae4c64ee3072eb78ea68f813cb URL: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… Author: Dragos Vingarzan <vingarzan(a)gmail.com> Committer: Dragos Vingarzan <dragos(a)neatpath.net> Date: 2024-10-22T16:21:49+02:00 ims_registrar_scscf: fixing em_max_expires --- Modified: src/modules/ims_registrar_scscf/config.c Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c Modified: src/modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… Patch: https://github.com/kamailio/kamailio/commit/3f38206d88af0fae4c64ee3072eb78e… --- diff --git a/src/modules/ims_registrar_scscf/config.c b/src/modules/ims_registrar_scscf/config.c index a01b4185f79..e4a2b5b5a14 100644 --- a/src/modules/ims_registrar_scscf/config.c +++ b/src/modules/ims_registrar_scscf/config.c @@ -31,19 +31,19 @@ #include "config.h" struct cfg_group_registrar default_registrar_cfg = { - 3600, /* default_expires */ - 0, /* default_expires_range */ - 60, /* min_expires */ - 0, /* max_expires */ - 3600, /* emergency contact default expires */ - 60, /* emergency contact max expires */ - 0, /* emergency contact min expires */ - 0, /* max_contacts */ - 0, /* retry_after */ - 0, /* case_sensitive */ - Q_UNSPECIFIED, /* default_q */ - 1, /* append_branches */ - "" /* realm_pref */ + .default_expires = 3600, /* default_expires */ + .default_expires_range = 0, /* default_expires_range */ + .min_expires = 60, /* min_expires */ + .max_expires = 600000, /* max_expires */ + .em_default_expires = 1800, /* emergency contact default expires */ + .em_max_expires = 3600, /* emergency contact max expires */ + .em_min_expires = 0, /* emergency contact min expires */ + .max_contacts = 0, /* max_contacts */ + .retry_after = 0, /* retry_after */ + .case_sensitive = 0, /* case_sensitive */ + .default_q = Q_UNSPECIFIED, /* default_q */ + .append_branches = 1, /* append_branches */ + .realm_pref = "" /* realm_pref */ }; void *registrar_cfg = &default_registrar_cfg; diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c index 08260dcb0a3..9c0b5c534e3 100644 --- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c +++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c @@ -284,7 +284,7 @@ static param_export_t params[] = { {"max_expires", INT_PARAM, &default_registrar_cfg.max_expires}, {"em_default_expires", INT_PARAM, &default_registrar_cfg.em_default_expires}, - {"em_min_expires", INT_PARAM, &default_registrar_cfg.em_max_expires}, + {"em_max_expires", INT_PARAM, &default_registrar_cfg.em_max_expires}, {"em_min_expires", INT_PARAM, &default_registrar_cfg.em_min_expires}, {"default_q", INT_PARAM, &default_registrar_cfg.default_q}, diff --git a/src/modules/ims_registrar_scscf/save.c b/src/modules/ims_registrar_scscf/save.c index cf3bea78277..8c67b62c241 100644 --- a/src/modules/ims_registrar_scscf/save.c +++ b/src/modules/ims_registrar_scscf/save.c @@ -125,20 +125,24 @@ static inline int calc_contact_expires( : default_registrar_cfg.default_expires; goto end; } - if(!sos_reg && r < default_registrar_cfg.min_expires) { + if(!sos_reg && r < default_registrar_cfg.min_expires + && default_registrar_cfg.min_expires != 0) { r = default_registrar_cfg.min_expires; goto end; } - if(sos_reg && r < default_registrar_cfg.em_min_expires) { + if(sos_reg && r < default_registrar_cfg.em_min_expires + && default_registrar_cfg.em_min_expires != 0) { r = default_registrar_cfg.em_min_expires; goto end; } - if(!sos_reg && r > default_registrar_cfg.max_expires) { + if(!sos_reg && r > default_registrar_cfg.max_expires + && default_registrar_cfg.max_expires != 0) { r = default_registrar_cfg.max_expires; goto end; } - if(sos_reg && r > default_registrar_cfg.em_max_expires) { - r = default_registrar_cfg.em_min_expires; + if(sos_reg && r > default_registrar_cfg.em_max_expires + && default_registrar_cfg.em_max_expires != 0) { + r = default_registrar_cfg.em_max_expires; goto end; } end:

1 0

[kamailio/kamailio] Add ims_icscf module db tables schema (PR #3991)
by Xenofon Karamanos 22 Oct '24

22 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3876 #### Description  This PR add the schemas for the table needed for the module ims-icscf You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3991 -- Commit Summary -- * Add ims_icscf db schema -- File Changes -- A src/lib/srdb1/schema/kamailio-ims_icscf.xml (14) A src/lib/srdb1/schema/nds_trusted_domains.xml (41) A src/lib/srdb1/schema/s_cscf.xml (49) A src/lib/srdb1/schema/s_cscf_capabilities.xml (58) M utils/kamctl/kamdbctl.base (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3991.patch https://github.com/kamailio/kamailio/pull/3991.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3991 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3991(a)github.com>

2 3

git:master:a0941254: db_schema: Create new table definitions
by Henning Westerholt 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: a094125433122313c2e02dfc0e9ad5d3a5beaa50 URL: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-10-22T12:59:03+02:00 db_schema: Create new table definitions --- Added: utils/kamctl/db_berkeley/kamailio/nds_trusted_domains Added: utils/kamctl/db_berkeley/kamailio/s_cscf Added: utils/kamctl/db_berkeley/kamailio/s_cscf_capabilities Added: utils/kamctl/db_redis/kamailio/nds_trusted_domains Added: utils/kamctl/db_redis/kamailio/s_cscf Added: utils/kamctl/db_redis/kamailio/s_cscf_capabilities Added: utils/kamctl/db_sqlite/ims_icscf-create.sql Added: utils/kamctl/dbtext/kamailio/nds_trusted_domains Added: utils/kamctl/dbtext/kamailio/s_cscf Added: utils/kamctl/dbtext/kamailio/s_cscf_capabilities Added: utils/kamctl/mongodb/kamailio/nds_trusted_domains.json Added: utils/kamctl/mongodb/kamailio/s_cscf.json Added: utils/kamctl/mongodb/kamailio/s_cscf_capabilities.json Added: utils/kamctl/mysql/ims_icscf-create.sql Added: utils/kamctl/oracle/ims_icscf-create.sql Added: utils/kamctl/postgres/ims_icscf-create.sql Added: utils/kamctl/xhttp_pi/ims_icscf-mod Added: utils/kamctl/xhttp_pi/ims_icscf-table Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mongodb/kamailio/version-create.mongo Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d… Patch: https://github.com/kamailio/kamailio/commit/a094125433122313c2e02dfc0e9ad5d…

1 0

git:master:e2ea7279: db_schema: Add ims_icscf db schema
by Henning Westerholt 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: e2ea727988828a9683ef112637e25ee4d58032f7 URL: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-10-22T12:59:03+02:00 db_schema: Add ims_icscf db schema --- Added: src/lib/srdb1/schema/kamailio-ims_icscf.xml Added: src/lib/srdb1/schema/nds_trusted_domains.xml Added: src/lib/srdb1/schema/s_cscf.xml Added: src/lib/srdb1/schema/s_cscf_capabilities.xml Modified: utils/kamctl/kamdbctl.base --- Diff: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee… Patch: https://github.com/kamailio/kamailio/commit/e2ea727988828a9683ef112637e25ee…

1 0

git:master:c823f413: core: parser sdp - check length for rtpmap extract
by Daniel-Constantin Mierla 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: c823f41350ab9186a323707e9be32e31922bec17 URL: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-22T07:41:08+02:00 core: parser sdp - check length for rtpmap extract --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… Patch: https://github.com/kamailio/kamailio/commit/c823f41350ab9186a323707e9be32e3… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a74f78abb84..fe5b464e473 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -151,6 +151,9 @@ int extract_rtpmap(str *body, str *rtpmap_payload, str *rtpmap_encoding, char *cp, *cp1; int len; + if(body->len <= 9) { + return -1; + } if(strncasecmp(body->s, "a=rtpmap:", 9) != 0) { /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", * body->len, body->s); */

1 0

git:master:0cbb2eb0: jwt: print decode result in error log message
by Daniel-Constantin Mierla 22 Oct '24

22 Oct '24

Module: kamailio Branch: master Commit: 0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5 URL: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-22T07:34:29+02:00 jwt: print decode result in error log message --- Modified: src/modules/jwt/jwt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Patch: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… --- diff --git a/src/modules/jwt/jwt_mod.c b/src/modules/jwt/jwt_mod.c index 0efb793c47f..af3d42f79c5 100644 --- a/src/modules/jwt/jwt_mod.c +++ b/src/modules/jwt/jwt_mod.c @@ -498,7 +498,7 @@ static int ki_jwt_verify_key( ret = jwt_decode( &jwt, jwtval->s, (unsigned char *)kdata.s, (size_t)kdata.len); if(ret != 0 || jwt == NULL) { - LM_ERR("failed to decode jwt value\n"); + LM_ERR("failed to decode jwt value (ret: %d jwt: %p)\n", ret, jwt); goto error; } if(jwt_validate(jwt, jwt_valid) != 0) {

1 0

git:master:6b7894d6: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 21 Oct '24

21 Oct '24

Module: kamailio Branch: master Commit: 6b7894d66ca65ca99b5987ddc35a7f28c7a88949 URL: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-21T15:01:11+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Patch: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 6b1d875d77e..4658b7a3f35 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -674,15 +674,15 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) to all rtpengines, else no rtpengine will be queried until its rtpengine_disable_tout timeout passes. - Default value is ��1�� (enabled). + Default value is ��0�� (disabled). Can be set at runtime, e.g.: $ kamcmd cfg.set_now_int rtpengine aggressive_redetectio -n 0 +n 1 Example 1.3. Set aggressive_redetection parameter ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... 4.4. rtpengine_tout_ms (integer)

1 0

[kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)
by Stefan Mititelu 21 Oct '24

21 Oct '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #3297 #### Description  The setup is a kamailio with no available rtpengine. (e.g. has a list with rtpengine urls but those are not reachable) Recently had a crash similar to #3297, but in an outdated kamailio version (5.5.7). Tried to reproduce this in 5.5.7 and 5.8.3 but could not crash any of them. However I managed to get the logs similar to ones right before the crash happened: ``` 2024-10-04T17:39:58.026206+03:00 kamailio[450237]: ERROR: {1 1 INVITE 203-450290(a)192.168.100.93} <core> [core/action.c:1595]: run_actions(): alert - action [corefunc (16)] cfg [/home/stefan/kamailio.cfg:625] took too long [29310906 us] ``` ...directly related to how much rtpengine_manage() function took to execute. So routing of SIP is delayed by that ammount. Tracked this in code, down to where this lock is get, when "aggressive_redetection" modparam is enabled: https://github.com/kamailio/kamailio/blob/66fe6eb71e58a02222d1a2fb00f9a0cdb… I will double check that part of the code, since I don't think a lock get is necessary. It only updates a value inside a node, inside the list of nodes, but not changes the list links at all. (this in another PR) For now I propose to disable this aggressive_redetection mechanism by default. Since it delays the SIP routing logic when no rtpengines available (and in some cases lead to crashes in transaction module). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3992 -- Commit Summary -- * rtpengine: disable aggressive redetection by default -- File Changes -- M src/modules/rtpengine/config.c (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3992.patch https://github.com/kamailio/kamailio/pull/3992.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3992(a)github.com>

3 4

git:master:b1aae565: rtpengine: disable aggressive redetection by default (#3992)
by GitHub 21 Oct '24

21 Oct '24

Module: kamailio Branch: master Commit: b1aae5658e84453ce5849a627832efbbb6c20117 URL: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: GitHub <noreply(a)github.com> Date: 2024-10-21T08:53:39-04:00 rtpengine: disable aggressive redetection by default (#3992) --- Modified: src/modules/rtpengine/config.c Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Patch: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… --- diff --git a/src/modules/rtpengine/config.c b/src/modules/rtpengine/config.c index 7ea1a0d68e9..ba2bd5c5747 100644 --- a/src/modules/rtpengine/config.c +++ b/src/modules/rtpengine/config.c @@ -32,7 +32,7 @@ struct cfg_group_rtpengine default_rtpengine_cfg = { 60, /* default disable timeout in seconds */ - 1, /* default aggressive_redetection enabled */ + 0, /* default aggressive_redetection disabled */ 1000, /* default wait timeout in milliseconds */ MAX_RTPP_TRIED_NODES, 5, /* rtprengine retries */ }; diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index f898aa32979..b443fbc0290 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -219,20 +219,20 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) </para> <para> <emphasis> - Default value is <quote>1</quote> (enabled). + Default value is <quote>0</quote> (disabled). </emphasis> </para> <para> Can be set at runtime, e.g.: <programlisting> - $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 0 + $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 1 </programlisting> </para> <example> <title>Set <varname>aggressive_redetection</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... </programlisting> </example>

1 0

[kamailio/kamailio] app_python3s: initial support for free-threading Python (PR #3987)
by space88man 19 Oct '24

19 Oct '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description - Enable `app_python3s` module to build with Free Threading CPython builds - Can be gated with `-DKSR_PYTHON_DISABLE_FREETHREADING` - If Python is a non-free-threading build this change has no effect You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3987 -- Commit Summary -- * app_python3s: initial support for free-threading Python -- File Changes -- M src/modules/app_python3s/apy3s_kemi.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3987.patch https://github.com/kamailio/kamailio/pull/3987.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3987 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3987(a)github.com>

3 17

git:master:62b4ee4a: app_python3s: refactor GIL and thread state handling
by S-P Chan 19 Oct '24

19 Oct '24

Module: kamailio Branch: master Commit: 62b4ee4a0d0b62b35c8bdf67e5daf9cbe9a28499 URL: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: refactor GIL and thread state handling * incorrectly using PyGILState_XXX functions; these functions are for threads launched by Python unaware libraries * if the KEMI script used Python threading these threads would be blocked after returning to the Kamailio event loop as the GIL was not released Fix is to use Py_BLOCK|UNBLOCK_THREADS macros --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Patch: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c…

1 0

git:master:c81b2b33: app_python3s: initial support for free-threading Python
by S-P Chan 19 Oct '24

19 Oct '24

Module: kamailio Branch: master Commit: c81b2b3383c5900aba83672da024c812d8e6d89d URL: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: initial support for free-threading Python * build the modules as free-threading compatible if free-threading Python is detected * can be gated by -DKSR_PYTHON_DISABLE_FREETHREADING --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… Patch: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index 38c67b9e1d5..0fb7879ef6b 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -746,6 +746,11 @@ static PyObject *init_KSR(void) /* special sub-modules - x.modf() can have variable number of params */ _sr_apy_ksr_modules_list[m] = PyModule_Create(&KSR_x_moduledef); PyModule_AddObject(_sr_apy_ksr_module, "x", _sr_apy_ksr_modules_list[m]); +#if defined(Py_GIL_DISABLED) && !defined(KSR_PYTHON_DISABLE_FREETHREADING) +#warning Python Free Threading build + PyUnstable_Module_SetGIL(_sr_apy_ksr_module, Py_MOD_GIL_NOT_USED); + PyUnstable_Module_SetGIL(_sr_apy_ksr_modules_list[m], Py_MOD_GIL_NOT_USED); +#endif Py_INCREF(_sr_apy_ksr_modules_list[m]); m++; @@ -781,6 +786,11 @@ static PyObject *init_KSR(void) mmodule->m_size = -1; _sr_apy_ksr_modules_list[m] = PyModule_Create(mmodule); +#if defined(Py_GIL_DISABLED) && !defined(KSR_PYTHON_DISABLE_FREETHREADING) +#warning Python Free Threading build + PyUnstable_Module_SetGIL( + _sr_apy_ksr_modules_list[m], Py_MOD_GIL_NOT_USED); +#endif PyModule_AddObject(_sr_apy_ksr_module, emods[k].kexp[0].mname.s, _sr_apy_ksr_modules_list[m]); Py_INCREF(_sr_apy_ksr_modules_list[m]);

1 0

git:master:c7f89e81: core: parser sdp - check if body is enough for rtpmap
by Daniel-Constantin Mierla 17 Oct '24

17 Oct '24

Module: kamailio Branch: master Commit: c7f89e81504c425a83f3423bc4b4d9d1a8a48909 URL: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-17T08:21:43+02:00 core: parser sdp - check if body is enough for rtpmap --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… Patch: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 079a9992402..a74f78abb84 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -152,7 +152,8 @@ int extract_rtpmap(str *body, str *rtpmap_payload, str *rtpmap_encoding, int len; if(strncasecmp(body->s, "a=rtpmap:", 9) != 0) { - /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", body->len, body->s); */ + /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", + * body->len, body->s); */ return -1; }

1 0

[kamailio/kamailio] Usrloc keepalive: Not sending OPTIONS to UDP endpoints- 5.8.0 and 5.8.1 (Issue #3844)
by Luke Escudé 17 Oct '24

17 Oct '24

Running compiled Kamailio 5.8.1 (previously 5.8.0) on Debian 12 64-bit We're seeing an issue with UDP endpoints (this issue does not happen with TCP and TLS) where usrloc will not send OPTIONS packet keepalives. Here are all of our usrloc parameters: modparam("usrloc", "db_mode", 0) modparam("usrloc", "ka_domain", "SIPDOMAIN") #-- SIPDOMAIN is a fqdn modparam("usrloc", "ka_from", "sip:proxy-ping@SIPDOMAIN") modparam("usrloc", "ka_mode", 1) modparam("usrloc", "timer_interval", 20) #-- How often to qualify endpoints and clean mem tables? modparam("usrloc", "timer_procs", 4) modparam("usrloc", "ka_randomize", 10) modparam("usrloc", "use_domain", 0) modparam("usrloc", "server_id_filter", 1) modparam("usrloc", "ka_filter", 0) modparam("usrloc", "ka_timeout", 60) #-- How quickly to expire a contact if it does not reply to keepalive? modparam("usrloc", "matching_mode", 0) modparam("usrloc", "handle_lost_tcp", 1) modparam("usrloc", "close_expired_tcp", 1) modparam("usrloc", "desc_time_order", 1) modparam("usrloc", "hash_size", 14) It seems usrloc is not actually using timer_interval at all for UDP devices. However, it does seem to be sending OPTIONS every 20 seconds on TCP/TLS. (this is confirmed via packet capture on a SIP phone). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3844 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3844(a)github.com>

4 9

git:master:1869a9d9: modules: readme files regenerated - async ... [skip ci]
by Kamailio Dev 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: 1869a9d9a7639c6e18e0cc14779a0078ae165917 URL: https://github.com/kamailio/kamailio/commit/1869a9d9a7639c6e18e0cc14779a007… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-16T12:01:11+02:00 modules: readme files regenerated - async ... [skip ci] --- Modified: src/modules/async/README Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/1869a9d9a7639c6e18e0cc14779a007… Patch: https://github.com/kamailio/kamailio/commit/1869a9d9a7639c6e18e0cc14779a007…

1 0

git:master:cce29af4: async: docs updates for async_sleep()
by Daniel-Constantin Mierla 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: cce29af41120cf30c4c22979e772d1ca666408c6 URL: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-16T11:46:37+02:00 async: docs updates for async_sleep() --- Modified: src/modules/async/doc/async_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c… Patch: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c… --- diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml index 027cea11ed7..152c6be5db7 100644 --- a/src/modules/async/doc/async_admin.xml +++ b/src/modules/async/doc/async_admin.xml @@ -234,8 +234,11 @@ route[RESUME] { </title> <para> Simulate a sleep of 'seconds' and then continue the processing of SIP - request with the next action. In case of internal errors, the function - returns false. + request with the next action. Note that the processing continues till + the last action in the current route block. Consider using async_route() + instead if you want to control better what is executed after the wait + time. Beacuse the execution is resumed in another process, do not use + private memory variables before and after the async sleep. </para> <para> The sleep parameter represent the number of seconds to suspend the @@ -243,6 +246,9 @@ route[RESUME] { a static integer or a variable holding an integer. </para> <para> + In case of internal errors, the function returns false. + </para> + <para> This function can be used from REQUEST_ROUTE. </para> <example> @@ -262,15 +268,13 @@ exit; <function moreinfo="none">async_ms_sleep(milliseconds)</function> </title> <para> - Simulate a sleep of 'milliseconds' and then continue the processing of SIP - request with the next action. In case of internal errors, the function - returns false. - This function works only if the ms_timer parameter has a value greater than 0. + Similar to async_sleep(), but with a 'milliseconds' parameter. This + function works only if the ms_timer parameter has a value greater than 0. </para> <para> The sleep parameter represent the number of milliseconds to suspend the - processing of SIP request. Maximum value is 30000 (30 sec). The parameter can be - a static integer or a variable holding an integer. + processing of SIP request. Maximum value is 30000 (30 sec). The parameter + can be a static integer or a variable holding an integer. </para> <para> This function can be used from REQUEST_ROUTE.

1 0

git:master:e18c5203: tls: docs - relocate overview notes to Important Notes section
by Daniel-Constantin Mierla 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: e18c52030e202716df9f5e8e953c19fb4a9c65e2 URL: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-16T11:05:04+02:00 tls: docs - relocate overview notes to Important Notes section --- Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f… Patch: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f… --- diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml index 3a0416fed61..53397e2d50a 100644 --- a/src/modules/tls/doc/tls.xml +++ b/src/modules/tls/doc/tls.xml @@ -60,27 +60,9 @@ must be added to the Kamailio config file. </para> <para> - IMPORTANT: the tls module must be loaded before any other &kamailio; module - that uses libssl (OpenSSL library). A safe option is to have the tls module - loaded first (be in the first "loadmodule" in &kamailio;.cfg). - </para> - <para> - IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" - has to be set, see the Core Cookbook for possible values. - </para> - <para> - IMPORTANT: using this module compiled with newer versions of libssl - (e.g., v1.1+) may require &kamailio; to be started with - <emphasis>--atexit=no</emphasis> command line parameters to avoid - calling C atexit callbacks inside the process ending during - daemonize procedure as well as during shut down, which can lead - to crashes because it destroys and then accesses shared memory. For - example, such case has been reported for Ubuntu 20.04 or RedHat 8. - </para> - <para> - Note: with some particular combination of OS, openssl and mysql-client - libraries, there were reports of random crashes, in such case try to set - the db_mysql module parameter opt_ssl_mode to 1. + Read the "Important Notes" section because it has relevant information + about configuring properly the module for various libssl versions, + components and operating systems. </para> </section> <section id="tls.quick_start"> @@ -134,7 +116,7 @@ request_route { <para> The TLS module needs some special options enabled when compiling Kamailio. These options are enabled by default, however in case - you're using a modified Kamailio version or Makefile, make sure + you are using a modified Kamailio version or Makefile, make sure that you enable -DUSE_TLS and -DTLS_HOOKS (or compile with make TLS_HOOKS=1 which will take care of both options). </para> @@ -188,6 +170,29 @@ request_route { </itemizedlist> The bug reports can be viewed at <ulink url="http://rt.openssl.org/">http://rt.openssl.org/</ulink>. </para> + <para> + Note 1: the tls module must be loaded before any other &kamailio; module + that uses libssl (OpenSSL library). A safe option is to have the tls module + loaded first (be in the first "loadmodule" in &kamailio;.cfg). + </para> + <para> + Note 2: for libssl v3.x, the core parameter "tls_threads_mode" + has to be set, see the Core Cookbook for possible values. + </para> + <para> + Note 3: using this module compiled with newer versions of libssl + (e.g., v1.1+) may require &kamailio; to be started with + <emphasis>--atexit=no</emphasis> command line parameters to avoid + calling C atexit callbacks inside the process ending during + daemonize procedure as well as during shut down, which can lead + to crashes because it destroys and then accesses shared memory. For + example, such case has been reported for Ubuntu 20.04 or RedHat 8. + </para> + <para> + Note 4: with some particular combination of OS, openssl and mysql-client + libraries, there were reports of random crashes, in such case try to set + the db_mysql module parameter opt_ssl_mode to 1. + </para> </section>

1 0

git:master:a5b1099c: core: socket info - skip ipv6 link local on interface discovery
by Daniel-Constantin Mierla 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: a5b1099c9061551a0b31db8ef88efb2e376b290c URL: https://github.com/kamailio/kamailio/commit/a5b1099c9061551a0b31db8ef88efb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-16T10:49:16+02:00 core: socket info - skip ipv6 link local on interface discovery --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/a5b1099c9061551a0b31db8ef88efb2… Patch: https://github.com/kamailio/kamailio/commit/a5b1099c9061551a0b31db8ef88efb2… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 4142ab17dce..80f72870e79 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1763,6 +1763,16 @@ int add_interfaces(char *if_name, int family, unsigned short port, continue; if(family && family != ifa->ifa_addr->sa_family) continue; + if(ifa->ifa_addr->sa_family == AF_INET6) { + struct sockaddr_in6 *caddr = (struct sockaddr_in6 *)ifa->ifa_addr; + if((sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP) + && IN6_IS_ADDR_LINKLOCAL(&(caddr->sin6_addr))) { + LM_DBG("skipping iface [%s] fam: [%x] flg: [%lx] addr: [%s]\n", + ifa->ifa_name, ifa->ifa_addr->sa_family, + (unsigned long)ifa->ifa_flags, tmp); + continue; + } + } sockaddr2ip_addr(&addr, (struct sockaddr *)ifa->ifa_addr); tmp = ip_addr2a(&addr); if(ifa->ifa_flags & IFF_LOOPBACK)

1 0

[kamailio/kamailio] Pcv issue 3929 pr (PR #3994)
by Eik Rentzow 16 Oct '24

16 Oct '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3929 #### Description The handling of the buffer and pointers in the siputils/chargingvector.c module was inconsistent and led to writing directly in the sip msg buffer, which resulted in the destruction of the SIP message as reported in the issue. During the testing more cases showed up where the PCV handling became ugly and inconsistent, especially in fault scenarios. Therefore more parts have been rewritten to account for those scenarios. The $pcv(status) pseudo-variable has been added to reflect the state of the P-Charging-Vector in the message, whether it was parsed, had errors (no body or no icid-value), has been deleted or if none is there. The sip_p_charging_vector() function returns a status value of what it has done, or if it was a no-op call. A present PCV can only be generated once by the module, either after an explicit deletion or by a forced replacement. After that the call returns with no-op. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3994 -- Commit Summary -- * siputils: bug fix for sip_p_charging_vector * siputils/doc: updated pcv documentation [skip ci] -- File Changes -- M src/modules/siputils/chargingvector.c (346) M src/modules/siputils/doc/siputils.xml (8) M src/modules/siputils/doc/siputils_admin.xml (50) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3994.patch https://github.com/kamailio/kamailio/pull/3994.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3994 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3994(a)github.com>

2 17

[kamailio/kamailio] sdpops: cannot parse big SDP (Issue #4000)
by sergey-safarov 15 Oct '24

15 Oct '24

### Description Cannot be parsed `$sdp(body)` when received to big SDP. ### Troubleshooting #### Reproduction To reproduce you can use minimal config like ``` listen=tcp:127.0.0.1:5060 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "sdpops.so" route{ xerr("SDP: TEST $tu\n"); xerr("SDP: $sdp(body)\n"); drop; } ``` And send an INVITE message like in the attached file. In my case, the SDP size is 8710. [invite.txt](https://github.com/user-attachments/files/17376561/invite.txt) #### Log Messages ``` ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 12(143998) DEBUG: <core> [core/ip_addr.c:585]: print_ip(): tcpconn_new: new tcp connection: 2605:84c0:48:4:0:0:0:8 12(143998) DEBUG: <core> [core/tcp_main.c:1246]: tcpconn_new(): on port 42350, type 2, socket 24 12(143998) DEBUG: <core> [core/tcp_main.c:1649]: tcpconn_add(): hashes: 1814:1060:1991, 1 12(143998) DEBUG: <core> [core/io_wait.h:369]: io_watch_add(): processing io_watch_add(0xa15ab0, 24, 2, 0xffffa9cbe2c0) - fd_no=20 12(143998) DEBUG: <core> [core/io_wait.h:600]: io_watch_del(): DBG: io_watch_del (0xa15ab0, 24, -1, 0x0) fd_no=21 called 12(143998) DEBUG: <core> [core/tcp_main.c:4705]: handle_tcpconn_ev(): sending to child, events 1 12(143998) DEBUG: <core> [core/tcp_main.c:4380]: send2child(): selected tcp worker idx:0 proc:4 pid:143990 for activity on [tcp:[2605:84c0:48:4::8]:5060], 0xffffa9cbe2c0 4(143990) DEBUG: <core> [core/tcp_read.c:1776]: handle_io(): received n=8 con=0xffffa9cbe2c0, fd=4 4(143990) DEBUG: <core> [core/tcp_read.c:1576]: tcp_read_req(): content-length=8710 4(143990) DEBUG: <core> [core/parser/parse_fline.c:247]: parse_first_line(): first line type 1 (request) flags 1 4(143990) DEBUG: <core> [core/parser/msg_parser.c:721]: parse_msg(): SIP Request: 4(143990) DEBUG: <core> [core/parser/msg_parser.c:723]: parse_msg(): method: <INVITE> 4(143990) DEBUG: <core> [core/parser/msg_parser.c:725]: parse_msg(): uri: <sip:nga911@[2605:84c0:48:7:9e89:e249:e025:8c89]:11000;ippbx-uuid=SEC11-a46040a-b46040a-1-3GhFlTbDLgyj> 4(143990) DEBUG: <core> [core/parser/msg_parser.c:727]: parse_msg(): version: <SIP/2.0> 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Route] type 9 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Route] type 9 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Via] type 1 4(143990) DEBUG: <core> [core/parser/parse_via.c:1312]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK8676587>; state=16 4(143990) DEBUG: <core> [core/parser/parse_via.c:2663]: parse_via(): end of header reached, state=5 4(143990) DEBUG: <core> [core/parser/msg_parser.c:591]: parse_headers(): Via found, flags=2 4(143990) DEBUG: <core> [core/parser/msg_parser.c:593]: parse_headers(): this is the first via 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Max-Forwards] type 8 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [To] type 3 4(143990) DEBUG: <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=1FZy0t0K3Xj9j 4(143990) DEBUG: <core> [core/parser/parse_addr_spec.c:904]: parse_addr_spec(): end of header reached, state=29 4(143990) DEBUG: <core> [core/parser/msg_parser.c:173]: get_hdr_field(): <To> [63]; uri=[sip:3015329632@[2605:97c0:2051:1033:a::1]] 4(143990) DEBUG: <core> [core/parser/msg_parser.c:176]: get_hdr_field(): to body (43)[<sip:3015329632@[2605:97c0:2051:1033:a::1]>], to tag (13)[1FZy0t0K3Xj9j] 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [From] type 4 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Call-ID] type 6 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [CSeq] type 5 4(143990) DEBUG: <core> [core/parser/msg_parser.c:154]: get_hdr_field(): cseq <CSeq>: <5911> <INVITE> 4(143990) DEBUG: <core> [core/receive.c:397]: _receive_msg(): --- received sip message - request - call-id: [b20ca364-3000-4938-bf40-5c4bf5f0e67c] - cseq: [5911 INVITE] 4(143990) DEBUG: <core> [core/receive.c:263]: ksr_evrt_pre_routing(): event route core:pre-routing not defined 4(143990) DEBUG: <core> [core/receive.c:479]: _receive_msg(): preparing to run routing scripts... 4(143990) ERROR: <script>: SDP: TEST sip:3015329632@[2605:97c0:2051:1033:a::1] 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Contact] type 7 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Content-Type] type 11 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Session-Expires] type 35 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Allow] type 21 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Supported] type 17 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [User-Agent] type 28 4(143990) DEBUG: <core> [core/parser/parse_hname2.c:314]: parse_sip_header_name(): parsed header name [Content-Length] type 12 4(143990) DEBUG: <core> [core/parser/msg_parser.c:187]: get_hdr_field(): content_length=8710 4(143990) DEBUG: <core> [core/parser/msg_parser.c:91]: get_hdr_field(): found end of header 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:692]: extract_sess_version(): oline(44): >o=- 5916726231183296689 3 IN IP4 127.0.0.1 < 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:721]: extract_sess_version(): end 1: >3< 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:572]: extract_mediaip(): located IP address [127.0.0.1] in `o=' field 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:572]: extract_mediaip(): located IP address [192.168.223.25] in `c=' field 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-ufrag:Wg73 a=...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-pwd:2trzRy7dCN...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=fingerprint:sha-25...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=setup:actpass a=m...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=mid:0 a=extmap:1 ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:1 urn:ietf:...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:2 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:3 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:4 urn:ietf:...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=msid:2bf68e42-fd5b...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-mux a=rtcp-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-rsize a=rtpm...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ssrc:954653789 cna...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ssrc:954653789 msi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:572]: extract_mediaip(): located IP address [192.168.223.25] in `c=' field 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-ufrag:Wg73 a=...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-pwd:2trzRy7dCN...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=fingerprint:sha-25...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=setup:actpass a=m...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=mid:1 a=extmap:14...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:14 urn:ietf...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:2 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:13 urn:3gpp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:3 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:5 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:6 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:7 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:8 http://ww...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:4 urn:ietf:...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:10 urn:ietf...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=extmap:11 urn:ietf...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=msid:2bf68e42-fd5b...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-mux a=rtcp-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-rsize a=rtpm...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:106 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:106 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:106 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:107 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:107 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:107 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:102 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:102 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:102 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:102 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:102 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:127 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:127 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:127 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:127 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:127 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:126 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:126 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:126 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:126 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:126 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:125 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:125 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:125 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:125 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:125 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:39 goog-re...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:39 transpo...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:39 ccm fir...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:39 nack a...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:39 nack pl...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:45 goog-re...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:45 transpo...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:45 ccm fir...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:45 nack a...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:45 nack pl...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:98 goog-re...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:98 transpo...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:98 ccm fir...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:98 nack a...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:98 nack pl...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:100 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:100 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:100 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:100 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:100 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:112 goog-r...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:112 transp...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:112 ccm fi...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:112 nack ...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=rtcp-fb:112 nack p...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ssrc:1414828106 cn...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ssrc:1414828106 ms...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp_helpr_funcs.c:572]: extract_mediaip(): located IP address [0.0.0.0] in `c=' field 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-ufrag:sO9Y a=...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=ice-pwd:3YgpASnwan...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=fingerprint:sha-25...' 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=setup:actpass a=m...' ...'43990) DEBUG: <core> [core/parser/sdp/sdp.c:656]: parse_sdp_session(): ignoring unknown type in a= line: `a=mid:2 4(143990) DEBUG: sdpops [sdpops_mod.c:2088]: pv_get_sdp(): param->pvn.u.isname.name.n=0 4(143990) ERROR: <core> [core/pvapi.c:1431]: pv_printf_mode(): no more space for spec value - printed:5 token:8710 buffer:4096 4(143990) ERROR: <core> [core/pvapi.c:1444]: pv_printf_mode(): buffer overflow -- increase the buffer size... 4(143990) DEBUG: <core> [core/receive.c:537]: _receive_msg(): request-route executed in: 1104 usec 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(143990) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(143990) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(143990) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(143990) DEBUG: <core> [core/receive.c:640]: _receive_msg(): cleaning up 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:941]: free_sdp(): _sdp = 0xffffadfa58e8 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:944]: free_sdp(): sdp = 0xffffadfa6eb0 4(143990) DEBUG: <core> [core/parser/sdp/sdp.c:946]: free_sdp(): session = 0xffffadfa6f60 4(143990) DEBUG: <core> [core/io_wait.h:369]: io_watch_add(): processing io_watch_add(0xa818a0, 4, 2, 0xffffa9cbe2c0) - fd_no=1 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4000 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4000(a)github.com>

2 2

git:master:39f20537: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 15 Oct '24

15 Oct '24

Module: kamailio Branch: master Commit: 39f2053769ea45b1d75a0b73f7f7c14397546b4e URL: https://github.com/kamailio/kamailio/commit/39f2053769ea45b1d75a0b73f7f7c14… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-15T14:01:10+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/39f2053769ea45b1d75a0b73f7f7c14… Patch: https://github.com/kamailio/kamailio/commit/39f2053769ea45b1d75a0b73f7f7c14… --- diff --git a/src/modules/siputils/README b/src/modules/siputils/README index f66c7391747..2ab1d707a9a 100644 --- a/src/modules/siputils/README +++ b/src/modules/siputils/README @@ -36,6 +36,8 @@ Bogdan-Andrei Iancu Gabriel Vasile +Eik Rentzow + Copyright �� 2008, 2005, 2003 1&1 Internet AG, FhG Fokus, Voice Sistem SRL __________________________________________________________________ @@ -116,6 +118,7 @@ Gabriel Vasile 5.3. $pcv(genaddr) 5.4. $pcv(orig) 5.5. $pcv(term) + 5.6. $pcv(status) List of Examples @@ -249,6 +252,7 @@ Chapter 1. Admin Guide 5.3. $pcv(genaddr) 5.4. $pcv(orig) 5.5. $pcv(term) + 5.6. $pcv(status) 1. Overview @@ -1089,7 +1093,19 @@ if(is_first_hop("1")) { ... } 4.37. sip_p_charging_vector(flags) Manage the P-Charging-Vector header (RFC7315). The flags can be: 'r' - - remove; 'g' - generate; 'f' - force (remove + generate). + remove; 'g' - generate; 'f' - force (remove + generate). Once a new PCV + has been generated by 'g' or 'f' the PCV cannot be changed again. The + icid-generated-at parameter of a generated PCV will be set to the + sending interface.IP address. + + Return Codes: + * 1 - Nothing was done. + * (2 - intentionally left out) + * 3 - P-Charging-Vector header has been newly generated. + * 4 - P-Charging-Vector header has been deleted. + * 5 - P-Charging-Vector header has been replaced or inserted after + deletion. + * negative - Any error occured during execution. This function can be used from ANY_ROUTE. @@ -1227,6 +1243,7 @@ if (sip_parse_headers()) { 5.3. $pcv(genaddr) 5.4. $pcv(orig) 5.5. $pcv(term) + 5.6. $pcv(status) 5.1. $pcv(all) @@ -1247,3 +1264,16 @@ if (sip_parse_headers()) { 5.5. $pcv(term) term-ioi field (see RFC7315 section 5.6) + +5.6. $pcv(status) + + Returns whether the PCV header was successfully parsed, deleted, newly + generated or other. + * 0 - No P-Charging-Vector header in message. + * 1 - P-Charging-Vector header in message and parsed successfully. + * 2 - P-Charging-Vector is present, but has no valid icid-value + parameter. + * 3 - P-Charging-Vector header has been newly generated or replaced. + * 4 - P-Charging-Vector header has been deleted. + + Negative values indicate an internal error during the parsing process.

1 0

git:master:d7c8bc5c: siputils: bug fix for sip_p_charging_vector
by Victor Seva 15 Oct '24

15 Oct '24

Module: kamailio Branch: master Commit: d7c8bc5c58f672004894733d0e6d2a7cb00efe7a URL: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7… Author: Eik Rentzow <rentzow(a)gmx.de> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-15T13:48:35+02:00 siputils: bug fix for sip_p_charging_vector - Bug fix for #3929 and further improvements. - New buffer usage for P-Charging-Vector handling. - Added $pcv(status) pseudo-var. - Added return values for sip_p_charging_vector(). - Much improved error case handling. - Use send interface for icid-genearted-at: The icid-generated-at parameter should carry the ip adress of the egress interface and not of the interface where the message was received. This is in accordance with other SBC solutions. --- Modified: src/modules/siputils/chargingvector.c --- Diff: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7… Patch: https://github.com/kamailio/kamailio/commit/d7c8bc5c58f672004894733d0e6d2a7…

1 0

git:master:05a30ed5: siputils/doc: updated pcv documentation [skip ci]
by Victor Seva 15 Oct '24

15 Oct '24

Module: kamailio Branch: master Commit: 05a30ed53fc5657a2d86e1c1bdb9277571a8d17e URL: https://github.com/kamailio/kamailio/commit/05a30ed53fc5657a2d86e1c1bdb9277… Author: Eik Rentzow <rentzow(a)gmx.de> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-15T13:48:35+02:00 siputils/doc: updated pcv documentation [skip ci] - Updated documentation to reflect the changes to the $pcv pseudo-var and the sip_p_charging_vector() function. --- Modified: src/modules/siputils/doc/siputils.xml Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/05a30ed53fc5657a2d86e1c1bdb9277… Patch: https://github.com/kamailio/kamailio/commit/05a30ed53fc5657a2d86e1c1bdb9277… --- diff --git a/src/modules/siputils/doc/siputils.xml b/src/modules/siputils/doc/siputils.xml index d537da1fb15..08d3d8fb4d9 100644 --- a/src/modules/siputils/doc/siputils.xml +++ b/src/modules/siputils/doc/siputils.xml @@ -95,6 +95,14 @@ </address> </editor> + <editor> + <firstname>Eik</firstname> + <surname>Rentzow</surname> + <address> + <email>rentzow(a)gmx.de</email> + </address> + </editor> + </authorgroup> <copyright> <year>2008</year> diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index 6850f53e9bf..e92472284df 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -1279,7 +1279,33 @@ if(is_first_hop("1")) { ... } <para> Manage the P-Charging-Vector header (RFC7315). The flags can be: 'r' - remove; 'g' - generate; 'f' - force (remove + generate). + Once a new PCV has been generated by 'g' or 'f' the PCV cannot be changed again. + The icid-generated-at parameter of a generated PCV will be set to + the sending interface.IP address. </para> + <para> + Return Codes: + </para> + <itemizedlist> + <listitem><para> + <emphasis>1</emphasis> - Nothing was done. + </para></listitem> + <listitem><para> + <emphasis>(2</emphasis> - <emphasis>intentionally left out)</emphasis> + </para></listitem> + <listitem><para> + <emphasis>3</emphasis> - P-Charging-Vector header has been newly generated. + </para></listitem> + <listitem><para> + <emphasis>4</emphasis> - P-Charging-Vector header has been deleted. + </para></listitem> + <listitem><para> + <emphasis>5</emphasis> - P-Charging-Vector header has been replaced or inserted after deletion. + </para></listitem> + <listitem><para> + <emphasis>negative</emphasis> - Any error occured during execution. + </para></listitem> + </itemizedlist> <para> This function can be used from ANY_ROUTE. </para> @@ -1532,6 +1558,32 @@ if (sip_parse_headers()) { term-ioi field (see RFC7315 section 5.6) </para> </section> + <section id="siputils.v.pcv_status"> + <title><varname>$pcv(status)</varname></title> + <para> + Returns whether the PCV header was successfully parsed, deleted, + newly generated or other. + <itemizedlist> + <listitem><para> + <emphasis>0</emphasis> - No P-Charging-Vector header in message. + </para></listitem> + <listitem><para> + <emphasis>1</emphasis> - P-Charging-Vector header in message and parsed successfully. + </para></listitem> + <listitem><para> + <emphasis>2</emphasis> - P-Charging-Vector is present, but has no valid + <emphasis>icid-value</emphasis> parameter. + </para></listitem> + <listitem><para> + <emphasis>3</emphasis> - P-Charging-Vector header has been newly generated or replaced. + </para></listitem> + <listitem><para> + <emphasis>4</emphasis> - P-Charging-Vector header has been deleted. + </para></listitem> + </itemizedlist> + Negative values indicate an internal error during the parsing process. + </para> + </section> </section> </chapter>

1 0

git:master:e802f918: core: parser sdp - check field length when extracting the value
by Daniel-Constantin Mierla 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: e802f9187383feb7fdd96c4ded44fda403da4535 URL: https://github.com/kamailio/kamailio/commit/e802f9187383feb7fdd96c4ded44fda… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-11T12:37:08+02:00 core: parser sdp - check field length when extracting the value --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/e802f9187383feb7fdd96c4ded44fda… Patch: https://github.com/kamailio/kamailio/commit/e802f9187383feb7fdd96c4ded44fda… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a5186fb4428..079a9992402 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -346,13 +346,16 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) } -/* generic method for attribute extraction +/* generic method for attribute value extraction * field must has format "a=attrname:" */ int extract_field(str *body, str *value, str field) { - if(strncmp(body->s, field.s, field.len < body->len ? field.len : body->len) - != 0) { - /*LM_DBG("We are not pointing to an %.* attribute =>`%.*s'\n", field.len, field.s, body->len, body->s); */ + if(body->len < field.len) { + return -1; + } + if(strncmp(body->s, field.s, field.len) != 0) { + /* LM_DBG("We are not pointing to an %.* attribute =>`%.*s'\n", + field.len, field.s, body->len, body->s); */ return -1; }

1 0

git:master:d4bbde61: core: parse sdp - check for body limit on mixed content
by Daniel-Constantin Mierla 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: d4bbde619bbf808edebb31e131b3783ba2a4b34d URL: https://github.com/kamailio/kamailio/commit/d4bbde619bbf808edebb31e131b3783… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-11T12:00:53+02:00 core: parse sdp - check for body limit on mixed content --- Modified: src/core/parser/sdp/sdp.c --- Diff: https://github.com/kamailio/kamailio/commit/d4bbde619bbf808edebb31e131b3783… Patch: https://github.com/kamailio/kamailio/commit/d4bbde619bbf808edebb31e131b3783… --- diff --git a/src/core/parser/sdp/sdp.c b/src/core/parser/sdp/sdp.c index 52e967a3db9..06fc411f502 100644 --- a/src/core/parser/sdp/sdp.c +++ b/src/core/parser/sdp/sdp.c @@ -810,9 +810,11 @@ static int parse_mixed_content(str *mixed_body, str delimiter, sdp_info_t *_sdp) } /* end of while */ /* and now we need to parse the content */ if(start_parsing) { - while(('\n' == *rest) || ('\r' == *rest) || ('\t' == *rest) - || (' ' == *rest)) + while((rest < bodylimit) + && (('\n' == *rest) || ('\r' == *rest) || ('\t' == *rest) + || (' ' == *rest))) { rest++; /* Skip any whitespace */ + } _sdp->raw_sdp.s = rest; _sdp->raw_sdp.len = d2p - rest; /* LM_DBG("we need to check session %d: <%.*s>\n", session_num, _sdp.raw_sdp.len, _sdp.raw_sdp.s); */

1 0

git:master:fc481706: core: parser sdp - check for length of sendrecv attribute
by Daniel-Constantin Mierla 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: fc4817064f81ef9a82b1b1468b1b8a4ae352c1f2 URL: https://github.com/kamailio/kamailio/commit/fc4817064f81ef9a82b1b1468b1b8a4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-11T11:41:02+02:00 core: parser sdp - check for length of sendrecv attribute --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/fc4817064f81ef9a82b1b1468b1b8a4… Patch: https://github.com/kamailio/kamailio/commit/fc4817064f81ef9a82b1b1468b1b8a4… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a5dffd9c398..a5186fb4428 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -447,6 +447,9 @@ int extract_sendrecv_mode(str *body, str *sendrecv_mode, int *is_on_hold) { char *cp1; + if(body->len < 10) { + return -1; + } cp1 = body->s; if(!((strncasecmp(cp1, "a=sendrecv", 10) == 0) || (strncasecmp(cp1, "a=recvonly", 10) == 0))) {

1 0

Inconsistencies in SIP Parsing with Embedded tel: URIs and Documentation Issues
by Xenofon Karamanos 11 Oct '24

11 Oct '24

Hi all, I’d like to bring up some development topics related to the SIP parsing logic, specifically when handling sip: with embedded tel URIs scheme. The current behaviour, particularly when user=phone is present, is leading to some inconsistencies and potential confusion, and I believe it might require some refactoring or documentation updates. Current Parsing Behavior: When a tel: URI is embedded in a sip: scheme (e.g., user=phone is present), the parser currently copies the URI parsed parameters to sip_params, then splits the user part (like 123;param=value;param2=value2) into user and all the rest tel parameters to params. This behaviour is only triggered when the global phone2tel configuration option is enabled (which is the default). Issues: 1. Inconsistent Handling of URI Parameters There’s no consistency across modules on whether they use sip_params or params to get the URI parameters. While most modules correctly use sip_params, others use params. Normally, this works fine because sip_params and params hold the same data when user=phone is not present or phone2tel is disabled. However, when user=phone is present and phone2tel is enabled, params may be empty, leading to unexpected behavior in modules relying on it. For example, the following modules are using params and many others: * dmqnode.c (line 204)<https://github.com/kamailio/kamailio/blob/ba6ab04e06b0dfd66874749e0cb1225f2…> * notification_peer.c (line 432)<https://github.com/kamailio/kamailio/blob/ba6ab04e06b0dfd66874749e0cb1225f2…> While some may handle the differences between sip_params and params, not all of them do. 2. Unclear Intention of the phone2tel Global Parameter The current parser code is quite old, and it’s unclear what the original intention behind the phone2tel global parameter was. As far as I understand, the sip: scheme can handle tel: URIs, and this is the most widely accepted specification. The role of phone2tel seems to blur the lines between the two schemes, leading to unexpected transformations. Example of Unexpected Behavior: Consider the following header: P-Asserted-Identity: Display <sip:+1234;pname=pval@domain;user=phone>;tag=1234 If we apply the {tobody.user} transformation, the expected output should be the user part of the URI. Based on the RFC, we expected the transformation to return +1234;pname=pval. However, due to the phone2tel global configuration parameter, the parser treats it as a tel: scheme and returns only +1234. This behavior seems to be influenced by how the global parameter forces the parser to handle the URI. Proposal: To resolve these issues, I suggest the following: 1. Refactor Parameter Handling: Introduce a more explicit separation of tel_params and sip_params, and ensure all modules use the correct set of parameters based on the context. This would help enforce consistency across the codebase. 2. Update Documentation: Provide clear documentation regarding the behavior of phone2tel and how it impacts URI parsing. In particular, the transformation documentation should reflect the expected behavior depending on whether the URI is treated as sip: or tel:. 3. Review and Fix Modules: We should audit the modules that currently rely on params and ensure they are using sip_params where appropriate, especially in cases where user=phone could be present. Any guidance or feedback on these points would be greatly appreciated. If you’ve encountered any related bugs or discovered other edge cases, please let me know so we can address them. Best regards, Xenofon

2 1

git:master:95fb987b: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: 95fb987bd402432996c616c6582ef430e9441d93 URL: https://github.com/kamailio/kamailio/commit/95fb987bd402432996c616c6582ef43… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-11T11:16:09+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/95fb987bd402432996c616c6582ef43… Patch: https://github.com/kamailio/kamailio/commit/95fb987bd402432996c616c6582ef43…

1 0

git:master:337c06b6: siptrace: docs for data_mode param
by Daniel-Constantin Mierla 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: 337c06b6b43606536f1d37ebfd6e4240aab9cf5a URL: https://github.com/kamailio/kamailio/commit/337c06b6b43606536f1d37ebfd6e424… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-11T11:02:35+02:00 siptrace: docs for data_mode param --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/337c06b6b43606536f1d37ebfd6e424… Patch: https://github.com/kamailio/kamailio/commit/337c06b6b43606536f1d37ebfd6e424… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 2bf7c1e9163..b7fd0bf3c74 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -610,6 +610,26 @@ modparam("siptrace", "trace_mode", 1) ... modparam("siptrace", "trace_mode", 3) ... +</programlisting> + </example> + </section> + <section id="siptrace.p.data_mode"> + <title><varname>data_mode</varname> (integer)</title> + <para> + A set of flags to control what data is used for the trace. + If flag 1 (value 1) is set, then advertised address (when set) + is used instead of socket bind address. + </para> + <para> + Default value is <emphasis>0</emphasis>. + </para> + <example> + <title>Set <varname>data_mode</varname> + parameter</title> + <programlisting format="linespecific"> +... +modparam("siptrace", "data_mode", 1) +... </programlisting> </example> </section> @@ -949,4 +969,3 @@ onsend_route { </section> </chapter> -

1 0

git:master:9d8432f3: siptrace: added parameter data_mode
by Daniel-Constantin Mierla 11 Oct '24

11 Oct '24

Module: kamailio Branch: master Commit: 9d8432f3ffb1f9d07874452e23140be21e75c530 URL: https://github.com/kamailio/kamailio/commit/9d8432f3ffb1f9d07874452e23140be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-11T10:57:05+02:00 siptrace: added parameter data_mode - control if bind address of advertised address are used --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/9d8432f3ffb1f9d07874452e23140be… Patch: https://github.com/kamailio/kamailio/commit/9d8432f3ffb1f9d07874452e23140be… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 31609821682..257cf0eb335 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -133,6 +133,9 @@ int siptrace_net_data_sent(sr_event_param_t *evp); static int _siptrace_init_mode = 0; static int _siptrace_mode = 0; +#define SIPTRACE_DATA_MODE_ADVADDR 1 /* use advertised address */ +static int _siptrace_data_mode = 0; + static str db_url = str_init(DEFAULT_DB_URL); static str siptrace_table = str_init("sip_trace"); @@ -272,6 +275,7 @@ static param_export_t params[] = { {"trace_db_mode", INT_PARAM, &trace_db_mode}, {"trace_init_mode", PARAM_INT, &_siptrace_init_mode}, {"trace_mode", PARAM_INT, &_siptrace_mode}, + {"data_mode", PARAM_INT, &_siptrace_data_mode}, {"evcb_msg", PARAM_STR, &_siptrace_evcb_msg}, {"trace_dialog_ack", PARAM_INT, &trace_dialog_ack}, {"trace_dialog_spiral", PARAM_INT, &trace_dialog_spiral}, @@ -2308,7 +2312,8 @@ int siptrace_net_data_recv(sr_event_param_t *evp) sto.fromip.s = sto.fromip_buff; } - if(nd->rcv->bind_address != NULL + if((_siptrace_data_mode & SIPTRACE_DATA_MODE_ADVADDR) + && nd->rcv->bind_address != NULL && nd->rcv->bind_address->useinfo.sock_str.len > 0 && (nd->rcv->bind_address->useinfo.sock_str.len < SIPTRACE_ADDR_MAX - 1)) { @@ -2449,7 +2454,8 @@ int siptrace_net_data_sent(sr_event_param_t *evp) sto.fromip.len = SIPTRACE_ANYADDR_LEN; proto = PROTO_UDP; } else { - if(new_dst.send_sock->useinfo.sock_str.len > 0) { + if((_siptrace_data_mode & SIPTRACE_DATA_MODE_ADVADDR) + && new_dst.send_sock->useinfo.sock_str.len > 0) { vsock = new_dst.send_sock->useinfo.sock_str; } else { vsock = new_dst.send_sock->sock_str;

1 0

git:master:9fb15e2e: siptrace: use advertise address if set for trace mode 1 callbacks
by Daniel-Constantin Mierla 09 Oct '24

09 Oct '24

Module: kamailio Branch: master Commit: 9fb15e2ef93a0d606fa4c6d695a2f13a4b0a8031 URL: https://github.com/kamailio/kamailio/commit/9fb15e2ef93a0d606fa4c6d695a2f13… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-09T19:51:27+02:00 siptrace: use advertise address if set for trace mode 1 callbacks --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/9fb15e2ef93a0d606fa4c6d695a2f13… Patch: https://github.com/kamailio/kamailio/commit/9fb15e2ef93a0d606fa4c6d695a2f13… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 208718adf0d..31609821682 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -2308,15 +2308,26 @@ int siptrace_net_data_recv(sr_event_param_t *evp) sto.fromip.s = sto.fromip_buff; } - sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", - siptrace_proto_name(nd->rcv->proto), ip_addr2strz(&nd->rcv->dst_ip), - (int)nd->rcv->dst_port); - if(sto.toip.len < 0 || sto.toip.len >= SIPTRACE_ADDR_MAX) { - LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len); - sto.toip.s = SIPTRACE_ANYADDR; - sto.toip.len = SIPTRACE_ANYADDR_LEN; - } else { + if(nd->rcv->bind_address != NULL + && nd->rcv->bind_address->useinfo.sock_str.len > 0 + && (nd->rcv->bind_address->useinfo.sock_str.len + < SIPTRACE_ADDR_MAX - 1)) { + sto.toip.len = nd->rcv->bind_address->useinfo.sock_str.len; + memcpy(sto.toip_buff, nd->rcv->bind_address->useinfo.sock_str.s, + sto.toip.len); + sto.toip_buff[sto.toip.len] = '\0'; sto.toip.s = sto.toip_buff; + } else { + sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(nd->rcv->proto), + ip_addr2strz(&nd->rcv->dst_ip), (int)nd->rcv->dst_port); + if(sto.toip.len < 0 || sto.toip.len >= SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len); + sto.toip.s = SIPTRACE_ANYADDR; + sto.toip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.toip.s = sto.toip_buff; + } } sto.dir = "in"; @@ -2408,6 +2419,7 @@ int siptrace_net_data_sent(sr_event_param_t *evp) int proto; int evcb_ret; int ret = 0; + str vsock; if(evp->data == 0) return -1; @@ -2437,14 +2449,18 @@ int siptrace_net_data_sent(sr_event_param_t *evp) sto.fromip.len = SIPTRACE_ANYADDR_LEN; proto = PROTO_UDP; } else { - if(new_dst.send_sock->sock_str.len >= SIPTRACE_ADDR_MAX - 1) { - LM_ERR("socket string is too large: %d\n", - new_dst.send_sock->sock_str.len); + if(new_dst.send_sock->useinfo.sock_str.len > 0) { + vsock = new_dst.send_sock->useinfo.sock_str; + } else { + vsock = new_dst.send_sock->sock_str; + } + if(vsock.len >= SIPTRACE_ADDR_MAX - 1) { + LM_ERR("socket string is too large: %d\n", vsock.len); return -1; } - strncpy(sto.fromip_buff, new_dst.send_sock->sock_str.s, - new_dst.send_sock->sock_str.len); - sto.fromip.len = new_dst.send_sock->sock_str.len; + memcpy(sto.fromip_buff, vsock.s, vsock.len); + sto.fromip.len = vsock.len; + sto.fromip_buff[sto.fromip.len] = '\0'; proto = new_dst.send_sock->proto; } sto.fromip.s = sto.fromip_buff;

1 0

[kamailio/kamailio] goto error on cursor error (PR #3996)
by Adnan Elezovic 09 Oct '24

09 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description If the query failed, the result set should not be parsed and used. This results in an empty result set which will most likely lead to unwanted behavior. Background: While troubleshooting, we detected that domain.reload actually replaces domains with an empty result set if mongodb connectivity fails. ``` DEBUG: db_mongodb [mongodb_dbase.c:849]: db_mongodb_store_result(): An error occurred: No suitable servers found (`serverSelectionTryOnce` set): [connection timeout calling ismaster on 'pdb-iop1-wrmg-2:27017'] [connection timeout calling ismaster on 'pdb-iop1-wrmg-1:27017'] DEBUG: domain [domain.c:365]: reload_tables(): number of rows in domain_attrs table: 0 DEBUG: <core> [db_res.c:79]: db_free_columns(): freeing 0 columns DEBUG: <core> [db_res.c:138]: db_free_result(): freeing result set at 0x7fb0c9811848 DEBUG: db_mongodb [mongodb_dbase.c:973]: db_mongodb_query(): query to collection [domains] DEBUG: db_mongodb [mongodb_dbase.c:1007]: db_mongodb_query(): query filter: { } DEBUG: db_mongodb [mongodb_dbase.c:1043]: db_mongodb_query(): columns filter: { "projection" : { "domain" : 1, "did" : 1 } } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3996 -- Commit Summary -- * mongodb: fix cursor error resulting empty result set -- File Changes -- M src/modules/db_mongodb/mongodb_dbase.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3996.patch https://github.com/kamailio/kamailio/pull/3996.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3996 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3996(a)github.com>

2 2

git:master:afebe6b2: mongodb: fix cursor error resulting empty result set
by Victor Seva 09 Oct '24

09 Oct '24

Module: kamailio Branch: master Commit: afebe6b2e597755ae37fd37bdf011fbb2fbbf8fe URL: https://github.com/kamailio/kamailio/commit/afebe6b2e597755ae37fd37bdf011fb… Author: aelezovic <adnan.elezovic(a)infobip.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-09T16:15:31+02:00 mongodb: fix cursor error resulting empty result set --- Modified: src/modules/db_mongodb/mongodb_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/afebe6b2e597755ae37fd37bdf011fb… Patch: https://github.com/kamailio/kamailio/commit/afebe6b2e597755ae37fd37bdf011fb… --- diff --git a/src/modules/db_mongodb/mongodb_dbase.c b/src/modules/db_mongodb/mongodb_dbase.c index 6b51962c8b8..a57324d4afa 100644 --- a/src/modules/db_mongodb/mongodb_dbase.c +++ b/src/modules/db_mongodb/mongodb_dbase.c @@ -838,6 +838,7 @@ static int db_mongodb_store_result(const db1_con_t *_h, db1_res_t **_r) || !mongoc_cursor_next(mgres->cursor, &itdoc) || !itdoc) { if(mongoc_cursor_error(mgres->cursor, &error)) { LM_DBG("An error occurred: %s\n", error.message); + goto error; } else { LM_DBG("no result from mongodb\n"); }

1 0

git:master:2737bb19: http_async_client: fix warning deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 2737bb19a363be7c0d67749b75f11c7e9d2d09f3 URL: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T15:03:55+02:00 http_async_client: fix warning deprecated-non-prototype > Warning: ./http_multi.h:64:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C23, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > 64 | int init_http_multi(); > | ^ > http_multi.c:403:5: note: conflicting prototype is here > 403 | int init_http_multi(struct event_base *evbase, struct http_m_global *wg) > | ^ > 1 warning generated. --- Modified: src/modules/http_async_client/http_multi.h --- Diff: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7… Patch: https://github.com/kamailio/kamailio/commit/2737bb19a363be7c0d67749b75f11c7… --- diff --git a/src/modules/http_async_client/http_multi.h b/src/modules/http_async_client/http_multi.h index 0f35a722306..8e3676b3ed1 100644 --- a/src/modules/http_async_client/http_multi.h +++ b/src/modules/http_async_client/http_multi.h @@ -61,7 +61,7 @@ extern int curl_verbose; extern int curl_follow_redirect; void set_curl_mem_callbacks(void); -int init_http_multi(); +int init_http_multi(struct event_base *evbase, struct http_m_global *wg); int multi_timer_cb(CURLM *multi, long timeout_ms, struct http_m_global *g); void timer_cb(int fd, short kind, void *userp); int sock_cb(CURL *e, curl_socket_t s, int what, void *cbp, void *sockp);

1 0

git:master:ee052fd0: sms: fix warning and remove old logic
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: ee052fd0a7e7dc703a186a01926a8e64c635d636 URL: https://github.com/kamailio/kamailio/commit/ee052fd0a7e7dc703a186a01926a8e6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T14:58:40+02:00 sms: fix warning and remove old logic > Warning: libsms_getsms.c:107:25: warning: implicit conversion from 'int' to 'char' changes value from 183 to -73 [-Wconstant-conversion] > 107 | ascii[charcounter] = 183; > | ~ ^~~ > 1 warning generated. --- Modified: src/modules/sms/libsms_getsms.c --- Diff: https://github.com/kamailio/kamailio/commit/ee052fd0a7e7dc703a186a01926a8e6… Patch: https://github.com/kamailio/kamailio/commit/ee052fd0a7e7dc703a186a01926a8e6… --- diff --git a/src/modules/sms/libsms_getsms.c b/src/modules/sms/libsms_getsms.c index 4181560490e..1909c78bcc9 100644 --- a/src/modules/sms/libsms_getsms.c +++ b/src/modules/sms/libsms_getsms.c @@ -101,12 +101,7 @@ static int pdu2ascii(char *pdu, char *ascii) bitposition++; c = (c >> 1) & 127; /* The shift fills with 1, but I want 0 */ } - if(/*cs_convert*/ 1) - ascii[charcounter] = sms2ascii(c); - else if(c == 0) - ascii[charcounter] = 183; - else - ascii[charcounter] = c; + ascii[charcounter] = sms2ascii(c); } ascii[count] = 0; return count;

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev