- all secfilter functions are exported to KEMI
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
* All secfilter functions are exported to KEMI
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3946
-- Commit Summary --
* secfilter: export all functions to KEMI
-- File Changes --
M src/modules/secfilter/secfilter.c (103)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3946.patchhttps://github.com/kamailio/kamailio/pull/3946.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3946
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3946(a)github.com>
### Description
I am using Kemi with the app_python3 module. I was getting what appeared to be random TypeError exceptions thrown within the Kamailio app_python3 module. I later discovered that this only happened when calling a Kamailio function that exceeded the duration specified in the latency_limit_action core parameter. Also, the line printed in the logs displayed Null values in the 'file:' and 'func:' fields.
#### Reproduction
To reproduce the issue:
1. You must be using Kemi with the app_python3 module, with the cfgengine set to python.
2. Set the following in your kamailio.cfg file:
```
latency_log=2
latency_limit_action=100000
```
3. Run a Kemi function call that takes more time than the latency_limi_action set above. You may have to lower it if your computer is a fast runner. Here is my suggested code:
```
jsreload = dict()
jsreload["jsonrpc"] = "2.0"
jsreload["method"] = "tls.reload"
jsreload["id"] = 1
KSR.jsonrpcs.exec(json.dumps(jsreload))
```
4. Use python version 3.11
#### Log Messages
45(324) INFO: app_python3 [apy_kemi.c:377]: sr_apy_kemi_exec_func(): alert - action KSR.jsonrpcs.exec(...) took too long [752946 ms] (file:(null) func:(null) line:491)
45(324) ERROR: app_python3 [python_support.c:167]: python_handle_exception(): apy_exec: ksr_rtimer_dodebug(rtimer): Unhandled exception in the Python code:
TypeError: expected bytes, str found
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/etc/kamailio/kamailio.py", line 491, in ksr_rtimer_dodebug
KSR.jsonrpcs.exec(json.dumps(jsreload))
SystemError: <built-in function exec> returned a result with an exception set
### Possible Solutions
The solution is to replace PyBytes_AsString(..) calls with calls to PyUnicode_AsUTF8(..) in the PY_VERSION_HEX >= 0x030B0000 block of apy_kemi.c. The PyBytes_AsString expects a Bytes value but reeives a Unicode value instead, thus causing the TypeError exception. Enclosed is a patch file with the fix implemented:
[kamailio-5.8.2.patch.txt](https://github.com/user-attachments/files/1619573…
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
# kamailio -v
version: kamailio 5.8.2 (x86_64/linux) 3fa5f4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 3fa5f4
compiled on 09:58:55 Jul 12 2024 with gcc 12.2.0
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
# uname -a
Linux xxxxxxxxxxxxxxxxxxx 5.10.0-30-amd64 #1 SMP Debian 5.10.218-1 (2024-06-01) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3915
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3915(a)github.com>
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue # 3915
#### Description
<!-- Describe your changes in detail -->
Replace PyBytes_AsString(..) calls with calls to PyUnicode_AsUTF8(..) in the PY_VERSION_HEX >= 0x030B0000 block of apy_kemi.c. The PyBytes_AsString expects a Bytes value but receives a Unicode value instead, thus causing the TypeError exception.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3959
-- Commit Summary --
* app_python3: Fixes Kemi TypeError thrown when latency_limit_action is exceeded.
-- File Changes --
M src/modules/app_python3/apy_kemi.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3959.patchhttps://github.com/kamailio/kamailio/pull/3959.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3959
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3959(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Start up failed with error " waiting for child one too long"
execute start up command, and suddenly failed.
`
sudo /usr/local/sbin/kamailio -m 128 -M 8 -E -e -dd -f /usr/local/etc/kamailio/kamailio.cfg
`
### Troubleshooting
#### Reproduction
Maybe the problem of my env.
#### Debugging Data
#### Log Messages
the log:
0(2749) INFO: <core> [core/sctp_core.c:74]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module
Listening on
udp: 192.168.5.167:5061
Aliases:
udp: 192.168.5.167:5061
0(2749) INFO: <core> [core/tcp_main.c:5218]: init_tcp(): using epoll_lt as the io watch method (auto detected)
0(2751) INFO: rr [../outbound/api.h:53]: ob_load_api(): unable to import bind_ob - maybe module is not loaded
0(2751) INFO: rr [rr_mod.c:185]: mod_init(): outbound module not available
0(2751) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
0(2751) INFO: auth [auth_mod.c:342]: mod_init(): qop set, but nonce-count (nonce_count) support disabled
0(2751) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
0(2751) WARNING: tls [tls_mod.c:364]: mod_init(): tls support is disabled (set enable_tls=1 in the config to enable it)
0(2751) INFO: <core> [main.c:3233]: main(): processes (at least): 24 - shm size: 134217728 - pkg size: 8388608
0(2751) INFO: <core> [core/udp_server.c:163]: probe_max_receive_buffer(): SO_RCVBUF is initially 16777216 for fd 9
0(2751) INFO: <core> [core/udp_server.c:233]: probe_max_receive_buffer(): SO_RCVBUF is finally 16777216 on fd 9
0(2751) INFO: <core> [core/udp_server.c:264]: probe_max_send_buffer(): SO_SNDBUF is initially 16777216 for fd 9
0(2751) INFO: <core> [core/udp_server.c:334]: probe_max_send_buffer(): SO_SNDBUF is finally 16777216 on fd 9
1(2754) WARNING: db_mysql [km_my_con.c:187]: db_mysql_new_connection(): opt_ssl_ca option not supported by mysql version (value (null)) - ignoring
1(2754) NOTICE: ndb_redis [redis_client.c:257]: redisc_init(): Connecting to 10.20.80.33:6380
0(2751) ERROR: <core> [main.c:1825]: main_loop(): waiting for child one too long - wait time: 1000000
1(2754) INFO: <core> [main.c:888]: sig_usr(): signal 15 received
0(2751) INFO: snmpstats [snmpstats.c:399]: mod_destroy(): The SNMPStats module got the kill signal
0(2751) INFO: snmpstats [snmpstats.c:403]: mod_destroy(): Shutting down the AgentX Sub-Agent!
0(2751) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized`
what does that mean? ` 0(2751) ERROR: <core> [main.c:1825]: main_loop(): waiting for child one too long - wait time: 1000000`
How can I solve that?
#### SIP Traffic
### Possible Solutions
### Additional Information
* **Operating System**:
`
LSB Version: :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description: CentOS Linux release 7.9.2009 (Core)
Release: 7.9.2009
Codename: Core
`
Kamailio-5.8.2
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3960
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3960(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Noticed that kafka.so is not included in any existing deb packages. However, librdkafka-dev is generally available library in debian.
I've added deb package build for "kamailio-kafka-modules", for bullseye, bookworm and sid. Maybe this can be backported to at least 5.8 stable branch?!
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3952
-- Commit Summary --
* kafka: build .deb package with kafka.so
-- File Changes --
M pkg/kamailio/deb/bookworm/control (17)
M pkg/kamailio/deb/bookworm/rules (1)
M pkg/kamailio/deb/bullseye/control (17)
M pkg/kamailio/deb/bullseye/rules (1)
M pkg/kamailio/deb/sid/control (17)
M pkg/kamailio/deb/sid/rules (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3952.patchhttps://github.com/kamailio/kamailio/pull/3952.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3952
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3952(a)github.com>
Module: kamailio
Branch: master
Commit: 7a390e0a297278b6d319c78f74b8179ed6a25c3b
URL: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2024-08-27T12:46:11+02:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
Patch: https://github.com/kamailio/kamailio/commit/7a390e0a297278b6d319c78f74b8179…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 35c2e5d0ec0..dbeff43d002 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -1631,8 +1631,12 @@ modparam("tm", "e2e_cancel_hop_by_hop", 0)
3.44. headers_mode (int)
- Control if headers from incoming CANCEL should be propagated to
- hop-by-hop generated CANCEL.
+ Control how headers from incoming CANCEL should be propagated to
+ hop-by-hop generated CANCEL. If bit (flag) 1 is set (value 1),
+ propagate the headers that are not branch specific (e.g., From, To). If
+ bit (flag) 2 is set, in case processing ends in stateless forwarding by
+ tm, forward CANCEL with a single Via header (the one added by
+ Kamailio).
Default value: 0 (do not propagate).
Module: kamailio
Branch: master
Commit: b67bb7a1bc4c710d33e242cea94a192297660c75
URL: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-08-27T12:42:13+02:00
tm: docs for header_mode flag 2
---
Modified: src/modules/tm/doc/params.xml
---
Diff: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
Patch: https://github.com/kamailio/kamailio/commit/b67bb7a1bc4c710d33e242cea94a192…
---
diff --git a/src/modules/tm/doc/params.xml b/src/modules/tm/doc/params.xml
index ffef9a4eec3..e8a16182e42 100644
--- a/src/modules/tm/doc/params.xml
+++ b/src/modules/tm/doc/params.xml
@@ -1377,8 +1377,12 @@ modparam("tm", "e2e_cancel_hop_by_hop", 0)
<section id="headers_mode">
<title><varname>headers_mode</varname> (int)</title>
<para>
- Control if headers from incoming CANCEL should be propagated to
- hop-by-hop generated CANCEL.
+ Control how headers from incoming CANCEL should be propagated to
+ hop-by-hop generated CANCEL. If bit (flag) 1 is set (value 1),
+ propagate the headers that are not branch specific (e.g., From, To).
+ If bit (flag) 2 is set, in case processing ends in stateless
+ forwarding by tm, forward CANCEL with a single Via header (the one
+ added by &kamailio;).
</para>
<para>
Default value: 0 (do not propagate).
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
We are seeing a lot of error messages like:
> ERROR: <null> pua [pua_db.c:895]: get_record_puadb(): Too many rows found (2)
After some investigation I come up with a couple of fixes:
* pua: improve the query to support caller|callee with same pres_id (same dialog)
* pua_dialoginfo: support uuid to generate pres_id to improve randomness
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3955
-- Commit Summary --
* pua: get_record_puadb() add pres_uri to the query
* pua_dialoginfo: use_uuid parameter
* pua_dialoginfo: document use_uuid parameter
-- File Changes --
M src/modules/pua/pua_db.c (18)
M src/modules/pua/pua_db.h (5)
M src/modules/pua/send_publish.c (5)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo.xml (11)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml (25)
M src/modules/pua_dialoginfo/pua_dialoginfo.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3955.patchhttps://github.com/kamailio/kamailio/pull/3955.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3955
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3955(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
#### Description
This is the first step to merge the functionality that is already used in Sipwise kamailio flavor
* module parameters [from|to]_uri_avp to store
* sca_handle_subscribe() support [from|to_uri] parameters
Add the possibility of define what is the URI value for To and/or From instead of the values from the SIP message
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3930
-- Commit Summary --
* sca: add support custom [to|from]_uri
-- File Changes --
M src/modules/sca/doc/sca.xml (58)
M src/modules/sca/doc/sca_admin.xml (52)
M src/modules/sca/sca.c (115)
M src/modules/sca/sca.h (5)
M src/modules/sca/sca_call_info.c (190)
M src/modules/sca/sca_subscribe.c (96)
M src/modules/sca/sca_subscribe.h (5)
M src/modules/sca/sca_util.c (184)
M src/modules/sca/sca_util.h (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3930.patchhttps://github.com/kamailio/kamailio/pull/3930.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3930
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3930(a)github.com>
Module: kamailio
Branch: master
Commit: c9a9fcd4429de8c7da7cb3ab9cebe077edea91bf
URL: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2024-08-27T09:37:56+02:00
sca: add support custom [to|from]_uri
* module parameters [from|to]_uri_avp to store
* sca_handle_subscribe() support [from|to_uri] parameters
Add the possibility of define what is the URI value
for To and/or From instead of the values from the SIP message
---
Modified: src/modules/sca/doc/sca.xml
Modified: src/modules/sca/doc/sca_admin.xml
Modified: src/modules/sca/sca.c
Modified: src/modules/sca/sca.h
Modified: src/modules/sca/sca_call_info.c
Modified: src/modules/sca/sca_subscribe.c
Modified: src/modules/sca/sca_subscribe.h
Modified: src/modules/sca/sca_util.c
Modified: src/modules/sca/sca_util.h
---
Diff: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
Patch: https://github.com/kamailio/kamailio/commit/c9a9fcd4429de8c7da7cb3ab9cebe07…
fix(pua_reginfo): free pkg memory after getting the XML attribute
- free the memory from the state XML attribute that was returned and immediately used in another function call without freeing leaving one small mem leak;
- add comments but keep the dead code regarding parsed but unused attrs.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3953
-- Commit Summary --
* fix(pua_reginfo): free pkg memory after getting the content of each XML attribute
-- File Changes --
M src/modules/pua_reginfo/notify.c (86)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3953.patchhttps://github.com/kamailio/kamailio/pull/3953.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3953
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3953(a)github.com>