- sr-dev - kamailio.org

git:master:16006cd9: dialplan: exported dp_match() and dp_replace() to kemi framework
by Daniel-Constantin Mierla 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: 16006cd97c4eccb4b45c459a8585649450bf5772 URL: https://github.com/kamailio/kamailio/commit/16006cd97c4eccb4b45c459a8585649… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-26T12:18:15+02:00 dialplan: exported dp_match() and dp_replace() to kemi framework --- Modified: src/modules/dialplan/dialplan.c --- Diff: https://github.com/kamailio/kamailio/commit/16006cd97c4eccb4b45c459a8585649… Patch: https://github.com/kamailio/kamailio/commit/16006cd97c4eccb4b45c459a8585649… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index 5a94e8c21c..85dc0d652b 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -55,6 +55,7 @@ #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" #include "../../core/lvalue.h" +#include "../../core/kemi.h" #include "dialplan.h" #include "dp_db.h" @@ -256,17 +257,21 @@ static int dp_update(struct sip_msg * msg, pv_spec_t * dest, memset(&val, 0, sizeof(pv_value_t)); val.flags = PV_VAL_STR; - no_change = (dest==NULL) || (dest->type == PVT_NONE) || (!repl->s) || (!repl->len); + no_change = (dest==NULL) || (dest->type == PVT_NONE) + || (!repl->s) || (!repl->len); if (no_change) goto set_attr_pvar; val.rs = *repl; - if(dest->setf(msg, &dest->pvp, (int)EQ_T, &val)<0) - { - LM_ERR("setting dst pseudo-variable failed\n"); - return -1; + if(dest->setf) { + if(dest->setf(msg, &dest->pvp, (int)EQ_T, &val)<0) { + LM_ERR("setting dst pseudo-variable failed\n"); + return -1; + } + } else { + LM_WARN("target variable is read only - skipping setting its value\n"); } if(dp_append_branch!=0) { @@ -506,6 +511,19 @@ static int w_dp_replace(sip_msg_t* msg, char* pid, char* psrc, char* pdst) return dp_replace_helper(msg, dpid, &src, pvd); } +static int ki_dp_replace(sip_msg_t* msg, int dpid, str* src, str* dst) +{ + pv_spec_t *pvd = NULL; + + pvd = pv_cache_get(dst); + if(pvd==NULL) { + LM_ERR("cannot get pv spec for [%.*s]\n", dst->len, dst->s); + return -1; + } + + return dp_replace_helper(msg, dpid, src, pvd); +} + static int w_dp_match(sip_msg_t* msg, char* pid, char* psrc) { int dpid = 1; @@ -523,6 +541,11 @@ static int w_dp_match(sip_msg_t* msg, char* pid, char* psrc) return dp_replace_helper(msg, dpid, &src, NULL); } +static int ki_dp_match(sip_msg_t* msg, int dpid, str* src) +{ + return dp_replace_helper(msg, dpid, src, NULL); +} + int dp_replace_fixup(void** param, int param_no) { if (param_no == 1) @@ -776,3 +799,32 @@ static int dialplan_init_rpc(void) } return 0; } + +/** + * + */ +/* clang-format off */ +static sr_kemi_t sr_kemi_dialplan_exports[] = { + { str_init("dialplan"), str_init("dp_match"), + SR_KEMIP_INT, ki_dp_match, + { SR_KEMIP_INT, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("dialplan"), str_init("dp_replace"), + SR_KEMIP_INT, ki_dp_replace, + { SR_KEMIP_INT, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } +}; +/* clang-format on */ + +/** + * + */ +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + sr_kemi_modules_add(sr_kemi_dialplan_exports); + return 0; +} \ No newline at end of file

1 0

git:master:35219960: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: 35219960e2960359d4d8b17f1566da611554a152 URL: https://github.com/kamailio/kamailio/commit/35219960e2960359d4d8b17f1566da6… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-26T12:01:25+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/35219960e2960359d4d8b17f1566da6… Patch: https://github.com/kamailio/kamailio/commit/35219960e2960359d4d8b17f1566da6… --- diff --git a/src/modules/pv/README b/src/modules/pv/README index 428a27c958..9c082b8fc2 100644 --- a/src/modules/pv/README +++ b/src/modules/pv/README @@ -74,7 +74,7 @@ Daniel-Constantin Mierla 1.15. pv_xavp_to_var() usage 1.16. pv_xavp_to_var() usage 1.17. pv.shvSet usage - 1.18. pv.shvSet usage + 1.18. pv.shvGet usage Chapter 1. Admin Guide @@ -461,7 +461,7 @@ $ kamcmd pv.shvSet debug int 3 If no name is given, all shared variables are listed. - Example 1.18. pv.shvSet usage + Example 1.18. pv.shvGet usage ... $ kamcmd pv.shvGet debug ...

1 0

git:master:e9509170: pv: added section ids in the docs
by Daniel-Constantin Mierla 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: e95091700857ff96d9e7c6508104a5ba5d5487ff URL: https://github.com/kamailio/kamailio/commit/e95091700857ff96d9e7c6508104a5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-26T12:00:38+02:00 pv: added section ids in the docs --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e95091700857ff96d9e7c6508104a5b… Patch: https://github.com/kamailio/kamailio/commit/e95091700857ff96d9e7c6508104a5b…

1 0

git:master:ab1d3a33: modules: readme files regenerated - dialplan ... [skip ci]
by Kamailio Dev 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: ab1d3a3302760713722b2fd3ef41615c53b597dc URL: https://github.com/kamailio/kamailio/commit/ab1d3a3302760713722b2fd3ef41615… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-26T09:31:32+02:00 modules: readme files regenerated - dialplan ... [skip ci] --- Modified: src/modules/dialplan/README --- Diff: https://github.com/kamailio/kamailio/commit/ab1d3a3302760713722b2fd3ef41615… Patch: https://github.com/kamailio/kamailio/commit/ab1d3a3302760713722b2fd3ef41615… --- diff --git a/src/modules/dialplan/README b/src/modules/dialplan/README index f073564db1..cde96e214d 100644 --- a/src/modules/dialplan/README +++ b/src/modules/dialplan/README @@ -54,6 +54,7 @@ Luis Martin 5.11. attrs_pvar (string) 5.12. fetch_rows (int) 5.13. match_dynamic (int) + 5.14. append_branch (int) 6. Functions @@ -87,11 +88,12 @@ Luis Martin 1.11. Set attrs_pvar parameter 1.12. Set fetch_rows parameter 1.13. Set match_dynamic parameter - 1.14. dp_replace usage - 1.15. dp_match usage - 1.16. dp_translate usage + 1.14. Set append_branch parameter + 1.15. dp_replace usage + 1.16. dp_match usage 1.17. dp_translate usage - 1.18. Example of rules + 1.18. dp_translate usage + 1.19. Example of rules Chapter 1. Admin Guide @@ -120,6 +122,7 @@ Chapter 1. Admin Guide 5.11. attrs_pvar (string) 5.12. fetch_rows (int) 5.13. match_dynamic (int) + 5.14. append_branch (int) 6. Functions @@ -219,6 +222,7 @@ Chapter 1. Admin Guide 5.11. attrs_pvar (string) 5.12. fetch_rows (int) 5.13. match_dynamic (int) + 5.14. append_branch (int) 5.1. db_url (string) @@ -375,6 +379,20 @@ modparam("dialplan", "fetch_rows", 4000) modparam("dialplan", "match_dynamic", 1) ... +5.14. append_branch (int) + + If set to 1, the module appends a new outgoing branch when request URI + (r-uri) or its user part are changed by dp_translate() or dp_replace() + inside a failure_route block. Set it to 0 if the branch should not be + added. + + Default value is “1”. + + Example 1.14. Set append_branch parameter +... +modparam("dialplan", "append_branch", 0) +... + 6. Functions 6.1. dp_replace(dpid, inval, outvar) @@ -405,7 +423,7 @@ modparam("dialplan", "match_dynamic", 1) This function can be used from ANY_ROUTE. - Example 1.14. dp_replace usage + Example 1.15. dp_replace usage ... dp_replace("240", "$rU", "$var(newru)"); xlog("'$rU' was translated to '$var(newru)'\n"); @@ -432,7 +450,7 @@ dp_replace("240", "+49$rU", "$var(newval)"); This function can be used from ANY_ROUTE. - Example 1.15. dp_match usage + Example 1.16. dp_match usage ... dp_match("240", "+49$rU"); xlog("the attributes associated with '+49$rU' are '$var(attrs)'\n"); @@ -473,13 +491,13 @@ xlog("the attributes associated with '+49$rU' are '$var(attrs)'\n"); This function can be used from ANY_ROUTE. - Example 1.16. dp_translate usage + Example 1.17. dp_translate usage ... dp_translate("240", "$ruri.user/$avp(s:dest)"); xlog("translated to var $avp(s:dest) \n"); ... - Example 1.17. dp_translate usage + Example 1.18. dp_translate usage ... $avp(s:src) = $ruri.user; dp_translate("$var(x)", "$avp(s:src)/$var(y)"); @@ -549,7 +567,7 @@ xlog("translated to var $var(y) \n"); Some sample records from a dialplan table are presented in the next figure. - Example 1.18. Example of rules + Example 1.19. Example of rules ... dpid: 1 pr: 1

1 0

git:master:55a98c84: dialplan: documentation for append_branch parameter
by Daniel-Constantin Mierla 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: 55a98c84112fcca6b917f1efd08e8da3b1a9ab69 URL: https://github.com/kamailio/kamailio/commit/55a98c84112fcca6b917f1efd08e8da… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-26T09:24:59+02:00 dialplan: documentation for append_branch parameter --- Modified: src/modules/dialplan/doc/dialplan_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/55a98c84112fcca6b917f1efd08e8da… Patch: https://github.com/kamailio/kamailio/commit/55a98c84112fcca6b917f1efd08e8da… --- diff --git a/src/modules/dialplan/doc/dialplan_admin.xml b/src/modules/dialplan/doc/dialplan_admin.xml index 073c2b24ed..e9f8f95350 100644 --- a/src/modules/dialplan/doc/dialplan_admin.xml +++ b/src/modules/dialplan/doc/dialplan_admin.xml @@ -387,6 +387,28 @@ modparam("dialplan", "match_dynamic", 1) </programlisting> </example> </section> + <section id="dialplan.p.append_branch"> + <title><varname>append_branch</varname> (int)</title> + <para> + If set to 1, the module appends a new outgoing branch when request + URI (r-uri) or its user part are changed by dp_translate() or + dp_replace() inside a failure_route block. Set it to 0 if the branch + should not be added. + </para> + <para> + <emphasis> + Default value is <quote>1</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>append_branch</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialplan", "append_branch", 0) +... + </programlisting> + </example> + </section> </section>

1 0

git:master:4c65f4fd: dialplan: added append_branch parameter
by Daniel-Constantin Mierla 26 Jul '17

26 Jul '17

Module: kamailio Branch: master Commit: 4c65f4fd4dda697e48757e06e011fa58a2000588 URL: https://github.com/kamailio/kamailio/commit/4c65f4fd4dda697e48757e06e011fa5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-26T09:21:59+02:00 dialplan: added append_branch parameter - control if the module should do append branch if r-uri or r-uri username are changed inside failure route - default value is 1 (append branch - preserves compatibility) --- Modified: src/modules/dialplan/dialplan.c --- Diff: https://github.com/kamailio/kamailio/commit/4c65f4fd4dda697e48757e06e011fa5… Patch: https://github.com/kamailio/kamailio/commit/4c65f4fd4dda697e48757e06e011fa5… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index cac1df7124..5a94e8c21c 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -85,6 +85,7 @@ dp_param_p default_par2 = NULL; int dp_fetch_rows = 1000; int dp_match_dynamic = 0; +int dp_append_branch = 1; static param_export_t mod_params[]={ { "db_url", PARAM_STR, &dp_db_url }, @@ -100,6 +101,7 @@ static param_export_t mod_params[]={ { "attrs_pvar", PARAM_STR, &attr_pvar_s }, { "fetch_rows", PARAM_INT, &dp_fetch_rows }, { "match_dynamic", PARAM_INT, &dp_match_dynamic }, + { "append_branch", PARAM_INT, &dp_append_branch }, {0,0,0} }; @@ -267,11 +269,15 @@ static int dp_update(struct sip_msg * msg, pv_spec_t * dest, return -1; } - if(is_route_type(FAILURE_ROUTE) - && (dest->type==PVT_RURI || dest->type==PVT_RURI_USERNAME)) { - if (append_branch(msg, 0, 0, 0, Q_UNSPECIFIED, 0, 0, 0, 0, 0, 0) != 1) { - LM_ERR("append_branch action failed\n"); - return -1; + if(dp_append_branch!=0) { + if(is_route_type(FAILURE_ROUTE) + && (dest->type == PVT_RURI + || dest->type == PVT_RURI_USERNAME)) { + if(append_branch(msg, 0, 0, 0, Q_UNSPECIFIED, 0, 0, 0, 0, 0, 0) + != 1) { + LM_ERR("append branch action failed\n"); + return -1; + } } }

1 0

git:master:b59771bb: modules/sipcapture: fix (param_export_t).name typo
by Mikko Lehto 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: b59771bb81bbe240b98113252df10377a75da700 URL: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df1037… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-07-25T15:54:57+03:00 modules/sipcapture: fix (param_export_t).name typo --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df1037… Patch: https://github.com/kamailio/kamailio/commit/b59771bb81bbe240b98113252df1037… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index beaff682d3..1c365f8168 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -367,7 +367,7 @@ static param_export_t params[] = { {"insert_retries", INT_PARAM, &insert_retries }, {"insert_retry_timeout", INT_PARAM, &insert_retry_timeout }, {"table_time_sufix", PARAM_STR, &table_time_sufix }, - {"topoh_unamsk", PARAM_INT, &sc_topoh_unmask }, + {"topoh_unmask", PARAM_INT, &sc_topoh_unmask }, {"nonsip_hook", PARAM_INT, &nonsip_hook }, {0, 0, 0} };

2 3

git:5.0:605feb78: modules/sipcapture: fix (param_export_t).name typo
by Mikko Lehto 25 Jul '17

25 Jul '17

Module: kamailio Branch: 5.0 Commit: 605feb7876c4a4a70b3c336b477a597182a8e60a URL: https://github.com/kamailio/kamailio/commit/605feb7876c4a4a70b3c336b477a597… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-07-25T22:36:51+03:00 modules/sipcapture: fix (param_export_t).name typo (cherry picked from commit b59771bb81bbe240b98113252df10377a75da700) --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/605feb7876c4a4a70b3c336b477a597… Patch: https://github.com/kamailio/kamailio/commit/605feb7876c4a4a70b3c336b477a597… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index efc53d1054..7167cf3053 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -367,7 +367,7 @@ static param_export_t params[] = { {"insert_retries", INT_PARAM, &insert_retries }, {"insert_retry_timeout", INT_PARAM, &insert_retry_timeout }, {"table_time_sufix", PARAM_STR, &table_time_sufix }, - {"topoh_unamsk", PARAM_INT, &sc_topoh_unmask }, + {"topoh_unmask", PARAM_INT, &sc_topoh_unmask }, {"nonsip_hook", PARAM_INT, &nonsip_hook }, {0, 0, 0} };

1 0

git:master:f3a96c82: modules: readme files regenerated - dialplan ... [skip ci]
by Kamailio Dev 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: f3a96c82dae858da68d586a2ded97d7ae3c11a2e URL: https://github.com/kamailio/kamailio/commit/f3a96c82dae858da68d586a2ded97d7… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-25T19:46:22+02:00 modules: readme files regenerated - dialplan ... [skip ci] --- Modified: src/modules/dialplan/README --- Diff: https://github.com/kamailio/kamailio/commit/f3a96c82dae858da68d586a2ded97d7… Patch: https://github.com/kamailio/kamailio/commit/f3a96c82dae858da68d586a2ded97d7…

1 0

git:master:2cae9f8a: dialplan: added documentation for dp_match() and dp_translate()
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 2cae9f8a301befb0a00f1831c9d5773924e35c10 URL: https://github.com/kamailio/kamailio/commit/2cae9f8a301befb0a00f1831c9d5773… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T19:41:05+02:00 dialplan: added documentation for dp_match() and dp_translate() --- Modified: src/modules/dialplan/doc/dialplan_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2cae9f8a301befb0a00f1831c9d5773… Patch: https://github.com/kamailio/kamailio/commit/2cae9f8a301befb0a00f1831c9d5773… --- diff --git a/src/modules/dialplan/doc/dialplan_admin.xml b/src/modules/dialplan/doc/dialplan_admin.xml index 8153974401..073c2b24ed 100644 --- a/src/modules/dialplan/doc/dialplan_admin.xml +++ b/src/modules/dialplan/doc/dialplan_admin.xml @@ -394,6 +394,103 @@ modparam("dialplan", "match_dynamic", 1) <section> <title>Functions</title> + <section id="dialplan.p.dp_replace"> + <title> + <function moreinfo="none">dp_replace(dpid, inval, outvar)</function> + </title> + <para> + The function translates the input value 'inval' using the rules with dialplan + id 'dpid', storing the value in the variable 'outvar'. If the rule that was + applied has attributes, they are stored in the variable provided via the + module parameter 'attrs_pvar'. + </para> + <para> + The behavior is same as dp_translate("dpid", "inval/outvar"), but the + parameters have a more flexible format. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>dpid</emphasis> - the dialplan id to match the rules and apply + the transformations. It can be a static string or a config variable + holding an integer value. + </para> + </listitem> + <listitem> + <para> + <emphasis>inval</emphasis> - input value. It can be a static or a + dynamic string. The dynamic string can contain config variables, + combined or not with static strings, that are evaluated at runtime. + </para> + </listitem> + <listitem> + <para> + <emphasis>outvar</emphasis> - output variable name. The value resulted + after applying the matching rule is stored in this variable. The name + must refer to a writable variable. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>dp_replace</function> usage</title> + <programlisting format="linespecific"> +... +dp_replace("240", "$rU", "$var(newru)"); +xlog("'$rU' was translated to '$var(newru)'\n"); +dp_replace("240", "+49$rU", "$var(newval)"); +... + </programlisting> + </example> + </section> + + <section id="dialplan.p.dp_match"> + <title> + <function moreinfo="none">dp_match(dpid, inval)</function> + </title> + <para> + The function matches the input value 'inval' using the rules with dialplan + id 'dpid'. If the rule that was applied has attributes, they are stored in + the variable provided via the module parameter 'attrs_pvar'. + </para> + <para> + The behavior is same as dp_translate("dpid", "inval"), but the + parameters have a more flexible format. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>dpid</emphasis> - the dialplan id to match the rules and apply + the transformations. It can be a static string or a config variable + holding an integer value. + </para> + </listitem> + <listitem> + <para> + <emphasis>inval</emphasis> - input value. It can be a static or a + dynamic string. The dynamic string can contain config variables, + combined or not with static strings, that are evaluated at runtime. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>dp_match</function> usage</title> + <programlisting format="linespecific"> +... +dp_match("240", "+49$rU"); +xlog("the attributes associated with '+49$rU' are '$var(attrs)'\n"); +... + </programlisting> + </example> + </section> + <section id="dialplan.p.dp_translate"> <title> <function moreinfo="none">dp_translate(id, [src[/dest]])</function>

1 0

git:master:e049d6db: core: added helper fixup for int and str dynamic parameters
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: e049d6db78d9a86049f88acc27188d726974054f URL: https://github.com/kamailio/kamailio/commit/e049d6db78d9a86049f88acc27188d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T19:41:05+02:00 core: added helper fixup for int and str dynamic parameters --- Modified: src/core/mod_fix.c Modified: src/core/mod_fix.h --- Diff: https://github.com/kamailio/kamailio/commit/e049d6db78d9a86049f88acc27188d7… Patch: https://github.com/kamailio/kamailio/commit/e049d6db78d9a86049f88acc27188d7… --- diff --git a/src/core/mod_fix.c b/src/core/mod_fix.c index d817b75565..3e8562add6 100644 --- a/src/core/mod_fix.c +++ b/src/core/mod_fix.c @@ -461,7 +461,6 @@ int fixup_igp_pvar(void** param, int param_no) } - int fixup_free_igp_pvar(void** param, int param_no) { if (param_no == 1) @@ -472,7 +471,6 @@ int fixup_free_igp_pvar(void** param, int param_no) } - int fixup_igp_pvar_pvar(void** param, int param_no) { if (param_no == 1) @@ -483,7 +481,6 @@ int fixup_igp_pvar_pvar(void** param, int param_no) } - int fixup_free_igp_pvar_pvar(void** param, int param_no) { if (param_no == 1) @@ -494,6 +491,25 @@ int fixup_free_igp_pvar_pvar(void** param, int param_no) } +int fixup_igp_spve(void** param, int param_no) +{ + if (param_no == 1) + return fixup_igp_null(param, param_no); + else if (param_no == 2) + return fixup_spve_all(param, param_no); + return E_UNSPEC; +} + + +int fixup_free_igp_spve(void** param, int param_no) +{ + if (param_no == 1) + return fixup_free_igp_null(param, param_no); + else if (param_no == 2) + return fixup_free_spve_all(param, param_no); + return E_UNSPEC; +} + /** macro for declaring a spve fixup and the corresponding free_fixup * for a function expecting first no1 params as fparam converted spve diff --git a/src/core/mod_fix.h b/src/core/mod_fix.h index 835342ab86..869dd78527 100644 --- a/src/core/mod_fix.h +++ b/src/core/mod_fix.h @@ -122,6 +122,12 @@ int fixup_free_igp_pvar(void** param, int param_no); int fixup_igp_pvar_pvar(void** param, int param_no); int fixup_free_igp_pvar_pvar(void** param, int param_no); +int fixup_igp_spve(void** param, int param_no); +int fixup_free_igp_spve(void** param, int param_no); + +int fixup_pvar_all(void** param, int param_no); +int fixup_free_pvar_all(void** param, int param_no); + int fixup_spve_spve(void** param, int param_no); int fixup_free_spve_spve(void** param, int param_no); int fixup_spve_null(void** param, int param_no);

1 0

git:master:2c105fa6: dialplan: added dp_match() and dp_replace() functions
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 2c105fa6a66e24a6d9e24f96b0f4c04b60ce0da9 URL: https://github.com/kamailio/kamailio/commit/2c105fa6a66e24a6d9e24f96b0f4c04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T19:41:05+02:00 dialplan: added dp_match() and dp_replace() functions - alternatives to dp_translate() with dedicated required parameters (avoiding second parameter of two variables separated by '/') - dp_match(dpid, inval) - dp_replace(dpid, inval, outvar) - dpid can be interger or variable - inval can be a static or dynamic (with vars) string - outvar has to be a writable variable --- Modified: src/modules/dialplan/dialplan.c Modified: src/modules/dialplan/dialplan.h Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/2c105fa6a66e24a6d9e24f96b0f4c04… Patch: https://github.com/kamailio/kamailio/commit/2c105fa6a66e24a6d9e24f96b0f4c04…

1 0

git:master:36b8c1a1: dialplan: increased the size for dialplan attributes to 256
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 36b8c1a138548ea3689cac77e18ac304ec2ee0e5 URL: https://github.com/kamailio/kamailio/commit/36b8c1a138548ea3689cac77e18ac30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T19:41:05+02:00 dialplan: increased the size for dialplan attributes to 256 --- Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/36b8c1a138548ea3689cac77e18ac30… Patch: https://github.com/kamailio/kamailio/commit/36b8c1a138548ea3689cac77e18ac30… --- diff --git a/src/modules/dialplan/dp_repl.c b/src/modules/dialplan/dp_repl.c index 85741677df..28d555bbdd 100644 --- a/src/modules/dialplan/dp_repl.c +++ b/src/modules/dialplan/dp_repl.c @@ -571,7 +571,7 @@ int rule_translate(sip_msg_t *msg, str string, dpl_node_t * rule, return -1; } -#define DP_MAX_ATTRS_LEN 128 +#define DP_MAX_ATTRS_LEN 255 static char dp_attrs_buf[DP_MAX_ATTRS_LEN+1]; int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, str *attrs)

1 0

git:master:c9ff171b: modules: readme files regenerated - sipcapture ... [skip ci]
by Kamailio Dev 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: c9ff171b4ce90671eebbef914e12e8d59521e621 URL: https://github.com/kamailio/kamailio/commit/c9ff171b4ce90671eebbef914e12e8d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-25T15:01:20+02:00 modules: readme files regenerated - sipcapture ... [skip ci] --- Modified: src/modules/sipcapture/README --- Diff: https://github.com/kamailio/kamailio/commit/c9ff171b4ce90671eebbef914e12e8d… Patch: https://github.com/kamailio/kamailio/commit/c9ff171b4ce90671eebbef914e12e8d… --- diff --git a/src/modules/sipcapture/README b/src/modules/sipcapture/README index 451628d8b3..bc7bc6694f 100644 --- a/src/modules/sipcapture/README +++ b/src/modules/sipcapture/README @@ -49,6 +49,7 @@ Alexandr Dubovikov 3.18. insert_retry_timeout (integer) 3.19. callid_aleg_header (str) 3.20. topoh_unmask (int) + 3.21. nonsip_hook (int) 4. Functions @@ -84,8 +85,9 @@ Alexandr Dubovikov 1.18. Set insert_retry_timeout parameter 1.19. Set callid_aleg_header parameter 1.20. Set topoh_unmask parameter - 1.21. sip_capture() usage - 1.22. report_capture() usage + 1.21. Set nonsip_hook parameter + 1.22. sip_capture() usage + 1.23. report_capture() usage Chapter 1. Admin Guide @@ -119,6 +121,7 @@ Chapter 1. Admin Guide 3.18. insert_retry_timeout (integer) 3.19. callid_aleg_header (str) 3.20. topoh_unmask (int) + 3.21. nonsip_hook (int) 4. Functions @@ -186,6 +189,7 @@ Chapter 1. Admin Guide 3.18. insert_retry_timeout (integer) 3.19. callid_aleg_header (str) 3.20. topoh_unmask (int) + 3.21. nonsip_hook (int) 3.1. db_url (str) @@ -456,6 +460,18 @@ modparam("sipcapture", "callid_aleg_header", "X-CallIDALeg") modparam("sipcapture", "topoh_unmask", 1) ... +3.21. nonsip_hook (int) + + If set to 1, event route sipcapture:siprequest is run when HEP message + is received. + + Default value is 0. + + Example 1.21. Set nonsip_hook parameter +... +modparam("sipcapture", "nonsip_hook", 1) +... + 4. Functions 4.1. sip_capture([table]) @@ -477,7 +493,7 @@ modparam("sipcapture", "topoh_unmask", 1) ONREPLY_ROUTE, BRANCH_ROUTE. Default value is "NULL". - Example 1.21. sip_capture() usage + Example 1.22. sip_capture() usage ... sip_capture(); ... @@ -496,7 +512,7 @@ sip_capture("sip_capture_call_20160124"); ONREPLY_ROUTE, BRANCH_ROUTE. Default value is "NULL". - Example 1.22. report_capture() usage + Example 1.23. report_capture() usage ... report_capture(); ...

1 0

git:master:2f872dcc: modules/sipcapture: improve nonsip_hook documentation
by Mikko Lehto 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 2f872dcc684a345cff09a437ae4a3767613b5529 URL: https://github.com/kamailio/kamailio/commit/2f872dcc684a345cff09a437ae4a376… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-07-25T15:54:57+03:00 modules/sipcapture: improve nonsip_hook documentation --- Modified: src/modules/sipcapture/doc/sipcapture_admin.xml Modified: src/modules/sipcapture/examples/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/2f872dcc684a345cff09a437ae4a376… Patch: https://github.com/kamailio/kamailio/commit/2f872dcc684a345cff09a437ae4a376… --- diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml b/src/modules/sipcapture/doc/sipcapture_admin.xml index 8916317cb0..d9d47cceda 100644 --- a/src/modules/sipcapture/doc/sipcapture_admin.xml +++ b/src/modules/sipcapture/doc/sipcapture_admin.xml @@ -493,6 +493,26 @@ modparam("sipcapture", "topoh_unmask", 1) </programlisting> </example> </section> + + <section id="sipcapture.p.nonsip_hook"> + <title><varname>nonsip_hook</varname> (int)</title> + <para> + If set to 1, event route <emphasis>sipcapture:siprequest</emphasis> is + run when HEP message is received. + </para> + <para> + Default value is <emphasis>0</emphasis>. + </para> + <example> + <title>Set <varname>nonsip_hook</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("sipcapture", "nonsip_hook", 1) +... + </programlisting> + </example> + </section> + </section> <section> <title>Functions</title> diff --git a/src/modules/sipcapture/examples/kamailio.cfg b/src/modules/sipcapture/examples/kamailio.cfg index 3d42a78f47..14a5641a1c 100644 --- a/src/modules/sipcapture/examples/kamailio.cfg +++ b/src/modules/sipcapture/examples/kamailio.cfg @@ -861,10 +861,6 @@ route[STORE] { sip_capture("$var(a)"); } -event_route[sipcapture:request] { - xlog("received sipcapture request from $si:$sp\r\n"); -} - #!ifdef WITH_HOMER_CUSTOM_STATS event_route[xhttp:request] { set_reply_close(); @@ -908,12 +904,14 @@ event_route[xhttp:request] { event_route[sipcapture:request] { - xlog("HEP Request!\n"); - xlog("received sipcapture request from $si:$sp\r\n"); - xlog("HEP VERSION $hep(version) request from $si:$sp\r\n"); - xlog("HEP CHUNK Source IP $hep(0x002) request from $si:$sp\r\n"); + xlog("HEP Request!\n"); + xlog("received sipcapture request from $si:$sp\n"); + xlog("HEP VERSION $hep(version) request from $si:$sp\n"); + xlog("HEP CHUNK Source IP $hep(0x002) request from $si:$sp\n"); + #Is it SIP ? - if($hep(0x00b) == 1){ + if($hep(0x00b) == 1) + { #Do parsing internal return 1; @@ -921,8 +919,8 @@ event_route[sipcapture:request] { else { #If report lets proceed here with payload - xlog("HEP CHUNK PAYLOAD $hep(0x00f) request from $si:$sp\r\n"); - return 0; + xlog("HEP CHUNK PAYLOAD $hep(0x00f) request from $si:$sp\n"); + return 0; } }

1 0

git:master:1632bb7c: pv: xavp related functions exported to kemi framework
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 1632bb7ced8aab774cc3c77abba1246c1a848a5b URL: https://github.com/kamailio/kamailio/commit/1632bb7ced8aab774cc3c77abba1246… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T14:05:47+02:00 pv: xavp related functions exported to kemi framework --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/1632bb7ced8aab774cc3c77abba1246… Patch: https://github.com/kamailio/kamailio/commit/1632bb7ced8aab774cc3c77abba1246… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index ad33d3b899..8dccdb3a0b 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -26,6 +26,7 @@ #include "../../core/pvar.h" #include "../../core/lvalue.h" #include "../../core/mod_fix.h" +#include "../../core/xavp.h" #include "../../core/kemi.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" @@ -741,6 +742,11 @@ static int w_var_to_xavp(sip_msg_t *msg, char *s1, char *s2) return pv_var_to_xavp(&varname, &xname); } +static int ki_var_to_xavp(sip_msg_t *msg, str *varname, str *xname) +{ + return pv_var_to_xavp(varname, xname); +} + /** * xavp to script variable */ @@ -756,6 +762,17 @@ static int w_xavp_to_var(sip_msg_t *msg, char *s1) return pv_xavp_to_var(&xname); } +static int ki_xavp_to_var(sip_msg_t *msg, str *xname) +{ + return pv_xavp_to_var(xname); +} + +static int ki_xavp_print(sip_msg_t* msg) +{ + xavp_print_list(NULL); + return 1; +} + /** * */ @@ -782,6 +799,17 @@ static int w_xavp_params_explode(sip_msg_t *msg, char *pparams, char *pxname) /** * */ +static int ki_xavp_params_explode(sip_msg_t *msg, str *sparams, str *sxname) +{ + if(xavp_params_explode(sparams, sxname)<0) + return -1; + + return 1; +} + +/** + * + */ static int w_sbranch_set_ruri(sip_msg_t *msg, char p1, char *p2) { if(sbranch_set_ruri(msg)<0) @@ -962,6 +990,26 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("pv_var_to_xavp"), + SR_KEMIP_INT, ki_var_to_xavp, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("pvx"), str_init("pv_xavp_to_var"), + SR_KEMIP_INT, ki_xavp_to_var, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("pvx"), str_init("pv_xavp_print"), + SR_KEMIP_INT, ki_xavp_print, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("pvx"), str_init("xavp_params_explode"), + SR_KEMIP_INT, ki_xavp_params_explode, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; @@ -979,4 +1027,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) return -1; } return register_trans_mod(path, mod_trans); -} +} \ No newline at end of file diff --git a/src/modules/pv/pv_xavp.c b/src/modules/pv/pv_xavp.c index d556dda99f..c36a6c6f1f 100644 --- a/src/modules/pv/pv_xavp.c +++ b/src/modules/pv/pv_xavp.c @@ -555,7 +555,7 @@ int pv_parse_xavp_name(pv_spec_p sp, str *in) return -1; } -int pv_xavp_print(struct sip_msg* msg, char* s1, char *s2) +int pv_xavp_print(sip_msg_t* msg, char* s1, char *s2) { xavp_print_list(NULL); return 1;

1 0

git:master:8db85222: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 8db85222c3f82e8af1fbeb38eaabb9aec99ecab2 URL: https://github.com/kamailio/kamailio/commit/8db85222c3f82e8af1fbeb38eaabb9a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-07-25T14:01:22+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/8db85222c3f82e8af1fbeb38eaabb9a… Patch: https://github.com/kamailio/kamailio/commit/8db85222c3f82e8af1fbeb38eaabb9a… --- diff --git a/src/modules/pv/README b/src/modules/pv/README index d30fea9c67..428a27c958 100644 --- a/src/modules/pv/README +++ b/src/modules/pv/README @@ -371,12 +371,14 @@ pv_xavp_print(); 4.11. pv_var_to_xavp(varname, xname) - Copy script variables values to a xavp. + Copy the script variable value into an xavp. First parameter can be '*' in order to copy all script variables. Second parameter is the name of the destination xavp. If xavp already exists it will be reset first. + Both parameters can contain variables that are evaluated at runtime. + Function can be used from ANY_ROUTE. Example 1.14. pv_var_to_xavp() usage @@ -395,7 +397,9 @@ $xavp("ok[0]=>foo") now is "foo indeed" 4.12. pv_xavp_to_var(xname) - Copy xavp values to vars. Reverse of pv_var_to_xavp(). + Copy xavp values into vars. Reverse of pv_var_to_xavp(). + + Both parameters can contain variables that are evaluated at runtime. Function can be used from ANY_ROUTE.

1 0

git:master:e9a132af: pv: notes about dynamic parameters for xavp to var funtions
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: e9a132afc0fa4b02a7030c2c20ade65a1d693006 URL: https://github.com/kamailio/kamailio/commit/e9a132afc0fa4b02a7030c2c20ade65… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T13:49:05+02:00 pv: notes about dynamic parameters for xavp to var funtions --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e9a132afc0fa4b02a7030c2c20ade65… Patch: https://github.com/kamailio/kamailio/commit/e9a132afc0fa4b02a7030c2c20ade65… --- diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml index 31929efa7f..bd5a7ab6f4 100644 --- a/src/modules/pv/doc/pv_admin.xml +++ b/src/modules/pv/doc/pv_admin.xml @@ -400,10 +400,16 @@ pv_xavp_print(); <function moreinfo="none">pv_var_to_xavp(varname, xname)</function> </title> <para> - Copy script variables values to a xavp. + Copy the script variable value into an xavp. </para> <para> - First parameter can be '*' in order to copy all script variables. Second parameter is the name of the destination xavp. If xavp already exists it will be reset first. + First parameter can be '*' in order to copy all script variables. + Second parameter is the name of the destination xavp. + If xavp already exists it will be reset first. + </para> + <para> + Both parameters can contain variables that are evaluated at + runtime. </para> <para> Function can be used from ANY_ROUTE. @@ -431,7 +437,11 @@ $xavp("ok[0]=>foo") now is "foo indeed" <function moreinfo="none">pv_xavp_to_var(xname)</function> </title> <para> - Copy xavp values to vars. Reverse of pv_var_to_xavp(). + Copy xavp values into vars. Reverse of pv_var_to_xavp(). + </para> + <para> + Both parameters can contain variables that are evaluated at + runtime. </para> <para> Function can be used from ANY_ROUTE.

1 0

git:master:45506c43: pv: support for dynamic params for var to xavp functions
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 45506c4343ae03450e33a04b9f2e9a3196d57306 URL: https://github.com/kamailio/kamailio/commit/45506c4343ae03450e33a04b9f2e9a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T13:45:28+02:00 pv: support for dynamic params for var to xavp functions --- Modified: src/modules/pv/pv.c --- Diff: https://github.com/kamailio/kamailio/commit/45506c4343ae03450e33a04b9f2e9a3… Patch: https://github.com/kamailio/kamailio/commit/45506c4343ae03450e33a04b9f2e9a3… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index c85d2015eb..ad33d3b899 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -538,10 +538,10 @@ static cmd_export_t cmds[]={ #ifdef WITH_XAVP {"pv_xavp_print", (cmd_function)pv_xavp_print, 0, 0, 0, ANY_ROUTE }, - {"pv_var_to_xavp", (cmd_function)w_var_to_xavp, 2, 0, 0, - ANY_ROUTE }, - {"pv_xavp_to_var", (cmd_function)w_xavp_to_var, 1, 0, 0, - ANY_ROUTE }, + {"pv_var_to_xavp", (cmd_function)w_var_to_xavp, 2, fixup_spve_spve, + fixup_free_spve_spve, ANY_ROUTE }, + {"pv_xavp_to_var", (cmd_function)w_xavp_to_var, 1, fixup_spve_null, + fixup_free_spve_null, ANY_ROUTE }, #endif {"is_int", (cmd_function)is_int, 1, fixup_pvar_null, fixup_free_pvar_null, ANY_ROUTE}, @@ -721,30 +721,38 @@ static int is_int(struct sip_msg* msg, char* pvar, char* s2) return -1; } +/** + * script variable to xavp + */ static int w_var_to_xavp(sip_msg_t *msg, char *s1, char *s2) { - str xname, varname; + str xname = STR_NULL; + str varname = STR_NULL; - if(s1 == NULL || s2 == NULL) { - LM_ERR("wrong parameters\n"); + if(fixup_get_svalue(msg, (gparam_t*)s1, &varname)<0) { + LM_ERR("failed to get the var name\n"); + return -1; + } + if(fixup_get_svalue(msg, (gparam_t*)s2, &xname)<0) { + LM_ERR("failed to get the xavp name\n"); return -1; } - varname.len = strlen(s1); varname.s = s1; - xname.s = s2; xname.len = strlen(s2); return pv_var_to_xavp(&varname, &xname); } +/** + * xavp to script variable + */ static int w_xavp_to_var(sip_msg_t *msg, char *s1) { - str xname; + str xname = STR_NULL; - if(s1 == NULL) { - LM_ERR("wrong parameters\n"); + if(fixup_get_svalue(msg, (gparam_t*)s1, &xname)<0) { + LM_ERR("failed to get the xavp name\n"); return -1; } - xname.s = s1; xname.len = strlen(s1); return pv_xavp_to_var(&xname); }

1 0

git:master:78722ff2: dialplan: catch error case from macro used inside dp_trans_fixup()
by Daniel-Constantin Mierla 25 Jul '17

25 Jul '17

Module: kamailio Branch: master Commit: 78722ff2f1e290dc6ae41a4d718e9c4cea20926b URL: https://github.com/kamailio/kamailio/commit/78722ff2f1e290dc6ae41a4d718e9c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-25T10:54:20+02:00 dialplan: catch error case from macro used inside dp_trans_fixup() --- Modified: src/modules/dialplan/dialplan.c --- Diff: https://github.com/kamailio/kamailio/commit/78722ff2f1e290dc6ae41a4d718e9c4… Patch: https://github.com/kamailio/kamailio/commit/78722ff2f1e290dc6ae41a4d718e9c4… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index e5710fd828..7fd6245a31 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -332,7 +332,7 @@ static int dp_translate_f(struct sip_msg* msg, char* str1, char* str2) } -#define verify_par_type(_par_no, _spec)\ +#define verify_par_type(_par_no, _spec, _ret) \ do{\ if( ((_par_no == 1) \ && (_spec->type != PVT_AVP) && (_spec->type != PVT_XAVP) && \ @@ -343,7 +343,8 @@ static int dp_translate_f(struct sip_msg* msg, char* str1, char* str2) && (_spec->type!=PVT_RURI) && (_spec->type!=PVT_RURI_USERNAME))){\ \ LM_ERR("Unsupported Parameter TYPE[%d]\n", _spec->type);\ - return E_UNSPEC;\ + _ret = E_UNSPEC; \ + goto error; \ }\ }while(0); @@ -359,6 +360,7 @@ static int dp_trans_fixup(void ** param, int param_no){ dp_param_p dp_par= NULL; char *p, *s=NULL; str lstr; + int ret = E_INVALID_PARAMS; if(param_no!=1 && param_no!=2) return 0; @@ -384,8 +386,8 @@ static int dp_trans_fixup(void ** param, int param_no){ lstr.s = *param; lstr.len = strlen(*param); if(str2sint(&lstr, &dpid) != 0) { LM_ERR("bad number <%s>\n",(char *)(*param)); - pkg_free(dp_par); - return E_CFG; + ret = E_CFG; + goto error; } dp_par->type = DP_VAL_INT; @@ -394,11 +396,10 @@ static int dp_trans_fixup(void ** param, int param_no){ lstr.s = p; lstr.len = strlen(p); dp_par->v.sp[0] = pv_cache_get(&lstr); if (dp_par->v.sp[0]==NULL) { - pkg_free(dp_par); goto error; } - verify_par_type(param_no, dp_par->v.sp[0]); + verify_par_type(param_no, dp_par->v.sp[0], ret); dp_par->type = DP_VAL_SPEC; } } else { @@ -413,7 +414,6 @@ static int dp_trans_fixup(void ** param, int param_no){ lstr.s = p; lstr.len = strlen(p); dp_par->v.sp[0] = pv_cache_get(&lstr); if(dp_par->v.sp[0]==NULL) { - pkg_free(dp_par); goto error; } @@ -421,10 +421,9 @@ static int dp_trans_fixup(void ** param, int param_no){ lstr.s = s; lstr.len = strlen(s); dp_par->v.sp[1] = pv_cache_get(&lstr); if (dp_par->v.sp[1]==NULL) { - pkg_free(dp_par); goto error; } - verify_par_type(param_no, dp_par->v.sp[1]); + verify_par_type(param_no, dp_par->v.sp[1], ret); } dp_par->type = DP_VAL_SPEC; @@ -437,7 +436,9 @@ static int dp_trans_fixup(void ** param, int param_no){ error: LM_ERR("failed to parse param %i\n", param_no); - return E_INVALID_PARAMS; + if(dp_par) pkg_free(dp_par); + + return ret; } /**

1 0

git:4.4:4d49b33b: tsilo: coherent locking in ts_append
by Federico Cabiddu 24 Jul '17

24 Jul '17

Module: kamailio Branch: 4.4 Commit: 4d49b33b6f2418329b4ede1e166239bb0d93af9e URL: https://github.com/kamailio/kamailio/commit/4d49b33b6f2418329b4ede1e166239b… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2017-07-24T15:19:32+02:00 tsilo: coherent locking in ts_append (cherry picked from commit 34265457e7c09b56dec295b753fd8250ef8b0c41) --- Modified: modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/4d49b33b6f2418329b4ede1e166239b… Patch: https://github.com/kamailio/kamailio/commit/4d49b33b6f2418329b4ede1e166239b… --- diff --git a/modules/tsilo/ts_append.c b/modules/tsilo/ts_append.c index b0c605a0ee..b5c51393e5 100644 --- a/modules/tsilo/ts_append.c +++ b/modules/tsilo/ts_append.c @@ -46,32 +46,31 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { int res; int appended; - - lock_entry_by_ruri(ruri); - + if (use_domain) { t_uri = ruri; } else { if(parse_uri(ruri->s, ruri->len, &p_uri)<0) { LM_ERR("failed to parse uri %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); return -1; } t_uri = &p_uri.user; } + lock_entry_by_ruri(t_uri); + res = get_ts_urecord(t_uri, &_r); if (res != 0) { - LM_ERR("failed to retrieve record for %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); + LM_ERR("failed to retrieve record for %.*s\n", t_uri->len, t_uri->s); + unlock_entry_by_ruri(t_uri); return -1; } ptr = _r->transactions; while(ptr) { - LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, ruri->len, ruri->s); + LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, t_uri->len, t_uri->s); appended = ts_append_to(msg, ptr->tindex, ptr->tlabel, table, ruri); if (appended > 0) @@ -79,7 +78,7 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { ptr = ptr->next; } - unlock_entry_by_ruri(ruri); + unlock_entry_by_ruri(t_uri); return 1; }

1 0

git:4.4:1765576b: tsilo: check return code for parse_uri()
by Federico Cabiddu 24 Jul '17

24 Jul '17

Module: kamailio Branch: 4.4 Commit: 1765576b013524e73131b9adb4d4ccb78de43658 URL: https://github.com/kamailio/kamailio/commit/1765576b013524e73131b9adb4d4ccb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2017-07-24T15:19:03+02:00 tsilo: check return code for parse_uri() (cherry picked from commit a19a06f6c302a7fbac9b137cc1558d47730ead2f) --- Modified: modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/1765576b013524e73131b9adb4d4ccb… Patch: https://github.com/kamailio/kamailio/commit/1765576b013524e73131b9adb4d4ccb… --- diff --git a/modules/tsilo/ts_append.c b/modules/tsilo/ts_append.c index db47fdfad7..b0c605a0ee 100644 --- a/modules/tsilo/ts_append.c +++ b/modules/tsilo/ts_append.c @@ -51,9 +51,12 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { if (use_domain) { t_uri = ruri; - } - else { - parse_uri(ruri->s, ruri->len, &p_uri); + } else { + if(parse_uri(ruri->s, ruri->len, &p_uri)<0) { + LM_ERR("failed to parse uri %.*s\n", ruri->len, ruri->s); + unlock_entry_by_ruri(ruri); + return -1; + } t_uri = &p_uri.user; }

1 0

git:5.0:3bfc9d49: tsilo: check return code for parse_uri()
by Federico Cabiddu 24 Jul '17

24 Jul '17

Module: kamailio Branch: 5.0 Commit: 3bfc9d4955cf3edd64fe29aa3e88d23609360209 URL: https://github.com/kamailio/kamailio/commit/3bfc9d4955cf3edd64fe29aa3e88d23… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2017-07-24T15:18:29+02:00 tsilo: check return code for parse_uri() (cherry picked from commit a19a06f6c302a7fbac9b137cc1558d47730ead2f) --- Modified: src/modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/3bfc9d4955cf3edd64fe29aa3e88d23… Patch: https://github.com/kamailio/kamailio/commit/3bfc9d4955cf3edd64fe29aa3e88d23… --- diff --git a/src/modules/tsilo/ts_append.c b/src/modules/tsilo/ts_append.c index 0076634109..e6e27e40cc 100644 --- a/src/modules/tsilo/ts_append.c +++ b/src/modules/tsilo/ts_append.c @@ -50,9 +50,12 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { if (use_domain) { t_uri = ruri; - } - else { - parse_uri(ruri->s, ruri->len, &p_uri); + } else { + if(parse_uri(ruri->s, ruri->len, &p_uri)<0) { + LM_ERR("failed to parse uri %.*s\n", ruri->len, ruri->s); + unlock_entry_by_ruri(ruri); + return -1; + } t_uri = &p_uri.user; }

1 0

git:5.0:41392baa: tsilo: coherent locking in ts_append
by Federico Cabiddu 24 Jul '17

24 Jul '17

Module: kamailio Branch: 5.0 Commit: 41392baa1b9d40e2d5cff5e532b2fe3b6c132bb6 URL: https://github.com/kamailio/kamailio/commit/41392baa1b9d40e2d5cff5e532b2fe3… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2017-07-24T15:18:35+02:00 tsilo: coherent locking in ts_append (cherry picked from commit 34265457e7c09b56dec295b753fd8250ef8b0c41) --- Modified: src/modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/41392baa1b9d40e2d5cff5e532b2fe3… Patch: https://github.com/kamailio/kamailio/commit/41392baa1b9d40e2d5cff5e532b2fe3… --- diff --git a/src/modules/tsilo/ts_append.c b/src/modules/tsilo/ts_append.c index e6e27e40cc..7d951865f0 100644 --- a/src/modules/tsilo/ts_append.c +++ b/src/modules/tsilo/ts_append.c @@ -45,32 +45,31 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { int res; int appended; - - lock_entry_by_ruri(ruri); - + if (use_domain) { t_uri = ruri; } else { if(parse_uri(ruri->s, ruri->len, &p_uri)<0) { LM_ERR("failed to parse uri %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); return -1; } t_uri = &p_uri.user; } + lock_entry_by_ruri(t_uri); + res = get_ts_urecord(t_uri, &_r); if (res != 0) { - LM_ERR("failed to retrieve record for %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); + LM_ERR("failed to retrieve record for %.*s\n", t_uri->len, t_uri->s); + unlock_entry_by_ruri(t_uri); return -1; } ptr = _r->transactions; while(ptr) { - LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, ruri->len, ruri->s); + LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, t_uri->len, t_uri->s); appended = ts_append_to(msg, ptr->tindex, ptr->tlabel, table, ruri); if (appended > 0) @@ -78,7 +77,7 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { ptr = ptr->next; } - unlock_entry_by_ruri(ruri); + unlock_entry_by_ruri(t_uri); return 1; }

1 0

git:master:34265457: tsilo: coherent locking in ts_append
by Federico Cabiddu 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 34265457e7c09b56dec295b753fd8250ef8b0c41 URL: https://github.com/kamailio/kamailio/commit/34265457e7c09b56dec295b753fd825… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2017-07-24T15:16:21+02:00 tsilo: coherent locking in ts_append --- Modified: src/modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/34265457e7c09b56dec295b753fd825… Patch: https://github.com/kamailio/kamailio/commit/34265457e7c09b56dec295b753fd825… --- diff --git a/src/modules/tsilo/ts_append.c b/src/modules/tsilo/ts_append.c index e6e27e40cc..7d951865f0 100644 --- a/src/modules/tsilo/ts_append.c +++ b/src/modules/tsilo/ts_append.c @@ -45,32 +45,31 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { int res; int appended; - - lock_entry_by_ruri(ruri); - + if (use_domain) { t_uri = ruri; } else { if(parse_uri(ruri->s, ruri->len, &p_uri)<0) { LM_ERR("failed to parse uri %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); return -1; } t_uri = &p_uri.user; } + lock_entry_by_ruri(t_uri); + res = get_ts_urecord(t_uri, &_r); if (res != 0) { - LM_ERR("failed to retrieve record for %.*s\n", ruri->len, ruri->s); - unlock_entry_by_ruri(ruri); + LM_ERR("failed to retrieve record for %.*s\n", t_uri->len, t_uri->s); + unlock_entry_by_ruri(t_uri); return -1; } ptr = _r->transactions; while(ptr) { - LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, ruri->len, ruri->s); + LM_DBG("transaction %u:%u found for %.*s, going to append branches\n",ptr->tindex, ptr->tlabel, t_uri->len, t_uri->s); appended = ts_append_to(msg, ptr->tindex, ptr->tlabel, table, ruri); if (appended > 0) @@ -78,7 +77,7 @@ int ts_append(struct sip_msg* msg, str *ruri, char *table) { ptr = ptr->next; } - unlock_entry_by_ruri(ruri); + unlock_entry_by_ruri(t_uri); return 1; }

1 0

git:master:0cf4ad7b: app_perl: free on error cases for modf execution
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 0cf4ad7b4e839856eef4dc2cd76adacd1627ce7c URL: https://github.com/kamailio/kamailio/commit/0cf4ad7b4e839856eef4dc2cd76adac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T13:24:49+02:00 app_perl: free on error cases for modf execution --- Modified: src/modules/app_perl/kamailioxs.xs --- Diff: https://github.com/kamailio/kamailio/commit/0cf4ad7b4e839856eef4dc2cd76adac… Patch: https://github.com/kamailio/kamailio/commit/0cf4ad7b4e839856eef4dc2cd76adac… --- diff --git a/src/modules/app_perl/kamailioxs.xs b/src/modules/app_perl/kamailioxs.xs index 8d2604c1a5..385fa1a115 100644 --- a/src/modules/app_perl/kamailioxs.xs +++ b/src/modules/app_perl/kamailioxs.xs @@ -289,6 +289,7 @@ int moduleFunc(struct sip_msg *m, char *func, LM_ERR("Module function '%s' is unsafe. Call is refused.\n", func); if (argv[0]) pkg_free(argv[0]); if (argv[1]) pkg_free(argv[1]); + pkg_free(act); *retval = -1; return -1; } @@ -297,6 +298,9 @@ int moduleFunc(struct sip_msg *m, char *func, *retval = exp_func_struct->fixup(&(act->val[3].u.data), 2); if (*retval < 0) { LM_ERR("Error in fixup (2)\n"); + if (argv[0]) pkg_free(argv[0]); + if (argv[1]) pkg_free(argv[1]); + pkg_free(act); return -1; } act->val[3].type = MODFIXUP_ST; @@ -305,6 +309,9 @@ int moduleFunc(struct sip_msg *m, char *func, *retval = exp_func_struct->fixup(&(act->val[2].u.data), 1); if (*retval < 0) { LM_ERR("Error in fixup (1)\n"); + if (argv[0]) pkg_free(argv[0]); + if (argv[1]) pkg_free(argv[1]); + pkg_free(act); return -1; } act->val[2].type = MODFIXUP_ST; @@ -313,6 +320,9 @@ int moduleFunc(struct sip_msg *m, char *func, *retval = exp_func_struct->fixup(0, 0); if (*retval < 0) { LM_ERR("Error in fixup (0)\n"); + if (argv[0]) pkg_free(argv[0]); + if (argv[1]) pkg_free(argv[1]); + pkg_free(act); return -1; } } @@ -337,7 +347,7 @@ int moduleFunc(struct sip_msg *m, char *func, if (argv[1]) pkg_free(argv[1]); pkg_free(act); - + return 1; } @@ -699,7 +709,9 @@ getFullHeader(self) LM_ERR("getFullHeader: Invalid message type.\n"); ST(0) = &PL_sv_undef; } else { - parse_headers(msg, ~0, 0); + if(parse_headers(msg, ~0, 0)<0) { + LM_ERR("failed to parse headers\n"); + } if (getType(msg) == SIP_REQUEST) { firsttoken = (msg->first_line).u.request.method.s; } else { /* SIP_REPLY */ @@ -713,7 +725,7 @@ getFullHeader(self) -((long)(firsttoken)); if (headerlen > 0) { - ST(0) = + ST(0) = sv_2mortal(newSVpv(firsttoken, headerlen)); } else { ST(0) = &PL_sv_undef; @@ -739,7 +751,9 @@ getBody(self) LM_ERR("Invalid message reference\n"); ST(0) = &PL_sv_undef; } else { - parse_headers(msg, ~0, 0); + if(parse_headers(msg, ~0, 0)<0) { + LM_ERR("failed to parse headers\n"); + } ST(0) = sv_2mortal(newSVpv(get_body(msg), 0)); } @@ -792,7 +806,9 @@ getHeader(self, name) if (!msg) { LM_ERR("Invalid message reference\n"); } else { - parse_headers(msg, ~0, 0); + if(parse_headers(msg, ~0, 0)<0) { + LM_ERR("failed to parse headers\n"); + } for (hf = msg->headers; hf; hf = hf->next) { if (namelen == hf->name.len) { if (strncmp(name, hf->name.s, namelen) == 0) { @@ -825,11 +841,13 @@ getHeaderNames(self) struct hdr_field *hf = NULL; int found = 0; PPCODE: - + if (!msg) { LM_ERR("Invalid message reference\n"); } else { - parse_headers(msg, ~0, 0); + if(parse_headers(msg, ~0, 0)<0) { + LM_ERR("failed to parse headers\n"); + } for (hf = msg->headers; hf; hf = hf->next) { found = 1; XPUSHs(sv_2mortal(newSVpv(hf->name.s, hf->name.len))); @@ -1231,17 +1249,22 @@ getParsedRURI(self) LM_ERR("Invalid message reference\n"); ST(0) = NULL; } else { - parse_sip_msg_uri(msg); - parse_headers(msg, ~0, 0); - - uri = &(msg->parsed_uri); - ret = sv_newmortal(); - sv_setref_pv(ret, "Kamailio::URI", (void *)uri); - SvREADONLY_on(SvRV(ret)); + if(parse_sip_msg_uri(msg)<0) { + LM_ERR("Invalid message uri\n"); + ST(0) = NULL; + } else { + if(parse_headers(msg, ~0, 0)<0) { + LM_ERR("failed to parse headers\n"); + } + uri = &(msg->parsed_uri); + ret = sv_newmortal(); + sv_setref_pv(ret, "Kamailio::URI", (void *)uri); + SvREADONLY_on(SvRV(ret)); - ST(0) = ret; + ST(0) = ret; + } } - + MODULE = Kamailio PACKAGE = Kamailio::URI

1 0

git:master:96582d77: xcap_client: safety check for namespace variable
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 96582d77583719d7bb9c5e5437198800ae9e7a12 URL: https://github.com/kamailio/kamailio/commit/96582d77583719d7bb9c5e543719880… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T12:22:00+02:00 xcap_client: safety check for namespace variable --- Modified: src/modules/xcap_client/xcap_functions.c --- Diff: https://github.com/kamailio/kamailio/commit/96582d77583719d7bb9c5e543719880… Patch: https://github.com/kamailio/kamailio/commit/96582d77583719d7bb9c5e543719880… --- diff --git a/src/modules/xcap_client/xcap_functions.c b/src/modules/xcap_client/xcap_functions.c index 6b875b17d0..cee161b7d0 100644 --- a/src/modules/xcap_client/xcap_functions.c +++ b/src/modules/xcap_client/xcap_functions.c @@ -223,7 +223,7 @@ xcap_node_sel_t* xcapNodeSelAddStep(xcap_node_sel_t* curr_sel, str* name, } curr_sel->size+= 1+ new_step.len; - if(namespace->len) + if(namespace && namespace->len) { curr_sel->size+= namespace->len+ 3; }

1 0

git:master:0f3fb6b8: xmlrpc: handle return codes
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 0f3fb6b8cb04162be07e9246c23bcfa8b8e4e4e6 URL: https://github.com/kamailio/kamailio/commit/0f3fb6b8cb04162be07e9246c23bcfa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T13:00:44+02:00 xmlrpc: handle return codes --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/0f3fb6b8cb04162be07e9246c23bcfa… Patch: https://github.com/kamailio/kamailio/commit/0f3fb6b8cb04162be07e9246c23bcfa… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index ef1535cc88..61b73d0993 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -654,7 +654,7 @@ static int fix_delayed_reply_ctx(rpc_ctx_t* ctx) { if ((ctx->flags & XMLRPC_DELAYED_CTX_F) && (ctx->reply.buf.s==0)){ if (init_xmlrpc_reply(&ctx->reply) <0) return -1; - add_xmlrpc_reply(&ctx->reply, &success_prefix); + if(add_xmlrpc_reply(&ctx->reply, &success_prefix)<0) return -1; if (ctx->flags & RET_ARRAY) return add_xmlrpc_reply(&ctx->reply, &array_prefix); } @@ -787,7 +787,7 @@ static int get_rpc_document(str* doc, sip_msg_t* msg) */ static int send_reply(sip_msg_t* msg, str* body) { - if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) < 0) { + if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) == 0) { ERR("Error while adding reply lump\n"); return -1; } @@ -1965,6 +1965,7 @@ static int rpc_struct_scan(struct rpc_struct* s, char* fmt, ...) break; default: ERR("Invalid parameter type in formatting string: %c\n", *fmt); + va_end(ap); return -1; } fmt++; @@ -2176,7 +2177,7 @@ static int init_context(rpc_ctx_t* ctx, sip_msg_t* msg) ctx->doc = 0; ctx->structs = 0; if (init_xmlrpc_reply(&ctx->reply) < 0) return -1; - add_xmlrpc_reply(&ctx->reply, &success_prefix); + if (add_xmlrpc_reply(&ctx->reply, &success_prefix)<0) return -1; if (open_doc(ctx, msg) < 0) return -1; return 0; } @@ -2367,7 +2368,9 @@ static int process_xmlrpc(sip_msg_t* msg) n_method = method[0] + (method[1] << 8) + (method[2] << 16) + (method[3] << 24); n_method |= 0x20202020; - n_method &= ((method_len < 4) * (1U << method_len * 8) - 1); + if(method_len < 4) { + n_method &= ((1U << (method_len * 8)) - 1); + } /* accept only GET or POST */ if ((n_method == N_HTTP_GET) || ((n_method == N_HTTP_POST) && (method_len == HTTP_POST_LEN))) {

1 0

git:master:e6e04f4c: xcap_client: removed unused api function get_elem()
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: e6e04f4c96e5fdd7a3a90f265fd6cb7470f1135b URL: https://github.com/kamailio/kamailio/commit/e6e04f4c96e5fdd7a3a90f265fd6cb7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T12:15:55+02:00 xcap_client: removed unused api function get_elem() --- Modified: src/modules/xcap_client/xcap_functions.c Modified: src/modules/xcap_client/xcap_functions.h --- Diff: https://github.com/kamailio/kamailio/commit/e6e04f4c96e5fdd7a3a90f265fd6cb7… Patch: https://github.com/kamailio/kamailio/commit/e6e04f4c96e5fdd7a3a90f265fd6cb7… --- diff --git a/src/modules/xcap_client/xcap_functions.c b/src/modules/xcap_client/xcap_functions.c index 1b2e6b457f..6b875b17d0 100644 --- a/src/modules/xcap_client/xcap_functions.c +++ b/src/modules/xcap_client/xcap_functions.c @@ -50,7 +50,6 @@ int bind_xcap(xcap_api_t* api) LM_ERR("Invalid parameter value\n"); return -1; } - api->get_elem= xcapGetElem; api->int_node_sel= xcapInitNodeSel; api->add_step= xcapNodeSelAddStep; api->add_terminal= xcapNodeSelAddTerminal; @@ -455,39 +454,6 @@ char* get_xcap_path(xcap_get_req_t req) return NULL; } -/* xcap_root must be a NULL terminated string */ - -char* xcapGetElem(xcap_get_req_t req, char** etag) -{ - char* path= NULL; - char* stream= NULL; - - path= get_xcap_path(req); - if(path== NULL) - { - LM_ERR("while constructing xcap path\n"); - return NULL; - } - - stream= send_http_get(path, req.port, req.etag, req.match_type, etag); - if(stream== NULL) - { - LM_DBG("the serched element was not found\n"); - } - - if(etag== NULL) - { - LM_ERR("no etag found\n"); - pkg_free(stream); - stream= NULL; - } - - if(path) - pkg_free(path); - - return stream; -} - size_t get_xcap_etag( void *ptr, size_t size, size_t nmemb, void *stream) { int len= 0; diff --git a/src/modules/xcap_client/xcap_functions.h b/src/modules/xcap_client/xcap_functions.h index 8750aeae53..44ae635972 100644 --- a/src/modules/xcap_client/xcap_functions.h +++ b/src/modules/xcap_client/xcap_functions.h @@ -103,11 +103,6 @@ xcap_node_sel_t* xcapNodeSelAddTerminal(xcap_node_sel_t* curr_sel, typedef xcap_node_sel_t* (*xcap_nodeSel_add_terminal_t)(xcap_node_sel_t* curr_sel, char* attr_sel, char* namespace_sel, char* extra_sel ); -/* generical function to get an element from an xcap server */ -char* xcapGetElem(xcap_get_req_t req, char** etag); - -typedef char* (*xcap_get_elem_t)(xcap_get_req_t req, char** etag); - void xcapFreeNodeSel(xcap_node_sel_t* node); typedef void (*xcap_nodeSel_free_t)(xcap_node_sel_t* node); @@ -118,7 +113,6 @@ char* xcapGetNewDoc(xcap_get_req_t req, str user, str domain); typedef char* (*xcapGetNewDoc_t)(xcap_get_req_t req, str user, str domain); typedef struct xcap_api { - xcap_get_elem_t get_elem; xcap_nodeSel_init_t int_node_sel; xcap_nodeSel_add_step_t add_step; xcap_nodeSel_add_terminal_t add_terminal;

1 0

git:master:8147009b: xcap_client: handle return code for strchr()
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 8147009b34639304fb75d4f6c39269c49ee385ca URL: https://github.com/kamailio/kamailio/commit/8147009b34639304fb75d4f6c39269c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T12:15:09+02:00 xcap_client: handle return code for strchr() --- Modified: src/modules/xcap_client/xcap_client.c --- Diff: https://github.com/kamailio/kamailio/commit/8147009b34639304fb75d4f6c39269c… Patch: https://github.com/kamailio/kamailio/commit/8147009b34639304fb75d4f6c39269c… --- diff --git a/src/modules/xcap_client/xcap_client.c b/src/modules/xcap_client/xcap_client.c index e96511651d..0b8a707d8d 100644 --- a/src/modules/xcap_client/xcap_client.c +++ b/src/modules/xcap_client/xcap_client.c @@ -310,24 +310,33 @@ int parse_doc_url(str doc_url, char** serv_addr, xcap_doc_sel_t* doc_sel) char* sl, *str_type; sl= strchr(doc_url.s, '/'); + if(sl==NULL) { + return -1; + } *sl= '\0'; *serv_addr= doc_url.s; sl++; doc_sel->auid.s= sl; sl= strchr(sl, '/'); + if(sl==NULL) { + return -1; + } doc_sel->auid.len= sl- doc_sel->auid.s; sl++; str_type= sl; sl= strchr(sl, '/'); + if(sl==NULL) { + return -1; + } *sl= '\0'; - if(strcasecmp(str_type, "users")== 0) + if(strcasecmp(str_type, "users")== 0) { doc_sel->type= USERS_TYPE; - else - if(strcasecmp(str_type, "group")== 0) + } else if(strcasecmp(str_type, "group")== 0) { doc_sel->type= GLOBAL_TYPE; + } sl++;

1 0

git:master:4ba40243: stun: link attribute when calling stun_parse_body() with an existing list
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 4ba402434449ec9cb426d5200b12c5cec4d07ab4 URL: https://github.com/kamailio/kamailio/commit/4ba402434449ec9cb426d5200b12c5c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T11:56:57+02:00 stun: link attribute when calling stun_parse_body() with an existing list --- Modified: src/modules/stun/kam_stun.c --- Diff: https://github.com/kamailio/kamailio/commit/4ba402434449ec9cb426d5200b12c5c… Patch: https://github.com/kamailio/kamailio/commit/4ba402434449ec9cb426d5200b12c5c… --- diff --git a/src/modules/stun/kam_stun.c b/src/modules/stun/kam_stun.c index 8257fbab4c..350317b0e7 100644 --- a/src/modules/stun/kam_stun.c +++ b/src/modules/stun/kam_stun.c @@ -336,8 +336,10 @@ static int stun_parse_body( } if (*unknown == NULL) { *unknown = body = tmp_unknown; - } - else { + } else { + if(body==NULL) { + body = *unknown; + } body->next = tmp_unknown; body = body->next; }

1 0

git:master:37129325: presence_xml: fixed misleading error message
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 371293257d000c004f78068f15a4184df3dbd57b URL: https://github.com/kamailio/kamailio/commit/371293257d000c004f78068f15a4184… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T12:14:18+02:00 presence_xml: fixed misleading error message --- Modified: src/modules/presence_xml/presence_xml.c --- Diff: https://github.com/kamailio/kamailio/commit/371293257d000c004f78068f15a4184… Patch: https://github.com/kamailio/kamailio/commit/371293257d000c004f78068f15a4184… --- diff --git a/src/modules/presence_xml/presence_xml.c b/src/modules/presence_xml/presence_xml.c index da0e056e3e..0f221852d7 100644 --- a/src/modules/presence_xml/presence_xml.c +++ b/src/modules/presence_xml/presence_xml.c @@ -242,7 +242,7 @@ static int mod_init(void) xcap_GetNewDoc= xcap_api.getNewDoc; if(xcap_GetNewDoc== NULL) { - LM_ERR("can't import get_elem from xcap_client module\n"); + LM_ERR("can't import getNewDoc from xcap_client module\n"); return -1; } @@ -559,4 +559,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_presence_xml_exports); return 0; -} \ No newline at end of file +}

1 0

git:master:f75eba63: statsd: simplified error handling inside statsd_connect()
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: f75eba63a1f0176adc8cd38846a0d1943471e10c URL: https://github.com/kamailio/kamailio/commit/f75eba63a1f0176adc8cd38846a0d19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T11:44:21+02:00 statsd: simplified error handling inside statsd_connect() --- Modified: src/modules/statsd/lib_statsd.c --- Diff: https://github.com/kamailio/kamailio/commit/f75eba63a1f0176adc8cd38846a0d19… Patch: https://github.com/kamailio/kamailio/commit/f75eba63a1f0176adc8cd38846a0d19… --- diff --git a/src/modules/statsd/lib_statsd.c b/src/modules/statsd/lib_statsd.c index bbda181d6a..79d99fcfbd 100644 --- a/src/modules/statsd/lib_statsd.c +++ b/src/modules/statsd/lib_statsd.c @@ -29,25 +29,24 @@ bool statsd_connect(void){ rc = getaddrinfo( statsd_connection.ip, statsd_connection.port, NULL, &serverAddr); - if (rc != 0) + if (rc != 0 || serverAddr == NULL) { - LM_ERR( - "Statsd: could not initiate server information (%s)\n", + LM_ERR("Statsd: could not initiate server information (%s)\n", gai_strerror(rc)); - if(serverAddr) freeaddrinfo(serverAddr); + if(serverAddr) freeaddrinfo(serverAddr); return false; } statsd_connection.sock = socket(serverAddr->ai_family, SOCK_DGRAM, IPPROTO_UDP); if (statsd_connection.sock < 0 ){ LM_ERR("Statsd: could not create a socket for statsd connection\n"); - if(serverAddr) freeaddrinfo(serverAddr); + freeaddrinfo(serverAddr); return false; } - rc = connect( - statsd_connection.sock, serverAddr->ai_addr, serverAddr->ai_addrlen); - freeaddrinfo(serverAddr); + rc = connect(statsd_connection.sock, serverAddr->ai_addr, + serverAddr->ai_addrlen); + freeaddrinfo(serverAddr); if (rc < 0){ LM_ERR("Statsd: could not initiate a connect to statsd\n"); return false;

1 0

git:master:711a5600: statistics: free vars in case of error in fixup function
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 711a5600330793b2ca787ce451f2ad48620dd639 URL: https://github.com/kamailio/kamailio/commit/711a5600330793b2ca787ce451f2ad4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T11:38:51+02:00 statistics: free vars in case of error in fixup function --- Modified: src/modules/statistics/statistics.c --- Diff: https://github.com/kamailio/kamailio/commit/711a5600330793b2ca787ce451f2ad4… Patch: https://github.com/kamailio/kamailio/commit/711a5600330793b2ca787ce451f2ad4… --- diff --git a/src/modules/statistics/statistics.c b/src/modules/statistics/statistics.c index 499b4198ba..c5ace8c185 100644 --- a/src/modules/statistics/statistics.c +++ b/src/modules/statistics/statistics.c @@ -135,6 +135,7 @@ static int fixup_stat(void** param, int param_no) if (s.s[0]=='$') { if (fixup_pvar_null(param, 1)!=0) { LM_ERR("invalid pv %s as parameter\n",s.s); + pkg_free(sopv); return E_CFG; } sopv->pv = (pv_spec_t*)(*param); @@ -143,10 +144,10 @@ static int fixup_stat(void** param, int param_no) sopv->stat = get_stat( &s ); if (sopv->stat==0) { LM_ERR("variable <%s> not defined\n", s.s); + pkg_free(sopv); return E_CFG; } } - pkg_free(s.s); *param=(void*)sopv; return 0; } else if (param_no==2) { @@ -160,6 +161,7 @@ static int fixup_stat(void** param, int param_no) if (s.s[0] == '$') { if (fixup_pvar_pvar(param, 2) != 0) { LM_ERR("invalid pv %s as parameter\n",s.s); + pkg_free(lopv); return E_CFG; } lopv->pv = (pv_spec_t*) (*param); @@ -179,13 +181,14 @@ static int fixup_stat(void** param, int param_no) if (err==0){ if (n==0 && (s.s[0]!='$')) { //we can't check the value of the pvar so have to ignore this check if it is a pvar LM_ERR("update with 0 has no sense\n"); + pkg_free(lopv); return E_CFG; } - pkg_free(s.s); *param=(void*)lopv; return 0; }else{ LM_ERR("bad update number <%s>\n",(char*)(*param)); + pkg_free(lopv); return E_CFG; } }

1 0

git:master:823bad5f: uid_uri_db: safer check for accessing to header
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 823bad5f3aad5c77ff9986ecf4be2517df043788 URL: https://github.com/kamailio/kamailio/commit/823bad5f3aad5c77ff9986ecf4be251… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T08:22:24+02:00 uid_uri_db: safer check for accessing to header --- Modified: src/modules/uid_uri_db/uid_uri_db_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/823bad5f3aad5c77ff9986ecf4be251… Patch: https://github.com/kamailio/kamailio/commit/823bad5f3aad5c77ff9986ecf4be251… --- diff --git a/src/modules/uid_uri_db/uid_uri_db_mod.c b/src/modules/uid_uri_db/uid_uri_db_mod.c index 4e5771f493..dba6454b81 100644 --- a/src/modules/uid_uri_db/uid_uri_db_mod.c +++ b/src/modules/uid_uri_db/uid_uri_db_mod.c @@ -238,14 +238,14 @@ static int lookup_uid(struct sip_msg* msg, long id, int store) } else if (id == USE_TO) { get_to_did(&did, msg); if (!msg->to) { - if (parse_headers( msg, HDR_TO_F, 0 )==-1) { + if (parse_headers(msg, HDR_TO_F, 0)==-1 || !msg->to) { ERR("unable to parse To header\n"); return -1; } } to = get_to(msg); if (!to) { - LOG(L_ERR, "uri_db:lookup_uid: Unable to get To username\n"); + LOG(L_ERR, "uri_db:lookup_uid: Unable to get To body\n"); return -1; } if (parse_uri(to->uri.s, to->uri.len, &puri) < 0) {

1 0

git:master:6997738a: sst: add 0 after memcpy
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 6997738a7098ef56becfd40cb6e7c7864d1975f0 URL: https://github.com/kamailio/kamailio/commit/6997738a7098ef56becfd40cb6e7c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-24T08:26:38+02:00 sst: add 0 after memcpy --- Modified: src/modules/sst/sst_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/6997738a7098ef56becfd40cb6e7c78… Patch: https://github.com/kamailio/kamailio/commit/6997738a7098ef56becfd40cb6e7c78… --- diff --git a/src/modules/sst/sst_handlers.c b/src/modules/sst/sst_handlers.c index ba1d4928b0..be55eb8883 100644 --- a/src/modules/sst/sst_handlers.c +++ b/src/modules/sst/sst_handlers.c @@ -791,11 +791,12 @@ static int append_header(struct sip_msg *msg, const char *header) return(1); } len = strlen(header); - if ((s = (char *)pkg_malloc(len)) == 0) { + if ((s = (char *)pkg_malloc(len+1)) == 0) { LM_ERR("No more pkg memory. (size requested = %d)\n", len); return(1); } memcpy(s, header, len); + s[len] = '\0'; if (insert_new_lump_before(anchor, s, len, 0) == 0) { LM_ERR("failed to insert lump\n"); pkg_free(s);

1 0

git:master:021e49d6: tm: refactored error handling for eval_uac_routing()
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 021e49d6293cc156cd85791dfc9d59307e62fba0 URL: https://github.com/kamailio/kamailio/commit/021e49d6293cc156cd85791dfc9d593… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-23T10:08:47+02:00 tm: refactored error handling for eval_uac_routing() --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/021e49d6293cc156cd85791dfc9d593… Patch: https://github.com/kamailio/kamailio/commit/021e49d6293cc156cd85791dfc9d593… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 3bd76b32fe..c4ab254076 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -912,7 +912,6 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, int is_req; struct sip_uri puri; static size_t chklen; - int ret = -1; /* parse the retr. buffer */ memset(&orig_inv, 0, sizeof(struct sip_msg)); @@ -931,14 +930,14 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, /* the bug is at message assembly */ LM_BUG("failed to parse INVITE retr. buffer and/or extract 'To' HF:" "\n%.*s\n", (int)orig_inv.len, orig_inv.buf); - goto end; + goto error; } if (((struct to_body *)orig_inv.to->parsed)->tag_value.len) { LM_DBG("building ACK for in-dialog INVITE (using RS in orig. INV.)\n"); if (parse_headers(&orig_inv, HDR_EOH_F, 0) < 0) { LM_BUG("failed to parse INVITE retr. buffer to EOH:" "\n%.*s\n", (int)orig_inv.len, orig_inv.buf); - goto end; + goto error; } sipmsg = &orig_inv; is_req = 1; @@ -951,7 +950,7 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, /* extract the route set */ if (get_uac_rs(sipmsg, is_req, &rtset) < 0) { LM_ERR("failed to extract route set.\n"); - goto end; + goto error; } if (! rtset) { /* No routes */ @@ -961,7 +960,7 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, if (parse_uri(rtset->ptr->nameaddr.uri.s, rtset->ptr->nameaddr.uri.len, &puri) < 0) { LM_ERR("failed to parse first route in set.\n"); - goto end; + goto error; } if (puri.lr.s) { /* Next hop is loose router */ @@ -993,7 +992,7 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, } else { LM_ERR("failed to establish what kind of router the next " "hop is.\n"); - goto end; + goto error; } break; case F_RB_NH_LOOSE: @@ -1028,8 +1027,7 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, } else { prev_t->next = NULL; } - ret = -1; - goto end; + goto error; } /* this way, .free_rr is also set to 0 (!!!) */ memset(t, 0, chklen); @@ -1054,19 +1052,21 @@ static int eval_uac_routing(sip_msg_t *rpl, const struct retr_buf *inv_rb, #ifdef EXTRA_DEBUG abort(); #else - goto end; + goto error; #endif } } *list = rtset; + free_sip_msg(&orig_inv); /* all went well */ - ret = 0; -end: + return 0; + +error: free_sip_msg(&orig_inv); - if (ret < 0) + if (rtset) free_rte_list(rtset); - return ret; + return -1; } /*

1 0

git:master:dd0c6fb5: msilo: reorganized tests to free db_res and build of extra headers
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: dd0c6fb586a61cb7e2eed1093ccf8f5158761ae3 URL: https://github.com/kamailio/kamailio/commit/dd0c6fb586a61cb7e2eed1093ccf8f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-23T09:42:21+02:00 msilo: reorganized tests to free db_res and build of extra headers --- Modified: src/modules/msilo/msfuncs.c Modified: src/modules/msilo/msilo.c --- Diff: https://github.com/kamailio/kamailio/commit/dd0c6fb586a61cb7e2eed1093ccf8f5… Patch: https://github.com/kamailio/kamailio/commit/dd0c6fb586a61cb7e2eed1093ccf8f5… --- diff --git a/src/modules/msilo/msfuncs.c b/src/modules/msilo/msfuncs.c index 43bc82ce60..5262a81159 100644 --- a/src/modules/msilo/msfuncs.c +++ b/src/modules/msilo/msfuncs.c @@ -211,30 +211,30 @@ int m_build_headers(str *buf, str ctype, str contact, time_t date, str extra) if(date > 0) { lenDate = timetToSipDateStr(date,strDate,48); - strncpy(p, strDate, lenDate); + memcpy(p, strDate, lenDate); p += lenDate; } if(ctype.len > 0) { - strncpy(p, "Content-Type: ", 14); + memcpy(p, "Content-Type: ", 14); p += 14; - strncpy(p, ctype.s, ctype.len); + memcpy(p, ctype.s, ctype.len); p += ctype.len; - strncpy(p, CRLF, CRLF_LEN); + memcpy(p, CRLF, CRLF_LEN); p += CRLF_LEN; } if(contact.len > 0 && ms_add_contact) { - strncpy(p, CONTACT_PREFIX, CONTACT_PREFIX_LEN); + memcpy(p, CONTACT_PREFIX, CONTACT_PREFIX_LEN); p += CONTACT_PREFIX_LEN; - strncpy(p, contact.s, contact.len); + memcpy(p, contact.s, contact.len); p += contact.len; - strncpy(p, CONTACT_SUFFIX, CONTACT_SUFFIX_LEN); + memcpy(p, CONTACT_SUFFIX, CONTACT_SUFFIX_LEN); p += CONTACT_SUFFIX_LEN; } if (extra.len > 0) { - strncpy(p, extra.s, extra.len); + memcpy(p, extra.s, extra.len); p += extra.len; } buf->len = p - buf->s; @@ -263,18 +263,18 @@ int m_build_body(str *body, time_t date, str msg, time_t sdate) { if(sdate!=0) { - strncpy(p, "[Reminder message - ", 20); + memcpy(p, "[Reminder message - ", 20); p += 20; - strncpy(p, ctime(&sdate), 24); + memcpy(p, ctime(&sdate), 24); p += 24; *p++ = ']'; } else { - strncpy(p, "[Offline message - ", 19); + memcpy(p, "[Offline message - ", 19); p += 19; - strncpy(p, ctime(&date), 24); + memcpy(p, ctime(&date), 24); p += 24; *p++ = ']'; diff --git a/src/modules/msilo/msilo.c b/src/modules/msilo/msilo.c index d231ae7e6e..f62557ce2a 100644 --- a/src/modules/msilo/msilo.c +++ b/src/modules/msilo/msilo.c @@ -1039,8 +1039,11 @@ static int m_dump(struct sip_msg* msg, str* owner_s) } if (msilo_dbf.query(db_con,db_keys,db_ops,db_vals,db_cols,db_no_keys, - db_no_cols, ob_key, &db_res) < 0) { + db_no_cols, ob_key, &db_res) < 0 || db_res==NULL) { LM_ERR("failed to query database\n"); + if (db_res!=NULL && msilo_dbf.free_result(db_con, db_res) < 0) { + LM_ERR("failed to free the query result\n"); + } goto error; } @@ -1071,13 +1074,13 @@ static int m_dump(struct sip_msg* msg, str* owner_s) (time_t)RES_ROWS(db_res)[i].values[5/*inc time*/].val.int_val; if (ms_extra_hdrs != NULL) { - if (fixup_get_svalue(msg, (gparam_p)*ms_extra_hdrs_sp, - &extra_hdrs_str) != 0) { - if (msilo_dbf.free_result(db_con, db_res) < 0) - LM_ERR("failed to free the query result\n"); - LM_ERR("unable to get extra_hdrs value\n"); - goto error; - } + if(fixup_get_svalue(msg, (gparam_p)*ms_extra_hdrs_sp, + &extra_hdrs_str) != 0) { + if(msilo_dbf.free_result(db_con, db_res) < 0) + LM_ERR("failed to free the query result\n"); + LM_ERR("unable to get extra_hdrs value\n"); + goto error; + } } else { extra_hdrs_str.len = 0; } @@ -1153,7 +1156,7 @@ static int m_dump(struct sip_msg* msg, str* owner_s) * Free the result because we don't need it * anymore */ - if ((db_res !=NULL) && msilo_dbf.free_result(db_con, db_res) < 0) + if (msilo_dbf.free_result(db_con, db_res) < 0) LM_ERR("failed to free result of query\n"); return 1;

1 0

git:master:9c34b68e: presence_conference: free xml array in case of error
by Daniel-Constantin Mierla 24 Jul '17

24 Jul '17

Module: kamailio Branch: master Commit: 9c34b68ee840880dd6be37694de8e8255f8bfb45 URL: https://github.com/kamailio/kamailio/commit/9c34b68ee840880dd6be37694de8e82… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-23T09:58:16+02:00 presence_conference: free xml array in case of error --- Modified: src/modules/presence_conference/notify_body.c --- Diff: https://github.com/kamailio/kamailio/commit/9c34b68ee840880dd6be37694de8e82… Patch: https://github.com/kamailio/kamailio/commit/9c34b68ee840880dd6be37694de8e82… --- diff --git a/src/modules/presence_conference/notify_body.c b/src/modules/presence_conference/notify_body.c index ff27946fbe..78108dd69e 100644 --- a/src/modules/presence_conference/notify_body.c +++ b/src/modules/presence_conference/notify_body.c @@ -92,7 +92,7 @@ str* agregate_xmls(str* pres_user, str* pres_domain, str** body_array, int n, in xmlNsPtr namespace = NULL; xmlNodePtr p_root= NULL; - xmlDocPtr* xml_array ; + xmlDocPtr* xml_array = NULL ; xmlNodePtr node = NULL; str *body= NULL; char buf[MAX_URI_SIZE+1]; @@ -129,8 +129,7 @@ str* agregate_xmls(str* pres_user, str* pres_domain, str** body_array, int n, in if(j == 0) /* no body */ { - if(xml_array) - pkg_free(xml_array); + pkg_free(xml_array); return NULL; } @@ -142,7 +141,7 @@ str* agregate_xmls(str* pres_user, str* pres_domain, str** body_array, int n, in /* create the new NOTIFY body */ if ( (pres_user->len + pres_domain->len + 1) > MAX_URI_SIZE ) { LM_ERR("entity URI too long, maximum=%d\n", MAX_URI_SIZE); - return NULL; + goto error; } memcpy(buf, pres_user->s, pres_user->len); buf[pres_user->len] = '@';

1 0

git:master:65ac6de1: mediaproxy: handle return pointer values
by Daniel-Constantin Mierla 23 Jul '17

23 Jul '17

Module: kamailio Branch: master Commit: 65ac6de1aebd6143c44f35ef28f46c2cd3a56723 URL: https://github.com/kamailio/kamailio/commit/65ac6de1aebd6143c44f35ef28f46c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-23T09:01:07+02:00 mediaproxy: handle return pointer values --- Modified: src/modules/mediaproxy/mediaproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/65ac6de1aebd6143c44f35ef28f46c2… Patch: https://github.com/kamailio/kamailio/commit/65ac6de1aebd6143c44f35ef28f46c2… --- diff --git a/src/modules/mediaproxy/mediaproxy.c b/src/modules/mediaproxy/mediaproxy.c index 71c365e07c..f1fa9613b0 100644 --- a/src/modules/mediaproxy/mediaproxy.c +++ b/src/modules/mediaproxy/mediaproxy.c @@ -809,12 +809,14 @@ static str get_sdp_line_separator(str *sdp) { char *ptr, *end_ptr, *sdp_end; - str separator; + str separator = STR_NULL; sdp_end = sdp->s + sdp->len; ptr = find_line_starting_with(sdp, "v=", False); + if(ptr==NULL) { return separator; } end_ptr = findendline(ptr, sdp_end-ptr); + if(end_ptr==NULL) { return separator; } separator.s = ptr = end_ptr; while ((*ptr=='\n' || *ptr=='\r') && ptr<sdp_end) ptr++; @@ -1329,7 +1331,7 @@ insert_element(struct sip_msg *msg, char *position, char *element) len = strlen(element); - buf = pkg_malloc(len); + buf = pkg_malloc(len+1); if (!buf) { LM_ERR("out of memory\n"); return False; @@ -1343,6 +1345,7 @@ insert_element(struct sip_msg *msg, char *position, char *element) } memcpy(buf, element, len); + buf[len] = '\0'; if (insert_new_lump_after(anchor, buf, len, 0)==0) { LM_ERR("failed to insert new element\n");

1 0

git:master:0efa76d8: json: remove use of deprecated macro is_error()
by Daniel-Constantin Mierla 23 Jul '17

23 Jul '17

Module: kamailio Branch: master Commit: 0efa76d80e159fd2a7516388fe2405ad4fb6c5b6 URL: https://github.com/kamailio/kamailio/commit/0efa76d80e159fd2a7516388fe2405a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-23T08:59:43+02:00 json: remove use of deprecated macro is_error() --- Modified: src/modules/json/json_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/0efa76d80e159fd2a7516388fe2405a… Patch: https://github.com/kamailio/kamailio/commit/0efa76d80e159fd2a7516388fe2405a… --- diff --git a/src/modules/json/json_funcs.c b/src/modules/json/json_funcs.c index 935877f651..2de892154b 100644 --- a/src/modules/json/json_funcs.c +++ b/src/modules/json/json_funcs.c @@ -56,9 +56,8 @@ int json_get_field(struct sip_msg* msg, char* json, char* field, char* dst) j = json_tokener_parse(json_s.s); - if (is_error(j)) { + if (j==NULL) { LM_ERR("empty or invalid JSON\n"); - if(j!=NULL) json_object_put(j); return -1; } @@ -74,6 +73,6 @@ int json_get_field(struct sip_msg* msg, char* json, char* field, char* dst) ret = -1; } - if(j!=NULL) json_object_put(j); + json_object_put(j); return ret; }

1 0

[kamailio/kamailio] tls mod cannot be loaded on Alpine Linux (#1188)
by sergey-safarov 22 Jul '17

22 Jul '17

### Description I want use kamailio on Alpine linux dist. All looks fine except tls module. During config file checking i got errors ``` / # / # vi /etc/kamailio/kamailio.cfg / # kamailio -c -f /etc/kamailio/kamailio.cfg loading modules under config path: /usr/lib/kamailio/modules/ 0(15) ERROR: <core> [core/sr_module.c:570]: load_module(): could not find module <mi_fifo> in </usr/lib/kamailio/modules/> 0(15) CRITICAL: <core> [core/cfg.y:3400]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 218, column 12-23: failed to load module 0(15) ERROR: <core> [core/sr_module.c:570]: load_module(): could not find module <mi_rpc> in </usr/lib/kamailio/modules/> 0(15) CRITICAL: <core> [core/cfg.y:3400]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 234, column 12-22: failed to load module 0(15) ERROR: <core> [core/sr_module.c:582]: load_module(): could not open module </usr/lib/kamailio/modules/tls.so>: Error relocating /usr/lib/kamailio/modules/tls.so: EC_KEY_new_by_curve_name: symbol not found 0(15) CRITICAL: <core> [core/cfg.y:3400]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 265, column 12-19: failed to load module 0(15) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <mi_fifo> found 0(15) CRITICAL: <core> [core/cfg.y:3403]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 285, column 67: Can't set module parameter 0(15) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <tls> found 0(15) CRITICAL: <core> [core/cfg.y:3403]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 411, column 50: Can't set module parameter ERROR: bad config file (5 errors) 0(15) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized / # / # ``` Error load_module(): could not open module </usr/lib/kamailio/modules/tls.so>: Error relocating /usr/lib/kamailio/modules/tls.so: EC_KEY_new_by_curve_name: symbol not found #### Reproduction docker run -it alpine sh apk --no-cache add alpine-sdk linux-headers bison flex libressl-dev cd kamailio sed -i -e 's/0x10100000L/0x10100000L || defined(LIBRESSL_VERSION_NUMBER)/' src/modules/tls/tls_locking.c make include_modules="tls" cfg make all make install sed -i '1s/^/#!define WITH_TLS\n/' /usr/local/etc/kamailio/kamailio.cfg /usr/local/sbin/kamailio -c -f /usr/local/etc/kamailio/kamailio.cfg #### Log Messages ``` @8bdc47c389e6:/usr/local/etc/kamailio$ /usr/local/sbin/kamailio -c -f /usr/local/etc/kamailio/kamailio.cfg 0(22421) ERROR: <core> [core/sr_module.c:582]: load_module(): could not open module </usr/local/lib64/kamailio/modules/tls.so>: Error relocating /usr/local/lib64/kamailio/modules/tls.so: SSL_CTX_set_min_proto_version: symbol not found 0(22421) CRITICAL: <core> [core/cfg.y:3426]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 276, column 12-19: failed to load module 0(22421) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <tls> found 0(22421) CRITICAL: <core> [core/cfg.y:3429]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 426, column 60: Can't set module parameter ERROR: bad config file (2 errors) 0(22421) INFO: <core> [core/sctp_core.c:53]: sctp_core_destroy(): SCTP API not initialized ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` @8bdc47c389e6:/usr/local/etc/kamailio$ /usr/local/sbin/kamailio -v version: kamailio 5.1.0-dev5 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 20:55:58 Jul 21 2017 with gcc 6.2.1 @8bdc47c389e6:/usr/local/etc/kamailio$ ``` * **Operating System**: Alpine linux 3.6 ``` @8bdc47c389e6:/usr/local/etc/kamailio$ uname -a Linux 8bdc47c389e6 3.10.0-514.16.1.el7.x86_64 #1 SMP Wed Apr 12 15:04:24 UTC 2017 x86_64 Linux``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1188

2 2

git:master:5f9eba3e: memcached: handle error cases and alloc enough for null termination
by Daniel-Constantin Mierla 22 Jul '17

22 Jul '17

Module: kamailio Branch: master Commit: 5f9eba3eb42cdb8a5c2ec840cec29757d480e136 URL: https://github.com/kamailio/kamailio/commit/5f9eba3eb42cdb8a5c2ec840cec2975… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-22T08:35:01+02:00 memcached: handle error cases and alloc enough for null termination --- Modified: src/modules/memcached/mcd_var.c Modified: src/modules/memcached/memcached.c --- Diff: https://github.com/kamailio/kamailio/commit/5f9eba3eb42cdb8a5c2ec840cec2975… Patch: https://github.com/kamailio/kamailio/commit/5f9eba3eb42cdb8a5c2ec840cec2975… --- diff --git a/src/modules/memcached/mcd_var.c b/src/modules/memcached/mcd_var.c index a55f57ba19..442cf219e3 100644 --- a/src/modules/memcached/mcd_var.c +++ b/src/modules/memcached/mcd_var.c @@ -442,6 +442,7 @@ int pv_parse_mcd_name(pv_spec_p sp, str *in) { if(pv_parse_format(in, &tmp) || tmp==NULL) { LM_ERR("wrong format [%.*s]\n", in->len, in->s); + if(tmp) pkg_free(tmp); return -1; } diff --git a/src/modules/memcached/memcached.c b/src/modules/memcached/memcached.c index be50316ceb..b85d8191ee 100644 --- a/src/modules/memcached/memcached.c +++ b/src/modules/memcached/memcached.c @@ -233,6 +233,7 @@ static int mod_init(void) { char *server, *port; unsigned int len = 0; memcached_return rc; + struct memcached_server_st *svt; if ((port = strchr(mcd_srv_str, ':')) != NULL) { port = port + 1; @@ -243,7 +244,7 @@ static int mod_init(void) { len = strlen(mcd_srv_str) ; } - server = pkg_malloc(len); + server = pkg_malloc(len+1); if (server == NULL) { PKG_MEM_ERROR; return -1; @@ -255,6 +256,7 @@ static int mod_init(void) { memcached_h = memcached_create(NULL); if (memcached_h == NULL) { LM_ERR("could not create memcached structure\n"); + pkg_free(server); return -1; } LM_DBG("allocated new server handle at %p", memcached_h); @@ -276,16 +278,28 @@ static int mod_init(void) { LM_DBG("memory manager callbacks set\n"); } else { LM_ERR("memory manager callbacks not set, returned %s.\n", memcached_strerror(memcached_h, rc)); + pkg_free(server); return -1; } } else { LM_INFO("Use system memory manager for memcached client library\n"); } - servers = memcached_server_list_append(servers, server, atoi(port), &rc); + svt = memcached_server_list_append(servers, server, atoi(port), &rc); + if(svt==NULL) { + LM_ERR("failed to append server\n"); + if(servers) { + memcached_server_list_free(servers); + servers = NULL; + } + pkg_free(server); + return -1; + } + servers = svt; if (memcached_behavior_set(memcached_h, MEMCACHED_BEHAVIOR_CONNECT_TIMEOUT, mcd_timeout) != MEMCACHED_SUCCESS) { LM_ERR("could not set server connection timeout\n"); + pkg_free(server); return -1; } rc = memcached_server_push(memcached_h, servers); @@ -293,6 +307,7 @@ static int mod_init(void) { LM_DBG("added server list to structure\n"); } else { LM_ERR("attempt to add server list to structure returned %s.\n", memcached_strerror(memcached_h, rc)); + pkg_free(server); return -1; }

1 0

git:master:449d4351: nat_traversal: handle return values for errors
by Daniel-Constantin Mierla 22 Jul '17

22 Jul '17

Module: kamailio Branch: master Commit: 449d435194338a4f3acf079774adcbef7ad7b794 URL: https://github.com/kamailio/kamailio/commit/449d435194338a4f3acf079774adcbe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-22T08:34:01+02:00 nat_traversal: handle return values for errors --- Modified: src/modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/449d435194338a4f3acf079774adcbe… Patch: https://github.com/kamailio/kamailio/commit/449d435194338a4f3acf079774adcbe… --- diff --git a/src/modules/nat_traversal/nat_traversal.c b/src/modules/nat_traversal/nat_traversal.c index 8bd4adde65..d3c6c95057 100644 --- a/src/modules/nat_traversal/nat_traversal.c +++ b/src/modules/nat_traversal/nat_traversal.c @@ -1573,6 +1573,10 @@ send_keepalive(NAT_Contact *contact) lport = 0; lproto = PROTO_NONE; hostent = sip_resolvehost(&nat_ip, &lport, &lproto); + if(hostent==NULL) { + LM_ERR("sip resolve host failed\n"); + return; + } hostent2su(&dst.to, hostent, 0, nat_port); dst.proto=PROTO_UDP; dst.send_sock=contact->socket; @@ -1900,7 +1904,9 @@ reply_filter(struct sip_msg *reply) static str prefix = {NULL, 0}; str call_id; - parse_headers(reply, HDR_VIA2_F, 0); + if(parse_headers(reply, HDR_VIA2_F, 0)<0) { + LM_DBG("second via not parsed\n"); + } if (reply->via2) return 1;

1 0

git:master:1891dcb9: pdt: reorder checks to avoid null access
by Daniel-Constantin Mierla 22 Jul '17

22 Jul '17

Module: kamailio Branch: master Commit: 1891dcb958100b5383f40278c4d675474d309df4 URL: https://github.com/kamailio/kamailio/commit/1891dcb958100b5383f40278c4d6754… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-22T08:33:22+02:00 pdt: reorder checks to avoid null access --- Modified: src/modules/pdt/pdt.c --- Diff: https://github.com/kamailio/kamailio/commit/1891dcb958100b5383f40278c4d6754… Patch: https://github.com/kamailio/kamailio/commit/1891dcb958100b5383f40278c4d6754… --- diff --git a/src/modules/pdt/pdt.c b/src/modules/pdt/pdt.c index 6505d8a3d5..09eacace4f 100644 --- a/src/modules/pdt/pdt.c +++ b/src/modules/pdt/pdt.c @@ -617,21 +617,25 @@ int pdt_load_db(void) { /* check for NULL values ?!?! */ sdomain.s = (char*)(RES_ROWS(db_res)[i].values[0].val.string_val); - sdomain.len = strlen(sdomain.s); - p.s = (char*)(RES_ROWS(db_res)[i].values[1].val.string_val); - p.len = strlen(p.s); - d.s = (char*)(RES_ROWS(db_res)[i].values[2].val.string_val); + + if(p.s==NULL || d.s==NULL || sdomain.s==NULL) + { + LM_ERR("Error - bad values in db\n"); + continue; + } + + sdomain.len = strlen(sdomain.s); + p.len = strlen(p.s); d.len = strlen(d.s); - if(p.s==NULL || d.s==NULL || sdomain.s==NULL || - p.len<=0 || d.len<=0 || sdomain.len<=0) + if(p.len<=0 || d.len<=0 || sdomain.len<=0) { LM_ERR("Error - bad values in db\n"); continue; } - + if(pdt_check_domain!=0 && _ptree_new!=NULL && pdt_check_pd(_ptree_new, &sdomain, &p, &d)==1) {

1 0

git:master:9136ce80: xhttp: proper check for return of add lump rpl
by Daniel-Constantin Mierla 21 Jul '17

21 Jul '17

Module: kamailio Branch: master Commit: 9136ce8017660e92f624de6f7b8a07e50620dfa1 URL: https://github.com/kamailio/kamailio/commit/9136ce8017660e92f624de6f7b8a07e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-21T13:51:36+02:00 xhttp: proper check for return of add lump rpl --- Modified: src/modules/xhttp/xhttp_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/9136ce8017660e92f624de6f7b8a07e… Patch: https://github.com/kamailio/kamailio/commit/9136ce8017660e92f624de6f7b8a07e… --- diff --git a/src/modules/xhttp/xhttp_mod.c b/src/modules/xhttp/xhttp_mod.c index d41fc47f70..8a542bfc8b 100644 --- a/src/modules/xhttp/xhttp_mod.c +++ b/src/modules/xhttp/xhttp_mod.c @@ -382,11 +382,12 @@ static int xhttp_handler(sip_msg_t* msg) } else { DBG("new fake msg created (%d bytes):\n<%.*s>\n", fake_msg_len, fake_msg_len, fake_msg); - if (xhttp_process_request(msg, fake_msg, fake_msg_len)<0) + if (xhttp_process_request(msg, fake_msg, fake_msg_len)<0) { ret=NONSIP_MSG_ERROR; - pkg_free(fake_msg); } - return ret; + pkg_free(fake_msg); + } + return ret; } else { LM_DBG("http msg unchanged (%d bytes):\n<%.*s>\n", msg->len, msg->len, msg->buf); @@ -432,7 +433,7 @@ static int xhttp_send_reply(sip_msg_t *msg, int code, str *reason, if(body!=NULL && body->len>0) { - if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) < 0) + if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) == 0) { LM_ERR("Error while adding reply lump\n"); return -1;

1 0

git:master:08c404f2: xcap_server: proper test of retun code for add lump rpl
by Daniel-Constantin Mierla 21 Jul '17

21 Jul '17

Module: kamailio Branch: master Commit: 08c404f245e55b37f71d4326afd959ecf1ea831c URL: https://github.com/kamailio/kamailio/commit/08c404f245e55b37f71d4326afd959e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-21T13:50:07+02:00 xcap_server: proper test of retun code for add lump rpl --- Modified: src/modules/xcap_server/xcap_server.c --- Diff: https://github.com/kamailio/kamailio/commit/08c404f245e55b37f71d4326afd959e… Patch: https://github.com/kamailio/kamailio/commit/08c404f245e55b37f71d4326afd959e… --- diff --git a/src/modules/xcap_server/xcap_server.c b/src/modules/xcap_server/xcap_server.c index 86f7816dd7..15c5a91209 100644 --- a/src/modules/xcap_server/xcap_server.c +++ b/src/modules/xcap_server/xcap_server.c @@ -284,7 +284,7 @@ static int xcaps_send_reply(sip_msg_t *msg, int code, str *reason, } if(body && body->len>0) { - if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) < 0) + if (add_lump_rpl(msg, body->s, body->len, LUMP_RPL_BODY) == 0) { LM_ERR("Error while adding reply lump\n"); return -1;

1 0

git:master:a2d010ce: xmlops: removed dead code return
by Daniel-Constantin Mierla 21 Jul '17

21 Jul '17

Module: kamailio Branch: master Commit: a2d010cea219fa1cd84d0cf84825f3cc63536530 URL: https://github.com/kamailio/kamailio/commit/a2d010cea219fa1cd84d0cf84825f3c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-21T13:51:19+02:00 xmlops: removed dead code return --- Modified: src/modules/xmlops/pv_xml.c --- Diff: https://github.com/kamailio/kamailio/commit/a2d010cea219fa1cd84d0cf84825f3c… Patch: https://github.com/kamailio/kamailio/commit/a2d010cea219fa1cd84d0cf84825f3c… --- diff --git a/src/modules/xmlops/pv_xml.c b/src/modules/xmlops/pv_xml.c index f002a53d44..872fea0de3 100644 --- a/src/modules/xmlops/pv_xml.c +++ b/src/modules/xmlops/pv_xml.c @@ -331,7 +331,6 @@ int pv_get_xml(struct sip_msg *msg, pv_param_t *param, default: return pv_get_null(msg, param, res); } - return pv_get_null(msg, param, res); } int pv_set_xml(struct sip_msg* msg, pv_param_t *param,

1 0

git:master:e6c9474e: core: cfg ctx - removed unused variable
by Daniel-Constantin Mierla 21 Jul '17

21 Jul '17

Module: kamailio Branch: master Commit: e6c9474e456fb0673c87f87a325d9dc40aa10d32 URL: https://github.com/kamailio/kamailio/commit/e6c9474e456fb0673c87f87a325d9dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-21T10:27:57+02:00 core: cfg ctx - removed unused variable --- Modified: src/core/cfg/cfg_ctx.c --- Diff: https://github.com/kamailio/kamailio/commit/e6c9474e456fb0673c87f87a325d9dc… Patch: https://github.com/kamailio/kamailio/commit/e6c9474e456fb0673c87f87a325d9dc… --- diff --git a/src/core/cfg/cfg_ctx.c b/src/core/cfg/cfg_ctx.c index 6dc9a469c0..d251b11317 100644 --- a/src/core/cfg/cfg_ctx.c +++ b/src/core/cfg/cfg_ctx.c @@ -1373,8 +1373,7 @@ int cfg_get_default_value_by_name(cfg_ctx_t *ctx, str *group_name, cfg_mapping_t *var; void *p; static str s; /* we need the value even - after the function returns */ - cfg_group_inst_t *group_inst; + * after the function returns */ /* verify the context even if we do not need it now to make sure that a cfg driver has called the function

1 0

git:master:e7a89633: cfg_rpc: hanlde return code inside cfg.reset rpc command
by Daniel-Constantin Mierla 21 Jul '17

21 Jul '17

Module: kamailio Branch: master Commit: e7a89633c809345aabdcf68f120f01e7d52d116d URL: https://github.com/kamailio/kamailio/commit/e7a89633c809345aabdcf68f120f01e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-21T10:11:07+02:00 cfg_rpc: hanlde return code inside cfg.reset rpc command --- Modified: src/modules/cfg_rpc/cfg_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/e7a89633c809345aabdcf68f120f01e… Patch: https://github.com/kamailio/kamailio/commit/e7a89633c809345aabdcf68f120f01e… --- diff --git a/src/modules/cfg_rpc/cfg_rpc.c b/src/modules/cfg_rpc/cfg_rpc.c index 18c16c8733..a9c42dc1e3 100644 --- a/src/modules/cfg_rpc/cfg_rpc.c +++ b/src/modules/cfg_rpc/cfg_rpc.c @@ -355,12 +355,12 @@ static void rpc_get(rpc_t* rpc, void* c) } } -static const char* rpc_reset_doc[2] = { +static const char* rpc_cfg_var_reset_doc[2] = { "Reset all the values of a configuration group and commit the change immediately", 0 }; -static void rpc_reset(rpc_t* rpc, void* c) +static void rpc_cfg_var_reset(rpc_t* rpc, void* c) { void *h; str gname, var; @@ -378,7 +378,7 @@ static void rpc_reset(rpc_t* rpc, void* c) if (get_group_id(&group, &group_id)) { rpc->fault(c, 400, "Wrong group syntax. Use either \"group\", or \"group[id]\""); - return; + return; } cfg_get_group_init(&h); @@ -402,10 +402,21 @@ static void rpc_reset(rpc_t* rpc, void* c) return; } - if (input_type == CFG_INPUT_INT) - cfg_set_now_int(ctx, &gname, group_id, &var, (int)(long)val); - else if (input_type == CFG_INPUT_STRING) - cfg_set_now_string(ctx, &gname, group_id, &var, val); + if (input_type == CFG_INPUT_INT) { + ret = cfg_set_now_int(ctx, &gname, group_id, &var, + (int)(long)val); + } else if (input_type == CFG_INPUT_STRING) { + ret = cfg_set_now_string(ctx, &gname, group_id, &var, val); + } else { + rpc->fault(c, 500, "Unsupported input type"); + return; + } + if(ret<0) { + rpc->fault(c, 500, "Reset failed"); + return; + } else if(ret==1) { + LM_WARN("unexpected situation - variable not found\n"); + } } } } @@ -601,7 +612,7 @@ static rpc_export_t rpc_calls[] = { {"cfg.commit", rpc_commit, rpc_commit_doc, 0}, {"cfg.rollback", rpc_rollback, rpc_rollback_doc, 0}, {"cfg.get", rpc_get, rpc_get_doc, 0}, - {"cfg.reset", rpc_reset, rpc_reset_doc, 0}, + {"cfg.reset", rpc_cfg_var_reset, rpc_cfg_var_reset_doc, 0}, {"cfg.help", rpc_help, rpc_help_doc, 0}, {"cfg.list", rpc_list, rpc_list_doc, 0}, {"cfg.diff", rpc_diff, rpc_diff_doc, 0},

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev