- sr-dev - kamailio.org

git:master:2492b92e: dialog: use defined tockens for is_set field of local cseq structure for keepalives
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 2492b92e49cfcd5f6828007b6a289b3f881dba69 URL: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:15:02+02:00 dialog: use defined tockens for is_set field of local cseq structure for keepalives --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Patch: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 52e492d2074..48494bef428 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -790,10 +790,11 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) * - dialog is ended on timeout (408) or C/L does not exist (481) */ if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; + di->loc_seq.is_set = DLG_SEQ_VALSET; } else { di->loc_seq.value = 0; + di->loc_seq.is_set = DLG_SEQ_VALNEW; } - di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:73c8316b: tm: add defines for dlg cseq is_self field
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 73c8316bf89703156f241886554919339ac270d0 URL: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:08:12+02:00 tm: add defines for dlg cseq is_self field - DLG_SEQ_VALINIT (should be initialized), DLG_SEQ_VALSET (is set, but can be updated for requests within dialog), DLG_SEQ_VALNEW (is set, and ready to be used as new cseq number in generated request) --- Modified: src/modules/tm/dlg.c Modified: src/modules/tm/dlg.h Modified: src/modules/tm/rpc_uac.c Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Patch: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… --- diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c index b99065a94c2..6c97db622af 100644 --- a/src/modules/tm/dlg.c +++ b/src/modules/tm/dlg.c @@ -357,7 +357,7 @@ int new_dlg_uac(str *_cid, str *_ltag, unsigned int _lseq, str *_luri, /* Make a copy of local sequence (usually CSeq) */ res->loc_seq.value = _lseq; /* And mark it as set */ - res->loc_seq.is_set = 1; + res->loc_seq.is_set = DLG_SEQ_VALSET; *_d = res; @@ -979,7 +979,7 @@ static inline int request2dlg(struct sip_msg *_m, dlg_t *_d) if(get_cseq_value(_m, &_d->rem_seq.value) < 0) goto err3; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; if(get_dlg_uri(_m->from, &_d->rem_uri) < 0) goto err3; @@ -1149,7 +1149,7 @@ int dlg_request_uas( /* Neither out of order nor retransmission -> update */ _d->rem_seq.value = cseq; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; /* We will als update remote target URI if the message * is target refresher diff --git a/src/modules/tm/dlg.h b/src/modules/tm/dlg.h index 732ba970bc0..ff37bc4bd9a 100644 --- a/src/modules/tm/dlg.h +++ b/src/modules/tm/dlg.h @@ -52,6 +52,10 @@ #endif /* DIALOG_CALLBACKS */ +#define DLG_SEQ_VALINIT 0 +#define DLG_SEQ_VALSET 1 +#define DLG_SEQ_VALNEW 2 + /* * Dialog sequence */ diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 285f3c7e9eb..3cd99a4d9c6 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -757,7 +757,7 @@ static void rpc_t_uac(rpc_t *rpc, void *c, int reply_wait, int cbflags) dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; @@ -1077,7 +1077,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket, dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index a9a327745ec..26748f4570c 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -451,11 +451,11 @@ static inline int t_uac_prepare( /* if err's returned, the message is incorrect */ goto error3; - if(!uac_r->dialog->loc_seq.is_set) { + if(uac_r->dialog->loc_seq.is_set == DLG_SEQ_VALINIT) { /* this is the first request in the dialog, set cseq to default value now - Miklos */ uac_r->dialog->loc_seq.value = DEFAULT_CSEQ; - uac_r->dialog->loc_seq.is_set = 1; + uac_r->dialog->loc_seq.is_set = DLG_SEQ_VALSET; } /* build cell sets X/AVP lists to new transaction structure @@ -677,7 +677,9 @@ int prepare_req_within(uac_req_t *uac_r, struct retr_buf **dst_req) goto send; if((uac_r->method->len == 6) && (!memcmp("CANCEL", uac_r->method->s, 6))) goto send; - uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + if(uac_r->dialog->loc_seq.is_set != DLG_SEQ_VALNEW) { + uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + } send: ret = t_uac_prepare(uac_r, dst_req, 0);

1 0

[kamailio/kamailio] Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module with high concurrency (Issue #4209)
by Henning Westerholt 06 Jun '25

06 Jun '25

henningw created an issue (kamailio/kamailio#4209) Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module. ### Environment: The systems are using 32 Kamailio worker processes for the relevant network interface, Its also using Prometheus counter increment operations more than 30 times in the cfg during INVITE processing. The Kamailio uses otherwise no database or other IO related services. Kamailio version 5.8.3, but no relevant changes in the xhttp_prom module could be found. ### Quick summary of the findings: Multiple systems showed frequent hangs in their Kamailio servers on a customer setup. It happens usually after a few hours that all Kamailio processes gets blocked, and no more traffic can be processed on the respective system. I have analysed three stack traces of the Kamailio on one of the system that showed the behaviour. Two without problems and one that was created from during a period where the server had problems. ### Details: Here some details of the stack traces from a problematic case. The relevant processes are from PID 494551 to 494582. The majority of all of these processes are blocked in paths related to the Prometheus module (PID 494551 to 494576): #### PID 494551: ``` #1 0x00007fc69ea5f053 in futex_get (lock=0x7fc4a147acd0) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #2 0x00007fc69ea70f99 in prom_counter_inc (s_name=0x7fffe339ffa0, number=1, l1=0x7fffe339ff90, l2=0x0, l3=0x0) at prom_metric.c:1154 p = 0x6b __func__ = "prom_counter_inc" […] #14 0x00000000005ab179 in receive_msg (buf=0x9f47e0 <buf> "INVITE [sip:+1YYYYYYY737@10.XXX.XXX107](sip:+1YYYYYYYYYY737@10.XXX.XX.107) SIP/2.0\r\nRecord-Route: [sip:10.1XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3](sip:10.XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3)\r\nRecord-Route: [sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F](sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F)\r\nRecord-R"..., len=2819, rcv_info=0x7fffe33a28d0) at core/receive.c:518 ``` Most of the worker processes are in the same state as shown above. Some of the processes are also working in other Prometheus related operations: #### PID 494554: ``` #0 prom_metric_timeout_delete (p_m=0x7fc49ea102f0) at prom_metric.c:646 current = 0x7fc4a2810fd0 ts = 1744143945433 __func__ = "prom_metric_timeout_delete" l = 0x7fc4abffc808 #1 0x00007fc69ea676ce in prom_metric_list_timeout_delete () at prom_metric.c:668 p = 0x7fc49ea102f0 ``` ### Problem hypothesis: My hypothesis is that the hang is caused from lock contention around the Prometheus module. The relevant code uses only one lock, and this together with the extensive usage of the increment counters probably causes this issues under high load. The majority of the worker processed are occupied in the Prometheus path and are not working on SIP packets. This will cause of course an increase of the UDP queue and the described problems. In order to test this hypothesis we removed temporarily the Prometheus logic in the kamailio cfg and see if the issue still persists. The issue did not showed up again after two days of testing, when before it was observed after a few hours. ### Possible solutions: The Prometheus module probably needs some improvements to support better high-load and concurrency situations. On common approach is to split the locks, e.g. using a per process lock array and then combining the individual values in a second pass when read from outside. Alternatively the xhttp_prom module should be used only carefully in situations with a high concurrency setup. I have the full backtrace available, if helpful just let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4209 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4209(a)github.com>

2 2

Kamailio Deployment in AWS
by gcampos＠momenta.network 05 Jun '25

05 Jun '25

Hi community, I'm not sure if anyone has ever tried that before, but I'm trying to run Kamailio in AWS with RTPengine. I successfully installed both Kamailio and RTPengine on my EC2 instance and I'm able to make my devices register to it. However, when I make a call from one of my devices, the call is muted. As I analyze my kamailio.cfg file, I see that the "route[NATMANAGE]" is likely the cause of the mute call. I think that none of the conditions below are met, therefore, the flags are not set. Because of that, the last condition is met, thus triggering the "return" and exiting from the route[NATMANAGE] prematurely without even reaching the section where I define the RTPengine modifications. Not only that, but if I remove/comment out the "return", then the RTPengine is triggered, but there call doesn't connect. I wonder why this is happening and if there's any known workaround. # RTP relaying management and signaling updates for NAT traversal route[NATMANAGE] { xlog("L_INFO", "NATMANAGE path was followed\n"); #!ifdef WITH_NAT xlog("L_INFO", "WITH_NAT Triggered\n"); if (is_request()) { xlog("L_INFO", "is_request path was followed\n"); if (has_totag()) { xlog("L_INFO", "has_totag path was followed\n"); if (check_route_param("nat=yes")) { xlog("L_INFO", "nat=yes param detected, setting FLB_NATB\n"); setbflag(FLB_NATB); } } if (nat_uac_test("3")) { xlog("L_INFO", "nat_uac_test(3) matched, setting FLT_NATS + FLB_NATB\n"); setflag(FLT_NATS); setbflag(FLB_NATB); } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) { xlog("L_INFO", "No NAT flags set, skipping NAT handling\n"); return; } #!ifdef WITH_RTPENGINE xlog("L_INFO", "WITH_RTPENGINE Path followed\n"); if (has_body("application/sdp")) { if (is_method("INVITE")) { xlog("L_INFO", "IS_METHOD_INVITE Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } else if (is_reply()) { xlog("L_INFO", "IS_Reply Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; }

3 2

git:5.8:6c71d5e7: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 5.8 Commit: 6c71d5e7364e169373a38d899793c78ae4f93835 URL: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T14:46:57+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) (cherry picked from commit 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Patch: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a22e64cb1e6..02f72d77521 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:6.0:a37a57c2: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: a37a57c2b4db73b4963d3af5e733ea8fe5c5833d URL: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:10:49+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog (cherry picked from commit 43e64af9bade5fedf34e847f662b97ce94c041bc) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Patch: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6349e88c1f8..773ae788e3b 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:43e64af9: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 43e64af9bade5fedf34e847f662b97ce94c041bc URL: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:07:59+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Patch: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6467b32b349..52e492d2074 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:b293f206: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: b293f20620c3396130f6409ddf30b69499bb482f URL: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:15+02:00 dialog: set cseq is_set for keepalive (cherry picked from commit b5d4c20172bdcaf0e63b15b4e23d205125398a42) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Patch: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..6349e88c1f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -784,10 +784,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:21c944e4: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b URL: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:03+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Patch: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:master:b5d4c201: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: b5d4c20172bdcaf0e63b15b4e23d205125398a42 URL: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 dialog: set cseq is_set for keepalive --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… Patch: https://github.com/kamailio/kamailio/commit/b5d4c20172bdcaf0e63b15b4e23d205… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 9ffd65e9526..6467b32b349 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -789,10 +789,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:730d6872: core: print default path to runtime dir on internals output
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 730d6872054cb6218684d5e48af341c7c2749233 URL: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:32:36+02:00 core: print default path to runtime dir on internals output --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… Patch: https://github.com/kamailio/kamailio/commit/730d6872054cb6218684d5e48af341c… --- diff --git a/src/main.c b/src/main.c index 95588200ba9..b0ec7fcb0d9 100644 --- a/src/main.c +++ b/src/main.c @@ -288,6 +288,7 @@ void print_internals(void) printf(" Version: %s\n", full_version); printf(" Default config: %s\n", CFG_FILE); printf(" Default paths to modules: %s\n", MODS_DIR); + printf(" Default path to runtime dir: %s\n", RUN_DIR); printf(" Compile flags: %s\n", ver_flags); printf(" MAX_RECV_BUFFER_SIZE=%d\n", MAX_RECV_BUFFER_SIZE); printf(" MAX_SEND_BUFFER_SIZE=%d\n", MAX_SEND_BUFFER_SIZE);

1 0

[kamailio/kamailio] Replace ip address of source (Issue #4272)
by nochnoi82 04 Jun '25

04 Jun '25

nochnoi82 created an issue (kamailio/kamailio#4272) Hello to everyone. I deployed Kamailio on Debian system. Install was successfull. I have the task to use Kamailio as proxy between Avaya PBX and Videoconference System. Outgoing calls only from IPPhone ----- Avaya PBX ---sip----> Kamailio -----sip----> Video System-IVR IVR number is 3000. Avaya Prefix for routing to Kamailio is 1234. When we dial number 12343000 the call goes to Video system with Header "TO" 12343000@ip_of_PBXAvaya and call drops. How to replace ip-address of Avaya to ip-address of Video_System? What to add in kamailio.cfg? ip video_system - *.*.60.3 ip avaya *.*.20.10 My route config ####### Routing Logic ######## /* Main SIP request routing logic * - processing of any incoming SIP request starts with this route * - note: this is the same as route { ... } */ request_route { # per request initial checks route(REQINIT); # NAT detection route(NATDETECT); # CANCEL processing if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } exit; } # handle retransmissions if (!is_method("ACK")) { if(t_precheck_trans()) { t_check_trans(); exit; } t_check_trans(); } # handle requests within SIP dialogs route(WITHINDLG); ### only initial requests (no To tag) # authentication route(AUTH); # record routing for dialog forming requests (in case they are routed) # - remove preloaded route headers remove_hf("Route"); if (is_method("INVITE|SUBSCRIBE")) { record_route(); } # account only INVITEs if (is_method("INVITE")) { setflag(FLT_ACC); # do accounting } if ($rU==$null) { sl_send_reply("484", "Address Incomplete"); exit; } $du = "sip:*.*.60.3:5060"; route(RELAY); exit; } # Wrapper for relaying requests route[RELAY] { # enable additional event routes for forwarded requests # - serial forking, RTP relaying handling, a.s.o. if (is_method("INVITE|BYE|SUBSCRIBE|UPDATE")) { if(!t_is_set("branch_route")) t_on_branch("MANAGE_BRANCH"); } if (is_method("INVITE|SUBSCRIBE|UPDATE")) { if(!t_is_set("onreply_route")) t_on_reply("MANAGE_REPLY"); } if (is_method("INVITE")) { if(!t_is_set("failure_route")) t_on_failure("MANAGE_FAILURE"); } if (!t_relay()) { sl_reply_error(); } exit; } # Per SIP request initial checks route[REQINIT] { # no connect for sending replies set_reply_no_connect(); # enforce symmetric signaling # - send back replies to the source address of request force_rport(); #!ifdef WITH_ANTIFLOOD # flood detection from same IP and traffic ban for a while # be sure you exclude checking trusted peers, such as pstn gateways # - local host excluded (e.g., loop to self) if(src_ip!=myself) { if($sht(ipban=>$si)!=$null) { # ip is already blocked xdbg("request from blocked IP - $rm from $fu (IP:$si:$sp)\n"); exit; } if (!pike_check_req()) { xlog("L_ALERT","ALERT: pike blocking $rm from $fu (IP:$si:$sp)\n"); $sht(ipban=>$si) = 1; exit; } } #!endif if($ua =~ "friendly|scanner|sipcli|sipvicious|VaxSIPUserAgent|pplsip") { # silent drop for scanners - uncomment next line if want to reply # sl_send_reply("200", "OK"); exit; } if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; } if(is_method("OPTIONS") && uri==myself && $rU==$null) { sl_send_reply("200","Keepalive"); exit; } if(!sanity_check("17895", "7")) { xlog("Malformed SIP request from $si:$sp\n"); exit; } } # Handle requests within SIP dialogs route[WITHINDLG] { if (!has_totag()) return; # sequential request withing a dialog should # take the path determined by record-routing if (loose_route()) { route(DLGURI); if (is_method("BYE")) { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } else if ( is_method("ACK") ) { # ACK is forwarded statelessly route(NATMANAGE); } else if ( is_method("NOTIFY") ) { # Add Record-Route for in-dialog NOTIFY as per RFC 6665. record_route(); } route(RELAY); exit; } if (is_method("SUBSCRIBE") && uri == myself) { # in-dialog subscribe requests route(PRESENCE); exit; } if ( is_method("ACK") ) { if ( t_check_trans() ) { # no loose-route, but stateful ACK; # must be an ACK after a 487 # or e.g. 404 from upstream server route(RELAY); exit; } else { # ACK without matching transaction ... ignore and discard exit; } } sl_send_reply("404","Not here"); exit; } # Handle SIP registrations route[REGISTRAR] { if (!is_method("REGISTER")) return; if(isflagset(FLT_NATS)) { setbflag(FLB_NATB); #!ifdef WITH_NATSIPPING # do SIP NAT pinging setbflag(FLB_NATSIPPING); #!endif } if (!save("location")) { sl_reply_error(); } exit; } # User location service route[LOCATION] { #!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") { if(sd_lookup("speed_dial")) { route(SIPOUT); } } #!endif #!ifdef WITH_ALIASDB # search in DB-based aliases if(alias_db_lookup("dbaliases")) { route(SIPOUT); } #!endif $avp(oexten) = $rU; if (!lookup("location")) { $var(rc) = $rc; route(TOVOICEMAIL); t_newtran(); switch ($var(rc)) { case -1: case -3: send_reply("404", "Not Found"); exit; case -2: send_reply("405", "Method Not Allowed"); exit; } } # when routing via usrloc, log the missed calls also if (is_method("INVITE")) { setflag(FLT_ACCMISSED); } route(RELAY); exit; } # Presence server processing route[PRESENCE] { if(!is_method("PUBLISH|SUBSCRIBE")) return; if(is_method("SUBSCRIBE") && $hdr(Event)=="message-summary") { route(TOVOICEMAIL); # returns here if no voicemail server is configured sl_send_reply("404", "No voicemail service"); exit; } #!ifdef WITH_PRESENCE #!ifdef WITH_MSGREBUILD # apply changes in case the request headers or body were modified msg_apply_changes(); #!endif if (!t_newtran()) { sl_reply_error(); exit; } if(is_method("PUBLISH")) { handle_publish(); t_release(); } else if(is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } exit; #!endif # if presence enabled, this part will not be executed if (is_method("PUBLISH") || $rU==$null) { sl_send_reply("404", "Not here"); exit; } return; } # IP authorization and user authentication route[AUTH] { #!ifdef WITH_AUTH #!ifdef WITH_IPAUTH if((!is_method("REGISTER")) && allow_source_address()) { # source IP allowed return; } #!endif if (is_method("REGISTER") || from_uri==myself) { # authenticate requests if (!auth_check("$fd", "subscriber", "1")) { auth_challenge("$fd", "0"); exit; } # user authenticated - remove auth header if(!is_method("REGISTER|PUBLISH")) consume_credentials(); } # if caller is not local subscriber, then check if it calls # a local destination, otherwise deny, not an open relay here if (from_uri!=myself && uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!else # authentication not enabled - do not relay at all to foreign networks if(uri!=myself) { sl_send_reply("403","Not relaying"); exit; } #!endif return; } # Caller NAT detection route[NATDETECT] { #!ifdef WITH_NAT if (nat_uac_test("19")) { if (is_method("REGISTER")) { fix_nated_register(); } else { if(is_first_hop()) { set_contact_alias(); } } setflag(FLT_NATS); } #!endif return; } # RTPProxy control and signaling updates for NAT traversal route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { if(has_totag()) { if(check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) return; #!ifdef WITH_RTPENGINE if(nat_uac_test("8")) { rtpengine_manage("SIP-source-address replace-origin replace-session-connection"); } else { rtpengine_manage("replace-origin replace-session-connection"); } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; } # URI update for dialog requests route[DLGURI] { #!ifdef WITH_NAT if(!isdsturiset()) { handle_ruri_alias(); } #!endif return; } # Routing to foreign domains route[SIPOUT] { if (uri==myself) return; append_hf("P-Hint: outbound\r\n"); route(RELAY); exit; } # PSTN GW routing route[PSTN] { #!ifdef WITH_PSTN # check if PSTN GW IP is defined if (strempty($sel(cfg_get.pstn.gw_ip))) { xlog("SCRIPT: PSTN routing enabled but pstn.gw_ip not defined\n"); return; } # route to PSTN dialed numbers starting with '+' or '00' # (international format) # - update the condition to match your dialing rules for PSTN routing if(!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) return; # only local users allowed to call if(from_uri!=myself) { sl_send_reply("403", "Not Allowed"); exit; } # normalize target number for pstn gateway # - convert leading 00 to + if (starts_with("$rU", "00")) { strip(2); prefix("+"); } if (strempty($sel(cfg_get.pstn.gw_port))) { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip); } else { $ru = "sip:" + $rU + "@" + $sel(cfg_get.pstn.gw_ip) + ":" + $sel(cfg_get.pstn.gw_port); } route(RELAY); exit; #!endif return; } # JSONRPC over HTTP(S) routing #!ifdef WITH_JSONRPC event_route[xhttp:request] { set_reply_close(); set_reply_no_connect(); if(src_ip!=127.0.0.1) { xhttp_reply("403", "Forbidden", "text/html", "<html><body>Not allowed from $si</body></html>"); exit; } if ($hu =~ "^/RPC") { jsonrpc_dispatch(); exit; } xhttp_reply("200", "OK", "text/html", "<html><body>Wrong URL $hu</body></html>"); exit; } #!endif # Routing to voicemail server route[TOVOICEMAIL] { #!ifdef WITH_VOICEMAIL if(!is_method("INVITE|SUBSCRIBE")) return; # check if VoiceMail server IP is defined if (strempty($sel(cfg_get.voicemail.srv_ip))) { xlog("SCRIPT: VoiceMail routing enabled but IP not defined\n"); return; } if(is_method("INVITE")) { if($avp(oexten)==$null) return; $ru = "sip:" + $avp(oexten) + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } else { if($rU==$null) return; $ru = "sip:" + $rU + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); } route(RELAY); exit; #!endif return; } # Manage outgoing branches branch_route[MANAGE_BRANCH] { xdbg("new branch [$T_branch_idx] to $ru\n"); route(NATMANAGE); return; } # Manage incoming replies reply_route { if(!sanity_check("17604", "6")) { xlog("Malformed SIP response from $si:$sp\n"); drop; } return; } # Manage incoming replies in transaction context onreply_route[MANAGE_REPLY] { xdbg("incoming reply\n"); if(status=~"[12][0-9][0-9]") { route(NATMANAGE); } return; } # Manage failure routing cases failure_route[MANAGE_FAILURE] { route(NATMANAGE); if (t_is_canceled()) exit; #!ifdef WITH_BLOCK3XX # block call redirect based on 3xx replies. if (t_check_status("3[0-9][0-9]")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_BLOCK401407 # block call redirect based on 401, 407 replies. if (t_check_status("401|407")) { t_reply("404","Not found"); exit; } #!endif #!ifdef WITH_VOICEMAIL # serial forking # - route to voicemail on busy or no answer (timeout) if (t_check_status("486|408")) { $du = $null; route(TOVOICEMAIL); exit; } #!endif return; -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4272 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4272(a)github.com>

2 2

git:master:0ab44e99: modules: readme files regenerated - userblocklist ... [skip ci]
by Kamailio Dev 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0ab44e999c81a25dc826f23e724cf699ce894beb URL: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-06-04T08:01:09+02:00 modules: readme files regenerated - userblocklist ... [skip ci] --- Modified: src/modules/userblocklist/README --- Diff: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… Patch: https://github.com/kamailio/kamailio/commit/0ab44e999c81a25dc826f23e724cf69… --- diff --git a/src/modules/userblocklist/README b/src/modules/userblocklist/README index 9aabcb73d19..4cff231c495 100644 --- a/src/modules/userblocklist/README +++ b/src/modules/userblocklist/README @@ -154,9 +154,9 @@ Chapter 1. Admin Guide blocklisted or not. An additional functionality that this module provides is the ability to - handle global blocklists. This lists are loaded on startup into memory, - thus providing a better performance than the userblocklist case. These - global blocklists are useful to allow only calls to certain + handle global blocklists. These lists are loaded on startup into + memory, thus providing a better performance than the userblocklist + case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers. They could also be used to prevent the blocklisting of important numbers, as allowlisting is supported too. This is useful for example

1 0

git:master:81357b54: userblocklist: docs - small typo
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 81357b548b6e0cdf464361c2b1742d797f0d7e95 URL: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 userblocklist: docs - small typo --- Modified: src/modules/userblocklist/doc/userblocklist_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… Patch: https://github.com/kamailio/kamailio/commit/81357b548b6e0cdf464361c2b1742d7… --- diff --git a/src/modules/userblocklist/doc/userblocklist_admin.xml b/src/modules/userblocklist/doc/userblocklist_admin.xml index db8efd86896..0a64d648ea1 100644 --- a/src/modules/userblocklist/doc/userblocklist_admin.xml +++ b/src/modules/userblocklist/doc/userblocklist_admin.xml @@ -20,7 +20,7 @@ </para> <para> An additional functionality that this module provides is the ability - to handle global blocklists. This lists are loaded on startup into + to handle global blocklists. These lists are loaded on startup into memory, thus providing a better performance than the userblocklist case. These global blocklists are useful to allow only calls to certain international destinations, i.e. block all not allowlisted numbers.

1 0

git:master:0195e860: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 04 Jun '25

04 Jun '25

Module: kamailio Branch: master Commit: 0195e86084ffbe5333310fc4206f4a6d01662a85 URL: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-04T07:50:46+02:00 siptrace: reset x/avp lists after event route --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… Patch: https://github.com/kamailio/kamailio/commit/0195e86084ffbe5333310fc4206f4a6… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index cdac1a32ccf..e199d1cefc9 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -40,6 +40,8 @@ #include "../../core/mod_fix.h" #include "../../core/fmsg.h" #include "../../core/events.h" +#include "../../core/srapi.h" +#include "../../core/receive.h" #include "../../core/kemi.h" #include "sipdump_write.h" @@ -286,14 +288,14 @@ static sipdump_data_t *sipdump_event_data = NULL; */ int sipdump_event_route(sipdump_data_t *sdi) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("sipdump:msg"); sip_msg_t *fmsg = NULL; + ksr_msg_env_t menv = {0}; - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); fmsg = faked_msg_next(); @@ -312,7 +314,8 @@ int sipdump_event_route(sipdump_data_t *sdi) } } sipdump_event_data = NULL; - set_route_type(backup_rt); + ksr_msg_env_reset(); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

[kamailio/kamailio] Cannot connect using MySQL option group name in DBURL (Issue #4271)
by dynax60 03 Jun '25

03 Jun '25

dynax60 created an issue (kamailio/kamailio#4271) Hi all! ```bash [root@kamailio kamailio]# cat /etc/rocky-release Rocky Linux release 9.5 (Blue Onyx) [root@kamailio kamailio]# sestatus SELinux status: disabled [root@kamailio kamailio]# kamailio -v version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 11.5.0 ``` I am trying to use the mysql option group name `kamailio` to connect to MySQL: ``` #!ifdef WITH_MYSQL #!trydef DBURL "mysql://[kamailio]/kamailio" #!endif ``` My /etc/my.cnf file: ``` # # This group is read both both by the client and the server # use it for options that affect everything # [client-server] # # include all files from the config directory # !includedir /etc/my.cnf.d/ ``` /etc/my.cnf.d/kamailio.cnf: ``` [kamailio] socket=/var/lib/mysql/mysql.sock user = kamailio password = ... default-character-set = utf8 ``` Let's check the group name and permissions (for test purposes): ```bash [root@kamailio kamailio]# usermod -s /bin/sh kamailio [root@kamailio kamailio]# su - kamailio -c 'my_print_defaults -c /etc/my.cnf kamailio' --socket=/var/lib/mysql/mysql.sock --user=kamailio --password=... --default-character-set=utf8 ``` The cuts from log file: ``` May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): auth_db May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_auth_s> in module auth [/usr/lib64/kamailio/modules/auth.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:1035]: init_mod(): presence May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:301]: mod_init(): db_url=mysql://[kamailio]/kamailio (len=27 addr=0x7f6002ba6f00) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/utils/sruid.c:127]: sruid_init(): root for sruid is [pres-683a04b4-1c59-] (0 / 19) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: presence [presence.c:345]: mod_init(): server_address parameter not set in configuration file May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <bind_sl> in module sl [/usr/lib64/kamailio/modules/sl.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <load_tm> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_newtran> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_tcp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay_to_udp> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_relay> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_forward_nonack> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <t_release> in module tm [/usr/lib64/kamailio/modules/tm.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:762]: find_mod_export_record(): found export of <db_bind_api> in module db_mysql [/usr/lib64/kamailio/modules/db_mysql.so] May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:217]: db_bind_mod(): using db bind api for db_mysql May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [lib/srdb1/db.c:322]: db_do_init2(): connection 0x7f6002c25500 not found in pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: db_mysql [km_my_con.c:121]: db_mysql_new_connection(): opening connection: mysql://xxxx:xxxx@/kamailio May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: NO) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: presence [presence.c:417]: mod_init(): Connection to database failed May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: ERROR: <core> [core/sr_module.c:1040]: init_mod(): Error while initializing module presence (/usr/lib64/kamailio/modules/presence.so) May 30 19:19:16 kamailio /usr/sbin/kamailio[7257]: DEBUG: <core> [core/sr_module.c:875]: destroy_modules(): starting modules destroy phase ``` Strange things happens if I place [kamailio] configuration into /etc/my.cnf - everything works like a charm! What could be wrong? How to check by other means? The problem is exactly that kamailio can't read the configuration in the external file /etc/my.cnf.d/kamailio.cnf -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4271 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4271(a)github.com>

3 4

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 01 Jun '25

01 Jun '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

4 6

[kamailio/kamailio] Possibly adjusting the SDP parser to be more lenient towards scenarios where a stream is being removed/rejected and connection-information "c=" is only available per media (no session-wide "c=") and the removed/rejected stream omits all fields (Issue #3982)
by thomas414 31 May '25

31 May '25

### Description I encountered an issue with a specific device that is receiving a T.38 fax. The call gets established towards the device normally with inband media, then the device requests T.38 media and tries to remove the audio media via sending port 0 in the ReInvite SDP. Also it sends connection-information only on the media level and there is no "c=" on the session level. Reading through the related RFCs and the kamailio code and discussing this on the mailing list, we came to the conclusion that kamailio is doing everything correct as per RFC. Though we were wondering if it would be possible to adjust the parser to be not as strict as it is right now, and allow a missing "c=" line on the media-level if the stream is removed/rejected via port 0, since i see no sense in requiring connection information. Of course we are also in contact with the vendor to hopefully adjust on their side. Here are the related RFCs: 1. RFC8866 5.7 `A session description MUST contain either at least one "c=" line in each media description or a single "c=" line at the session level. It MAY contain a single session-level "c=" line and additional media-level "c=" line(s) per-media-description, in which case the media-level values override the session-level settings for the respective media.` 2. RFC3264 8.2 `Existing media streams are removed by creating a new SDP with the port number for that stream set to zero. The stream description MAY omit all attributes present previously, and MAY list just a single media format.` At first i was especially confused by the RFC3264 8.2 part, since it seemed correct what the device is sending, but if you read carefully and keep the wording for SDP in mind only attributes ("a=") MAY be omitted. So a "c=" line should still be in the SDP for the removed media if it's not included on the session-level. Or do you see this differently? ### Expected behavior Kamailio allows and parses the SDP when there is no session-wide "c=", a media stream is being removed via port zero and there is no "c=" for this media stream and only the remaining media streams include a "c=" line. #### Actual observed behavior Kamailio throws an error when trying to parse the SDP. #### Log Messages ``` <core> [core/parser/sdp/sdp.c:523]: parse_sdp_session(): can't find media IP in the message ``` #### SIP Traffic ``` v=0 o=xmserver 1726638425 1726638427 IN IP4 169.254.1.1 s=xmserver t=0 0 m=audio 0 RTP/AVP 8 m=image 56002 udptl t38 c=IN IP4 169.254.1.1 a=sendrecv a=T38FaxVersion:0 a=T38MaxBitRate:14400 a=T38FaxFillBitRemoval:0 a=T38FaxTranscodingMMR:0 a=T38FaxTranscodingJBIG:0 a=T38FaxRateManagement:transferredTCF a=T38FaxMaxBuffer:200 a=T38FaxMaxDatagram:72 a=T38FaxUdpEC:t38UDPRedundancy ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Debian 12 Linux hostname 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3982 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3982(a)github.com>

3 5

[kamailio/kamailio] Inactive video stream: can't find media IP in the message (Issue #3406)
by schoberw 31 May '25

31 May '25

### Description In some situations the other side UA must reply with an inactive media stream. E.g. if video was added but not supported by the other side. The UAS then must answer with an m=video 0 RTP/.. line. It seams that the video section must contain a c= line with an IP address for rtpengine to function. If there is no c line (no IP address) the SDP body cannot be parsed and thus no RTP proxy is invoked. ### Troubleshooting Not easy to reproduce since the answer must bei "wrong". Is it correct to reply an SDP body (media = video) like this? ``` m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 ``` Maybe not (but Audiocodes SBC lates LTS version does it) - so we are dependent on other side now that this service works. #### Reproduction reInvite with Video to a UA that has no video Support (e.g. Bria -> Snom). Drop the c line in the video part with some textops in 200 OK (just to reproduce of course). A -> B, connect the call A -> + video, B has no video support A presses hold #### Log Messages Incoming 200 OK after doing hold with an inactive video: ``` v=0 o=root 436040161 309284577 IN IP4 1.2.3.5 s=call t=0 0 m=audio 14200 RTP/AVPF 9 8 126 c=IN IP4 1.2.3.5 a=ptime:20 a=recvonly a=mid:0 a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVPF 96 a=label:1 a=inactive a=mid:1 Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: ERROR: <core> [core/parser/sdp/sdp.c:490]: parse_sdp_session(): can't find media IP in the message Mar 27 17:52:22 c5p05es2-1 /usr/sbin/kamailio[2938205]: INFO: <script>: >>> Sending Reply: 200 OK (1.2.3.4:443 -> 100.108.48.38:65251) ``` Compare to working SDP parsing: ``` a=rtpmap:9 G722/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:126 telephone-event/8000 a=fmtp:126 0-15 m=video 0 RTP/AVP 96 c=IN IP4 1.2.3.5 a=inactive a=mid:1 Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ONREPLY_ROUTE[FORWARD] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: ROUTE[RTPP_REPLY] Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > 200 with inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Remove inactive video Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: > Answer to WebRTC client: 200 - qijpuibkv6ufhnd282ks Mar 27 18:00:17 c5p05es2-1 /usr/sbin/kamailio[2942881]: INFO: <script>: >>> Sending Reply: 200 OK (91.237.65.14:443 -> 80.108.48.38:65388) ``` ### Possible Solutions Tried to fix in script: ``` if(sdp_with_media("video")) xlog("L_INFO", "> $rs with video"); if(sdp_with_active_media("video")) xlog("L_INFO", "> $rs with active video"); if(!sdp_with_active_media("video")) xlog("L_INFO", "> $rs with inactive video"); if(sdp_with_media("video") && !sdp_with_active_media("video")) { # try fix for RMT#60189 xlog("L_INFO", "> Remove inactive video"); sdp_remove_media("video"); msg_apply_changes(); # needed? } ``` But since sdpops cannot parse it cannot remove the buggy media, too. See the log: non of the xlog is logging. If there is inactive media the c line is not mandatory. The parser should accept this by adding a default IP of 0.0.0.0, if needed Doing tricks with textops is not a easy nor performant solution to accept this wrong SDP from other parties. ### Additional Information ``` version: kamailio 5.6.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**: Debian Bullseye -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3406 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3406(a)github.com>

3 5

[kamailio/kamailio] dispatcher: weight documentation and workaround for limitations (PR #4158)
by Christian Berger 31 May '25

31 May '25

- describe limitation of weight parameter - describe a potential workaround against those limitations  #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We had problems understanding the weight parameter of the dispatcher module and wrote a little workaround against the problems we have found. This workaround in the configuration file improves behavior for setups with many dispatcher targets at the cost of more CPU load. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4158 -- Commit Summary -- * dispatcher: weight documentation and workaround for limitations -- File Changes -- M src/modules/dispatcher/doc/dispatcher_admin.xml (28) A src/modules/dispatcher/doc/weights.cfg (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4158.patch https://github.com/kamailio/kamailio/pull/4158.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4158 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4158(a)github.com>

4 4

[kamailio/kamailio] kafka_send in event_route not work (Issue #4198)
by wangduanduan 31 May '25

31 May '25

wangduanduan created an issue (kamailio/kamailio#4198)  ### Description kafka_send in event_route like tcp:timeout, tcp:closed not work ``` event_route[tcp:closed] { if (kafka_send("my_topic", "tcp:closed")) { xlog("L_INFO", "send success tcp:closed"); } } event_route[tcp:timeout] { if (kafka_send("my_topic", "tcp:timeout")) { xlog("L_INFO", "send success tcp:timeout"); } } ``` in log, its show "send success tcp:closed", "send success tcp:timeout", but in kafka web ui, in the **my_topic**, can't find the "tcp:closed" or " tcp:timeout" message. --- but if the kafka_send in onreply_route, message will be send ok, in the kafka web ui, the "some_route" can be find. ``` onreplay_route[some_route]{ if (kafka_send("my_topic", "some_routet")) { xlog("L_INFO", "send success some_routet"); } } ```  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic i use tcpdump to capture the traffic between kamailio and kafka. - when use kafka_send in event_route, no packages captured.  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**: centos7  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4198(a)github.com>

5 10

git:master:218de360: modules: readme files regenerated - jansson ... [skip ci]
by Kamailio Dev 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 218de360f439c3ef203f4403b5d06cd7ecca19df URL: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-30T12:31:11+02:00 modules: readme files regenerated - jansson ... [skip ci] --- Modified: src/modules/jansson/README --- Diff: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… Patch: https://github.com/kamailio/kamailio/commit/218de360f439c3ef203f4403b5d06cd… --- diff --git a/src/modules/jansson/README b/src/modules/jansson/README index 550c9d62a8d..47a091b8ca6 100644 --- a/src/modules/jansson/README +++ b/src/modules/jansson/README @@ -134,7 +134,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... 3.2. jansson_pv_get(key/path, srcvar, dst)

1 0

git:master:5ee87b79: siptrace: reset x/avp lists after event route
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 5ee87b7905d931931dece44ec591d8e6bcf567e2 URL: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:23:19+02:00 siptrace: reset x/avp lists after event route - GH #4258 --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… Patch: https://github.com/kamailio/kamailio/commit/5ee87b7905d931931dece44ec591d8e… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 6e6ffcaf237..3c27e20fe87 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -41,6 +41,7 @@ #include "../../core/ip_addr.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" +#include "../../core/receive.h" #include "../../core/rpc.h" #include "../../core/rpc_lookup.h" #include "../../lib/srdb1/db.h" @@ -54,6 +55,7 @@ #include "../../core/str.h" #include "../../core/onsend.h" #include "../../core/events.h" +#include "../../core/srapi.h" #include "../../core/kemi.h" #include "siptrace_data.h" @@ -2220,12 +2222,12 @@ static siptrace_data_t *siptrace_event_data = NULL; static int siptrace_exec_evcb_msg(siptrace_data_t *sto) { - int backup_rt; run_act_ctx_t ctx; run_act_ctx_t *bctx; sr_kemi_eng_t *keng = NULL; str evname = str_init("siptrace:msg"); sip_msg_t msg; + ksr_msg_env_t menv = {0}; if(_siptrace_evrt_msg_idx < 0 && _siptrace_evcb_msg.len <= 0) { return 0; @@ -2248,7 +2250,7 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) return -1; } - backup_rt = get_route_type(); + ksr_msg_env_push(&menv); set_route_type(EVENT_ROUTE); init_run_actions_ctx(&ctx); @@ -2267,8 +2269,9 @@ static int siptrace_exec_evcb_msg(siptrace_data_t *sto) } siptrace_event_data = NULL; + ksr_msg_env_reset(); free_sip_msg(&msg); - set_route_type(backup_rt); + ksr_msg_env_pop(&menv); if(ctx.run_flags & DROP_R_F) { return DROP_R_F; }

1 0

git:master:465fda0f: core: implement pop of lists from msg env
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 465fda0f790e44e5484b2ef41363fb23fece3f41 URL: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T12:07:46+02:00 core: implement pop of lists from msg env --- Modified: src/core/srapi.c --- Diff: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… Patch: https://github.com/kamailio/kamailio/commit/465fda0f790e44e5484b2ef41363fb2… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 8d7bd1ca620..a16acf97d21 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -79,7 +79,6 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) { menv->route_type = get_route_type(); - /* make available the avp list from transaction */ menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); @@ -100,5 +99,16 @@ void ksr_msg_env_push(ksr_msg_env_t *menv) void ksr_msg_env_pop(ksr_msg_env_t *menv) { set_route_type(menv->route_type); + + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, menv->avps_uri_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, menv->avps_uri_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, menv->avps_user_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, menv->avps_user_to); + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, menv->avps_domain_from); + set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, menv->avps_domain_to); + xavp_set_list(menv->xavps); + xavu_set_list(menv->xavus); + xavi_set_list(menv->xavis); + return; }

1 0

git:master:7fed8f52: jansson: docs - added missing semicolon in the example
by Daniel-Constantin Mierla 30 May '25

30 May '25

Module: kamailio Branch: master Commit: 7fed8f52391aaef43d5cb672f4821d50d4855830 URL: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-30T11:53:06+02:00 jansson: docs - added missing semicolon in the example --- Modified: src/modules/jansson/doc/jansson_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… Patch: https://github.com/kamailio/kamailio/commit/7fed8f52391aaef43d5cb672f4821d5… --- diff --git a/src/modules/jansson/doc/jansson_admin.xml b/src/modules/jansson/doc/jansson_admin.xml index daa5e9ea51e..71ffa92bff9 100644 --- a/src/modules/jansson/doc/jansson_admin.xml +++ b/src/modules/jansson/doc/jansson_admin.xml @@ -94,7 +94,7 @@ if(!jansson_get("inner.deep.list[3]", "$var(myjson)", "$var(n)")) { } xlog("L_INFO", "foo is $var(n)"); ... -jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)") +jansson_get("test", "{\"test\":\"abc\",\"idx\":20}", "$var(n)"); ... </programlisting> </example> @@ -313,4 +313,3 @@ xlog("foo.foz is $var(foofoz)"); </section> </section> </chapter> -

1 0

[kamailio/kamailio] Sca in cluster/load balancer (Issue #4267)
by Maurotb 29 May '25

29 May '25

Maurotb created an issue (kamailio/kamailio#4267) We have two kamailio in load balancing, mysql is in cluster mode. We need to use sca, but kamailio db cluster is not supported (i need to specify connection string to sql not cluster name) and if phone1 is registered on kamailio1 and phone2 on kamailio2, sca not work. It is possibile to implement cluster? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4267 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4267(a)github.com>

2 2

[kamailio/kamailio] Disable IPSec in P-CSCF (Issue #4269)
by navjyoty 29 May '25

29 May '25

navjyoty created an issue (kamailio/kamailio#4269) I'm working on a custom IMS deployment using the pcscf module in Kamailio. For our setup, we do not want Kamailio to handle IPsec or generate Security-Server headers in 401/407 responses. Is there a clean way to disable IPsec functionality entirely in the pcscf module? Specifically, I would like to: Prevent the module from requiring IPsec setup during UE registration Avoid any modification of SIP messages related to IPsec (e.g., removing Security-Verify, Security-Client, or Security-Server headers) Use only TLS or UDP without IPsec involvement Has anyone achieved this via configuration or by disabling specific features? Any guidance or examples would be greatly appreciated. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4269 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4269(a)github.com>

2 2

[kamailio/kamailio] SIP Race condition when using dlg.end_dlg (Issue #4268)
by IgorG 29 May '25

29 May '25

IgorrG created an issue (kamailio/kamailio#4268) ### Description We use RPC dlg.end_dlg command to terminate dialog. In most cases it does operate properly and send BYE from kamailio to both sides of dialog (as show on screenshot). ![Image](https://github.com/user-attachments/assets/b49164a5-6442-4c66-bd4d-f5412678247f) We found that in some cases we have only first BYE sent to calling party. Second BYE never sent, when called party tries to terminate call by timeout it get responded with 481. ![Image](https://github.com/user-attachments/assets/10c90b4c-30a3-4123-8e2b-2ca64cdec3c3) ![Image](https://github.com/user-attachments/assets/f0facce8-3acf-4049-8a23-ad559874af7b) In logs we have such warning: мая 27 15:11:46 service-proxy.iqtek.ru kamailio[3518388]: 2(3518388) WARNING: {1 1 BYE 541d3f2c-43fd-43b6-af24-bad1fbf85eb6} dialog [dlg_handlers.c:1343]: dlg_onroute(): unable to find dialog for BYE with route param 'e1e.4f22' [3614:8948] and call-id '541d3f2c-43fd-43b6-af24-bad1fbf85eb6' We also found that in this case this warning shown in logs 0.04 seconds after kamailio receive 200ok. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # ./kamailio -V version: kamailio 5.8.6 (x86_64/linux) fb71db flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fb71db compiled on 17:38:27 May 26 2025 with gcc 12.2.0 ``` * **Operating System**: ``` # lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm # uname -a Linux rtp-kamailio2 6.1.0-32-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.129-1 (2025-03-06) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4268 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4268(a)github.com>

1 0

git:master:54a330bb: core: helper functions to get/set msg env lists
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: 54a330bb707fb6b4943ba26356891696681a02e7 URL: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:47+02:00 core: helper functions to get/set msg env lists --- Modified: src/core/srapi.c Modified: src/core/srapi.h --- Diff: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… Patch: https://github.com/kamailio/kamailio/commit/54a330bb707fb6b4943ba2635689169… --- diff --git a/src/core/srapi.c b/src/core/srapi.c index 99fbf49d8a9..8d7bd1ca620 100644 --- a/src/core/srapi.c +++ b/src/core/srapi.c @@ -19,7 +19,9 @@ #include <stdio.h> #include <stdlib.h> + #include "dprint.h" +#include "route.h" #include "srapi.h" @@ -69,3 +71,34 @@ sr_cfgenv_t *sr_cfgenv_get(void) { return &_sr_cfgenv; } + +/** + * + */ +void ksr_msg_env_push(ksr_msg_env_t *menv) +{ + menv->route_type = get_route_type(); + + /* make available the avp list from transaction */ + menv->avps_uri_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, NULL); + menv->avps_uri_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, NULL); + menv->avps_user_from = set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, NULL); + menv->avps_user_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, NULL); + menv->avps_domain_from = + set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, NULL); + menv->avps_domain_to = set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, NULL); + menv->xavps = xavp_set_list(NULL); + menv->xavus = xavu_set_list(NULL); + menv->xavis = xavi_set_list(NULL); + + return; +} + +/** + * + */ +void ksr_msg_env_pop(ksr_msg_env_t *menv) +{ + set_route_type(menv->route_type); + return; +} diff --git a/src/core/srapi.h b/src/core/srapi.h index 1f5f8e7d36b..b573493a62b 100644 --- a/src/core/srapi.h +++ b/src/core/srapi.h @@ -20,6 +20,8 @@ #define __SRAPI_H__ #include "str.h" +#include "usr_avp.h" +#include "xavp.h" #include "parser/msg_parser.h" typedef void (*sr_generate_callid_f)(str *); @@ -39,4 +41,21 @@ typedef struct sr_cfgenv void sr_cfgenv_init(void); sr_cfgenv_t *sr_cfgenv_get(void); +typedef struct ksr_msg_env +{ + int route_type; + avp_list_t *avps_user_from; + avp_list_t *avps_user_to; + avp_list_t *avps_domain_from; + avp_list_t *avps_domain_to; + avp_list_t *avps_uri_from; + avp_list_t *avps_uri_to; + sr_xavp_t **xavps; + sr_xavp_t **xavus; + sr_xavp_t **xavis; +} ksr_msg_env_t; + +void ksr_msg_env_push(ksr_msg_env_t *menv); +void ksr_msg_env_pop(ksr_msg_env_t *menv); + #endif

1 0

git:master:f0291728: ims_ipsec_pcscf: jump to error for clean up
by Daniel-Constantin Mierla 28 May '25

28 May '25

Module: kamailio Branch: master Commit: f0291728b7fb623faf1d4de0f3152e782a6782ae URL: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-28T21:28:46+02:00 ims_ipsec_pcscf: jump to error for clean up --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… Patch: https://github.com/kamailio/kamailio/commit/f0291728b7fb623faf1d4de0f3152e7… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index e15de4e2de8..4672a45906a 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -272,7 +272,7 @@ static int fill_contact( if((srcip = pkg_malloc(50)) == NULL) { LM_ERR("Error allocating memory for source IP address\n"); - return -1; + goto error; } memcpy(srcip, alias_s.s, ci->received_host.len);

1 0

[kamailio/kamailio] tls: Create one shared context and reuse it. (PR #3972)
by Xenofon Karamanos 28 May '25

28 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3823 #### Description  This PR aims to implement what was discussed in [mailing list](https://lists.kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kama… regarding some `tls.reload` and increasing memory usage. It adds a new parameter `enable_shared_ctx` in `tls` module that if set to 0, preserves the old behavior and if set to 1 (other than 0 tbh), it creates a single SSL context that is being shared. This have the effect of using way less memory when initialized as well, but also minimizes (can't say it fixes the problem) the `tls.reload` memory increase. I have also added a small markdown (comparison.md) file, where some comparisons where made between enabled/disabled shared context and with/without CA file (where the initial problem was occurring by the reporter). Feedback would be necessary to verify whether this patch, acts as expected and kamailio works as intented. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3972 -- Commit Summary -- * tls: Add parameter for shared contexts * tls: Comparison for enable_shared_ctx -- File Changes -- A comparison.md (15) M src/modules/tls/tls_domain.c (172) M src/modules/tls/tls_mod.c (11) M src/modules/tls/tls_mod.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3972.patch https://github.com/kamailio/kamailio/pull/3972.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3972 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3972(a)github.com>

4 12

[kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)
by sergey-safarov 28 May '25

28 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description As a local IP address for TCP sending operation the Kamailio service is taking the same network_interface/IP_address, which is used by the service for TCP listening. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3925 -- Commit Summary -- * core: local TCP socket is bound on listening address -- File Changes -- M src/core/tcp_main.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3925.patch https://github.com/kamailio/kamailio/pull/3925.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3925 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3925(a)github.com>

5 16

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

Same -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142745(a)github.com>

1 0

Re: [kamailio/kamailio] pkg/kamailio: switched RPM packaging to use cmake (9a1b9d0)
by Xenofon Karamanos 27 May '25

27 May '25

@sergey-safarov I look a bit on this commit and some comments i can give are: 1) The config files of these modules are already installed by default when they are included to be built. No need for extra step. 2) These *-cfg components are no longer available after the refactoring to use build groups instead. Can you maybe confirm that? I expect that it silently does nothing instead of complaining... -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/9a1b9d08a112745663f37f0dfcbe86a741486da3/158142732(a)github.com>

1 0

git:master:6ccf41b3: modules: readme files regenerated - pdb ... [skip ci]
by Kamailio Dev 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 6ccf41b3e2c27b9f790aa9cc881eeca1054cb20c URL: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-27T16:01:09+02:00 modules: readme files regenerated - pdb ... [skip ci] --- Modified: src/modules/pdb/README --- Diff: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… Patch: https://github.com/kamailio/kamailio/commit/6ccf41b3e2c27b9f790aa9cc881eeca… --- diff --git a/src/modules/pdb/README b/src/modules/pdb/README index 52ebab2e8ae..0c2ec72e122 100644 --- a/src/modules/pdb/README +++ b/src/modules/pdb/README @@ -12,6 +12,11 @@ Pawel Kuzak 1&1 Internet AG <pawel.kuzak(a)1und1.de> +Muhammad Shahzad Shafi + + 1&1 Internet AG + <muhammad.shafi(a)1und1.de> + Copyright © 2009 1&1 Internet AG __________________________________________________________________ @@ -38,8 +43,9 @@ Pawel Kuzak 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate List of Examples @@ -48,8 +54,9 @@ Pawel Kuzak 1.3. Set ll_info parameter 1.4. pdb_query usage 1.5. pdb.status usage - 1.6. pdb.activate usage - 1.7. pdb.deactivate usage + 1.6. pdb.timeout usage + 1.7. pdb.activate usage + 1.8. pdb.deactivate usage Chapter 1. Admin Guide @@ -74,8 +81,9 @@ Chapter 1. Admin Guide 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 1. Overview @@ -178,8 +186,9 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); 5. RPC Commands 5.1. pdb.status - 5.2. pdb.activate - 5.3. pdb.deactivate + 5.2. pdb.timeout + 5.3. pdb.activate + 5.4. pdb.deactivate 5.1. pdb.status @@ -191,22 +200,35 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); kamcmd pdb.status ... -5.2. pdb.activate +5.2. pdb.timeout + + Prints the current PDB query timeout value. This can also be used to + set the PDB query timeout. + + Example 1.6. pdb.timeout usage +... +# get the PDB query timeout +kamcmd pdb.timeout +# set the PDB query timeout to 10ms +kamcmd pdb.timeout 10 +... + +5.3. pdb.activate Activates the module. This is the default after loading the module. - Example 1.6. pdb.activate usage + Example 1.7. pdb.activate usage ... kamcmd pdb.activate ... -5.3. pdb.deactivate +5.4. pdb.deactivate Deactivates the module. No more queries are performed until it is activated again. As long as the module is deactivated, the pdb_query function will return -1. - Example 1.7. pdb.deactivate usage + Example 1.8. pdb.deactivate usage ... kamcmd pdb.deactivate ...

1 0

[kamailio/kamailio] PDB: new RPC command to get/set the PDB query timeout value (PR #4261)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4261 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * Merge branch 'kamailio:master' into master -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4261.patch https://github.com/kamailio/kamailio/pull/4261.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4261 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4261(a)github.com>

2 5

git:master:db903613: pdb: add documentation for new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: db903613a10ae93ce0b8ff93835486953df4437e URL: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add documentation for new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/doc/pdb.xml Modified: src/modules/pdb/doc/pdb_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… Patch: https://github.com/kamailio/kamailio/commit/db903613a10ae93ce0b8ff938354869… --- diff --git a/src/modules/pdb/doc/pdb.xml b/src/modules/pdb/doc/pdb.xml index 835353ca359..686cf6ab0be 100644 --- a/src/modules/pdb/doc/pdb.xml +++ b/src/modules/pdb/doc/pdb.xml @@ -24,6 +24,12 @@ <affiliation><orgname>1&1 Internet AG</orgname></affiliation> <email>pawel.kuzak(a)1und1.de</email> </editor> + <editor> + <firstname>Muhammad Shahzad</firstname> + <surname>Shafi</surname> + <affiliation><orgname>1&1 Internet AG</orgname></affiliation> + <email>muhammad.shafi(a)1und1.de</email> + </editor> </authorgroup> <copyright> <year>2009</year> diff --git a/src/modules/pdb/doc/pdb_admin.xml b/src/modules/pdb/doc/pdb_admin.xml index 19b00bd99d8..50fb4190dae 100644 --- a/src/modules/pdb/doc/pdb_admin.xml +++ b/src/modules/pdb/doc/pdb_admin.xml @@ -163,6 +163,24 @@ cr_route("$avp(i:82)", "$rd", "$rU", "$rU", "call_id"); <programlisting format="linespecific"> ... &kamcmd; pdb.status +... + </programlisting> + </example> + </section> + <section id="pdb.r.timeout"> + <title>pdb.timeout</title> + <para> + Prints the current PDB query timeout value. + This can also be used to set the PDB query timeout. + </para> + <example> + <title><function>pdb.timeout</function> usage</title> + <programlisting format="linespecific"> +... +# get the PDB query timeout +&kamcmd; pdb.timeout +# set the PDB query timeout to 10ms +&kamcmd; pdb.timeout 10 ... </programlisting> </example>

1 0

git:master:e2ab3174: pdb: add new RPC command to view/change PDB query timeout
by Henning Westerholt 27 May '25

27 May '25

Module: kamailio Branch: master Commit: e2ab3174fb8f013e0a536c0cd5b049f3e2015eec URL: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Author: Muhammad Shafi <muhammad.shafi(a)1und1.de> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-27T15:56:13+02:00 pdb: add new RPC command to view/change PDB query timeout --- Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… Patch: https://github.com/kamailio/kamailio/commit/e2ab3174fb8f013e0a536c0cd5b049f… --- diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 492fa99ec09..77806e49df6 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -27,6 +27,8 @@ #include "../../core/sr_module.h" +#include "../../core/cfg/cfg.h" +#include "../../core/cfg/cfg_ctx.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" #include "../../core/rpc_lookup.h" @@ -806,6 +808,36 @@ static void pdb_rpc_status(rpc_t *rpc, void *ctx) (*active) ? "active" : "inactive"); } +static void pdb_rpc_timeout(rpc_t *rpc, void *ctx) +{ + void *vh; + int new_val = -1; + int old_val = cfg_get(pdb, pdb_cfg, timeout); + + str gname = str_init("pdb"); + str vname = str_init("timeout"); + + if(rpc->add(ctx, "{", &vh) < 0) { + rpc->fault(ctx, 500, "Server error"); + return; + } + + if(rpc->scan(ctx, "*d", &new_val) < 1) { + if(rpc->struct_add(vh, "d", "timeout", old_val) < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + } + return; + } + + if(rpc->struct_add(vh, "dd", "old_timeout", old_val, "new_timeout", new_val) + < 0) { + rpc->fault(ctx, 500, "Internal error reply structure"); + return; + } + + cfg_set_now_int(ctx, &gname, NULL, &vname, new_val); +} + static void pdb_rpc_activate(rpc_t *rpc, void *ctx) { if(active == NULL) { @@ -826,11 +858,14 @@ static void pdb_rpc_deactivate(rpc_t *rpc, void *ctx) static const char *pdb_rpc_status_doc[2] = {"Get the pdb status.", 0}; +static const char *pdb_rpc_timeout_doc[2] = {"Set the pdb_query timeout.", 0}; + static const char *pdb_rpc_activate_doc[2] = {"Activate pdb.", 0}; static const char *pdb_rpc_deactivate_doc[2] = {"Deactivate pdb.", 0}; rpc_export_t pdb_rpc[] = {{"pdb.status", pdb_rpc_status, pdb_rpc_status_doc, 0}, + {"pdb.timeout", pdb_rpc_timeout, pdb_rpc_timeout_doc, 0}, {"pdb.activate", pdb_rpc_activate, pdb_rpc_activate_doc, 0}, {"pdb.deactivate", pdb_rpc_deactivate, pdb_rpc_deactivate_doc, 0}, {0, 0, 0, 0}};

1 0

[kamailio/kamailio] tls: add WSS to RPC funtions (PR #4259)
by Benjamin 27 May '25

27 May '25

- tls_list() add PROTO_WSS to TLS_LIST RPC call to include WSS connections in tls.list - tls_kill() add PROTO_WSS to handle WSS connections Co-authored-by: Andreas Tarp <tarp(a)sipgate.de> #### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4167 #### Description WSS connection is not shown in tls.list RPC command like all other TLS connections. Also tls_kill does not handle WSS connections. This is related to the issue 4167. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4259 -- Commit Summary -- * http_client: add information about parameter loading * http_client: docs - typos from previous commit * tls: add WSS to RPC funtions -- File Changes -- M src/modules/http_client/doc/http_client_admin.xml (7) M src/modules/tls/tls_rpc.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4259.patch https://github.com/kamailio/kamailio/pull/4259.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4259 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4259(a)github.com>

1 5

git:master:0039c50e: permissions: don't allow reloads in the middle of ongoind reload
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 0039c50e83916c647a2ee38e6be2c39ad17adfcc URL: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T14:06:20+02:00 permissions: don't allow reloads in the middle of ongoind reload --- Modified: src/modules/permissions/rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… Patch: https://github.com/kamailio/kamailio/commit/0039c50e83916c647a2ee38e6be2c39… --- diff --git a/src/modules/permissions/rpc.c b/src/modules/permissions/rpc.c index 6519c6343c0..7646ee0672e 100644 --- a/src/modules/permissions/rpc.c +++ b/src/modules/permissions/rpc.c @@ -45,7 +45,8 @@ int rpc_check_reload(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "ongoing reload"); return -1; } - *perm_rpc_reload_time = time(NULL); + // we are reloading, don't allow new reloads + *perm_rpc_reload_time = time(NULL) + 86400; return 0; } @@ -61,10 +62,13 @@ void rpc_trusted_reload(rpc_t *rpc, void *c) if(reload_trusted_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; } @@ -101,10 +105,13 @@ void rpc_address_reload(rpc_t *rpc, void *c) if(reload_address_table_cmd() != 1) { rpc->fault(c, 500, "Reload failed."); - return; + goto done; } rpc->rpl_printf(c, "Reload OK"); +done: + // reloading is done + *perm_rpc_reload_time = time(NULL); return; }

1 0

git:5.8:02edb040: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 5.8 Commit: 02edb0408d907fa2a9031faf40bca899dbfcf050 URL: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:53+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) (cherry picked from commit 14de4b1101f62c3463e5f05836e8618a3b0db96b) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… Patch: https://github.com/kamailio/kamailio/commit/02edb0408d907fa2a9031faf40bca89… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 9e212f01e2c..c460cccdb36 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -625,9 +625,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -659,18 +656,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -701,6 +700,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -733,6 +735,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

git:6.0:14de4b11: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: 6.0 Commit: 14de4b1101f62c3463e5f05836e8618a3b0db96b URL: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:43:14+02:00 sca: reserve subscription.rr.s separately since it could be updated (cherry picked from commit fd04bcc152dd6ef88fbb819b0b77aee7ca817878) --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… Patch: https://github.com/kamailio/kamailio/commit/14de4b1101f62c3463e5f05836e8618… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] sca: reserve subscription.rr.s separately since it could be updated (PR #4251)
by Victor Seva 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description sca was generating a crash since it is trying to shm_free a part of a bigger block at: https://github.com/kamailio/kamailio/blob/master/src/modules/sca/sca_subscr… So, let's reserve memory that field separately. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4251 -- Commit Summary -- * sca: reserve subscription.rr.s separately since it could be updated -- File Changes -- M src/modules/sca/sca_subscribe.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4251.patch https://github.com/kamailio/kamailio/pull/4251.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4251 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4251(a)github.com>

1 1

git:master:fd04bcc1: sca: reserve subscription.rr.s separately since it could be updated
by Victor Seva 27 May '25

27 May '25

Module: kamailio Branch: master Commit: fd04bcc152dd6ef88fbb819b0b77aee7ca817878 URL: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-27T11:41:23+02:00 sca: reserve subscription.rr.s separately since it could be updated --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… Patch: https://github.com/kamailio/kamailio/commit/fd04bcc152dd6ef88fbb819b0b77aee… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index ca42fd138e9..5e34ceac6d2 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -626,9 +626,6 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, len += sizeof(sca_subscription); len += sizeof(char) * (aor->len + subscriber->len); - if(!SCA_STR_EMPTY(rr)) { - len += sizeof(char) * rr->len; - } sub = (sca_subscription *)shm_malloc(len); if(sub == NULL) { @@ -660,18 +657,20 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, SCA_STR_COPY(&sub->target_aor, aor); len += aor->len; + // we shm_malloc this parts separately in case we need to update in-memory + // info for this subscriber. This is likely to happen if the + // subscriber goes off-line for some reason. if(!SCA_STR_EMPTY(rr)) { - sub->rr.s = (char *)sub + len; + sub->rr.s = (char *)shm_malloc(rr->len); + if(sub->rr.s == NULL) { + SHM_MEM_ERROR; + goto error; + } SCA_STR_COPY(&sub->rr, rr); - len += rr->len; } // dialog.id holds call-id + from-tag + to-tag; dialog.call_id, // dialog.from_tag, and dialog.to_tag point to offsets within // dialog.id. - // - // we shm_malloc this separately in case we need to update in-memory - // dialog saved for this subscriber. This is likely to happen if the - // subscriber goes off-line for some reason. len = sizeof(char) * (call_id->len + from_tag->len + to_tag->len); sub->dialog.id.s = (char *)shm_malloc(len); if(sub->dialog.id.s == NULL) { @@ -702,6 +701,9 @@ sca_subscription *sca_subscription_create(str *aor, int event, str *subscriber, error: if(sub != NULL) { + if(sub->rr.s != NULL) { + shm_free(sub->rr.s); + } if(sub->dialog.id.s != NULL) { shm_free(sub->dialog.id.s); } @@ -734,6 +736,10 @@ void sca_subscription_free(void *value) LM_DBG("Freeing %s subscription from %.*s\n", sca_event_name_from_type(sub->event), STR_FMT(&sub->subscriber)); + if(!SCA_STR_EMPTY(&sub->rr)) { + shm_free(sub->rr.s); + } + if(!SCA_STR_EMPTY(&sub->dialog.id)) { shm_free(sub->dialog.id.s); }

1 0

[kamailio/kamailio] PDB: new RPC command to view/change PDB query timeout value (PR #4260)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4260 -- Commit Summary -- * pdb: add new RPC command to view/change PDB query timeout * pdb: add documentation for new RPC command to view/change PDB query timeout * pdb: add new code contributor credits -- File Changes -- M src/modules/pdb/doc/pdb.xml (6) M src/modules/pdb/doc/pdb_admin.xml (18) M src/modules/pdb/pdb.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4260.patch https://github.com/kamailio/kamailio/pull/4260.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4260 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4260(a)github.com>

1 3

[kamailio/kamailio] PDB: add RPC command to get and set PDB query timeout (PR #4254)
by Muhammad Shahzad Shafi 27 May '25

27 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4254 -- Commit Summary -- * pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout -- File Changes -- M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4254(a)github.com>

3 8

[kamailio/kamailio] Adding kemi exports for play_dtmf event_callback and dlg_req_within functions (PR #4245)
by ggontariu 27 May '25

27 May '25

- [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Added missing kemi exports for RTP Engine module play_dtmf event_callback functions and Dialog module dlg_req_within function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4245 -- Commit Summary -- * Add support for playing DTMF tones in RTP engine module using Kemi * Add support for KEMI callbacks in RTP engine events * Add `ki_dlg_req_within4` handling for dialog requests -- File Changes -- M src/modules/dialog/dialog.c (24) M src/modules/rtpengine/rtpengine.c (215) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4245.patch https://github.com/kamailio/kamailio/pull/4245.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4245 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4245(a)github.com>

2 17

git:master:472dbb59: dialog: Kemi export dlg_req_within
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 472dbb59006207629e9724b7d7155719cb653969 URL: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 dialog: Kemi export dlg_req_within --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… Patch: https://github.com/kamailio/kamailio/commit/472dbb59006207629e9724b7d715571… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4539d1657e2..36af6f54404 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -2615,6 +2615,27 @@ static int ki_dlg_var_is_null(sip_msg_t *msg, str *name) return -1; } +/** + * + */ +static int ki_dlg_req_within4(struct sip_msg *msg, str *side, str *method, + str *content_type, str *content) +{ + int n = 0; + if(side && side->len > 0) { + if(side->len == 6 && strncasecmp(side->s, "caller", 6) == 0) { + n = 1; + } else if(side->len == 6 && strncasecmp(side->s, "callee", 6) == 0) { + n = 2; + } else { + return -1; + } + } + + return ki_dlg_req_with_headers_and_content( + msg, n, method, NULL, content_type, content); +} + /** * */ @@ -2780,6 +2801,11 @@ static sr_kemi_t sr_kemi_dialog_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("dialog"), str_init("dlg_req_within4"), + SR_KEMIP_INT, ki_dlg_req_within4, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, + SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:c52bf0aa: rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: c52bf0aaa4ad2bc53ede2eeb5df0d8a9bff0e140 URL: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Author: gabrielgontariu <114484712+gabrielgontariu(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T09:31:56+02:00 rtpengine: Kemi export play_dtmf and event_callback. Enhance support for dtmf event by adding support for source_label, tags, source_ip, type, volume and duration --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a… Patch: https://github.com/kamailio/kamailio/commit/c52bf0aaa4ad2bc53ede2eeb5df0d8a…

1 0

git:master:25daa044: pv_headers: set value after checking if src is set
by Daniel-Constantin Mierla 27 May '25

27 May '25

Module: kamailio Branch: master Commit: 25daa0445ebc611cda3e47fd34aefc74494550d7 URL: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-27T08:59:16+02:00 pv_headers: set value after checking if src is set --- Modified: src/modules/pv_headers/pvh_str.c --- Diff: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… Patch: https://github.com/kamailio/kamailio/commit/25daa0445ebc611cda3e47fd34aefc7… --- diff --git a/src/modules/pv_headers/pvh_str.c b/src/modules/pv_headers/pvh_str.c index 28908a37069..1916f93e002 100644 --- a/src/modules/pv_headers/pvh_str.c +++ b/src/modules/pv_headers/pvh_str.c @@ -50,11 +50,12 @@ int pvh_str_free(str *s) int pvh_str_copy(str *dst, str *src, unsigned int max_size) { - unsigned int src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; + unsigned int src_len = 0; if(src == NULL || dst == NULL || src->len <= 0) return -1; + src_len = src->len + 1 >= max_size ? max_size - 1 : src->len; memset(dst->s, 0, dst->len); memcpy(dst->s, src->s, src_len); dst->s[src_len] = '\0';

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev