- sr-dev - kamailio.org

git:master:898f680d: cmake: Remove unnessecary components to be consistent
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 898f680d85b3e558038b41a14fa6f2ebca05bc94 URL: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:48:24Z cmake: Remove unnessecary components to be consistent --- Modified: src/modules/crypto/CMakeLists.txt Modified: src/modules/dnssec/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… Patch: https://github.com/kamailio/kamailio/commit/898f680d85b3e558038b41a14fa6f2e… --- diff --git a/src/modules/crypto/CMakeLists.txt b/src/modules/crypto/CMakeLists.txt index 63d56fb6a8e..a111e1f2799 100644 --- a/src/modules/crypto/CMakeLists.txt +++ b/src/modules/crypto/CMakeLists.txt @@ -2,6 +2,6 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(OpenSSL REQUIRED COMPONENTS SSL Crypto) +find_package(OpenSSL REQUIRED) target_link_libraries(${module_name} PRIVATE OpenSSL::SSL OpenSSL::Crypto) diff --git a/src/modules/dnssec/CMakeLists.txt b/src/modules/dnssec/CMakeLists.txt index 82abef707b1..3177aff9a2f 100644 --- a/src/modules/dnssec/CMakeLists.txt +++ b/src/modules/dnssec/CMakeLists.txt @@ -2,7 +2,7 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(OpenSSL REQUIRED COMPONENTS SSL Crypto) +find_package(OpenSSL REQUIRED) find_package(Threads REQUIRED) # TODO: library libval not foud on recent distributions: whichi library is sres?

1 0

git:master:85b821b4: cmake: Remove unused groups
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 85b821b4b6e6cfaa5495d39bcd3ef2e1b939b499 URL: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:47:54Z cmake: Remove unused groups --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… Patch: https://github.com/kamailio/kamailio/commit/85b821b4b6e6cfaa5495d39bcd3ef2e… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 96a16979de8..d71e60318a0 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -483,37 +483,6 @@ set(MODULE_GROUP_COMMON ${MOD_LIST_TLSDEPS} ) -# For db use (db modules, excluding drivers) module_group_db=$(mod_list_db) -set(MODULE_GROUP_DB ${MOD_LIST_DB}) - -# For mysql module_group_mysql_driver=$(mod_list_mysql) -# module_group_mysql=$(module_group_mysql_driver) $(module_group_db) -set(MODULE_GROUP_MYSQL_DRIVER ${MOD_LIST_MYSQL}) -set(MODULE_GROUP_MYSQL ${MODULE_GROUP_MYSQL_DRIVER} ${MODULE_GROUP_DB}) - -# For postgress module_group_postgres_driver=$(mod_list_postgres) -# module_group_postgres=$(module_group_postgres_driver) $(module_group_db) -set(MODULE_GROUP_POSTGRES_DRIVER ${MOD_LIST_POSTGRES}) -set(MODULE_GROUP_POSTGRES ${MODULE_GROUP_POSTGRES_DRIVER} ${MODULE_GROUP_DB}) - -# For sqlite module_group_sqlite_driver=$(mod_list_sqlite) -# module_group_sqlite=$(module_group_sqlite_driver) $(module_group_db) -set(MODULE_GROUP_SQLITE_DRIVER ${MOD_LIST_SQLITE}) -set(MODULE_GROUP_SQLITE ${MODULE_GROUP_SQLITE_DRIVER} ${MODULE_GROUP_DB}) - -# For radius -set(MODULE_GROUP_RADIUS ${MODULE_LIST_RADIUS}) - -# For presence kamailio modules -set(MODULE_GROUP_PRESENCE ${MOD_LIST_PRESENCE}) - -# For cassandra -set(MODULE_GROUP_CASSANDRA_DRIVER ${MODULE_LIST_CASSANDRA}) -set(MODULE_GROUP_CASSANDRA ${MODULE_GROUP_CASSANDRA_DRIVER} ${MODULE_GROUP_DB}) - -# For all modules not compiled by default -# list(FILTER MOD_LIST_ALL EXCLUDE REGEX "${MODULE_GROUP_DEFAULT}") - # for all protocols (excl. local ones such as unix, tcp, etc.) set(AVAILABLE_GROUPS ALL DEFAULT STANDARD COMMON)

1 0

git:master:165f2cd3: cmake: Add missing defintion
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 165f2cd3c2e1197b8d1986cbc2784a24c02e06e9 URL: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:47:24Z cmake: Add missing defintion --- Modified: cmake/defs.cmake --- Diff: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… Patch: https://github.com/kamailio/kamailio/commit/165f2cd3c2e1197b8d1986cbc2784a2… --- diff --git a/cmake/defs.cmake b/cmake/defs.cmake index 6ec6ac59b72..7fa11e89093 100644 --- a/cmake/defs.cmake +++ b/cmake/defs.cmake @@ -108,6 +108,7 @@ option(CORE_TLS "CORE_TLS" OFF) if(${CORE_TLS}) set(RELEASE "${RELEASE}-tls") set(TLS_HOOKS OFF) + target_compile_definitions(common INTERFACE CORE_TLS) else() set(TLS_HOOKS ON) endif()

1 0

git:master:549643ec: cmake: Remove warning message
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 549643ec1e283b07e9fae274b6ed923065ba46e0 URL: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T10:44:40Z cmake: Remove warning message --- Modified: src/modules/snmpstats/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… Patch: https://github.com/kamailio/kamailio/commit/549643ec1e283b07e9fae274b6ed923… --- diff --git a/src/modules/snmpstats/CMakeLists.txt b/src/modules/snmpstats/CMakeLists.txt index 0fc68b2c8df..fdcbe151d41 100644 --- a/src/modules/snmpstats/CMakeLists.txt +++ b/src/modules/snmpstats/CMakeLists.txt @@ -10,6 +10,6 @@ target_link_libraries(${module_name} PRIVATE NETSNMP::NETSNMP) install( DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/mibs - DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp/ + DESTINATION ${CMAKE_INSTALL_DATADIR}/snmp OPTIONAL )

1 0

git:master:cf8cdb99: cmake: Warning if no modules/group were selected
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: cf8cdb99355e19a30460229633eaf087717ee44d URL: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T08:15:11Z cmake: Warning if no modules/group were selected --- Modified: src/modules/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… Patch: https://github.com/kamailio/kamailio/commit/cf8cdb99355e19a30460229633eaf08… --- diff --git a/src/modules/CMakeLists.txt b/src/modules/CMakeLists.txt index cc303f0bb88..0decc1865ab 100644 --- a/src/modules/CMakeLists.txt +++ b/src/modules/CMakeLists.txt @@ -149,8 +149,14 @@ message(STATUS "Modules to be built: ${ADDED_MODULES_LIST}") # TODO: Comment is not showing. probably a bug in CMAKE # https://gitlab.kitware.com/cmake/cmake/-/issues/26571 add_custom_target(modules COMMENT "Building modules") -add_dependencies(modules ${ADDED_MODULES_LIST}) - +if(NOT ADDED_MODULES_LIST) + message( + WARNING + "No modules to build. Did you forget to add a module group or include module?" + ) +else() + add_dependencies(modules ${ADDED_MODULES_LIST}) +endif() get_property(ALL_MODULE_DOC_TARGETS GLOBAL PROPERTY ALL_MODULE_DOC_TARGETS) # message(STATUS "ALL_MODULE_DOC_TARGETS: ${ALL_MODULE_DOC_TARGETS}")

1 0

git:master:0afea1fd: cmake: Forbid in-source builds
by Xenofon Karamanos 19 May '25

19 May '25

Module: kamailio Branch: master Commit: 0afea1fd170a79d3f260c18a293bac1ce8fd8527 URL: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-19T08:14:54Z cmake: Forbid in-source builds --- Modified: CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… Patch: https://github.com/kamailio/kamailio/commit/0afea1fd170a79d3f260c18a293bac1… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 6d68b5da980..22ee9a8e3a2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -10,6 +10,17 @@ project( HOMEPAGE_URL "https://www.kamailio.org" ) +# ---- Include guards ---- + +if(PROJECT_SOURCE_DIR STREQUAL PROJECT_BINARY_DIR) + message( + FATAL_ERROR + "In-source builds not allowed. Please make a new directory (called a build directory) \ +and run CMake again accordingly.") +endif() + +# ---- Project settings ---- + # Set the version number set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}")

1 0

[kamailio/kamailio] generate rpm packages using github actions (PR #4194)
by sergey-safarov 17 May '25

17 May '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I have refactored the rpm packaging and am now using the GitHub actions. Now `tar.gz` archive with rpm packages, source rpm and deps rpm files attached to the release message like. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4194 -- Commit Summary -- * generate rpm packages using github actions -- File Changes -- A .github/workflows/rpm.yml (57) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4194.patch https://github.com/kamailio/kamailio/pull/4194.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4194 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4194(a)github.com>

2 5

git:master:afa2d017: github: generate rpm packages
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: afa2d017e3b5a1f5a776935767e485c1158be461 URL: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Author: Sergey Safarov <s.safarov(a)anycast-lb.net> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:41:05+02:00 github: generate rpm packages --- Added: .github/workflows/rpm.yml --- Diff: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… Patch: https://github.com/kamailio/kamailio/commit/afa2d017e3b5a1f5a776935767e485c… --- diff --git a/.github/workflows/rpm.yml b/.github/workflows/rpm.yml new file mode 100644 index 00000000000..0d890b63a8c --- /dev/null +++ b/.github/workflows/rpm.yml @@ -0,0 +1,89 @@ +--- +name: build_rpm +'on': + schedule: + - cron: '41 6 * * 0' + push: + tags: + - '[0-9]+.[0-9]+.[0-9]+' +jobs: + # is required nightly build? + # More info at https://stackoverflow.com/questions/63014786/how-to-schedule-a-github-actio… + # looking commit_id of the last successful daily build + check: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: octokit/request-action(a)v2.x + id: check_last_run + with: + route: GET /repos/{owner}/{repo}/actions/workflows/rpm.yml/runs?per_page=1&status=success + owner: ${{ github.repository_owner }} + repo: kamailio + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Show last execution info + run: | + echo "Last daily build: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }}" + + outputs: + last_sha: ${{ fromJson(steps.check_last_run.outputs.data).workflow_runs[0].head_sha }} + + native: + needs: [check] + if: needs.check.outputs.last_sha != github.sha + strategy: + matrix: + os: + - centos-10 + - rhel-10 + - centos-9 + - rhel-9 + - centos-8 + - rhel-8 + runner: + - ubuntu-latest + - ubuntu-24.04-arm + runs-on: ${{ matrix.runner }} + permissions: + contents: write + steps: + - name: checkout sources + uses: actions/checkout@v4 + + - name: print commit info and init hosttype var + id: init + run: | + echo ${{ github.sha }} + echo "hosttype=${HOSTTYPE}" >> $GITHUB_OUTPUT + + - name: build rpm files + uses: addnab/docker-run-action@v3 + with: + image: safarov/kamailio-builder:${{ matrix.os }} + options: -v ${{ github.workspace }}:/usr/src/kamailio + run: | + cd /usr/src/kamailio + make cfg + make -C pkg/kamailio src.rpm + rpmbuild -ra /usr/src/kamailio/kamailio*.src.rpm + cp -R /deps ~/rpmbuild/RPMS + mv ~/rpmbuild/SRPMS/* ~/rpmbuild/RPMS + mv ~/rpmbuild/RPMS . + tar czf kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz RPMS + + - name: Push artifacts + uses: actions/upload-artifact@v4 + if: "! startsWith(github.ref, 'refs/tags/')" + with: + name: kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm + path: | + RPMS/* + + - name: Release + uses: softprops/action-gh-release@v2 + if: "startsWith(github.ref, 'refs/tags/')" + with: + files: | + kamailio-${{ github.ref_name }}-${{ matrix.os }}-${{ steps.init.outputs.hosttype }}.rpm.tar.gz

1 0

[kamailio/kamailio] ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c (PR #4206)
by Amin Nazari 17 May '25

17 May '25

- fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #4205 (replace XXXX with an open issue number) #### Description Based on the description in issue #4205, this PR will fix a bug in ims_auth module related to MAR Diameter request callbacks, by replacing the call to t_continue function with t_continue_skip_timer, after the MAR request is sent, the control will successfully move to the cfg action in Kamailio scripts. Just like what we already have in ims_registrar_scscf module, using t_continue_skip_timer instead of t_continue cause the transaction to be found and resumed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4206 -- Commit Summary -- * ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c -- File Changes -- M src/modules/ims_auth/cxdx_mar.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4206.patch https://github.com/kamailio/kamailio/pull/4206.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4206 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4206(a)github.com>

2 1

git:master:74709677: ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c
by Victor Seva 17 May '25

17 May '25

Module: kamailio Branch: master Commit: 7470967790a78ba67ef7acb7c87d94482fbea0cb URL: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Author: amnapa <marvelousvip(a)live.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-17T20:34:43+02:00 ims_auth: replaced t_continue_skip_timer with t_continue in cxdx_mar.c - fixed log message in MAR Async CDP callback - fixed executing cfg_action after sending MAR Diameter request - cfg_action is the callback parameter of the ims_www_challenge function --- Modified: src/modules/ims_auth/cxdx_mar.c --- Diff: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… Patch: https://github.com/kamailio/kamailio/commit/7470967790a78ba67ef7acb7c87d944… --- diff --git a/src/modules/ims_auth/cxdx_mar.c b/src/modules/ims_auth/cxdx_mar.c index 51e05ce7a27..3868dee4f60 100644 --- a/src/modules/ims_auth/cxdx_mar.c +++ b/src/modules/ims_auth/cxdx_mar.c @@ -479,7 +479,7 @@ void async_cdp_callback( adi_list = 0; } - LM_DBG("DBG:UAR Async CDP callback: ... Done resuming transaction\n"); + LM_DBG("DBG:MAR Async CDP callback: ... Done resuming transaction\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &t->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &t->uri_avps_to); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, &t->user_avps_from); @@ -493,7 +493,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&req->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); free_saved_transaction_data(data); return; @@ -504,7 +504,7 @@ void async_cdp_callback( //del_nonshm_lump_rpl(&t->uas.request->reply_lump); tmb.unref_cell(t); } - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_skip_timer(data->tindex, data->tlabel, data->act); error1: free_saved_transaction_data(data);

1 0

git:master:b51c78ba: usrloc: use the internal wrappers for time value
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: b51c78ba27ca552893ba88cefe2d941246322a69 URL: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T11:05:47+02:00 usrloc: use the internal wrappers for time value --- Modified: src/modules/usrloc/ul_keepalive.c --- Diff: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… Patch: https://github.com/kamailio/kamailio/commit/b51c78ba27ca552893ba88cefe2d941… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 5ea58f25a9f..a0704da2a69 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -156,9 +156,10 @@ int ul_ka_urecord(urecord_t *ur) /* set contact as expired in 10s */ LM_DBG("set expired contact on keepalive (%u + %u < %u)" " - aor: %.*s c: %.*s\n", - (unsigned int)uc->last_keepalive, - (unsigned int)ul_keepalive_timeout, (unsigned int)tnow, - ur->aor.len, ur->aor.s, uc->c.len, uc->c.s); + ksr_time_uint(&uc->last_keepalive, NULL), + (unsigned int)ul_keepalive_timeout, + ksr_time_sint(&tnow, NULL), ur->aor.len, ur->aor.s, + uc->c.len, uc->c.s); if(uc->expires > tnow + 10) { uc->expires = tnow + 10; continue;

1 0

git:master:73dc08af: tls: removed unnecessary code
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: 73dc08affb9d0a7a3f9ab83c24e01bada8958b2d URL: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:49:09+02:00 tls: removed unnecessary code --- Modified: src/modules/tls/tls_select.c --- Diff: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… Patch: https://github.com/kamailio/kamailio/commit/73dc08affb9d0a7a3f9ab83c24e01ba… --- diff --git a/src/modules/tls/tls_select.c b/src/modules/tls/tls_select.c index 6a2711bd36a..18abcc7dd03 100644 --- a/src/modules/tls/tls_select.c +++ b/src/modules/tls/tls_select.c @@ -1415,8 +1415,6 @@ static int get_alt_count(long *res, int local, int type, sip_msg_t *msg) tcpconn_put(c); return 0; err: - if(names) - sk_GENERAL_NAME_pop_free(names, GENERAL_NAME_free); if(!local) X509_free(cert); tcpconn_put(c);

1 0

git:master:87cfa9f3: pv_headers: compare the pvh_set_xavi() result with NULL
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: 87cfa9f3c5ae337dceb78654beb6fe4b00587993 URL: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:39:33+02:00 pv_headers: compare the pvh_set_xavi() result with NULL --- Modified: src/modules/pv_headers/pvh_func.c --- Diff: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… Patch: https://github.com/kamailio/kamailio/commit/87cfa9f3c5ae337dceb78654beb6fe4… --- diff --git a/src/modules/pv_headers/pvh_func.c b/src/modules/pv_headers/pvh_func.c index 1fe3d58f07c..5cbeb143113 100644 --- a/src/modules/pv_headers/pvh_func.c +++ b/src/modules/pv_headers/pvh_func.c @@ -113,20 +113,20 @@ int pvh_collect_headers(struct sip_msg *msg) val_part.len = strlen(hvals[idx]); if(pvh_set_xavi(msg, &_pvh_params.xavi_name, &name, &val_part, SR_XTYPE_STR, 0, 1) - < 0) + == NULL) return -1; } continue; } if(pvh_set_xavi( msg, &_pvh_params.xavi_name, &name, &val, SR_XTYPE_STR, 0, 1) - < 0) + == NULL) return -1; } if(pvh_set_xavi(msg, &_pvh_params.xavi_helper_xname, &xavi_helper_name, &_pvh_params.xavi_name, SR_XTYPE_STR, 0, 0) - < 0) + == NULL) return -1; pvh_hdrs_set_collected(msg);

1 0

git:master:cf53743b: presence: use internal wrapper to get int time values
by Daniel-Constantin Mierla 16 May '25

16 May '25

Module: kamailio Branch: master Commit: cf53743ba79b60724150738eb482473043925ffc URL: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-16T10:33:21+02:00 presence: use internal wrapper to get int time values --- Modified: src/modules/presence/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… Patch: https://github.com/kamailio/kamailio/commit/cf53743ba79b60724150738eb482473… --- diff --git a/src/modules/presence/notify.c b/src/modules/presence/notify.c index 191cac0d04b..6c86a5237e7 100644 --- a/src/modules/presence/notify.c +++ b/src/modules/presence/notify.c @@ -297,7 +297,7 @@ int get_wi_subs_db(subs_t *subs, watcher_t *watchers) query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; query_vals[n_query_cols].val.int_val = - (int)time(NULL) + pres_expires_offset; + ksr_time_sint(NULL, NULL) + pres_expires_offset; n_query_cols++; result_cols[status_col = n_result_cols++] = &str_status_col; @@ -367,7 +367,7 @@ str *get_wi_notify_body(subs_t *subs, subs_t *watcher_subs) unsigned int hash_code; subs_t *s = NULL; int state = FULL_STATE_FLAG; - unsigned int now = (int)time(NULL); + unsigned int now = ksr_time_uint(NULL, NULL); hash_code = 0; version_str = int2str(subs->version, &len); @@ -655,7 +655,7 @@ str *ps_db_get_p_notify_body( query_cols[n_query_cols] = &str_expires_col; query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; - query_vals[n_query_cols].val.int_val = (int)time(NULL); + query_vals[n_query_cols].val.int_val = ksr_time_sint(NULL, NULL); query_ops[n_query_cols] = OP_GT; n_query_cols++; } @@ -891,7 +891,7 @@ str *ps_cache_get_p_notify_body( ptm.domain = uri.host; ptm.event = event->name; if(pres_startup_mode == 1) { - ptm.expires = (int)time(NULL); + ptm.expires = ksr_time_sint(NULL, NULL); } ptlist = ps_ptable_search(&ptm, 1, pres_retrieve_order); @@ -1343,10 +1343,11 @@ int get_subs_db( s.event = event; s.local_cseq = row_vals[cseq_col].val.int_val + 1; if(row_vals[expires_col].val.int_val - < (int)time(NULL) + pres_expires_offset) + < ksr_time_sint(NULL, NULL) + pres_expires_offset) s.expires = 0; else - s.expires = row_vals[expires_col].val.int_val - (int)time(NULL); + s.expires = row_vals[expires_col].val.int_val + - ksr_time_sint(NULL, NULL); s.version = row_vals[version_col].val.int_val + 1; s.flags = row_vals[flags_col].val.int_val; s.user_agent.s = (char *)row_vals[user_agent_col].val.string_val; @@ -1401,7 +1402,7 @@ subs_t *get_subs_dialog(str *pres_uri, pres_ev_t *event, str *sender) printf_subs(s); - if(s->expires < (int)time(NULL)) { + if(s->expires < ksr_time_sint(NULL, NULL)) { LM_DBG("expired subs\n"); continue; } @@ -1420,7 +1421,7 @@ subs_t *get_subs_dialog(str *pres_uri, pres_ev_t *event, str *sender) lock_release(&subs_htable[hash_code].lock); goto error; } - s_new->expires -= (int)time(NULL); + s_new->expires -= ksr_time_sint(NULL, NULL); s_new->next = s_array; s_array = s_new; } @@ -2883,7 +2884,7 @@ int process_dialogs(int round, int presence_winfo) int end_transaction = 0; subs_t sub; str ev_sname, winfo = str_init("presence.winfo"); - int now = (int)time(NULL); + int now = ksr_time_sint(NULL, NULL); int updated = 0; int no_active_watchers = 0; db_query_f query_fn = pa_dbf.query_lock ? pa_dbf.query_lock : pa_dbf.query; @@ -3228,7 +3229,7 @@ void ps_active_watchers_db_timer_clean(unsigned int ticks, void *param) db_ops[0] = OP_LT; db_vals[0].type = DB1_INT; db_vals[0].nul = 0; - db_vals[0].val.int_val = (int)time(NULL); + db_vals[0].val.int_val = ksr_time_sint(NULL, NULL); db_keys[1] = &str_expires_col; db_ops[1] = OP_GT;

1 0

[kamailio/kamailio] kamailio.pid does not exist -- Kamailio start failed (Issue #4243)
by nochnoi82 16 May '25

16 May '25

nochnoi82 created an issue (kamailio/kamailio#4243) Greetings folks. Need your help or conclusion. Debian 12 Kamailio 6.0.1 (Open source installed) Init script and systemd script were applied. kamctl start (/usr/local/sbin) ERROR: PID file /var/run/kamailio.pid does not exist -- Kamailio start failed kamailio start (/usr/local/sbin) error: 'start' is not a supported argument error: stopping kamailio ... sudo journalctl -xeu kamailio ERROR: db_mysql [km_my_con.c:219]: db_mysql_new_connection(): driver error: Access denied for user 'kamailio'@'localhost' (using password: YES) May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [lib/srdb1/db.c:326]: db_do_init2(): could not add connection to the pool May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: usrloc [dlist.c:848]: register_udomain(): failed to open database connection May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: registrar [registrar.c:773]: domain_fixup(): failed to register domain May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:750 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/rvalue.c:3816]: fix_rval_expr(): failure in cfg at line: 750 col: 22 May 15 11:50:54 zaks-sbc01-op /usr/local/sbin/kamailio[53616]: ERROR: <core> [core/route.c:1195]: fix_actions(): fixing failed (code=-1) at cfg:/usr/local/etc/kamailio/kamailio.cfg:753 Kamailio acts as proxy server only. What did i miss? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4243 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4243(a)github.com>

3 4

git:master:57ec3497: pv: added $tts variable
by Daniel-Constantin Mierla 15 May '25

15 May '25

Module: kamailio Branch: master Commit: 57ec3497c5a584850bd2883d6a6e8fd0535e11d7 URL: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-15T12:10:30+02:00 pv: added $tts variable - return to-tag state: 0 - if not set; 1 - if set --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… Patch: https://github.com/kamailio/kamailio/commit/57ec3497c5a584850bd2883d6a6e8fd… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 81781303049..89f5d5c2a14 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -398,6 +398,8 @@ static pv_export_t mod_pvs[] = { pv_init_iname, 5}, {{"tt", (sizeof("tt") - 1)}, /* */ PVT_OTHER, pv_get_to_attr, 0, 0, 0, pv_init_iname, 4}, + {{"tts", (sizeof("tts") - 1)}, /* */ + PVT_OTHER, pv_get_totagstate, 0, 0, 0, 0, 0}, {{"tu", (sizeof("tu") - 1)}, /* */ PVT_TO, pv_get_to_attr, pv_set_to_uri, 0, 0, pv_init_iname, 1}, {{"to", (sizeof("to") - 1)}, /* */ diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 56d96b20d75..a1064738bba 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -509,6 +509,27 @@ int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) return pv_get_xto_attr(msg, param, res, get_to(msg), 0); } +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) +{ + if(msg == NULL) + return pv_get_uintval(msg, param, res, 0); + + if(msg->to == NULL && parse_headers(msg, HDR_TO_F, 0) == -1) { + LM_ERR("cannot parse To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + if(msg->to == NULL || get_to(msg) == NULL) { + LM_DBG("no To header\n"); + return pv_get_uintval(msg, param, res, 0); + } + + if(get_to(msg)->tag_value.s != NULL && get_to(msg)->tag_value.len > 0) { + return pv_get_uintval(msg, param, res, 1); + } + + return pv_get_uintval(msg, param, res, 0); +} + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { if(msg == NULL) diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 16b14bf31cd..1341c9ba0f0 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -77,6 +77,8 @@ int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, int pv_get_to_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_totagstate(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); + int pv_get_from_attr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_get_cseq(struct sip_msg *msg, pv_param_t *param, pv_value_t *res);

1 0

[kamailio/kamailio] Topos not working Properly for ACK (Issue #4208)
by Pandi1981 14 May '25

14 May '25

Pandi1981 created an issue (kamailio/kamailio#4208) We are facing an issue while using TOPOS in Kamailio P-CSCF (running under Docker). Kamailio version: 6.0.0 operating system: "10 (buster)" **Call Flow & Issue Description:** Note: Public IP and Private IP mapping using the below configuration. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ listen=udp:LOCAL_IP:5060 name "internal" listen=udp:LOCAL_IP:6080 advertise PUBLIC_IP:6080 name "external" ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ **Call Flow (INVITE):** A-Party --> Kamailio P-CSCF (Public IP) --> Kamailio P-CSCF (Private IP) --> Kamailio S-CSCF (Private IP) B-Party <-- Kamailio P-CSCF (Public IP) <-- Kamailio P-CSCF (Private IP) <-- Kamailio S-CSCF (Private IP) Everything works correctly up to the point where the 200 OK is received by the A-Party. However, when the A-Party sends the ACK, it is received by the Kamailio P-CSCF but is not forwarded to the B-Party. Upon investigation, we found that when Kamailio receives the ACK from the A-Party, the rr (Record-Route) module fails to recognize its own Route header and thus falls back to strict routing instead of performing loose routing. This results in an incorrect rewrite of the Request-URI of the ACK, causing it to fail to reach the B-Party. Essentially, the Route header is not popped as expected and the ACK routing breaks. TOPOS module is configured as follows: loadmodule "topos_redis.so" loadmodule "ndb_redis.so" loadmodule "topos.so" modparam("ndb_redis", "server", "name=tps;addr=127.0.0.1;port=6379;db=0") modparam("topos", "storage", "redis") modparam("topos_redis", "serverid", "tps") modparam("topos", "rr_update", 1) modparam("topos", "contact_mode", 1) modparam("topos", "xavu_field_a_contact", "a_contact") modparam("topos", "xavu_field_b_contact", "b_contact") modparam("topos", "xavu_cfg", "tps") Please guide us how to achieve and what we are doing wrong. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4208 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4208(a)github.com>

2 5

[kamailio/kamailio] tcp_main : Crash on local_timer_list_expire (Issue #4238)
by ctylihuai 14 May '25

14 May '25

ctylihuai created an issue (kamailio/kamailio#4238) ### Description The Kamailio “P” node responsible for 5G messaging encountered an unhandled exception and generated a core dump during operation . This node had been continuously running for over one month (34 days) without any issues, and the failure occurred only once . As of now, no reproducible steps have been identified to trigger the problem again ### Troubleshooting #### Reproduction It cannot be reproduced for the time being #### Debugging Data ``` (gdb) bt full #0 0x0000aaaac25ffd10 in local_timer_list_expire (l=0xaaaac29ef340 <tcp_main_ltimer>, t=1691001057, h=0xaaaac2a10158 <tcp_main_ltimer+134680>) at core/local_timer.c:193 tl = 0xaaaac2a7b528 <tcp_reader_ltimer+197384> ret = 0 #1 0x0000aaaac25ffe98 in local_timer_expire (h=0xaaaac29ef340 <tcp_main_ltimer>, t=1691001057) at core/local_timer.c:222 No locals. #2 0x0000aaaac260031c in local_timer_run (lt=0xaaaac29ef340 <tcp_main_ltimer>, saved_ticks=1691001057) at core/local_timer.c:245 __func__ = "local_timer_run" #3 0x0000aaaac2552bec in tcp_timer_run () at core/tcp_main.c:4875 ticks = 1691001057 #4 0x0000aaaac2555074 in tcp_main_loop () at core/tcp_main.c:5060 si = 0x0 r = 48 __func__ = "tcp_main_loop" #5 0x0000aaaac23d24b0 in main_loop () at main.c:1945 i = 48 pid = 0 si = 0x0 si_desc = "udp receiver child=47 sock=10.185.16.12:5060\000\000\000\000\000\027\065\215sw\247\235\060\346\256\310\377\377\000\000|\312p\302\252\252\000\000@\346\256\310\377\377\000\000\000\263\252\302\252\252\000\000\200\346\256\310\377\377\000\000\n\000\000\000\000\000\000\000\200\346\256\310\377\377\000\000\250\345=\302\252\252\000\000\200\346\256\310\377\377\000" nrprocs = 48 woneinit = 1 __func__ = "main_loop" #6 0x0000aaaac23de5f4 in main (argc=19, argv=0xffffc8aeebe8) at main.c:3212 cfg_stream = 0xaaaafeb0d260 c = -1 r = 0 tmp = 0xffffc8aefe85 "" tmp_len = -1484867064 port = 65535 proto = -1487420584 ahost = 0x0 aport = 0 options = 0xaaaac28ec2a0 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3762187974 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 ---Type <return> to continue, or q <return> to quit--- n_lst = 0xffffc8aee8f8 p = 0x0 st = {st_dev = 64772, st_ino = 4298835, st_mode = 16877, st_nlink = 2, st_uid = 103, st_gid = 105, st_rdev = 0, __pad1 = 0, st_size = 6, st_blksize = 4096, __pad2 = 0, st_blocks = 0, st_atim = { tv_sec = 0, tv_nsec = 0}, st_mtim = {tv_sec = 1733885384, tv_nsec = 0}, st_ctim = {tv_sec = 1737443001, tv_nsec = 2493470}, __glibc_reserved = {0, 0}} tbuf = "\210\351\256\310\377\377\000\000\204\351\256\310\377\377\000\000\002\b \200\002\b \200\260\351\256\310\377\377\000\000\234\303~\247\377\377\000\000\230e;\330\000\000\000\000\310*\201\247\377\377\000\000\330\fi\247\377\377\000\000\310\352\256\310\377\377\000\000\070\353\256\310\377\377\000\000\000\000\000\000\000\000\000\000@'\201\247\377\377\000\000\000\000\000\000\000\000\000\000X\352\256\310\377\377\000\000h\352\256\310\377\377\000\000\001", '\000' <repeats 15 times>, "\230e;\330\000\000\000\000h'\201\247\377\377\000\000\000\000\000\000\000\000\000\000X\352\256\310\377\377\000\000h\352\256\310\377\377\000\000\320\352\256\310\377\377\000\000\330\fi\247\377\377\000\000\210\351\256\310\377\377\000\000"... option_index = 12 long_options = {{name = 0xaaaac28ee678 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0xaaaac28e9410 "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0xaaaac28ee680 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0xaaaac28ee688 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0xaaaac28ee690 "substdef", has_arg = 1, flag = 0x0, val = 1026}, { name = 0xaaaac28ee6a0 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0xaaaac28ee6b0 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0xaaaac28ee6c0 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0xaaaac28ee6d0 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0xaaaac28ee6e0 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, { name = 0xaaaac28ee6f0 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0xaaaac28ee6f8 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0xaaaac28ee708 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0xaaaac28ee710 "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) p tl $30 = (struct timer_ln *) 0xaaaac2a7b528 <tcp_reader_ltimer+197384> (gdb) p *tl $31 = {next = 0x0, prev = 0xaaaac2a10158 <tcp_main_ltimer+134680>, expire = 0, initial_timeout = 0, data = 0x0, f = 0x0, flags = 0, slow_idx = 0} (gdb) p *h $10 = {next = 0x0, prev = 0xfff8adcef5d8} 循环打印 h->prev内容 $177 = (struct timer_ln *) 0xaaaac2a10158 <tcp_main_ltimer+134680> next = 0x0, prev = 0xfff8adcef5d8 $178 = (struct timer_ln * volatile) 0xfff8adcef5d8 next = 0xaaaac2a10158 <tcp_main_ltimer+134680>, prev = 0xfff9437ede60 $179 = (struct timer_ln *) 0xfff9437ede60 next = 0xfff8adcef5d8, prev = 0xfffa58c31970 $180 = (struct timer_ln *) 0xfffa58c31970 next = 0xfff9437ede60, prev = 0xaaaac2a1bd48 $181 = (struct timer_ln *) 0xaaaac2a1bd48 <tcp_main_ltimer+182792> next = 0xfffa58c31970, prev = 0xfffa53da92a8 $182 = (struct timer_ln *) 0xfffa53da92a8 next = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, prev = 0xfff96e22e0e0 $183 = (struct timer_ln *) 0xfff96e22e0e0 next = 0xfffa53da92a8, prev = 0xfffa4f642a28 $184 = (struct timer_ln *) 0xfffa4f642a28 next = 0xfff96e22e0e0, prev = 0xfff880261368 $185 = (struct timer_ln *) 0xfff880261368 next = 0xfffa4f642a28, prev = 0xfff99e55db30 $186 = (struct timer_ln *) 0xfff99e55db30 next = 0xfff880261368, prev = 0xfff99fe12eb0 $187 = (struct timer_ln *) 0xfff99fe12eb0 next = 0xfff99e55db30, prev = 0xfffa7f14dfa8 $188 = (struct timer_ln *) 0xfffa7f14dfa8 next = 0xfff99fe12eb0, prev = 0xaaaac2a21658 <tcp_main_ltimer+205592 $189 = (struct timer_ln *) 0xaaaac2a21658 <tcp_main_ltimer+205592> next = 0xfffa7f14dfa8, prev = 0xfff82902dfb8 $190 = (struct timer_ln *) 0xfff82902dfb8 next = 0xaaaac2a21658 <tcp_main_ltimer+205592>, prev = 0xfffa3728f340 $191 = (struct timer_ln *) 0xfffa3728f340 next = 0xfff82902dfb8, prev = 0xfff8f0b5ec40 $192 = (struct timer_ln *) 0xfff8f0b5ec40 next = 0xfffa3728f340, prev = 0xfffaa900c338 $193 = (struct timer_ln *) 0xfffaa900c338 next = 0xfff8f0b5ec40, prev = 0xfff888f53088 $194 = (struct timer_ln *) 0xfff888f53088 next = 0xfffaa900c338, prev = 0xfff79d06ff60 $195 = (struct timer_ln *) 0xfff79d06ff60 next = 0xfff888f53088, prev = 0xfff8eea80ff8 $196 = (struct timer_ln *) 0xfff8eea80ff8 next = 0xfffa38e4f870, prev = 0xfff83d1a6a18 $197 = (struct timer_ln *) 0xfff83d1a6a18 next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48 $198 = (struct timer_ln *) 0xfffa5c69fb48 next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58 $199 = (struct timer_ln *) 0xfff8b5c31c58 next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688 $200 = (struct timer_ln *) 0xfff9a4ac6688 next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200 $201 = (struct timer_ln *) 0xfff9e3ee0200 next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 $202 = (struct timer_ln *) 0xaaaac2a267b8 <tcp_main_ltimer+226424> next = 0xfff9e3ee0200, prev = 0xfff9b6b00188 $203 = (struct timer_ln *) 0xfff9b6b00188 next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870 $204 = (struct timer_ln *) 0xfffa38e4f870 next = 0xfff9b6b00188, prev = 0xfff8eea80ff8 $205 = (struct timer_ln *) 0xfff8eea80ff8 next = 0xfffa38e4f870, prev = 0xfff83d1a6a18 $206 = (struct timer_ln *) 0xfff83d1a6a18 next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48 $207 = (struct timer_ln *) 0xfffa5c69fb48 next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58 $208 = (struct timer_ln *) 0xfff8b5c31c58 next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688 $209 = (struct timer_ln *) 0xfff9a4ac6688 next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200 $210 = (struct timer_ln *) 0xfff9e3ee0200 next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424> $211 = (struct timer_ln *) 0xaaaac2a267b8 <tcp_main_ltimer+226424> next = 0xfff9e3ee0200, prev = 0xfff9b6b00188 $212 = (struct timer_ln *) 0xfff9b6b00188 next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870 $213 = (struct timer_ln *) 0xfffa38e4f870 next = 0xfff9b6b00188, prev = 0xfff8eea80ff8 (gdb) set $node = h->prev (gdb) while ($node != 0) >print *$node >set $node = $node->prev >end $50 = {next = 0xaaaac2a10158 <tcp_main_ltimer+134680>, prev = 0xfff9437ede60, expire = 1691004064, initial_timeout = 5760, data = 0xfff8adcef430, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $51 = {next = 0xfff8adcef5d8, prev = 0xfffa58c31970, expire = 1691004064, initial_timeout = 5760, data = 0xfff9437edcb8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $52 = {next = 0xfff9437ede60, prev = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, expire = 1691004064, initial_timeout = 5760, data = 0xfffa58c317c8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $53 = {next = 0xfffa58c31970, prev = 0xfffa53da92a8, expire = 3125221032, initial_timeout = 65529, data = 0xfffa51099620, f = 0xfff7f9d36838, flags = 4191381560, slow_idx = 65527} $54 = {next = 0xaaaac2a1bd48 <tcp_main_ltimer+182792>, prev = 0xfff96e22e0e0, expire = 1691004064, initial_timeout = 5760, data = 0xfffa53da9100, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $55 = {next = 0xfffa53da92a8, prev = 0xfffa4f642a28, expire = 1691004064, initial_timeout = 5760, data = 0xfff96e22df38, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $56 = {next = 0xfff96e22e0e0, prev = 0xfff880261368, expire = 1691004064, initial_timeout = 5760, data = 0xfffa4f642880, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $57 = {next = 0xfffa4f642a28, prev = 0xfff99e55db30, expire = 1691005489, initial_timeout = 5760, data = 0xfff8802611c0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $58 = {next = 0xfff880261368, prev = 0xfff99fe12eb0, expire = 1691005489, initial_timeout = 5760, data = 0xfff99e55d988, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $59 = {next = 0xfff99e55db30, prev = 0xfffa7f14dfa8, expire = 1691005489, initial_timeout = 5760, data = 0xfff99fe12d08, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $60 = {next = 0xfff99fe12eb0, prev = 0xaaaac2a21658 <tcp_main_ltimer+205592>, expire = 1691005489, initial_timeout = 5760, data = 0xfffa7f14de00, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $61 = {next = 0xfffa7f14dfa8, prev = 0xfff82902dfb8, expire = 888530032, initial_timeout = 65528, data = 0xfff81b870028, f = 0xfff798f80cc0, flags = 522077992, slow_idx = 65529} $62 = {next = 0xaaaac2a21658 <tcp_main_ltimer+205592>, prev = 0xfffa3728f340, expire = 1691005489, initial_timeout = 5760, data = 0xfff82902de10, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $63 = {next = 0xfff82902dfb8, prev = 0xfff8f0b5ec40, expire = 1691005489, initial_timeout = 5760, data = 0xfffa3728f198, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $64 = {next = 0xfffa3728f340, prev = 0xfffaa900c338, expire = 1691005489, initial_timeout = 5760, data = 0xfff8f0b5ea98, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $65 = {next = 0xfff8f0b5ec40, prev = 0xfff888f53088, expire = 1691005489, initial_timeout = 5760, data = 0xfffaa900c190, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $66 = {next = 0xfffaa900c338, prev = 0xfff79d06ff60, expire = 1691005489, initial_timeout = 5760, data = 0xfff888f52ee0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $67 = {next = 0xfff888f53088, prev = 0xfff8eea80ff8, expire = 1691005489, initial_timeout = 5760, data = 0xfff79d06fdb8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $68 = {next = 0xfffa38e4f870, prev = 0xfff83d1a6a18, expire = 1691006791, initial_timeout = 5760, data = 0xfff8eea80e50, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $69 = {next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48, expire = 1691006791, initial_timeout = 5760, data = 0xfff83d1a6870, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $70 = {next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58, expire = 1691006791, initial_timeout = 5760, data = 0xfffa5c69f9a0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $71 = {next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688, expire = 1691006791, initial_timeout = 5760, data = 0xfff8b5c31ab0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $72 = {next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200, expire = 1691006791, initial_timeout = 5760, data = 0xfff9a4ac64e0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $73 = {next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, expire = 1691006791, initial_timeout = 5760, data = 0xfff9e3ee0058, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $74 = {next = 0xfff9e3ee0200, prev = 0xfff9b6b00188, expire = 1429254648, initial_timeout = 65528, data = 0xfff88564eb80, f = 0xfff9cc7da958, flags = 881566008, slow_idx = 65529} $75 = {next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870, expire = 1691006791, initial_timeout = 5760, data = 0xfff9b6afffe0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $76 = {next = 0xfff9b6b00188, prev = 0xfff8eea80ff8, expire = 1691006791, initial_timeout = 5760, data = 0xfffa38e4f6c8, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $77 = {next = 0xfffa38e4f870, prev = 0xfff83d1a6a18, expire = 1691006791, initial_timeout = 5760, data = 0xfff8eea80e50, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $78 = {next = 0xfff8eea80ff8, prev = 0xfffa5c69fb48, expire = 1691006791, initial_timeout = 5760, data = 0xfff83d1a6870, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $79 = {next = 0xfff83d1a6a18, prev = 0xfff8b5c31c58, expire = 1691006791, initial_timeout = 5760, data = 0xfffa5c69f9a0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $80 = {next = 0xfffa5c69fb48, prev = 0xfff9a4ac6688, expire = 1691006791, initial_timeout = 5760, data = 0xfff8b5c31ab0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $81 = {next = 0xfff8b5c31c58, prev = 0xfff9e3ee0200, expire = 1691006791, initial_timeout = 5760, data = 0xfff9a4ac64e0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} ---Type <return> to continue, or q <return> to quit--- $82 = {next = 0xfff9a4ac6688, prev = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, expire = 1691006791, initial_timeout = 5760, data = 0xfff9e3ee0058, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} $83 = {next = 0xfff9e3ee0200, prev = 0xfff9b6b00188, expire = 1429254648, initial_timeout = 65528, data = 0xfff88564eb80, f = 0xfff9cc7da958, flags = 881566008, slow_idx = 65529} $84 = {next = 0xaaaac2a267b8 <tcp_main_ltimer+226424>, prev = 0xfffa38e4f870, expire = 1691006791, initial_timeout = 5760, data = 0xfff9b6afffe0, f = 0xaaaac2551690 <tcpconn_main_timeout>, flags = 512, slow_idx = 0} ``` #### Log Messages ``` 2025-05-02T05:39:54.151913300Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([49.69.41.98]:36121 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152035620Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7cd0a8ba0 r: 0xfff7cd0a8cc8 (-1) 2025-05-02T05:39:54.152046140Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([110.252.23.203]:27380 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152053220Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff9a1658f08 r: 0xfff9a1659030 (-1) 2025-05-02T05:39:54.152067100Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([240e:440:1b18:1fb3:22:da32:6be9:33e7]:50529 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5460) 2025-05-02T05:39:54.152468020Z 90(137) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([124.236.136.161]:13636 ->90(137) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152535370Z 87(134) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([111.61.229.67]:41796 ->87(134) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.152895350Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa8d174330 r: 0xfffa8d174458 (-1) 2025-05-02T05:39:54.152916500Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([240e:440:9a08:24:1444:71da:9ff4:a6e6]:57851 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5460) 2025-05-02T05:39:54.153179200Z 90(137) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa45cedc18 r: 0xfffa45cedd40 (-1) 2025-05-02T05:39:54.153425390Z 87(134) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfffa22771e70 r: 0xfffa22771f98 (-1) 2025-05-02T05:39:54.153520770Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff83da65638 r: 0xfff83da65760 (-1) 2025-05-02T05:39:54.153540580Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([2408:8431:6810:2e2:1cbb:1c9e:63e6:abf1]:61717 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [240e:954:2000:208::31]:5260) 2025-05-02T05:39:54.154460230Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7ccf40938 r: 0xfff7ccf40a60 (-1) 2025-05-02T05:39:54.154502480Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([123.182.115.202]:21533 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.154629490Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff89ae41378 r: 0xfff89ae414a0 (-1) 2025-05-02T05:39:54.154649140Z 84(131) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection timed out (110) ([183.199.201.13]:3125 ->84(131) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.154830180Z 84(131) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff9acc5d970 r: 0xfff9acc5da98 (-1) 2025-05-02T05:39:54.173624940Z 90(137) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff7de186590 r: 0xfff7de1866b8 (-1) 2025-05-02T05:39:54.325541260Z 117(164) ERROR: <core> [core/tcp_read.c:297]: tcp_read_data(): error reading: Connection reset by peer (104) ([171.114.149.119]:18629 ->117(164) ERROR: <core> [core/tcp_read.c:299]: tcp_read_data(): -> [10.185.18.67]:5260) 2025-05-02T05:39:54.325597230Z 117(164) ERROR: <core> [core/tcp_read.c:1556]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0xfff83556b7e0 r: 0xfff83556b908 (-1) 2025-05-02T05:39:54.395159000Z 41(88) ERROR: <core> [core/tcp_main.c:1406]: tcp_do_connect(): connect 183.198.156.45:1272 failed Cannot assign requested address 2025-05-02T05:39:54.395211960Z 41(88) ERROR: <core> [core/tcp_main.c:1409]: tcp_do_connect(): connect 183.198.156.45:1272: (99) Cannot assign requested address 2025-05-02T05:39:54.395220020Z 41(88) ERROR: <core> [core/tcp_main.c:1545]: tcpconn_finish_connect(): 183.198.156.45:1272: tcp_do_connect for 0xfff95f7037e0 failed 2025-05-02T05:39:54.395226280Z 41(88) ERROR: <core> [core/tcp_main.c:2200]: tcp_send(): 183.198.156.45:1272: tcpconn_finish_connect(0xfff95f7037e0) failed 2025-05-02T05:39:54.395232270Z 41(88) ERROR: tm [../../core/forward.h:290]: msg_send_buffer(): tcp_send failed 2025-05-02T05:39:54.395337640Z 41(88) ERROR: sl [sl_funcs.c:415]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL) 2025-05-02T05:39:54.484799620Z 19(66) ERROR: <core> [core/tcp_main.c:1406]: tcp_do_connect(): connect 1.202.124.130:54952 failed Cannot assign requested address 2025-05-02T05:39:54.484847710Z 19(66) ERROR: <core> [core/tcp_main.c:1409]: tcp_do_connect(): connect 1.202.124.130:54952: (99) Cannot assign requested address 2025-05-02T05:39:54.484882280Z 19(66) ERROR: <core> [core/tcp_main.c:1545]: tcpconn_finish_connect(): 1.202.124.130:54952: tcp_do_connect for 0xfff9c7c0d500 failed 2025-05-02T05:39:54.484889320Z 19(66) ERROR: <core> [core/tcp_main.c:2200]: tcp_send(): 1.202.124.130:54952: tcpconn_finish_connect(0xfff9c7c0d500) failed 2025-05-02T05:39:54.484894930Z 19(66) ERROR: tm [../../core/forward.h:260]: msg_send_buffer(): tcp_send failed 2025-05-02T05:39:54.484899790Z 19(66) ERROR: sl [sl_funcs.c:415]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL) 2025-05-02T05:39:54.759458370Z 118(165) CRITICAL: <core> [core/io_wait.h:594]: io_watch_del(): invalid fd 69, not in [0, 0) 2025-05-02T05:39:54.759506810Z 118(165) ERROR: <core> [core/tcp_read.c:1765]: tcpconn_read_timeout(): io_watch_del failed for 0xfff80ff7f860 id 65244425 fd 69, state 0, flags c018, main fd 48347 ([240e::31]:63566 -> [240e::31]:5460) note：[240e::31] is the service address of kamailio, hiding the real IP address . ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) fdc771 ``` * **Operating System**:  ``` OpenEuler 22.03 Linux localhost.localdomain 5.10.0-136.12.0.86.ctl3.x86_64 #1 SMP Fri Jan 13 08:18:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4238 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4238(a)github.com>

2 10

[kamailio/kamailio] rtpengine: select node with weight=0 if no other nodes online (Issue #4180)
by sergey-safarov 13 May '25

13 May '25

sergey-safarov created an issue (kamailio/kamailio#4180) ### Description I have installed two `rtpengine` instances and want to use them as an `active backup`. I want to use `backup` only when `active` is unavailable. Closest settings for this rtpengine node `weight` and want to use settings like ``` MariaDB [kamailio]> select * from rtpengine; +----+-------+---------------------------------+--------+----------+---------------------+ | id | setid | url | weight | disabled | stamp | +----+-------+---------------------------------+--------+----------+---------------------+ | 1 | 0 | udp6:[2005:84c0:bf:11::20]:2223 | 1 | 0 | 1900-01-01 00:00:01 | | 2 | 0 | udp6:[2005:84c0:bf:11::21]:2223 | 0 | 0 | 1900-01-01 00:00:01 | +----+-------+---------------------------------+--------+----------+---------------------+ ``` But in case `weight=0` node is not selected and handled as disabled. It will be fine do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. ### Expected behavior Do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. #### Actual observed behavior The node is not selected and handled as disabled when `weight=0`. #### Log Messages ``` rtpengine [rtpengine.c:3430]: rtpp_test(): rtpengine instance <udp6:[2005:84c0:bf:11::21]:2223> found, support for it enabled rtpengine [rtpengine.c:3883]: select_rtpp_node(): rtpengine failed to select new for calllen=27 callid=1-10824@2005:84c0:bf:11::22 rtpengine [rtpengine.c:3183]: rtpp_function_call(): no available proxies ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4180 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4180(a)github.com>

3 3

[kamailio/kamailio] WSS-connections show up as <null> in $tls_version and $tls_cypher_info (Issue #4167)
by Christian Berger 12 May '25

12 May '25

ChristianBergerSipgate created an issue (kamailio/kamailio#4167) Hi, we have found a potential bug. The pseudo variables return null for WSS connections. Example config: `xlog("L_INFO", "<mainLogic> REGISTER: TLS or WSS detected: fU=$fU tls_version=$tls_version tls_cipher_info=$tls_cipher_info ua=$ua\n");` Log output: `Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 310, "function": "get_version", "message": "TLS connection not found in select_version\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "ERROR", "module": "tls", "file": "tls_select.c", "line": 131, "function": "get_cur_connection", "message": "Transport protocol is not TLS (bug in config)\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "tls", "file": "tls_select.c", "line": 201, "function": "get_cipher", "message": "TLS connection not found in select_cipher\n" } Mar 7 08:37:28 sip-tcploadbalancer01 /usr/sbin/kamailio[1268940]: { "level": "INFO", "module": "xlog", "file": "xlog.c", "line": 278, "function": "", "message": "<mainLogic> REGISTER: TLS or WSS detected: fU=1125411e0 tls_version=<null> tls_cipher_info=<null> ua=webphone\n" }` As you can see both tls_version and tls_cipher_info return <null> even though the underlying connection is via WSS. We have looked into it, and it seems like `get_cur_connection` in `modules/tls/tls_select.c` only checks for TLS, but not WSS. ``` struct tcp_connection *get_cur_connection(struct sip_msg *msg) { struct tcp_connection *c; if(_tls_pv_con != 0) return _tls_pv_con; if(msg->rcv.proto != PROTO_TLS) { ERR("Transport protocol is not TLS (bug in config)\n"); return 0; } c = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, cfg_get(tls, tls_cfg, con_lifetime)); if(c && c->type != PROTO_TLS) { ERR("Connection found but is not TLS\n"); tcpconn_put(c); return 0; } return c; } ``` We think that checking for `PROTO_WSS` might solve the issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4167 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4167(a)github.com>

4 5

[kamailio/kamailio] dispatcher: OPTIONS check does not triggered after new target added (Issue #4212)
by sergey-safarov 12 May '25

12 May '25

sergey-safarov created an issue (kamailio/kamailio#4212) ### Description When I add a new dispatcher target using the kamcmd command, then kamailio does not start send OPTIONS. #### Reproduction Need to start Kamailio with config file ``` listen=eth0 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/dev/null") route{ xerr("TEST $ci\n"); drop; } ``` And then execute comands ``` kamcmd dispatcher.add 1 "sip:sip.telnyx.com:5060;transport=tcp" 8 kamcmd dispatcher.list ``` After the last command expected output ``` { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:sip.telnyx.com:5060;transport=tcp FLAGS: AP PRIORITY: 0 } } } } } ``` As you can see, the target has `AP` flags, which means the target is active and probing enabled. But no OPTIONS messages were sent. #### Log Messages Here is kamailio debug output for during kamcmd execitions and some time after ``` 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 68 12(94363) DEBUG: <core> [core/dns_cache.c:533]: _dns_hash_find(): (sip.telnyx.com(14), 1), h=507 12(94363) DEBUG: <core> [core/resolve.c:1021]: get_record(): skipping 0 NS (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/resolve.c:1035]: get_record(): parsing 0 ARs (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/dns_cache.c:1699]: dns_get_related(): (0x7fce63a32000 (sip.telnyx.com, 1), 1, *(nil)) (0) 12(94363) DEBUG: <core> [core/dns_cache.c:1702]: dns_get_related(): record not alone: 0x7fce63a32000 - type: 1 12(94363) DEBUG: <core> [core/dns_cache.c:748]: dns_cache_add_unsafe(): adding sip.telnyx.com(14) 1 (flags=0) at 507 12(94363) DEBUG: dispatcher [dispatch.c:768]: add_dest2list(): dest [1/1] <sip:sip.telnyx.com:5060;transport=tcp> 12(94363) DEBUG: dispatcher [dispatch.c:258]: ds_log_dst_cb(): dst>> 1 sip:sip.telnyx.com:5060;transport=tcp 8 0 (,0,0,0) 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 68 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 25 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 25 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 14.2.1 ``` * **Operating System**:  ``` root@nout:~# cat /etc/os-release NAME="Fedora Linux" VERSION="41 (Workstation Edition)" RELEASE_TYPE=stable ID=fedora VERSION_ID=41 VERSION_CODENAME="" PLATFORM_ID="platform:f41" PRETTY_NAME="Fedora Linux 41 (Workstation Edition)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:41" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=41 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=41 SUPPORT_END=2025-12-15 VARIANT="Workstation Edition" VARIANT_ID=workstation ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4212 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4212(a)github.com>

3 8

[kamailio/kamailio] Improve and document cdp module list_peers output (Issue #4226)
by Henning Westerholt 12 May '25

12 May '25

henningw created an issue (kamailio/kamailio#4226) Improve and document cdp module list_peers output Example output: reg03:~$ sudo kamcmd cdp.list_peers { Realm: YYY.com Identity: 212.XX.XX.3 Accept unknown peers: 0 Connect timeout: 5 Transaction timeout: 5 Default auth session timeout: 3600 Queue length: 32 Workers: 8 Peer count: 3 Peers: { FQDN: 212.XX.XX.1 Details: { State: R_Open Disabled: False Last used: 1745907094 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.2 Details: { State: R_Open Disabled: False Last used: -1406883582 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.3 Details: { State: R_Open Disabled: False Last used: 1745907095 Applications: { appid:vendorid: 4:10415 } } } } 1. Add list_peers command to module XML docs 2. Document State meaning (e.g. what means R_Open etc..) 3. Check/ probably cast time_t value to not output negative numbers -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4226 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4226(a)github.com>

1 2

Analysis regarding performance regressions OpenSSL 3.0/3.x
by Henning Westerholt 11 May '25

11 May '25

Hello, If somebody is using Kamailio in a larger environment with TLS, this new technical analysis and performance report from haproxy could be interesting: https://www.haproxy.com/blog/state-of-ssl-stacks The bottom-line - OpenSSL 3.0 will show serious performance regressions for larger TLS services with higher performance requirements. OpenSSL 3.1 and newer versions are a bit better, but still much slower in key operations. You should consider using the tls_wolfssl module or stay on OpenSSL 1.1.1. For the medium- to long-term we probably should observe how other OpenSSL libraries are developing and act accordingly for the tls modules. The haproxy project recommends besides using wolfssl also the aws-lc library. The situation regarding OpenSSL 3.x seems to be not easily fixable, as these regressions are caused from internal design decisions. Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

1 0

git:master:fdce48b0: modules: readme files regenerated - pv ... [skip ci]
by Kamailio Dev 11 May '25

11 May '25

Module: kamailio Branch: master Commit: fdce48b007d0bede3b1b18cc9249f8351a8ce220 URL: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-11T16:01:10+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83… Patch: https://github.com/kamailio/kamailio/commit/fdce48b007d0bede3b1b18cc9249f83…

1 0

git:master:57316690: pv: docs for the new xavp/i rm all functions
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: 57316690e96f8c458e9f83af7e102bfa816bf2cf URL: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: docs for the new xavp/i rm all functions --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… Patch: https://github.com/kamailio/kamailio/commit/57316690e96f8c458e9f83af7e102bf… --- diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml index 6a06bb717de..0d962a81ca5 100644 --- a/src/modules/pv/doc/pv_admin.xml +++ b/src/modules/pv/doc/pv_admin.xml @@ -726,6 +726,29 @@ xavi_child_sets("WhatEver", "FoO", "Count: $var(n)"); ... xavp_rm("x"); # same result as: $xavp(x) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavp_rm_all"> + <title> + <function moreinfo="none">xavp_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavp(rname). + </para> + <para> + The parameter has to be the name of XAVP in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavp_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavp_rm_all("x"); ... </programlisting> </example> @@ -750,6 +773,29 @@ xavp_rm("x"); ... xavi_rm("WhatEver"); # same result as: $xavi(whatever) = $null; +... + </programlisting> + </example> + </section> + <section id="pv.f.xavi_rm_all"> + <title> + <function moreinfo="none">xavi_rm_all(rname)</function> + </title> + <para> + Remove all the values of $xavi(rname). + </para> + <para> + The parameter has to be the name of XAVI in the root list. + It can be static or dynamic string (to include variables). + </para> + <para> + Function can be used from ANY ROUTE. + </para> + <example> + <title><function>xavi_rm_all</function> usage</title> + <programlisting format="linespecific"> +... +xavi_rm_all("WhatEver"); ... </programlisting> </example>

1 0

git:master:acf3f1eb: pv: added functions to remove all root xavp/xavi items
by Daniel-Constantin Mierla 11 May '25

11 May '25

Module: kamailio Branch: master Commit: acf3f1ebeebec1540d0e93a80c8df54fee939610 URL: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-11T15:57:50+02:00 pv: added functions to remove all root xavp/xavi items --- Modified: src/modules/pv/pv.c --- Diff: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… Patch: https://github.com/kamailio/kamailio/commit/acf3f1ebeebec1540d0e93a80c8df54… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index d5f21ebba65..81781303049 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -507,6 +507,7 @@ static int w_xavp_child_seti( static int w_xavp_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavp_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavp_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_sbranch_set_ruri(sip_msg_t *msg, char p1, char *p2); static int w_sbranch_append(sip_msg_t *msg, char p1, char *p2); @@ -519,6 +520,7 @@ static int w_xavi_child_seti( static int w_xavi_child_sets( sip_msg_t *msg, char *prname, char *pcname, char *pval); static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2); +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2); static int w_xavi_child_rm(sip_msg_t *msg, char *prname, char *pcname); static int w_xavp_lshift(sip_msg_t *msg, char *pxname, char *pidx); @@ -577,6 +579,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavp_rm", (cmd_function)w_xavp_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavp_rm_all", (cmd_function)w_xavp_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavp_child_rm", (cmd_function)w_xavp_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavi_child_seti", (cmd_function)w_xavi_child_seti, 3, @@ -585,6 +589,8 @@ static cmd_export_t cmds[] = { fixup_spve_all, fixup_free_spve_all, ANY_ROUTE}, {"xavi_rm", (cmd_function)w_xavi_rm, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"xavi_rm_all", (cmd_function)w_xavi_rm_all, 1, + fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"xavi_child_rm", (cmd_function)w_xavi_child_rm, 2, fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {"xavp_lshift", (cmd_function)w_xavp_lshift, 2, @@ -1645,6 +1651,56 @@ static int w_xavi_rm(sip_msg_t *msg, char *prname, char *p2) return w_xav_rm(msg, prname, p2, 1); } +/** + * + */ +static int ki_xav_rm_all(sip_msg_t *msg, str *rname, int _case) +{ + int ret; + if(_case) { + ret = xavi_rm_by_name(rname, 1, NULL); + } else { + ret = xavp_rm_by_name(rname, 1, NULL); + } + + return (ret == 0) ? 1 : ret; +} + +static int ki_xavp_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 0); +} + +static int ki_xavi_rm_all(sip_msg_t *msg, str *rname) +{ + return ki_xav_rm_all(msg, rname, 1); +} + +/** + * + */ +static int w_xav_rm_all(sip_msg_t *msg, char *prname, char *p2, int _case) +{ + str rname; + + if(fixup_get_svalue(msg, (gparam_t *)prname, &rname) < 0) { + LM_ERR("failed to get root xavp name\n"); + return -1; + } + + return ki_xav_rm_all(msg, &rname, _case); +} + +static int w_xavp_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 0); +} + +static int w_xavi_rm_all(sip_msg_t *msg, char *prname, char *p2) +{ + return w_xav_rm_all(msg, prname, p2, 1); +} + /** * */ @@ -3041,6 +3097,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavp_rm_all"), + SR_KEMIP_INT, ki_xavp_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavp_is_null"), SR_KEMIP_INT, ki_xavp_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, @@ -3196,6 +3257,11 @@ static sr_kemi_t sr_kemi_pvx_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("pvx"), str_init("xavi_rm_all"), + SR_KEMIP_INT, ki_xavi_rm_all, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("pvx"), str_init("xavi_is_null"), SR_KEMIP_INT, ki_xavi_is_null, { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git:master:35733d16: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 10 May '25

10 May '25

Module: kamailio Branch: master Commit: 35733d163829e6c9ffd5a5391da872ecf46f4fa1 URL: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-10T13:16:11+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… Patch: https://github.com/kamailio/kamailio/commit/35733d163829e6c9ffd5a5391da872e… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 6bfa6e44d81..be626d40c7c 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -2211,6 +2211,7 @@ kamcmd dlg.list_ctx greater comparison; 'lt' - match using integer lesser comparison. Integer comparison can be used only with 'start_ts' key. * mval - matching value. + * limit (optional) - limit of matched dialogs. RPC Command Format: ...

1 0

git:master:c66d9f72: dialog: add missing documentation for optional limit parameter for list_match
by Henning Westerholt 10 May '25

10 May '25

Module: kamailio Branch: master Commit: c66d9f7298aa1d76d1905b3388e3e55023baa5ae URL: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-05-10T11:07:56Z dialog: add missing documentation for optional limit parameter for list_match --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… Patch: https://github.com/kamailio/kamailio/commit/c66d9f7298aa1d76d1905b3388e3e55… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 4a522cd553e..2653f159ea4 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -2848,6 +2848,9 @@ dlg_set_state("early"); <listitem><para> <emphasis>mval</emphasis> - matching value. </para></listitem> + <listitem><para> + <emphasis>limit</emphasis> (optional) - limit of matched dialogs. + </para></listitem> </itemizedlist> <para>RPC Command Format:</para> <programlisting format="linespecific">

1 0

[kamailio/kamailio] cmake: switching deb rules (Issue #4053)
by Victor Seva 10 May '25

10 May '25

Opening this generic issue to track issues when trying to switch deb package generation to cmake: -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4053 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4053(a)github.com>

5 56

git:master:1f5afd30: app_jsdt: use snprintf() to build path instead of strcat()
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 1f5afd3044dd399a7a8b03430c9d2b899d044b5a URL: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T10:08:21+02:00 app_jsdt: use snprintf() to build path instead of strcat() --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… Patch: https://github.com/kamailio/kamailio/commit/1f5afd3044dd399a7a8b03430c9d2b8… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index 93383860379..53464f3ced5 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -459,7 +459,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) DIR *directory = NULL; struct dirent *dir_entry = NULL; size_t size_to_allocate = 0; - char full_path_to_file[255] = {0}; + char full_path_to_file[512] = {0}; size_t name_len = 0; directory = opendir(_sr_jsdt_load_dir.s); @@ -474,9 +474,8 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) name_len = strlen(dir_entry->d_name); if(name_len >= 3 && strcmp(dir_entry->d_name + name_len - 3, ".js") == 0) { - strcpy(full_path_to_file, _sr_jsdt_load_dir.s); - strcat(full_path_to_file, "/"); - strcat(full_path_to_file, dir_entry->d_name); + snprintf(full_path_to_file, 512, "%s/%s", _sr_jsdt_load_dir.s, + dir_entry->d_name); LM_DBG("loading js script file: %s from folder %.*s\n", dir_entry->d_name, _sr_jsdt_load_dir.len,

1 0

git:master:03c93484: app_jsdt: initialize allocated buffer
by Daniel-Constantin Mierla 08 May '25

08 May '25

Module: kamailio Branch: master Commit: 03c93484901928700d282a1684e4b6e4eaeed6c4 URL: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-08T09:59:25+02:00 app_jsdt: initialize allocated buffer --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… Patch: https://github.com/kamailio/kamailio/commit/03c93484901928700d282a1684e4b6e… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index b11d66aa519..93383860379 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -496,6 +496,7 @@ static int jsdt_load_dir(duk_context *ctx, const char *path) full_buffer = (char *)malloc(size_to_allocate); if(full_buffer) { + memset(full_buffer, 0, size_to_allocate); buf = full_buffer; allocated_len = size_to_allocate; }

1 0

[kamailio/kamailio] rtpengine: improve compatibility of rtpengine per call leg stats parsing (PR #4233)
by tsearle 08 May '25

08 May '25

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [*] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [*] PR should be backported to stable branches - [*] Tested changes locally - [*] Related to issue #4232 #### Description not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4233 -- Commit Summary -- * rtpengine: improve compatibility of rtpengine per call leg stats parsing -- File Changes -- M src/modules/rtpengine/rtpengine.c (19) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4233.patch https://github.com/kamailio/kamailio/pull/4233.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4233 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4233(a)github.com>

3 8

git:5.8:9fb936b7: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 5.8 Commit: 9fb936b75dd7a06ac8b9a012b03b7c85ca7884ab URL: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:41:50+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) (cherry picked from commit e3b1220b375b48f16ae361cfe592e8c1bd8e7649) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… Patch: https://github.com/kamailio/kamailio/commit/9fb936b75dd7a06ac8b9a012b03b7c8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 561384df566..81456c4faea 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4052,7 +4052,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4107,9 +4108,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:6.0:e3b1220b: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Torrey Searle 07 May '25

07 May '25

Module: kamailio Branch: 6.0 Commit: e3b1220b375b48f16ae361cfe592e8c1bd8e7649 URL: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Torrey Searle <torrey.searle(a)wavecrest.com> Date: 2025-05-07T16:40:06+02:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. (cherry picked from commit 992ee3df02148a940c255b8be7eb9d8e63465834) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… Patch: https://github.com/kamailio/kamailio/commit/e3b1220b375b48f16ae361cfe592e8c… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

[kamailio/kamailio] rtpengine: improve compatibility of per-leg statistics parsing (Issue #4232)
by tsearle 07 May '25

07 May '25

tsearle created an issue (kamailio/kamailio#4232) ### Description For getting A and B leg QoS stats, Kamailio expects there to be a SSRC key inside the Stream object. However some versions of rtpengine (tested with mr13.3.1.1) do not send this key. Looking at the master version of rtpengine, I see this key has been added to correspond to ingress SSRCs[0]. This patch adds a checking ingress SSRCs[0] as a fallback if SSRC ### Troubleshooting #### Reproduction use kamailio 6.0.1 and rtpengine mr13.3.1.1 using baresip as the calling and called party the following in the kamailio.cfg ``` modparam("rtpengine", "mos_A_label_pv", "$avp(mos_A_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_A_pv", "$avp(mos_min_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_A_pv", "$avp(mos_min_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_A_pv", "$avp(mos_min_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_A_pv", "$avp(mos_min_roundtrip_A)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_A_pv", "$avp(mos_max_mos_A)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_A_pv", "$avp(mos_max_packetloss_A)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_A_pv", "$avp(mos_max_jitter_A)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_A_pv", "$avp(mos_max_roundtrip_A)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_A_pv", "$avp(mos_average_mos_A)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_A_pv", "$avp(mos_average_packetloss_A)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_A_pv", "$avp(mos_average_jitter_A)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_A_pv", "$avp(mos_average_roundtrip_A)") modparam("rtpengine", "mos_B_label_pv", "$avp(mos_B_label)") #The name of a pseudovariable to hold the minimum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_min_B_pv", "$avp(mos_min_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_packetloss_B_pv", "$avp(mos_min_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_jitter_B_pv", "$avp(mos_min_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the minimum MOS value was encountered; modparam("rtpengine", "mos_min_roundtrip_B_pv", "$avp(mos_min_roundtrip_B)") #The name of a pseudovariable to hold the maximum encountered MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_max_B_pv", "$avp(mos_max_mos_B)") #The name of a pseudovariable to hold the amount of packetloss in percent at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_packetloss_B_pv", "$avp(mos_max_packetloss_B)") #The name of a pseudovariable to hold the amount of jitter in milliseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_jitter_B_pv", "$avp(mos_max_jitter_B)") #The name of a pseudovariable to hold the packet round-trip time in microseconds at the time the maximum MOS value was encountered; modparam("rtpengine", "mos_max_roundtrip_B_pv", "$avp(mos_max_roundtrip_B)") #The name of a pseudovariable to hold the average (median) MOS value for the call. The value typically has a range of 1.0 through 5.0. modparam("rtpengine", "mos_average_B_pv", "$avp(mos_average_mos_B)") #The name of a pseudovariable to hold the average (median) amount of packetloss in percent present throughout the call. modparam("rtpengine", "mos_average_packetloss_B_pv", "$avp(mos_average_packetloss_B)") #The name of a pseudovariable to hold the average (median) amount of jitter in milliseconds present throughout the call. modparam("rtpengine", "mos_average_jitter_B_pv", "$avp(mos_average_jitter_B)") #The name of a pseudovariable to hold the average (median) packet round-trip time in microseconds present throughout the call. modparam("rtpengine", "mos_average_roundtrip_B_pv", "$avp(mos_average_roundtrip_B)") ``` #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages ``` May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 3684, "function": "rtpp_function_call", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine hash table remove entry for callen=16 callid=3df537fef966eb1a viabranch=" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Aleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4508, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: looking for label 'Bleg_label'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4514, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tags" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Aleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4517, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got tag" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4522, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got label Bleg_label" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4525, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX label match" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4530, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got medias" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4532, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got media" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4537, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got streams" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4542, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX got stream type 4" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4543, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child 'local port'" } May 07 06:12:56 tst-ec1-blue-app-116 /usr/sbin/kamailio[3299]: { "level": "DEBUG", "module": "rtpengine", "file": "rtpengine.c", "line": 4546, "function": "parse_call_stats_1", "callid": "3df537fef966eb1a", "logprefix": "{BYE <null> 10.152.8.37 3df537fef966eb1a } ", "message": "rtpengine: XXX stream child val type 2" } ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4232 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4232(a)github.com>

2 2

git:master:992ee3df: rtpengine: improve compatibility of rtpengine per call leg stats parsing
by Richard Fuchs 07 May '25

07 May '25

Module: kamailio Branch: master Commit: 992ee3df02148a940c255b8be7eb9d8e63465834 URL: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Author: Torrey Searle <torrey.searle(a)wavecrest.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2025-05-07T09:06:19-04:00 rtpengine: improve compatibility of rtpengine per call leg stats parsing not all versions of rtpengine sends a key SSRC per stream. For those that do not the same information can be found in ingress SSRCs. Add logic to check for the SSRC value there if the SSRC key is not present. --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… Patch: https://github.com/kamailio/kamailio/commit/992ee3df02148a940c255b8be7eb9d8… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 49c942627cd..2401ad09cbd 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -4490,7 +4490,8 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, long long ssrc; char *endp; bencode_item_t *ssrc_list, *ssrc_key, *ssrc_dict, *tags, *tag_key, - *tag_dict, *medias, *media, *streams, *stream; + *tag_dict, *medias, *media, *streams, *stream, *ingress_ssrcs, + *ingress_ssrc; struct minmax_stats_vals min_vals = {.mos = 100}, max_vals = {.mos = -1}, average_vals = {.avg_samples = 0}, vals_decoded; @@ -4545,9 +4546,21 @@ static void parse_call_stats_1(struct minmax_mos_label_stats *mmls, (char *)stream->child->iov[1].iov_base); LM_DBG("rtpengine: XXX stream child val type %i\n", stream->child->sibling->type); - if((ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1)) - == -1) - continue; + ssrc = bencode_dictionary_get_integer(stream, "SSRC", -1); + if(ssrc == -1) { + ingress_ssrcs = bencode_dictionary_get_expect( + stream, "ingress SSRCs", BENCODE_LIST); + if(!ingress_ssrcs || !ingress_ssrcs->child) + continue; + LM_DBG("rtpengine: XXX got ingress SSRCs\n"); + ingress_ssrc = ingress_ssrcs->child; + if((ssrc = bencode_dictionary_get_integer( + ingress_ssrc, "SSRC", -1)) + == -1) { + continue; + } + } + /* got a valid SSRC to watch for */ ssrcs[num_ssrcs] = ssrc; LM_DBG("rtpengine: found SSRC '%lli' for label '%.*s'\n", ssrc,

1 0

git:master:f2a60cfa: pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci]
by Victor Seva 06 May '25

06 May '25

Module: kamailio Branch: master Commit: f2a60cfac4cf3a5a6d84e24f7845ab4faeacf45e URL: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-05-06T15:39:08+02:00 pkg/kamailio/deb: version set 6.1.0~dev1 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4… Patch: https://github.com/kamailio/kamailio/commit/f2a60cfac4cf3a5a6d84e24f7845ab4…

1 0

git:master:4405af93: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4405af938ec72c0482e85abb3abea7853c5a22bb URL: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T14:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README --- Diff: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78… Patch: https://github.com/kamailio/kamailio/commit/4405af938ec72c0482e85abb3abea78…

1 0

git:master:2e20c74f: app_jsdt: doc - fix section tags for loaddir
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 2e20c74fb03f2442cde5f3f69989a0ed914f542c URL: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:38:02+02:00 app_jsdt: doc - fix section tags for loaddir --- Modified: src/modules/app_jsdt/doc/app_jsdt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… Patch: https://github.com/kamailio/kamailio/commit/2e20c74fb03f2442cde5f3f69989a0e… --- diff --git a/src/modules/app_jsdt/doc/app_jsdt_admin.xml b/src/modules/app_jsdt/doc/app_jsdt_admin.xml index 6d139c29428..bbf2148b9b4 100644 --- a/src/modules/app_jsdt/doc/app_jsdt_admin.xml +++ b/src/modules/app_jsdt/doc/app_jsdt_admin.xml @@ -107,35 +107,31 @@ modparam("app_jsdt", "load", "/usr/local/etc/kamailio/js/myscript.js") </programlisting> </example> </section> - <section> - <title>Parameters</title> - <section id="app_jsdt.p.loaddir"> - <title> - <varname>loaddir</varname> (str) - </title> - <para> - Set the path to the folder containing JavaScript files to be loaded at startup. All - .js files in the folder will be loaded and combined into a single javascript script. - Then you can use jsdt_run(function, params) to execute a function from the - script at runtime. If you use it for KEMI configuration, - then it has to include the required functions. - </para> - <para> - <emphasis> - Default value is <quote>null</quote>. - </emphasis> - </para> - <example> - <title> - Set <varname>loaddir</varname> parameter - </title> - <programlisting format="linespecific"> - ... - modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") - ... - </programlisting> - </example> - </section> + <section id="app_jsdt.p.loaddir"> + <title><varname>loaddir</varname> (str)</title> + <para> + Set the path to the folder containing JavaScript files to be loaded at startup. All + .js files in the folder will be loaded and combined into a single javascript script. + Then you can use jsdt_run(function, params) to execute a function from the + script at runtime. If you use it for KEMI configuration, + then it has to include the required functions. + </para> + <para> + <emphasis> + Default value is <quote>null</quote>. + </emphasis> + </para> + <example> + <title> + Set <varname>loaddir</varname> parameter + </title> + <programlisting format="linespecific"> +... +modparam("app_jsdt", "loaddir", "/usr/local/etc/kamailio/js") +... +</programlisting> + </example> + </section> <section id="app_jsdt.p.mode"> <title><varname>mode</varname> (int)</title> <para> @@ -328,4 +324,3 @@ request_route { </programlisting> </section> </chapter> -

1 0

git:master:7fa8b166: Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 7fa8b166bfc813270d19a30351326a94a9187852 URL: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T14:34:06+02:00 Makefile.defs/CMakeLists.txt: version set to 6.1.0-dev1 --- Modified: CMakeLists.txt Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… Patch: https://github.com/kamailio/kamailio/commit/7fa8b166bfc813270d19a30351326a9… --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 36451562d6f..6d68b5da980 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ project( ) # Set the version number -set(EXTRAVERSION "-dev0") +set(EXTRAVERSION "-dev1") set(RELEASE "${PROJECT_VERSION}${EXTRAVERSION}") message(STATUS "PROJECT_VERSION: ${PROJECT_VERSION}") diff --git a/src/Makefile.defs b/src/Makefile.defs index 7656029123e..6ff7eeddb51 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 6 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -dev0 +EXTRAVERSION = -dev1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

[kamailio/kamailio] cdp: restructure locking order to prevent rare deadlock (PR #4191)
by Morten Tryfoss 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description We've been running the ims_charging module in production for quite some time, without any issues. A couple of days ago the whole instance freezed, but I was able to get a dump before the stuck processes before restarting. The traffic volume has gradually increased over time, so it's likely related to that. I then did a summary of the different types of stuck processes. Which locks they're holding, and what they're waiting for: ``` holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8cde in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:108 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7fe6e4a5ba30) at peermanager.c:259 #3 0x00007fe70ebb64b7 in get_first_connected_route (cdp_session=0x7fe6e5cc5350, r=0x7fe6e4a5ba30, app_id=4, vendor_id=10415) at routing.c:115 #4 0x00007fe70ebb9a37 in get_routing_peer (cdp_session=0x7fe6e5cc5350, m=0x7fe6e5447ab0) at routing.c:293 #5 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5447ab0, callback_f=0x7fe707a9e323 <resume_on_initial_ccr>, callback_param=0x7fe6e5297110) at diameter_comm.c:139 #6 0x00007fe707a9d3e0 in Ro_Send_CCR (msg=0x7fe70f011100, dlg=0x7fe6e5c571f0, dir=0, reservation_units=30, incoming_trunk_id=0x7ffe50efb060, outgoing_trunk_id=0x7ffe50efb050, pani=0x7ffe50efaee0, action=0x7fe70efa4730, tindex=10484, tlabel=677172593) at ims_ro.c:1511 #7 0x00007fe707a8285d in ki_ro_ccr (msg=0x7fe70f011100, s_route_name=0x7ffe50efb080, s_direction=0x7ffe50efb070, reservation_units=30, s_incoming_trunk_id=0x7ffe50efb060, s_outgoing_trunk_id=0x7ffe50efb050) at ims_charging_mod.c:742 #8 0x00007fe707a7bf01 in w_ro_ccr (msg=0x7fe70f011100, c_route_name=0x7fe70ef8b8d0 "\220\311\371\016\347\177", c_direction=0x7fe70ef8b980 "p\240\371\016\347\177", reservation_units=30, c_incoming_trunk_id=0x7fe70ef8ba30 "p\241\371\016\347\177", c_outgoing_trunk_id=0x7fe70ef8bae0 "\360\241\371\016\347\177") at ims_charging_mod.c:507 #9 0x00000000004858d8 in do_action (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1144 #10 0x00000000004928d6 in run_actions (h=0x7ffe50efb970, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1618 #11 0x0000000000492f52 in run_actions_safe (h=0x7ffe50eff1e0, a=0x7fe70ef99e20, msg=0x7fe70f011100) at core/action.c:1681 #12 0x0000000000450156 in rval_get_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, i=0x7ffe50efbec8, rv=0x7fe70ef9c1d8, cache=0x0) at core/rvalue.c:973 #13 0x0000000000454d24 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efbec8, rve=0x7fe70ef9c1d0) at core/rvalue.c:1854 #14 0x0000000000454d52 in rval_expr_eval_long (h=0x7ffe50eff1e0, msg=0x7fe70f011100, res=0x7ffe50efc448, rve=0x7fe70ef9b920) at core/rvalue.c:1864 #15 0x00000000004850ce in do_action (h=0x7ffe50eff1e0, a=0x7fe70ef9b070, msg=0x7fe70f011100) at core/action.c:1097 -- holding lock: AAASessionsLock waiting for lock: lock_get(peer_list_lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5c680) at ../../core/futexlock.h:121 #2 0x00007fe70ebaaca2 in get_peer_by_fqdn (fqdn=0x7ffe50efab90) at peermanager.c:259 #3 0x00007fe70ebb8e89 in get_routing_peer (cdp_session=0x7fe6e5ab6910, m=0x7fe6e5435be0) at routing.c:252 #4 0x00007fe70ebcaf8c in AAASendMessage (message=0x7fe6e5435be0, callback_f=0x7fe707a95edc <resume_on_termination_ccr>, callback_param=0x0) at diameter_comm.c:139 #5 0x00007fe707a95b02 in send_ccr_stop_with_param (ro_session=0x7fe6e5ab65e0, code=0, reason=0x7ffe50efb060) at ims_ro.c:1181 #6 0x00007fe707a72ff7 in dlg_terminated (dlg=0x7fe6e623d7a0, type=64, termcode=0, reason=0x7fe707ab72b3 "normal call clearing", _params=0x7fe707f67280 <params>) at dialog.c:249 #7 0x00007fe707a6a729 in dlg_callback_received (dlg=0x7fe6e623d7a0, type=64, _params=0x7fe707f67280 <params>) at dialog.c:25 #8 0x00007fe707d341b9 in run_dlg_callbacks (type=64, dlg=0x7fe6e623d7a0, req=0x7fe70f011100, rpl=0x0, dir=1, dlg_data=0x0) at dlg_cb.c:271 #9 0x00007fe707cf4db4 in dlg_terminated (req=0x7fe70f011100, dlg=0x7fe6e623d7a0, dir=1) at dlg_handlers.c:413 #10 0x00007fe707cfddeb in dlg_onroute (req=0x7fe70f011100, route_params=0x7ffe50efb6d0, param=0x0) at dlg_handlers.c:1097 #11 0x00007fe70ad285f6 in run_rr_callbacks (req=0x7fe70f011100, rr_param=0x7ffe50efb7c0) at rr_cb.c:96 #12 0x00007fe70ad3ae92 in after_loose (_m=0x7fe70f011100, preloaded=0) at loose.c:1021 #13 0x00007fe70ad3b5ce in loose_route_mode (_m=0x7fe70f011100, _mode=0) at loose.c:1056 #14 0x00007fe70ad3f74f in w_loose_route (msg=0x7fe70f011100, p1=0x0, p2=0x0) at rr_mod.c:273 #15 0x00000000004855ff in do_action (h=0x7ffe50efc390, a=0x7fe70efe0d40, msg=0x7fe70f011100) at core/action.c:1121 -- holding lock: lock_get(peer_list_lock); waiting for lock: lock_get(p->lock); #1 0x00007fe70eba8d4f in futex_get (lock=0x7fe6e4a5cbd0) at ../../core/futexlock.h:121 #2 0x00007fe70ebab0ae in peer_timer (now=1742807320, ptr=0x0) at peermanager.c:286 #3 0x00007fe70ebd0f39 in timer_loop () at timer.c:116 #4 0x00007fe70ebd21b2 in timer_process (returns=0) at timer.c:216 #5 0x00007fe70eb8ccf8 in diameter_peer_start (blocking=0) at diameter_peer.c:350 #6 0x00007fe70eb7cbb2 in cdp_child_init (rank=0) at cdp_mod.c:272 -- holding lock: lock_get(p->lock) waiting for lock: AAASessionsLock #1 0x00007fe70ebf2597 in futex_get (lock=0x7fe6e4a5d490) at ../../core/futexlock.h:108 #2 0x00007fe70ebf26f1 in AAASessionsLock (hash=0) at session.c:79 #3 0x00007fe70ebf5e6e in cdp_get_session (id=...) at session.c:316 #4 0x00007fe70eba6892 in Snd_Message (p=0x7fe6e4a5c880, msg=0x7fe6e63998d0) at peerstatemachine.c:1237 #5 0x00007fe70eba003e in sm_process (p=0x7fe6e4a5c880, event=Send_Message, msg=0x7fe6e63998d0, peer_locked=0, sock=0) at peerstatemachine.c:429 #6 0x00007fe70ebcbdc6 in AAASendMessage (message=0x7fe6e63998d0, callback_f=0x7fe707a8f208 <resume_on_interim_ccr>, callback_param=0x7fe6e6190a90) at diameter_comm.c:166 #7 0x00007fe707a8edb3 in send_ccr_interim (ro_session=0x7fe6e5399160, used=60, reserve=30) at ims_ro.c:847 #8 0x00007fe707a68bd6 in ro_session_ontimeout (tl=0x7fe6e5399200) at ro_timer.c:513 #9 0x00007fe707a63078 in ro_timer_routine (ticks=114862426, attr=0x0) at ro_timer.c:279 #10 0x00000000004fd33e in compat_old_handler (ti=1837798827, tl=0x7fe6e4cf6260, data=0x7fe6e4cf6260) at core/timer.c:980 #11 0x00000000004fde7a in slow_timer_main () at core/timer.c:1103 #12 0x000000000042e4e7 in main_loop () at main.c:1911 #13 0x000000000043876c in main (argc=10, argv=0x7ffe50f001c8) at main.c:3236 ``` In `get_first_connected_route()` in `routing.c` of the cdp module there are two places `get_peer_by_fqdn()` are called. One of them has an unlock/relock of the session list before and after (and a comment about holding two locks at a time), while the other doesn't. I'm currently testing two version of this. The first by just doing the some relock for the other `get_peer_by_fqdn()`, but this PR got an approach for maybe fixing more latent issues. `sm_process()` also got some strange handling by `Rcv_Process()` after the peer lock is released, which seems to be about the same thing. My deadlock is for the `Snd_Message()` equivalent. I've now removed this queueing behaviour, and instead doing a re-lock of the peer to (hopefully) have the same locking order as the other operations. The problem with this thing is how rare it occurs. Just wanted to share my findings for others with more knowledge to the cdp module for comments, suggestions and hopefully some extra testing. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4191 -- Commit Summary -- * cdp: restructure locking order to prevent rare deadlock -- File Changes -- M src/modules/cdp/peerstatemachine.c (25) M src/modules/cdp/routing.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4191.patch https://github.com/kamailio/kamailio/pull/4191.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4191 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4191(a)github.com>

4 13

git:master:12bfe206: modules: readme files regenerated - app_jsdt ... [skip ci]
by Kamailio Dev 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 12bfe206daa6b9c2e8aa73e0d0da416d6593fd4e URL: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-05-06T13:46:10+02:00 modules: readme files regenerated - app_jsdt ... [skip ci] --- Modified: src/modules/app_jsdt/README Modified: src/modules/cdp/README Modified: src/modules/stirshaken/README --- Diff: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416… Patch: https://github.com/kamailio/kamailio/commit/12bfe206daa6b9c2e8aa73e0d0da416…

1 0

[kamailio/kamailio] stirshaken: removed repeated x509 certification path check (PR #4202)
by Felipe Cuadra Plaza 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Currently `stirshaken` module performs x509 certificate path check twice (when enabled): - first by calling `stir_shaken_verify_cert_path` directly from the [`stirshaken_mod.c`](https://github.com/kamailio/kamailio/blob/330543f46cbb6bf815ebf77c98378314091197ce/src/modules/stirshaken/stirshaken_mod.c#L626) - second time from the [`libstirshaken`](https://github.com/signalwire/libstirshaken/blame/cb6ede40b3ce12ab76e370186a14dc141839ef07/src/stir_shaken_verify.c#L445) `libstirshaken` had the path check built in since approx 2020 ([last commit mentioning it as TODO](https://github.com/signalwire/libstirshaken/blame/552650e31e3dc668069… before the `stir_shaken_verify_cert_path` function was introduced). This shouldn't be an issue since `stirshaken` module was added to Kamailio in 2021. This PR removes the x509 certificate path check from the `stirshaken_mod.c` by passing the responsibility to perform certificate path check to the `libstirshaken`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4202 -- Commit Summary -- * stirshaken: removed repeated x509 certification path check -- File Changes -- M src/modules/stirshaken/doc/stirshaken_admin.xml (4) M src/modules/stirshaken/stirshaken_mod.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4202.patch https://github.com/kamailio/kamailio/pull/4202.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4202 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4202(a)github.com>

2 2

git:master:f007736b: stirshaken: removed repeated x509 certification path check
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: f007736ba18f5cc2114ffdd1e6df2b9b03808fe7 URL: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… Author: FelipeCuadra <f.cuadra(a)zaleos.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:34:41+02:00 stirshaken: removed repeated x509 certification path check - removed a second check of the x509 certificate path from the module, since it is already done earlier in the library and updated documentation --- Modified: src/modules/stirshaken/doc/stirshaken_admin.xml Modified: src/modules/stirshaken/stirshaken_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… Patch: https://github.com/kamailio/kamailio/commit/f007736ba18f5cc2114ffdd1e6df2b9… --- diff --git a/src/modules/stirshaken/doc/stirshaken_admin.xml b/src/modules/stirshaken/doc/stirshaken_admin.xml index ef07e6a7212..41f72e5c1b7 100644 --- a/src/modules/stirshaken/doc/stirshaken_admin.xml +++ b/src/modules/stirshaken/doc/stirshaken_admin.xml @@ -528,6 +528,10 @@ request_route { ... </programlisting> </example> + <para> + To ensure proper functionality, the Kamailio stirshaken module requires a minimum version of libstirshaken that includes the stir_shaken_verify_cert_path function for performing the x509 certificate path check. This functionality was added to libstirshaken around 2020 (<![CDATA[https://github.com/signalwire/libstirshaken/commit/58e740b897ae40e2bb02ada2231a051a7eb55137]]>). + If you're using an older version of libstirshaken that predates this commit, the stirshaken module may not function correctly. + </para> </section> </chapter> diff --git a/src/modules/stirshaken/stirshaken_mod.c b/src/modules/stirshaken/stirshaken_mod.c index 95bbdeb5736..5d0bc744885 100644 --- a/src/modules/stirshaken/stirshaken_mod.c +++ b/src/modules/stirshaken/stirshaken_mod.c @@ -613,23 +613,6 @@ static int ki_stirshaken_check_identity(sip_msg_t *msg) goto fail; } - if(stirshaken_vs_verify_x509_cert_path) { - - LM_DBG("Running X509 certificate path verification\n"); - - if(!vs) { - LM_ERR("Verification Service not started\n"); - goto fail; - } - - if(STIR_SHAKEN_STATUS_OK - != stir_shaken_verify_cert_path(&ss, cert_out, vs->store)) { - LM_ERR("Cert did not pass X509 path validation\n"); - stirshaken_print_error_details(&ss); - goto fail; - } - } - if(stirshaken_vs_pptg_pvname.s != 0) { memset(&val, 0, sizeof(pv_value_t)); val.flags = PV_VAL_STR;

1 0

[kamailio/kamailio] app_jstd: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory (PR #4221)
by nickgashcc 06 May '25

06 May '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into separate .js files but load them all into the JavaScript engine. - Updated documentation You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4221 -- Commit Summary -- * app_jstd: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory -- File Changes -- M src/modules/app_jsdt/app_jsdt_api.c (175) M src/modules/app_jsdt/app_jsdt_mod.c (2) M src/modules/app_jsdt/doc/app_jsdt_admin.xml (31) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4221.patch https://github.com/kamailio/kamailio/pull/4221.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4221 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4221(a)github.com>

2 9

git:master:4ed24494: app_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4ed2449454d07594f9bc30622b7fada9d719c5a3 URL: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada… Author: ngash <nick.gash(a)ccprosolutions.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:33:50+02:00 app_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into seperate .js files but load them all inbto the JavaScript engine. - Updated documentation accordinglyapp_jsdt: Added dynamic buffer sizing to load bigger .js files and Added ability to load all JavaScript files from a specified directory - The code that loaded a JavaScript file used a fix buffer length of 128K on the stack. This has been changed so that the file size is determined and an attempt to allocate an appropriate buffer size temporarily is made. The file contents are then loaded into that buffer before being passed to the duktape engine. - In addition a new module param 'loaddir' has been added that allows you to specify a directory containing .js files rather than specifying a single .js file to load with the existing 'load' param. If loaddir is set it will take a higher priority than load. All .js files in the directory are loaded into a temporary buffer and combined before passing to the duktape engine. This allows you to split logic/routes into seperate .js files but load them all inbto the JavaScript engine. - Updated documentation accordingly --- Modified: src/modules/app_jsdt/app_jsdt_api.c Modified: src/modules/app_jsdt/app_jsdt_mod.c Modified: src/modules/app_jsdt/doc/app_jsdt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada… Patch: https://github.com/kamailio/kamailio/commit/4ed2449454d07594f9bc30622b7fada…

1 0

[kamailio/kamailio] Feature/tcp/tls domain matching (PR #4222)
by Michael Furmur 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description PR adds new core option `tls_connection_match_domain` with the default value 0 (old behavior) to solve the problem when we need to have multiple TLS connections with different SNI to the same host:port endpoint. for example: multiple customers (authorized by cert) for MS Teams on the single kamailio instance. originally, functions `_tcpconn_find` and `_tcpconn_add_alias_unsafe` use only endpoint and protocol to match connections. setting `tls_connection_match_domain` to `1` will match additionaly with `tls_domain_str()` output for matched TLS domain. as a result, we will be able to establish new TLS connections if TLS domain is changed instead of reusing of the existent one with the wrong SNI. i'm not considering this PR as the final version but we need something to start with. looking forward for any input. FIXME: not found the right place where new core option should be documented. #### Behavior difference example * /etc/kamailio/kamailio.cfg (relays all requests to 127.0.0.1:5081 using TLS domain matched by server_id retreived from RURI-User): ``` #!KAMAILIO listen=udp:127.0.0.1:5060 listen=tls:127.0.0.1:5061 enable_tls = yes tls_connection_match_domain = 1 debug = 3 loadmodule "tls.so" modparam("tls", "config", "/etc/kamailio/tls.cfg") modparam("tls", "xavp_cfg", "tls") loadmodule "ctl.so" loadmodule "pv.so" loadmodule "tm.so" route { $xavp(tls=>server_id) = $rU; t_relay_to_tls("127.0.0.1", 5081); } ``` * /etc/kamailio/tls.cfg: ``` [server:default] certificate = /etc/ssl/certs/ssl-cert-snakeoil.pem private_key = /etc/ssl/private/ssl-cert-snakeoil.key [client:any] server_name = server_name_1.invalid server_id = 1 [client:any] server_name = server_name_2.invalid server_id = 2 ``` * run tls server: ```bash $ openssl s_server -port 5081 -cert /etc/ssl/certs/ssl-cert-snakeoil.pem -key /etc/ssl/private/ssl-cert-snakeoil.key ``` * send `INVITE sip:1@127.0.0.1:5060` and `INVITE sip:2@127.0.0.1:5060` using sipp: ```bash $ for u in 1 2; do sipp -sn uac -m 1 -nd -recv_timeout 1 -bg -s $u 127.0.0.1:5060; done ``` * resulting `tls.list` for kamailio instance WITHOUT `tls_connection_match_domain = 1` (old behavior): ```bash # kamcmd tls.list { id: 1 dom: TLSc<any:server_name_1.invalid> sni: N/A timestamp: 2025-04-24 14:07:20 timeout: 118 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 58808 cipher: unknown ct_wq_size: 1162 enc_rd_buf: 0 flags: 1 state: tls_connect } ``` * `tls.list` for kamailio instance WITH `tls_connection_match_domain = 1` (new behavior): ```bash # kamcmd tls.list { id: 1 dom: TLSc<any:server_name_1.invalid> sni: N/A timestamp: 2025-04-24 14:09:10 timeout: 117 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 55480 cipher: unknown ct_wq_size: 581 enc_rd_buf: 0 flags: 1 state: tls_connect } { id: 2 dom: TLSc<any:server_name_2.invalid> sni: N/A timestamp: 2025-04-24 14:09:10 timeout: 117 src_ip: 127.0.0.1 src_port: 5081 dst_ip: 127.0.0.1 dst_port: 55488 cipher: unknown ct_wq_size: 581 enc_rd_buf: 0 flags: 1 state: tls_connect } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4222 -- Commit Summary -- * core: support tls connection domain matching * tls: implement match_domain,match_connections_domain hooks * tls_wolfssl: implement match_domain,match_connections_domain hooks -- File Changes -- M src/core/cfg.lex (3) M src/core/cfg.y (9) M src/core/globals.h (1) M src/core/tcp_main.c (14) M src/core/tls_hooks.h (9) M src/main.c (4) M src/modules/tls/tls_mod.c (2) M src/modules/tls/tls_rpc.c (12) M src/modules/tls/tls_server.c (97) M src/modules/tls/tls_server.h (8) M src/modules/tls_wolfssl/tls_rpc.c (12) M src/modules/tls_wolfssl/tls_server.c (94) M src/modules/tls_wolfssl/tls_server.h (7) M src/modules/tls_wolfssl/tls_wolfssl_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4222.patch https://github.com/kamailio/kamailio/pull/4222.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4222 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4222(a)github.com>

2 4

git:master:fabf509a: tls_wolfssl: implement match_domain,match_connections_domain hooks
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: fabf509a7e2ce550f71554517346f873b8426ff6 URL: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 tls_wolfssl: implement match_domain,match_connections_domain hooks * save tls_domain_str() to the tls_extra_data and use it for connections matching * rpc tls.list: add 'dom' attribute --- Modified: src/modules/tls_wolfssl/tls_rpc.c Modified: src/modules/tls_wolfssl/tls_server.c Modified: src/modules/tls_wolfssl/tls_server.h Modified: src/modules/tls_wolfssl/tls_wolfssl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87… Patch: https://github.com/kamailio/kamailio/commit/fabf509a7e2ce550f71554517346f87…

1 0

git:master:98feec09: tls: implement match_domain,match_connections_domain hooks
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 98feec09b3cc0fe67d1a2f8484b5c9583a4beb21 URL: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 tls: implement match_domain,match_connections_domain hooks * save tls_domain_str() to the tls_extra_data and use it for connections matching * rpc tls.list: add 'dom' attribute --- Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_rpc.c Modified: src/modules/tls/tls_server.c Modified: src/modules/tls/tls_server.h --- Diff: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Patch: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95…

1 0

git:master:69f22ad4: core: support tls connection domain matching
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 69f22ad49be1302c884f47903d0e32d8491912fd URL: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 core: support tls connection domain matching * add tls_connection_match_domain core option (default: 0) * add match_domain, match_connections_domain tls hooks * modify _tcpconn_find, _tcpconn_add_alias_unsafe to use newly added tls hooks --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/globals.h Modified: src/core/tcp_main.c Modified: src/core/tls_hooks.h Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Patch: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev