<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #4226
#### Description
<!-- Describe your changes in detail -->
- Improve and add missing function documentation `list_peers`.
- Use correct identifier in `struct_add` rpc function and cast `time_t` for time_t field.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4227
-- Commit Summary --
* cdp: Cast time_t and use 'L' (long long) identifier in rpc function.
* cdp/docs: Add missing list_peers function
-- File Changes --
M src/modules/cdp/cdp_rpc.c (4)
M src/modules/cdp/doc/cdp_admin.xml (29)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4227.patchhttps://github.com/kamailio/kamailio/pull/4227.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4227
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4227(a)github.com>
- format as well
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #4227
#### Description
<!-- Describe your changes in detail -->
There was missing information of type identifiers that can be used in [rpc tutorial docs](https://www.kamailio.org/docs/docbooks/5.7.x/rpc_api/rpc_api.html#rpc…. This is an update to those docs. The most recent I could find was for 5.7.
Maybe there is a need for manual updating the page?
Also during the relevant PR #4227 , we found the `t` identifier is never used in the code. since it can overflow on 64bit systems due to being a `long` and not `int` type when saved/load, maybe we can remove it completely?. One can just cast the `time_t` to the relevant type and use the correct identifier as done in https://github.com/kamailio/kamailio/blob/2081b3aac394223b68b849fbac2a9e5ac…
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4228
-- Commit Summary --
* Update type identifiers that can be used in the RPC API
-- File Changes --
M doc/tutorials/rpc/kamailio_rpc.xml (86)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4228.patchhttps://github.com/kamailio/kamailio/pull/4228.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4228
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4228(a)github.com>
- len is first adjusted by the amount of chars consumed so far
- start pointer is then adjusted to begin new search
#### Pre-Submission Checklist
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #4229
#### Description
Small logic tweak — we adjust `len` by the amount of chars consumed first, then adjust the `start` pointer to begin the new search.
Existing:
```
start = space + 1;
len = len - (space - start + 1); // this is a no-op
// as the pointer was adjusted first
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4230
-- Commit Summary --
* core: sdp - update start pointer only after len adjustment
-- File Changes --
M src/core/parser/sdp/sdp_helpr_funcs.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4230.patchhttps://github.com/kamailio/kamailio/pull/4230.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4230
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4230(a)github.com>
space88man created an issue (kamailio/kamailio#4229)
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4229
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4229(a)github.com>
Fr-Soltanzadeh created an issue (kamailio/kamailio#4164)
### Description
In a IMS lab using Kamailio PCSCF, ICSCF and SCSCF default configs, I have used TOPOH module in PCSCF for topology hiding. Topoh config is as follows:
```
modparam("topoh", "mask_key", "my-key")
modparam("topoh", "mask_ip", "127.0.0.2")
modparam("topoh", "sanity_checks", 1)
```
As shown in attached traffic, SCSCF IP is not hided in 180 ringing and 200ok messages to the caller. In invite, ack and bye messages hiding is performed well.
[topoh.zip](https://github.com/user-attachments/files/19086420/topoh.zip)
[topoh.zip](https://github.com/user-attachments/files/19086428/topoh.zip)
[topoh.zip](https://github.com/user-attachments/files/19086431/topoh.zip)
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Troubleshooting
#### Reproduction
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
(paste your debugging data here)
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4164
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4164(a)github.com>
Module: kamailio
Branch: master
Commit: 08916aa91fae8f09c97f3e99585bd914673537cd
URL: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2025-05-02T04:16:10+02:00
modules: readme files regenerated - outbound ... [skip ci]
---
Modified: src/modules/outbound/README
---
Diff: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91…
Patch: https://github.com/kamailio/kamailio/commit/08916aa91fae8f09c97f3e99585bd91…
---
diff --git a/src/modules/outbound/README b/src/modules/outbound/README
index af2f86cb3c2..899cf9008a2 100644
--- a/src/modules/outbound/README
+++ b/src/modules/outbound/README
@@ -71,17 +71,19 @@ Chapter 1. Admin Guide
1.1. Conditions
- The module analyzes SIP requests so that users (e.g. path, rr) can
- determine whether to apply RFC5626 processing. This section applies if
- outbound processing is not forced by the force_outbound_flag flag.
+ The module analyses SIP requests so that other module (e.g. path, rr)
+ can determine whether to apply RFC5626 processing. This section applies
+ if outbound processing is not forced by the force_outbound_flag flag,
+ or disabled with force_no_outbound_flag.
REGISTER request:
* single Via: header (first hop) and Contact: header has ;reg-id
parameter
- Non-REGISTER requests:
+ Non-REGISTER requests if either of the following conditions is true:
* top Route header URI is myself and has ;ob parameter
- * single Via: header and Contact: header has ;ob parameter
+ * Supported: outbound... header, single Via: header, and Contact:
+ header has ;ob parameter
1.2. Edge Proxy Keep-Alives (STUN)
Module: kamailio
Branch: master
Commit: 1a48c1d18e3c6fa21394eb2075a1b348757c47a0
URL: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34…
Author: S-P Chan <shihping.chan(a)gmail.com>
Committer: S-P Chan <shihping.chan(a)gmail.com>
Date: 2025-05-02T10:12:42+08:00
outbound: docs - more tweaks
---
Modified: src/modules/outbound/doc/outbound_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34…
Patch: https://github.com/kamailio/kamailio/commit/1a48c1d18e3c6fa21394eb2075a1b34…
---
diff --git a/src/modules/outbound/doc/outbound_admin.xml b/src/modules/outbound/doc/outbound_admin.xml
index e2f3e3f468f..55a54ed434f 100644
--- a/src/modules/outbound/doc/outbound_admin.xml
+++ b/src/modules/outbound/doc/outbound_admin.xml
@@ -22,10 +22,11 @@
<section>
<title>Conditions</title>
- <para>The module analyzes SIP requests so that users (e.g. path, rr)
+ <para>The module analyses SIP requests so that other module (e.g. path, rr)
can determine whether to apply RFC5626 processing.
This section applies if outbound processing
- is not forced by the <code>force_outbound_flag</code> flag.</para>
+ is not forced by the <code>force_outbound_flag</code> flag, or disabled with
+ <code>force_no_outbound_flag</code>.</para>
<para><code>REGISTER</code> request:
<itemizedlist>
<listitem>
@@ -33,13 +34,14 @@
</listitem>
</itemizedlist>
</para>
- <para>Non-<code>REGISTER</code> requests:
+ <para>Non-<code>REGISTER</code> requests if either of the following conditions is true:
<itemizedlist>
<listitem>
<para>top Route header URI is myself and has <code>;ob</code> parameter</para>
</listitem>
<listitem>
- <para>single <code>Via:</code> header and <code>Contact:</code> header has <code>;ob</code> parameter</para>
+ <para><code>Supported: outbound...</code> header, single <code>Via:</code> header,
+ and <code>Contact:</code> header has <code>;ob</code> parameter</para>
</listitem>
</itemizedlist>
</para>
I'm sorry @miconda
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd15ba3e32d/156150906(a)github.com>
For the records and future consideration: the README file for a module must not be changed manually, it is generated from the xml files located in the `doc/` subfolder of the module directory. If you want to change something in the README file, change inside the xml files and a job on kamailio.org server will generate and push to git the updated README content.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/c92795b672ce8cfc7ff0ff361e5fdbd15ba3e32d/156146968(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
##### **Summary**
This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists.
##### **Details**
* Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value.
* Supports removal of single or multiple matching entries in one operation.
##### **Benefits**
- Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management.
- Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries.
- Enhances performance by reducing unnecessary duplication in the lists.
##### Testing
This feature was tested using `kmcmd` commands in various scenarios:
- Removing the **first element** in the list.
- Removing an element from the **middle** of the list.
- Removing the **last element** in the list.
- Removing **all matching elements** in the list.
In all cases, the commands worked correctly, and the lists were updated and cleaned as expected.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4089
-- Commit Summary --
* secfilter‌: support remove rule in Whitelist and Blacklist
-- File Changes --
M src/modules/secfilter/secfilter.c (8)
M src/modules/secfilter/secfilter.h (3)
M src/modules/secfilter/secfilter_db.c (106)
M src/modules/secfilter/secfilter_rpc.c (95)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4089.patchhttps://github.com/kamailio/kamailio/pull/4089.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4089
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4089(a)github.com>
Module: kamailio
Branch: master
Commit: f68cd7a4b1d035d48c28b774dcf9b9bde557f38f
URL: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2025-04-30T03:46:09+02:00
modules: readme files regenerated - outbound ... [skip ci]
---
Modified: src/modules/outbound/README
---
Diff: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b…
Patch: https://github.com/kamailio/kamailio/commit/f68cd7a4b1d035d48c28b774dcf9b9b…
---
diff --git a/src/modules/outbound/README b/src/modules/outbound/README
index aa712cd73fc..af2f86cb3c2 100644
--- a/src/modules/outbound/README
+++ b/src/modules/outbound/README
@@ -75,12 +75,13 @@ Chapter 1. Admin Guide
determine whether to apply RFC5626 processing. This section applies if
outbound processing is not forced by the force_outbound_flag flag.
- REGISTER request —
- * single Via: (first hop) and Contact: has ;ob parameter
+ REGISTER request:
+ * single Via: header (first hop) and Contact: header has ;reg-id
+ parameter
- Non-REGISTER requests —
- * top Route header is me and has ;ob parameter
- * single Via: and Contact: URI has ;ob parameter
+ Non-REGISTER requests:
+ * top Route header URI is myself and has ;ob parameter
+ * single Via: header and Contact: header has ;ob parameter
1.2. Edge Proxy Keep-Alives (STUN)
xadhoom created an issue (kamailio/kamailio#4203)
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-users.lists.kamailio…
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* https://lists.kamailio.org/mailman3/postorius/lists/sr-dev.lists.kamailio.o…
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
Note that an issue report may be closed automatically after about 2 months
if there is no interest from developers or community users on pursuing it, being
considered expired. In such case, it can be reopened by writing a comment that includes
the token `/notexpired`. About two weeks before considered expired, the issue is
marked with the label `stale`, trying to notify the submitter and everyone else
that might be interested in it. To remove the label `stale`, write a comment that
includes the token `/notstale`. Also, any comment postpone the `expire` timeline,
being considered that there is interest in pursuing the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Enabled json logging engine, with the following setup:
- kam cmd line params: `--log-engine=json:Mp`
- prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "`
- another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "`
What I see that certain json lines are truncated, for example
- one line is interrupted by another json entry
- one line starts "truncated"
### Troubleshooting
What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc.
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
The following first 3 lines are ok, then the latest is corrupted:
```
{ "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" }
{ "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" }
{ "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" }
{ "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" }
```
or (notice 2nd line or 5th one)
```
{ "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" }
line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" }
{ "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" }
{ "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" }
, "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" }
{ "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" }
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
6.0.1
```
happens also with 5.8.x
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `lsb_release -a` and `uname -a`)
-->
```
Debian noble, docker container
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4203
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4203(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #4212
#### Description
<!-- Describe your changes in detail -->
Probing a host correctly needs the tm module to be loaded. This PR adds a check for when adding a target in dispatcher with probing enabled to verify whether tm is loaded. If it's not, it emmits a warning and disable the probing to the target.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4223
-- Commit Summary --
* dispatcher: Check if tm is enabled before probing
-- File Changes --
M src/modules/dispatcher/dispatch.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4223.patchhttps://github.com/kamailio/kamailio/pull/4223.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4223
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4223(a)github.com>
intliang created an issue (kamailio/kamailio#4214)
### Description
The **<bymonth>** comparison logic in **tmrec_match()** fails to properly evaluate equivalence conditions, as shown below:
```
int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp)
{
...
if(_trp->bymonth) {
for(i = 0; i < _trp->bymonth->nr; i++) {
if(_atp->t.tm_mon
== (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12)
% 12)
break;
}
...
```
### Troubleshooting
#### Reproduction
Rule string: "20250403T100000|PT14H|weekly|20250425T000000|2|-1WE, -2WE|16|||4"
Date time: 20250416T190000
Expected output: MATCH
Actual output: NOT MATCH
<!--
If the issue can be reproduced, describe how it can be done.
-->
#### Debugging Data
<!--
If you got a core dump, use gdb to extract troubleshooting data - full backtrace,
local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile
bt full
info locals
list
If you are familiar with gdb, feel free to attach more of what you consider to
be relevant.
-->
```
((lldb) p _trp->bymonth->xxx[0]
(int) 4
(lldb) p _trp->bymonth->req[0]
(int) 1
(lldb) p _atp->t.tm_mon
(int) 3
(lldb) p _trp->bymonth->nr
(int) 1
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your log messages here)
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
(paste your sip traffic here)
```
### Possible Solutions
The **tm_mon** field in the tm struct uses a 0-11 range (January=0), while the **<bymonth>** parameter follows a 1-12 convention (January=1) as documented in the tmrec module's README. Therefore, we should first decrement the value of **_trp->bymonth->xxx[i]** by 1 for proper conversion.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 6.1.0-dev0 (x86_64/Darwin) 9f24f1-dirty
flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, select, kqueue.
id: 9f24f1 dirty
compiled on 11:59:55 Apr 16 2025 with AppleClang 17.0.0.17000013
```
* **Operating System**:
```
Darwin yintiliangdeMacBook-Pro19.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:41:43 PST 2024; root:xnu-11215.61.5~2/RELEASE_X86_64 x86_64
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4214
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4214(a)github.com>
### Description
`secf_check_sqli_all();` block requests when a single quote is present in From name :
```
From: "O'Reilly" <sip:100@example.net>;tag=abcd
```
Since single quotes are frequent in names.
It makes it difficult to use this function.
### Possible Solutions
A solution would be to skip single quote check in From name.
I'll write the PR if you are OK with this solution
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3984
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3984(a)github.com>
secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3984 (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4225
-- Commit Summary --
* secfilter: Allow single quotes in From name and To name in function secf_check_sqli_all();
-- File Changes --
M src/modules/secfilter/secfilter.c (56)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4225.patchhttps://github.com/kamailio/kamailio/pull/4225.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4225
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4225(a)github.com>
Hi Kamailio Team,
We have started inhouse implementation of ED-137B for VVCS project.
I need your guidance in identifying credible source for deployment of this protocol.
Regards,
Sandeep Nayak (VP - Engineering)
+91 80952 41019
[https://ci3.googleusercontent.com/mail-sig/AIorK4woqONsX5aNx6yhTdY0_mcz3Zal…]
Applied Electro Magnetics Pvt Ltd.
B-106, Block B, Sector 67, Noida, Uttar Pradesh-201301
Website: https://www.aemindia.com/
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3984 (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4224
-- Commit Summary --
* secfilter: fix secf_check_dst bug
* secfilter: Allow single quotes in From name and To name
-- File Changes --
M src/modules/secfilter/secfilter.c (57)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4224.patchhttps://github.com/kamailio/kamailio/pull/4224.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4224
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4224(a)github.com>