Hello,
likely everyone on sr-dev likely noticed the rather large amount of
github-actions notifications related to opened issues and pull requests,
they happened because of trying to automatise/optimize tasks related to
them and somehow keep both reporters and interested developers aware of
items ageing. Enabling that action to see how it goes with it triggered
rather large amount of notifications, because it worked also on existing
items, not only on the future ones.
Anyhow, if there is notification that an item is getting too old and
nobody has interest on it, then it may be closed after a while, right
now is 6 weeks notice of inactivity, plus 2 weeks to react on it --
these values can adjusted of course base on feedback. If there is
interest in the item, simply the label stale can be removed.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy and Development Services
### Description
I recently downloaded kamailio 5.2.3 and tried to install it for investigation purposes. I was trying to include app_java module in order to execute some brief java apps in kamailio. But then I get the same issue wen I compile and when I run kamailio
Thank you for all the help you can give me
### Troubleshooting
I get the same bunch of warnings everytime I try to make all
java_msgobj.c: In function ‘fill_sipmsg_object’:
java_msgobj.c:83:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->id);
^~~~~~~~~~~~~~
java_msgobj.c:83:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:96:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->pid);
^~~~~~~~~~~~~~
java_msgobj.c:96:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:110:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:110:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:127:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:127:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:142:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:142:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:156:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->len);
^~~~~~~~~~~~~~
java_msgobj.c:156:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:172:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:172:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:189:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:189:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:205:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->parsed_orig_ruri_ok);
^~~~~~~~~~~~~~
java_msgobj.c:205:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:222:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:222:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:237:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->add_to_branch_len);
^~~~~~~~~~~~~~
java_msgobj.c:237:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:251:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->hash_index);
^~~~~~~~~~~~~~
java_msgobj.c:251:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:265:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetIntField(env, SipMsgInstance, fid, msg->msg_flags);
^~~~~~~~~~~~~~
java_msgobj.c:265:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:286:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:286:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
java_msgobj.c:306:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types]
(*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam);
^~~~~~~~~~~~~~
java_msgobj.c:306:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’
CC (gcc) [M app_java.so] java_support.o
CC (gcc) [M app_java.so] java_iface.o
java_iface.c: In function ‘java_exec’:
java_iface.c:205:53: warning: passing argument 2 of ‘(*_aj_env)->NewLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method);
^~~~~~~~~~~
java_iface.c:205:53: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:205:18: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method);
^
java_iface.c:208:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref);
^~~~~~~~~~~~~~~
java_iface.c:208:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:216:40: warning: passing argument 2 of ‘(*_aj_env)->MonitorEnter’ from incompatible pointer type [-Wincompatible-pointer-types]
if((*_aj_env)->MonitorEnter(_aj_env, invk_method_ref) != JNI_OK) {
^~~~~~~~~~~~~~~
java_iface.c:216:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:234:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref);
^~~~~~~~~~~~~~~
java_iface.c:234:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:235:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method);
^~~~~~~~~~~
java_iface.c:235:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:258:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref);
^~~~~~~~~~~~~~~
java_iface.c:258:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:259:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method);
^~~~~~~~~~~
java_iface.c:259:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:266:39: warning: passing argument 2 of ‘(*_aj_env)->MonitorExit’ from incompatible pointer type [-Wincompatible-pointer-types]
if((*_aj_env)->MonitorExit(_aj_env, invk_method_ref) != JNI_OK) {
^~~~~~~~~~~~~~~
java_iface.c:266:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:272:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref);
^~~~~~~~~~~~~~~
java_iface.c:272:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
java_iface.c:273:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, invk_method);
^~~~~~~~~~~
java_iface.c:273:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
CC (gcc) [M app_java.so] java_native_methods.o
java_native_methods.c: In function ‘Java_org_siprouter_SipMsg_ParseSipMsg’:
java_native_methods.c:484:9: warning: return from incompatible pointer type [-Wincompatible-pointer-types]
return fill_sipmsg_object(jenv, _aj_msg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CC (gcc) [M app_java.so] app_java_mod.o
app_java_mod.c: In function ‘child_init’:
app_java_mod.c:236:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types]
(*_aj_env)->DeleteLocalRef(_aj_env, child_init_id);
^~~~~~~~~~~~~
app_java_mod.c:236:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’
#### Reproduction
1. Download 5.2.3
2. in /usr/local/src/kamailio-5.2.3/
2.1 make include_modules="app_java" cfg
2.2 make all
2.3 make install
3 kamailo -e -E -ddd
#### Debugging Data
0(18169) ERROR: <core> [core/sr_module.c:498]: load_module(): could not open module </usr/local/lib64/kamailio/modules/app_java.so>: libjvm.so: cannot open shared object file: No such file or directory
0(18169) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 300, column 12-24: failed to load module
0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found
0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 306, column 46: Can't set module parameter
0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found
0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 307, column 55: Can't set module parameter
0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found
0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 308, column 60: Can't set module parameter
0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found
0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 309, column 41: Can't set module parameter
0(18169) ERROR: <core> [core/cfg.y:3370]: yyparse(): cfg. parser: failed to find command java_method_exec (params 2)
0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 483, column 37: unknown command, missing loadmodule?
### Possible Solutions
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
version: kamailio 5.2.3 (x86_64/linux) c36229
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: c36229
* **Operating System**:
Ubuntu 18.04
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1984
Running `5.7.1:441300`, trying to loop through the results of an `HGETALL` operation in Redis:
```
127.0.0.1:6379[1]> keys *
1) "customer_params:14045551212:1.1.1.1"
127.0.0.1:6379[1]> hgetall customer_params:14045551212:1.1.1.1
1) "auth_ha1"
2) "9febe8cf72c6bd063b8978cded892e4bb"
```
This means that the returned type will be `$redisd(rpl_arr)` and a loop is required. For any given key value `$redis(r=>value[x])`, the value is in the next array slot, at `$redis(r=>value[x + 1])`.
With that in mind, I tried this loop:
```
$var(i) = 0;
while($var(i) < $redis(r=>size)) {
$var(key) = $redis(r=>value[$var(i)]);
switch($var(key)) {
case "auth_ha1":
$var(auth_ha1) = $redis(r=>value[$var(i)+1]);
break;
}
$var(i) = $var(i) + 1;
}
```
However, this ends up storing the key value ("auth_ha1") in `$var(auth_ha1)`. I also tried `$(var(i){s.int}) + 1` for the subscript value.
To get the actual next-slot value, the expression evaluation has to be externalised into an intermediate variable:
```
while($var(i) < $redis(r=>size)) {
$var(key) = $redis(r=>value[$var(i)]);
# For some reason, Kamailio cannot evaluate an addition expression inside this subscript: $redis(r=>value[EXPR])
$var(idx) = $var(i) + 1;
switch($var(key)) {
case "auth_ha1":
$var(auth_ha1) = $redis(r=>value[$var(idx)]);
break;
}
$var(i) = $var(i) + 1;
}
```
This works, and yields `9febe8cf72c6bd063b8978cded892e4bb`.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3526
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3526(a)github.com>
Module: kamailio
Branch: master
Commit: ca613b491412a7ebb6f3d59956a8cbbde1cb725a
URL: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2023-11-07T23:24:45+01:00
github: close-stale-issues
As discussed at Kamailio developers meeting 2023
---
Added: .github/workflows/issue_management.yml
---
Diff: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb…
Patch: https://github.com/kamailio/kamailio/commit/ca613b491412a7ebb6f3d59956a8cbb…
---
diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml
new file mode 100644
index 00000000000..d99a934cdfd
--- /dev/null
+++ b/.github/workflows/issue_management.yml
@@ -0,0 +1,19 @@
+name: 'Close stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 2 * * *'
+permissions:
+ issues: write
+ pull-requests: write
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v8
+ with:
+ stale-issue-message: 'This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.'
+ stale-pr-message: 'This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.'
+ days-before-stale: 42
+ days-before-close: 14
+ exempt-issue-labels: bug
+ remove-stale-when-updated: true
Module: kamailio
Branch: master
Commit: 4587d46d06fe4fe1d7c754b46b0f68910cbca633
URL: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-11-07T17:19:44+01:00
core: set atexit to default to no
---
Modified: src/main.c
---
Diff: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689…
Patch: https://github.com/kamailio/kamailio/commit/4587d46d06fe4fe1d7c754b46b0f689…
---
diff --git a/src/main.c b/src/main.c
index e299db3b319..8c3e34e5bc7 100644
--- a/src/main.c
+++ b/src/main.c
@@ -167,7 +167,7 @@ Options:\n\
--atexit=val Control atexit callbacks execution from external libraries\n\
which may access destroyed shm memory causing crash on shutdown.\n\
Can be y[es] or 1 to enable atexit callbacks, n[o] or 0 to disable,\n\
- default is yes.\n\
+ default is no.\n\
-A define Add config pre-processor define (e.g., -A WITH_AUTH,\n\
-A 'FLT_ACC=1', -A 'DEFVAL=\"str-val\"')\n\
-b nr Maximum OS UDP receive buffer size which will not be exceeded by\n\
@@ -546,7 +546,7 @@ char *sr_memmng_shm = NULL;
static int *_sr_instance_started = NULL;
int ksr_cfg_print_mode = 0;
-int ksr_atexit_mode = 1;
+int ksr_atexit_mode = 0;
int ksr_wait_worker1_mode = 0;
int ksr_wait_worker1_time = 4000000;
**crypto_uuid.c**
```
CC (gcc) [M crypto.so] api.o
CC (gcc) [M crypto.so] crypto_aes.o
CC (gcc) [M crypto.so] crypto_evcb.o
CC (gcc) [M crypto.so] crypto_mod.o
CC (gcc) [M crypto.so] crypto_uuid.o
crypto_uuid.c: In function 'crypto_generate_callid':
crypto_uuid.c:184:9: warning: 'SHA1_Init' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
184 | SHA1_Init(&crypto_ctx);
| ^~~~~~~~~
In file included from crypto_uuid.c:37:
/usr/include/openssl/sha.h:49:27: note: declared here
49 | OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c);
| ^~~~~~~~~
crypto_uuid.c:185:9: warning: 'SHA1_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
185 | SHA1_Update(&crypto_ctx, crypto_callid_seed, SEED_LEN);
| ^~~~~~~~~~~
In file included from crypto_uuid.c:37:
/usr/include/openssl/sha.h:50:27: note: declared here
50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
| ^~~~~~~~~~~
crypto_uuid.c:186:9: warning: 'SHA1_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
186 | SHA1_Update(&crypto_ctx, crypto_callid_counter, CTR_LEN);
| ^~~~~~~~~~~
In file included from crypto_uuid.c:37:
/usr/include/openssl/sha.h:50:27: note: declared here
50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
| ^~~~~~~~~~~
crypto_uuid.c:187:9: warning: 'SHA1_Final' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
187 | SHA1_Final(crypto_buf, &crypto_ctx);
| ^~~~~~~~~~
In file included from crypto_uuid.c:37:
/usr/include/openssl/sha.h:51:27: note: declared here
51 | OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
| ^~~~~~~~~~
LD (gcc) [M crypto.so] crypto.so
CC (gcc) [M tls.so] tls_bio.o
```
**auth_crypt.c**
```
CC (gcc) [M tls.so] tls_verify.o
LD (gcc) [M tls.so] tls.so
CC (gcc) [M auth_identity.so] auth_crypt.o
auth_crypt.c: In function 'rsa_sha1_enc':
auth_crypt.c:214:9: warning: 'RSA_sign' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
214 | if(RSA_sign(NID_sha1, sstrcrypted, sizeof sstrcrypted,
| ^~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_crypt.c:33:
/usr/include/openssl/rsa.h:356:27: note: declared here
356 | OSSL_DEPRECATEDIN_3_0 int RSA_sign(int type, const unsigned char *m,
| ^~~~~~~~
auth_crypt.c: In function 'rsa_sha1_dec':
auth_crypt.c:258:9: warning: 'EVP_PKEY_get1_RSA' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
258 | hpubkey = EVP_PKEY_get1_RSA(pkey);
| ^~~~~~~
In file included from /usr/include/openssl/pem.h:22,
from auth_crypt.c:33:
/usr/include/openssl/evp.h:1359:16: note: declared here
1359 | struct rsa_st *EVP_PKEY_get1_RSA(EVP_PKEY *pkey);
| ^~~~~~~~~~~~~~~~~
auth_crypt.c:266:9: warning: 'RSA_verify' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
266 | if(RSA_verify(NID_sha1, (unsigned char *)ssha, sshasize,
| ^~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_crypt.c:33:
/usr/include/openssl/rsa.h:359:27: note: declared here
359 | OSSL_DEPRECATEDIN_3_0 int RSA_verify(int type, const unsigned char *m,
| ^~~~~~~~~~
auth_crypt.c:273:17: warning: 'RSA_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
273 | RSA_free(hpubkey);
| ^~~~~~~~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_crypt.c:33:
/usr/include/openssl/rsa.h:301:28: note: declared here
301 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r);
| ^~~~~~~~
auth_crypt.c:298:9: warning: 'RSA_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
298 | RSA_free(hpubkey);
| ^~~~~~~~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_crypt.c:33:
/usr/include/openssl/rsa.h:301:28: note: declared here
301 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r);
| ^~~~~~~~
CC (gcc) [M auth_identity.so] auth_dynstr.o
CC (gcc) [M auth_identity.so] auth_hdrs.o
```
**auth_identity.c**
```
CC (gcc) [M auth_identity.so] auth_http.o
CC (gcc) [M auth_identity.so] auth_identity.o
auth_identity.c: In function 'mod_init':
auth_identity.c:414:9: warning: 'PEM_read_RSAPrivateKey' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
414 | glb_hmyprivkey = PEM_read_RSAPrivateKey(hpemfile, NULL, NULL, NULL);
| ^~~~~~~~~~~~~~
In file included from auth_identity.c:43:
/usr/include/openssl/pem.h:447:1: note: declared here
447 | DECLARE_PEM_rw_cb_attr(OSSL_DEPRECATEDIN_3_0, RSAPrivateKey, RSA)
| ^~~~~~~~~~~~~~~~~~~~~~
auth_identity.c:425:9: warning: 'RSA_size' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
425 | if(initdynstr(&glb_encedmsg, RSA_size(glb_hmyprivkey)))
| ^~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_identity.c:43:
/usr/include/openssl/rsa.h:212:27: note: declared here
212 | OSSL_DEPRECATEDIN_3_0 int RSA_size(const RSA *rsa);
| ^~~~~~~~
auth_identity.c:429:9: warning: 'RSA_size' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
429 | if(initdynstr(&glb_b64encedmsg, (RSA_size(glb_hmyprivkey) / 3 + 1) * 4))
| ^~
In file included from /usr/include/openssl/x509.h:36,
from /usr/include/openssl/pem.h:23,
from auth_identity.c:43:
/usr/include/openssl/rsa.h:212:27: note: declared here
212 | OSSL_DEPRECATEDIN_3_0 int RSA_size(const RSA *rsa);
| ^~~~~~~~
CC (gcc) [M auth_identity.so] auth_tables.o
LD (gcc) [M auth_identity.so] auth_identity.so
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3502
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3502(a)github.com>
I have a scenario on wich requires sequential fork (up to 30 possible destinations) with different
Call-ID for each leg. I am using topoh module enabled, but it always puts the same Call-ID.
I think a possible solution would be to modify the callid prefix parameter of
topoh module.
Instead of storing a string, it could store the name of a variable that could then have
its content changed within the script. So within the "branch_route" I could modify
this variable by putting $tU ( To URI Username of the outgoing Invite).
In this case the new Call-ID generated by topoh module would be a function of the
"To URI Username" that is different for each leg.
Is this proposal technically feasible or is there a different solution for this scenario?
Additional information:
kamailio Version - output of kamailio -v
version: kamailio 5.7.1 (x86_64/linux) 4238e4
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 4238e4
compiled on 13:26:58 Jun 28 2023 with gcc 8.5.0
Operating System: CentOS Linux 8
CPE OS Name: cpe:/o:centos:centos:8
Kernel: Linux 4.18.0-348.7.1.el8_5.x86_64
Architecture: x86-64
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3630
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3630(a)github.com>
NAME variable might be set to the current HOSTNAME in some shell and also clash with the value set by the module calling MOD_INSTALL_UTILS by passing a NAME variable.
With commit 1774cee62098 ("kamcmd: allow defining the name of the application from command line") this resulted in the kamcmd bin being renamed to all kind of name from hostname to ctl.so.
Fix this by checking the variable to a more safe name that is not already defined in shell by default and also that doesn't clash with module variables, use UTIL_NAME as an alternative to NAME.
UTIL_NAME now needs to be used to create kamcmd with custom name.
Fixes: 1774cee62098 ("kamcmd: allow defining the name of the application from command line")
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3628
-- Commit Summary --
* kamcmd: don't clash with ENV NAME or ctl.so module
-- File Changes --
M utils/kamcmd/Makefile (9)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3628.patchhttps://github.com/kamailio/kamailio/pull/3628.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3628
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3628(a)github.com>
Module: kamailio
Branch: master
Commit: b141f267ce1fe1068de1541d8bd5b5dc53c1d6d9
URL: https://github.com/kamailio/kamailio/commit/b141f267ce1fe1068de1541d8bd5b5d…
Author: Christian Marangi <ansuelsmth(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-11-06T16:13:55+01:00
kamcmd: Makefile - use CUSTOM_NAME for specifying custom binary name
- previous use of NAME can clash with environment variable NAME that
could be set by OS or by Kamailio modules installation
- GH #3628
---
Modified: utils/kamcmd/Makefile
---
Diff: https://github.com/kamailio/kamailio/commit/b141f267ce1fe1068de1541d8bd5b5d…
Patch: https://github.com/kamailio/kamailio/commit/b141f267ce1fe1068de1541d8bd5b5d…
---
diff --git a/utils/kamcmd/Makefile b/utils/kamcmd/Makefile
index 1fd923d8554..c8298a8662c 100644
--- a/utils/kamcmd/Makefile
+++ b/utils/kamcmd/Makefile
@@ -8,10 +8,15 @@ include $(COREPATH)/Makefile.targets
auto_gen=
RELEASE=1.5
UTIL_SRC_NAME=kamcmd
+# Pass CUSTOM_NAME to overwrite the kamcmd/sercmd bin name
+ifeq ($(CUSTOM_NAME),)
ifeq ($(FLAVOUR),ser)
- NAME?=sercmd
+ NAME=sercmd
else
- NAME?=kamcmd
+ NAME=kamcmd
+endif
+else
+ NAME=$(CUSTOM_NAME)
endif
readline_localpath=$(LOCALBASE)/include/readline/readline.h
- realtime and shutdown mode support
- removed duplicate entry in doc about "ro_auth_expiry"
- RO_TABLE_VERSION constant did not match inserted value in db schema
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Fixed the module so it also use information written to database to restore Ro sessions on startup/restart.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3622
-- Commit Summary --
* ims_charging: Implemented restore of Ro sessions from database
-- File Changes --
M src/modules/ims_charging/dialog.c (6)
M src/modules/ims_charging/doc/ims_charging_admin.xml (21)
M src/modules/ims_charging/ims_charging_mod.c (15)
M src/modules/ims_charging/ims_ro.c (2)
M src/modules/ims_charging/ro_db_handler.c (444)
M src/modules/ims_charging/ro_db_handler.h (11)
M src/modules/ims_charging/ro_timer.c (2)
M utils/kamctl/mysql/ims_charging-create.sql (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3622.patchhttps://github.com/kamailio/kamailio/pull/3622.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3622
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3622(a)github.com>
Module: kamailio
Branch: master
Commit: 70ecd99e3d8069d0f89444a5b893f61dd1edd1b3
URL: https://github.com/kamailio/kamailio/commit/70ecd99e3d8069d0f89444a5b893f61…
Author: Morten Tryfoss <morten(a)tryfoss.no>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-11-06T13:29:09+01:00
tm: T_ASYNC_SUSPENDED flag not removed when cancelling a suspension
---
Modified: src/modules/tm/t_suspend.c
---
Diff: https://github.com/kamailio/kamailio/commit/70ecd99e3d8069d0f89444a5b893f61…
Patch: https://github.com/kamailio/kamailio/commit/70ecd99e3d8069d0f89444a5b893f61…
---
diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c
index 997d1a5bb78..e0048f0604c 100644
--- a/src/modules/tm/t_suspend.c
+++ b/src/modules/tm/t_suspend.c
@@ -645,6 +645,7 @@ int t_cancel_suspend(unsigned int hash_index, unsigned int label)
/* The transaction does not need to be locked because this
* function is either executed from the original route block
* or from failure route which already locks */
+ t->flags &= ~T_ASYNC_SUSPENDED;
reset_kr(); /* the blind UAC of t_suspend has set kr */
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
I've been testing the ims_charging module which relies on a diameter request and async reply. If there's no available diameter server, Ro_CCR() calls t_cancel_suspend() to cancel suspension of the transaction and return an error.
Based on my understanding, it should now be possible to continue script logic as if the transaction was not suspended at all.
In our case we want the call to go through anyway, as a fallback.
The INVITE is being sent to the destination, but all replies are filtered since the suspended flag is still set.
Tested this change locally, and it's now working according to our needs.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3629
-- Commit Summary --
* tm: T_ASYNC_SUSPENDED flag not removed when cancelling a suspension
-- File Changes --
M src/modules/tm/t_suspend.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3629.patchhttps://github.com/kamailio/kamailio/pull/3629.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3629
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3629(a)github.com>
Module: kamailio
Branch: master
Commit: 4cec039ce1b7fa2d1980f8f30dd7bb1012e3c9cb
URL: https://github.com/kamailio/kamailio/commit/4cec039ce1b7fa2d1980f8f30dd7bb1…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-11-05T22:02:26+01:00
modules: readme files regenerated - tm ... [skip ci]
---
Modified: src/modules/tm/README
---
Diff: https://github.com/kamailio/kamailio/commit/4cec039ce1b7fa2d1980f8f30dd7bb1…
Patch: https://github.com/kamailio/kamailio/commit/4cec039ce1b7fa2d1980f8f30dd7bb1…
---
diff --git a/src/modules/tm/README b/src/modules/tm/README
index 216533fbfb6..41dced573d2 100644
--- a/src/modules/tm/README
+++ b/src/modules/tm/README
@@ -2101,6 +2101,9 @@ if (t_newtran()) {
* code - Reply code number.
* reason_phrase - Reason string.
+ This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
+ ONREPLY_ROUTE.
+
Example 1.63. t_reply usage
...
t_reply("404", "Not found");
@@ -2111,7 +2114,8 @@ t_reply("404", "Not found");
Sends a stateful reply based in internal error code, similar to
sl_send_error() from sl module.
- This function can be used from REQUEST_ROUTE.
+ This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
+ ONREPLY_ROUTE.
Example 1.64. t_reply_error usage
...
Module: kamailio
Branch: master
Commit: 9bbf86a8a7e598a67254e2907dcc430af98f5689
URL: https://github.com/kamailio/kamailio/commit/9bbf86a8a7e598a67254e2907dcc430…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-11-05T21:48:43+01:00
tm: docs updated for t_reply_error()
---
Modified: src/modules/tm/doc/functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/9bbf86a8a7e598a67254e2907dcc430…
Patch: https://github.com/kamailio/kamailio/commit/9bbf86a8a7e598a67254e2907dcc430…
---
diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml
index 7bcc3a43ccf..539e4f0dafb 100644
--- a/src/modules/tm/doc/functions.xml
+++ b/src/modules/tm/doc/functions.xml
@@ -359,6 +359,9 @@ if (t_newtran()) {
</para>
</listitem>
</itemizedlist>
+ <para>
+ This function can be used from REQUEST_ROUTE, FAILURE_ROUTE, ONREPLY_ROUTE.
+ </para>
<example>
<title><function>t_reply</function> usage</title>
<programlisting>
@@ -378,7 +381,7 @@ t_reply("404", "Not found");
sl_send_error() from sl module.
</para>
<para>
- This function can be used from REQUEST_ROUTE.
+ This function can be used from REQUEST_ROUTE, FAILURE_ROUTE, ONREPLY_ROUTE.
</para>
<example>
<title><function>t_reply_error</function> usage</title>
Module: kamailio
Branch: master
Commit: cb5295234a1b106473c3fdb9ff25c23bfc9fbcd1
URL: https://github.com/kamailio/kamailio/commit/cb5295234a1b106473c3fdb9ff25c23…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-11-03T09:06:38+01:00
sl: docs for send_reply_error()
---
Modified: src/modules/sl/doc/sl_functions.xml
---
Diff: https://github.com/kamailio/kamailio/commit/cb5295234a1b106473c3fdb9ff25c23…
Patch: https://github.com/kamailio/kamailio/commit/cb5295234a1b106473c3fdb9ff25c23…
---
diff --git a/src/modules/sl/doc/sl_functions.xml b/src/modules/sl/doc/sl_functions.xml
index 11ef4706755..8f2715b7a00 100644
--- a/src/modules/sl/doc/sl_functions.xml
+++ b/src/modules/sl/doc/sl_functions.xml
@@ -130,7 +130,7 @@ send_reply_mode("403", "Invalid user - $fU", "3");
</title>
<para>
Sends back an error reply describing the nature of the last
- internal error. Usually this function should be used after a
+ internal error. Usually this function should be used after a
script function that returned an error code.
</para>
<example>
@@ -174,6 +174,29 @@ sl_reply_error();
if(status=="408")
sl_forward_reply("404", "Not found");
...
+</programlisting>
+ </example>
+ </section>
+
+ <section id="sl.f.send_reply_error">
+ <title>
+ <function moreinfo="none">send_reply_error()</function>
+ </title>
+ <para>
+ For the current request, the internal error code reply is sent back
+ stateful or stateless, depending of the <acronym>TM</acronym> module:
+ if a transaction exists for the current request, then the reply is sent
+ statefully, otherwise stateless.
+ </para>
+ <para>
+ It can be used from REQUEST_ROUTE, ONREPLY_ROUTE and FAILURE_ROUTE.
+ </para>
+ <example>
+ <title><function>send_reply_error</function> usage</title>
+ <programlisting format="linespecific">
+...
+send_reply_error();
+...
</programlisting>
</example>
</section>
### Description
This new code in pdttree.c is not correct for this new pdt mode, it just print's a debug log instead of error. The return value should be 0 instead of 1 in case _pdt_mode is 1 otherwise it will still not start.
<code>
if(_pdt_mode & 1) {
LM_DBG("prefix already allocated [%.*s/[%.*s] - ignoring\n",
sp->len, sp->s, sd->len, sd->s);
return -1;
} else {
LM_ERR("prefix already allocated [%.*s/[%.*s]\n", sp->len, sp->s,
sd->len, sd->s);
return -1;
}
</code>
### Troubleshooting
#### Reproduction
#### Debugging Data
#### Log Messages
#### SIP Traffic
### Possible Solutions
### Additional Information
* **Operating System**:
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3626
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3626(a)github.com>
Module: kamailio
Branch: master
Commit: d9189306f38e8f79c16e3a9ea38a2fe90fc82fb7
URL: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2023-11-02T13:16:27+01:00
modules: readme files regenerated - http_client ... [skip ci]
---
Modified: src/modules/http_client/README
---
Diff: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe…
Patch: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe…
---
diff --git a/src/modules/http_client/README b/src/modules/http_client/README
index e10556dad09..6ffe4cab0cd 100644
--- a/src/modules/http_client/README
+++ b/src/modules/http_client/README
@@ -266,6 +266,13 @@ Chapter 1. Admin Guide
3.20. config_file (string)
3.21. netinterface (string)
+ The parameters are loaded in order. That can lead to unexpected
+ behavior: If httpcon is set at first, the default values for all other
+ parameters are used, and not the values that might be set after
+ httpcon. For example, if setting verify_peer=0 or verify_host=0 after
+ httpcon, the certificates are checked and self-signed certificates are
+ rejected nevertheless.
+
3.1. httpredirect (int)
If set to 1, enabled, http_client will follow HTTP 302 Redirects. If
This was originaly fixed in #3601, but that did not handle the change in #3612 very well.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Fix for undefined symbols when using older/unsupported OpenSSL.
This was originaly fixed in #3601, but that did not handle the change in #3612 very well.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3616
-- Commit Summary --
* cdp: Fix for undefined symbols when using older/unsupported OpenSSL
-- File Changes --
M src/modules/cdp/receiver.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3616.patchhttps://github.com/kamailio/kamailio/pull/3616.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3616
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3616(a)github.com>
Module: kamailio
Branch: master
Commit: 02dd4e2c883585601f4dbcea0b63b858b4dd24d6
URL: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85…
Author: Benjamin <92934023+tietzsg(a)users.noreply.github.com>
Committer: GitHub <noreply(a)github.com>
Date: 2023-11-02T13:09:57+01:00
http_client: add information about parameter loading (#3619)
* http_client: add information about parameter loading
- Inform that the order of the parameters is important when httpcon is loaded first
* http_client: docs - typos from previous commit
---------
Co-authored-by: Daniel-Constantin Mierla <miconda(a)gmail.com>
---
Modified: src/modules/http_client/doc/http_client_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85…
Patch: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85…
---
diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml
index 1449dc824d8..0e182cc95e3 100644
--- a/src/modules/http_client/doc/http_client_admin.xml
+++ b/src/modules/http_client/doc/http_client_admin.xml
@@ -88,6 +88,13 @@
<section>
<title>Parameters</title>
+ <para>
+ The parameters are loaded in order. That can lead to unexpected behavior:
+ If httpcon is set at first, the default values for all other parameters are used,
+ and not the values that might be set after httpcon.
+ For example, if setting verify_peer=0 or verify_host=0 after httpcon,
+ the certificates are checked and self-signed certificates are rejected nevertheless.
+ </para>
<section id="http_client.p.httpredirect">
<title><varname>httpredirect</varname> (int)</title>
<para>
- Inform that the order of the parameters is important when httpcon is loaded first
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3619
-- Commit Summary --
* http_client: add information about parameter loading
-- File Changes --
M src/modules/http_client/doc/http_client_admin.xml (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3619.patchhttps://github.com/kamailio/kamailio/pull/3619.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3619
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3619(a)github.com>
### Description
kamailio RPM repos include libks (v2)
FreeSWITCH for EL7 distributes libks (v1) libks2 (v2) — the reason is to support their packages
signalwire-client-c(requires libks) and signalwire-client-c2(requires libks2).
RFC: rename the kamailio package libks to libks2 to be consistent
### Expected behavior
Currently rebuilding FreeSWITCH signalwire-client-c and signalwire-client-c2 and installing mixing in the
kamailio RPM can lead to confusion
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3625
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3625(a)github.com>