sr-dev

sr-dev@lists.kamailio.org

13 participants
44935 discussions

[kamailio/kamailio] cmake: do not packaged (Issue #4255)
by sergey-safarov 23 May '25

23 May '25

sergey-safarov created an issue (kamailio/kamailio#4255) ### Description I now make testing `cmake` packaging and see this error ``` RPM build errors: Directory not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres File not found: /root/rpmbuild/BUILDROOT/kamailio-6.1.0-dev1.0.el10.centos.x86_64/usr/share/kamailio/postgres/* ``` ### Troubleshooting #### Reproduction I use this module list for build https://github.com/sergey-safarov/kamailio/blob/master/pkg/kamailio/obs/kam… @xkaraman could you look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4255 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4255(a)github.com>

2 6

[kamailio/kamailio] rtpengine hash table dmq replication (PR #4240)
by vlitvinov 23 May '25

23 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding KDMQ replication for rtpengine hash table (call -> rtpengine instance assignment) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4240 -- Commit Summary -- * rtpegnine hash table dmq replication -- File Changes -- M src/modules/rtpengine/rtpengine.c (49) M src/modules/rtpengine/rtpengine.h (4) M src/modules/rtpengine/rtpengine_db.c (2) A src/modules/rtpengine/rtpengine_dmq.c (310) A src/modules/rtpengine/rtpengine_dmq.h (54) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4240.patch https://github.com/kamailio/kamailio/pull/4240.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4240 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4240(a)github.com>

2 2

git:master:57bd37c5: cmake: dbschema Coorect install folder of pi_framework
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 57bd37c54390fdb70520834b0c2eb29fbb79510e URL: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T13:34:50Z cmake: dbschema Coorect install folder of pi_framework --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… Patch: https://github.com/kamailio/kamailio/commit/57bd37c54390fdb70520834b0c2eb29… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index dcd7bb0645b..a45e7e85470 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -59,6 +59,8 @@ function(add_db_target db_name xsl_file) set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") + elseif(db_name STREQUAL "pi_framework_table" OR db_name STREQUAL "pi_framework_mod") + set(install_folder "xhttp_pi") else() set(install_folder "${db_name}") endif() @@ -101,7 +103,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 1 1 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -110,7 +111,6 @@ function(add_db_target db_name xsl_file) TARGET dbschema_${db_name} POST_BUILD COMMAND ${POSTPROCESS_SCRIPT} 2 10 - # ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} COMMENT "Creating version table for ${db_name}" WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/${folder_suffix} ) @@ -130,7 +130,8 @@ function(add_db_target db_name xsl_file) # message(WARNING "group name is ${group_name}") # Before installing, ensure the target is built `dbschema_${db_name}` # install as previously done in makefile folder. see naming above - # TODO: when tools adopt to new folder structure, remove the install_folder variable + # TODO: when tools adopt to new folder structure, replace the install_folder variable + # with ${db_name_folder} install( DIRECTORY ${CMAKE_BINARY_DIR}/utils/kamctl/${db_name_folder}/

1 0

git:master:c7fcdfdb: cmake: Add some check for finding group name if using non K-variants of group names
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: c7fcdfdb13aeec9aeae726a9cc1ccaeda557e7bb URL: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add some check for finding group name if using non K-variants of group names --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… Patch: https://github.com/kamailio/kamailio/commit/c7fcdfdb13aeec9aeae726a9cc1ccae… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index a41560f17fc..c629ee49f93 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -764,6 +764,20 @@ function(find_group_name module) "" PARENT_SCOPE ) + # This was need due to the dbschema.cmake + # If one select one of these option as group + # we want the group name to match instead of the actual group it belongs to + if(MODULE_GROUP_NAME STREQUAL "ALL" + OR MODULE_GROUP_NAME STREQUAL "DEFAULT" + OR MODULE_GROUP_NAME STREQUAL "STANDARD" + OR MODULE_GROUP_NAME STREQUAL "COMMON" + ) + set(group_name + "${MODULE_GROUP_NAME}" + PARENT_SCOPE + ) + return() + endif() # message(WARNING "groups to search in" ${MODULE_GROUP_PACKAGE_GROUPS}) # Get all variable names in the current CMake context foreach(group IN LISTS MODULE_GROUP_PACKAGE_GROUPS) @@ -776,6 +790,8 @@ function(find_group_name module) "${group}" PARENT_SCOPE ) + return() endif() endforeach() + message((STATUS "module ${module} not found in any group")) endfunction()

1 0

git:master:0fb18272: cmake: Add missing package KSTANDARD
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 0fb182720428b276793899debb210279a0b5ec97 URL: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T11:10:13Z cmake: Add missing package KSTANDARD - When `ALL_PACKAGED` is used, KSTANDARD should be built as well, but not KMINI which is a subset of it. - Fix RTP_MEDIA group name --- Modified: cmake/groups.cmake --- Diff: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… Patch: https://github.com/kamailio/kamailio/commit/0fb182720428b276793899debb21027… --- diff --git a/cmake/groups.cmake b/cmake/groups.cmake index 90c47413d22..a41560f17fc 100644 --- a/cmake/groups.cmake +++ b/cmake/groups.cmake @@ -688,6 +688,7 @@ set(MODULE_GROUP_KRTP_MEDIA_SERVER ${MOD_LIST_RTP_MEDIA_SERVER}) set(STATIC_MODULES "") set(MODULE_GROUP_PACKAGE_GROUPS + KSTANDARD KPCRE KMYSQL KPOSTGRES @@ -748,7 +749,7 @@ set(MODULE_GROUP_PACKAGE_GROUPS KNGHTTP2 KGCRYPT KSECSIPID - KRT_MEDIA_SERVER + KRTP_MEDIA_SERVER ) # Add group names to available group and provide "ALL_PACKAGED" as well

1 0

5.7.7 release, tag and docker build
by Henning Westerholt 23 May '25

23 May '25

Hello, I have noticed that the git tag for release 5.7.7 was missing, I've just set it. The 5.7.7-bullseye docker image is also missing from https://github.com/kamailio/kamailio-docker/pkgs/container/kamailio Not sure if this is done automatically, if not - please can somebody please trigger the workflow to create it? Thank you, Henning

2 3

git:master:2ec8ddba: cmake: Move prefix/suffix calculation back.
by Xenofon Karamanos 23 May '25

23 May '25

Module: kamailio Branch: master Commit: 2ec8ddba5eeaeea1c7292d1aa56ed90dc834341e URL: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-05-23T10:56:50Z cmake: Move prefix/suffix calculation back. - Prefix depends on each table name.. - Fix postgress with correct install folder..... --- Modified: cmake/dbschema.cmake --- Diff: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… Patch: https://github.com/kamailio/kamailio/commit/2ec8ddba5eeaeea1c7292d1aa56ed90… --- diff --git a/cmake/dbschema.cmake b/cmake/dbschema.cmake index 17528d83ed0..dcd7bb0645b 100644 --- a/cmake/dbschema.cmake +++ b/cmake/dbschema.cmake @@ -50,26 +50,13 @@ function(add_db_target db_name xsl_file) # For consistency, we are now using the new names. # For compatibility with tools, we are still using the old names for install folder - # Determine the prefix/suffix - if(db_name STREQUAL "db_berkeley" - OR db_name STREQUAL "db_redis" - OR db_name STREQUAL "db_text" - OR db_name STREQUAL "db_mongodb" - ) - set(prefix '') - set(folder_suffix "${MAIN_NAME}") - else() - set(prefix "${table}-") - set(folder_suffix '') - endif() - # install folder based on db_name if(db_name STREQUAL "db_mongodb") set(install_folder "mongodb") elseif(db_name STREQUAL "db_mysql") set(install_folder "mysql") elseif(db_name STREQUAL "db_postgres") - set(install_folder "mysql") + set(install_folder "postgres") elseif(db_name STREQUAL "db_text") set(install_folder "dbtext") else() @@ -79,6 +66,19 @@ function(add_db_target db_name xsl_file) # Loop through each table and add a command for xsltproc foreach(table ${EXTRACTED_TABLES}) + # Determine the prefix/suffix + if(db_name STREQUAL "db_berkeley" + OR db_name STREQUAL "db_redis" + OR db_name STREQUAL "db_text" + OR db_name STREQUAL "db_mongodb" + ) + set(prefix '') + set(folder_suffix "${MAIN_NAME}") + else() + set(prefix "${table}-") + set(folder_suffix '') + endif() + # Stringparam db is the db_* module name add_custom_command( TARGET dbschema_${db_name}

1 0

[kamailio/kamailio] wip: pua_reginfo: add helper to disable publishing for current message (PR #4253)
by Matteo 23 May '25

23 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4252 #### Description This PR adds a new helper `reginfo_disable_publish` to `pua_reginfo` module which disabled the publishing for the current message, which is useful to control when to actually send it or not (eg in DMQ replication scenarios). The helper is "negative" (it *disables* not enables) on purpose in order to mantain backward compatibility to current behaviour. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4253 -- Commit Summary -- * pua_reginfo: add helper to disable publishing for current message -- File Changes -- M src/modules/pua_reginfo/pua_reginfo.c (4) M src/modules/pua_reginfo/pua_reginfo.h (4) M src/modules/pua_reginfo/usrloc_cb.c (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4253.patch https://github.com/kamailio/kamailio/pull/4253.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4253 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4253(a)github.com>

2 6

[kamailio/kamailio] PDB: add RPC command to get and set PDB query timeout (PR #4254)
by Muhammad Shahzad Shafi 23 May '25

23 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4254 -- Commit Summary -- * pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout -- File Changes -- M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4254 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4254(a)github.com>

2 1

[kamailio/kamailio] Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module with high concurrency (Issue #4209)
by Henning Westerholt 23 May '25

23 May '25

henningw created an issue (kamailio/kamailio#4209) Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module. ### Environment: The systems are using 32 Kamailio worker processes for the relevant network interface, Its also using Prometheus counter increment operations more than 30 times in the cfg during INVITE processing. The Kamailio uses otherwise no database or other IO related services. Kamailio version 5.8.3, but no relevant changes in the xhttp_prom module could be found. ### Quick summary of the findings: Multiple systems showed frequent hangs in their Kamailio servers on a customer setup. It happens usually after a few hours that all Kamailio processes gets blocked, and no more traffic can be processed on the respective system. I have analysed three stack traces of the Kamailio on one of the system that showed the behaviour. Two without problems and one that was created from during a period where the server had problems. ### Details: Here some details of the stack traces from a problematic case. The relevant processes are from PID 494551 to 494582. The majority of all of these processes are blocked in paths related to the Prometheus module (PID 494551 to 494576): #### PID 494551: ``` #1 0x00007fc69ea5f053 in futex_get (lock=0x7fc4a147acd0) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #2 0x00007fc69ea70f99 in prom_counter_inc (s_name=0x7fffe339ffa0, number=1, l1=0x7fffe339ff90, l2=0x0, l3=0x0) at prom_metric.c:1154 p = 0x6b __func__ = "prom_counter_inc" […] #14 0x00000000005ab179 in receive_msg (buf=0x9f47e0 <buf> "INVITE [sip:+1YYYYYYY737@10.XXX.XXX107](sip:+1YYYYYYYYYY737@10.XXX.XX.107) SIP/2.0\r\nRecord-Route: [sip:10.1XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3](sip:10.XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3)\r\nRecord-Route: [sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F](sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F)\r\nRecord-R"..., len=2819, rcv_info=0x7fffe33a28d0) at core/receive.c:518 ``` Most of the worker processes are in the same state as shown above. Some of the processes are also working in other Prometheus related operations: #### PID 494554: ``` #0 prom_metric_timeout_delete (p_m=0x7fc49ea102f0) at prom_metric.c:646 current = 0x7fc4a2810fd0 ts = 1744143945433 __func__ = "prom_metric_timeout_delete" l = 0x7fc4abffc808 #1 0x00007fc69ea676ce in prom_metric_list_timeout_delete () at prom_metric.c:668 p = 0x7fc49ea102f0 ``` ### Problem hypothesis: My hypothesis is that the hang is caused from lock contention around the Prometheus module. The relevant code uses only one lock, and this together with the extensive usage of the increment counters probably causes this issues under high load. The majority of the worker processed are occupied in the Prometheus path and are not working on SIP packets. This will cause of course an increase of the UDP queue and the described problems. In order to test this hypothesis we removed temporarily the Prometheus logic in the kamailio cfg and see if the issue still persists. The issue did not showed up again after two days of testing, when before it was observed after a few hours. ### Possible solutions: The Prometheus module probably needs some improvements to support better high-load and concurrency situations. On common approach is to split the locks, e.g. using a per process lock array and then combining the individual values in a second pass when read from outside. Alternatively the xhttp_prom module should be used only carefully in situations with a high concurrency setup. I have the full backtrace available, if helpful just let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4209 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4209(a)github.com>

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev