25 Apr
2024
25 Apr
'24
8:02 p.m.
@miconda commented on this pull request.
}
static int ki_statsd_decr_with_labels(sip_msg_t *msg, str *key, str *labels) { - return statsd_count(key->s, "-1", labels->s); + return convert_result(statsd_count(key->s, "-1", labels->s)); +} + +static int convert_result(bool result) +{ + if(result == false) { + return -1; + } + + return 0;
Shouldn't the above line be `return 1`? Or I misunderstood the purpose.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3819#pullrequestreview-2023469703
You are receiving this because you are subscribed to this thread.
Message ID: kamailio/kamailio/pull/3819/review/2023469703@github.com