Re: [sr-dev] garbage in outgoing sip request

On Oct 15, 2009 at 18:21, Juha Heinanen jh@tutpro.com wrote:

Juha Heinanen writes:

...

what do you mean by that, because there are many sr and k modules that use various fixup_free functions?

i went and reverted this sr_module.c commit. after that the garbage that i have been seeing in outgoing sip request disappeared.

so this patch definitely has something to do with the problem.

Yes, it did have something to do with it: turns out the fixup_spve* functions wrongly freed the contents of a fixed spve, which included the original string. You did not see the bug before, because the original string was not freed (memleak). It should be fixed now.

Andrei