[sr-dev] Re: [kamailio/kamailio] Topos: Added Call-ID mask (PR #3334)

@toharish commented on this pull request. } } dialog = (get_to(&msg)->tag_value.len>0)?1:0; - if(dialog) { - /* dialog request */ - tps_request_received(&msg, dialog); - } + + tps_request_received(&msg, dialog); + yes, it's required to mask the Call-ID for the inial Request. Please refer to the changes in tps_msg.c function tps_request_received where it is masking the Call-ID and then returning back when dialog=0 ``` if(dialog==0) { tps_mask_callid(msg); /* nothing to do for initial request other than Call-ID mask */ return 0; } ``` This could have been done by checking (dialog==0) and calling tps_mask_callid(msg) directly in topos_mod.c insted of calling tps_request_received(&msg, dialog). Any Request which is entered from the Upstream Call-ID mask is done Any Request which is sent to Upstream Call-ID Un-mask is done Any response which is entered from the Upstream Call-ID mask is done Any response which is sent to Upstream Call-ID Un-mask is done -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3334#discussion_r1084415204 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3334/review/1266135078(a)github.com>