Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
The diff has a lot of formatting changes, did you run clang-format or you did them manually?
New features should be made as a clean PR, without formatting changes, because it is hard to follow up what is new and what is reformatting, you also relocated some lines, adding to the volume of the changes.
Reformatting PR's are also welcome, but they have to be done separately, so one knows it is not about behavioural changes. But not that clang-format should be used at the end to ensure coherency.
Can you split the PR in two, one with the new feature and the second with formatting/relocating changes?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.