The logging macros make use of GCC (and compatible) variadic macros. While there are ifdefs for Solaris Studio using C99 variadic macros, they don't compile and seem to be suffering from bit rot.

There are a couple ways to address this:

• rebase and fix the ifdef __SUNPRO_C portion which would introduce no changes for the GCC build but would have more longterm maintenance overhead
• replace the GCC extensions and ifdefs with C99 compliant ones which would not be as readable and require a few hacks to prevent trailing commas in the case of zero arguments. This would remove the code maintenance burden and make the macros more portable.

I'll be happy to submit a pull request for either approach.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.