Few more things that need to be done:

• the commit message must have the format as per guidelines at:
  • http://www.kamailio.org/wiki/devel/github-contributions#commit_message_format
• this patch seems to just copy a lot of code from topoh module to sipcapture. It means that if there is a change in topoh, it needs to be resync'ed in sipcapture. This is not the right way to do. Better export an intermodule API in topoh and bind to that one from sipcapture. In this way, the code and parameters from topoh will be used by sipcapture. Sipcapture should get a new module parameter to control if it should bind or not to topoh.

You can look at sl module how it exports some functions (modules/sl/sl.h, the sl_api_t structure and the sl_load_api() function) and then at registrar module how it binds to sl in mod_init() and use sl functions.

—
Reply to this email directly or view it on GitHub.