Re: [sr-dev] [kamailio/kamailio] dialog: update event route statistics (#2243)

Indeed, this needs a bit more explanation. Check out this function flow: ``` dlg_onreply() -> dlg_run_event_route() -> dlg_lookup() -> if (dlg0 == 0) ``` When dlg_run_event_route() fails (returns -1) then dlg_onreply() just returns. Now, in the same dlg_onreply() at line 571, the statistics are updated in case of new_state==DLG_STATE_DELETED. However, because of the above, this code is not called if dlg_run_event_route() fails. Most probably I should update this pull request to increment also the failed dialogs, as done in dlg_onreply() at line 585. Let me know if this clarifies your questions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2243#issuecomment-597044476