Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@henningw commented on this pull request.
@petermarianF Thank you for integrating all the comments and sorry for the delay. I've added two more comments, which are probably some minor things.
In src/modules/ims_usrloc_pcscf/udomain.h:
> @@ -82,5 +83,7 @@ int update_security(udomain_t* _d, security_type _t, security_t* _s, struct pcon int update_temp_security(udomain_t* _d, security_type _t, security_t* _s, struct pcontact* _c); int preload_udomain(db1_con_t* _c, udomain_t* _d); - +int audit_usrloc_expired_pcontacts(udomain_t* _d); +int db_load_pcontact(udomain_t* _d, str *_aor, int insert_cache, struct pcontact** _c, pcontact_info_t* contact_info); +int db_delete_presentityuri_from_pua(str *presentity_uri);
This probably can be removed as well, as there is no implementation.
In src/modules/ims_usrloc_pcscf/usrloc_db.c:
> @@ -301,7 +307,7 @@ int db_insert_pcontact(struct pcontact* _c) SET_PROPER_NULL_FLAG(_c->rinstance, values, LP_RINSTANCE_IDX); SET_PROPER_NULL_FLAG(_c->rx_session_id, values, LP_RX_SESSION_ID_IDX); - VAL_DOUBLE(GET_FIELD_IDX(values, LP_REG_STATE_IDX)) = _c->reg_state; + VAL_INT(GET_FIELD_IDX(values, LP_REG_STATE_IDX)) = _c->reg_state;
Why you are changing this from double to int?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.