@Fr-Soltanzadeh commented on this pull request.
typedef struct rtpengine_api
{
rtpengine_start_recording_f start_recording;
rtpengine_answer_f answer;
rtpengine_offer_f offer;
- rtpengine_delete_f delete;
+ rtpengine_delete_f _delete;
Thanks for the review. I added the underscore to delete to avoid potential conflicts with
the delete keyword in C++. While this code is written in C, there's a possibility that
it might be included in a C++ project in the future. Using _delete ensures compatibility
and prevents any issues if that happens. If you think it's unnecessary, I'm happy
to revert it, but I thought it was a safer choice to avoid potential problems.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3956#discussion_r1734027030
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3956/review/2265206893(a)github.com>