[sr-dev] [kamailio/kamailio] Common style of CMakeLists.txt for modules (Issue #4081)

I noticed at least two styles of CMakeLists.txt for modules: ``` ❯ cat src/modules/acc/CMakeLists.txt file(GLOB acc_SRC "*.c") add_library(acc SHARED ${acc_SRC}) ``` and ``` ❯ cat src/modules/xlog/CMakeLists.txt file(GLOB SRC_FILES "*.c") add_library(xlog SHARED ${SRC_FILES}) # # target_link_libraries(.*PRIVATE) ``` Which one should be used? The one with `modname_SRC` (e.g., `acc_SRC`) or the one with `SRC_FILES`? Also, I guess that the comment with `target_link_libraries()` can be removed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4081 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4081(a)github.com>