1 Aug
2011
1 Aug
'11
9:04 p.m.
On Monday 01 August 2011, Iñaki Baz Castillo wrote:
2011/8/1 Henning Westerholt
<henning.westerholt(a)1und1.de>de>:
Hi Iñaki,
ok, understand. I think we should not introduce two functions with similar
names and the same behaviour in two modules. Even worse, both use different
implementations (table matching vs. ragel parser). So one commit should be
reverted.
A generic is_rfc1918 function in ipops would be nice, but the nathelper module
also needs this test internally. What about move one of the parsers to the
library dir, and then just including it from both modules?
Best regards,
Henning
i saw that you just commited it. Does the new
function does implement the
same functionality as the one in nathelper?
Basically yes, it allows passing an string or pv and returns true if
the given IP is a private IP according to RFC 1918.
I think it's useful to also have this function in ipops module as no
all the deployments require nathelper features, but of course maybe
other people don't think the same.