15 Jul
2019
15 Jul
'19
9:22 p.m.
@tdimitrov I started the review yesterday as announced here, but got caught by some other
urgent topic. This is a quite large patch in the end. There was no need to rush this into
the repository.
There exists many white-space issues where the code uses a complete different indention as
the existing code (e.g. ims_ipsec_pcscf_mod.c). There are also several commented out code
blocks which should be probably removed as well (src/modules/ims_ipsec_pcscf/ipsec.c). I
will have a look to fix the most noticeable cases.
If you like to merge a big patch like this in the future, please spend some time to review
the code to catch this obvious issues before.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2001#issuecomment-511514584