Description

tm module writes a misleading log error that triggers ops alerts.

Troubleshooting

Reproduction

using this partial script

event_route[core:worker-one-init]
{
    async_route("DEFERRED_CLEANUP", "20");
}

route[DEFERRED_CLEANUP]
{
  xlog("L_INFO", "processing deferred cleanup\n");
}

Log Messages

2018-11-15T19:22:44.547049+00:00 apps001 kamailio[2105]: INFO: <script>: processing deferred cleanup
2018-11-15T19:22:44.554085+00:00 apps001 kamailio[2105]: ERROR: tm [t_reply.c:551]: _reply_light(): no resolved dst to send reply to

Possible Solutions

i silence the error with the below patch but i'm pretty sure its not the proper way to do it.

diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c
index 8a95fe7..99c59db 100644
--- a/src/modules/tm/t_reply.c
+++ b/src/modules/tm/t_reply.c
@@ -548,7 +548,9 @@
 	 * the chances for this increase a lot.
 	 */
 	if (unlikely(!trans->uas.response.dst.send_sock)) {
-		LM_ERR("no resolved dst to send reply to\n");
+		if(is_local(trans)) {
+			LM_ERR("no resolved dst to send reply to\n");
+		}
 	} else {
 		if (likely(SEND_PR_BUFFER( rb, buf, len )>=0)){
 			if (unlikely(code>=200 && !is_local(trans) &&

Additional Information

version: kamailio 5.3.0-dev0 (x86_64/linux) 37bff4-dirty
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.

Linux 2.6.32-754.el6.x86_64 #1 SMP Tue Jun 19 21:26:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.