[sr-dev] [kamailio/kamailio] Kamailio 5.2 / ims_registrar_scscf's NOTIFY message on registration (#2692)

Hi When I register to my IMS core (Kamailio version 5.2), ims_registrar_scscf modul sends notification with XML body showing all contacts with expires "0". I noticed that , in ims_registrar_scscf module, the notify_subscribers function is as shown below: ``` int notify_subscribers(impurecord_t* impurecord, str *explit_dereg_contact, int num_explit_dereg_contact) { event_reg(0, impurecord, IMS_REGISTRAR_CONTACT_UNREGISTERED, 0, 0, explit_dereg_contact, num_explit_dereg_contact); return 0; } ``` IMS_REGISTRAR_CONTACT_UNREGISTERED parameter is hardcoded. I noticed that in upper version of Kamailio this changed like that: ``` int notify_subscribers(impurecord_t* impurecord, ucontact_t* contact, str *explit_dereg_contact, int num_explit_dereg_contact, int event_type) { event_reg(0, impurecord, contact, event_type, 0, 0, 0, explit_dereg_contact, num_explit_dereg_contact); return 0; } ``` Also noticed that in upper version of Kamailio notify_subscribers is only called on de-registration. But in version 5.2 it is called on registration and re-registration also. (This leads strange cases) Could you please advise on this issue? Best regards Erhan ### Troubleshooting #### Reproduction <!-- If the issue can be reproduced, describe how it can be done. --> #### Debugging Data <!-- If you got a core dump, use gdb to extract troubleshooting data - full backtrace, local variables and the list of the code at the issue location. gdb /path/to/kamailio /path/to/corefile bt full info locals list If you are familiar with gdb, feel free to attach more of what you consider to be relevant. --> ``` (paste your debugging data here) ``` #### Log Messages <!-- Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). --> ``` (paste your log messages here) ``` #### SIP Traffic <!-- If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). --> ``` (paste your sip traffic here) ``` ### Possible Solutions <!-- If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix. --> ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [stack@ims-test2 ~]$ /usr/local/sbin/kamailio -v version: kamailio 5.2.0 (x86_64/linux) 40c16b ``` * **Operating System**: <!-- Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...; Kernel details (output of `uname -a`) --> ``` [stack@ims-test2 ~]$ uname -a Linux ims-test2.novalocal 3.10.0-1062.1.1.el7.x86_64 #1 SMP Fri Sep 13 22:55:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2692