Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
From my point of view after a very brief code review, it is fine to merge.
I do have a comment, though. I would suggest to prefix global variables with some value specific to the module, like (ims_qos_ or _ims_qos_, e.g., _ims_qos_suspend_transaction) because there might be cases when global variables become exposed across modules or core and when they have rather common words then it can result in duplicates and conflicts. IMS modules might not have such common prefix to global variables yet, but it would be good to start doing it, at least for the newly added variables. This can be done as a follow up commit after merging this PR.
The name of the exposed modparam can stay the same, it is only about the C variable name.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.