[sr-dev] Re: [kamailio/kamailio] Add timer to ping rtpengine (PR #4016)

@stefan-mititelu-idt commented on this pull request. return 1; } if(force == 0) { + /* If ping_interval is set, the timer will ping and test + the rtps. No need to do something during routing */ + if(rtpengine_ping_interval > 0) + return 1; I think rtpp_test_ping() and rtpp_test() are very similar, except rtpp_test() skips sending the actual ping in some cases. Definitely first one can replace the second one when force pinging is required (maybe additionally checking manually disabled rtpengines before calling it -> RTPENGINE_MAX_RECHECK_TICKS) I think, a much more simpler change would be the previous one suggested. So pings will happen additionally, besides the timer pings, only when they are force pings. I wonder if you see any problems with it, that I am missing? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4016#discussion_r1838377890 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4016/review/2430052970(a)github.com>