sure . Its long back pull request. i need to check whether those comments incorporated or not.
On Sat, May 5, 2018 at 1:07 PM, Daniel-Constantin Mierla < notifications@github.com> wrote:
There was a discussion on mailing lists (sr-dev and sr-users) started in February with the subject "RFC: db_redisusrloc module - review and how to deal with" - can you follow up on that thread, some people had comments and it is better that you express your point of view.
I haven't checked yet, but there were some comments/reviews on code for initial PR #1422 https://github.com/kamailio/kamailio/pull/1422, have you dealt with them in this PR?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1446#issuecomment-386786987, or mute the thread https://github.com/notifications/unsubscribe-auth/AGb9UQObnq5JAKSibvEUuUEj7t9ivmohks5tvVaqgaJpZM4SJS1k .