No problem, Victor!

Our Kamailio CI job is happy again! :)

https://github.com/sippy/voiptests/actions/runs/5663713633

-Max
P.S. On the subject of that commit, I really doubt it increased the quality
of the code. Replacing the library function with a hand-rolled equivalent
just to silence the static analyzer is not only pointless exercise (if the
buffer overflows, it would still overflow) but also prone to introducing
new bugs as this encounter has proven, I hope.

On Wed, Jul 26, 2023 at 6:05 AM Victor Seva ***@***.***>
wrote:

> My bad, added fixes for my commits. thanks @sobomax
> <https://github.com/sobomax> !
>
> commit 192b681ce7fcd868a4a47a7c26863c733321b8d4 (HEAD -> master, origin/master, origin/HEAD)
> Author: Victor Seva ***@***.***>
> Date: Wed Jul 26 15:00:38 2023 +0200
>
> sipcapture: make sure we null terminate the copy of the string
>
> bug introduced at cbd7810fff3d5145c1ce34c0e362b5590bb92a12
>
> commit 3c1700fb7693c05025be1058e856fe610f4be031
> Author: Victor Seva ***@***.***>
> Date: Wed Jul 26 14:53:26 2023 +0200
>
> rtpproxy: make sure we null terminate the copy of the string.
>
> bug introduced at d00ceda2c04
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/kamailio/kamailio/pull/3524#issuecomment-1651767068>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABVMJWFD5SLCAMK3VU4ONLXSEIYXANCNFSM6AAAAAA2XRKA3Y>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

--
Maksym Sobolyev
Sippy Software, Inc.
Internet Telephony (VoIP) Experts
Tel (Canada): +1-778-783-0474
Tel (Toll-Free): +1-855-747-7779
Fax: +1-866-857-6942
Web: http://www.sippysoft.com
MSN: ***@***.***
Skype: SippySoft

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.