[sr-dev] git:master:91596953: sdpops: safety check when location a= line not to exceed end of message

Module: kamailio Branch: master Commit: 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285 URL: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… Author: Daniel-Constantin Mierla &lt;miconda(a)gmail.com&gt; Committer: Daniel-Constantin Mierla &lt;miconda(a)gmail.com&gt; Date: 2015-02-23T14:29:46+01:00 sdpops: safety check when location a= line not to exceed end of message --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… Patch: https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… --- diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 3357bb2..2a4aa6b 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -159,12 +159,17 @@ static int mod_init(void) int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) { char *p; + char *bend; + p = pos; while(*p!='\n') p--; aline->s = p + 1; p = pos; - while(*p!='\n') p++; + bend = msg->buf+msg->len; + while(*p!='\n' && p<bend) p++; aline->len = p - aline->s + 1; + if(unlikely(p==bend)) aline->len--; + return 0; }