Hello Juha,
The rtcp port was computed only if an rtcp attibute was present in the
received SDP.
Since rtpproxy daemon will always allocate an RTCP port = RTP port +
1, I simplified insert_candidates() signature and computed each port
inside.
See commit 2e58de7e16203c849cf1c445dfb33d304ffd3507.
Regards,
Ovidiu Sas
--
VoIP Embedded, Inc.
http://www.voipembedded.com
On Fri, Feb 15, 2013 at 7:11 PM, Ovidiu Sas <osas(a)voipembedded.com> wrote:
Hello Juha,
The relay candidate is added only for RTP stream, but not for RTCP stream.
Example:
received SDP:
v=0.
o=- 3569961501 3569961501 IN IP4 192.168.2.104.
s=cpc_med.
c=IN IP4 192.168.2.104.
t=0 0.
m=audio 53528 RTP/AVP 0 101.
a=sendrecv.
a=rtpmap:0 PCMU/8000.
a=rtpmap:101 telephone-event/8000.
a=fmtp:101 0-15.
a=ice-ufrag:3d6687c0.
a=ice-pwd:165a6dbe.
a=candidate:Hc0a80268 1 UDP 2130706431 192.168.2.104 53528 typ host.
a=candidate:Hc0a80268 2 UDP 2130706430 192.168.2.104 49908 typ host.
sent SDP:
v=0.
o=- 3569961501 3569961501 IN IP4 192.168.2.2.
s=cpc_med.
c=IN IP4 192.168.2.2.
t=0 0.
m=audio 11070 RTP/AVP 0 101.
a=sendrecv.
a=rtpmap:0 PCMU/8000.
a=rtpmap:101 telephone-event/8000.
a=fmtp:101 0-15.
a=ice-ufrag:3d6687c0.
a=ice-pwd:165a6dbe.
a=candidate:Hc0a80268 1 UDP 2130706431 192.168.2.104 53528 typ host.
a=candidate:19216822 1 UDP 16777215 192.168.2.2 11070 typ relay.
a=candidate:Hc0a80268 2 UDP 2130706430 192.168.2.104 49908 typ host.
We should have an extra candidate:
a=candidate:19216822 1 UDP 16777215 192.168.2.2 11071 typ relay.
rtpproxy will allocate an extra port for RTCP traffic (RTP port + 1).
Regards,
Ovidiu Sas
--
VoIP Embedded, Inc.
http://www.voipembedded.com
On Wed, Jan 2, 2013 at 6:08 AM, Juha Heinanen <jh(a)tutpro.com> wrote:
> Module: sip-router
> Branch: master
> Commit: 75fde552f1c4cdea736baa72ff1aa36e527e0215
> URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=75fde55…
>
> Author: Juha Heinanen <jh(a)tutpro.com>
> Committer: Juha Heinanen <jh(a)tutpro.com>
> Date: Wed Jan 2 13:00:31 2013 +0200
>
> modules/rtpproxy: rtpproxy_manage can now add ice relay candidates
>
> - The feature is activated by defining ice_candidate_priority_avp module
> parameter.
>
> ---
>
> modules/rtpproxy/README | 149 ++++++++++++++++++-------------
> modules/rtpproxy/doc/rtpproxy_admin.xml | 28 ++++++
> modules/rtpproxy/rtpproxy.c | 139 ++++++++++++++++++++++++++++-
> 3 files changed, 250 insertions(+), 66 deletions(-)
>
> Diff:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=75f…
>